October 2023 - Open Build Service Commits

[openSUSE/osc] 0d239c: Change NoPBTextMeter to display no output at all
by Daniel Mach 13 Oct '23

13 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 0d239cc2656f4999d339e730da85ff20a85e8929 https://github.com/openSUSE/osc/commit/0d239cc2656f4999d339e730da85ff20a85e… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M osc/meter.py Log Message: ----------- Change NoPBTextMeter to display no output at all Commit: 0c2cafe5138bc15d1361cfbd1996c8a30ef9e409 https://github.com/openSUSE/osc/commit/0c2cafe5138bc15d1361cfbd1996c8a30ef9… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M osc/meter.py Log Message: ----------- Merge pull request #1433 from dmach/NoPBTextMeter-no-output Change NoPBTextMeter to display no output at all Compare: https://github.com/openSUSE/osc/compare/2aa7c17331a7...0c2cafe5138b

1 0

[openSUSE/osc] 53968b: Fix retrieving a password in case a function retur...
by Daniel Mach 13 Oct '23

13 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 53968bf91c25a16cc927335e3cabeae65b1206d4 https://github.com/openSUSE/osc/commit/53968bf91c25a16cc927335e3cabeae65b12… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M osc/conf.py Log Message: ----------- Fix retrieving a password in case a function returns another callable Commit: 2aa7c17331a73a3e894cc0c509e4d5893c999c1d https://github.com/openSUSE/osc/commit/2aa7c17331a73a3e894cc0c509e4d5893c99… Author: Daniel Mach <daniel.mach(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M osc/conf.py Log Message: ----------- Merge pull request #1431 from dmach/fix-keyring-keyutils-callable-password Fix retrieving a password in case a function returns another callable Compare: https://github.com/openSUSE/osc/compare/225fea0e0661...2aa7c17331a7

1 0

[openSUSE/open-build-service] 278860: Reduce cyclomatic complexity of CommentPolicy#reply?
by Jacob Michalskie 13 Oct '23

13 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 27886047360b0a445bd8ddc2ed800b44ab79a0e0 https://github.com/openSUSE/open-build-service/commit/27886047360b0a445bd8d… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M src/api/app/policies/comment_policy.rb Log Message: ----------- Reduce cyclomatic complexity of CommentPolicy#reply? Commit: 66a4b5140e98ec23870875839f76d40e960bb451 https://github.com/openSUSE/open-build-service/commit/66a4b5140e98ec2387087… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M src/api/app/policies/comment_policy.rb Log Message: ----------- Merge pull request #15060 from hellcp-work/reply-lint Reduce cyclomatic complexity of CommentPolicy#reply? Compare: https://github.com/openSUSE/open-build-service/compare/595a869a6d42...66a4b…

1 0

[openSUSE/open-build-service] 989656: Don't display the comment field when the comments ...
by Jacob Michalskie 13 Oct '23

13 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 989656a2d35d67b8ff3a3018035fcd63d789f1f8 https://github.com/openSUSE/open-build-service/commit/989656a2d35d67b8ff3a3… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M src/api/app/controllers/webui/comments_controller.rb M src/api/app/policies/comment_policy.rb M src/api/app/views/webui/comment/_new.html.haml Log Message: ----------- Don't display the comment field when the comments are locked Commit: 97eec663590c84a2c74936c5229c8a28699d96f9 https://github.com/openSUSE/open-build-service/commit/97eec663590c84a2c7493… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M src/api/app/models/comment_locking_validator.rb M src/api/app/policies/comment_policy.rb Log Message: ----------- Expand the conditions for what qualifies as locked Maintainers, admins, moderators and staff should always be able to comment, and we want the package locks to be covered by project locks and request action locks to be covered by request locks Commit: eec0076aa5e45b03e2f02f354cbe2e200021a554 https://github.com/openSUSE/open-build-service/commit/eec0076aa5e45b03e2f02… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M src/api/app/models/comment_locking_validator.rb M src/api/app/policies/comment_lock_policy.rb M src/api/app/policies/comment_policy.rb M src/api/app/views/webui/comment/_new.html.haml Log Message: ----------- Allow maintainers, admins, moderators and staff to comment Also make sure to still display the message about the comments being locked Commit: e624603bc708c478d4a07238a555ff3961d39fc8 https://github.com/openSUSE/open-build-service/commit/e624603bc708c478d4a07… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M src/api/app/models/comment_locking_validator.rb M src/api/app/policies/comment_policy.rb Log Message: ----------- Make sure the user exists before checking if they are a maintainer There are scenarios in which comments are created without a User.session present, like creating comments in factories Commit: 595a869a6d4285963ef2a0ec7f67645e815bb2fe https://github.com/openSUSE/open-build-service/commit/595a869a6d4285963ef2a… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M src/api/app/controllers/webui/comments_controller.rb M src/api/app/models/comment_locking_validator.rb M src/api/app/policies/comment_lock_policy.rb M src/api/app/policies/comment_policy.rb M src/api/app/views/webui/comment/_new.html.haml Log Message: ----------- Merge pull request #15053 from hellcp-work/comment-locking-policy Don't display the comment field when the comments are locked Compare: https://github.com/openSUSE/open-build-service/compare/3e475d495001...595a8…

1 0

[openSUSE/open-build-service] 58960c: Increase length limit of URL to upload a file
by Marvin Friedrich 13 Oct '23

13 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 58960c8836feabaf8483a90b723bfa8d850a1b84 https://github.com/openSUSE/open-build-service/commit/58960c8836feabaf8483a… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M src/api/app/views/webui/packages/files/new.html.haml Log Message: ----------- Increase length limit of URL to upload a file Commit: 3e475d4950011202e8403cea7cabca5bdd706a4a https://github.com/openSUSE/open-build-service/commit/3e475d4950011202e8403… Author: Marvin Friedrich <144036628+mfriedrichgh(a)users.noreply.github.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M src/api/app/views/webui/packages/files/new.html.haml Log Message: ----------- Merge pull request #15059 from eduardoj/fix/issue_14544_2 Increase length limit of URL to upload a file Compare: https://github.com/openSUSE/open-build-service/compare/caccada6e8a2...3e475…

1 0

[openSUSE/open-build-service] fe5185: Add maximum length validation for package url
by Marvin Friedrich 13 Oct '23

13 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: fe51856de0d2a78b957d05b1a566b0398132377f https://github.com/openSUSE/open-build-service/commit/fe51856de0d2a78b957d0… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M src/api/.database_consistency.todo.yml M src/api/app/models/package.rb Log Message: ----------- Add maximum length validation for package url Commit: caccada6e8a28af8b5d01eb7f4a1b7d1644abe5f https://github.com/openSUSE/open-build-service/commit/caccada6e8a28af8b5d01… Author: Marvin Friedrich <144036628+mfriedrichgh(a)users.noreply.github.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M src/api/.database_consistency.todo.yml M src/api/app/models/package.rb Log Message: ----------- Merge pull request #15058 from eduardoj/fix/issue_14544 Add maximum length validation for package url Compare: https://github.com/openSUSE/open-build-service/compare/3cb3a0a906a2...cacca…

1 0

[openSUSE/open-build-service] f90d5c: Handle invalid request token operation values
by Eduardo J. 13 Oct '23

13 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f90d5cb4defa13f51ab9006fee8c87fcbc06670f https://github.com/openSUSE/open-build-service/commit/f90d5cb4defa13f51ab90… Author: ncounter <dleidi(a)suse.com> Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M src/api/app/controllers/person/token_controller.rb Log Message: ----------- Handle invalid request token operation values Commit: 3cb3a0a906a2c3a8239ac6020bee5c59fa2589fb https://github.com/openSUSE/open-build-service/commit/3cb3a0a906a2c3a8239ac… Author: Eduardo J <enavarro(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M src/api/app/controllers/person/token_controller.rb Log Message: ----------- Merge pull request #14979 from ncounter/token-vs-rss-token Handle invalid request token operation values Compare: https://github.com/openSUSE/open-build-service/compare/2e94ad7699a8...3cb3a…

1 0

[openSUSE/open-build-service] 8c1f21: Stop setting options that are already default, II
by Eduardo J. 13 Oct '23

13 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8c1f217064727b0f4062326af50c56d5e4b12353 https://github.com/openSUSE/open-build-service/commit/8c1f217064727b0f40623… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/staging/staged_requests_controller.rb M src/api/app/controllers/staging/staging_controller.rb M src/api/app/controllers/status/required_checks_controller.rb Log Message: ----------- Stop setting options that are already default, II `errorcode` has a default value when `status` is `404`. Stop setting those options all over the app to their defaults again. Commit: 2e94ad7699a8cd6f4651c802bb61fd3d828c9867 https://github.com/openSUSE/open-build-service/commit/2e94ad7699a8cd6f4651c… Author: Eduardo J <enavarro(a)suse.com> Date: 2023-10-13 (Fri, 13 Oct 2023) Changed paths: M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/staging/staged_requests_controller.rb M src/api/app/controllers/staging/staging_controller.rb M src/api/app/controllers/status/required_checks_controller.rb Log Message: ----------- Merge pull request #15056 from eduardoj/refactoring/stop_setting_options_ii Stop setting options that are already default, II Compare: https://github.com/openSUSE/open-build-service/compare/004d2ff1f9ce...2e94a…

1 0

[openSUSE/open-build-service] fe39e7: Update rubocop to version 1.57.0
by Bernhard M. Wiedemann 12 Oct '23

12 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: fe39e78c26740405dee13e277eb06bb589d517b2 https://github.com/openSUSE/open-build-service/commit/fe39e78c26740405dee13… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-1.56.4.gem A src/api/vendor/cache/rubocop-1.57.0.gem Log Message: ----------- Update rubocop to version 1.57.0 Commit: 9ff069037c6f964dd01334fa7117e77588936862 https://github.com/openSUSE/open-build-service/commit/9ff069037c6f964dd0133… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M src/api/.rubocop_todo.yml Log Message: ----------- Regenerate RuboCop TODO file for rails subdirectory Commit: 9c6e1357cb986c6f1915e25fdebd74982c74cbb1 https://github.com/openSUSE/open-build-service/commit/9c6e1357cb986c6f1915e… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M src/api/.rubocop_todo.yml M src/api/spec/services/diff_parser_spec.rb Log Message: ----------- Autocorrect RuboCop Style/SingleLineDoEndBlock offenses Commit: 9e6112d3ec452bbae4571c27eb10130f1ba015e9 https://github.com/openSUSE/open-build-service/commit/9e6112d3ec452bbae4571… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/policies/bs_request_policy.rb Log Message: ----------- Correct RuboCop Style/RedundantFilterChain offense Commit: 004d2ff1f9ce1331a01e266163522d6da2e2591d https://github.com/openSUSE/open-build-service/commit/004d2ff1f9ce1331a01e2… Author: Bernhard M. Wiedemann <bwiedemann(a)suse.de> Date: 2023-10-12 (Thu, 12 Oct 2023) Changed paths: M src/api/.rubocop_todo.yml M src/api/Gemfile.lock M src/api/app/policies/bs_request_policy.rb M src/api/spec/services/diff_parser_spec.rb R src/api/vendor/cache/rubocop-1.56.4.gem A src/api/vendor/cache/rubocop-1.57.0.gem Log Message: ----------- Merge pull request #15054 from openSUSE/depfu/update/srcapi/rubocop-1.57.0 [src/api] Update rubocop 1.56.4 → 1.57.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/5d1073c1a2b5...004d2…

1 0

[openSUSE/open-build-service]
by Bernhard M. Wiedemann 12 Oct '23

12 Oct '23

Branch: refs/heads/depfu/update/srcapi/rubocop-1.57.0 Home: https://github.com/openSUSE/open-build-service

1 0