October 2023 - Open Build Service Commits

[openSUSE/open-build-service] 2170e9: Collect set flag step artifacts
by Rubhan Azeem 26 Oct '23

26 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2170e96ec2dc8d81edd2031391e03467bb708c3f https://github.com/openSUSE/open-build-service/commit/2170e96ec2dc8d81edd20… Author: Rubhan Azeem <rubhanazeem(a)gmail.com> Date: 2023-10-26 (Thu, 26 Oct 2023) Changed paths: M src/api/app/components/workflow_artifacts_per_step_component.rb M src/api/app/services/workflows/artifacts_collector.rb Log Message: ----------- Collect set flag step artifacts Commit: 5b0380828548b8d81f4e9a87a461fc668420c3f2 https://github.com/openSUSE/open-build-service/commit/5b0380828548b8d81f4e9… Author: Rubhan Azeem <rubhanazeem(a)gmail.com> Date: 2023-10-26 (Thu, 26 Oct 2023) Changed paths: M src/api/lib/tasks/dev/workflows.rake M src/api/spec/factories/workflow_artifacts_per_step.rb M src/api/spec/services/workflows/artifacts_collector_spec.rb Log Message: ----------- Add specs for set_flag step artifacts collection Commit: cfe9121d0dbee5e2643f88278e6ad0f226a1898f https://github.com/openSUSE/open-build-service/commit/cfe9121d0dbee5e2643f8… Author: Rubhan Azeem <rubhanazeem(a)gmail.com> Date: 2023-10-26 (Thu, 26 Oct 2023) Changed paths: M src/api/app/components/workflow_artifacts_per_step_component.rb M src/api/app/services/workflows/artifacts_collector.rb M src/api/lib/tasks/dev/workflows.rake M src/api/spec/factories/workflow_artifacts_per_step.rb M src/api/spec/services/workflows/artifacts_collector_spec.rb Log Message: ----------- Merge pull request #15085 from rubhanazeem/artifacts-set-flag Collect artifacts for set flag step Compare: https://github.com/openSUSE/open-build-service/compare/4f002a515760...cfe91…

1 0

[openSUSE/open-build-service] 634be1: Make use of `update_as_failed` method to update ...
by Dani Donisa 26 Oct '23

26 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 634be12c62a6bc073a3ff3b4e25039286fdf0559 https://github.com/openSUSE/open-build-service/commit/634be12c62a6bc073a3ff… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M src/api/app/models/workflow_run.rb Log Message: ----------- Make use of `update_as_failed` method to update ... ... WorkflowRun status Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Commit: ae9f0f633a9fe043e4c9748a15be204b1c4a80df https://github.com/openSUSE/open-build-service/commit/ae9f0f633a9fe043e4c97… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M src/api/app/models/event/base.rb A src/api/app/models/event/workflow_run_fail.rb M src/api/app/models/workflow_run.rb M src/api/spec/models/workflow_run_spec.rb Log Message: ----------- Create WorkflowRunFail event Also, handle the creation of the event on an after_save callback. Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Commit: ed1480f3f3e121513a2d4a593868ce086e68b6ca https://github.com/openSUSE/open-build-service/commit/ed1480f3f3e121513a2d4… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M src/api/app/models/event_subscription.rb M src/api/app/models/event_subscription/for_channel_form.rb Log Message: ----------- Add new event to subscriptions page Only enabled for web channel temporarily. Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: 10ac44b1dabfcebca1a292f2d0b28b95e9a9388b https://github.com/openSUSE/open-build-service/commit/10ac44b1dabfcebca1a29… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/components/notification_avatars_component.rb M src/api/app/components/notification_component.html.haml M src/api/app/components/notification_component.rb M src/api/app/components/notification_excerpt_component.rb M src/api/app/components/notification_notifiable_link_component.rb A src/api/app/components/workflow_run_status_badge_component.rb M src/api/app/models/event/workflow_run_fail.rb M src/api/app/models/workflow_run.rb A src/api/app/queries/outdated_notifications_finder/workflow_run.rb M src/api/app/services/notification_service/notifier.rb M src/api/app/services/notification_service/web_channel.rb M src/api/app/services/notified_projects.rb Log Message: ----------- Introduce notifications for WorkflowRunFail event Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: f8888dd924913e6465983e752c212be2bf711959 https://github.com/openSUSE/open-build-service/commit/f8888dd924913e6465983… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M src/api/lib/tasks/dev/workflows.rake Log Message: ----------- Adapt task to subscribe users to WorkflowRunFail Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: f5a6ffd501d59ec939599ea6d8ffc28aa47f0bfe https://github.com/openSUSE/open-build-service/commit/f5a6ffd501d59ec939599… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M src/api/app/components/notification_filter_component.html.haml M src/api/app/components/notification_filter_component.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/queries/notifications_finder.rb Log Message: ----------- Add notification filter for WorkflowRunFail Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: 363e05bca1c8e7b6f559bdc62659d962e171b6de https://github.com/openSUSE/open-build-service/commit/363e05bca1c8e7b6f559b… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M src/api/app/components/workflow_run_row_component.rb Log Message: ----------- Use WorkflowRun#formatted_event_source_name The method is going to be used in the component and other parts of the code, so the definition has been moved to the model. Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: 88ad76b7714ff6d65672036dc815fd1c36380a2f https://github.com/openSUSE/open-build-service/commit/88ad76b7714ff6d656720… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: A src/api/spec/models/event/workflow_run_fail_spec.rb Log Message: ----------- Add spec for token_executor receiver role Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: 4f002a51576096d87b4d098f903dc524262b16db https://github.com/openSUSE/open-build-service/commit/4f002a51576096d87b4d0… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-10-26 (Thu, 26 Oct 2023) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/components/notification_avatars_component.rb M src/api/app/components/notification_component.html.haml M src/api/app/components/notification_component.rb M src/api/app/components/notification_excerpt_component.rb M src/api/app/components/notification_filter_component.html.haml M src/api/app/components/notification_filter_component.rb M src/api/app/components/notification_notifiable_link_component.rb M src/api/app/components/workflow_run_row_component.rb A src/api/app/components/workflow_run_status_badge_component.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/models/event/base.rb A src/api/app/models/event/workflow_run_fail.rb M src/api/app/models/event_subscription.rb M src/api/app/models/event_subscription/for_channel_form.rb M src/api/app/models/workflow_run.rb M src/api/app/queries/notifications_finder.rb A src/api/app/queries/outdated_notifications_finder/workflow_run.rb M src/api/app/services/notification_service/notifier.rb M src/api/app/services/notification_service/web_channel.rb M src/api/app/services/notified_projects.rb M src/api/lib/tasks/dev/workflows.rake A src/api/spec/models/event/workflow_run_fail_spec.rb M src/api/spec/models/workflow_run_spec.rb Log Message: ----------- Merge pull request #15084 from eduardoj/feature/workflow_run_failed_notifications Get notified about failed WorkflowRuns Compare: https://github.com/openSUSE/open-build-service/compare/e261a408a499...4f002…

1 0

[openSUSE/open-build-service] 4c3bda: [dist] fix can't not get full hostname in function...
by Frank Schreiner 26 Oct '23

26 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4c3bdadc8bf32f1dbd2e9972b5dcc2b644ea4991 https://github.com/openSUSE/open-build-service/commit/4c3bdadc8bf32f1dbd2e9… Author: YangMame <yangmame(a)icloud.com> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M dist/functions.setup-appliance.sh Log Message: ----------- [dist] fix can't not get full hostname in functions such as abc.site.com Commit: e261a408a499e6e1b933822f0e9a107b9c21cda7 https://github.com/openSUSE/open-build-service/commit/e261a408a499e6e1b9338… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2023-10-26 (Thu, 26 Oct 2023) Changed paths: M dist/functions.setup-appliance.sh Log Message: ----------- Merge pull request #14900 from YangMame/master [dist] fix can not get full hostname in functions such as abc.site.com Compare: https://github.com/openSUSE/open-build-service/compare/660e5d99e506...e261a…

1 0

[openSUSE/open-build-service] 6ead23: Enforce the presence of a package name in trigger#...
by Dani Donisa 25 Oct '23

25 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6ead23864ea01340416a62eb416f7fbee06a3a66 https://github.com/openSUSE/open-build-service/commit/6ead23864ea01340416a6… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M src/api/app/controllers/trigger/errors.rb M src/api/app/controllers/trigger_controller.rb M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Enforce the presence of a package name in trigger#create For the operations rebuild, release and runservice Fixes #12813 Commit: 660e5d99e50695664e4c6102fde50fabdfb88230 https://github.com/openSUSE/open-build-service/commit/660e5d99e50695664e4c6… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M src/api/app/controllers/trigger/errors.rb M src/api/app/controllers/trigger_controller.rb M src/api/spec/controllers/trigger_controller_spec.rb Log Message: ----------- Merge pull request #15115 from dmarcoux/issue-12813 Enforce the presence of a package name in trigger#create Compare: https://github.com/openSUSE/open-build-service/compare/cd6c23ca2549...660e5…

1 0

[openSUSE/open-build-service]
by Dani Donisa 25 Oct '23

25 Oct '23

Branch: refs/heads/make-runservice-token-usage-consistent Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] a1693c: Reduce number of lines of a method
by Dany Marcoux 25 Oct '23

25 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a1693cf98c7c68396b2123d952c32fbcab1c006e https://github.com/openSUSE/open-build-service/commit/a1693cf98c7c68396b212… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M src/api/app/components/notification_action_description_component.rb Log Message: ----------- Reduce number of lines of a method This way we comply with the requirements of codeclimate. Commit: cd6c23ca2549cd307488bda903079dec8e6f863c https://github.com/openSUSE/open-build-service/commit/cd6c23ca2549cd307488b… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M src/api/app/components/notification_action_description_component.rb Log Message: ----------- Merge pull request #15110 from eduardoj/refactoring/reduce_lines_of_method Reduce number of lines of `call` method Compare: https://github.com/openSUSE/open-build-service/compare/9c9cea506f0c...cd6c2…

1 0

[openSUSE/open-build-service] ebb0a5: Remove the WorkflowRuns with unsupported events
by Jacob Michalskie 25 Oct '23

25 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ebb0a5621bee51b3b5f144d55003027990e55923 https://github.com/openSUSE/open-build-service/commit/ebb0a5621bee51b3b5f14… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-10-23 (Mon, 23 Oct 2023) Changed paths: A src/api/db/data/20231023110428_remove_unsupported_hook_events.rb M src/api/db/data_schema.rb Log Message: ----------- Remove the WorkflowRuns with unsupported events Commit: 9c9cea506f0cb0baecf74d73897ae288142e5c00 https://github.com/openSUSE/open-build-service/commit/9c9cea506f0cb0baecf74… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: A src/api/db/data/20231023110428_remove_unsupported_hook_events.rb M src/api/db/data_schema.rb Log Message: ----------- Merge pull request #15092 from hellcp-work/delete_wrong_workflowruns Remove the WorkflowRuns with unsupported events Compare: https://github.com/openSUSE/open-build-service/compare/f19206e6176b...9c9ce…

1 0

[openSUSE/open-build-service] 92b825: Simplify Project.find_package
by Dani Donisa 25 Oct '23

25 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 92b8251ffdc2ca0025a88a12b9fbf78d4330875a https://github.com/openSUSE/open-build-service/commit/92b8251ffdc2ca0025a88… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M src/api/app/models/linked_project.rb M src/api/app/models/package.rb M src/api/app/models/project.rb Log Message: ----------- Simplify Project.find_package - LinkedProject scope to be able ignore remote project links - Introduces update_project to explicitly avoid the update_instance_or_self trap - Introduces check_access? instance method, the class method is doing things we've already done while instantiating Commit: f19206e6176b885460c956aedb2b448b3b5f9075 https://github.com/openSUSE/open-build-service/commit/f19206e6176b885460c95… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-10-25 (Wed, 25 Oct 2023) Changed paths: M src/api/app/models/linked_project.rb M src/api/app/models/package.rb M src/api/app/models/project.rb Log Message: ----------- Merge pull request #15099 from hennevogel/refactoring/project_find_package Simplify Project.find_package Compare: https://github.com/openSUSE/open-build-service/compare/09105fba356a...f1920…

1 0

[openSUSE/open-build-service] 960c88: Use speaking variable names
by Henne Vogelsang 24 Oct '23

24 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 960c88d55d315b3db1af14573639f08ff1bb1e2d https://github.com/openSUSE/open-build-service/commit/960c88d55d315b3db1af1… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M src/api/app/models/package.rb Log Message: ----------- Use speaking variable names - package -> package_name - pkg -> package - project -> project_name_or_object - prj -> project Commit: 09105fba356a3ce89a5a0b99ebc688a9454e0e52 https://github.com/openSUSE/open-build-service/commit/09105fba356a3ce89a5a0… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M src/api/app/models/package.rb Log Message: ----------- Merge pull request #15112 from hennevogel/refactoring/package_get_by_project_and_name Use speaking variable names Compare: https://github.com/openSUSE/open-build-service/compare/648f739865d0...09105…

1 0

[openSUSE/open-build-service] 6f85f7: Make the token naming consistent
by Dani Donisa 24 Oct '23

24 Oct '23

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6f85f733fa9bfbbe606b6165c4e4220e7b8e826e https://github.com/openSUSE/open-build-service/commit/6f85f733fa9bfbbe606b6… Author: ddonisa <ddonisa(a)localhost.localdomain> Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M src/api/app/views/person/token/index.xml.builder Log Message: ----------- Make the token naming consistent Because when we create the token, we have to tell the token is of type=runservice, but when we ask about the tokens a user has, we get that same token as kind=service instead. Commit: 648f739865d071f7ea4b3440dec8a0a56155c8cc https://github.com/openSUSE/open-build-service/commit/648f739865d071f7ea4b3… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2023-10-24 (Tue, 24 Oct 2023) Changed paths: M src/api/app/views/person/token/index.xml.builder Log Message: ----------- Merge pull request #15109 from danidoni/make-runservice-token-usage-consistent Make the token naming consistent Compare: https://github.com/openSUSE/open-build-service/compare/0a1d36ccc116...648f7…

1 0