July 2022 - Open Build Service Commits

[openSUSE/open-build-service] 1c4272: [api] sanities permission check
by Dany Marcoux 19 Jul '22

19 Jul '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1c4272040062ce1dc1b683215cb5638802644cde https://github.com/openSUSE/open-build-service/commit/1c4272040062ce1dc1b68… Author: Adrian Schröter <adrian(a)reiser.suse.de> Date: 2022-07-19 (Tue, 19 Jul 2022) Changed paths: M src/api/app/controllers/source_controller.rb Log Message: ----------- [api] sanities permission check only because you can not write to project (may exist and be locked) it does not mean you can create it when you have write access on the upper level. Commit: 980b0dbb399bcf96232bedb8d33432e42635fee1 https://github.com/openSUSE/open-build-service/commit/980b0dbb399bcf96232be… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-07-19 (Tue, 19 Jul 2022) Changed paths: M src/api/app/controllers/source_controller.rb Log Message: ----------- Merge pull request #12824 from adrianschroeter/fix_project_copy [api] sanities permission check Compare: https://github.com/openSUSE/open-build-service/compare/3e96060cf10f...980b0…

1 0

[openSUSE/open-build-service] 182fb5: Downgrade nokogiri from 1.13.7 back to 1.13.6
by Dani Donisa 19 Jul '22

19 Jul '22

Branch: refs/heads/2.10 Home: https://github.com/openSUSE/open-build-service Commit: 182fb59cfa440b2f2e760f57bb0c6021cd9849f8 https://github.com/openSUSE/open-build-service/commit/182fb59cfa440b2f2e760… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2022-07-19 (Tue, 19 Jul 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Downgrade nokogiri from 1.13.7 back to 1.13.6 While [upgrading rails](https://github.com/openSUSE/open-build-service/pull/12801) to 5.2.8.1 we pulled in a new version of nokogiri that requires ruby >= 2.6.0. We don't want to upgrade ruby right now, so we downgrade nokogiri back to the version we already had before the rails upgrade. Commit: 533e43dabf7944ec62807089a102b1b2624b764c https://github.com/openSUSE/open-build-service/commit/533e43dabf7944ec62807… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2022-07-19 (Tue, 19 Jul 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #12825 from danidoni/downgrade-nokogiri-1.13.7 Downgrade nokogiri from 1.13.7 back to 1.13.6 Compare: https://github.com/openSUSE/open-build-service/compare/f0fbf5ab5411...533e4…

1 0

[openSUSE/open-build-service] b42c18: Allow /public access to files with spaces
by Lukas Krause 18 Jul '22

18 Jul '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b42c1838ba6fcc0b650aa87c5ebdfcb014cc4380 https://github.com/openSUSE/open-build-service/commit/b42c1838ba6fcc0b650aa… Author: Stephan Kulow <coolo(a)suse.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: M src/api/app/controllers/public_controller.rb Log Message: ----------- Allow /public access to files with spaces controller has it's own usage of CGI.escape not ported. So use the model method available to build the path. Commit: 3e96060cf10f6c9ab704e035f1b2e9ccc08d9180 https://github.com/openSUSE/open-build-service/commit/3e96060cf10f6c9ab704e… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: M src/api/app/controllers/public_controller.rb Log Message: ----------- Merge pull request #12820 from coolo/fix_public Allow /public access to files with spaces Compare: https://github.com/openSUSE/open-build-service/compare/ed668e1d489c...3e960…

1 0

[openSUSE/open-build-service] ec8db3: Retire shared_examples 'require logged in user'
by Dany Marcoux 18 Jul '22

18 Jul '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ec8db399ff20089d9b0be61328a89a2103540787 https://github.com/openSUSE/open-build-service/commit/ec8db399ff20089d9b0be… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/1_2_1.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/sets_flash_error_message.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/when_proxy_auth_mode_off/1_2_1_3_1.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/when_proxy_auth_mode_on/1_2_1_4_1.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/when_request_is_xhr/returns_Please_login_error.yml M src/api/spec/controllers/webui/cloud/azure/configurations_controller_spec.rb M src/api/spec/controllers/webui/staging/projects_controller_spec.rb M src/api/spec/controllers/webui/staging/workflows_controller_spec.rb M src/api/spec/controllers/webui/status_messages_controller_spec.rb M src/api/spec/controllers/webui/users/notifications_controller_spec.rb M src/api/spec/controllers/webui/users/patchinfos_controller_spec.rb M src/api/spec/controllers/webui/users/rss_tokens_controller_spec.rb M src/api/spec/controllers/webui/users/subscriptions_controller_spec.rb M src/api/spec/controllers/webui/users/tasks_controller_spec.rb M src/api/spec/controllers/webui/users_controller_spec.rb R src/api/spec/support/shared_examples/require_logged_in_user.rb Log Message: ----------- Retire shared_examples 'require logged in user' Make sure we use verify_authorized in a callback. Commit: ed668e1d489c7a0ebf4fbd64da2fc7d82cf234cf https://github.com/openSUSE/open-build-service/commit/ed668e1d489c7a0ebf4fb… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/1_2_1.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/sets_flash_error_message.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/when_proxy_auth_mode_off/1_2_1_3_1.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/when_proxy_auth_mode_on/1_2_1_4_1.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/when_request_is_xhr/returns_Please_login_error.yml M src/api/spec/controllers/webui/cloud/azure/configurations_controller_spec.rb M src/api/spec/controllers/webui/staging/projects_controller_spec.rb M src/api/spec/controllers/webui/staging/workflows_controller_spec.rb M src/api/spec/controllers/webui/status_messages_controller_spec.rb M src/api/spec/controllers/webui/users/notifications_controller_spec.rb M src/api/spec/controllers/webui/users/patchinfos_controller_spec.rb M src/api/spec/controllers/webui/users/rss_tokens_controller_spec.rb M src/api/spec/controllers/webui/users/subscriptions_controller_spec.rb M src/api/spec/controllers/webui/users/tasks_controller_spec.rb M src/api/spec/controllers/webui/users_controller_spec.rb R src/api/spec/support/shared_examples/require_logged_in_user.rb Log Message: ----------- Merge pull request #12823 from hennevogel/refactoring/retire-shared_examples Retire shared_examples 'require logged in user' Compare: https://github.com/openSUSE/open-build-service/compare/04c77050a0f1...ed668…

1 0

[openSUSE/open-build-service]
by Dani Donisa 18 Jul '22

18 Jul '22

Branch: refs/tags/2.10.17 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] 1f936c: Don't copy sources when branching a scmsynced package
by Lukas Krause 18 Jul '22

18 Jul '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1f936c9c8d94cae835affe06cb23857a7798c09f https://github.com/openSUSE/open-build-service/commit/1f936c9c8d94cae835aff… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: M src/api/app/models/branch_package.rb Log Message: ----------- Don't copy sources when branching a scmsynced package Commit: 4f41c6dd253ae43876939bdc53b77553b09960f6 https://github.com/openSUSE/open-build-service/commit/4f41c6dd253ae43876939… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: M src/api/app/models/workflow/step.rb M src/api/app/models/workflow/step/branch_package_step.rb Log Message: ----------- Add support for scmsynced packages and projects to branch_package step Commit: 48f38c6246b3f80f57398bc1c47eb91f1b2b1094 https://github.com/openSUSE/open-build-service/commit/48f38c6246b3f80f57398… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: M src/api/app/models/workflow/step/link_package_step.rb Log Message: ----------- Add support for scmsynced packages and projects to link_package step Commit: 560a269edc40d12a9b864758e7ca77a2218c1b88 https://github.com/openSUSE/open-build-service/commit/560a269edc40d12a9b864… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: M src/api/app/models/workflow/step.rb M src/api/app/models/workflow/step/branch_package_step.rb M src/api/app/models/workflow/step/link_package_step.rb Log Message: ----------- Reduce cyclomatic complexity for branch_package and link_package method Commit: 80228a01f6ef43028d0b64fc69e063feff01fde3 https://github.com/openSUSE/open-build-service/commit/80228a01f6ef43028d0b6… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: A src/api/app/models/concerns/scm_sync_enabled_step.rb M src/api/app/models/workflow/step.rb M src/api/app/models/workflow/step/branch_package_step.rb M src/api/app/models/workflow/step/link_package_step.rb Log Message: ----------- Extract scmsync related methods for workflow steps to a concern Commit: d714980783e09f9a704cd5a653d4acafb7350909 https://github.com/openSUSE/open-build-service/commit/d714980783e09f9a704cd… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_8_2_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_8_2_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_8_2_3.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_8_2_4.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_8_2_5.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_8_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_8_1_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_8_1_3.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_8_1_4.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_8_1_5.yml M src/api/spec/models/workflow/step/branch_package_step_spec.rb Log Message: ----------- Add specs for scmsynced packages and projects in branch package step Commit: 525c1fa1729016b17032f0c040cfd93312cd9b9e https://github.com/openSUSE/open-build-service/commit/525c1fa1729016b17032f… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_7_2_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_7_2_2.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_7_2_3.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_7_2_4.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_7_2_5.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_7_1_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_7_1_2.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_7_1_3.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_7_1_4.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_7_1_5.yml M src/api/spec/models/workflow/step/link_package_step_spec.rb Log Message: ----------- Add specs for scmsynced packages and projects in link package step Commit: 04c77050a0f17cc677cadf900144d2ca575d6266 https://github.com/openSUSE/open-build-service/commit/04c77050a0f17cc677cad… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: M src/api/app/models/branch_package.rb A src/api/app/models/concerns/scm_sync_enabled_step.rb M src/api/app/models/workflow/step.rb M src/api/app/models/workflow/step/branch_package_step.rb M src/api/app/models/workflow/step/link_package_step.rb A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_8_2_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_8_2_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_8_2_3.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_8_2_4.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_8_2_5.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_8_1_1.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_8_1_2.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_8_1_3.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_8_1_4.yml A src/api/spec/cassettes/Workflow_Step_BranchPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_8_1_5.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_7_2_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_7_2_2.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_7_2_3.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_7_2_4.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_package_level/1_1_1_7_2_5.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_7_1_1.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_7_1_2.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_7_1_3.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_7_1_4.yml A src/api/spec/cassettes/Workflow_Step_LinkPackageStep/_call/when_the_SCM_is_GitHub/when_scmsync_is_active/on_project_level/1_1_1_7_1_5.yml M src/api/spec/models/workflow/step/branch_package_step_spec.rb M src/api/spec/models/workflow/step/link_package_step_spec.rb Log Message: ----------- Merge pull request #12784 from krauselukas/scm_integration/add_scm_sync_support Add scmsync to OBS SCM/CI integration Compare: https://github.com/openSUSE/open-build-service/compare/1bd69a7f79d3...04c77…

1 0

[openSUSE/open-build-service]
by Dani Donisa 18 Jul '22

18 Jul '22

Branch: refs/tags/2.10.17 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] c1a7b1: Introduces commit_opts[:login] for delete_on_backend
by Dani Donisa 18 Jul '22

18 Jul '22

Branch: refs/heads/2.10 Home: https://github.com/openSUSE/open-build-service Commit: c1a7b122eebfc6046408aa13bae592a8ff3de036 https://github.com/openSUSE/open-build-service/commit/c1a7b122eebfc6046408a… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/project.rb Log Message: ----------- Introduces commit_opts[:login] for delete_on_backend And uses this from BsRequestActionDelete. Before we have relied on User.run_as in BsRequest.auto_accept to set User.session (which is a Thread/fiber-local variable). But in an `after_commit` callback this is not working reliably. Maybe a race or something with nested transactions or whatnot. Couldn't figure it out... Commit: 8f090393df52a8d0a9b97bb7df072eff4b61c1b7 https://github.com/openSUSE/open-build-service/commit/8f090393df52a8d0a9b97… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: A ReleaseNotes-2.10.17 Log Message: ----------- Update release notes for 2.10.17 Commit: f0fbf5ab54113b7a5854d50e80a8446dfd8695b0 https://github.com/openSUSE/open-build-service/commit/f0fbf5ab54113b7a5854d… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: A ReleaseNotes-2.10.17 M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/project.rb Log Message: ----------- Merge pull request #12821 from danidoni/backport-after-destroy-commit-bugfix Introduces commit_opts[:login] for delete_on_backend Compare: https://github.com/openSUSE/open-build-service/compare/e663e1a3f283...f0fbf…

1 0

[openSUSE/open-build-service] b58165: Send only exception class name to metrics
by Dany Marcoux 18 Jul '22

18 Jul '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b58165b21dd882b8ed7df3d1765d3af80b64fcae https://github.com/openSUSE/open-build-service/commit/b58165b21dd882b8ed7df… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: M src/api/app/services/github_status_reporter.rb M src/api/app/services/gitlab_status_reporter.rb Log Message: ----------- Send only exception class name to metrics The interpolation (or #to_s) of an Exception object uses the exception message, if any, otherwise the class name. We want the class name only. Commit: 1bd69a7f79d347b4585d552ad2d6b7a4c6e2c155 https://github.com/openSUSE/open-build-service/commit/1bd69a7f79d347b4585d5… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: M src/api/app/services/github_status_reporter.rb M src/api/app/services/gitlab_status_reporter.rb Log Message: ----------- Merge pull request #12822 from saraycp/exception-class Send only exception class name to metrics Compare: https://github.com/openSUSE/open-build-service/compare/e3e02cca9c2d...1bd69…

1 0

[openSUSE/open-build-service] e11632: Allow users to manage their own home project and i...
by Dany Marcoux 18 Jul '22

18 Jul '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e1163244b7daa91737c319fe11c0d643e7a31801 https://github.com/openSUSE/open-build-service/commit/e1163244b7daa91737c31… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: M src/api/app/models/user.rb M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/sets_the_package.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/sets_the_project.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_not_passing_the_rev_parameter/and_passing_the_page_parameter/returns_the_paginated_revisions_for_the_page_parameter_s_value.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_not_passing_the_rev_parameter/and_passing_the_show_all_parameter/returns_revisions_without_pagination.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_not_passing_the_rev_parameter/returns_revisions_with_the_default_pagination.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_passing_the_rev_parameter/and_passing_the_page_parameter/returns_the_paginated_revisions_for_the_page_parameter_s_value.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_passing_the_rev_parameter/and_passing_the_show_all_parameter/returns_revisions_up_to_rev_parameter_s_value_without_pagination.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_passing_the_rev_parameter/returns_revisions_up_to_rev_parameter_s_value_with_the_default_pagination.yml A src/api/spec/cassettes/Webui_PackageController/GET_revisions/without_source_access/1_6_1_1.yml A src/api/spec/cassettes/Webui_PackageController/GET_revisions/without_source_access/1_6_1_2.yml R src/api/spec/cassettes/Webui_PackageController/GET_revisions/without_source_access/1_7_1_1.yml R src/api/spec/cassettes/Webui_PackageController/GET_revisions/without_source_access/1_7_1_2.yml M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Allow users to manage their own home project and its packages This is needed since users sometimes remove themselves from the maintainers of their own home project. It should have never been possible in the first place for users to do this, but here we are. It was quite confusing to users since they could still see the `Create Package` or `Add User` actions, but they were never authorized to do those actions. They should have been able to do them though. This is now addressed. For now, we can help users by applying this fix. This code from the custom authorization system is called in Pundit, so both authorization systems (custom and Pundit) are covered. Another important change here is that nothing can prevent a user from managing their home project or a package in their home project. As an example, it was previously possible to prevent users from accessing the source of their home project by setting `sourceaccess` to `disable` in the local permissions. Fixes #10067 Commit: e3e02cca9c2df8ad3b8b4827592e788902b19635 https://github.com/openSUSE/open-build-service/commit/e3e02cca9c2df8ad3b8b4… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-07-18 (Mon, 18 Jul 2022) Changed paths: M src/api/app/models/user.rb M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/sets_the_package.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/sets_the_project.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_not_passing_the_rev_parameter/and_passing_the_page_parameter/returns_the_paginated_revisions_for_the_page_parameter_s_value.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_not_passing_the_rev_parameter/and_passing_the_show_all_parameter/returns_revisions_without_pagination.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_not_passing_the_rev_parameter/returns_revisions_with_the_default_pagination.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_passing_the_rev_parameter/and_passing_the_page_parameter/returns_the_paginated_revisions_for_the_page_parameter_s_value.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_passing_the_rev_parameter/and_passing_the_show_all_parameter/returns_revisions_up_to_rev_parameter_s_value_without_pagination.yml M src/api/spec/cassettes/Webui_PackageController/GET_revisions/with_source_access/when_passing_the_rev_parameter/returns_revisions_up_to_rev_parameter_s_value_with_the_default_pagination.yml A src/api/spec/cassettes/Webui_PackageController/GET_revisions/without_source_access/1_6_1_1.yml A src/api/spec/cassettes/Webui_PackageController/GET_revisions/without_source_access/1_6_1_2.yml R src/api/spec/cassettes/Webui_PackageController/GET_revisions/without_source_access/1_7_1_1.yml R src/api/spec/cassettes/Webui_PackageController/GET_revisions/without_source_access/1_7_1_2.yml M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Merge pull request #12808 from dmarcoux/permissions-home-project Allow users to manage their own home project and its packages Compare: https://github.com/openSUSE/open-build-service/compare/c8f9b642478e...e3e02…

1 0