April 2022 - Open Build Service Commits

[openSUSE/open-build-service]
by Henne Vogelsang 13 Apr '22

13 Apr '22

Branch: refs/heads/depfu/update/srcapi-2.10/nokogiri-1.13.4 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] f44d5b: Update nokogiri to version 1.13.4
by Henne Vogelsang 13 Apr '22

13 Apr '22

Branch: refs/heads/2.10 Home: https://github.com/openSUSE/open-build-service Commit: f44d5b4121e9db836bd9e8aecc1c8146125d4012 https://github.com/openSUSE/open-build-service/commit/f44d5b4121e9db836bd9e… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update nokogiri to version 1.13.4 Commit: 4cfae4c02b9b88a9d10a3a45ddf97958c70c819e https://github.com/openSUSE/open-build-service/commit/4cfae4c02b9b88a9d10a3… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update sanitize to version 6.0.0 Commit: 75d09df2f3b1d5ceae04b488226b540d99c4da3d https://github.com/openSUSE/open-build-service/commit/75d09df2f3b1d5ceae04b… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/app/models/kiwi/image/xml_builder.rb M src/api/spec/models/kiwi/image_spec.rb Log Message: ----------- Fix broken specs in Kiwi::Image model Two specs were failing when checking if the subject didn't have errors: ``` Failure/Error: it { expect(subject.errors).to be_empty } expected `[#<Nokogiri::XML::SyntaxError: 1:12: FATAL: XML declaration allowed only at the start of the document>].empty?` to be truthy, got false ./spec/models/kiwi/image_spec.rb:226:in `block (5 levels) in <top (required)>' Failure/Error: expect(subject.errors).to be_empty expected `[#<Nokogiri::XML::SyntaxError: 1:12: FATAL: XML declaration allowed only at the start of the document>].empty?` to be truthy, got false ./spec/models/kiwi/image_spec.rb:279:in `block (4 levels) in <top (required)>' ``` Those errors weren't reported before nokogiri _1.13.0_, as noted in the changelog upstream: > XML::DocumentFragment#errors now correctly contains any parsing errors > encountered. Previously this was always empty. (Note that > HTML::DocumentFragment#errors already did this.) Relying on XML::DocumentFragment was wrong since the XML generated by the Kiwi::Image's to_xml and kiwi_body methods is not a document fragment, but a document. They contain a XML declaration (`<?xml ...?>`), so changing the class solves the issue. Commit: 173849c522f6d9f720f67941f62065d7544fcef1 https://github.com/openSUSE/open-build-service/commit/173849c522f6d9f720f67… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/Gemfile.lock M src/api/app/models/kiwi/image/xml_builder.rb M src/api/spec/models/kiwi/image_spec.rb Log Message: ----------- Merge pull request #12432 from openSUSE/depfu/update/srcapi-2.10/nokogiri-1.13.4 🚨 [security] [src/api - 2.10] Update nokogiri: 1.11.7 → 1.13.4 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/0218ebd4231e...17384…

1 0

[openSUSE/open-build-service] e0bc4c: Remove `report_to_scm` method from workflow step m...
by Henne Vogelsang 13 Apr '22

13 Apr '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e0bc4c749ce2998e6b108ad97d6e437269a23a14 https://github.com/openSUSE/open-build-service/commit/e0bc4c749ce2998e6b108… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/app/models/workflow/step.rb Log Message: ----------- Remove `report_to_scm` method from workflow step model The method isn't called anywhere, seems to be a left over. Commit: 93bb86d5516ab48f20fb91b05cc1487745e74f97 https://github.com/openSUSE/open-build-service/commit/93bb86d5516ab48f20fb9… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/app/models/workflow/step.rb Log Message: ----------- Merge pull request #12439 from krauselukas/remove_report_to_scm_method Remove `report_to_scm` method from workflow step model Compare: https://github.com/openSUSE/open-build-service/compare/543d1960dd63...93bb8…

1 0

[openSUSE/open-build-service] 75d09d: Fix broken specs in Kiwi::Image model
by Dany Marcoux 13 Apr '22

13 Apr '22

Branch: refs/heads/depfu/update/srcapi-2.10/nokogiri-1.13.4 Home: https://github.com/openSUSE/open-build-service Commit: 75d09df2f3b1d5ceae04b488226b540d99c4da3d https://github.com/openSUSE/open-build-service/commit/75d09df2f3b1d5ceae04b… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/app/models/kiwi/image/xml_builder.rb M src/api/spec/models/kiwi/image_spec.rb Log Message: ----------- Fix broken specs in Kiwi::Image model Two specs were failing when checking if the subject didn't have errors: ``` Failure/Error: it { expect(subject.errors).to be_empty } expected `[#<Nokogiri::XML::SyntaxError: 1:12: FATAL: XML declaration allowed only at the start of the document>].empty?` to be truthy, got false ./spec/models/kiwi/image_spec.rb:226:in `block (5 levels) in <top (required)>' Failure/Error: expect(subject.errors).to be_empty expected `[#<Nokogiri::XML::SyntaxError: 1:12: FATAL: XML declaration allowed only at the start of the document>].empty?` to be truthy, got false ./spec/models/kiwi/image_spec.rb:279:in `block (4 levels) in <top (required)>' ``` Those errors weren't reported before nokogiri _1.13.0_, as noted in the changelog upstream: > XML::DocumentFragment#errors now correctly contains any parsing errors > encountered. Previously this was always empty. (Note that > HTML::DocumentFragment#errors already did this.) Relying on XML::DocumentFragment was wrong since the XML generated by the Kiwi::Image's to_xml and kiwi_body methods is not a document fragment, but a document. They contain a XML declaration (`<?xml ...?>`), so changing the class solves the issue.

1 0

[openSUSE/open-build-service] 4cfae4: Update sanitize to version 6.0.0
by Henne Vogelsang 13 Apr '22

13 Apr '22

Branch: refs/heads/depfu/update/srcapi-2.10/nokogiri-1.13.4 Home: https://github.com/openSUSE/open-build-service Commit: 4cfae4c02b9b88a9d10a3a45ddf97958c70c819e https://github.com/openSUSE/open-build-service/commit/4cfae4c02b9b88a9d10a3… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update sanitize to version 6.0.0

1 0

[openSUSE/open-build-service]
by Henne Vogelsang 13 Apr '22

13 Apr '22

Branch: refs/heads/depfu/update/srcapi-2.10/yajl-ruby-1.4.2 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] c872ce: Update yajl-ruby to version 1.4.2
by Henne Vogelsang 13 Apr '22

13 Apr '22

Branch: refs/heads/2.10 Home: https://github.com/openSUSE/open-build-service Commit: c872cec3a98d8278d6b6737fc41b64b01b91b309 https://github.com/openSUSE/open-build-service/commit/c872cec3a98d8278d6b67… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update yajl-ruby to version 1.4.2 Commit: 0218ebd4231eaf6ba4397da047113b028ec49492 https://github.com/openSUSE/open-build-service/commit/0218ebd4231eaf6ba4397… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #12408 from openSUSE/depfu/update/srcapi-2.10/yajl-ruby-1.4.2 🚨 [security] [src/api - 2.10] Update yajl-ruby: 1.4.1 → 1.4.2 (patch) Compare: https://github.com/openSUSE/open-build-service/compare/718ad6625c1e...0218e…

1 0

[openSUSE/open-build-service] f44d5b: Update nokogiri to version 1.13.4
by depfu[bot] 13 Apr '22

13 Apr '22

Branch: refs/heads/depfu/update/srcapi-2.10/nokogiri-1.13.4 Home: https://github.com/openSUSE/open-build-service Commit: f44d5b4121e9db836bd9e8aecc1c8146125d4012 https://github.com/openSUSE/open-build-service/commit/f44d5b4121e9db836bd9e… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update nokogiri to version 1.13.4

1 0

[openSUSE/open-build-service] c872ce: Update yajl-ruby to version 1.4.2
by depfu[bot] 13 Apr '22

13 Apr '22

Branch: refs/heads/depfu/update/srcapi-2.10/yajl-ruby-1.4.2 Home: https://github.com/openSUSE/open-build-service Commit: c872cec3a98d8278d6b6737fc41b64b01b91b309 https://github.com/openSUSE/open-build-service/commit/c872cec3a98d8278d6b67… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update yajl-ruby to version 1.4.2

1 0

[openSUSE/open-build-service] f38fcd: Fix flaky test
by Henne Vogelsang 13 Apr '22

13 Apr '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f38fcdcbd4407af7b570ea90c7c4817cc3c0b428 https://github.com/openSUSE/open-build-service/commit/f38fcdcbd4407af7b570e… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/app/controllers/webui/users/bs_requests_controller.rb M src/api/spec/controllers/webui/users/bs_requests_controller_spec.rb Log Message: ----------- Fix flaky test You can only look at your own tasks. This ran into an obscure Admin only feature in check_display_user... Commit: 543d1960dd63124ffd9cd44228537ba40def2c26 https://github.com/openSUSE/open-build-service/commit/543d1960dd63124ffd9cd… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2022-04-13 (Wed, 13 Apr 2022) Changed paths: M src/api/app/controllers/webui/users/bs_requests_controller.rb M src/api/spec/controllers/webui/users/bs_requests_controller_spec.rb Log Message: ----------- Merge pull request #12438 from hennevogel/bugfix/flaky-user-test Fix flaky test Compare: https://github.com/openSUSE/open-build-service/compare/5c99a705543b...543d1…

1 0