February 2022 - Open Build Service Commits

[openSUSE/software-o-o] d738d7: Update nokogiri to version 1.13.1
by depfu[bot] 21 Feb '22

21 Feb '22

Branch: refs/heads/depfu/update/nokogiri-1.13.1 Home: https://github.com/openSUSE/software-o-o Commit: d738d798c43fd649179e5b62a80cc453de881894 https://github.com/openSUSE/software-o-o/commit/d738d798c43fd649179e5b62a80… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M Gemfile.lock Log Message: ----------- Update nokogiri to version 1.13.1

1 0

[openSUSE/open-build-service] 4901f4: Update mini_portile2 to version 2.8.0
by depfu[bot] 21 Feb '22

21 Feb '22

Branch: refs/heads/depfu/update/srcapi/mini_portile2-2.8.0 Home: https://github.com/openSUSE/open-build-service Commit: 4901f45cea7afbe11a18e2db8808a612ea727167 https://github.com/openSUSE/open-build-service/commit/4901f45cea7afbe11a18e… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update mini_portile2 to version 2.8.0

1 0

[openSUSE/open-build-service] 41afc2: Update nokogiri to version 1.13.2
by depfu[bot] 21 Feb '22

21 Feb '22

Branch: refs/heads/depfu/update/srcapi-2.10/nokogiri-1.13.2 Home: https://github.com/openSUSE/open-build-service Commit: 41afc2435f1f37597508646a6afa83b673763369 https://github.com/openSUSE/open-build-service/commit/41afc2435f1f375975086… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update nokogiri to version 1.13.2

1 0

[openSUSE/software-o-o] ac6841: Update nokogiri to version 1.13.2
by depfu[bot] 21 Feb '22

21 Feb '22

Branch: refs/heads/depfu/update/nokogiri-1.13.2 Home: https://github.com/openSUSE/software-o-o Commit: ac684102591dc89363d060ec10f1befb91d269ee https://github.com/openSUSE/software-o-o/commit/ac684102591dc89363d060ec10f… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M Gemfile.lock Log Message: ----------- Update nokogiri to version 1.13.2

1 0

[openSUSE/open-build-service] bb5468: Update nokogiri to version 1.13.2
by depfu[bot] 21 Feb '22

21 Feb '22

Branch: refs/heads/depfu/update/srcapi/nokogiri-1.13.2 Home: https://github.com/openSUSE/open-build-service Commit: bb54681f735b2bb89c17d1edcc7b2071fdbc3745 https://github.com/openSUSE/open-build-service/commit/bb54681f735b2bb89c17d… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update nokogiri to version 1.13.2

1 0

[openSUSE/open-build-service] 1eb9b5: Create WatchedItem model and its associations
by Henne Vogelsang 21 Feb '22

21 Feb '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1eb9b505a947021a19deae6669aa1658c2441f57 https://github.com/openSUSE/open-build-service/commit/1eb9b505a947021a19dea… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/app/models/bs_request.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/user.rb A src/api/app/models/watched_item.rb A src/api/db/migrate/20220210154407_create_watched_items.rb M src/api/db/schema.rb A src/api/spec/factories/watched_items.rb A src/api/spec/models/watched_item_spec.rb Log Message: ----------- Create WatchedItem model and its associations The new watchlist implementation allows users to add packages and requests to the watchlist, not only projects. - Add migration for watched_items table - Polymorphic association between WatchedItem, Package, Project and BsRequest. - Association with user. Co-authored-by: Daniel Donisa <daniel.donisa(a)suse.com> Commit: dcd219b85a1082bec7e1d09d0975212e931b2f90 https://github.com/openSUSE/open-build-service/commit/dcd219b85a1082bec7e1d… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: A src/api/app/components/watchlist_component.html.haml A src/api/app/components/watchlist_component.rb M src/api/app/views/layouts/webui/webui.html.haml A src/api/spec/components/watchlist_component_spec.rb Log Message: ----------- Create WatchlistComponent This component represents the whole Watchlist bar, with the actions to add or remove elements, and the list of watched items grouped by type. Co-authored-by: Daniel Donisa <daniel.donisa(a)suse.com> Commit: 1bb23417280245537322bcdec26b325e806a9108 https://github.com/openSUSE/open-build-service/commit/1bb23417280245537322b… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/app/assets/stylesheets/webui/application.scss A src/api/app/assets/stylesheets/webui/new_watchlist/watchlist.scss A src/api/app/components/watched_items_list_component.html.haml A src/api/app/components/watched_items_list_component.rb M src/api/app/components/watchlist_component.html.haml A src/api/spec/components/watched_items_list_component_spec.rb Log Message: ----------- Create WatchedItemsListComponent We have three identical lists of items. One list per each type of items: packages, projects, requests. The code has been moved to the WatchedItemsListComponent so we don't repeat the code three times. Commit: 75f67785ba468f46331550b1ba927bc5e740daac https://github.com/openSUSE/open-build-service/commit/75f67785ba468f4633155… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: A src/api/app/controllers/webui/watched_items_controller.rb M src/api/config/routes/webui_routes.rb A src/api/spec/controllers/webui/watched_items_controller_spec.rb Log Message: ----------- Add toggle functionality for new watchlist The new routes allow to add and remove items to the watchlist. The items can be of three different types: Package, Project and BsRequest. Co-authored-by: Daniel Donisa <daniel.donisa(a)suse.com> Commit: d47def5780c4be2dbb802412510eec9a8a001f8d https://github.com/openSUSE/open-build-service/commit/d47def5780c4be2dbb802… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/lib/tasks/dev.rake Log Message: ----------- Configure new_watchlist feature flag Co-authored-by: Daniel Donisa <daniel.donisa(a)suse.com> Commit: b151c5be5abf011ead5c42166ef1016185f2ca0a https://github.com/openSUSE/open-build-service/commit/b151c5be5abf011ead5c4… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/app/components/watchlist_component.rb M src/api/config/routes/webui_routes.rb Log Message: ----------- Use resourceful routes Co-authored-by: Daniel Donisa <daniel.donisa(a)suse.com> Commit: bf1c650bcd3818f165d96cc233c90808754fbf5c https://github.com/openSUSE/open-build-service/commit/bf1c650bcd3818f165d96… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/app/components/watchlist_component.rb M src/api/app/views/layouts/webui/webui.html.haml M src/api/spec/components/watchlist_component_spec.rb Log Message: ----------- Pass objects to WatchlistComponent Co-authored-by: Daniel Donisa <daniel.donisa(a)suse.com> Commit: 9f2ff21143929e26493d248dcf763bc027f2159a https://github.com/openSUSE/open-build-service/commit/9f2ff21143929e26493d2… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/app/components/watched_items_list_component.html.haml Log Message: ----------- Remove unnecessary div list-group Commit: d76dc3e3e013b04317c84f9310554b6b5e3d4d2b https://github.com/openSUSE/open-build-service/commit/d76dc3e3e013b04317c84… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/app/controllers/webui/watched_items_controller.rb Log Message: ----------- Require login on WatchedItemsController Commit: 529c8c3574b93a267201e12a907c130cc25753d2 https://github.com/openSUSE/open-build-service/commit/529c8c3574b93a267201e… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/spec/controllers/webui/watched_items_controller_spec.rb R src/api/spec/models/watched_item_spec.rb Log Message: ----------- Remove superfluous specs Commit: 6b32cc46460692898783c1074a5bd8eddaed953c https://github.com/openSUSE/open-build-service/commit/6b32cc46460692898783c… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/app/assets/stylesheets/webui/application.scss A src/api/app/assets/stylesheets/webui/new_watchlist/watchlist.scss A src/api/app/components/watched_items_list_component.html.haml A src/api/app/components/watched_items_list_component.rb A src/api/app/components/watchlist_component.html.haml A src/api/app/components/watchlist_component.rb A src/api/app/controllers/webui/watched_items_controller.rb M src/api/app/models/bs_request.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/user.rb A src/api/app/models/watched_item.rb M src/api/app/views/layouts/webui/webui.html.haml M src/api/config/routes/webui_routes.rb A src/api/db/migrate/20220210154407_create_watched_items.rb M src/api/db/schema.rb M src/api/lib/tasks/dev.rake A src/api/spec/components/watched_items_list_component_spec.rb A src/api/spec/components/watchlist_component_spec.rb A src/api/spec/controllers/webui/watched_items_controller_spec.rb A src/api/spec/factories/watched_items.rb Log Message: ----------- Merge pull request #12185 from danidoni/new-watchlist-implementation Implement the new watchlist feature Compare: https://github.com/openSUSE/open-build-service/compare/bf78a42d208d...6b32c…

1 0

[openSUSE/open-build-service] 1c5b38: Don't initialize `NotificationsFinder` twice
by Lukas Krause 21 Feb '22

21 Feb '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1c5b38a26f556f77215b2987d4178d27b39d6cf1 https://github.com/openSUSE/open-build-service/commit/1c5b38a26f556f77215b2… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-02-18 (Fri, 18 Feb 2022) Changed paths: M src/api/app/controllers/person/notifications_controller.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/policies/notification_policy.rb M src/api/app/queries/notifications_finder.rb Log Message: ----------- Don't initialize `NotificationsFinder` twice Currently we initialize the `NotificationsFinder` once in the pundit notification policy scope and then use the returned notifications to initialize another `NotificationsFinder` object. This is confusing and makes it harder to track down unefficient queries and other issues. We should move the logic that fetches the notifications for the subscribed user from the finder to the policy since it is related to authorization. Commit: 83405d354c1d6882e194ddcd45449b66f88d27ca https://github.com/openSUSE/open-build-service/commit/83405d354c1d6882e194d… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-02-18 (Fri, 18 Feb 2022) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb Log Message: ----------- Eager load records associated with notifications Currently the notifications view cause a lot of n+1 queries Commit: dc5db00af5f6525d859168035b1c7178816d8d2b https://github.com/openSUSE/open-build-service/commit/dc5db00af5f6525d85916… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-02-18 (Fri, 18 Feb 2022) Changed paths: M src/api/app/components/notification_avatars_component.rb M src/api/app/models/review.rb Log Message: ----------- Remove `where` clause for comments and reviews in notification avatar component We eager loaded the comments and reviews when querying the notifications from the DB. The `where` clause cause another query to the db, so it ignores the by activerecord eager loaded objects. Commit: 8b6f26795cf793138a54ab574664d2454f2fb244 https://github.com/openSUSE/open-build-service/commit/8b6f26795cf793138a54a… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-02-18 (Fri, 18 Feb 2022) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/queries/notifications_finder.rb Log Message: ----------- Check for logged in user in controller instead of finder class Checking if the user is logged in should happen on the controller level, not inside the notifications finder class. Commit: 30b0a3a613e741732c3759ebbcc52a982c9ad1bc https://github.com/openSUSE/open-build-service/commit/30b0a3a613e741732c375… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-02-18 (Fri, 18 Feb 2022) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/queries/notifications_finder.rb Log Message: ----------- Use notification pundit policy in order to authorize and fetch a single notification Currently we query a whole scope in order to receive and authorize a single notification. Also having a method in a finder class to simply query a notification by an Id creates a bit of overhead. Lets simply use the `find` method to fetch the record and a pundit method to authorize. Commit: bf78a42d208d768ffcf855b6d6bec3ac05287ffd https://github.com/openSUSE/open-build-service/commit/bf78a42d208d768ffcf85… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M src/api/app/components/notification_avatars_component.rb M src/api/app/controllers/person/notifications_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/models/review.rb M src/api/app/policies/notification_policy.rb M src/api/app/queries/notifications_finder.rb Log Message: ----------- Merge pull request #12223 from krauselukas/improve_notification_queries02 Avoid n+1 queries for notification index view Compare: https://github.com/openSUSE/open-build-service/compare/ee129e3e0890...bf78a…

1 0

[openSUSE/obs-build] decac5: Improve testcase->rpm dependency translation
by Michael Schroeder 21 Feb '22

21 Feb '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: decac565264fad9a4825379ecede9bfe8123e520 https://github.com/openSUSE/obs-build/commit/decac565264fad9a4825379ecede9b… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M PBuild/OBS.pm Log Message: ----------- Improve testcase->rpm dependency translation Commit: 1e3e3c2b19bfe3b9d8e389c39d5e9ee6deaab01f https://github.com/openSUSE/obs-build/commit/1e3e3c2b19bfe3b9d8e389c39d5e9e… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M download Log Message: ----------- download: save in tmp file and rename on completion Commit: 58090e8f36bc31f5d3ae724922b31ae5c119dfbc https://github.com/openSUSE/obs-build/commit/58090e8f36bc31f5d3ae724922b31a… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M init_buildsystem Log Message: ----------- Remove preinstall image unpacking progress report It slows down the unpacking and also processes tend to stay behind causing a later umount to fail. Compare: https://github.com/openSUSE/obs-build/compare/f05b479a4244...58090e8f36bc

1 0

[openSUSE/obs-build] c160b2: download_assets: add --outdir parameter
by Michael Schroeder 21 Feb '22

21 Feb '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: c160b294be3562d48612cb1fe889c5f450f54dd5 https://github.com/openSUSE/obs-build/commit/c160b294be3562d48612cb1fe889c5… Author: Adrian Schröter <adrian(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M download_assets Log Message: ----------- download_assets: add --outdir parameter To be used by obs-service-download_assets, when using the assets mechanic independend of git/obssync Commit: f05b479a424424812ac0ea53b982c7e55f2361e4 https://github.com/openSUSE/obs-build/commit/f05b479a424424812ac0ea53b982c7… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M download_assets Log Message: ----------- Merge pull request #796 from adrianschroeter/outdir download_assets: add --outdir parameter Compare: https://github.com/openSUSE/obs-build/compare/3e0410e8a080...f05b479a4244

1 0

[openSUSE/obs-build] 0518c8: Add support for LXC 4.
by Adrian Schröter 21 Feb '22

21 Feb '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 0518c8b3ba7333afa78920d7b4d92a8f9dc23c14 https://github.com/openSUSE/obs-build/commit/0518c8b3ba7333afa78920d7b4d92a… Author: Oleg Girko <ol(a)infoserver.lv> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M build-vm-lxc Log Message: ----------- Add support for LXC 4. LXC 4 introduces no incompatibilities with LXC 3 regarding configuration and command line options that build-vm-lxc uses. Hence, this change just makes build-vm-lxc recognise version 4. Signed-off-by: Oleg Girko <ol(a)infoserver.lv> Commit: 3e0410e8a0808de803f1bf8ec0a67de485ea36f5 https://github.com/openSUSE/obs-build/commit/3e0410e8a0808de803f1bf8ec0a67d… Author: Adrian Schröter <adrian(a)suse.de> Date: 2022-02-21 (Mon, 21 Feb 2022) Changed paths: M build-vm-lxc Log Message: ----------- Merge pull request #795 from OlegGirko/lxc-4 Add support for LXC 4 Compare: https://github.com/openSUSE/obs-build/compare/8613c09448b1...3e0410e8a080

1 0