November 2022 - Open Build Service Commits

[openSUSE/obs-sign] 5eb0db: Add assertion to addpkg()
by Michael Schroeder 16 Nov '22

16 Nov '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-sign Commit: 5eb0db905cb967de985482816e709a932213ad10 https://github.com/openSUSE/obs-sign/commit/5eb0db905cb967de985482816e709a9… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M pgp.c Log Message: ----------- Add assertion to addpkg() Defensive programming.

1 0

[openSUSE/obs-sign] ac43c4: Refactor code
by Michael Schroeder 16 Nov '22

16 Nov '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-sign Commit: ac43c428d2813c358abed7e463520ff37e3aafb6 https://github.com/openSUSE/obs-sign/commit/ac43c428d2813c358abed7e463520ff… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M Makefile M appimage.c M appx.c M base64.c A bele.h M inc.h M pe.c M pgp.c M rpm.c M sign.c A util.c M x509.c M zip.c Log Message: ----------- Refactor code - split off duplicated code into util.h - use u32/u64 consistently - clean up rpm signature insertion code

1 0

[openSUSE/open-build-service] 7aa820: Add event_subscriptions association in WorkflowRun
by Henne Vogelsang 16 Nov '22

16 Nov '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7aa82014198c5251c63d4669df7adff61cf28c06 https://github.com/openSUSE/open-build-service/commit/7aa82014198c5251c63d4… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: M src/api/app/models/event_subscription.rb M src/api/app/models/workflow_run.rb Log Message: ----------- Add event_subscriptions association in WorkflowRun I realized this was missing when I looked at #13377. Commit: 3109ff657aa7a28b3b82e2beebc13934f48e6005 https://github.com/openSUSE/open-build-service/commit/3109ff657aa7a28b3b82e… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2022-11-16 (Wed, 16 Nov 2022) Changed paths: M src/api/app/models/event_subscription.rb M src/api/app/models/workflow_run.rb Log Message: ----------- Merge pull request #13381 from dmarcoux/add-missing-association-workflow-run Add event_subscriptions association in WorkflowRun Compare: https://github.com/openSUSE/open-build-service/compare/b3ad85145dfe...3109f…

1 0

[openSUSE/open-build-service] 0438f2: Remove `@statushash` instance variable from BuildR...
by Dany Marcoux 15 Nov '22

15 Nov '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0438f212eac65142f9cd0f0c54252e6fab019415 https://github.com/openSUSE/open-build-service/commit/0438f212eac65142f9cd0… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M src/api/app/helpers/webui/buildresult_helper.rb Log Message: ----------- Remove `@statushash` instance variable from BuildResultHelper We should not use instance variables in a helper class and the variable is not instantiated anywhere where this helper is used. Seems to be a left over. Commit: 539226f3bb42292c5d44a899438a0f8fa6da0d98 https://github.com/openSUSE/open-build-service/commit/539226f3bb42292c5d44a… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: A src/api/app/components/buildresult_status_link_component.html.haml A src/api/app/components/buildresult_status_link_component.rb M src/api/app/helpers/webui/buildresult_helper.rb M src/api/app/views/webui/package/_buildstatus.html.haml M src/api/app/views/webui/request/beta_show_tabs/_build_status.html.haml Log Message: ----------- Replace `arch_repo_table_cell` helper method with a view component Commit: 34651d14640000ec05e2b625507b34aa6b9ec42c https://github.com/openSUSE/open-build-service/commit/34651d14640000ec05e2b… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: R src/api/spec/helpers/webui/buildresult_helper_spec.rb Log Message: ----------- Remove `buildresult_helper_spec.rb` The only method tested in this spec is `arch_repo_table_cell` which is now refactored to a view component. Commit: 17e50f61b1e158b475c80cc563a0e59b904d5c93 https://github.com/openSUSE/open-build-service/commit/17e50f61b1e158b475c80… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: A src/api/spec/components/buildresult_status_link_component_spec.rb Log Message: ----------- Add spec for `BuildresultStatusLinkComponent` view component Commit: e19bfccc7a036b21b67b84447bbd17e9c1653b67 https://github.com/openSUSE/open-build-service/commit/e19bfccc7a036b21b67b8… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: A src/api/spec/components/previews/buildresult_status_link_component_preview.rb Log Message: ----------- Add view component preview for `BuildresultStatusLinkComponent` Commit: b3ad85145dfe32196f6f1efd52a37b9e697bf0a0 https://github.com/openSUSE/open-build-service/commit/b3ad85145dfe32196f6f1… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: A src/api/app/components/buildresult_status_link_component.html.haml A src/api/app/components/buildresult_status_link_component.rb M src/api/app/helpers/webui/buildresult_helper.rb M src/api/app/views/webui/package/_buildstatus.html.haml M src/api/app/views/webui/request/beta_show_tabs/_build_status.html.haml A src/api/spec/components/buildresult_status_link_component_spec.rb A src/api/spec/components/previews/buildresult_status_link_component_preview.rb R src/api/spec/helpers/webui/buildresult_helper_spec.rb Log Message: ----------- Merge pull request #13361 from krauselukas/refactor/arch_repo_table_cell Replace `arch_repo_table_cell` helper method with a view component Compare: https://github.com/openSUSE/open-build-service/compare/e055e612bb96...b3ad8…

1 0

[openSUSE/open-build-service]
by Dany Marcoux 15 Nov '22

15 Nov '22

Branch: refs/heads/depfu/update/srcapi/rubocop-1.39.0 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] c80e6a: Update rubocop to version 1.39.0
by Dany Marcoux 15 Nov '22

15 Nov '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c80e6a39c245f3769af5a67680c25ae5ca80a6c2 https://github.com/openSUSE/open-build-service/commit/c80e6a39c245f3769af5a… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-1.38.0.gem A src/api/vendor/cache/rubocop-1.39.0.gem Log Message: ----------- Update rubocop to version 1.39.0 Commit: 801287d2cd97a4bf3edec57317509f6d02be9dbd https://github.com/openSUSE/open-build-service/commit/801287d2cd97a4bf3edec… Author: Rubhan Azeem <rubhanazeem(a)gmail.com> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: M src/api/app/models/group.rb M src/api/app/models/static_permission.rb Log Message: ----------- Remove redundant escape inside regexp literal Commit: e055e612bb96d4db7639c81dcf069984cb29607d https://github.com/openSUSE/open-build-service/commit/e055e612bb96d4db7639c… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: M src/api/Gemfile.lock M src/api/app/models/group.rb M src/api/app/models/static_permission.rb R src/api/vendor/cache/rubocop-1.38.0.gem A src/api/vendor/cache/rubocop-1.39.0.gem Log Message: ----------- Merge pull request #13375 from openSUSE/depfu/update/srcapi/rubocop-1.39.0 [src/api] Update rubocop: 1.38.0 → 1.39.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/29fe2bfa6633...e055e…

1 0

[openSUSE/open-build-service] c80e6a: Update rubocop to version 1.39.0
by Rubhan Azeem 15 Nov '22

15 Nov '22

Branch: refs/heads/depfu/update/srcapi/rubocop-1.39.0 Home: https://github.com/openSUSE/open-build-service Commit: c80e6a39c245f3769af5a67680c25ae5ca80a6c2 https://github.com/openSUSE/open-build-service/commit/c80e6a39c245f3769af5a… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-1.38.0.gem A src/api/vendor/cache/rubocop-1.39.0.gem Log Message: ----------- Update rubocop to version 1.39.0 Commit: 801287d2cd97a4bf3edec57317509f6d02be9dbd https://github.com/openSUSE/open-build-service/commit/801287d2cd97a4bf3edec… Author: Rubhan Azeem <rubhanazeem(a)gmail.com> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: M src/api/app/models/group.rb M src/api/app/models/static_permission.rb Log Message: ----------- Remove redundant escape inside regexp literal Compare: https://github.com/openSUSE/open-build-service/compare/789a1bba3481...80128…

1 0

[openSUSE/open-build-service] 789a1b: Remove redundant escape inside regexp literal
by Rubhan Azeem 15 Nov '22

15 Nov '22

Branch: refs/heads/depfu/update/srcapi/rubocop-1.39.0 Home: https://github.com/openSUSE/open-build-service Commit: 789a1bba3481722b321334b676ecc26c8bba974a https://github.com/openSUSE/open-build-service/commit/789a1bba3481722b32133… Author: Rubhan Azeem <rubhanazeem(a)gmail.com> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: M src/api/app/models/group.rb M src/api/app/models/static_permission.rb Log Message: ----------- Remove redundant escape inside regexp literal

1 0

[openSUSE/open-build-service] 561b89: Rewrite the ternary so it's easier on the eyes
by Dany Marcoux 15 Nov '22

15 Nov '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 561b89dd3b625ce076c99a581a0d2af36c1168a9 https://github.com/openSUSE/open-build-service/commit/561b89dd3b625ce076c99… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2022-11-14 (Mon, 14 Nov 2022) Changed paths: M src/api/app/models/bs_request_action.rb M src/api/spec/models/bs_request_action_spec.rb Log Message: ----------- Rewrite the ternary so it's easier on the eyes Ternaries are harder to read than regular conditionals (if's). This one was extra hard because it was embedded in a string interpolation. Commit: 29fe2bfa66335797cce355f8f70500685056e507 https://github.com/openSUSE/open-build-service/commit/29fe2bfa66335797cce35… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: M src/api/app/models/bs_request_action.rb M src/api/spec/models/bs_request_action_spec.rb Log Message: ----------- Merge pull request #13366 from danidoni/fix-hard-to-read-ternary Rewrite the ternary so it's easier on the eyes Compare: https://github.com/openSUSE/open-build-service/compare/881fa105c40a...29fe2…

1 0

[openSUSE/open-build-service] 1c8f67: Update rubocop to version 1.39.0
by depfu[bot] 15 Nov '22

15 Nov '22

Branch: refs/heads/depfu/update/srcapi/rubocop-1.39.0 Home: https://github.com/openSUSE/open-build-service Commit: 1c8f670dda6d2490c25b02792819210378c5c321 https://github.com/openSUSE/open-build-service/commit/1c8f670dda6d2490c25b0… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-11-15 (Tue, 15 Nov 2022) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-1.38.0.gem A src/api/vendor/cache/rubocop-1.39.0.gem Log Message: ----------- Update rubocop to version 1.39.0

1 0