October 2022 - Open Build Service Commits

[openSUSE/open-build-service] 7b758a: Fix RuboCop offense RSpec/Rails/InferredSpecType
by Dany Marcoux 27 Oct '22

27 Oct '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7b758aededde0b061a7275abcd96999b0b213cf6 https://github.com/openSUSE/open-build-service/commit/7b758aededde0b061a727… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: M src/api/spec/features/webui/badge_spec.rb Log Message: ----------- Fix RuboCop offense RSpec/Rails/InferredSpecType We can remove the redundant spec type. Commit: 9c83d0a28b205d895930109d02b60d8dfe073de6 https://github.com/openSUSE/open-build-service/commit/9c83d0a28b205d8959301… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: M src/api/spec/features/webui/badge_spec.rb Log Message: ----------- Merge pull request #13283 from dmarcoux/fix-rubocop-offense Fix RuboCop offense RSpec/Rails/InferredSpecType Compare: https://github.com/openSUSE/open-build-service/compare/b239a7f42e21...9c83d…

1 0

[openSUSE/open-build-service] eb44b8: Specify formats in render calls instead of using f...
by Dany Marcoux 27 Oct '22

27 Oct '22

Branch: refs/heads/next_rails-7/fix-specs Home: https://github.com/openSUSE/open-build-service Commit: eb44b8d7ea2cd77d158d1cdc7ce7d6b440b25bb2 https://github.com/openSUSE/open-build-service/commit/eb44b8d7ea2cd77d158d1… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/helpers/webui/user_helper.rb Log Message: ----------- Specify formats in render calls instead of using file extensions Using file extensions in render calls has been deprecated and it is now unsupported in Rails 7.x. For details, see https://github.com/rails/rails/pull/39164

1 0

[openSUSE/open-build-service] 7e416e: Add the build results badge for the package
by Henne Vogelsang 27 Oct '22

27 Oct '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7e416e3a1f63ebf2dbef3ff7983b30687c6db149 https://github.com/openSUSE/open-build-service/commit/7e416e3a1f63ebf2dbef3… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2022-10-20 (Thu, 20 Oct 2022) Changed paths: A src/api/app/assets/images/badge-failed.svg A src/api/app/assets/images/badge-percent.svg A src/api/app/assets/images/badge-succeeded.svg A src/api/app/assets/images/badge-unknown.svg A src/api/app/controllers/webui/packages/badge_controller.rb M src/api/app/models/local_build_result/for_package.rb M src/api/app/models/package.rb M src/api/config/routes/webui_routes.rb A src/api/spec/features/webui/badge_spec.rb Log Message: ----------- Add the build results badge for the package Commit: 5c231f0ff2c7310ed144e6d765737854a6c8fd25 https://github.com/openSUSE/open-build-service/commit/5c231f0ff2c7310ed144e… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2022-10-20 (Thu, 20 Oct 2022) Changed paths: M src/api/spec/cassettes/Package/_buildresult/returns_an_object_with_class_LocalBuildResult_ForPackage.yml M src/api/spec/cassettes/Packages/log/download_logfile_succesfully.yml M src/api/spec/features/webui/packages_spec.rb Log Message: ----------- Fix casettes and specs not including the new param Commit: 858a27086718a55df5d39a52c64f1953696fedc6 https://github.com/openSUSE/open-build-service/commit/858a27086718a55df5d39… Author: Jacob Michalskie <jacob.michalskie(a)suse.com> Date: 2022-10-20 (Thu, 20 Oct 2022) Changed paths: A src/api/spec/cassettes/Badge/with_failing_and_succeeding_build_results/displays_the_correct_failed_state.yml A src/api/spec/cassettes/Badge/with_failing_and_succeeding_build_results/displays_the_correct_percentage.yml A src/api/spec/cassettes/Badge/with_succeeding_build_results/displays_the_correct_percentage.yml A src/api/spec/cassettes/Badge/with_succeeding_build_results/displays_the_suceeded_state.yml A src/api/spec/cassettes/Badge/without_build_results/displays_the_correct_unknown_state.yml A src/api/spec/cassettes/Badge/without_build_results/displays_the_correct_unknown_state_despite_percent_type.yml Log Message: ----------- Add cassetes for badges Commit: b239a7f42e2147de86fa33ce50d9951ef09eb96a https://github.com/openSUSE/open-build-service/commit/b239a7f42e2147de86fa3… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: A src/api/app/assets/images/badge-failed.svg A src/api/app/assets/images/badge-percent.svg A src/api/app/assets/images/badge-succeeded.svg A src/api/app/assets/images/badge-unknown.svg A src/api/app/controllers/webui/packages/badge_controller.rb M src/api/app/models/local_build_result/for_package.rb M src/api/app/models/package.rb M src/api/config/routes/webui_routes.rb A src/api/spec/cassettes/Badge/with_failing_and_succeeding_build_results/displays_the_correct_failed_state.yml A src/api/spec/cassettes/Badge/with_failing_and_succeeding_build_results/displays_the_correct_percentage.yml A src/api/spec/cassettes/Badge/with_succeeding_build_results/displays_the_correct_percentage.yml A src/api/spec/cassettes/Badge/with_succeeding_build_results/displays_the_suceeded_state.yml A src/api/spec/cassettes/Badge/without_build_results/displays_the_correct_unknown_state.yml A src/api/spec/cassettes/Badge/without_build_results/displays_the_correct_unknown_state_despite_percent_type.yml M src/api/spec/cassettes/Package/_buildresult/returns_an_object_with_class_LocalBuildResult_ForPackage.yml M src/api/spec/cassettes/Packages/log/download_logfile_succesfully.yml A src/api/spec/features/webui/badge_spec.rb M src/api/spec/features/webui/packages_spec.rb Log Message: ----------- Merge pull request #13169 from hellcp-work/badge Add the build results badge for the package Compare: https://github.com/openSUSE/open-build-service/compare/e2676309932b...b239a…

1 0

[openSUSE/open-build-service] e92182: Remove unneeded quotes in SQL query for Maintenanc...
by Dany Marcoux 27 Oct '22

27 Oct '22

Branch: refs/heads/next_rails-7/fix-specs Home: https://github.com/openSUSE/open-build-service Commit: e92182aa0d348b9da425f77a225d1ff8df095933 https://github.com/openSUSE/open-build-service/commit/e92182aa0d348b9da425f… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: M src/api/app/models/maintenance_incident.rb Log Message: ----------- Remove unneeded quotes in SQL query for MaintenanceIncident#project_name With Rails 7.x, MySQL surrounds numeric values with quotes whenever queries are built from SQL fragments. This was changed to prevent potential security vulnerabilities. This means the quotes we had before in the modified quotes aren't needed. For details, see https://github.com/rails/rails/issues/44312

1 0

[openSUSE/open-build-service] eefaca: Be less strict in assertion of test_update_watchlist
by Dany Marcoux 27 Oct '22

27 Oct '22

Branch: refs/heads/next_rails-7/fix-specs Home: https://github.com/openSUSE/open-build-service Commit: eefacaffb7ed2704abaa27aed0f42d35cfeddd94 https://github.com/openSUSE/open-build-service/commit/eefacaffb7ed2704abaa2… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: M src/api/test/functional/person_controller_test.rb Log Message: ----------- Be less strict in assertion of test_update_watchlist In Rails 6.x, the summary will be `Couldn't find Project`. In Rails 7.x, it's slightly more verbose with `Couldn't find Project with [WHERE `projects`.`id` NOT IN (?, ?) AND `projects`.`name` = ?]`. Commit: 8ecb55fe3664c1e73e0370d17d97fb32b04833d2 https://github.com/openSUSE/open-build-service/commit/8ecb55fe3664c1e73e037… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: M src/api/app/models/maintenance_incident.rb Log Message: ----------- Remove unneeded quotes in SQL query for MaintenanceIncident#project_name With Rails 7.x, MySQL surrounds numeric values with quotes whenever queries are built from SQL fragments. This was changed to prevent potential security vulnerabilities. This means the quotes we had before in the modified quotes aren't needed. For details, see https://github.com/rails/rails/issues/44312 Compare: https://github.com/openSUSE/open-build-service/compare/ba3c033bd121...8ecb5…

1 0

[openSUSE/open-build-service]
by Dany Marcoux 27 Oct '22

27 Oct '22

Branch: refs/heads/depfu/update/srcapi/rubocop-rspec-2.14.2 Home: https://github.com/openSUSE/open-build-service

1 0

[openSUSE/open-build-service] fa729e: Update rubocop-rspec to version 2.14.2
by Dany Marcoux 27 Oct '22

27 Oct '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: fa729e492fe7bbb3348e8a0ee02eab0787bd75b6 https://github.com/openSUSE/open-build-service/commit/fa729e492fe7bbb3348e8… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-rspec-2.14.1.gem A src/api/vendor/cache/rubocop-rspec-2.14.2.gem Log Message: ----------- Update rubocop-rspec to version 2.14.2 Commit: e2676309932b1b1e98b142891002a4a4406c4ab9 https://github.com/openSUSE/open-build-service/commit/e2676309932b1b1e98b14… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-rspec-2.14.1.gem A src/api/vendor/cache/rubocop-rspec-2.14.2.gem Log Message: ----------- Merge pull request #13282 from openSUSE/depfu/update/srcapi/rubocop-rspec-2.14.2 [src/api] Update rubocop-rspec: 2.14.1 → 2.14.2 (patch) Compare: https://github.com/openSUSE/open-build-service/compare/db2e69388e5a...e2676…

1 0

[openSUSE/open-build-service] fa729e: Update rubocop-rspec to version 2.14.2
by depfu[bot] 27 Oct '22

27 Oct '22

Branch: refs/heads/depfu/update/srcapi/rubocop-rspec-2.14.2 Home: https://github.com/openSUSE/open-build-service Commit: fa729e492fe7bbb3348e8a0ee02eab0787bd75b6 https://github.com/openSUSE/open-build-service/commit/fa729e492fe7bbb3348e8… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: M src/api/Gemfile.lock R src/api/vendor/cache/rubocop-rspec-2.14.1.gem A src/api/vendor/cache/rubocop-rspec-2.14.2.gem Log Message: ----------- Update rubocop-rspec to version 2.14.2

1 0

[openSUSE/open-build-service] ba3c03: Do not use an exit statement in transactions
by Dany Marcoux 27 Oct '22

27 Oct '22

Branch: refs/heads/next_rails-7/fix-specs Home: https://github.com/openSUSE/open-build-service Commit: ba3c033bd121f834ffa1eb395f95eb8af9c9753e https://github.com/openSUSE/open-build-service/commit/ba3c033bd121f834ffa1e… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/models/bs_request.rb Log Message: ----------- Do not use an exit statement in transactions With ActiveRecord 7.x, transactions are now rolled back whenever they return early. Previously, they were still committed. With `next`, the transactions aren't rolled back. This is also what RuboCop suggests. For details: - https://github.com/rails/rails/issues/45017 - https://docs.rubocop.org/rubocop-rails/cops_rails.html#railstransactionexit…

1 0

[openSUSE/obs-sign] 455bcf: Add support for creating detached cms signatures
by Michael Schroeder 27 Oct '22

27 Oct '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-sign Commit: 455bcf859c6a578ec137ba7437a4e8904cf6efb5 https://github.com/openSUSE/obs-sign/commit/455bcf859c6a578ec137ba7437a4e89… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-10-27 (Thu, 27 Oct 2022) Changed paths: M appx.c M hash.c M inc.h M sign.c M x509.c Log Message: ----------- Add support for creating detached cms signatures See rfc2630 for documentation. This is also what is used to sign linux kernel modules.

1 0