January 2022 - Open Build Service Commits

[openSUSE/open-build-service] 09af92: Update rubocop-rails to version 2.13.1
by Dani Donisa 13 Jan '22

13 Jan '22

Branch: refs/heads/depfu/update/srcapi/rubocop-rails-2.13.1 Home: https://github.com/openSUSE/open-build-service Commit: 09af92a4c1825ba61cbb8c7b874ee80b30d3f30f https://github.com/openSUSE/open-build-service/commit/09af92a4c1825ba61cbb8… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-01-13 (Thu, 13 Jan 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop-rails to version 2.13.1 Commit: 0c1ac453bde5a1e61c320a23182ebb594b4fc3f8 https://github.com/openSUSE/open-build-service/commit/0c1ac453bde5a1e61c320… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2022-01-13 (Thu, 13 Jan 2022) Changed paths: M src/api/app/controllers/status/required_checks_controller.rb M src/api/app/controllers/webui/requests/submissions_controller.rb M src/api/app/jobs/consistency_check_job.rb M src/api/app/lib/backend/instrumentation.rb M src/api/app/mailers/event_mailer.rb M src/api/app/views/webui/search/_results_owner.html.haml Log Message: ----------- Fix Rails/CompactBlank cop Compare: https://github.com/openSUSE/open-build-service/compare/90c75d02569a...0c1ac…

1 0

[openSUSE/obs-build] 7b51dc: fix typo in argument handling of build verbose option
by Adrian Schröter 13 Jan '22

13 Jan '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 7b51dc72c470fc6bafe5b5e0cc24ea5e9f12c3ab https://github.com/openSUSE/obs-build/commit/7b51dc72c470fc6bafe5b5e0cc24ea… Author: Adrian Schröter <adrian(a)suse.de> Date: 2022-01-13 (Thu, 13 Jan 2022) Changed paths: M build Log Message: ----------- fix typo in argument handling of build verbose option

1 0

[openSUSE/open-build-service] 92c3a9: Update rubocop-rails to version 2.13.0
by Dani Donisa 13 Jan '22

13 Jan '22

Branch: refs/heads/depfu/update/srcapi/rubocop-rails-2.13.0 Home: https://github.com/openSUSE/open-build-service Commit: 92c3a96ed24441e5c5a7c22c3ecf31344da6dd0b https://github.com/openSUSE/open-build-service/commit/92c3a96ed24441e5c5a7c… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2022-01-13 (Thu, 13 Jan 2022) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop-rails to version 2.13.0 Commit: fe46bac72b7b3800e015a170c5029e5a2c9ff4ac https://github.com/openSUSE/open-build-service/commit/fe46bac72b7b3800e015a… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2022-01-13 (Thu, 13 Jan 2022) Changed paths: M src/api/app/controllers/status/required_checks_controller.rb M src/api/app/controllers/webui/requests/submissions_controller.rb M src/api/app/jobs/consistency_check_job.rb M src/api/app/lib/backend/instrumentation.rb M src/api/app/mailers/event_mailer.rb M src/api/app/views/webui/search/_results_owner.html.haml Log Message: ----------- Fix Rails/CompactBlank cop Commit: ad10269f463ec4eb54526256428773726b129096 https://github.com/openSUSE/open-build-service/commit/ad10269f463ec4eb54526… Author: Dani Donisa <dani.doni(a)gmail.com> Date: 2022-01-13 (Thu, 13 Jan 2022) Changed paths: M src/api/db/migrate/20170619111734_alter_notifications_to_use_polymorphic.rb M src/api/db/migrate/20170704133728_remove_source_project_id_and_source_package_id_from_bs_request_actions.rb M src/api/db/migrate/20180906142802_update_status_checks_table.rb Log Message: ----------- Disable Rails/ReversibleMigration cops on older migrations Compare: https://github.com/openSUSE/open-build-service/compare/3216166bd3c3...ad102…

1 0

[openSUSE/obs-build] ef2269: docker: support package installation calls inside ...
by Michael Schroeder 13 Jan '22

13 Jan '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: ef226920b27856dd1c3ca32d74b52c781496905c https://github.com/openSUSE/obs-build/commit/ef226920b27856dd1c3ca32d74b52c… Author: Adrian Schröter <adrian(a)suse.de> Date: 2022-01-13 (Thu, 13 Jan 2022) Changed paths: M Build/Docker.pm Log Message: ----------- docker: support package installation calls inside of if conditions Always parse them in if _and_ else conditions as we can not judge about the runtime check Commit: 9d716b782157407d17ab5f73011378bb06832abb https://github.com/openSUSE/obs-build/commit/9d716b782157407d17ab5f73011378… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-01-13 (Thu, 13 Jan 2022) Changed paths: M Build/Docker.pm Log Message: ----------- Merge pull request #757 from adrianschroeter/fix_docker docker: support package installation calls inside of if conditions Compare: https://github.com/openSUSE/obs-build/compare/133eca0a5409...9d716b782157

1 0

[openSUSE/obs-build] 133eca: Move virtio thread enabling into the fixup
by Michael Schroeder 13 Jan '22

13 Jan '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 133eca0a5409182bbbeeb55d601e5f877d846ed9 https://github.com/openSUSE/obs-build/commit/133eca0a5409182bbbeeb55d601e5f… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-01-13 (Thu, 13 Jan 2022) Changed paths: M build-vm-kvm Log Message: ----------- Move virtio thread enabling into the fixup The position before this commit was not correct, as the code afterwards changes kvm_device to non-virtio if no special initrd is found. It gets changed back to virtio in the fixup call later on if a special kernel is used. So we need to do the thread option adding after the fixup code changed the device back to virtio.

1 0

[openSUSE/open-build-service] 29eb3c: Enable `belongs_to_required_by_default` behaviour
by Rubhan Azeem 13 Jan '22

13 Jan '22

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 29eb3c18708aee07978fa576246efc434e857fc0 https://github.com/openSUSE/open-build-service/commit/29eb3c18708aee07978fa… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M src/api/config/application.rb Log Message: ----------- Enable `belongs_to_required_by_default` behaviour Since Rails 5.0 `belongs_to` automatically checks for the presence of the related record. We opted out this behavior in previous Rails upgrades. It's time to enable the default behavior (also since rubocop-rails 2.13 introduced a cop that checks for redundant validation to check for the presence of a record). Commit: 6844d9b926dbe3bae6b075bf1f61f0403c993556 https://github.com/openSUSE/open-build-service/commit/6844d9b926dbe3bae6b07… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M src/api/app/models/attrib.rb M src/api/app/models/comment.rb M src/api/app/models/commit_activity.rb M src/api/app/models/download_repository.rb M src/api/app/models/group_maintainer.rb M src/api/app/models/groups_user.rb M src/api/app/models/kiwi/profile.rb M src/api/app/models/notified_project.rb M src/api/app/models/path_element.rb M src/api/app/models/relationship.rb M src/api/app/models/repository.rb M src/api/app/models/repository_architecture.rb M src/api/app/models/review.rb M src/api/app/models/staging/request_exclusion.rb M src/api/app/models/staging/workflow.rb M src/api/app/models/status/report.rb M src/api/app/models/status_message.rb M src/api/app/models/status_message_acknowledgement.rb M src/api/app/models/token.rb M src/api/app/models/watched_project.rb Log Message: ----------- Remove redundant presence validations for belongs_to relations After enabling `belongs_to_required_by_default` those checks for presence are done automatically. Commit: 2216b2dcb6a54c3f196a67c443e71e0ac40628a3 https://github.com/openSUSE/open-build-service/commit/2216b2dcb6a54c3f196a6… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M src/api/app/models/attrib_default_value.rb M src/api/app/models/attrib_namespace_modifiable_by.rb M src/api/app/models/attrib_type_modifiable_by.rb M src/api/app/models/attrib_value.rb M src/api/app/models/backend_package.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_accept_info.rb M src/api/app/models/channel_binary.rb M src/api/app/models/channel_binary_list.rb M src/api/app/models/cloud/azure/configuration.rb M src/api/app/models/cloud/ec2/configuration.rb M src/api/app/models/cloud/user/upload_job.rb M src/api/app/models/concerns/staging_project.rb M src/api/app/models/event_subscription.rb M src/api/app/models/flag.rb M src/api/app/models/issue.rb M src/api/app/models/kiwi/description.rb M src/api/app/models/kiwi/package.rb M src/api/app/models/kiwi/package_group.rb M src/api/app/models/kiwi/preference.rb M src/api/app/models/kiwi/repository.rb M src/api/app/models/linked_project.rb M src/api/app/models/maintenance_incident.rb M src/api/app/models/notification.rb M src/api/app/models/package.rb M src/api/app/models/package_kind.rb M src/api/app/models/product_medium.rb M src/api/app/models/product_update_repository.rb M src/api/app/models/project.rb M src/api/app/models/project_log_entry.rb M src/api/app/models/review.rb M src/api/app/models/role.rb M src/api/app/models/status/check.rb M src/api/app/models/token.rb M src/api/app/models/user.rb M src/api/app/models/workflow_run.rb Log Message: ----------- Set optional flag on belongs_to relation where necessary After enabling `belongs_to_required_by_default` we have to explicitly tell rails where the associated record is optional. I set it to optional where ever it is not dissallowed on DB level with the `not_null` value or where no explicit validation for presence was set in the past. This way we keep the previous behavior and don't break any code. Commit: e2b0bf793404bab868fe5cdd3ad812c1d763d014 https://github.com/openSUSE/open-build-service/commit/e2b0bf793404bab868fe5… Author: Lukas Krause <lkrause(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M src/api/spec/controllers/webui/download_on_demand_controller_spec.rb M src/api/spec/controllers/webui/repositories_controller_spec.rb M src/api/spec/models/bs_request_action_spec.rb M src/api/spec/models/cloud/ec2/configuration_spec.rb M src/api/spec/models/cloud/user/upload_job_spec.rb M src/api/spec/models/comment_spec.rb M src/api/spec/models/commit_activity_spec.rb M src/api/spec/models/download_repository_spec.rb M src/api/spec/models/repository_spec.rb M src/api/spec/models/review_spec.rb M src/api/spec/models/staging/workflow_spec.rb M src/api/spec/models/status/report_spec.rb M src/api/spec/models/token_spec.rb Log Message: ----------- Adapt specs to take belongs_to_required_by_default into account Commit: 52547d15ed6eec7d55865d13c1adb0624872e0ac https://github.com/openSUSE/open-build-service/commit/52547d15ed6eec7d55865… Author: Rubhan Azeem <rubhanazeem(a)gmail.com> Date: 2022-01-13 (Thu, 13 Jan 2022) Changed paths: M src/api/app/models/attrib.rb M src/api/app/models/attrib_default_value.rb M src/api/app/models/attrib_namespace_modifiable_by.rb M src/api/app/models/attrib_type_modifiable_by.rb M src/api/app/models/attrib_value.rb M src/api/app/models/backend_package.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_accept_info.rb M src/api/app/models/channel_binary.rb M src/api/app/models/channel_binary_list.rb M src/api/app/models/cloud/azure/configuration.rb M src/api/app/models/cloud/ec2/configuration.rb M src/api/app/models/cloud/user/upload_job.rb M src/api/app/models/comment.rb M src/api/app/models/commit_activity.rb M src/api/app/models/concerns/staging_project.rb M src/api/app/models/download_repository.rb M src/api/app/models/event_subscription.rb M src/api/app/models/flag.rb M src/api/app/models/group_maintainer.rb M src/api/app/models/groups_user.rb M src/api/app/models/issue.rb M src/api/app/models/kiwi/description.rb M src/api/app/models/kiwi/package.rb M src/api/app/models/kiwi/package_group.rb M src/api/app/models/kiwi/preference.rb M src/api/app/models/kiwi/profile.rb M src/api/app/models/kiwi/repository.rb M src/api/app/models/linked_project.rb M src/api/app/models/maintenance_incident.rb M src/api/app/models/notification.rb M src/api/app/models/notified_project.rb M src/api/app/models/package.rb M src/api/app/models/package_kind.rb M src/api/app/models/path_element.rb M src/api/app/models/product_medium.rb M src/api/app/models/product_update_repository.rb M src/api/app/models/project.rb M src/api/app/models/project_log_entry.rb M src/api/app/models/relationship.rb M src/api/app/models/repository.rb M src/api/app/models/repository_architecture.rb M src/api/app/models/review.rb M src/api/app/models/role.rb M src/api/app/models/staging/request_exclusion.rb M src/api/app/models/staging/workflow.rb M src/api/app/models/status/check.rb M src/api/app/models/status/report.rb M src/api/app/models/status_message.rb M src/api/app/models/status_message_acknowledgement.rb M src/api/app/models/token.rb M src/api/app/models/user.rb M src/api/app/models/watched_project.rb M src/api/app/models/workflow_run.rb M src/api/config/application.rb M src/api/spec/controllers/webui/download_on_demand_controller_spec.rb M src/api/spec/controllers/webui/repositories_controller_spec.rb M src/api/spec/models/bs_request_action_spec.rb M src/api/spec/models/cloud/ec2/configuration_spec.rb M src/api/spec/models/cloud/user/upload_job_spec.rb M src/api/spec/models/comment_spec.rb M src/api/spec/models/commit_activity_spec.rb M src/api/spec/models/download_repository_spec.rb M src/api/spec/models/repository_spec.rb M src/api/spec/models/review_spec.rb M src/api/spec/models/staging/workflow_spec.rb M src/api/spec/models/status/report_spec.rb M src/api/spec/models/token_spec.rb Log Message: ----------- Merge pull request #12062 from krauselukas/enable_belongs_to_required_by_default Enable belongs to required by default Compare: https://github.com/openSUSE/open-build-service/compare/3b6e3cd6bedf...52547…

1 0

[openSUSE/obs-build] 942d22: show kernel messages in verbose mode
by Adrian Schröter 12 Jan '22

12 Jan '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 942d22286ee228102bf70f63e43c5648946dd2e1 https://github.com/openSUSE/obs-build/commit/942d22286ee228102bf70f63e43c56… Author: Adrian Schröter <adrian(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M build M build-vm Log Message: ----------- show kernel messages in verbose mode skips using "quiet" kernel parameter introducing --verbose option Commit: 349473f38773c7d3c9b27088a97b6c1f1aa18bb1 https://github.com/openSUSE/obs-build/commit/349473f38773c7d3c9b27088a97b6c… Author: Adrian Schröter <adrian(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M build-vm M build-vm-qemu Log Message: ----------- get vm-type=qemu working again * Fix virtio storage detection * avoid overwriting console overwriting, if the kernel package specifies a console name Commit: 8933e563f1edf5a30ba9dbad63c62d3d439f77ab https://github.com/openSUSE/obs-build/commit/8933e563f1edf5a30ba9dbad63c62d… Author: Adrian Schröter <adrian(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M build M build-vm M build-vm-qemu Log Message: ----------- Merge pull request #755 from adrianschroeter/get_qemu_working_again Get vm-type=qemu working again we agreed to clean it up further, but to fix the current regression for now. Compare: https://github.com/openSUSE/obs-build/compare/efeece009482...8933e563f1ed

1 0

[openSUSE/obs-build] 759e29: Fix rpm payload compression detection
by Michael Schroeder 12 Jan '22

12 Jan '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 759e293dc36e64b567c647d6e080dbd466ceded0 https://github.com/openSUSE/obs-build/commit/759e293dc36e64b567c647d6e080db… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M build-pkg-rpm Log Message: ----------- Fix rpm payload compression detection Broken with commit 92c0c6a6914b45705cd805b4082cacecc6d1c36b. The name of the variable is "PAYLOADCOMPRESS", not "PAYLOADCOMPRESSOR". Commit: 124ae2ee55a4e82c371133f3e1d5f846c390436e https://github.com/openSUSE/obs-build/commit/124ae2ee55a4e82c371133f3e1d5f8… Author: Dirk Müller <dirk(a)dmllr.de> Date: 2022-01-11 (Tue, 11 Jan 2022) Changed paths: M build-pkg-rpm Log Message: ----------- one more case of rm/cp that can be optimized the pattern of rm $b; cp $a $b can be transformed into cp --remove-destination $a $b which saves one external shell function call Commit: d0ae4446303275a28e9d7354cc97d41b050950a4 https://github.com/openSUSE/obs-build/commit/d0ae4446303275a28e9d7354cc97d4… Author: Adrian Schröter <adrian(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M build-pkg-rpm Log Message: ----------- Merge pull request #756 from dirkmueller/one_more_cp one more case of rm/cp that can be optimized Commit: 08c3a406a981b3c5c2be88bd7762fef6e491f384 https://github.com/openSUSE/obs-build/commit/08c3a406a981b3c5c2be88bd7762fe… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M build-pkg-rpm Log Message: ----------- Simplify the rpm preinstall code Commit: 9c844287220aa727d36ae964aed648773fdfd7e1 https://github.com/openSUSE/obs-build/commit/9c844287220aa727d36ae964aed648… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M PBuild/Recipe.pm Log Message: ----------- pbuild find_recipe: De-priorize the Dockerfile check If a package has both a spec and a Dockerfile, build the spec if the build type is set to spec. Commit: f62a59b3b31f06b1c8ae56b8831ea60339f86274 https://github.com/openSUSE/obs-build/commit/f62a59b3b31f06b1c8ae56b8831ea6… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M PBuild/AssetMgr.pm M PBuild/Source.pm Log Message: ----------- pbuild: refactor assetid handling Allow parsed assets to already have an assetid, add a new "immutable" indicator. Adapt ipfs asset handling. Commit: 032b83d7be056f0f7e10bcc1970d9b3046f7e2a0 https://github.com/openSUSE/obs-build/commit/032b83d7be056f0f7e10bcc1970d9b… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M PBuild/Download.pm Log Message: ----------- pbuild: implement size limit in downloader Commit: 583000846c4804a02efcb1f181cd1174bd02b3fd https://github.com/openSUSE/obs-build/commit/583000846c4804a02efcb1f181cd11… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M PBuild/AssetMgr.pm M PBuild/Cpio.pm M PBuild/RemoteAssets.pm A PBuild/Zip.pm Log Message: ----------- pbuild: Add support for golang module assets We parse the go.sum file and download all modules we find in it. They go into a "build-gomodcache" directory that can be used as the module cache for the "go" compiler. Commit: efeece00948252d141ac4584dbf6d5eaf1ee8b0c https://github.com/openSUSE/obs-build/commit/efeece00948252d141ac4584dbf6d5… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M PBuild/AssetMgr.pm M PBuild/RemoteAssets.pm M download_assets Log Message: ----------- pbuild: refactor keep_all_assets implementation We now do the asset pruning in the AssetMgr so that we do not have do duplicate the pruning code for all asset types. Compare: https://github.com/openSUSE/obs-build/compare/f3ceef817b62...efeece009482

1 0

[openSUSE/obs-build] 0eba40: show kernel messages in verbose mode
by Adrian Schröter 12 Jan '22

12 Jan '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 0eba40b29c46aca28adc5bea7d5b28a63588fd8d https://github.com/openSUSE/obs-build/commit/0eba40b29c46aca28adc5bea7d5b28… Author: Adrian Schröter <adrian(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M build M build-vm Log Message: ----------- show kernel messages in verbose mode skips using "quiet" kernel parameter introducing --verbose option Commit: f3ceef817b627f30c3a1c599cd1e8bcb4638caec https://github.com/openSUSE/obs-build/commit/f3ceef817b627f30c3a1c599cd1e8b… Author: Adrian Schröter <adrian(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M build-vm M build-vm-qemu Log Message: ----------- get vm-type=qemu working again * Fix virtio storage detection * avoid overwriting console overwriting, if the kernel package specifies a console name Compare: https://github.com/openSUSE/obs-build/compare/efeece009482...f3ceef817b62

1 0

[openSUSE/obs-build] efeece: pbuild: refactor keep_all_assets implementation
by Michael Schroeder 12 Jan '22

12 Jan '22

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: efeece00948252d141ac4584dbf6d5eaf1ee8b0c https://github.com/openSUSE/obs-build/commit/efeece00948252d141ac4584dbf6d5… Author: Michael Schroeder <mls(a)suse.de> Date: 2022-01-12 (Wed, 12 Jan 2022) Changed paths: M PBuild/AssetMgr.pm M PBuild/RemoteAssets.pm M download_assets Log Message: ----------- pbuild: refactor keep_all_assets implementation We now do the asset pruning in the AssetMgr so that we do not have do duplicate the pruning code for all asset types.

1 0