October 2021 - Open Build Service Commits

[openSUSE/open-build-service] cf123a: Update test-unit to version 3.4.8
by depfu[bot] 12 Oct '21

12 Oct '21

Branch: refs/heads/depfu/update/srcapi/test-unit-3.4.8 Home: https://github.com/openSUSE/open-build-service Commit: cf123a6fd86757fcb39d1e87c489ad81ff988e50 https://github.com/openSUSE/open-build-service/commit/cf123a6fd86757fcb39d1… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2021-10-12 (Tue, 12 Oct 2021) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update test-unit to version 3.4.8

1 0

[openSUSE/open-build-service] d9737c: Create web notification for subscribed group members
by Lukas Krause 11 Oct '21

11 Oct '21

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d9737cfc9073bb5a23a049c471c795811a7b382f https://github.com/openSUSE/open-build-service/commit/d9737cfc9073bb5a23a04… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/app/models/event_subscription/find_for_event.rb M src/api/app/services/notification_service/web_channel.rb Log Message: ----------- Create web notification for subscribed group members Having a single notification for a subscriber_type Group won't allow users of this group to have their own notifications (like marking them as read/unread). We need to create a notification for every group member. By linking a notification to a group, we can tell which groups have notifications. This is useful for UI filters. Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Co-authored-by: Lukas Krause <lkrause(a)suse.de> Commit: 6cf4a6483885bdc01a901faadd8175138cce03ba https://github.com/openSUSE/open-build-service/commit/6cf4a6483885bdc01a901… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/lib/tasks/dev.rake M src/api/spec/factories/event_subscriptions.rb M src/api/spec/jobs/send_event_emails_job_spec.rb Log Message: ----------- Adapt specs to handle web group notifications Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Co-authored-by: Lukas Krause <lkrause(a)suse.de> Commit: c8b62edbbcfcbab445fc5117db0aad0e144a9f49 https://github.com/openSUSE/open-build-service/commit/c8b62edbbcfcbab445fc5… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/app/controllers/webui/users/subscriptions_controller.rb M src/api/app/views/webui/users/subscriptions/index.html.haml M src/api/spec/features/beta/webui/notifications_spec.rb M src/api/spec/features/webui/notifications_spec.rb Log Message: ----------- Change UI for subscriptions Add checkbox to subscribe to groups notifications through the web channel. Also remove n+1 query by eager loading groups Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Co-authored-by: Lukas Krause <lkrause(a)suse.de> Commit: 3289068f5edf49c38b5a8d8c4b426645ca7aadcd https://github.com/openSUSE/open-build-service/commit/3289068f5edf49c38b5a8… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/helpers/webui/notification_helper.rb M src/api/app/jobs/send_event_emails_job.rb M src/api/app/presenters/notifications_filter_presenter.rb A src/api/app/queries/groups_for_filter_finder.rb M src/api/app/queries/notifications_finder.rb M src/api/app/views/webui/users/notifications/_notifications_filter.html.haml M src/api/spec/services/notification_service/web_channel_spec.rb Log Message: ----------- Add notification filters for groups Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Commit: f0a4143064192f0902539133e24e438592f108b8 https://github.com/openSUSE/open-build-service/commit/f0a4143064192f0902539… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/app/services/notification_service/web_channel.rb M src/api/spec/services/notification_service/web_channel_spec.rb Log Message: ----------- Add specs for group subscriptions in web channel service Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: 11c8f393aed78cb047c3e88f974a97536fcfc900 https://github.com/openSUSE/open-build-service/commit/11c8f393aed78cb047c3e… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/presenters/notification_presenter.rb Log Message: ----------- Address warnings from Bullet gem by eager loading associations Some warnings are still left and as written in the TODOs, it's quite complicated to address them. Commit: 8aa27a4c155d33c2729a9cd1d22d33e4a907aebf https://github.com/openSUSE/open-build-service/commit/8aa27a4c155d33c2729a9… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/app/models/event_subscription/find_for_event.rb M src/api/app/services/notification_service/web_channel.rb Log Message: ----------- Create web notification for subscribed group members Having a single notification for a subscriber_type Group won't allow users of this group to have their own notifications (like marking them as read/unread). We need to create a notification for every group member. By linking a notification to a group, we can tell which groups have notifications. This is useful for UI filters. Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Co-authored-by: Lukas Krause <lkrause(a)suse.de> Commit: 3c748c50289b89e65e56f0ae9009e9e378fdb6ba https://github.com/openSUSE/open-build-service/commit/3c748c50289b89e65e56f… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/app/services/notification_service/web_channel.rb M src/api/spec/services/notification_service/web_channel_spec.rb Log Message: ----------- Add specs for group subscriptions in web channel service Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: 63b0cfaac0c3b671d321db48189c6c69808f1dba https://github.com/openSUSE/open-build-service/commit/63b0cfaac0c3b671d321d… Author: Lukas Krause <lkrause(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/controllers/webui/users/subscriptions_controller.rb M src/api/app/helpers/webui/notification_helper.rb M src/api/app/jobs/send_event_emails_job.rb M src/api/app/models/event_subscription/find_for_event.rb M src/api/app/presenters/notification_presenter.rb M src/api/app/presenters/notifications_filter_presenter.rb A src/api/app/queries/groups_for_filter_finder.rb M src/api/app/queries/notifications_finder.rb M src/api/app/services/notification_service/web_channel.rb M src/api/app/views/webui/users/notifications/_notifications_filter.html.haml M src/api/app/views/webui/users/subscriptions/index.html.haml M src/api/lib/tasks/dev.rake M src/api/spec/factories/event_subscriptions.rb M src/api/spec/features/beta/webui/notifications_spec.rb M src/api/spec/features/webui/notifications_spec.rb M src/api/spec/jobs/send_event_emails_job_spec.rb M src/api/spec/services/notification_service/web_channel_spec.rb Log Message: ----------- Merge pull request #11674 from eduardoj/filter_notifications_by_group Filter notifications by group Compare: https://github.com/openSUSE/open-build-service/compare/b1fc7665a7ca...63b0c…

1 0

[openSUSE/osc] 2b278e: avoid sending entire projects on "osc mr"
by Marcus Hüwe 11 Oct '21

11 Oct '21

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 2b278e7226a4ac6baab65b6e9ba6dafabfe49f88 https://github.com/openSUSE/osc/commit/2b278e7226a4ac6baab65b6e9ba6dafabfe4… Author: Adrian Schröter <adrian(a)suse.de> Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M osc/commandline.py Log Message: ----------- avoid sending entire projects on "osc mr" We may have a package working directory, so we should only put this into request and not entire project. Commit: b6f69180e2b1bd715894007a12d44630e6f986b2 https://github.com/openSUSE/osc/commit/b6f69180e2b1bd715894007a12d44630e6f9… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M osc/commandline.py Log Message: ----------- Merge branch 'fix_mr' of https://github.com/adrianschroeter/osc Do not create an MR for the entire project if "osc mr" is invoked in a package wc (only create an MR for the specific package instead). Strictly speaking, the "breaks" the existing UI - but this rather seems to be a "fix" than a "break";) Compare: https://github.com/openSUSE/osc/compare/26aea786da1d...b6f69180e2b1

1 0

[openSUSE/osc] 81d198: Improve error message in case of an URLError
by Marcus Hüwe 11 Oct '21

11 Oct '21

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 81d1985bc5b1ea30a58a3057b09d85d206bb39f7 https://github.com/openSUSE/osc/commit/81d1985bc5b1ea30a58a3057b09d85d206bb… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2021-09-30 (Thu, 30 Sep 2021) Changed paths: M osc/babysitter.py M osc/core.py Log Message: ----------- Improve error message in case of an URLError The old code does not print any information about the host, for which the access failed, in case of an URLError. In order to fix this, add information about the host (and port) to the URLError instance in core.http_request and use this information in the babysitter to print out a more detailed error message (which includes the host (and port)). For now, we simply add a "private" "_osc_host_port" attribute to the URLError instance (this way we avoid potential name clashes (due to the "_osc" prefix) and could come up with a different/more clever way in the future (due to its privateness)). Fixes: #954 ("Better diagnostic for domain name issues") Commit: 26aea786da1dd42908c74bdaa238ab0c58091cde https://github.com/openSUSE/osc/commit/26aea786da1dd42908c74bdaa238ab0c5809… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M osc/babysitter.py M osc/core.py Log Message: ----------- Merge branch 'improve_URLError_msg' of https://github.com/marcus-h/osc Improve error message in case of an URLError. Compare: https://github.com/openSUSE/osc/compare/2b1c04757b01...26aea786da1d

1 0

[openSUSE/software-o-o] 45bbf4: Update rubocop to version 1.22.1
by depfu[bot] 11 Oct '21

11 Oct '21

Branch: refs/heads/depfu/update/rubocop-1.22.1 Home: https://github.com/openSUSE/software-o-o Commit: 45bbf465c5390bf54980c879de7befbc1c052679 https://github.com/openSUSE/software-o-o/commit/45bbf465c5390bf54980c879de7… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M Gemfile.lock Log Message: ----------- Update rubocop to version 1.22.1

1 0

[openSUSE/open-build-service] 1d75da: Add a notification groups join table
by Eduardo J. 11 Oct '21

11 Oct '21

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1d75dab788a08bcd63cde96306d588b9fc09f268 https://github.com/openSUSE/open-build-service/commit/1d75dab788a08bcd63cde… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: A src/api/db/migrate/20210929130336_create_join_table_groups_notifications.rb A src/api/db/migrate/20211005112031_add_web_to_groups_users.rb M src/api/db/schema.rb Log Message: ----------- Add a notification groups join table Also add the web field to the table groups_users Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Co-authored-by: Lukas Krause <lkrause(a)suse.de> Commit: 8c92c09791ed3c7796bd3c6b19172b7c67801b26 https://github.com/openSUSE/open-build-service/commit/8c92c09791ed3c7796bd3… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2021-10-08 (Fri, 08 Oct 2021) Changed paths: M src/api/app/models/group.rb M src/api/app/models/groups_user.rb M src/api/app/models/notification.rb Log Message: ----------- Create associations between notifications and groups Also create the `web_users` method, to retrieve the groups a user wants to be notified through the web channel. Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Co-authored-by: Lukas Krause <lkrause(a)suse.de> Commit: b1fc7665a7caadc4638dc6d3dee9767cef777209 https://github.com/openSUSE/open-build-service/commit/b1fc7665a7caadc4638dc… Author: Eduardo J <enavarro(a)suse.com> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/app/models/group.rb M src/api/app/models/groups_user.rb M src/api/app/models/notification.rb A src/api/db/migrate/20210929130336_create_join_table_groups_notifications.rb A src/api/db/migrate/20211005112031_add_web_to_groups_users.rb M src/api/db/schema.rb Log Message: ----------- Merge pull request #11710 from eduardoj/notifications_by_group_migrations Add migrations for introducing web notifications by group Compare: https://github.com/openSUSE/open-build-service/compare/5443ffe52eb5...b1fc7…

1 0

[openSUSE/open-build-service] bdb45c: Create a read-only api for notifications
by Henne Vogelsang 11 Oct '21

11 Oct '21

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: bdb45c668c3f2c18f775052406c228e15172f1ac https://github.com/openSUSE/open-build-service/commit/bdb45c668c3f2c18f7750… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: A src/api/app/controllers/person/notifications_controller.rb A src/api/app/views/person/notifications/_notification.xml.builder A src/api/app/views/person/notifications/index.xml.builder M src/api/config/routes/api_routes.rb A src/api/spec/controllers/person/notifications_controller_spec.rb Log Message: ----------- Create a read-only api for notifications Commit: b94432fbba54ac71abd2bdafa0e3028b0260cd08 https://github.com/openSUSE/open-build-service/commit/b94432fbba54ac71abd2b… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/public/apidocs-new/OBS-v2.10.50.yaml A src/api/public/apidocs-new/components/schemas/notifications.yaml A src/api/public/apidocs-new/paths/my_notifications.yaml Log Message: ----------- Add Swagger documentation to our new notifications API endpoint Commit: d9f2a53e171085ceb3e8e94221bb4cd894771127 https://github.com/openSUSE/open-build-service/commit/d9f2a53e171085ceb3e8e… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/app/controllers/person/notifications_controller.rb M src/api/spec/controllers/person/notifications_controller_spec.rb Log Message: ----------- Add check for feature flag and beta to the notifications API endpoint Commit: 49b77d92ef1e1e3345dfdeae5c8e563923c33613 https://github.com/openSUSE/open-build-service/commit/49b77d92ef1e1e3345dfd… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/app/controllers/person/notifications_controller.rb M src/api/spec/controllers/person/notifications_controller_spec.rb Log Message: ----------- Add filter options to the Notifications API endpoint Commit: 83aa40cfa28d9cba8f49e64974e7913bbd703f4b https://github.com/openSUSE/open-build-service/commit/83aa40cfa28d9cba8f49e… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: A src/api/app/controllers/person/errors.rb M src/api/app/controllers/person/notifications_controller.rb Log Message: ----------- Extract Errors to its own module Commit: 644fec08a133a7785ff98891eccdc32fd90e280a https://github.com/openSUSE/open-build-service/commit/644fec08a133a7785ff98… Author: Victor Pereira <vpereira(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/api/app/views/person/notifications/index.xml.builder Log Message: ----------- Add pagination information to the Notifications API endpoint Commit: 5443ffe52eb54ae6bf2a5da1a165a9b4d4c310db https://github.com/openSUSE/open-build-service/commit/5443ffe52eb54ae6bf2a5… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: A src/api/app/controllers/person/errors.rb A src/api/app/controllers/person/notifications_controller.rb A src/api/app/views/person/notifications/_notification.xml.builder A src/api/app/views/person/notifications/index.xml.builder M src/api/config/routes/api_routes.rb M src/api/public/apidocs-new/OBS-v2.10.50.yaml A src/api/public/apidocs-new/components/schemas/notifications.yaml A src/api/public/apidocs-new/paths/my_notifications.yaml A src/api/spec/controllers/person/notifications_controller_spec.rb Log Message: ----------- Merge pull request #11677 from vpereira/notifications_read_api Read-only api for notifications Compare: https://github.com/openSUSE/open-build-service/compare/85e409afccf9...5443f…

1 0

[openSUSE/open-build-service] 013b04: [backend] also return hdrmd5 information for Kiwi/...
by Michael Schroeder 11 Oct '21

11 Oct '21

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 013b04784fc964b78b97c9b0c21add18d39c7340 https://github.com/openSUSE/open-build-service/commit/013b04784fc964b78b97c… Author: Michael Schroeder <mls(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/backend/BSSched/BuildJob/Docker.pm M src/backend/BSSched/BuildJob/KiwiImage.pm M src/backend/BSSched/BuildJob/KiwiProduct.pm Log Message: ----------- [backend] also return hdrmd5 information for Kiwi/Docker builds Commit: 6528b89683307317ada9896443fd6be791d31ebe https://github.com/openSUSE/open-build-service/commit/6528b89683307317ada98… Author: Michael Schroeder <mls(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/backend/BSSched/BuildJob/Docker.pm M src/backend/BSSched/BuildJob/KiwiImage.pm M src/backend/BSSched/BuildJob/KiwiProduct.pm Log Message: ----------- [backend] KiwiProduct/Image/Docker: reuse the context pool if possible Commit: 85e409afccf9894552b6c91fb2cbcdaf486a0c87 https://github.com/openSUSE/open-build-service/commit/85e409afccf9894552b6c… Author: Michael Schroeder <mls(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/backend/BSSched/BuildJob/Docker.pm M src/backend/BSSched/BuildJob/KiwiImage.pm M src/backend/BSSched/BuildJob/KiwiProduct.pm Log Message: ----------- Merge pull request #11715 from mlschroe/master [backend] KiwiImage/Docker: reuse the context pool if possible Compare: https://github.com/openSUSE/open-build-service/compare/99d092731d93...85e40…

1 0

[openSUSE/open-build-service] 5a281e: [backend] delete new hdrmd5 in the testcase compar...
by Michael Schroeder 11 Oct '21

11 Oct '21

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5a281eb986825947476fc2f5c91df81a4d6bd517 https://github.com/openSUSE/open-build-service/commit/5a281eb986825947476fc… Author: Michael Schroeder <mls(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/backend/t/lib/Test/OBS.pm Log Message: ----------- [backend] delete new hdrmd5 in the testcase comparison code Should have been in commit 805bbce79579bd76456d18b9542705f6c66b72fa Commit: 99d092731d93a9732872e29e2c203b577ae4efd0 https://github.com/openSUSE/open-build-service/commit/99d092731d93a9732872e… Author: Michael Schroeder <mls(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/backend/t/lib/Test/OBS.pm Log Message: ----------- Merge pull request #11714 from mlschroe/master [backend] delete new hdrmd5 in the testcase comparison code Compare: https://github.com/openSUSE/open-build-service/compare/a562e1a4f91c...99d09…

1 0

[openSUSE/open-build-service] 805bbc: [backend] add hdrmd5 as part of buildinfo
by Michael Schroeder 11 Oct '21

11 Oct '21

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 805bbce79579bd76456d18b9542705f6c66b72fa https://github.com/openSUSE/open-build-service/commit/805bbce79579bd76456d1… Author: Adrian Schröter <adrian(a)suse.de> Date: 2021-10-04 (Mon, 04 Oct 2021) Changed paths: M src/backend/BSSched/BuildJob.pm Log Message: ----------- [backend] add hdrmd5 as part of buildinfo osc needs it to validate it's cache for repositories which do not increase build numbers on rebuild. Commit: a562e1a4f91ca8ddb18358874266cfa1ea4df956 https://github.com/openSUSE/open-build-service/commit/a562e1a4f91ca8ddb1835… Author: Michael Schroeder <mls(a)suse.de> Date: 2021-10-11 (Mon, 11 Oct 2021) Changed paths: M src/backend/BSSched/BuildJob.pm Log Message: ----------- Merge pull request #11691 from adrianschroeter/buildinf [backend] add hdrmd5 as part of buildinfo Compare: https://github.com/openSUSE/open-build-service/compare/82b00816baaa...a562e…

1 0