September 2020 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] ab5484: Fix rubocop Style/MethodCallWithArgsParentheses in...
by Lukas Krause 30 Sep '20

30 Sep '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ab5484ebebc4d9d427110f3b8cd92611a77a4967 https://github.com/openSUSE/open-build-service/commit/ab5484ebebc4d9d427110… Author: Lukas Krause <lkrause(a)suse.de> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/api/app/helpers/webui/notification_helper.rb Log Message: ----------- Fix rubocop Style/MethodCallWithArgsParentheses in notification helper Rubocop detects this offense on the master branch. This leads to a failing CI for other PR's Commit: 5858c3fd3e2d2d80a306cc1a1f0b92ec79cb00e4 https://github.com/openSUSE/open-build-service/commit/5858c3fd3e2d2d80a306c… Author: Lukas Krause <lkrause(a)suse.de> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/api/app/helpers/webui/notification_helper.rb Log Message: ----------- Merge pull request #10239 from krauselukas/fix/rubocop_master Fix rubocop Style/MethodCallWithArgsParentheses in notification helper Compare: https://github.com/openSUSE/open-build-service/compare/35067f20a240...5858c…

1 0

[obs-commits] [openSUSE/open-build-service] 8bafd3: [backend] fix hanging signing jobs again
by Michael Schroeder 30 Sep '20

30 Sep '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8bafd3b3665959fcac9dd165f0d35c7276956990 https://github.com/openSUSE/open-build-service/commit/8bafd3b3665959fcac9dd… Author: Adrian Schröter <adrian(a)suse.de> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/backend/bs_repserver Log Message: ----------- [backend] fix hanging signing jobs again fix wrong line order after beautification.... Commit: 35067f20a2407508b56c45304ba7d1bc7d8ca809 https://github.com/openSUSE/open-build-service/commit/35067f20a2407508b56c4… Author: Michael Schroeder <mls(a)suse.de> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/backend/bs_repserver Log Message: ----------- Merge pull request #10240 from adrianschroeter/fix_line_order [backend] fix hanging signing jobs again Compare: https://github.com/openSUSE/open-build-service/compare/7bd2c24be276...35067…

1 0

[obs-commits] [openSUSE/open-build-service] c49784: Show toolbar when viewing a notification
by Dany Marcoux 30 Sep '20

30 Sep '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c497842508c14928115b74d782104d4eef2338bd https://github.com/openSUSE/open-build-service/commit/c497842508c14928115b7… Author: Oleksandr Orlov <oorlov(a)suse.com> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/api/app/assets/stylesheets/webui/application.scss A src/api/app/assets/stylesheets/webui/notification_toolbar.scss M src/api/app/assets/stylesheets/webui/responsive_ux/responsive_ux.scss M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/helpers/webui/notification_helper.rb M src/api/app/presenters/notification_presenter.rb M src/api/app/queries/notifications_finder.rb A src/api/app/views/layouts/webui/_notification_toolbar.html.haml M src/api/app/views/layouts/webui/responsive_ux.html.haml Log Message: ----------- Show toolbar when viewing a notification Notification toolbar allows user to mark the notification as Read while viewing the one. The commit adds toolbar which is appeared on top of the page, under the header when viewing single notification. Fixes #9279 Commit: 7bd2c24be2760de32bb4f3f199c459d3572b3359 https://github.com/openSUSE/open-build-service/commit/7bd2c24be2760de32bb4f… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/api/app/assets/stylesheets/webui/application.scss A src/api/app/assets/stylesheets/webui/notification_toolbar.scss M src/api/app/assets/stylesheets/webui/responsive_ux/responsive_ux.scss M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/users/notifications_controller.rb M src/api/app/helpers/webui/notification_helper.rb M src/api/app/presenters/notification_presenter.rb M src/api/app/queries/notifications_finder.rb A src/api/app/views/layouts/webui/_notification_toolbar.html.haml M src/api/app/views/layouts/webui/responsive_ux.html.haml Log Message: ----------- Merge pull request #10220 from OleksandrOrlov/9279_notification_controls Show Notification Toolbar when opening notification from Notifications List Page Compare: https://github.com/openSUSE/open-build-service/compare/6b9b15c68d86...7bd2c…

1 0

[obs-commits] [openSUSE/open-build-service] 0265df: Update BS request with AJAX call
by Dany Marcoux 30 Sep '20

30 Sep '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0265dfeece54a45e6cece117c090831fde5e648a https://github.com/openSUSE/open-build-service/commit/0265dfeece54a45e6cece… Author: Oleksandr Orlov <oorlov(a)suse.com> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/_decision_tab.html.haml A src/api/app/views/webui/request/_handle_request.html.haml A src/api/app/views/webui/request/_update.js.erb M src/api/app/views/webui/request/show.html.haml Log Message: ----------- Update BS request with AJAX call The commit introduces asynchronous update for BS Requests. This was implemented in scope of adding notification toolbar feature (#10220). Previously, when the request got updated (e.g. approved/rejected), the page was refreshed and notification toolbar was removed, because it relies on 'notification_id' query parameter, but that parameter got removed after action was made on BS request. Commit: 6b9b15c68d86a84222c884f100c4ca991db4666b https://github.com/openSUSE/open-build-service/commit/6b9b15c68d86a84222c88… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/_decision_tab.html.haml A src/api/app/views/webui/request/_handle_request.html.haml A src/api/app/views/webui/request/_update.js.erb M src/api/app/views/webui/request/show.html.haml Log Message: ----------- Merge pull request #10227 from OleksandrOrlov/9279_bs_request_ajax Update BS Request with AJAX call Compare: https://github.com/openSUSE/open-build-service/compare/8ca526bbfb3d...6b9b1…

1 0

[obs-commits] [openSUSE/open-build-service] c7ddc4: [backend] extend product parsing for milestone def...
by Adrian Schröter 30 Sep '20

30 Sep '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c7ddc4d75ce1bee580e5ac8ac6deac4f614587ac https://github.com/openSUSE/open-build-service/commit/c7ddc4d75ce1bee580e5a… Author: Adrian Schröter <adrian(a)suse.de> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/backend/BSProductXML.pm Log Message: ----------- [backend] extend product parsing for milestone definition implementation is in product converter service Commit: 8ca526bbfb3ddafe37f68e9ac518190ec7225956 https://github.com/openSUSE/open-build-service/commit/8ca526bbfb3ddafe37f68… Author: Adrian Schröter <adrian(a)suse.de> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/backend/BSProductXML.pm Log Message: ----------- Merge pull request #10230 from adrianschroeter/product_conv milestone product definition Compare: https://github.com/openSUSE/open-build-service/compare/c7c4f7dad17c...8ca52…

1 0

[obs-commits] [openSUSE/open-build-service] 05f3e3: [webui] Replace `require_login` with Pundit
by Dany Marcoux 30 Sep '20

30 Sep '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 05f3e31373f89457c363d3944741bc305ba9d8d0 https://github.com/openSUSE/open-build-service/commit/05f3e31373f89457c363d… Author: Jacopo <beschi.jacopo(a)gmail.com> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/api/app/controllers/concerns/webui/rescue_handler.rb M src/api/app/controllers/webui/cloud/azure/configurations_controller.rb M src/api/app/policies/application_policy.rb A src/api/app/policies/cloud/azure/configuration_policy.rb A src/api/config/initializers/patch_pundit_exception.rb R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/DELETE_destroy/1_3_1.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/DELETE_destroy/1_3_2.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/DELETE_destroy/for_logged_in_user/1_3_2_1.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/DELETE_destroy/for_logged_in_user/1_3_2_2.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/GET_show/with_Azure_configuration/1_1_2_1.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/GET_show/with_Azure_configuration/1_1_3_1.yml M src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/GET_show/without_Azure_configuration/creates_an_Azure_configuration.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/sets_flash_error_message.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/when_proxy_auth_mode_off/1_2_1_3_1.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/when_proxy_auth_mode_on/1_2_1_4_1.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/when_request_is_xhr/returns_Please_login_error.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/with_invalid_parameters/1_2_2_1.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/with_invalid_parameters/1_2_3_1.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/with_valid_parameters/1_2_1_1.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/with_valid_parameters/1_2_2_1.yml M src/api/spec/controllers/webui/cloud/azure/configurations_controller_spec.rb M src/api/spec/factories/azure_configuration.rb A src/api/spec/policies/cloud/azure/configuration_policy_spec.rb A src/api/spec/support/shared_examples/require_logged_in_user.rb Log Message: ----------- [webui] Replace `require_login` with Pundit This is a PR of a series which replaces `require_login` with `Pundit`. You can find further relevant info in #10083. Tackles Cloud::Azure::ConfigurationController. Ref #10083 Commit: c7c4f7dad17c57b2351b9da8b746b959f75c0420 https://github.com/openSUSE/open-build-service/commit/c7c4f7dad17c57b2351b9… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/api/app/controllers/concerns/webui/rescue_handler.rb M src/api/app/controllers/webui/cloud/azure/configurations_controller.rb M src/api/app/policies/application_policy.rb A src/api/app/policies/cloud/azure/configuration_policy.rb A src/api/config/initializers/patch_pundit_exception.rb R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/DELETE_destroy/1_3_1.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/DELETE_destroy/1_3_2.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/DELETE_destroy/for_logged_in_user/1_3_2_1.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/DELETE_destroy/for_logged_in_user/1_3_2_2.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/GET_show/with_Azure_configuration/1_1_2_1.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/GET_show/with_Azure_configuration/1_1_3_1.yml M src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/GET_show/without_Azure_configuration/creates_an_Azure_configuration.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/sets_flash_error_message.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/when_proxy_auth_mode_off/1_2_1_3_1.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/when_proxy_auth_mode_on/1_2_1_4_1.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/behaves_like_require_logged_in_user/when_request_is_xhr/returns_Please_login_error.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/with_invalid_parameters/1_2_2_1.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/with_invalid_parameters/1_2_3_1.yml R src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/with_valid_parameters/1_2_1_1.yml A src/api/spec/cassettes/Webui_Cloud_Azure_ConfigurationsController/PUT_update/with_valid_parameters/1_2_2_1.yml M src/api/spec/controllers/webui/cloud/azure/configurations_controller_spec.rb M src/api/spec/factories/azure_configuration.rb A src/api/spec/policies/cloud/azure/configuration_policy_spec.rb A src/api/spec/support/shared_examples/require_logged_in_user.rb Log Message: ----------- Merge pull request #10200 from intrip/refactor_require_login_azure_configurations_ctrl Replace `require_login` with Pundit in Cloud::Azure::ConfigurationController Compare: https://github.com/openSUSE/open-build-service/compare/4595a6816af2...c7c4f…

1 0

[obs-commits] [openSUSE/open-build-service] 36d9a7: Remove unneeded code for notification.notifiable_t...
by Dany Marcoux 30 Sep '20

30 Sep '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 36d9a77d266cbf61647a85b119224bb272fa0d3c https://github.com/openSUSE/open-build-service/commit/36d9a77d266cbf61647a8… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2020-09-29 (Tue, 29 Sep 2020) Changed paths: M src/api/app/presenters/notification_presenter.rb M src/api/app/queries/notifications_finder.rb M src/api/app/services/notified_projects.rb M src/api/spec/controllers/webui/users/notifications_controller_spec.rb M src/api/spec/db/data/backfill_notified_projects_spec.rb M src/api/spec/factories/notification.rb Log Message: ----------- Remove unneeded code for notification.notifiable_type 'Review' Notifications with the notifiable_type 'Review' and the event_type 'Event::ReviewWanted' were migrated to the notifiable_type 'BsRequest' in #9883. Code specific to the notifiable_type 'Review' is since then unneeded. Commit: 4595a6816af22df3ef1ed82e002b41e5a29ee42f https://github.com/openSUSE/open-build-service/commit/4595a6816af22df3ef1ed… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2020-09-30 (Wed, 30 Sep 2020) Changed paths: M src/api/app/presenters/notification_presenter.rb M src/api/app/queries/notifications_finder.rb M src/api/app/services/notified_projects.rb M src/api/spec/controllers/webui/users/notifications_controller_spec.rb M src/api/spec/db/data/backfill_notified_projects_spec.rb M src/api/spec/factories/notification.rb Log Message: ----------- Merge pull request #10191 from dmarcoux/remove_unneeded_code_notification_notifiable_type_review Remove unneeded code for notification.notifiable_type 'Review' Compare: https://github.com/openSUSE/open-build-service/compare/66eedd78b4ca...4595a…

1 0

[obs-commits] [openSUSE/software-o-o]
by depfu[bot] 29 Sep '20

29 Sep '20

Branch: refs/heads/depfu/update/puma_worker_killer-0.3.0 Home: https://github.com/openSUSE/software-o-o

1 0

[obs-commits] [openSUSE/software-o-o] 7be446: Update puma_worker_killer to version 0.3.1
by depfu[bot] 29 Sep '20

29 Sep '20

Branch: refs/heads/depfu/update/puma_worker_killer-0.3.1 Home: https://github.com/openSUSE/software-o-o Commit: 7be4460297f1ed2fd0f6df3c8f60a970c1304929 https://github.com/openSUSE/software-o-o/commit/7be4460297f1ed2fd0f6df3c8f6… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2020-09-29 (Tue, 29 Sep 2020) Changed paths: M Gemfile.lock Log Message: ----------- Update puma_worker_killer to version 0.3.1

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu[bot] 29 Sep '20

29 Sep '20

Branch: refs/heads/depfu/update/srcapi/rubocop-ast-0.6.0 Home: https://github.com/openSUSE/open-build-service

1 0