August 2020 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] a60ab6: Correct Rubocop Style/RegexpLiteral in various files
by Henne Vogelsang 24 Aug '20

24 Aug '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a60ab620ed0a9715618807faa58a41b303b6e8d8 https://github.com/openSUSE/open-build-service/commit/a60ab620ed0a971561880… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/helpers/webui/webui_helper.rb M src/api/app/mixins/build_log_support.rb M src/api/app/services/package_service/file_verifier.rb M src/api/app/services/trigger_controller_service/token_extractor.rb M src/api/config/routes/webui_routes.rb M src/api/lib/api_error.rb M src/api/lib/tasks/coverage.rake M src/api/lib/tasks/extract.rake M src/api/lib/tasks/test_webui.rake Log Message: ----------- Correct Rubocop Style/RegexpLiteral in various files Corrections in helpers, mixins, services, routes and libs. Using // by default and %r{} just in case the regular expression contains slashes. Commit: ff674b0e7223928086331f841e330922106f44e0 https://github.com/openSUSE/open-build-service/commit/ff674b0e7223928086331… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2020-08-25 (Tue, 25 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/helpers/webui/webui_helper.rb M src/api/app/mixins/build_log_support.rb M src/api/app/services/package_service/file_verifier.rb M src/api/app/services/trigger_controller_service/token_extractor.rb M src/api/config/routes/webui_routes.rb M src/api/lib/api_error.rb M src/api/lib/tasks/coverage.rake M src/api/lib/tasks/extract.rake M src/api/lib/tasks/test_webui.rake Log Message: ----------- Merge pull request #10057 from saraycp/rubocop_autocorrect_IX_various Correct Rubocop Style/RegexpLiteral in various files Compare: https://github.com/openSUSE/open-build-service/compare/b8a12f24c033...ff674…

1 0

[obs-commits] [openSUSE/open-build-service] 0c6cbe: Correct Rubocop Style/RegexpLiteral in specs and t...
by Victor Pereira 24 Aug '20

24 Aug '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0c6cbe81e23e4c7e396ccec4d5d900688760d884 https://github.com/openSUSE/open-build-service/commit/0c6cbe81e23e4c7e396cc… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml M src/api/spec/controllers/cloud/upload_jobs_controller_spec.rb M src/api/spec/controllers/public_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/features/beta/webui/packages_spec.rb M src/api/spec/features/webui/packages_spec.rb M src/api/spec/support/vcr.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/message_controller_test.rb M src/api/test/functional/read_permission_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/request_events_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/status_controller_test.rb M src/api/test/functional/webui/spider_test.rb M src/api/test/models/event_test.rb M src/api/test/test_helper.rb M src/api/test/unit/attribute_test.rb M src/api/test/unit/package_test.rb M src/api/test/unit/schema_test.rb Log Message: ----------- Correct Rubocop Style/RegexpLiteral in specs and tests Using // by default and %r{} just in case the regular expression contains slashes. Also avoids Lint/AmbiguousRegexpLiteral adding parentheses where needed. Commit: b8a12f24c033f31bec9b00f12fcb4b233f7865d5 https://github.com/openSUSE/open-build-service/commit/b8a12f24c033f31bec9b0… Author: Victor Pereira <vpereira(a)suse.de> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml M src/api/spec/controllers/cloud/upload_jobs_controller_spec.rb M src/api/spec/controllers/public_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/features/beta/webui/packages_spec.rb M src/api/spec/features/webui/packages_spec.rb M src/api/spec/support/vcr.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/message_controller_test.rb M src/api/test/functional/read_permission_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/request_events_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/status_controller_test.rb M src/api/test/functional/webui/spider_test.rb M src/api/test/models/event_test.rb M src/api/test/test_helper.rb M src/api/test/unit/attribute_test.rb M src/api/test/unit/package_test.rb M src/api/test/unit/schema_test.rb Log Message: ----------- Merge pull request #10058 from saraycp/rubocop_autocorrect_IX_tests Correct Rubocop Style/RegexpLiteral in specs and tests Compare: https://github.com/openSUSE/open-build-service/compare/88e674aaa2b1...b8a12…

1 0

[obs-commits] [openSUSE/open-build-service] 828292: Correct Rubocop Style/RegexpLiteral in models
by Victor Pereira 24 Aug '20

24 Aug '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 82829290838827bebbcf687e10a52e7089efcae2 https://github.com/openSUSE/open-build-service/commit/82829290838827bebbcf6… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/models/cloud/ec2/configuration.rb M src/api/app/models/comment.rb M src/api/app/models/event/factory.rb M src/api/app/models/group.rb M src/api/app/models/kiwi/repository.rb M src/api/app/models/repository.rb M src/api/app/models/role.rb M src/api/app/models/service.rb M src/api/app/models/static_permission.rb M src/api/app/models/user.rb Log Message: ----------- Correct Rubocop Style/RegexpLiteral in models Using // by default and %r{} just in case the regular expression contains slashes. Commit: 88e674aaa2b1912d656213f6b68562497aace42a https://github.com/openSUSE/open-build-service/commit/88e674aaa2b1912d65621… Author: Victor Pereira <vpereira(a)suse.de> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/models/cloud/ec2/configuration.rb M src/api/app/models/comment.rb M src/api/app/models/event/factory.rb M src/api/app/models/group.rb M src/api/app/models/kiwi/repository.rb M src/api/app/models/repository.rb M src/api/app/models/role.rb M src/api/app/models/service.rb M src/api/app/models/static_permission.rb M src/api/app/models/user.rb Log Message: ----------- Merge pull request #10056 from saraycp/rubocop_autocorrect_IX_models Correct Rubocop Style/RegexpLiteral in models Compare: https://github.com/openSUSE/open-build-service/compare/0268bc752153...88e67…

1 0

[obs-commits] [openSUSE/open-build-service] 6a7a47: Correct Rubocop Style/RegexpLiteral offences in co...
by Victor Pereira 24 Aug '20

24 Aug '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6a7a4743129ce0b7fb854d4444489ed254a9b09d https://github.com/openSUSE/open-build-service/commit/6a7a4743129ce0b7fb854… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/controllers/application_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/sitemaps_controller.rb M src/api/app/controllers/webui/webui_controller.rb Log Message: ----------- Correct Rubocop Style/RegexpLiteral offences in controllers Regular expresiones can be wrapped by // or %r{}. Rubocop proposes to use only one of them and // is the preference. Only if the regular expression contains any slash, it should use %r{}. Commit: 0268bc75215329b710853c3ae28b4ae84a15698f https://github.com/openSUSE/open-build-service/commit/0268bc75215329b710853… Author: Victor Pereira <vpereira(a)suse.de> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/controllers/application_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/sitemaps_controller.rb M src/api/app/controllers/webui/webui_controller.rb Log Message: ----------- Merge pull request #10055 from saraycp/rubocop_autocorrect_IX_controllers Correct Rubocop Style/RegexpLiteral offences in controllers Compare: https://github.com/openSUSE/open-build-service/compare/7af64d7a9f04...0268b…

1 0

[obs-commits] [openSUSE/open-build-service] 24743a: Correct Rubocop Style/RedundantReturn when argumen...
by Victor Pereira 24 Aug '20

24 Aug '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 24743a765a5455bd82188c21cd5a1a49fc90533f https://github.com/openSUSE/open-build-service/commit/24743a765a5455bd82188… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/app/controllers/services/webhooks_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/webui/request_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/lib/backend/connection.rb M src/api/app/lib/suse/permission.rb M src/api/app/mixins/has_attributes.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action/differ/source_package_finder.rb M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/directory.rb M src/api/app/models/local_build_statistic/for_package.rb M src/api/app/models/service.rb M src/api/app/models/staging/request_excluder.rb M src/api/app/models/staging/staged_requests.rb M src/api/app/models/user_ldap_strategy.rb M src/api/app/services/package_controller_service/url_generator.rb M src/api/test/node_matcher.rb Log Message: ----------- Correct Rubocop Style/RedundantReturn when argument given to return Commit: ef2535111d36732a9a17e7781acf22aa2157c873 https://github.com/openSUSE/open-build-service/commit/ef2535111d36732a9a17e… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/app/controllers/attribute_controller.rb M src/api/app/controllers/build/file_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/main_controller.rb M src/api/app/controllers/webui/apidocs_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/staging/excluded_requests_controller.rb M src/api/app/controllers/webui/staging/projects_controller.rb M src/api/app/controllers/webui/staging/workflows_controller.rb M src/api/app/controllers/webui/users_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/lib/authenticator.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/event/request.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/project_log_entry.rb M src/api/app/models/repository.rb M src/api/app/models/user.rb Log Message: ----------- Correct Rubocop Style/RedundantReturn when returning without arguments Commit: e826f59b8c07bbd8da8f376a251cd6489be2f5b3 https://github.com/openSUSE/open-build-service/commit/e826f59b8c07bbd8da8f3… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml Log Message: ----------- Remove affected files from .rubocop_todo.yml Commit: 7af64d7a9f049a35a15fede32d0c903dd6013609 https://github.com/openSUSE/open-build-service/commit/7af64d7a9f049a35a15fe… Author: Victor Pereira <vpereira(a)suse.de> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/controllers/attribute_controller.rb M src/api/app/controllers/build/file_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/main_controller.rb M src/api/app/controllers/services/webhooks_controller.rb M src/api/app/controllers/webui/apidocs_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/staging/excluded_requests_controller.rb M src/api/app/controllers/webui/staging/projects_controller.rb M src/api/app/controllers/webui/staging/workflows_controller.rb M src/api/app/controllers/webui/users_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/webui/request_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/lib/authenticator.rb M src/api/app/lib/backend/connection.rb M src/api/app/lib/suse/permission.rb M src/api/app/mixins/has_attributes.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action/differ/source_package_finder.rb M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/directory.rb M src/api/app/models/event/request.rb M src/api/app/models/local_build_statistic/for_package.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/project_log_entry.rb M src/api/app/models/repository.rb M src/api/app/models/service.rb M src/api/app/models/staging/request_excluder.rb M src/api/app/models/staging/staged_requests.rb M src/api/app/models/user.rb M src/api/app/models/user_ldap_strategy.rb M src/api/app/services/package_controller_service/url_generator.rb M src/api/test/node_matcher.rb Log Message: ----------- Merge pull request #10051 from saraycp/rubocop_autocorrect_VIII Correct Rubocop Style/RedundantReturn offenses Compare: https://github.com/openSUSE/open-build-service/compare/c7c400b4bb1f...7af64…

1 0

[obs-commits] [openSUSE/open-build-service] b2fd83: Hide file action column for anonymous
by Henne Vogelsang 24 Aug '20

24 Aug '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b2fd83a34c53d3e78a19bdb7cf90adfa18bc89e7 https://github.com/openSUSE/open-build-service/commit/b2fd83a34c53d3e78a19b… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/app/views/webui/package/_file.html.haml M src/api/app/views/webui/package/_files_view.html.haml Log Message: ----------- Hide file action column for anonymous Downloading files requires people to log in. Even if it goes through the `/source` API route. Offering this makes some web spiders that do not pay attention to robots.txt produce lots of 401s. Commit: c7c400b4bb1fa1fecc1e4ef2958173575294ad75 https://github.com/openSUSE/open-build-service/commit/c7c400b4bb1fa1fecc1e4… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/app/views/webui/package/_file.html.haml M src/api/app/views/webui/package/_files_view.html.haml Log Message: ----------- Merge pull request #10053 from hennevogel/feature/remove-download-file Hide file action column for anonymous Compare: https://github.com/openSUSE/open-build-service/compare/10931292b51c...c7c40…

1 0

[obs-commits] [openSUSE/open-build-service] 8b8c3e: Fix RuboCop offenses for Rails/PluckInWhere
by Quang Tran 24 Aug '20

24 Aug '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8b8c3ebd91c47ea2d0aa3b597236ac602094a373 https://github.com/openSUSE/open-build-service/commit/8b8c3ebd91c47ea2d0aa3… Author: Quang Tran <quang.tran(a)suse.com> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/models/group.rb M src/api/app/models/package.rb M src/api/app/models/review.rb M src/api/app/queries/open_requests_finder.rb Log Message: ----------- Fix RuboCop offenses for Rails/PluckInWhere Commit: 10931292b51c9f44950a40a67cfe74ff64e578e7 https://github.com/openSUSE/open-build-service/commit/10931292b51c9f44950a4… Author: Quang Tran <quang.tran(a)suse.com> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/models/group.rb M src/api/app/models/package.rb M src/api/app/models/review.rb M src/api/app/queries/open_requests_finder.rb Log Message: ----------- Merge pull request #10047 from quatran/fix_rubocop_rails_pluckinwhere Fix RuboCop offenses for Rails/PluckInWhere Compare: https://github.com/openSUSE/open-build-service/compare/05e22399fef3...10931…

1 0

[obs-commits] [openSUSE/open-build-service] f09716: Update Rubocop's TODOs file
by Dany Marcoux 24 Aug '20

24 Aug '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f09716f5b27fb6936fc54e35103e2539e3b52296 https://github.com/openSUSE/open-build-service/commit/f09716f5b27fb6936fc54… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml Log Message: ----------- Update Rubocop's TODOs file Commit: 05e22399fef37185918c293fdf4e73cc4fb9d783 https://github.com/openSUSE/open-build-service/commit/05e22399fef37185918c2… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/api/.rubocop_todo.yml Log Message: ----------- Merge pull request #10049 from saraycp/update_rubocop_todo Update Rubocop's TODOs file Compare: https://github.com/openSUSE/open-build-service/compare/23b447b607b2...05e22…

1 0

[obs-commits] [openSUSE/open-build-service] 4a0cb1: [backend] bs_publish fix layers-check for helm chart
by Sumit Jamgade 24 Aug '20

24 Aug '20

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4a0cb1ca44c1b02b317844afc92094db6fef3e56 https://github.com/openSUSE/open-build-service/commit/4a0cb1ca44c1b02b31784… Author: Sumit Jamgade <sjamgade(a)suse.com> Date: 2020-08-21 (Fri, 21 Aug 2020) Changed paths: M src/backend/bs_regpush Log Message: ----------- [backend] bs_publish fix layers-check for helm chart in case config has no rootfs then there are diff_ids to match against the layers. So ignore checking diff_ids == layers Commit: 23b447b607b2f826f867ca8962988431fb571409 https://github.com/openSUSE/open-build-service/commit/23b447b607b2f826f867c… Author: Sumit Jamgade <25170818+sjamgade(a)users.noreply.github.com> Date: 2020-08-24 (Mon, 24 Aug 2020) Changed paths: M src/backend/bs_regpush Log Message: ----------- Merge pull request #10041 from sjamgade/externalhelmpublish [backend] bs_publish fix layers-check for helm chart Compare: https://github.com/openSUSE/open-build-service/compare/27e0c490a831...23b44…

1 0

[obs-commits] [openSUSE/open-build-service]
by Dany Marcoux 24 Aug '20

24 Aug '20

Branch: refs/heads/depfu/update/srcapi/autoprefixer-rails-9.8.6.2 Home: https://github.com/openSUSE/open-build-service

1 0