Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 929f1c26820e6edd6ce368f0649e088b0cea9df7
https://github.com/openSUSE/open-build-service/commit/929f1c26820e6edd6ce36…
Author: Eduardo Navarro <enavarro(a)suse.com>
Date: 2020-04-27 (Mon, 27 Apr 2020)
Changed paths:
M src/api/app/services/notification_creator.rb
Log Message:
-----------
Associate projects to notifications
When a notification is created, we also add its associated projects.
Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de>
Commit: f93352f395db8edef69def9b9e6246ecd4af2a95
https://github.com/openSUSE/open-build-service/commit/f93352f395db8edef69de…
Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de>
Date: 2020-04-27 (Mon, 27 Apr 2020)
Changed paths:
M src/api/app/controllers/webui/users/notifications_controller.rb
M src/api/app/helpers/webui/notification_helper.rb
M src/api/app/helpers/webui/webui_helper.rb
M src/api/app/queries/notifications_finder.rb
M src/api/app/services/notification_creator.rb
M src/api/app/views/webui/users/notifications/index.html.haml
Log Message:
-----------
Filter notifications by project
Show a clickable list of projects to filter notifications by them.
Each item on the filter by project list, displays the project's name and the amount
of notifications associated to the project.
The list is sorted by amount of notifications and then name.
Co-authored-by: Eduardo Navarro <enavarro(a)suse.com>
Commit: c657fc5232e0da64123a2e06baf7c24f56898c4a
https://github.com/openSUSE/open-build-service/commit/c657fc5232e0da64123a2…
Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de>
Date: 2020-04-27 (Mon, 27 Apr 2020)
Changed paths:
M src/api/app/models/notified_project.rb
Log Message:
-----------
Add validation for the notification and project association
The pair notification and project should be unique.
Commit: 0317ed47b7f35c4699162d7cc9f090d867d8f26e
https://github.com/openSUSE/open-build-service/commit/0317ed47b7f35c4699162…
Author: Victor Pereira <vpereira(a)suse.de>
Date: 2020-04-27 (Mon, 27 Apr 2020)
Changed paths:
M src/api/app/controllers/webui/users/notifications_controller.rb
M src/api/app/helpers/webui/notification_helper.rb
M src/api/app/helpers/webui/webui_helper.rb
M src/api/app/models/notified_project.rb
M src/api/app/queries/notifications_finder.rb
M src/api/app/services/notification_creator.rb
M src/api/app/views/webui/users/notifications/index.html.haml
Log Message:
-----------
Merge pull request #9447 from saraycp/notifications_filtered_by_projects
Notifications filtered by projects
Compare: https://github.com/openSUSE/open-build-service/compare/90847a2aecf0...0317e…
Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 4ca31916d654d942592c1f741b79b8d58339f30c
https://github.com/openSUSE/open-build-service/commit/4ca31916d654d942592c1…
Author: David Kang <dkang(a)suse.com>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
A src/api/db/migrate/20200422134122_add_rss_and_web_to_notification.rb
M src/api/db/structure.sql
Log Message:
-----------
Add columns rss and web to notifications table
Commit: f722f98fd7505f1fc41758666c7b39d2d56171cb
https://github.com/openSUSE/open-build-service/commit/f722f98fd7505f1fc4175…
Author: David Kang <dkang(a)suse.com>
Date: 2020-04-27 (Mon, 27 Apr 2020)
Changed paths:
M src/api/app/jobs/send_event_emails_job.rb
M src/api/app/models/event/base.rb
M src/api/app/models/event_subscription/find_for_event.rb
M src/api/app/services/notification_creator.rb
M src/api/spec/db/data/regenerate_notifications_spec.rb
M src/api/spec/jobs/send_event_emails_job_spec.rb
M src/api/spec/services/notification_creator_spec.rb
Log Message:
-----------
Adapt NotificationCreator and Job to handle new channels
We need to adapt `SendEventEmailsJob` job the send emails and
notifications for the enabled channels (rss and web).
Commit: f7353bb65992e8b65255a3e266b39dcf628376b5
https://github.com/openSUSE/open-build-service/commit/f7353bb65992e8b65255a…
Author: David Kang <dkang(a)suse.com>
Date: 2020-04-27 (Mon, 27 Apr 2020)
Changed paths:
M src/api/app/controllers/webui/users/notifications_controller.rb
M src/api/app/models/group.rb
M src/api/app/models/notification.rb
M src/api/app/models/user.rb
M src/api/app/services/notification_creator.rb
M src/api/spec/controllers/webui/users/notifications_controller_spec.rb
M src/api/spec/factories/notification.rb
M src/api/spec/models/user_spec.rb
Log Message:
-----------
Use Notification instead of Notification::RssFeedItem
We plan to remove the column type from `Notification` and remove the
class `Notification::RssFeedItem` and only use Notification class.
The first step is not use this class anymore. After that we should
create a migration to remove the column type and get rid the class
`Notification::RssFeedItem`.
For that we created new `scopes` to fetch the notifications for the
different channels.
Commit: 832241d58fc53ffd1361b8f8eaab92f06abd85f3
https://github.com/openSUSE/open-build-service/commit/832241d58fc53ffd1361b…
Author: David Kang <dkang(a)suse.com>
Date: 2020-04-27 (Mon, 27 Apr 2020)
Changed paths:
A src/api/db/data/20200424080753_generate_web_notifications.rb
M src/api/db/data_schema.rb
A src/api/spec/db/data/generate_web_notifications_spec.rb
Log Message:
-----------
Add data migration for generate EventSubscriptions
We generate EventSubscriptions for `rss` and `web` channels if we
found a EventSubscription enabled (channel == :instant_email).
Commit: 90847a2aecf00d8e56564a08ce8520cd41f92173
https://github.com/openSUSE/open-build-service/commit/90847a2aecf00d8e56564…
Author: Henne Vogelsang <hvogel(a)opensuse.org>
Date: 2020-04-27 (Mon, 27 Apr 2020)
Changed paths:
M src/api/app/controllers/webui/users/notifications_controller.rb
M src/api/app/jobs/send_event_emails_job.rb
M src/api/app/models/event/base.rb
M src/api/app/models/event_subscription/find_for_event.rb
M src/api/app/models/group.rb
M src/api/app/models/notification.rb
M src/api/app/models/user.rb
M src/api/app/services/notification_creator.rb
A src/api/db/data/20200424080753_generate_web_notifications.rb
M src/api/db/data_schema.rb
A src/api/db/migrate/20200422134122_add_rss_and_web_to_notification.rb
M src/api/db/structure.sql
M src/api/spec/controllers/webui/users/notifications_controller_spec.rb
A src/api/spec/db/data/generate_web_notifications_spec.rb
M src/api/spec/db/data/regenerate_notifications_spec.rb
M src/api/spec/factories/notification.rb
M src/api/spec/jobs/send_event_emails_job_spec.rb
M src/api/spec/models/user_spec.rb
M src/api/spec/services/notification_creator_spec.rb
Log Message:
-----------
Merge pull request #9430 from DavidKang/notification/jobs-and-user-notification
Adapt Job to handle new notification channels
Compare: https://github.com/openSUSE/open-build-service/compare/8660152a4d1c...90847…
Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: c730462f265035b54ac07ed8a3c223e2a7c65262
https://github.com/openSUSE/open-build-service/commit/c730462f265035b54ac07…
Author: Eduardo Navarro <enavarro(a)suse.com>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
A src/api/db/migrate/20200421115317_create_join_table_notified_projects.rb
M src/api/db/structure.sql
Log Message:
-----------
Create notified_projects join table
Retrieving the projects of a notification, requires querying for comments,
requests and reviews. We want to avoid n+1 queries instead of going through
the polymorphic associations notifiable and notifiable.commentable for
comments.
We need to have an ID in the table since we'll be using a `has_many through:`
association
Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com>
Co-authored-by: David Kang <dkang(a)suse.com>
Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de>
Commit: e85d1203ab053fe605b8f24ed220de344810353c
https://github.com/openSUSE/open-build-service/commit/e85d1203ab053fe605b8f…
Author: Dany Marcoux <dmarcoux(a)posteo.de>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
M src/api/app/models/notification.rb
A src/api/app/models/notified_project.rb
M src/api/app/models/project.rb
Log Message:
-----------
Add model and associations for join table notified_projects
Commit: cef8f358b6fa12704ef765d71dbc96059a20ad12
https://github.com/openSUSE/open-build-service/commit/cef8f358b6fa12704ef76…
Author: Eduardo Navarro <enavarro(a)suse.com>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
A src/api/app/services/notified_projects.rb
Log Message:
-----------
Create service to get the projects of a notification
This service retrieves the associated projects of a notification.
It will be used either by the notification creation from events,
or from a data migration that will fill the notifications' projects
after the notified_projects table was introduced.
Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de>
Commit: de3eba3b9d8e765364b50a95eef2396bf5a54107
https://github.com/openSUSE/open-build-service/commit/de3eba3b9d8e765364b50…
Author: Dany Marcoux <dmarcoux(a)posteo.de>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
A src/api/db/data/20200421121610_backfill_notified_projects.rb
A src/api/spec/cassettes/BackfillNotifiedProjects/up/backfills_the_notifications_projects_table_with_all_projects_from_existing_notifications.yml
A src/api/spec/db/data/backfill_notified_projects_spec.rb
Log Message:
-----------
Add migration to backfill notified_projects table
Commit: 2392177bccc6908cb002fee54e998a446fce0830
https://github.com/openSUSE/open-build-service/commit/2392177bccc6908cb002f…
Author: Victor Pereira <vpereira(a)suse.de>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
M src/api/app/models/notification.rb
A src/api/app/models/notified_project.rb
M src/api/app/models/project.rb
A src/api/app/services/notified_projects.rb
A src/api/db/data/20200421121610_backfill_notified_projects.rb
A src/api/db/migrate/20200421115317_create_join_table_notified_projects.rb
M src/api/db/structure.sql
A src/api/spec/cassettes/BackfillNotifiedProjects/up/backfills_the_notifications_projects_table_with_all_projects_from_existing_notifications.yml
A src/api/spec/db/data/backfill_notified_projects_spec.rb
Log Message:
-----------
Merge pull request #9433 from dmarcoux/data-migration-notified-projects
Create and backfill notified_projects table
Compare: https://github.com/openSUSE/open-build-service/compare/f4bc345a71ad...23921…
Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 0232a9b633ef27c0d157743856d67f9488ef692b
https://github.com/openSUSE/open-build-service/commit/0232a9b633ef27c0d1577…
Author: Dani Donisa <daniel.donisa(a)suse.com>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
M src/api/app/controllers/webui/projects/pulse_controller.rb
Log Message:
-----------
Set pulse data for all request types
Now we only set the pulse data for ajax requests.
When bots hit a project's pulse page, the before_action is not called
and then the page breaks.
Fixes #9370
Commit: 8f4e2ad2ef62bf5231ad2f5d428cd3d118453274
https://github.com/openSUSE/open-build-service/commit/8f4e2ad2ef62bf5231ad2…
Author: Dani Donisa <daniel.donisa(a)suse.com>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
M src/api/app/controllers/webui/projects/pulse_controller.rb
Log Message:
-----------
Forbid bot access to the pulse page
Commit: f4bc345a71ad37750986f001e3f5a111af25f427
https://github.com/openSUSE/open-build-service/commit/f4bc345a71ad37750986f…
Author: Victor Pereira <vpereira(a)suse.de>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
M src/api/app/controllers/webui/projects/pulse_controller.rb
Log Message:
-----------
Merge pull request #9440 from danidoni/render_pulse_even_for_non_xhr_requests
Set pulse data for all request types
Compare: https://github.com/openSUSE/open-build-service/compare/cba7a27a3086...f4bc3…
Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 03e888f223e8d5e3b8a445e306ba7cbc0f622c9a
https://github.com/openSUSE/open-build-service/commit/03e888f223e8d5e3b8a44…
Author: David Kang <dkang(a)suse.com>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
M src/api/app/models/event_subscription.rb
A src/api/db/migrate/20200423160517_add_enabled_to_event_subscription.rb
M src/api/db/structure.sql
M src/api/spec/factories/event_subscriptions.rb
M src/api/spec/models/event_subscription/find_for_event_spec.rb
M src/api/spec/support/shared_contexts/a_user_and_subscriptions.rb
M src/api/spec/support/shared_contexts/a_user_and_subscriptions_with_defaults.rb
M src/api/spec/support/shared_examples/a_subscriptions_form_for_subscriber.rb
M src/api/test/fixtures/event_subscriptions.yml
M src/api/test/functional/maintenance_test.rb
M src/api/test/models/event_test.rb
Log Message:
-----------
Add new notification channels and enable field
We added two new channels,`rss` and 'web`, to make the notification
settings more granular. We also added a new field called `enable` to
know if the subscription is enabled.
Commit: c705ed5e7266cc8405b3557cfda8d901784d54c0
https://github.com/openSUSE/open-build-service/commit/c705ed5e7266cc8405b35…
Author: David Kang <dkang(a)suse.com>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
M src/api/app/models/event_subscription.rb
A src/api/app/models/event_subscription/for_channel_form.rb
A src/api/app/models/event_subscription/for_event_form.rb
A src/api/app/models/event_subscription/for_role_form.rb
R src/api/app/models/event_subscription/generate_hash_for_subscriber.rb
A src/api/spec/models/event_subscription/for_event_form_spec.rb
A src/api/spec/models/event_subscription/for_role_form_spec.rb
R src/api/spec/models/event_subscription/generate_hash_for_subscriber_spec.rb
Log Message:
-----------
Use objects instead of hash
Co-authored-by: Daniel Donisa <daniel.donisa(a)suse.com>
Commit: fe76c923deca4968b1d91e21c39d21e0e7acbbaa
https://github.com/openSUSE/open-build-service/commit/fe76c923deca4968b1d91…
Author: David Kang <dkang(a)suse.com>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
M src/api/app/models/event_subscription/form.rb
Log Message:
-----------
Adapt EventSubscription::Form#update! to handle multiple channels
Commit: a3cf9c1cdf39fe148f25e880969434217c1ce0af
https://github.com/openSUSE/open-build-service/commit/a3cf9c1cdf39fe148f25e…
Author: David Kang <dkang(a)suse.com>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
M src/api/app/controllers/webui/users/subscriptions_controller.rb
M src/api/app/views/webui/subscriptions/_subscriptions_form.html.haml
M src/api/spec/features/webui/notifications_spec.rb
Log Message:
-----------
Adapt notification configuration view to handle new channels
We need to adapt the view to render different checkbox for the new
channels. Each checkbox is a `EventSubscription` specific event_type, role
and channel.
Co-authored-by: Daniel Donisa <daniel.donisa(a)suse.com>
Commit: cba7a27a3086119ae053f71cb96a4dd4231dce50
https://github.com/openSUSE/open-build-service/commit/cba7a27a3086119ae053f…
Author: Victor Pereira <vpereira(a)suse.de>
Date: 2020-04-24 (Fri, 24 Apr 2020)
Changed paths:
M src/api/app/controllers/webui/users/subscriptions_controller.rb
M src/api/app/models/event_subscription.rb
A src/api/app/models/event_subscription/for_channel_form.rb
A src/api/app/models/event_subscription/for_event_form.rb
A src/api/app/models/event_subscription/for_role_form.rb
M src/api/app/models/event_subscription/form.rb
R src/api/app/models/event_subscription/generate_hash_for_subscriber.rb
M src/api/app/views/webui/subscriptions/_subscriptions_form.html.haml
A src/api/db/migrate/20200423160517_add_enabled_to_event_subscription.rb
M src/api/db/structure.sql
M src/api/spec/factories/event_subscriptions.rb
M src/api/spec/features/webui/notifications_spec.rb
M src/api/spec/models/event_subscription/find_for_event_spec.rb
A src/api/spec/models/event_subscription/for_event_form_spec.rb
A src/api/spec/models/event_subscription/for_role_form_spec.rb
R src/api/spec/models/event_subscription/generate_hash_for_subscriber_spec.rb
M src/api/spec/support/shared_contexts/a_user_and_subscriptions.rb
M src/api/spec/support/shared_contexts/a_user_and_subscriptions_with_defaults.rb
M src/api/spec/support/shared_examples/a_subscriptions_form_for_subscriber.rb
M src/api/test/fixtures/event_subscriptions.yml
M src/api/test/functional/maintenance_test.rb
M src/api/test/models/event_test.rb
Log Message:
-----------
Merge pull request #9405 from DavidKang/notification/configure-channels
Configure multiple notification channels
Compare: https://github.com/openSUSE/open-build-service/compare/826dff0ed78f...cba7a…