Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: 6024dbbdb2949a02ffedada0a46840e6229cd892
https://github.com/openSUSE/open-build-service/commit/6024dbbdb2949a02ffeda…
Author: Victor Pereira <vpereira(a)suse.de>
Date: 2019-04-25 (Thu, 25 Apr 2019)
Changed paths:
M src/api/app/models/comment.rb
A src/api/app/presenters/comments_controller_presenters/comment_presenter.rb
A src/api/app/views/comments/_comment.xml.builder
M src/api/app/views/comments/index.xml.builder
M src/api/spec/models/comment_spec.rb
A src/api/spec/presenters/comments_controller_presenters/comment_presenter_spec.rb
Log Message:
-----------
Use render partial to render a collection of comments
Move model rendering to the view, lift some view code to a presenter
Commit: 29f543c15850aff219f7d3e186c383c2c071b896
https://github.com/openSUSE/open-build-service/commit/29f543c15850aff219f7d…
Author: Victor Pereira <vpereira(a)suse.de>
Date: 2019-04-26 (Fri, 26 Apr 2019)
Changed paths:
M src/api/app/models/comment.rb
A src/api/app/presenters/comments_controller_presenters/comment_presenter.rb
A src/api/app/views/comments/_comment.xml.builder
M src/api/app/views/comments/index.xml.builder
M src/api/spec/models/comment_spec.rb
A src/api/spec/presenters/comments_controller_presenters/comment_presenter_spec.rb
Log Message:
-----------
Merge pull request #7445 from vpereira/comment_partial_builder
Use render partial to render a collection of comments
Compare: https://github.com/openSUSE/open-build-service/compare/9fa2eda3e651...29f54…
Branch: refs/heads/master
Home: https://github.com/openSUSE/open-build-service
Commit: b1cd2d18f1df12fadea0d05edaa163689368cbea
https://github.com/openSUSE/open-build-service/commit/b1cd2d18f1df12fadea0d…
Author: Björn Geuken <bgeuken(a)suse.de>
Date: 2019-04-25 (Thu, 25 Apr 2019)
Changed paths:
M src/api/app/controllers/webui/download_on_demand_controller.rb
M src/api/app/controllers/webui/package_controller.rb
M src/api/app/controllers/webui/webui_controller.rb
Log Message:
-----------
Catch unhandled backend errors and show a proper error message in the UI
This will catch Backend::Error and Timeout::Error exceptions and
redirect users the previous page. The exception will be send to errbit.
Many of the webui controllers call store without worrying about
possible exceptions that could be raised. This change makes sure
that we have a generic solution for this.
Commit: d8a5375c6903f5817c58cf2929e5e3413444cf30
https://github.com/openSUSE/open-build-service/commit/d8a5375c6903f5817c58c…
Author: Björn Geuken <bgeuken(a)suse.de>
Date: 2019-04-25 (Thu, 25 Apr 2019)
Changed paths:
M src/api/spec/controllers/webui/package_controller_spec.rb
Log Message:
-----------
Use an RSpec subject instead of storing http requests in a let block
let is meant for storing variables.
Commit: c6e22b872720cdf107f55162eb1e703247632136
https://github.com/openSUSE/open-build-service/commit/c6e22b872720cdf107f55…
Author: Björn Geuken <bgeuken(a)suse.de>
Date: 2019-04-25 (Thu, 25 Apr 2019)
Changed paths:
M src/api/app/controllers/webui/package_controller.rb
M src/api/spec/controllers/webui/package_controller_spec.rb
Log Message:
-----------
Binary page: Show an error message when there was a backend error
Previously we were showing the 404 error page in such cases. We
have a generic exception handler in the webui controller that we can
use instead.
This way we redirect back and show a nice error message instead of
rendering the generic 404 view.
Commit: 9fa2eda3e651c1f4ff5ea4c5ac98e47045d93286
https://github.com/openSUSE/open-build-service/commit/9fa2eda3e651c1f4ff5ea…
Author: Victor Pereira <vpereira(a)suse.de>
Date: 2019-04-26 (Fri, 26 Apr 2019)
Changed paths:
M src/api/app/controllers/webui/download_on_demand_controller.rb
M src/api/app/controllers/webui/package_controller.rb
M src/api/app/controllers/webui/webui_controller.rb
M src/api/spec/controllers/webui/package_controller_spec.rb
Log Message:
-----------
Merge pull request #7423 from bgeuken/add_generic_exception_handling_for_backend_failures
Catch unhandled backend errors and show a proper error message in the UI
Compare: https://github.com/openSUSE/open-build-service/compare/4be15cabe241...9fa2e…