February 2019 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 4a505f: Raise RoutingError instead of using nextstatus
by Dany Marcoux 28 Feb '19

28 Feb '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4a505f1b34f37350159b782563eacbc4fd0700a1 https://github.com/openSUSE/open-build-service/commit/4a505f1b34f37350159b7… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/packages/build_reason_controller.rb M src/api/app/controllers/webui/packages/job_history_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/projects/project_configuration_controller.rb M src/api/app/controllers/webui/repositories_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/controllers/webui2/project_controller.rb A src/api/spec/cassettes/Webui_ProjectController/GET_show/with_patchinfo/1_13_2_1.yml R src/api/spec/cassettes/Webui_ProjectController/GET_show/with_patchinfo/1_13_4_1.yml M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/controllers/webui/projects/project_configuration_controller_spec.rb Log Message: ----------- Raise RoutingError instead of using nextstatus Avoid unneeded code Fixes #6933 Commit: dcb31bdb7f1a8f73c4c555373ad6ce2d38b1eee8 https://github.com/openSUSE/open-build-service/commit/dcb31bdb7f1a8f73c4c55… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/packages/build_reason_controller.rb M src/api/app/controllers/webui/packages/job_history_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/projects/project_configuration_controller.rb M src/api/app/controllers/webui/repositories_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/controllers/webui2/project_controller.rb A src/api/spec/cassettes/Webui_ProjectController/GET_show/with_patchinfo/1_13_2_1.yml R src/api/spec/cassettes/Webui_ProjectController/GET_show/with_patchinfo/1_13_4_1.yml M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/controllers/webui/projects/project_configuration_controller_spec.rb Log Message: ----------- Merge pull request #7048 from dmarcoux/use-redirect_to-status Use redirect_to without custom nextstatus Compare: https://github.com/openSUSE/open-build-service/compare/fb8dfa89405f...dcb31…

1 0

[obs-commits] [openSUSE/open-build-service] 7ae59d: [backend] do not simply remove the worker building...
by Michael Schroeder 28 Feb '19

28 Feb '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7ae59d3483a2c15272f3d114f6f5c4434d27015f https://github.com/openSUSE/open-build-service/commit/7ae59d3483a2c15272f3d… Author: Michael Schroeder <mls(a)suse.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/backend/bs_repserver Log Message: ----------- [backend] do not simply remove the worker building data Removing it can make the dispatcher abort jobs with "no compliant workers found". Instead, move the worker data to "down" for a short amount of time. This is not optimal, but introducing a new "resting" state seems a bit overkill... Commit: fb8dfa89405f041725d0502d755461c69a16735b https://github.com/openSUSE/open-build-service/commit/fb8dfa89405f041725d05… Author: Michael Schroeder <mls(a)suse.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/backend/bs_repserver Log Message: ----------- Merge pull request #7075 from mlschroe/master [backend] do not simply remove the worker building data Compare: https://github.com/openSUSE/open-build-service/compare/2de5a645dca9...fb8df…

1 0

[obs-commits] [openSUSE/open-build-service] 2072ad: Migrate user creation page to bootstrap
by Björn Geuken 28 Feb '19

28 Feb '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2072ad10e0b9d9cc402043e7568a450e4224170c https://github.com/openSUSE/open-build-service/commit/2072ad10e0b9d9cc40204… Author: Lukas Krause <lkrause(a)suse.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/controllers/webui/user_controller.rb M src/api/app/views/layouts/webui2/_personal_navigation.html.haml M src/api/app/views/webui2/shared/_sign_up.html.haml M src/api/app/views/webui2/webui/main/index.html.haml M src/api/app/views/webui2/webui/user/_breadcrumb_items.html.haml M src/api/app/views/webui2/webui/user/index.html.haml A src/api/app/views/webui2/webui/user/register_user.html.haml A src/api/app/views/webui2/webui/user/signup.html.haml M src/api/config/routes.rb Log Message: ----------- Migrate user creation page to bootstrap We are migrating the configuration section to bootstrap. The manage user page belongs to this area and includes the user creation. Commit: 2de5a645dca9a1f4aa4d39f3a14203ed59849bca https://github.com/openSUSE/open-build-service/commit/2de5a645dca9a1f4aa4d3… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/controllers/webui/user_controller.rb M src/api/app/views/layouts/webui2/_personal_navigation.html.haml M src/api/app/views/webui2/shared/_sign_up.html.haml M src/api/app/views/webui2/webui/main/index.html.haml M src/api/app/views/webui2/webui/user/_breadcrumb_items.html.haml M src/api/app/views/webui2/webui/user/index.html.haml A src/api/app/views/webui2/webui/user/register_user.html.haml A src/api/app/views/webui2/webui/user/signup.html.haml M src/api/config/routes.rb Log Message: ----------- Merge pull request #7064 from krauselukas/bootstrap/create_user02 Migrate user creation page to bootstrap Compare: https://github.com/openSUSE/open-build-service/compare/d98e126cf506...2de5a…

1 0

[obs-commits] [openSUSE/open-build-service] 75d7eb: Add a bento_only for project#linking_projects
by Björn Geuken 28 Feb '19

28 Feb '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 75d7eb693aca79710e6ed7cdb27f52a087b20dc3 https://github.com/openSUSE/open-build-service/commit/75d7eb693aca79710e6ed… Author: Ana María Martínez Gómez <anamaria(a)martinezgomez.name> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/controllers/webui/project_controller.rb Log Message: ----------- Add a bento_only for project#linking_projects In the new UI we used the @linking_projects variable instead of calling the controller again. For more details check: https://github.com/openSUSE/open-build-service/pull/7071 Commit: d98e126cf50620daba6d4adf0eacea3b35f83c46 https://github.com/openSUSE/open-build-service/commit/d98e126cf50620daba6d4… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/controllers/webui/project_controller.rb Log Message: ----------- Merge pull request #7077 from Ana06/linking-project-todo Add a bento_only for project#linking_projects Compare: https://github.com/openSUSE/open-build-service/compare/cfdb6a79d2f1...d98e1…

1 0

[obs-commits] [openSUSE/open-build-service] ecdaac: Don't let disabled projects/repos pass stagings as...
by Stephan Kulow 28 Feb '19

28 Feb '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ecdaac813a0987658c81e4b4e0b352db29ea1e61 https://github.com/openSUSE/open-build-service/commit/ecdaac813a0987658c81e… Author: Stephan Kulow <coolo(a)suse.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/models/obs_factory/staging_project.rb M src/api/app/models/staging/staging_project.rb A src/api/spec/cassettes/Staging_StagingProject/_overall_state/with_disabled_repository/1_3_10_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/with_disabled_repository/1_3_10_2.yml M src/api/spec/models/obs_factory/staging_project_spec.rb M src/api/spec/models/staging/staging_project_spec.rb Log Message: ----------- Don't let disabled projects/repos pass stagings as acceptable When osc crashes while selecting, sometimes we don't reenable the staging project and then it becomes acceptable - which is an error. We discussed this in the release manager round and there is no valid use case of having disabled repositories *and* wanting it to be acceptable. Mapping this to 'building' is obviously a little fake, but unacceptable sounds too harsh too. So in building stagings the RM will look from time to time to see what's taking so long and she would notice then. Commit: cfdb6a79d2f1a3ab93d2557478579808afc2cb4e https://github.com/openSUSE/open-build-service/commit/cfdb6a79d2f1a3ab93d25… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/models/obs_factory/staging_project.rb M src/api/app/models/staging/staging_project.rb A src/api/spec/cassettes/Staging_StagingProject/_overall_state/with_disabled_repository/1_3_10_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/with_disabled_repository/1_3_10_2.yml M src/api/spec/models/obs_factory/staging_project_spec.rb M src/api/spec/models/staging/staging_project_spec.rb Log Message: ----------- Merge pull request #7072 from coolo/dont_skip_disabled Don't let disabled projects/repos pass stagings as acceptable Compare: https://github.com/openSUSE/open-build-service/compare/983df2706396...cfdb6…

1 0

[obs-commits] [openSUSE/open-build-service] 1c4a84: Use correct style for Notifications button
by Björn Geuken 28 Feb '19

28 Feb '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1c4a84ff4328de7416c0b99036defc9c1f5ecc4d https://github.com/openSUSE/open-build-service/commit/1c4a84ff4328de7416c0b… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/views/webui2/webui/subscriptions/index.html.haml Log Message: ----------- Use correct style for Notifications button Also set disable_with for UJS Commit: 983df270639654a5aa9fd9de3da321e514ce3adb https://github.com/openSUSE/open-build-service/commit/983df270639654a5aa9fd… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/views/webui2/webui/subscriptions/index.html.haml Log Message: ----------- Merge pull request #7076 from dmarcoux/use-correct-style-for-notifications-button Use correct style for Notifications button Compare: https://github.com/openSUSE/open-build-service/compare/c8ce7c23735d...983df…

1 0

[obs-commits] [openSUSE/open-build-service] acabc8: Update styling for user notifications
by Björn Geuken 28 Feb '19

28 Feb '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: acabc8341ca1f553053b6158db93949f59c836e9 https://github.com/openSUSE/open-build-service/commit/acabc8341ca1f553053b6… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/controllers/webui/users/subscriptions_controller.rb M src/api/app/views/webui2/webui/subscriptions/_subscriptions_form.html.haml M src/api/app/views/webui2/webui/users/subscriptions/index.html.haml Log Message: ----------- Update styling for user notifications Use Bootstrap card-body CSS classes for the sections "Groups" and "Elements" inside "Notifications". Commit: c8ce7c23735d5464a3fbb5cbab49a34f618718ea https://github.com/openSUSE/open-build-service/commit/c8ce7c23735d5464a3fbb… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/controllers/webui/users/subscriptions_controller.rb M src/api/app/views/webui2/webui/users/subscriptions/index.html.haml Log Message: ----------- Merge pull request #7046 from eduardoj/update_bootstrap_for_user_notifications Update Bootstrap styling for user notifications Compare: https://github.com/openSUSE/open-build-service/compare/c068ae1eea5d...c8ce7…

1 0

[obs-commits] [openSUSE/open-build-service] a98d1d: Hide deleted and locked users in autocomplete search
by Dany Marcoux 28 Feb '19

28 Feb '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a98d1d3bbfca307d14552c88eae7356820a9a52e https://github.com/openSUSE/open-build-service/commit/a98d1d3bbfca307d14552… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/models/user.rb M src/api/spec/factories/users.rb M src/api/spec/models/user_spec.rb Log Message: ----------- Hide deleted and locked users in autocomplete search Such users are not allowed to execute any actions. So it doesn't make sense to offer them in forms, e.g. adding them as maintainer. Fixes #7022 Commit: c068ae1eea5d46a5f21781809a0f746843c37ea6 https://github.com/openSUSE/open-build-service/commit/c068ae1eea5d46a5f2178… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/models/user.rb M src/api/spec/factories/users.rb M src/api/spec/models/user_spec.rb Log Message: ----------- Merge pull request #7074 from bgeuken/fix_issue_7022 Hide deleted and locked users in autocomplete search Compare: https://github.com/openSUSE/open-build-service/compare/65a819881701...c068a…

1 0

[obs-commits] [openSUSE/open-build-service] 0a2970: [backend] fix typo in build-type specific release ...
by Michael Schroeder 28 Feb '19

28 Feb '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0a2970c6022671bdc7906d0bea507a8485ae4cb6 https://github.com/openSUSE/open-build-service/commit/0a2970c6022671bdc7906… Author: Michael Schroeder <mls(a)suse.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/backend/BSSched/BuildJob.pm Log Message: ----------- [backend] fix typo in build-type specific release settings Commit: 65a819881701a629b103bc77694185b93b2250dc https://github.com/openSUSE/open-build-service/commit/65a819881701a629b103b… Author: Michael Schroeder <mls(a)suse.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/backend/BSSched/BuildJob.pm Log Message: ----------- Merge pull request #7073 from mlschroe/master [backend] fix typo in build-type specific release settings Compare: https://github.com/openSUSE/open-build-service/compare/75ec71a6d8f9...65a81…

1 0

[obs-commits] [openSUSE/open-build-service] d85ebd: Add bootstrap view for notifications view
by Björn Geuken 28 Feb '19

28 Feb '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d85ebddecabe3e4efe0b59c1db86743b0cf41666 https://github.com/openSUSE/open-build-service/commit/d85ebddecabe3e4efe0b5… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2019-02-26 (Tue, 26 Feb 2019) Changed paths: M src/api/app/controllers/webui/subscriptions_controller.rb M src/api/app/views/webui2/webui/subscriptions/_subscriptions_form.html.haml M src/api/app/views/webui2/webui/subscriptions/index.html.haml Log Message: ----------- Add bootstrap view for notifications view Commit: 75ec71a6d8f9e90d32cc7fc4ca06e16fb6fa332a https://github.com/openSUSE/open-build-service/commit/75ec71a6d8f9e90d32cc7… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2019-02-28 (Thu, 28 Feb 2019) Changed paths: M src/api/app/controllers/webui/subscriptions_controller.rb M src/api/app/views/webui2/webui/subscriptions/_subscriptions_form.html.haml M src/api/app/views/webui2/webui/subscriptions/index.html.haml Log Message: ----------- Merge pull request #7036 from eduardoj/migrate_notifications_to_bootstrap Migrate notifications view for Bootstrap UI Compare: https://github.com/openSUSE/open-build-service/compare/8e3569070827...75ec7…

1 0