October 2019 - Open Build Service Commits

[obs-commits] [openSUSE/osc] e43d06: find appimage.yml files as build description
by Marcus Hüwe 21 Oct '19

21 Oct '19

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: e43d0641c6b99526d154cf8e63a67c5b80553242 https://github.com/openSUSE/osc/commit/e43d0641c6b99526d154cf8e63a67c5b8055… Author: Adrian Schröter <adrian(a)suse.de> Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M osc/commandline.py Log Message: ----------- find appimage.yml files as build description Commit: 3025dbf954242a6c4a98fa183986c218a306df75 https://github.com/openSUSE/osc/commit/3025dbf954242a6c4a98fa183986c218a306… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M osc/commandline.py Log Message: ----------- Merge branch 'support_appimage_yml' of https://github.com/adrianschroeter/osc Support "appimage.yml" in parse_repoarchdescr. Compare: https://github.com/openSUSE/osc/compare/598ad1034d66...3025dbf95424

1 0

[obs-commits] [openSUSE/osc] aaa51b: improve help text for osc maintained
by Marcus Hüwe 21 Oct '19

21 Oct '19

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: aaa51bcab1eb31ef0bb74b1001bcac95a905a6a0 https://github.com/openSUSE/osc/commit/aaa51bcab1eb31ef0bb74b1001bcac95a905… Author: lethliel <mstrigl(a)suse.de> Date: 2019-10-16 (Wed, 16 Oct 2019) Changed paths: M osc/commandline.py Log Message: ----------- improve help text for osc maintained The help text does not indicate that only osc mbranch really creates a branch. osc maintained and osc sm are just aliases for osc mbranch --dryrun Commit: 598ad1034d669adf2a678964ff02aec603e27408 https://github.com/openSUSE/osc/commit/598ad1034d669adf2a678964ff02aec603e2… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M osc/commandline.py Log Message: ----------- Merge branch 'improve_help_text_for_maintained' of https://github.com/lethliel/osc Improve help text of the "mbranch" command. Compare: https://github.com/openSUSE/osc/compare/6c23e10d80f4...598ad1034d66

1 0

[obs-commits] [openSUSE/open-build-service] dc965d: Disable use of concurrency in asset compilation
by Victor Pereira 21 Oct '19

21 Oct '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: dc965da39fedcc9ec4fc9ef856ac96fced8f09bc https://github.com/openSUSE/open-build-service/commit/dc965da39fedcc9ec4fc9… Author: Stephan Kulow <coolo(a)suse.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M src/api/config/application.rb Log Message: ----------- Disable use of concurrency in asset compilation sassc is not thread safe and there are tons of crashes while building packages. Unfortunately #8555 was merged even though the problem was noted there Commit: 528b95a2bf175ec2d958a683b00692afeac137e0 https://github.com/openSUSE/open-build-service/commit/528b95a2bf175ec2d958a… Author: Victor Pereira <vpereira(a)suse.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M src/api/config/application.rb Log Message: ----------- Merge pull request #8596 from coolo/no_concurrency Disable use of concurrency in asset compilation Compare: https://github.com/openSUSE/open-build-service/compare/ee39b752b118...528b9…

1 0

[obs-commits] [openSUSE/open-build-service] 26fe5c: [backend] added uri to 'remote error' message
by Frank Schreiner 21 Oct '19

21 Oct '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 26fe5cab532e34e92ecec1e31a4a14c859cc1e48 https://github.com/openSUSE/open-build-service/commit/26fe5cab532e34e92ecec… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2019-10-20 (Sun, 20 Oct 2019) Changed paths: M src/backend/BSRPC.pm Log Message: ----------- [backend] added uri to 'remote error' message Commit: 793013e6a62d3bf8f9e53e6051ddccb8d90b9bc2 https://github.com/openSUSE/open-build-service/commit/793013e6a62d3bf8f9e53… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M dist/t/spec/features/0040_package_spec.rb Log Message: ----------- [ci] disable animations in smoketest 0040_package_spec.rb Without this patch only a part of the string 'openSUSE.org:openSUSE:Tools' gets passed to the backend, which quits with a 404 from the remote side. This behavior is non-determenistic. SEE ALSO: https://github.com/teamcapybara/capybara/issues/1890 This patch disables jquery animations by setting jQuery.fx.off to true Commit: ee39b752b118f2786881e18918a4f245738009b4 https://github.com/openSUSE/open-build-service/commit/ee39b752b118f2786881e… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M dist/t/spec/features/0040_package_spec.rb M src/backend/BSRPC.pm Log Message: ----------- Merge pull request #8593 from M0ses/fix_smoke_tests Fix smoke tests Compare: https://github.com/openSUSE/open-build-service/compare/e63f808ff594...ee39b…

1 0

[obs-commits] [openSUSE/open-build-service] aa3dbe: Remove unused "tracked" attribute from classified_...
by Victor Pereira 21 Oct '19

21 Oct '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: aa3dbe51ae12e38f17af14400278b32a61ab0457 https://github.com/openSUSE/open-build-service/commit/aa3dbe51ae12e38f17af1… Author: Lukas Krause <lkrause(a)suse.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M src/api/app/models/concerns/staging_project.rb Log Message: ----------- Remove unused "tracked" attribute from classified_requests The "tracked" attribute is nowhere used in the staging workflow, and can be removed. Commit: 0c167da4917b49309d4ef38883cde57f27311b66 https://github.com/openSUSE/open-build-service/commit/0c167da4917b49309d4ef… Author: Lukas Krause <lkrause(a)suse.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M src/api/app/models/concerns/staging_project.rb Log Message: ----------- Prevent n+1 query in classified_requests method The classified_requests method includes the reviews when querying the requests but never takes advantage of it. Related to #7350 Commit: 703e5d1d48c5319c40cb3b490668bc171b63a48e https://github.com/openSUSE/open-build-service/commit/703e5d1d48c5319c40cb3… Author: Lukas Krause <lkrause(a)suse.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M src/api/app/models/concerns/staging_project.rb Log Message: ----------- Prevent n+1 query in missing_reviews method The missing_reviews method indirectly access the bs_request_action table through the extract_missing_reviews method. Including the bs_request_actions while loading the reviews prevents loading them one by one. Commit: ce62dab8186fe46de824a668994e5b6ee46f7672 https://github.com/openSUSE/open-build-service/commit/ce62dab8186fe46de824a… Author: Lukas Krause <lkrause(a)suse.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M src/api/app/models/concerns/staging_project.rb Log Message: ----------- Cache missing_reviews and reuse them When rendering the staging project show view, the classified_requests methods gets called and fetches the missing reviews for the package list. Afterwards the missing_reviews are collected again, inorder to show a list of them in the status area. Caching and reusing them saves time. Commit: a826d1ab31c81f7771c8c162e27404f92b224ac5 https://github.com/openSUSE/open-build-service/commit/a826d1ab31c81f7771c8c… Author: Lukas Krause <lkrause(a)suse.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M src/api/app/helpers/webui/staging/workflow_helper.rb Log Message: ----------- Call classified_requests methods only once in workflow helper There is no reason to call the method twice. Saving the result of the method call and reusing it is more effecient. Commit: 345cdbe0a49119a62dbd96df7893dd6955d1e37d https://github.com/openSUSE/open-build-service/commit/345cdbe0a49119a62dbd9… Author: Lukas Krause <lkrause(a)suse.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M src/api/app/models/bs_request.rb M src/api/app/models/concerns/staging_project.rb Log Message: ----------- Filter missing_reviews in database query Filtering out the reviews that have a review by_project for the staging project itself can happen directly in the database query instead of doing it through a condition in the ruby code. Commit: 6b2a4ef378d1b1f82b50b1fb555cbf9982fde303 https://github.com/openSUSE/open-build-service/commit/6b2a4ef378d1b1f82b50b… Author: Lukas Krause <lkrause(a)suse.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M src/api/app/models/concerns/staging_project.rb Log Message: ----------- Use each_with_object to collect and extract missing_reviews Using each_with_object to collect and extract the missing_reviews, reduces the amount of temporary used variables and makes the code a bit cleaner. Co-authored-by: Daniel Donisa <daniel.donisa(a)suse.com> Commit: e63f808ff5940976fc1ae889b8bba679b19c5d6f https://github.com/openSUSE/open-build-service/commit/e63f808ff5940976fc1ae… Author: Victor Pereira <vpereira(a)suse.de> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M src/api/app/helpers/webui/staging/workflow_helper.rb M src/api/app/models/bs_request.rb M src/api/app/models/concerns/staging_project.rb Log Message: ----------- Merge pull request #8580 from krauselukas/issue_7350_follow_up Get rid of n+1 queries and improve rendering time of staging project/workflow Compare: https://github.com/openSUSE/open-build-service/compare/8c47f71da304...e63f8…

1 0

[obs-commits] [openSUSE/open-build-service] 8618c9: Add method link_package
by Henne Vogelsang 21 Oct '19

21 Oct '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8618c9f800adca97dcb13641af93fcb539442286 https://github.com/openSUSE/open-build-service/commit/8618c9f800adca97dcb13… Author: Victor Pereira <vpereira(a)suse.de> Date: 2019-10-19 (Sat, 19 Oct 2019) Changed paths: M src/api/app/models/staging/staged_requests.rb Log Message: ----------- Add method link_package Commit: 4288f65fa63e7246190520e56322100bf6b442bf https://github.com/openSUSE/open-build-service/commit/4288f65fa63e724619052… Author: Victor Pereira <vpereira(a)suse.de> Date: 2019-10-19 (Sat, 19 Oct 2019) Changed paths: M src/api/spec/cassettes/Staging_StagedRequestsController/POST_create/with_valid_and_invalid_request_number/1_2_3_1.yml M src/api/spec/cassettes/Staging_StagedRequestsController/POST_create/with_valid_and_invalid_request_number/1_2_3_2.yml M src/api/spec/cassettes/Staging_StagedRequestsController/POST_create/with_valid_staging_project/1_2_5_1.yml M src/api/spec/cassettes/Staging_StagedRequestsController/POST_create/with_valid_staging_project/1_2_5_2.yml M src/api/spec/cassettes/Staging_StagedRequestsController/POST_create/with_valid_staging_project/1_2_5_3.yml M src/api/spec/cassettes/Staging_StagedRequestsController/POST_create/with_valid_staging_project/1_2_5_4.yml Log Message: ----------- Refresh StagedRequestsController cassettes and spec Commit: 48d01ac548245cc625cc68595148fbab2de765e3 https://github.com/openSUSE/open-build-service/commit/48d01ac548245cc625cc6… Author: Victor Pereira <vpereira(a)suse.de> Date: 2019-10-19 (Sat, 19 Oct 2019) Changed paths: M src/api/app/models/staging/staged_requests.rb Log Message: ----------- Remove comments and unused code Commit: 8c47f71da304071e5d97f4a9bc2b06ad05200885 https://github.com/openSUSE/open-build-service/commit/8c47f71da304071e5d97f… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2019-10-21 (Mon, 21 Oct 2019) Changed paths: M src/api/app/models/staging/staged_requests.rb M src/api/spec/cassettes/Staging_StagedRequestsController/POST_create/with_valid_and_invalid_request_number/1_2_3_1.yml M src/api/spec/cassettes/Staging_StagedRequestsController/POST_create/with_valid_and_invalid_request_number/1_2_3_2.yml M src/api/spec/cassettes/Staging_StagedRequestsController/POST_create/with_valid_staging_project/1_2_5_1.yml M src/api/spec/cassettes/Staging_StagedRequestsController/POST_create/with_valid_staging_project/1_2_5_2.yml M src/api/spec/cassettes/Staging_StagedRequestsController/POST_create/with_valid_staging_project/1_2_5_3.yml M src/api/spec/cassettes/Staging_StagedRequestsController/POST_create/with_valid_staging_project/1_2_5_4.yml Log Message: ----------- Merge pull request #8582 from vpereira/staging_workflow_link Staging workflow link instead of branch packages Compare: https://github.com/openSUSE/open-build-service/compare/756f17283bed...8c47f…

1 0

[obs-commits] [openSUSE/open-build-service] 335a9a: Make editor big where needed
by Henne Vogelsang 18 Oct '19

18 Oct '19

Branch: refs/heads/2.10 Home: https://github.com/openSUSE/open-build-service Commit: 335a9a9e71f5117b4db88d9f5f1d6d0c4bb3f63f https://github.com/openSUSE/open-build-service/commit/335a9a9e71f5117b4db88… Author: Stasiek Michalski <hellcp(a)opensuse.org> Date: 2019-10-17 (Thu, 17 Oct 2019) Changed paths: M src/api/app/assets/javascripts/webui2/cm2/use-codemirror.js M src/api/app/assets/stylesheets/webui2/cm2.scss M src/api/app/views/webui2/shared/_editor.html.haml M src/api/app/views/webui2/webui/package/_revision_diff_detail.html.haml Log Message: ----------- Make editor big where needed This way the editor textarea gets maximized most of the times, that is what users want. Don't show always the bottom box. We prefer to see more from the editor textarea. Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> (cherry picked from commit eb30e4ad3ca6262c7749905db9fb2dde8efedd91) Commit: 647e2a9df54cd1846a21c9bfa4ccb5b86180d2f0 https://github.com/openSUSE/open-build-service/commit/647e2a9df54cd1846a21c… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2019-10-18 (Fri, 18 Oct 2019) Changed paths: M src/api/app/assets/javascripts/webui2/cm2/use-codemirror.js M src/api/app/assets/stylesheets/webui2/cm2.scss M src/api/app/views/webui2/shared/_editor.html.haml M src/api/app/views/webui2/webui/package/_revision_diff_detail.html.haml Log Message: ----------- Merge pull request #8590 from Conan-Kudo/backport-2.10-make_editor_bigger_where_needed [2.10 backport] Make editor big where needed Compare: https://github.com/openSUSE/open-build-service/compare/27a8dd00704f...647e2…

1 0

[obs-commits] [openSUSE/open-build-service]
by Henne Vogelsang 18 Oct '19

18 Oct '19

Branch: refs/heads/depfu/update/srcapi-2.10/selenium-webdriver-3.142.6 Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service] 80e6a5: Update selenium-webdriver to version 3.142.6
by Henne Vogelsang 18 Oct '19

18 Oct '19

Branch: refs/heads/2.10 Home: https://github.com/openSUSE/open-build-service Commit: 80e6a5d15c271a20c529b5c187a9090a023bc598 https://github.com/openSUSE/open-build-service/commit/80e6a5d15c271a20c529b… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2019-10-18 (Fri, 18 Oct 2019) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update selenium-webdriver to version 3.142.6 Commit: 27a8dd00704fd0eee3855581112c43abdef109cd https://github.com/openSUSE/open-build-service/commit/27a8dd00704fd0eee3855… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2019-10-18 (Fri, 18 Oct 2019) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #8592 from openSUSE/depfu/update/srcapi-2.10/selenium-webdriver-3.142.6 [src/api - 2.10] Update selenium-webdriver: 3.142.3 → 3.142.6 (patch) Compare: https://github.com/openSUSE/open-build-service/compare/98acca24dd29...27a8d…

1 0

[obs-commits] [openSUSE/open-build-service] 80e6a5: Update selenium-webdriver to version 3.142.6
by depfu[bot] 18 Oct '19

18 Oct '19

Branch: refs/heads/depfu/update/srcapi-2.10/selenium-webdriver-3.142.6 Home: https://github.com/openSUSE/open-build-service Commit: 80e6a5d15c271a20c529b5c187a9090a023bc598 https://github.com/openSUSE/open-build-service/commit/80e6a5d15c271a20c529b… Author: depfu[bot] <23717796+depfu[bot](a)users.noreply.github.com> Date: 2019-10-18 (Fri, 18 Oct 2019) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update selenium-webdriver to version 3.142.6

1 0