January 2019 - Open Build Service Commits

[obs-commits] [openSUSE/software-o-o]
by depfu 04 Jan '19

04 Jan '19

Branch: refs/heads/depfu/update/geckodriver-helper-0.23.0 Home: https://github.com/openSUSE/software-o-o **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/software-o-o] c25f51: Update geckodriver-helper to version 0.23.0
by Duncan Mac-Vicar P 04 Jan '19

04 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/software-o-o Commit: c25f514ddaeae7987e390149c44bf32505262216 https://github.com/openSUSE/software-o-o/commit/c25f514ddaeae7987e390149c44… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-12-18 (Tue, 18 Dec 2018) Changed paths: M Gemfile.lock Log Message: ----------- Update geckodriver-helper to version 0.23.0 Commit: ec1d45e9936ac7f5111b9eb6677c1c08615cb74c https://github.com/openSUSE/software-o-o/commit/ec1d45e9936ac7f5111b9eb6677… Author: Duncan Mac-Vicar P <dmacvicar(a)gmail.com> Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M Gemfile.lock Log Message: ----------- Merge pull request #449 from openSUSE/depfu/update/geckodriver-helper-0.23.0 Update geckodriver-helper: 0.21.0 → 0.23.0 (major) Compare: https://github.com/openSUSE/software-o-o/compare/d9350827886a...ec1d45e9936a **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/software-o-o] 0ddc31: TravisCI: Update ruby 2.4 version and add 2.5, 2.6
by Duncan Mac-Vicar P 04 Jan '19

04 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/software-o-o Commit: 0ddc312040c62fa2898fd3a81e4db3de00d7efcf https://github.com/openSUSE/software-o-o/commit/0ddc312040c62fa2898fd3a81e4… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- TravisCI: Update ruby 2.4 version and add 2.5, 2.6 Our application should run on the latest 2.4 minor version and also on 2.5 and the recently released 2.6. Travis can run all of them easily for us ;) Commit: d9350827886a60763c3ea7e84250dda025b31091 https://github.com/openSUSE/software-o-o/commit/d9350827886a60763c3ea7e8425… Author: Duncan Mac-Vicar P <dmacvicar(a)gmail.com> Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M .travis.yml Log Message: ----------- Merge pull request #454 from alexandergraul/travis-ci TravisCI: Update ruby 2.4 version and add 2.5, 2.6 Compare: https://github.com/openSUSE/software-o-o/compare/8c80540c2fc2...d9350827886a **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/software-o-o] a9566b: Use development credentials for tests
by Duncan Mac-Vicar P 04 Jan '19

04 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/software-o-o Commit: a9566bbe9e31a98ad76d845c435fffc35564b579 https://github.com/openSUSE/software-o-o/commit/a9566bbe9e31a98ad76d845c435… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M config/options.yml Log Message: ----------- Use development credentials for tests The previously used credentials resulted in authorization errors, but the development credentials work fine. Commit: 369eec442f78776e88c144dac130fd6505d9de86 https://github.com/openSUSE/software-o-o/commit/369eec442f78776e88c144dac13… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M Gemfile M Gemfile.lock Log Message: ----------- Update development gems Add byebug and web-console for easier debugging. Commit: 3594bc26c5641d6aff455c7bcd2136d65e60197b https://github.com/openSUSE/software-o-o/commit/3594bc26c5641d6aff455c7bcd2… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M Gemfile M Gemfile.lock M config/initializers/activexml.rb A lib/obs.rb A test/obs_test.rb M test/support/vcr/default.yml Log Message: ----------- Add OBS mini client Use a mini client for connections to our backend OBS. This client is based on Faraday, a flexible HTTP client library. It is easily extensible by Rack middleware and hopefully makes it easier to debug memory issues. It will replace Seeker, the currently used model that handles these queries, together with ActiveXML. Co-authored-by: Duncan Mac-Vicar P <dmacvicar(a)suse.de> Commit: 74d45a156409138cf3a3f66b605e3b388db2c876 https://github.com/openSUSE/software-o-o/commit/74d45a156409138cf3a3f66b605… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/obs.rb M test/obs_test.rb Log Message: ----------- Add OBS:QualityCategory attribute search Binaries need "quality" attributes that come from their projects, so that "private" binaries can be filtered out. Commit: ea30c076731afef748af7d338f757256e4855947 https://github.com/openSUSE/software-o-o/commit/ea30c076731afef748af7d338f7… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/obs.rb M test/obs_test.rb Log Message: ----------- Add Fileinfo to binaries Binaries need additional information that we can display in the views. This additional information consist of a one-line summary, a description and the binary size. Commit: aa89e1fcb5202de13c8491891ae136697da59fab https://github.com/openSUSE/software-o-o/commit/aa89e1fcb5202de13c8491891ae… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/obs.rb Log Message: ----------- Add relevance to binaries and sort returned Array Relevance logic is taken from Seeker, the current implementation of the Binary queries. Commit: 9051f19d00ad92eb1472a58170009e420cdb5907 https://github.com/openSUSE/software-o-o/commit/9051f19d00ad92eb1472a581700… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/obs.rb Log Message: ----------- Use Rails.cache for binary queries to OBS Other queries are already cached and requests to OBS should be kept as minimal as possible to reduce loading times and bandwidth usage. Commit: b2152540d2e6809de1356589ba064148044fe268 https://github.com/openSUSE/software-o-o/commit/b2152540d2e6809de1356589ba0… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M app/controllers/application_controller.rb M app/controllers/obs_controller.rb M app/controllers/package_controller.rb M app/controllers/search_controller.rb M app/helpers/application_helper.rb M app/views/package/show.html.erb M app/views/search/_find_results.html.erb Log Message: ----------- Migrate controllers and views to new OBS client The controllers don't rely on Seeker anymore but instead make use of the new OBS mini client. Views are adjusted to the small difference between the old and new data structure. One example for that is that binary.size does not work as previously, as size is a built-in method and binary is a modified Hash. Therefore, the hash-like binary[:size] notation is used. Commit: 3b6f05c05282d73c15d73d8bb15512f5877ca928 https://github.com/openSUSE/software-o-o/commit/3b6f05c05282d73c15d73d8bb15… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/obs.rb Log Message: ----------- Improve performance of binary search Two changes to increase performance of search_published_binary: - Instead of iterating three times with .map, just iterate once with .each - Use of sort_by instead of sort, it is more efficient. Co-authored-by: Ana María Martínez Gómez <anamma06(a)gmail.com> Commit: 5bdaca40d367c81ade838b9369569edbfde07830 https://github.com/openSUSE/software-o-o/commit/5bdaca40d367c81ade838b93695… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M app/helpers/application_helper.rb R app/models/seeker.rb R config/initializers/activexml.rb A config/initializers/obs_client.rb R lib/activexml/activexml.rb R lib/activexml/matcher.rb R lib/activexml/node.rb R lib/activexml/transport.rb M lib/tasks/fill_search_cache.rake Log Message: ----------- Remove ActiveXML library ActiveXML has been fully replaced by lib/obs.rb and is not needed anymore. Commit: 577fbd3701b1227780cb421389a3d4f2e8789a38 https://github.com/openSUSE/software-o-o/commit/577fbd3701b1227780cb421389a… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M lib/obs.rb Log Message: ----------- Improve add_fileinfo_to_binary comments Small improvements to clarify two comments. Commit: 70925837801958789be9f672b215d4b671dcd190 https://github.com/openSUSE/software-o-o/commit/70925837801958789be9f672b21… Author: Alexander Graul <agraul(a)suse.com> Date: 2019-01-02 (Wed, 02 Jan 2019) Changed paths: M app/helpers/application_helper.rb M lib/obs.rb Log Message: ----------- Load fileinfo on-demand Instead of loading fileinfo for each binary in `search_published_binaries`, the fileinfo query is started in application_helper#search_for_description. That method returns a binary that has fileinfo for the views to display and is the only place that makes use of fileinfo as of now. Commit: 8c80540c2fc23379222df8be64745b70156d467d https://github.com/openSUSE/software-o-o/commit/8c80540c2fc23379222df8be647… Author: Duncan Mac-Vicar P <dmacvicar(a)gmail.com> Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M Gemfile M Gemfile.lock M app/controllers/application_controller.rb M app/controllers/obs_controller.rb M app/controllers/package_controller.rb M app/controllers/search_controller.rb M app/helpers/application_helper.rb R app/models/seeker.rb M app/views/package/show.html.erb M app/views/search/_find_results.html.erb R config/initializers/activexml.rb A config/initializers/obs_client.rb M config/options.yml R lib/activexml/activexml.rb R lib/activexml/matcher.rb R lib/activexml/node.rb R lib/activexml/transport.rb A lib/obs.rb M lib/tasks/fill_search_cache.rake A test/obs_test.rb M test/support/vcr/default.yml Log Message: ----------- Merge pull request #387 from alexandergraul/obs-client Add OBS Client Compare: https://github.com/openSUSE/software-o-o/compare/24cc83a32759...8c80540c2fc2 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] c226b0: Hide disabled repositories by default
by Ana María Martínez Gómez 04 Jan '19

04 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c226b0f4f91c98dd5f6c2dbdb7250e781b17c8c2 https://github.com/openSUSE/open-build-service/commit/c226b0f4f91c98dd5f6c2… Author: Gabriel Bustamante <gabriel.souza1(a)gmail.com> Date: 2018-12-19 (Wed, 19 Dec 2018) Changed paths: M src/api/app/models/local_build_result/for_package.rb M src/api/app/views/webui/package/_buildstatus.html.haml M src/api/app/views/webui2/webui/package/_buildstatus.html.haml M src/api/spec/models/local_build_result/for_package_spec.rb Log Message: ----------- Hide disabled repositories by default Fixes #2529 Commit: d332afe25035a992bd9d782040273fa030e7fc3f https://github.com/openSUSE/open-build-service/commit/d332afe25035a992bd9d7… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M src/api/app/models/local_build_result/for_package.rb M src/api/app/views/webui/package/_buildstatus.html.haml M src/api/app/views/webui2/webui/package/_buildstatus.html.haml M src/api/spec/models/local_build_result/for_package_spec.rb Log Message: ----------- Merge pull request #6549 from gsouzab/disabled_build_results Not showing disabled build results on default Compare: https://github.com/openSUSE/open-build-service/compare/5976f98619d8...d332a… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 6968bb: Fix flag validation catching duplicates
by Stephan Kulow 04 Jan '19

04 Jan '19

Branch: refs/heads/fix_flag_validation Home: https://github.com/openSUSE/open-build-service Commit: 6968bb16e9bc923517cd8b570aaca30cf7ff142f https://github.com/openSUSE/open-build-service/commit/6968bb16e9bc923517cd8… Author: Stephan Kulow <coolo(a)suse.de> Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M src/api/app/models/flag.rb A src/api/db/data/20181214100207_remove_duplicated_flags.rb Log Message: ----------- Fix flag validation catching duplicates This has been broken since the introduction as where('repo = ?', repo) for nil values compares with NULL, which never exists. On top of that this also checked if status was duplicated, which means you could have an enabled and disabled status for the same field, which doesn't make much sense We have a lot of duplicated flags by now, so we need a data migration Fixes #6615 Co-authored-by: Ana María Martínez Gómez <ammartinez(a)suse.de> Commit: d2d5767c85355874deb533d345d29ae40df4d9f7 https://github.com/openSUSE/open-build-service/commit/d2d5767c85355874deb53… Author: Stephan Kulow <coolo(a)suse.de> Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M src/api/test/unit/build_flag_test.rb M src/api/test/unit/debug_flag_test.rb M src/api/test/unit/publish_flag_test.rb Log Message: ----------- Replace invalid unit test duplicating flags The test duplicated flags without expecting it. Commit: 4be2b39156c5b9bb7c707fe048ee056e56c91ba1 https://github.com/openSUSE/open-build-service/commit/4be2b39156c5b9bb7c707… Author: Stephan Kulow <coolo(a)suse.de> Date: 2019-01-04 (Fri, 04 Jan 2019) Changed paths: M src/api/db/data/20181214100207_remove_duplicated_flags.rb M src/api/db/data_schema.rb Log Message: ----------- Fix migration to really pluck I put this in comments, but forgot to really do it (to be squashed) Compare: https://github.com/openSUSE/open-build-service/compare/6968bb16e9bc^...4be2… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 5976f9: [backend] support newer gpg 2.1
by Adrian Schröter 03 Jan '19

03 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5976f98619d81047b77d4d05d58625d66725fed0 https://github.com/openSUSE/open-build-service/commit/5976f98619d81047b77d4… Author: Adrian Schröter <adrian(a)suse.de> Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M src/backend/bs_dodup Log Message: ----------- [backend] support newer gpg 2.1 it is using pubring.kbx instead of pubring.gpg now **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 53fe87: Fix footer
by David Kang 03 Jan '19

03 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 53fe87d676e8ab44acf9711b4222909303d5ae9a https://github.com/openSUSE/open-build-service/commit/53fe87d676e8ab44acf97… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M src/api/app/views/webui2/webui/package/_delete_binaries_dialog.html.haml Log Message: ----------- Fix footer Commit: e63bd5e874cd968c1dfab53f92d30d049c4d4a76 https://github.com/openSUSE/open-build-service/commit/e63bd5e874cd968c1dfab… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M src/api/app/views/webui2/webui/package/_delete_binaries_dialog.html.haml M src/api/app/views/webui2/webui/package/binaries.html.haml M src/api/app/views/webui2/webui/package/binaries/_trigger_rebuild_wipe_binaries.html.haml Log Message: ----------- Refactor removing binaries Instead of generating html code for each modal that asks for removing the binaries, only one modal is created. Arguments for the modal are passed with "data-*" attributes. Commit: 9430987be5cb06968b6028431dbad7844db67ddf https://github.com/openSUSE/open-build-service/commit/9430987be5cb06968b602… Author: David Kang <dkang(a)suse.com> Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M src/api/app/views/webui2/webui/package/_delete_binaries_dialog.html.haml M src/api/app/views/webui2/webui/package/binaries.html.haml M src/api/app/views/webui2/webui/package/binaries/_trigger_rebuild_wipe_binaries.html.haml Log Message: ----------- Merge pull request #6705 from eduardoj/refactor_delete_binaries_modal Refactor removing binaries Compare: https://github.com/openSUSE/open-build-service/compare/721312ffab09...94309… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 03 Jan '19

03 Jan '19

Branch: refs/heads/depfu/update/srcapi/rubocop-rspec-1.31.0 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 9496a9: Update rubocop-rspec to version 1.31.0
by Dany Marcoux 03 Jan '19

03 Jan '19

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9496a985d6026863b54e26d63f63e61dc1aad030 https://github.com/openSUSE/open-build-service/commit/9496a985d6026863b54e2… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop-rspec to version 1.31.0 Commit: 721312ffab091f263200a33ae56b9670c1a2168a https://github.com/openSUSE/open-build-service/commit/721312ffab091f263200a… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2019-01-03 (Thu, 03 Jan 2019) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6704 from openSUSE/depfu/update/srcapi/rubocop-rspec-1.31.0 [src/api] Update rubocop-rspec: 1.30.1 → 1.31.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/1e3e2c7040d1...72131… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0