September 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 00c6dd: [webui] Expand breadcrumbs instead of hardcoding w...
by Björn Geuken 25 Sep '18

25 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 00c6ddf4521c2cac71be4f0aaed475e0a13a9d5e https://github.com/openSUSE/open-build-service/commit/00c6ddf4521c2cac71be4… Author: Stasiek Michalski <hellcp(a)opensuse.org> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/app/views/layouts/webui2/webui.html.haml Log Message: ----------- [webui] Expand breadcrumbs instead of hardcoding width Commit: 98368145e123bb491d9853c92bce67e99d762eff https://github.com/openSUSE/open-build-service/commit/98368145e123bb491d985… Author: Stasiek Michalski <hellcp(a)opensuse.org> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/app/views/webui2/webui/main/_breadcrumb_items.html.haml Log Message: ----------- [webui] Space out home icon from text Commit: 82267aca862597e621cd88ed59351740dbd91a69 https://github.com/openSUSE/open-build-service/commit/82267aca862597e621cd8… Author: Stasiek Michalski <hellcp(a)opensuse.org> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/app/views/webui2/webui/main/_breadcrumb_items.html.haml Log Message: ----------- [webui] Fix both cases of home spacing Commit: c213cc0a6f88ba57d1d5090c0546e2088f7cc3ae https://github.com/openSUSE/open-build-service/commit/c213cc0a6f88ba57d1d50… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M src/api/app/views/layouts/webui2/webui.html.haml M src/api/app/views/webui2/webui/main/_breadcrumb_items.html.haml Log Message: ----------- Merge pull request #5894 from hellcp/patch-2 Fix scaling of breadcrumbs on low width screens Compare: https://github.com/openSUSE/open-build-service/compare/7992196c6508...c213c… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] ab1052: Add revision in branch package
by Björn Geuken 25 Sep '18

25 Sep '18

Branch: refs/heads/bootstrap-master Home: https://github.com/openSUSE/open-build-service Commit: ab105292f1f0b6986c71135c6080bb0cf3b2c3ee https://github.com/openSUSE/open-build-service/commit/ab105292f1f0b6986c711… Author: David Kang <dkang(a)suse.com> Date: 2018-09-13 (Thu, 13 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/views/shared/_package_branch_form.html.haml M src/api/app/views/webui2/shared/_package_branch_form.html.haml M src/api/spec/cassettes/Bootstrap_MaintenanceWorkflow/maintenance_workflow.yml M src/api/spec/cassettes/Bootstrap_Packages/branching_a_package_from_another_users_project/with_AutoCleanup.yml M src/api/spec/cassettes/Bootstrap_Packages/branching_a_package_from_another_users_project/without_AutoCleanup.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_current_revision_parameter_is_provided_but_there_wasn_t_any_revision_before.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_package_does_not_exist.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_package_parameter_not_provided.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_project_does_not_exist.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_project_parameter_not_provided.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_user_has_no_permissions_for_source_project.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/1_4_8_1.yml A src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/1_4_8_3.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/redirects_to_the_branched_package.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_target_package_name/1_4_7_1.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_target_package_name/redirects_to_the_branched_package.yml M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Add revision in branch package When we branch a package with a specific revision, it was always branching the last revision. Now it's having into account the revision shown in the Package#show page. Commit: 8cdfb1797b7813225accdc23955d1db13e689e49 https://github.com/openSUSE/open-build-service/commit/8cdfb1797b7813225accd… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/app/views/webui2/webui/attribute/index.html.haml M src/api/app/views/webui2/webui/package/revisions.html.haml Log Message: ----------- Remove unneeded package_bread_crumb This was used in the old webui views Commit: 1ab5efd131db0e44cf13b925ec8f745d1289ac1c https://github.com/openSUSE/open-build-service/commit/1ab5efd131db0e44cf13b… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/app/views/webui2/webui/attribute/index.html.haml M src/api/app/views/webui2/webui/package/revisions.html.haml Log Message: ----------- Merge pull request #5906 from dmarcoux/remove-unneeded-package_bread_crumb Remove unneeded package_bread_crumb Commit: 62b6fbfa2a2275b35151cb72a5437d67a344e7b8 https://github.com/openSUSE/open-build-service/commit/62b6fbfa2a2275b35151c… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: R src/api/app/views/webui/package/_deps.html.erb A src/api/app/views/webui/package/_deps.html.haml R src/api/app/views/webui/package/binary.html.erb A src/api/app/views/webui/package/binary.html.haml Log Message: ----------- Convert binary views to haml This is for preparation of writing the binary view page in haml. Commit: ef2361a88851906635400d4d988490b716b28558 https://github.com/openSUSE/open-build-service/commit/ef2361a88851906635400… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: R src/api/app/views/webui/package/_deps.html.erb A src/api/app/views/webui/package/_deps.html.haml R src/api/app/views/webui/package/binary.html.erb A src/api/app/views/webui/package/binary.html.haml Log Message: ----------- Merge pull request #5912 from bgeuken/convert_binary_view_to_haml Convert binary view to haml Commit: 7992196c650818c6727b0fa44c969fa42385daa5 https://github.com/openSUSE/open-build-service/commit/7992196c650818c6727b0… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/views/shared/_package_branch_form.html.haml M src/api/app/views/webui2/shared/_package_branch_form.html.haml M src/api/spec/cassettes/Bootstrap_MaintenanceWorkflow/maintenance_workflow.yml M src/api/spec/cassettes/Bootstrap_Packages/branching_a_package_from_another_users_project/with_AutoCleanup.yml M src/api/spec/cassettes/Bootstrap_Packages/branching_a_package_from_another_users_project/without_AutoCleanup.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_current_revision_parameter_is_provided_but_there_wasn_t_any_revision_before.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_package_does_not_exist.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_package_parameter_not_provided.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_project_does_not_exist.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_project_parameter_not_provided.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_user_has_no_permissions_for_source_project.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/1_4_8_1.yml A src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/1_4_8_3.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/redirects_to_the_branched_package.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_target_package_name/1_4_7_1.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_target_package_name/redirects_to_the_branched_package.yml M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Merge pull request #5836 from DavidKang/sprint47/bugsquad/5365-issue Add revision in branch package Commit: 0c93ca5eb2d1691792e4a6a8db53ccbe2b3edecd https://github.com/openSUSE/open-build-service/commit/0c93ca5eb2d1691792e4a… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb R src/api/app/controllers/webui2/request_controller.rb M src/api/app/views/webui2/webui/package/bottom_actions/_request_devel_project_change.html.haml M src/api/app/views/webui2/webui/package/show.html.haml M src/api/app/views/webui2/webui/request/_change_devel_request_dialog.html.haml M src/api/spec/bootstrap/features/webui/packages_spec.rb Log Message: ----------- Refactor render_dialog for change_devel_request_dialog Instead of performing an Ajax call that answers with a Javascript code that updates the view to create and show the modal we now render the modal if needed and show it via Javascript locally. This is better because we only need one SQL query more and we save a XHR request. Co-authored-by: David Kang <dkang(a)suse.com> Commit: c4f12082d0245df575e09d3aa1f112c0c6695209 https://github.com/openSUSE/open-build-service/commit/c4f12082d0245df575e09… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui2/webui/request/_change_devel_request_dialog.html.haml M src/api/spec/features/webui/packages_spec.rb Log Message: ----------- Refactor change_devel_request_modal view This modal had some "if" not needed anymore so we simplified the code a lot. Also we marked the request controller action to be deleted in the migration to Boostrap. Co-authored-by: David Kang <dkang(a)suse.com> Commit: b648190ed5637faf04b8917ba099ab9a2e3c48f8 https://github.com/openSUSE/open-build-service/commit/b648190ed5637faf04b89… Author: David Kang <dkang(a)suse.com> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui2/package_controller.rb M src/api/app/views/webui2/webui/package/_bottom_actions.html.haml A src/api/app/views/webui2/webui/package/_edit_dialog.html.haml M src/api/app/views/webui2/webui/package/bottom_actions/_edit_description.html.haml M src/api/app/views/webui2/webui/package/show.html.haml M src/api/config/routes.rb M src/api/spec/bootstrap/features/webui/packages_spec.rb A src/api/spec/cassettes/Bootstrap_Packages/editing_a_package.yml Log Message: ----------- Make package#edit a modal The action edit has much sense to be a modal. Commit: cea2e1db003c7f1a5ebcc482539c3b6e35afd431 https://github.com/openSUSE/open-build-service/commit/cea2e1db003c7f1a5ebcc… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/views/shared/_package_branch_form.html.haml R src/api/app/views/webui/package/_deps.html.erb A src/api/app/views/webui/package/_deps.html.haml R src/api/app/views/webui/package/binary.html.erb A src/api/app/views/webui/package/binary.html.haml M src/api/app/views/webui2/shared/_package_branch_form.html.haml M src/api/app/views/webui2/webui/attribute/index.html.haml M src/api/app/views/webui2/webui/package/revisions.html.haml M src/api/spec/cassettes/Bootstrap_MaintenanceWorkflow/maintenance_workflow.yml M src/api/spec/cassettes/Bootstrap_Packages/branching_a_package_from_another_users_project/with_AutoCleanup.yml M src/api/spec/cassettes/Bootstrap_Packages/branching_a_package_from_another_users_project/without_AutoCleanup.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_current_revision_parameter_is_provided_but_there_wasn_t_any_revision_before.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_package_does_not_exist.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_package_parameter_not_provided.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_project_does_not_exist.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_project_parameter_not_provided.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_user_has_no_permissions_for_source_project.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/1_4_8_1.yml A src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/1_4_8_3.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/redirects_to_the_branched_package.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_target_package_name/1_4_7_1.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_target_package_name/redirects_to_the_branched_package.yml M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Merge pull request #5916 from bgeuken/bootstrap-master Update Bootstrap master branch Compare: https://github.com/openSUSE/open-build-service/compare/75ae193acc37...cea2e… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/obs-build] 18c852: Support "OBS-AddTag" directive to set multiple con...
by GitHub 25 Sep '18

25 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 18c8528286f8af5f3c1e80f6b368af94cc704499 https://github.com/openSUSE/obs-build/commit/18c8528286f8af5f3c1e80f6b368af… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M Build/Kiwi.pm Log Message: ----------- Support "OBS-AddTag" directive to set multiple container tags in kiwi builds **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] ab1052: Add revision in branch package
by Björn Geuken 25 Sep '18

25 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ab105292f1f0b6986c71135c6080bb0cf3b2c3ee https://github.com/openSUSE/open-build-service/commit/ab105292f1f0b6986c711… Author: David Kang <dkang(a)suse.com> Date: 2018-09-13 (Thu, 13 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/views/shared/_package_branch_form.html.haml M src/api/app/views/webui2/shared/_package_branch_form.html.haml M src/api/spec/cassettes/Bootstrap_MaintenanceWorkflow/maintenance_workflow.yml M src/api/spec/cassettes/Bootstrap_Packages/branching_a_package_from_another_users_project/with_AutoCleanup.yml M src/api/spec/cassettes/Bootstrap_Packages/branching_a_package_from_another_users_project/without_AutoCleanup.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_current_revision_parameter_is_provided_but_there_wasn_t_any_revision_before.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_package_does_not_exist.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_package_parameter_not_provided.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_project_does_not_exist.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_project_parameter_not_provided.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_user_has_no_permissions_for_source_project.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/1_4_8_1.yml A src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/1_4_8_3.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/redirects_to_the_branched_package.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_target_package_name/1_4_7_1.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_target_package_name/redirects_to_the_branched_package.yml M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Add revision in branch package When we branch a package with a specific revision, it was always branching the last revision. Now it's having into account the revision shown in the Package#show page. Commit: 7992196c650818c6727b0fa44c969fa42385daa5 https://github.com/openSUSE/open-build-service/commit/7992196c650818c6727b0… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/views/shared/_package_branch_form.html.haml M src/api/app/views/webui2/shared/_package_branch_form.html.haml M src/api/spec/cassettes/Bootstrap_MaintenanceWorkflow/maintenance_workflow.yml M src/api/spec/cassettes/Bootstrap_Packages/branching_a_package_from_another_users_project/with_AutoCleanup.yml M src/api/spec/cassettes/Bootstrap_Packages/branching_a_package_from_another_users_project/without_AutoCleanup.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_current_revision_parameter_is_provided_but_there_wasn_t_any_revision_before.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_package_does_not_exist.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_package_parameter_not_provided.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_project_does_not_exist.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_source_project_parameter_not_provided.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/shows_an_error_if_user_has_no_permissions_for_source_project.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/1_4_8_1.yml A src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/1_4_8_3.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_currrent_revision_parameter/redirects_to_the_branched_package.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_target_package_name/1_4_7_1.yml M src/api/spec/cassettes/Webui_PackageController/POST_branch/with_target_package_name/redirects_to_the_branched_package.yml M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Merge pull request #5836 from DavidKang/sprint47/bugsquad/5365-issue Add revision in branch package Compare: https://github.com/openSUSE/open-build-service/compare/ef2361a88851...79921… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 62b6fb: Convert binary views to haml
by Björn Geuken 25 Sep '18

25 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 62b6fbfa2a2275b35151cb72a5437d67a344e7b8 https://github.com/openSUSE/open-build-service/commit/62b6fbfa2a2275b35151c… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: R src/api/app/views/webui/package/_deps.html.erb A src/api/app/views/webui/package/_deps.html.haml R src/api/app/views/webui/package/binary.html.erb A src/api/app/views/webui/package/binary.html.haml Log Message: ----------- Convert binary views to haml This is for preparation of writing the binary view page in haml. Commit: ef2361a88851906635400d4d988490b716b28558 https://github.com/openSUSE/open-build-service/commit/ef2361a88851906635400… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: R src/api/app/views/webui/package/_deps.html.erb A src/api/app/views/webui/package/_deps.html.haml R src/api/app/views/webui/package/binary.html.erb A src/api/app/views/webui/package/binary.html.haml Log Message: ----------- Merge pull request #5912 from bgeuken/convert_binary_view_to_haml Convert binary view to haml Compare: https://github.com/openSUSE/open-build-service/compare/1ab5efd131db...ef236… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 442ed1: Make package#edit a modal
by Moisés Déniz Alemán 25 Sep '18

25 Sep '18

Branch: refs/heads/bootstrap-master Home: https://github.com/openSUSE/open-build-service Commit: 442ed15500874c5d88214ef5c098c61478433501 https://github.com/openSUSE/open-build-service/commit/442ed15500874c5d88214… Author: David Kang <dkang(a)suse.com> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui2/package_controller.rb M src/api/app/views/webui2/webui/package/_bottom_actions.html.haml A src/api/app/views/webui2/webui/package/_edit_dialog.html.haml M src/api/app/views/webui2/webui/package/bottom_actions/_edit_description.html.haml M src/api/app/views/webui2/webui/package/show.html.haml M src/api/config/routes.rb M src/api/spec/bootstrap/features/webui/packages_spec.rb A src/api/spec/cassettes/Bootstrap_Packages/editing_a_package.yml Log Message: ----------- Make package#edit a modal The action edit has much sense to be a modal. Commit: 75ae193acc374fe6ca7339a6b5f4eaf306ae2515 https://github.com/openSUSE/open-build-service/commit/75ae193acc374fe6ca733… Author: Moisés Déniz Alemán <mdeniz(a)suse.com> Date: 2018-09-25 (Tue, 25 Sep 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui2/package_controller.rb M src/api/app/views/webui2/webui/package/_bottom_actions.html.haml A src/api/app/views/webui2/webui/package/_edit_dialog.html.haml M src/api/app/views/webui2/webui/package/bottom_actions/_edit_description.html.haml M src/api/app/views/webui2/webui/package/show.html.haml M src/api/config/routes.rb M src/api/spec/bootstrap/features/webui/packages_spec.rb A src/api/spec/cassettes/Bootstrap_Packages/editing_a_package.yml Log Message: ----------- Merge pull request #5907 from DavidKang/sprint48/package-description Make package#edit a modal Compare: https://github.com/openSUSE/open-build-service/compare/778d4d7135bf...75ae1… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 8cdfb1: Remove unneeded package_bread_crumb
by Christian Bruckmayer 24 Sep '18

24 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8cdfb1797b7813225accdc23955d1db13e689e49 https://github.com/openSUSE/open-build-service/commit/8cdfb1797b7813225accd… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/app/views/webui2/webui/attribute/index.html.haml M src/api/app/views/webui2/webui/package/revisions.html.haml Log Message: ----------- Remove unneeded package_bread_crumb This was used in the old webui views Commit: 1ab5efd131db0e44cf13b925ec8f745d1289ac1c https://github.com/openSUSE/open-build-service/commit/1ab5efd131db0e44cf13b… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/app/views/webui2/webui/attribute/index.html.haml M src/api/app/views/webui2/webui/package/revisions.html.haml Log Message: ----------- Merge pull request #5906 from dmarcoux/remove-unneeded-package_bread_crumb Remove unneeded package_bread_crumb Compare: https://github.com/openSUSE/open-build-service/compare/3a680f6ac131...1ab5e… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 8509ca: Update sass to version 3.6.0
by Christian Bruckmayer 24 Sep '18

24 Sep '18

Branch: refs/heads/bootstrap-master Home: https://github.com/openSUSE/open-build-service Commit: 8509caaadc6405486efde647819462c9c033dc13 https://github.com/openSUSE/open-build-service/commit/8509caaadc6405486efde… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-09-19 (Wed, 19 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update sass to version 3.6.0 Commit: c1c8b47cf7b67333e840bd31bf9b3f4871f85e63 https://github.com/openSUSE/open-build-service/commit/c1c8b47cf7b67333e840b… Author: David Kang <dkang(a)suse.com> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/assets/stylesheets/webui2/texts.scss M src/api/app/views/layouts/webui2/_watchlist.html.haml M src/api/app/views/layouts/webui2/_watchlist_dropdown.html.haml Log Message: ----------- Make watchlist smaller if the name of the project was very long, the container of the watchlist was also growing. Commit: 4df2f1154e9087386fa6563c524906c4ba44947f https://github.com/openSUSE/open-build-service/commit/4df2f1154e9087386fa65… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/backend/bs_admin M src/backend/bs_dodup Log Message: ----------- [backend] bs_admin: add --recheck-dod command to force recheck a DoD It supports a project or url prefix as argument Commit: 3e226956eb594acaa8cf875bd61dbafa8498c0da https://github.com/openSUSE/open-build-service/commit/3e226956eb594acaa8cf8… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb A src/api/app/controllers/status/concerns/set_checkable.rb A src/api/app/controllers/status/reports_controller.rb M src/api/app/controllers/status/required_checks_controller.rb M src/api/app/controllers/webui/obs_factory/staging_projects_controller.rb M src/api/app/helpers/status/required_checks_helper.rb M src/api/app/helpers/webui/obs_factory/application_helper.rb M src/api/app/models/bs_request.rb M src/api/app/models/project.rb M src/api/app/models/repository.rb M src/api/app/models/status/check.rb A src/api/app/models/status/report.rb R src/api/app/models/status/repository_publish.rb M src/api/app/policies/project_policy.rb R src/api/app/policies/status/check_policy.rb A src/api/app/policies/status/report_policy.rb R src/api/app/views/status/checks/index.xml.builder A src/api/app/views/status/reports/_check.xml.builder A src/api/app/views/status/reports/show.xml.builder M src/api/app/views/webui/obs_factory/staging_projects/_checks.html.haml M src/api/config/routes.rb A src/api/db/migrate/20180906115417_add_required_checks_to_projects.rb A src/api/db/migrate/20180906142702_create_status_reports.rb A src/api/db/migrate/20180906142802_update_status_checks_table.rb M src/api/db/structure.sql M src/api/spec/controllers/status/checks_controller_spec.rb A src/api/spec/controllers/status/reports_controller_spec.rb M src/api/spec/factories/checks.rb M src/api/spec/factories/groups.rb A src/api/spec/factories/status_reports.rb R src/api/spec/factories/status_repository_publish.rb R src/api/spec/fixtures/files/check.xml R src/api/spec/fixtures/files/invalid_check.xml M src/api/spec/models/status/check_spec.rb A src/api/spec/models/status/report_spec.rb R src/api/spec/models/status/repository_publish_spec.rb A src/api/spec/policies/status/report_policy_spec.rb Log Message: ----------- Implement status checks for requests in order to do this it was also necessary to refactor the whole status checks module * Dropped Status::RepositoryPublish model and introduced generic Status::Report model instead * Dropped all routes except Checks#update and Reports#index as discussed with the stakeholders that these are the only requested routes for now. Checks#update will create or update the check. Report#index will list all checks of this report. * Moved common functionality to a concern * Changed routes like requested by stakeholders * Made controllers polymorphic to support requests and repositories for now, more to probably come * Updated controller specs Co-authored-by: Björn Geuken <bgeuken(a)suse.de> Co-authored-by: Eduardo Navarro <enavarro(a)suse.com> Commit: efe7476b5ddda16367d62b80dc69aee8fac59f57 https://github.com/openSUSE/open-build-service/commit/efe7476b5ddda16367d62… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/required_checks_controller.rb Log Message: ----------- Extract set_project before action to make error messages more verbose and follow single responsibilty. Commit: f59bcd46e3d285515a9dd247fc094205e1bed470 https://github.com/openSUSE/open-build-service/commit/f59bcd46e3d285515a9dd… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/concerns/set_checkable.rb M src/api/app/controllers/status/reports_controller.rb Log Message: ----------- Fix linting errors Commit: 012a8d87e31752c07509d3743789bc0fbf71ca76 https://github.com/openSUSE/open-build-service/commit/012a8d87e31752c07509d… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/policies/project_policy.rb M src/api/app/policies/status/report_policy.rb Log Message: ----------- Be more explicit in the policies No need to defer the decisions to index? Commit: c5c089472a92baa4816a3edb5e6e7dc0f531c0e2 https://github.com/openSUSE/open-build-service/commit/c5c089472a92baa4816a3… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/spec/factories/project.rb Log Message: ----------- Unlock :project_with_repository factory The factory was inside the factory above which would make this project locked. Looks like this was accidental... Commit: 06ec3621f203a7284e0bfe98ca1d8fe243d2d3c2 https://github.com/openSUSE/open-build-service/commit/06ec3621f203a7284e0bf… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/reports_controller.rb Log Message: ----------- Simplify set_status_report Reduce cognitive complexity. Commit: a1fa3ca705e73b114a791eba511b70aa14358786 https://github.com/openSUSE/open-build-service/commit/a1fa3ca705e73b114a791… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb A src/api/app/controllers/status/concerns/set_checkable.rb A src/api/app/controllers/status/reports_controller.rb M src/api/app/controllers/status/required_checks_controller.rb M src/api/app/controllers/webui/obs_factory/staging_projects_controller.rb M src/api/app/helpers/status/required_checks_helper.rb M src/api/app/helpers/webui/obs_factory/application_helper.rb M src/api/app/models/bs_request.rb M src/api/app/models/project.rb M src/api/app/models/repository.rb M src/api/app/models/status/check.rb A src/api/app/models/status/report.rb R src/api/app/models/status/repository_publish.rb M src/api/app/policies/project_policy.rb R src/api/app/policies/status/check_policy.rb A src/api/app/policies/status/report_policy.rb R src/api/app/views/status/checks/index.xml.builder A src/api/app/views/status/reports/_check.xml.builder A src/api/app/views/status/reports/show.xml.builder M src/api/app/views/webui/obs_factory/staging_projects/_checks.html.haml M src/api/config/routes.rb A src/api/db/migrate/20180906115417_add_required_checks_to_projects.rb A src/api/db/migrate/20180906142702_create_status_reports.rb A src/api/db/migrate/20180906142802_update_status_checks_table.rb M src/api/db/structure.sql M src/api/spec/controllers/status/checks_controller_spec.rb A src/api/spec/controllers/status/reports_controller_spec.rb M src/api/spec/factories/checks.rb M src/api/spec/factories/groups.rb M src/api/spec/factories/project.rb A src/api/spec/factories/status_reports.rb R src/api/spec/factories/status_repository_publish.rb R src/api/spec/fixtures/files/check.xml R src/api/spec/fixtures/files/invalid_check.xml M src/api/spec/models/status/check_spec.rb A src/api/spec/models/status/report_spec.rb R src/api/spec/models/status/repository_publish_spec.rb A src/api/spec/policies/status/report_policy_spec.rb Log Message: ----------- Merge pull request #5862 from ChrisBr/refactor_check_controller Refactor check controller Commit: 114d3098d91aa54e0d8e5039e252f8bfa22acdbc https://github.com/openSUSE/open-build-service/commit/114d3098d91aa54e0d8e5… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-09-20 (Thu, 20 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update capybara to version 3.8.0 Commit: 7d6074ab0881dca8a704b730c51e26d91ff039f6 https://github.com/openSUSE/open-build-service/commit/7d6074ab0881dca8a704b… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/app/assets/stylesheets/webui2/texts.scss M src/api/app/views/layouts/webui2/_watchlist.html.haml M src/api/app/views/layouts/webui2/_watchlist_dropdown.html.haml Log Message: ----------- Merge pull request #5883 from DavidKang/fix/watchlist Make watchlist smaller Commit: dcdefa2c0b5296ac2856959f03fc87970246d512 https://github.com/openSUSE/open-build-service/commit/dcdefa2c0b5296ac28569… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5887 from openSUSE/depfu/update/srcapi/capybara-3.8.0 [src/api] Update capybara: 3.7.2 → 3.8.0 (minor) Commit: 420087ae584eea515c248b5eaa953573a09dadd7 https://github.com/openSUSE/open-build-service/commit/420087ae584eea515c248… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/app/models/status/report.rb M src/api/spec/models/status/report_spec.rb Log Message: ----------- Always set Status::Report.uuid I think it's nicer of the reports just always have an uuid. Regardless if we need them or not. Makes rendering and validating way easier. Commit: 3c99cb9c86a99759194a36fa5249529062e7c359 https://github.com/openSUSE/open-build-service/commit/3c99cb9c86a99759194a3… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/app/views/status/checks/_check.xml.builder R src/api/app/views/status/reports/_check.xml.builder M src/api/app/views/status/reports/show.xml.builder Log Message: ----------- Simplify Status Views No need for two check views that do the same. Commit: 5f2f2118c40fe29258ab39364c3386a81b2c31a6 https://github.com/openSUSE/open-build-service/commit/5f2f2118c40fe29258ab3… Author: Moisés Déniz Alemán <mdeniz(a)suse.com> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: A src/api/app/assets/stylesheets/webui2/modals.scss M src/api/app/assets/stylesheets/webui2/webui2.css.scss M src/api/app/controllers/webui2/comments_controller.rb A src/api/app/views/webui2/webui/attribute/_delete_dialog.html.haml M src/api/app/views/webui2/webui/attribute/index.html.haml A src/api/app/views/webui2/webui/comment/_delete_dialog.html.haml M src/api/app/views/webui2/webui/comment/_links.html.haml A src/api/app/views/webui2/webui/comment/create.js.haml R src/api/app/views/webui2/webui/comment/create_or_destroy.js.haml A src/api/app/views/webui2/webui/comment/destroy.js.haml M src/api/app/views/webui2/webui/main/_add_status_message_modal.html.haml M src/api/app/views/webui2/webui/package/_branch_dialog.html.haml M src/api/app/views/webui2/webui/package/_delete_dialog.html.haml A src/api/app/views/webui2/webui/package/_delete_file_dialog.html.haml M src/api/app/views/webui2/webui/package/_files_view.html.haml M src/api/app/views/webui2/webui/package/_linking_packages.html.haml M src/api/app/views/webui2/webui/package/_submit_request_dialog.html.haml M src/api/app/views/webui2/webui/request/_add_role_request_dialog.html.haml M src/api/app/views/webui2/webui/request/_change_devel_request_dialog.html.haml M src/api/app/views/webui2/webui/request/_delete_request_dialog.html.haml M src/api/spec/bootstrap/features/webui/maintenance_workflow_spec.rb M src/api/spec/bootstrap/features/webui/packages_spec.rb Log Message: ----------- Merge pull request #5890 from openSUSE/bootstrap-master Bootstrap master Commit: 95756859f86a890170317efc7c76ee2ecc8638b1 https://github.com/openSUSE/open-build-service/commit/95756859f86a890170317… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/app/models/status/report.rb M src/api/app/views/status/checks/_check.xml.builder R src/api/app/views/status/reports/_check.xml.builder M src/api/app/views/status/reports/show.xml.builder M src/api/spec/models/status/report_spec.rb Log Message: ----------- Merge pull request #5888 from hennevogel/bugfix/status Bugfix/status Commit: f136f2fc897866a5ed9433664e245141d8fdc3fd https://github.com/openSUSE/open-build-service/commit/f136f2fc897866a5ed943… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/app/controllers/webui/obs_factory/staging_projects_controller.rb Log Message: ----------- Change build_id to uuid Fixes #5891. Commit: 59eae11b2de71649bb41d4c8bce0da820faba52d https://github.com/openSUSE/open-build-service/commit/59eae11b2de71649bb41d… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/app/controllers/webui/obs_factory/staging_projects_controller.rb Log Message: ----------- Merge pull request #5893 from eduardoj/fix_5891 Change build_id to uuid Commit: 4575ace2b87a99ef588bab16efb935875445a8a8 https://github.com/openSUSE/open-build-service/commit/4575ace2b87a99ef588ba… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/config/routes.rb Log Message: ----------- Drop '/checks' from end of Status::Reports#show routes because this is the personal preference of our stakeholders. As we always want to make them happy we do this :) Commit: 0619e20fafed0bbf0289bcb4bb9d9ad19519a200 https://github.com/openSUSE/open-build-service/commit/0619e20fafed0bbf0289b… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/config/routes.rb M src/api/spec/controllers/status/checks_controller_spec.rb Log Message: ----------- Change status_api create to use #update to POST because this is the personal preference of our stakeholders. As we always want to make them happy we do this :) Commit: 1cbd4013a598783f8614087c279a7f3f2d9a3ff6 https://github.com/openSUSE/open-build-service/commit/1cbd4013a598783f86140… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/config/routes.rb M src/api/spec/controllers/status/checks_controller_spec.rb Log Message: ----------- Merge pull request #5892 from ChrisBr/checks/prune-route Drop /checks from end of route Commit: 63be27138609e3e3362fefe367de5ffa14e8cce1 https://github.com/openSUSE/open-build-service/commit/63be27138609e3e3362fe… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop to version 0.59.1 Commit: a9cce93d317a7bed12481cdc776bbad60b1dd856 https://github.com/openSUSE/open-build-service/commit/a9cce93d317a7bed12481… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M .rubocop_todo.yml M src/api/.rubocop_todo.yml Log Message: ----------- Regenerate Rubocop todo file after update New offenses due to the update from Rubocop 0.58.2 to 0.59.1 Commit: 2e66541326c2e7e9f487b52a53b03266e4cdd80d https://github.com/openSUSE/open-build-service/commit/2e66541326c2e7e9f487b… Author: Stasiek Michalski <hellcp(a)opensuse.org> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: M src/api/app/views/layouts/webui2/_navigation.html.haml Log Message: ----------- [webui] Use new SVG logo Commit: 322134dff3b766c3b41c39f017e0fb4a962f39de https://github.com/openSUSE/open-build-service/commit/322134dff3b766c3b41c3… Author: Stasiek Michalski <hellcp(a)opensuse.org> Date: 2018-09-21 (Fri, 21 Sep 2018) Changed paths: A src/api/app/assets/images/obs-logo_small.svg Log Message: ----------- [webui] Add logo Commit: 117ce89af2527b33c9083ada3b1a5f8c69b32956 https://github.com/openSUSE/open-build-service/commit/117ce89af2527b33c9083… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-09-22 (Sat, 22 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update bunny to version 2.12.0 Commit: 09cbe1433b91b0aa90e2fbb22c91eaa1c3d75a49 https://github.com/openSUSE/open-build-service/commit/09cbe1433b91b0aa90e2f… Author: David Kang <dkang(a)suse.com> Date: 2018-09-22 (Sat, 22 Sep 2018) Changed paths: A src/api/app/assets/images/obs-logo_small.svg M src/api/app/views/layouts/webui2/_navigation.html.haml Log Message: ----------- Merge pull request #5895 from hellcp/patch-3 Use current OBS logo for webui2 Commit: fcc221a0267a4d15e707833f403f7e415fb03f6c https://github.com/openSUSE/open-build-service/commit/fcc221a0267a4d15e7078… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M .rubocop_todo.yml M src/api/.rubocop_todo.yml M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5865 from openSUSE/depfu/update/srcapi/rubocop-0.59.1 [src/api] Update rubocop: 0.58.2 → 0.59.1 (major) Commit: 364e14a82e1e64fa6e99fbbbd0d1a4e447ff68cc https://github.com/openSUSE/open-build-service/commit/364e14a82e1e64fa6e99f… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update capybara to version 3.8.1 Commit: 2d7b120a7abd27073d09a34eb8869caff2fcb223 https://github.com/openSUSE/open-build-service/commit/2d7b120a7abd27073d09a… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5881 from openSUSE/depfu/update/srcapi/sass-3.6.0 [src/api] Update sass: 3.5.7 → 3.6.0 (minor) Commit: ef38bd2b2fd6becd71262ba8e32f8fc94623e2df https://github.com/openSUSE/open-build-service/commit/ef38bd2b2fd6becd71262… Author: Eduardo J <enavarro(a)suse.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5898 from openSUSE/depfu/update/srcapi/capybara-3.8.1 [src/api] Update capybara: 3.8.0 → 3.8.1 (patch) Commit: 3a041883e2211b587f5fdc96e28f24d6fffa9a4f https://github.com/openSUSE/open-build-service/commit/3a041883e2211b587f5fd… Author: David Kang <dkang(a)suse.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: A src/api/app/assets/stylesheets/webui2/comments.scss M src/api/app/assets/stylesheets/webui2/webui2.css.scss Log Message: ----------- Add style for `pre` tag in comments The content with `pre` tag was overflowing the comment box. Commit: 57afe6f84a5983b6ab69d10d7e7f2dfceecac55b https://github.com/openSUSE/open-build-service/commit/57afe6f84a5983b6ab69d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/spec/controllers/status/required_checks_controller_spec.rb Log Message: ----------- Fix tests for required checks controller The tested http requests was only added to the first it-block of some of the shared examples. Because of that the following it-blocks were testing the login requests (test preparation) instead of the actual controller action. This commit fixes it by moving the tested http request into a subject and re-using it in every it-block. Commit: 9622795ba351783817cb1f5ec1a9ec9dcd5d561f https://github.com/openSUSE/open-build-service/commit/9622795ba351783817cb1… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5896 from openSUSE/depfu/update/srcapi/bunny-2.12.0 [src/api] Update bunny: 2.11.0 → 2.12.0 (minor) Commit: 74d9af0af0c3127e3aa660a954d0ef895362f3c0 https://github.com/openSUSE/open-build-service/commit/74d9af0af0c3127e3aa66… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update riddle to version 2.3.2 Commit: d742df6c11de9fdc1ce2948130d62c9da440a782 https://github.com/openSUSE/open-build-service/commit/d742df6c11de9fdc1ce29… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop to version 0.59.2 Commit: 5407df3b4960d4223439ccca9f2ff8697366185f https://github.com/openSUSE/open-build-service/commit/5407df3b4960d4223439c… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: A src/api/app/assets/stylesheets/webui2/comments.scss M src/api/app/assets/stylesheets/webui2/webui2.css.scss Log Message: ----------- Merge pull request #5901 from DavidKang/bugfix/comments Add style for `pre` tag in comments Commit: d7e1f9dbdadfd3e1eb859fd1fc7c790e3c74559a https://github.com/openSUSE/open-build-service/commit/d7e1f9dbdadfd3e1eb859… Author: Eduardo J <enavarro(a)suse.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5899 from openSUSE/depfu/update/srcapi/riddle-2.3.2 [src/api] Update riddle: 2.3.1 → 2.3.2 (patch) Commit: 5f32c5f8f0777924ec40007f5693544fa9908a9c https://github.com/openSUSE/open-build-service/commit/5f32c5f8f0777924ec400… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5897 from openSUSE/depfu/update/srcapi/rubocop-0.59.2 [src/api] Update rubocop: 0.59.1 → 0.59.2 (minor) Commit: 3a680f6ac131676fd0ef90b4cc6149b24cca2c72 https://github.com/openSUSE/open-build-service/commit/3a680f6ac131676fd0ef9… Author: Moisés Déniz Alemán <mdeniz(a)suse.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/spec/controllers/status/required_checks_controller_spec.rb Log Message: ----------- Merge pull request #5902 from bgeuken/fix_required_checks_test Fix tests for required checks controller Commit: 778d4d7135bf21d26990f3084526fe1c80ac12e6 https://github.com/openSUSE/open-build-service/commit/778d4d7135bf21d26990f… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M .rubocop_todo.yml M src/api/.rubocop_todo.yml M src/api/Gemfile.lock A src/api/app/assets/images/obs-logo_small.svg A src/api/app/assets/stylesheets/webui2/comments.scss M src/api/app/assets/stylesheets/webui2/texts.scss M src/api/app/assets/stylesheets/webui2/webui2.css.scss M src/api/app/controllers/status/checks_controller.rb A src/api/app/controllers/status/concerns/set_checkable.rb A src/api/app/controllers/status/reports_controller.rb M src/api/app/controllers/status/required_checks_controller.rb M src/api/app/controllers/webui/obs_factory/staging_projects_controller.rb M src/api/app/helpers/status/required_checks_helper.rb M src/api/app/helpers/webui/obs_factory/application_helper.rb M src/api/app/models/bs_request.rb M src/api/app/models/project.rb M src/api/app/models/repository.rb M src/api/app/models/status/check.rb A src/api/app/models/status/report.rb R src/api/app/models/status/repository_publish.rb M src/api/app/policies/project_policy.rb R src/api/app/policies/status/check_policy.rb A src/api/app/policies/status/report_policy.rb M src/api/app/views/layouts/webui2/_navigation.html.haml M src/api/app/views/layouts/webui2/_watchlist.html.haml M src/api/app/views/layouts/webui2/_watchlist_dropdown.html.haml M src/api/app/views/status/checks/_check.xml.builder R src/api/app/views/status/checks/index.xml.builder A src/api/app/views/status/reports/show.xml.builder M src/api/app/views/webui/obs_factory/staging_projects/_checks.html.haml M src/api/config/routes.rb A src/api/db/migrate/20180906115417_add_required_checks_to_projects.rb A src/api/db/migrate/20180906142702_create_status_reports.rb A src/api/db/migrate/20180906142802_update_status_checks_table.rb M src/api/db/structure.sql M src/api/spec/controllers/status/checks_controller_spec.rb A src/api/spec/controllers/status/reports_controller_spec.rb M src/api/spec/controllers/status/required_checks_controller_spec.rb M src/api/spec/factories/checks.rb M src/api/spec/factories/groups.rb M src/api/spec/factories/project.rb A src/api/spec/factories/status_reports.rb R src/api/spec/factories/status_repository_publish.rb R src/api/spec/fixtures/files/check.xml R src/api/spec/fixtures/files/invalid_check.xml M src/api/spec/models/status/check_spec.rb A src/api/spec/models/status/report_spec.rb R src/api/spec/models/status/repository_publish_spec.rb A src/api/spec/policies/status/report_policy_spec.rb M src/backend/bs_admin M src/backend/bs_dodup Log Message: ----------- Merge pull request #5910 from openSUSE/master Update bootstrap master branch Compare: https://github.com/openSUSE/open-build-service/compare/810495694589...778d4… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 57afe6: Fix tests for required checks controller
by Moisés Déniz Alemán 24 Sep '18

24 Sep '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 57afe6f84a5983b6ab69d10d7e7f2dfceecac55b https://github.com/openSUSE/open-build-service/commit/57afe6f84a5983b6ab69d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/spec/controllers/status/required_checks_controller_spec.rb Log Message: ----------- Fix tests for required checks controller The tested http requests was only added to the first it-block of some of the shared examples. Because of that the following it-blocks were testing the login requests (test preparation) instead of the actual controller action. This commit fixes it by moving the tested http request into a subject and re-using it in every it-block. Commit: 3a680f6ac131676fd0ef90b4cc6149b24cca2c72 https://github.com/openSUSE/open-build-service/commit/3a680f6ac131676fd0ef9… Author: Moisés Déniz Alemán <mdeniz(a)suse.com> Date: 2018-09-24 (Mon, 24 Sep 2018) Changed paths: M src/api/spec/controllers/status/required_checks_controller_spec.rb Log Message: ----------- Merge pull request #5902 from bgeuken/fix_required_checks_test Fix tests for required checks controller Compare: https://github.com/openSUSE/open-build-service/compare/5f32c5f8f077...3a680… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 24 Sep '18

24 Sep '18

Branch: refs/heads/depfu/update/srcapi/rubocop-0.59.2 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0