August 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] d00308: Refactor list of problems in openQA dashboard
by Henne Vogelsang 24 Aug '18

24 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d003083a8cf0ea13f1241426240d0738f8cd791e https://github.com/openSUSE/open-build-service/commit/d003083a8cf0ea13f1241… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/app/views/webui/obs_factory/staging_projects/_problems.html.erb Log Message: ----------- Refactor list of problems in openQA dashboard - Remove unneeded `if` branch. - Replace `max` by `num_elements` and subsctract 1 when it is used in a range in favour of readability. Co-authored-by: Ana María Martínez Gómez <ammartinez(a)suse.de> Co-authored-by: David Kang <dkang(a)suse.com> Commit: ffd8ab35c1f878396b0e341a021794f201003159 https://github.com/openSUSE/open-build-service/commit/ffd8ab35c1f878396b0e3… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-08-24 (Fri, 24 Aug 2018) Changed paths: M src/api/app/views/webui/obs_factory/staging_projects/_problems.html.erb Log Message: ----------- Merge pull request #5706 from saraycp/refactor_problems_list Refactor list of problems in openQA dashboard Compare: https://github.com/openSUSE/open-build-service/compare/3df57ef65208...ffd8a… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 3ea7b0: Add a metric for acknowledged announcements
by Henne Vogelsang 24 Aug '18

24 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3ea7b0294567763b2a46d0ef957f92a36d1ecaaa https://github.com/openSUSE/open-build-service/commit/3ea7b0294567763b2a46d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-24 (Fri, 24 Aug 2018) Changed paths: M src/api/app/controllers/webui/users/announcements_controller.rb Log Message: ----------- Add a metric for acknowledged announcements Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Commit: a02d98374d15a8b4686096cae2e78ae2200d27e5 https://github.com/openSUSE/open-build-service/commit/a02d98374d15a8b468609… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-24 (Fri, 24 Aug 2018) Changed paths: M ReleaseNotes-2.10 Log Message: ----------- Mention new Terms of Services feature in Releasenotes Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Commit: 3df57ef652083638038d464e407194b9f3196a8c https://github.com/openSUSE/open-build-service/commit/3df57ef652083638038d4… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-08-24 (Fri, 24 Aug 2018) Changed paths: M ReleaseNotes-2.10 M src/api/app/controllers/webui/users/announcements_controller.rb Log Message: ----------- Merge pull request #5711 from bgeuken/metrics_and_releasenotes_for_announcements Metrics and releasenotes for announcements Compare: https://github.com/openSUSE/open-build-service/compare/183c7f4651f3...3df57… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 5d9a83: Add a metric to track users joining / leaving the ...
by Henne Vogelsang 24 Aug '18

24 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5d9a8325ea24b1b498ce58629d91827f7b392606 https://github.com/openSUSE/open-build-service/commit/5d9a8325ea24b1b498ce5… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-24 (Fri, 24 Aug 2018) Changed paths: M src/api/app/models/user.rb Log Message: ----------- Add a metric to track users joining / leaving the beta group Co-authored-by: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Commit: 1288cbfe6e0a3958d01a79211c53717e035eeeae https://github.com/openSUSE/open-build-service/commit/1288cbfe6e0a3958d01a7… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-24 (Fri, 24 Aug 2018) Changed paths: M src/api/app/models/user.rb Log Message: ----------- Update metrics for creating / deleting users We don't want to track data that would allow to identify users. Commit: 183c7f4651f34daa32d53e162a71c1aa7da99977 https://github.com/openSUSE/open-build-service/commit/183c7f4651f34daa32d53… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-08-24 (Fri, 24 Aug 2018) Changed paths: M src/api/app/models/user.rb Log Message: ----------- Merge pull request #5712 from bgeuken/add_metric_for_beta_users Add a metric to track users joining / leaving the beta group Compare: https://github.com/openSUSE/open-build-service/compare/9937ee198075...183c7… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 1ff6f3: Add bootstrap theme to package request tab
by Björn Geuken 24 Aug '18

24 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1ff6f3d97bb4200fec505b7ed68dd6978c0d2b96 https://github.com/openSUSE/open-build-service/commit/1ff6f3d97bb4200fec505… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-24 (Fri, 24 Aug 2018) Changed paths: M src/api/app/assets/javascripts/webui2/application.js M src/api/app/assets/javascripts/webui2/datatables.js A src/api/app/assets/javascripts/webui2/requests_table.js.erb M src/api/app/assets/stylesheets/webui2/datatables.scss M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/packages/bs_requests_controller.rb A src/api/app/views/webui2/shared/_requests_state_and_type_form.html.haml A src/api/app/views/webui2/shared/_requests_table.html.haml A src/api/app/views/webui2/shared/bs_requests/index.json.erb M src/api/app/views/webui2/webui/package/_breadcrumb_items.html.haml A src/api/app/views/webui2/webui/package/requests.html.haml Log Message: ----------- Add bootstrap theme to package request tab This ports the package request tab over to our new Bootstrap theme. While porting this over we dropped: * The additional spinner for indicating that the request table get's updated. We already been using the datatable "processing" overlay for that. * The custom counter of currently showed requests got replaced by the datatable "info". Commit: 8ff7a502e757b8de63d52d82e9c0f5e56074edf8 https://github.com/openSUSE/open-build-service/commit/8ff7a502e757b8de63d52… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-24 (Fri, 24 Aug 2018) Changed paths: M src/api/app/assets/javascripts/webui2/requests_table.js.erb Log Message: ----------- Use Font Awesome animation icons for our spinners in Webui2 Commit: 3ac483a9aa501eb618d2593575f17664f25cdde1 https://github.com/openSUSE/open-build-service/commit/3ac483a9aa501eb618d25… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-24 (Fri, 24 Aug 2018) Changed paths: M src/api/spec/support/capybara.rb Log Message: ----------- Increase screen size within capybara Since our existing feature tests are made for views with larger screens, they would fail for the new bootstrap theme. That's because elements would be hidden or rearranged for smaller screens and not be found by the capybara selectors. Commit: 9937ee1980756610e75271f99347964fd3b2d31d https://github.com/openSUSE/open-build-service/commit/9937ee1980756610e7527… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-24 (Fri, 24 Aug 2018) Changed paths: M src/api/app/assets/javascripts/webui2/application.js M src/api/app/assets/javascripts/webui2/datatables.js A src/api/app/assets/javascripts/webui2/requests_table.js.erb M src/api/app/assets/stylesheets/webui2/datatables.scss M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/packages/bs_requests_controller.rb A src/api/app/views/webui2/shared/_requests_state_and_type_form.html.haml A src/api/app/views/webui2/shared/_requests_table.html.haml A src/api/app/views/webui2/shared/bs_requests/index.json.erb M src/api/app/views/webui2/webui/package/_breadcrumb_items.html.haml A src/api/app/views/webui2/webui/package/requests.html.haml M src/api/spec/support/capybara.rb Log Message: ----------- Merge pull request #5691 from bgeuken/bootstrap_package_requests Bootstrap package requests Compare: https://github.com/openSUSE/open-build-service/compare/a89f120c27c6...9937e… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] a65e25: Move exceptions classes from bs_request_action to ...
by Henne Vogelsang 23 Aug '18

23 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a65e257229250c04d21e18abedb0f841a737a820 https://github.com/openSUSE/open-build-service/commit/a65e257229250c04d21e1… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/jobs/bs_request_action_webui_infos_job.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action/differ/for_source.rb A src/api/app/models/bs_request_action/errors.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/event/request.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/models/bs_request_action/differ/for_source_spec.rb M src/api/spec/models/bs_request_action_delete_spec.rb Log Message: ----------- Move exceptions classes from bs_request_action to its own module To reduce code clutter, following the pattern already used in other models like `project.rb` or `package.rb` move the exception classes to its own errors.rb file Commit: a89f120c27c6b949bc337943149766fbbb8ab50b https://github.com/openSUSE/open-build-service/commit/a89f120c27c6b949bc337… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-08-24 (Fri, 24 Aug 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/jobs/bs_request_action_webui_infos_job.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action/differ/for_source.rb A src/api/app/models/bs_request_action/errors.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/event/request.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/models/bs_request_action/differ/for_source_spec.rb M src/api/spec/models/bs_request_action_delete_spec.rb Log Message: ----------- Merge pull request #5709 from vpereira/bs_request_action_errors Move exceptions classes from bs_request_action to its own module Compare: https://github.com/openSUSE/open-build-service/compare/751521c58e7e...a89f1… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/obs-build] ce9653: support parsing of repos where the .repo file got ...
by GitHub 23 Aug '18

23 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: ce9653c1bd783deccfa7925151e9ba7fe5666bfe https://github.com/openSUSE/obs-build/commit/ce9653c1bd783deccfa7925151e9ba… Author: Adrian Schröter <adrian(a)suse.de> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M Build/Docker.pm Log Message: ----------- support parsing of repos where the .repo file got used **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 0359b5: Add Terms of Service to the views
by Moisés Déniz Alemán 23 Aug '18

23 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0359b57a7eea09f1f10eabf143f362d19e8425fc https://github.com/openSUSE/open-build-service/commit/0359b57a7eea09f1f10ea… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/assets/stylesheets/webui/application.css.erb A src/api/app/assets/stylesheets/webui/application/announcements.scss A src/api/app/controllers/webui/announcements_controller.rb A src/api/app/controllers/webui/users/announcements_controller.rb M src/api/app/controllers/webui/webui_controller.rb R src/api/app/helpers/comment_helper.rb A src/api/app/helpers/webui/markdown_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/mailers/event_mailer.rb M src/api/app/models/announcement.rb M src/api/app/views/event_mailer/comment_for_package.html.haml M src/api/app/views/event_mailer/comment_for_project.html.haml M src/api/app/views/event_mailer/comment_for_request.html.haml A src/api/app/views/layouts/webui/_announcement.html.haml M src/api/app/views/layouts/webui/webui.html.erb M src/api/app/views/layouts/webui2/_footer.html.haml A src/api/app/views/webui/announcements/show.html.haml M src/api/app/views/webui/comment/_show.html.haml M src/api/app/views/webui/main/_status_messages.html.haml A src/api/app/views/webui/users/announcements/create.js.erb M src/api/app/views/webui2/status_messages/_item.html.haml M src/api/config/routes.rb A src/api/spec/cassettes/Announcements_for_users/logged_in_users_see_a_new_announcements_notification_and_can_acknowledge_it.yml A src/api/spec/controllers/webui/users/announcements_controller_spec.rb A src/api/spec/features/webui/announcements_spec.rb R src/api/spec/helpers/comment_helper_spec.rb A src/api/spec/helpers/webui/markdown_helper_spec.rb Log Message: ----------- Add Terms of Service to the views Terms of Services are shown on any page of the Webui until a user acknowledges them. When there are new ToS the ToS notification message appears again and the user has to acknowledge the new version. The show page provides the full text of the ToS, while the notification message just contains a link to it. Additionally: * Terms of Services / announcement can be rendered as markdown. * The order of ToS versions is tracked via it's creation time. * The footer contains a 'Terms of Services' that links to the most recent ToS, if there are any. Co-authored-by: Björn Geuken <bgeuken(a)suse.de> Co-authored-by: David Kang <dkang(a)suse.com> Commit: 8a8a463e197bfebad33279a0193868f2ebb79079 https://github.com/openSUSE/open-build-service/commit/8a8a463e197bfebad3327… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/app/views/layouts/webui/webui.html.erb Log Message: ----------- Change syntax of hash rockets and strings Commit: 9abbce7d7c35fff3dcfb8a3841f2587211779e7c https://github.com/openSUSE/open-build-service/commit/9abbce7d7c35fff3dcfb8… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/app/views/layouts/webui2/_footer.html.haml Log Message: ----------- Replace haml '%a' tags by rails link_to To follow OBS style using rails helper link_to. Co-authored-by: Björn Geuken <bgeuken(a)suse.de> Commit: 751521c58e7e3d9118d40904550d8478404e7769 https://github.com/openSUSE/open-build-service/commit/751521c58e7e3d9118d40… Author: Moisés Déniz Alemán <mdeniz(a)suse.com> Date: 2018-08-23 (Thu, 23 Aug 2018) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/assets/stylesheets/webui/application.css.erb A src/api/app/assets/stylesheets/webui/application/announcements.scss A src/api/app/controllers/webui/announcements_controller.rb A src/api/app/controllers/webui/users/announcements_controller.rb M src/api/app/controllers/webui/webui_controller.rb R src/api/app/helpers/comment_helper.rb A src/api/app/helpers/webui/markdown_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/mailers/event_mailer.rb M src/api/app/models/announcement.rb M src/api/app/views/event_mailer/comment_for_package.html.haml M src/api/app/views/event_mailer/comment_for_project.html.haml M src/api/app/views/event_mailer/comment_for_request.html.haml A src/api/app/views/layouts/webui/_announcement.html.haml M src/api/app/views/layouts/webui/webui.html.erb M src/api/app/views/layouts/webui2/_footer.html.haml A src/api/app/views/webui/announcements/show.html.haml M src/api/app/views/webui/comment/_show.html.haml M src/api/app/views/webui/main/_status_messages.html.haml A src/api/app/views/webui/users/announcements/create.js.erb M src/api/app/views/webui2/status_messages/_item.html.haml M src/api/config/routes.rb A src/api/spec/cassettes/Announcements_for_users/logged_in_users_see_a_new_announcements_notification_and_can_acknowledge_it.yml A src/api/spec/controllers/webui/users/announcements_controller_spec.rb A src/api/spec/features/webui/announcements_spec.rb R src/api/spec/helpers/comment_helper_spec.rb A src/api/spec/helpers/webui/markdown_helper_spec.rb Log Message: ----------- Merge pull request #5627 from bgeuken/terms_of_service_dialog_part_2 Add Terms of Service to the views Compare: https://github.com/openSUSE/open-build-service/compare/7eae452547ba...75152… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 67654a: Align breadcrumbs' style with personal navigation
by Henne Vogelsang 22 Aug '18

22 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 67654a43ee4a96084b0b14f6ce2a29f0748d328f https://github.com/openSUSE/open-build-service/commit/67654a43ee4a96084b0b1… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/app/assets/stylesheets/webui2/breadcrumbs-component.scss Log Message: ----------- Align breadcrumbs' style with personal navigation The font size and the padding top is now the same for both components, making them fit better together. It also gives us more room in the breadcrumbs, thanks to the smaller font. Commit: 7eae452547bab08689abd09340c2ef84c258f3f0 https://github.com/openSUSE/open-build-service/commit/7eae452547bab08689abd… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/app/assets/stylesheets/webui2/breadcrumbs-component.scss Log Message: ----------- Merge pull request #5708 from dmarcoux/align_breadcrumbs_style_with_personal_navigation Align breadcrumbs' style with personal navigation Compare: https://github.com/openSUSE/open-build-service/compare/72f494c546f4...7eae4… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 22 Aug '18

22 Aug '18

Branch: refs/heads/depfu/update/srcapi/data_migrate-5.0.0 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 571dcf: add feature test for package requests
by Henne Vogelsang 22 Aug '18

22 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 571dcf1233d33ceb93e084ef34899a066cffdbfa https://github.com/openSUSE/open-build-service/commit/571dcf1233d33ceb93e08… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/spec/features/webui/packages_spec.rb Log Message: ----------- add feature test for package requests Commit: af23a9ec0f783fef4dc2b1bd766d6197df6fdd61 https://github.com/openSUSE/open-build-service/commit/af23a9ec0f783fef4dc2b… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/config/routes.rb M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Add controller tests for save_new action Commit: b8f5a9d251f356786ec60a1af5b1f8336df00979 https://github.com/openSUSE/open-build-service/commit/b8f5a9d251f356786ec60… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: A src/api/spec/cassettes/Packages/existing_requests/see_a_request.yml A src/api/spec/cassettes/Webui_PackageController/GET_dependency/1_23_1.yml A src/api/spec/cassettes/Webui_PackageController/GET_dependency/1_23_2.yml A src/api/spec/cassettes/Webui_PackageController/POST_save_new/invalid_package_name/1_22_2_1.yml A src/api/spec/cassettes/Webui_PackageController/POST_save_new/invalid_package_name/1_22_2_2.yml A src/api/spec/cassettes/Webui_PackageController/POST_save_new/invalid_package_name/1_22_2_3.yml A src/api/spec/cassettes/Webui_PackageController/POST_save_new/valid_package_name/1_22_1_1.yml A src/api/spec/cassettes/Webui_PackageController/POST_save_new/valid_package_name/1_22_1_2.yml A src/api/spec/cassettes/Webui_PackageController/POST_save_new/valid_package_name/1_22_1_3.yml Log Message: ----------- add necessary VCR cassettes Commit: a70301f5aec0d954f3edafa81d4ac77a3a535e0c https://github.com/openSUSE/open-build-service/commit/a70301f5aec0d954f3eda… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Remove unecessary comment Co-authored-by: Moisés Déniz Alemán <mdeniz(a)suse.com> Commit: 3d1d4cc61d7531ee2e67b4baa6ff68f37086561f https://github.com/openSUSE/open-build-service/commit/3d1d4cc61d7531ee2e67b… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- Move check_package_name_for_new to a before_action check_package_name_for_new should be a before_action since its just doing parameter validations and move the method check_package_name_for_new to private Co-authored-by: Moisés Déniz Alemán <mdeniz(a)suse.com> Commit: 4f043a871fd2e62c17e8c94d807df590e10b0353 https://github.com/openSUSE/open-build-service/commit/4f043a871fd2e62c17e8c… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Add test case for source_protection and friends Commit: 93f3deb3442bbe2afca4adcfbac43b26b4b12585 https://github.com/openSUSE/open-build-service/commit/93f3deb3442bbe2afca4a… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/spec/controllers/webui/package_controller_spec.rb Log Message: ----------- Add testcase for when the package save fails This condition is hard to test, because of the before_action check_package_name_for_new, which does the validations already Commit: 72f494c546f4677ffe79acb8ea37fb4dd705d6bb https://github.com/openSUSE/open-build-service/commit/72f494c546f4677ffe79a… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-08-22 (Wed, 22 Aug 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/config/routes.rb A src/api/spec/cassettes/Packages/existing_requests/see_a_request.yml A src/api/spec/cassettes/Webui_PackageController/GET_dependency/1_23_1.yml A src/api/spec/cassettes/Webui_PackageController/GET_dependency/1_23_2.yml A src/api/spec/cassettes/Webui_PackageController/POST_save_new/invalid_package_name/1_22_2_1.yml A src/api/spec/cassettes/Webui_PackageController/POST_save_new/invalid_package_name/1_22_2_2.yml A src/api/spec/cassettes/Webui_PackageController/POST_save_new/invalid_package_name/1_22_2_3.yml A src/api/spec/cassettes/Webui_PackageController/POST_save_new/valid_package_name/1_22_1_1.yml A src/api/spec/cassettes/Webui_PackageController/POST_save_new/valid_package_name/1_22_1_2.yml A src/api/spec/cassettes/Webui_PackageController/POST_save_new/valid_package_name/1_22_1_3.yml M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/features/webui/packages_spec.rb Log Message: ----------- Merge pull request #5527 from vpereira/package_creation extend coverage of package specs Compare: https://github.com/openSUSE/open-build-service/compare/0b50b416806d...72f49… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0