August 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 3f3526: Enforce presence of cmd in the query string
by Björn Geuken 31 Aug '18

31 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3f352610ff6c4ece863a69b4e5b11ed19ab47112 https://github.com/openSUSE/open-build-service/commit/3f352610ff6c4ece863a6… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/app/controllers/source_project_controller.rb Log Message: ----------- Enforce presence of cmd in the query string Without this, we raise an exception only when cmd is passed and invalid. However, when cmd is not passed, it leads to a 500 because cmd must be present to route to the correct action in source_controller.rb Fixes #5764 Commit: 15df17c479372396ccfcf0edaa2aff631b95e764 https://github.com/openSUSE/open-build-service/commit/15df17c479372396ccfcf… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/app/controllers/source_project_controller.rb Log Message: ----------- Merge pull request #5767 from dmarcoux/enforce_cmd_query_string Enforce presence of cmd in the query string Compare: https://github.com/openSUSE/open-build-service/compare/9459836a7640...15df1… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] de4f0f: Never consider the _nobody_ user as the displayed ...
by Eduardo J 31 Aug '18

31 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: de4f0fcc74fbe36ecaf1d571e2ac743d15f1a2b7 https://github.com/openSUSE/open-build-service/commit/de4f0fcc74fbe36ecaf1d… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/app/controllers/webui/webui_controller.rb Log Message: ----------- Never consider the _nobody_ user as the displayed user Without this, the links on the _nobody_ user's page are displayed. It doesn't make sense since nobody should be able to edit the _nobody_ user. Commit: 9459836a7640e5da59c4d8564f17b38a66878579 https://github.com/openSUSE/open-build-service/commit/9459836a7640e5da59c4d… Author: Eduardo J <enavarro(a)suse.com> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/app/controllers/webui/webui_controller.rb Log Message: ----------- Merge pull request #5766 from dmarcoux/user-nobody-links Never consider the _nobody_ user as the displayed user Compare: https://github.com/openSUSE/open-build-service/compare/7af77e8eb18d...94598… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/obs-build] 9f0d16: add SLE 12 SP4
by GitHub 31 Aug '18

31 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 9f0d16dc7e3df7d92bb35afceded27f9cfb81b56 https://github.com/openSUSE/obs-build/commit/9f0d16dc7e3df7d92bb35afceded27… Author: Adrian Schröter <adrian(a)suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: A configs/sle12.4.conf Log Message: ----------- add SLE 12 SP4 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] be83ce: Fix rendering of webui2 view in project request ta...
by Björn Geuken 31 Aug '18

31 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: be83cec561d75280ae5f0ccccda7cf6ed7e3cb1c https://github.com/openSUSE/open-build-service/commit/be83cec561d75280ae5f0… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/app/controllers/webui/projects/bs_requests_controller.rb Log Message: ----------- Fix rendering of webui2 view in project request tab Within respond_to blocks prepending the webui2 path doesn't work. Therefore we have to explicitly name the partial. Commit: 7af77e8eb18da5bfe2e1e2b0fe103687f8adc0c0 https://github.com/openSUSE/open-build-service/commit/7af77e8eb18da5bfe2e1e… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/app/controllers/webui/projects/bs_requests_controller.rb Log Message: ----------- Merge pull request #5760 from bgeuken/fix_rendered_project_request_tab Fix rendering of webui2 view in project request tab Compare: https://github.com/openSUSE/open-build-service/compare/6a0b0d469779...7af77… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 5f2141: Drop unused exceptions from status message control...
by Björn Geuken 31 Aug '18

31 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5f214178f4064ab47cfed730bca05815de5f1c12 https://github.com/openSUSE/open-build-service/commit/5f214178f4064ab47cfed… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-30 (Thu, 30 Aug 2018) Changed paths: M src/api/app/controllers/status_controller.rb Log Message: ----------- Drop unused exceptions from status message controller * NotSubmitRequest * MultipleNotSupported * NotFoundError Co-authored-by: Victor Pereira <vpereira(a)suse.com> Commit: 433c94083e84371516d396c5344607f158e6bfef https://github.com/openSUSE/open-build-service/commit/433c94083e84371516d39… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-30 (Thu, 30 Aug 2018) Changed paths: M ReleaseNotes-2.10 M src/api/app/controllers/status_controller.rb A src/api/app/controllers/status_messages_controller.rb R src/api/app/views/status/_messages.xml.builder A src/api/app/views/status_messages/index.xml.builder M src/api/config/routes.rb M src/api/test/functional/status_controller_test.rb Log Message: ----------- Move status messages related actions to their own controller These actions are all responsible for a single object and deserve their own controller. In addition we: * Changed action name and route of "update" action which is actually a create (for creating one or multiple status messages) * Dropped public routes for status messages. Public routes are only used for innterconnects. We don't need to cover status messages for that (aka. it's not used for that purpose) Co-authored-by: Victor Pereira <vpereira(a)suse.com> Commit: c6b9d722f7f21329f3ba0bab0e5da89756df4b24 https://github.com/openSUSE/open-build-service/commit/c6b9d722f7f21329f3ba0… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-30 (Thu, 30 Aug 2018) Changed paths: A src/api/spec/controllers/status_messages_controller_spec.rb Log Message: ----------- Add tests for index and show action of status message controller Co-authored-by: Victor Pereira <vpereira(a)suse.com> Commit: 38f2ce1ebfe9521c373dd66066142c1283cab1a9 https://github.com/openSUSE/open-build-service/commit/38f2ce1ebfe9521c373dd… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/app/controllers/status_messages_controller.rb Log Message: ----------- Refactor creation of status messages in controller The method call is simple enough to not generate a helper method. Co-authored-by: Victor Pereira <vpereira(a)suse.com> Commit: b4843320837f9134b95e1740f69ed64c96ce951c https://github.com/openSUSE/open-build-service/commit/b4843320837f9134b95e1… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/app/controllers/status_messages_controller.rb M src/api/spec/controllers/status_messages_controller_spec.rb Log Message: ----------- Respond with created status messages when using the API Instead of returing with a generic "<status code='ok'/>" we now return the XML representation of the created objects. This allows to identify the created messages (via their id) and check the content of the created messages. Commit: 670b23095acebea6b6e1dd5df29e670aa34154d9 https://github.com/openSUSE/open-build-service/commit/670b23095acebea6b6e1d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M docs/api/api/api.txt Log Message: ----------- Update API documentation of status message routes * Add undocumented routes * Update existing routes Commit: 6a0b0d469779afd6c61ca27f9ddb66fa5dd9dea0 https://github.com/openSUSE/open-build-service/commit/6a0b0d469779afd6c61ca… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M ReleaseNotes-2.10 M docs/api/api/api.txt M src/api/app/controllers/status_controller.rb A src/api/app/controllers/status_messages_controller.rb R src/api/app/views/status/_messages.xml.builder A src/api/app/views/status_messages/index.xml.builder M src/api/config/routes.rb A src/api/spec/controllers/status_messages_controller_spec.rb M src/api/test/functional/status_controller_test.rb Log Message: ----------- Merge pull request #5739 from bgeuken/refactor_status_controller Refactor status controller Compare: https://github.com/openSUSE/open-build-service/compare/3f6c08bbd69c...6a0b0… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] d13cb4: Add a depfu badge
by Henne Vogelsang 31 Aug '18

31 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d13cb4aa48563ea705f39f47a25160d3075cd9cf https://github.com/openSUSE/open-build-service/commit/d13cb4aa48563ea705f39… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M README.md Log Message: ----------- Add a depfu badge Will show if our dependencies are stale in master. Commit: 3f6c08bbd69c9ab01ae69522623bfa2b5ed987a4 https://github.com/openSUSE/open-build-service/commit/3f6c08bbd69c9ab01ae69… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M README.md Log Message: ----------- Merge pull request #5763 from hennevogel/feature/depfu-badge Add a depfu badge Compare: https://github.com/openSUSE/open-build-service/compare/1be54c1ebbf0...3f6c0… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 2b6106: Add a feature test for using the request tab
by Björn Geuken 31 Aug '18

31 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2b61063d1e3fca24a0194de6f4ab2587ce8f6de7 https://github.com/openSUSE/open-build-service/commit/2b61063d1e3fca24a0194… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-30 (Thu, 30 Aug 2018) Changed paths: M src/api/spec/cassettes/Packages/Viewing_a_package_that/has_a_mime_like_suffix_in_it_s_name.yml M src/api/spec/cassettes/Packages/Viewing_a_package_that/has_derived_packages.yml M src/api/spec/cassettes/Packages/Viewing_a_package_that/was_branched.yml M src/api/spec/cassettes/Packages/adding_an_invalid_file.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_group_to_package_/_project.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_role_to_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Remove_role_from_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Viewing_group_roles.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_role_to_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_user_to_package_/_project.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Remove_role_from_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Remove_user_from_package_/_project.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Viewing_user_roles.yml M src/api/spec/cassettes/Packages/branching_a_package_from_another_users_project/with_AutoCleanup.yml M src/api/spec/cassettes/Packages/branching_a_package_from_another_users_project/without_AutoCleanup.yml M src/api/spec/cassettes/Packages/changing_the_package_s_devel_project.yml M src/api/spec/cassettes/Packages/deleting_a_package.yml M src/api/spec/cassettes/Packages/log/download_logfile_succesfully.yml M src/api/spec/cassettes/Packages/log/live_build_finishes_succesfully.yml M src/api/spec/cassettes/Packages/requesting_package_deletion.yml M src/api/spec/cassettes/Packages/triggering_package_rebuild/via_binaries_view.yml M src/api/spec/cassettes/Packages/triggering_package_rebuild/via_live_build_log.yml M src/api/spec/features/webui/requests_spec.rb Log Message: ----------- Add a feature test for using the request tab This adds a feature test for using the type and state dropdowns, which is implemented via javascript, when searching for a request. javascript. Commit: beccb9c77e732363adfa3fc02a7a32eda93d8813 https://github.com/openSUSE/open-build-service/commit/beccb9c77e732363adfa3… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-30 (Thu, 30 Aug 2018) Changed paths: M src/api/app/controllers/webui/packages/bs_requests_controller.rb Log Message: ----------- Fix rendering bs requests with bootstrap UI (in production) When in production mode we don't have the font-awesome stylesheets and helper methods, eg. `icon()`. Since the rendering of bs requests via ajax was not done with the `switch_to_webui2` switch this was causing a bug which was only visible with using only compiled assets. Fixes #5756 Commit: 1be54c1ebbf01ca78812bf462b3570b2694934ce https://github.com/openSUSE/open-build-service/commit/1be54c1ebbf01ca78812b… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/app/controllers/webui/packages/bs_requests_controller.rb M src/api/spec/cassettes/Packages/Viewing_a_package_that/has_a_mime_like_suffix_in_it_s_name.yml M src/api/spec/cassettes/Packages/Viewing_a_package_that/has_derived_packages.yml M src/api/spec/cassettes/Packages/Viewing_a_package_that/was_branched.yml M src/api/spec/cassettes/Packages/adding_an_invalid_file.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_group_to_package_/_project.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Add_role_to_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Remove_role_from_group.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/group_roles/Viewing_group_roles.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_role_to_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Add_user_to_package_/_project.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Remove_role_from_user.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Remove_user_from_package_/_project.yml M src/api/spec/cassettes/Packages/behaves_like_user_tab/user_roles/Viewing_user_roles.yml M src/api/spec/cassettes/Packages/branching_a_package_from_another_users_project/with_AutoCleanup.yml M src/api/spec/cassettes/Packages/branching_a_package_from_another_users_project/without_AutoCleanup.yml M src/api/spec/cassettes/Packages/changing_the_package_s_devel_project.yml M src/api/spec/cassettes/Packages/deleting_a_package.yml M src/api/spec/cassettes/Packages/log/download_logfile_succesfully.yml M src/api/spec/cassettes/Packages/log/live_build_finishes_succesfully.yml M src/api/spec/cassettes/Packages/requesting_package_deletion.yml M src/api/spec/cassettes/Packages/triggering_package_rebuild/via_binaries_view.yml M src/api/spec/cassettes/Packages/triggering_package_rebuild/via_live_build_log.yml M src/api/spec/features/webui/requests_spec.rb Log Message: ----------- Merge pull request #5751 from bgeuken/bugfix/include_font_awesome_to_old_webui_css Add a feature test for using the request tab Compare: https://github.com/openSUSE/open-build-service/compare/6b3fa5eeb55e...1be54… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/osc] 4eae5d: Clarify use of osc token
by Marco Strigl 31 Aug '18

31 Aug '18

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 4eae5d9a4505e2f485d01634b2b636edb2dbce86 https://github.com/openSUSE/osc/commit/4eae5d9a4505e2f485d01634b2b636edb2db… Author: Andreas Schwab <schwab(a)linux-m68k.org> Date: 2018-08-12 (Sun, 12 Aug 2018) Changed paths: M osc/commandline.py Log Message: ----------- Clarify use of osc token Clarify the fact that the parameters of osc token -t and osc token -d are of different types. Commit: 48e71b0255fa1b194004bf2ab1560daca9d2a2d1 https://github.com/openSUSE/osc/commit/48e71b0255fa1b194004bf2ab1560daca9d2… Author: Marco Strigl <mstrigl(a)suse.com> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M osc/commandline.py Log Message: ----------- Merge pull request #438 from andreas-schwab/token Clarify use of osc token Compare: https://github.com/openSUSE/osc/compare/f1c31561cbe4...48e71b0255fa **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] c12f15: [Security] Bump rails-html-sanitizer from 1.0.3 to...
by dependabot 31 Aug '18

31 Aug '18

Branch: refs/heads/dependabot/bundler/src/api/2.8/rails-html-sanitizer-1.0.4 Home: https://github.com/openSUSE/open-build-service Commit: c12f1548feb306098864e778e6d57e09c076f193 https://github.com/openSUSE/open-build-service/commit/c12f1548feb306098864e… Author: dependabot[bot] <support(a)dependabot.com> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- [Security] Bump rails-html-sanitizer from 1.0.3 to 1.0.4 in /src/api Bumps [rails-html-sanitizer](https://github.com/rails/rails-html-sanitizer) from 1.0.3 to 1.0.4. **This update includes security fixes.** - [Release notes](https://github.com/rails/rails-html-sanitizer/releases) - [Changelog](https://github.com/rails/rails-html-sanitizer/blob/master/CHANGE… - [Commits](https://github.com/rails/rails-html-sanitizer/compare/v1.0.3...v1.… Signed-off-by: dependabot[bot] <support(a)dependabot.com> **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 9040da: [Security] Bump sprockets from 3.7.1 to 3.7.2 in /...
by dependabot 31 Aug '18

31 Aug '18

Branch: refs/heads/dependabot/bundler/src/api/2.8/sprockets-3.7.2 Home: https://github.com/openSUSE/open-build-service Commit: 9040dacf22c0567551cac15921666a5e5e856a42 https://github.com/openSUSE/open-build-service/commit/9040dacf22c0567551cac… Author: dependabot[bot] <support(a)dependabot.com> Date: 2018-08-31 (Fri, 31 Aug 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- [Security] Bump sprockets from 3.7.1 to 3.7.2 in /src/api Bumps [sprockets](http://getsprockets.org/) from 3.7.1 to 3.7.2. **This update includes security fixes.** Signed-off-by: dependabot[bot] <support(a)dependabot.com> **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0