July 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] b8e333: Replace BsRequest#obsolete? by an :obsolete scope
by Björn Geuken 25 Jul '18

25 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b8e333a2c012d6fc58da6cfabcb5465073cbcd36 https://github.com/openSUSE/open-build-service/commit/b8e333a2c012d6fc58da6… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/app/presenters/obs_factory/staging_project_presenter.rb Log Message: ----------- Replace BsRequest#obsolete? by an :obsolete scope Commit: 4e2fe38761d3991d3301b4c847d177de43004cbb https://github.com/openSUSE/open-build-service/commit/4e2fe38761d3991d3301b… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/spec/controllers/webui/obs_factory/staging_projects_controller_spec.rb Log Message: ----------- Group tests for assigning variables in staging controller tests Given the number of variable assignments we are testing there it makes sense (performance, number of tests running) to group them. This also reduces the number of VCR cassettes needed. Commit: e4f5914eb25daf88bc2b0c067e50789fdff077e5 https://github.com/openSUSE/open-build-service/commit/e4f5914eb25daf88bc2b0… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/with_dashboard_package/with_ignored_requests_file/with_content/1_1_2_1_1_1.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/with_dashboard_package/with_ignored_requests_file/with_content/1_1_2_1_1_2.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/with_dashboard_package/with_ignored_requests_file/with_content/sets_up_the_required_variables.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/with_dashboard_package/with_ignored_requests_file/without_content/1_1_2_1_2_1.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/with_dashboard_package/with_ignored_requests_file/without_content/1_1_2_1_2_2.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/with_dashboard_package/with_ignored_requests_file/without_content/sets_up_the_required_variables.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/without_dashboard_package/1_1_1_1.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/without_dashboard_package/1_1_1_2.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/without_dashboard_package/sets_up_the_required_variables.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/1_2_1_1.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/1_2_1_2.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_non-existent_factory_staging_project/1_2_2_1.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_non-existent_factory_staging_project/1_2_2_2.yml M src/api/spec/controllers/webui/obs_factory/staging_projects_controller_spec.rb Log Message: ----------- Render views in staging projects controller tests Rendering the views allows us to test the full functionality of the staging board. This would have revealed the regression fixed in #5446. Some of the views require data from projects, requests and other objects that rely on the backend, this also means we have to use the global write through and record cassettes. Commit: 29efd914a7d01ffaf0bfb9f232bcd312f796c9ca https://github.com/openSUSE/open-build-service/commit/29efd914a7d01ffaf0bfb… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/spec/controllers/webui/obs_factory/distributions_controller_spec.rb Log Message: ----------- Make distribution controller tests work without network Stubs the requests to download.opensuse.org to avoid test failures when no network is available. Commit: 146f5c126a913375fd9c5fcf64c5a26574719d3c https://github.com/openSUSE/open-build-service/commit/146f5c126a913375fd9c5… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/spec/controllers/webui/obs_factory/distributions_controller_spec.rb Log Message: ----------- Group tests for assigning variables in distribution controller tests Given the number of variable assignments we are testing there it makes sense (performance, number of tests running) to group them. Commit: 40f6d7034378cae9da2d47796a628e88f61a1935 https://github.com/openSUSE/open-build-service/commit/40f6d7034378cae9da2d4… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: A src/api/spec/cassettes/Webui_ObsFactory_DistributionsController/GET_show/1_1_1.yml A src/api/spec/cassettes/Webui_ObsFactory_DistributionsController/GET_show/1_1_2.yml A src/api/spec/cassettes/Webui_ObsFactory_DistributionsController/GET_show/1_1_5.yml A src/api/spec/cassettes/Webui_ObsFactory_DistributionsController/GET_show/calculate_reviews/sets_up_the_required_variables.yml A src/api/spec/cassettes/Webui_ObsFactory_DistributionsController/GET_show/sets_up_the_required_variables.yml A src/api/spec/cassettes/Webui_ObsFactory_DistributionsController/GET_show/with_a_live_project/1_1_6_1.yml M src/api/spec/controllers/webui/obs_factory/distributions_controller_spec.rb Log Message: ----------- Render views in distribution controller tests Rendering the views allows us to test the full functionality of the staging board. The Tumbleweed distribution has two rings, Bootstrap and MinimalX. Enabling the view rendering required to create a MinimalX project to avoid a Nil error when the RINGs are shown in the view. The fake OpenqaJob was causing an error as well. Instead we don't return any OpenqaJobs for now. ``` ActionView::Template::Error: undefined method `result_or_state' for :fake:Symbol # ./app/views/webui/obs_factory/distributions/show.html.haml:91:in `each' ``` Some of the views require data from projects, requests and other objects that rely on the backend, this also means we have to use the global write through and record cassettes. Commit: 792962c302dc82e5d002952d08046e155e6b1e8f https://github.com/openSUSE/open-build-service/commit/792962c302dc82e5d0029… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/spec/controllers/webui/obs_factory/staging_projects_controller_spec.rb Log Message: ----------- Extend staging projects controller test This extend the tests for show action to also cover projects with obsolete requests. This will also cover the regression fixed in #5448. Commit: 344ab1cd5ba914f416ed4445009a70c44d78fcc1 https://github.com/openSUSE/open-build-service/commit/344ab1cd5ba914f416ed4… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/app/views/webui/obs_factory/requests/_request.html.erb Log Message: ----------- Fix rendering requests partial on staging board The request_show_url helper requires a request number as parameter. Otherwise it fails with an ActionView::Template::Error error: "undefined method `empty?' for 1:Integer" This broke with ccaaef52ec15892fc26914030a62462d632f9800 Commit: 512f47d46a8fc0e5b49c5e44ba80e09cde4a95c0 https://github.com/openSUSE/open-build-service/commit/512f47d46a8fc0e5b49c5… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/app/presenters/obs_factory/staging_project_presenter.rb A src/api/spec/cassettes/Webui_ObsFactory_DistributionsController/GET_show/1_1_1.yml A src/api/spec/cassettes/Webui_ObsFactory_DistributionsController/GET_show/1_1_2.yml A src/api/spec/cassettes/Webui_ObsFactory_DistributionsController/GET_show/1_1_5.yml A src/api/spec/cassettes/Webui_ObsFactory_DistributionsController/GET_show/calculate_reviews/sets_up_the_required_variables.yml A src/api/spec/cassettes/Webui_ObsFactory_DistributionsController/GET_show/sets_up_the_required_variables.yml A src/api/spec/cassettes/Webui_ObsFactory_DistributionsController/GET_show/with_a_live_project/1_1_6_1.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/with_dashboard_package/with_ignored_requests_file/with_content/1_1_2_1_1_1.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/with_dashboard_package/with_ignored_requests_file/with_content/1_1_2_1_1_2.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/with_dashboard_package/with_ignored_requests_file/with_content/sets_up_the_required_variables.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/with_dashboard_package/with_ignored_requests_file/without_content/1_1_2_1_2_1.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/with_dashboard_package/with_ignored_requests_file/without_content/1_1_2_1_2_2.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/with_dashboard_package/with_ignored_requests_file/without_content/sets_up_the_required_variables.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/without_dashboard_package/1_1_1_1.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/without_dashboard_package/1_1_1_2.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_index/without_dashboard_package/sets_up_the_required_variables.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/1_2_1_1.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/1_2_1_2.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_non-existent_factory_staging_project/1_2_2_1.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_non-existent_factory_staging_project/1_2_2_2.yml M src/api/spec/controllers/webui/obs_factory/distributions_controller_spec.rb M src/api/spec/controllers/webui/obs_factory/staging_projects_controller_spec.rb Log Message: ----------- Merge pull request #5458 from bgeuken/fix_obs_factory_tests Refactor and extend obs factory tests Compare: https://github.com/openSUSE/open-build-service/compare/1c83d446ddd9...512f4… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 8a0b3c: Fix rendering requests partial on staging board
by Björn Geuken 25 Jul '18

25 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8a0b3c5c08b98fda75c8549a4c992534b155d6d1 https://github.com/openSUSE/open-build-service/commit/8a0b3c5c08b98fda75c85… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/app/views/webui/obs_factory/requests/_request.html.erb Log Message: ----------- Fix rendering requests partial on staging board The request_show_url helper requires a request number as parameter. Otherwise it fails with an ActionView::Template::Error error: "undefined method `empty?' for 1:Integer" This broke with ccaaef52ec15892fc26914030a62462d632f9800 Commit: 1c83d446ddd975f8b52d23e7107cc3fe17cc0f97 https://github.com/openSUSE/open-build-service/commit/1c83d446ddd975f8b52d2… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/app/views/webui/obs_factory/requests/_request.html.erb Log Message: ----------- Merge pull request #5477 from bgeuken/bugfix/rendering_requests_in_staging_board Fix rendering requests partial on staging board Compare: https://github.com/openSUSE/open-build-service/compare/5d302a0992ff...1c83d… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 25 Jul '18

25 Jul '18

Branch: refs/heads/depfu/update/srcapi/bootstrap-4.1.2 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] ccaaef: Remove main_app - obs_factory is no longer an engi...
by David Kang 25 Jul '18

25 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ccaaef52ec15892fc26914030a62462d632f9800 https://github.com/openSUSE/open-build-service/commit/ccaaef52ec15892fc2691… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/app/views/webui/obs_factory/distributions/show.html.haml M src/api/app/views/webui/obs_factory/requests/_request.html.erb M src/api/app/views/webui/obs_factory/staging_projects/_buildinfo.html.erb M src/api/app/views/webui/obs_factory/staging_projects/_infos.html.haml M src/api/app/views/webui/obs_factory/staging_projects/_legend.html.haml M src/api/app/views/webui/obs_factory/staging_projects/_overall_state.html.haml M src/api/app/views/webui/obs_factory/staging_projects/_problems.html.erb M src/api/app/views/webui/obs_factory/staging_projects/_request.html.haml M src/api/app/views/webui/obs_factory/staging_projects/show.html.erb Log Message: ----------- Remove main_app - obs_factory is no longer an engine Commit: 9646b27d2e71eb0a30a214d499ecbc3571dfa0cc https://github.com/openSUSE/open-build-service/commit/9646b27d2e71eb0a30a21… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/app/controllers/webui/obs_factory/distributions_controller.rb M src/api/app/controllers/webui/obs_factory/staging_projects_controller.rb Log Message: ----------- Remove main_app from controllers too Commit: 5d302a0992ff6831d9b315d405f682b4ef4a4aa1 https://github.com/openSUSE/open-build-service/commit/5d302a0992ff6831d9b31… Author: David Kang <dkang(a)suse.com> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/app/controllers/webui/obs_factory/distributions_controller.rb M src/api/app/controllers/webui/obs_factory/staging_projects_controller.rb M src/api/app/views/webui/obs_factory/distributions/show.html.haml M src/api/app/views/webui/obs_factory/requests/_request.html.erb M src/api/app/views/webui/obs_factory/staging_projects/_buildinfo.html.erb M src/api/app/views/webui/obs_factory/staging_projects/_infos.html.haml M src/api/app/views/webui/obs_factory/staging_projects/_legend.html.haml M src/api/app/views/webui/obs_factory/staging_projects/_overall_state.html.haml M src/api/app/views/webui/obs_factory/staging_projects/_problems.html.erb M src/api/app/views/webui/obs_factory/staging_projects/_request.html.haml M src/api/app/views/webui/obs_factory/staging_projects/show.html.erb Log Message: ----------- Merge pull request #5469 from coolo/remove_main_app Remove main_app - obs_factory is no longer an engine Compare: https://github.com/openSUSE/open-build-service/compare/07313365a919...5d302… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 3ffd12: Extend the puma silencing to circleci
by Stephan Kulow 25 Jul '18

25 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3ffd123020c05a273f82fed8de0e248e7d698e12 https://github.com/openSUSE/open-build-service/commit/3ffd123020c05a273f82f… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/spec/support/capybara.rb Log Message: ----------- Extend the puma silencing to circleci I only tested locally, but without wanting to I put the silence code in the if section only running against selenium container Commit: 07313365a91942b014a4d119242ad9c03013bd5b https://github.com/openSUSE/open-build-service/commit/07313365a91942b014a4d… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-07-25 (Wed, 25 Jul 2018) Changed paths: M src/api/spec/support/capybara.rb Log Message: ----------- Merge pull request #5468 from coolo/silence_puma_more Extend the puma silencing to circleci Compare: https://github.com/openSUSE/open-build-service/compare/15c268c741b6...07313… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 24 Jul '18

24 Jul '18

Branch: refs/heads/depfu/update/srcapi/capybara-3.4.1 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 15c268: [dist] fix osc checks for upload docker images
by Frank Schreiner 24 Jul '18

24 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 15c268c741b66a8d28b2e5936c7df2a5f550618a https://github.com/openSUSE/open-build-service/commit/15c268c741b66a8d28b2e… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M dist/t/osc/0200-check_docker_registry.ts Log Message: ----------- [dist] fix osc checks for upload docker images **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] ad76b2: Align values of OBSOLETE_STATES with VALID_REQUEST...
by Stephan Kulow 24 Jul '18

24 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ad76b2f6d5a1f320e2a0d3094abd78efe6c6b298 https://github.com/openSUSE/open-build-service/commit/ad76b2f6d5a1f320e2a0d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- Align values of OBSOLETE_STATES with VALID_REQUEST_STATES This makes it easier to compare and combine the two arrays. Commit: 31939319a91b33e339c11ad687fd23c8f1567647 https://github.com/openSUSE/open-build-service/commit/31939319a91b33e339c11… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/models/obs_factory/staging_project.rb Log Message: ----------- Remove unused constant StagingProject::OBSOLETE_STATES Commit: 77bdab9d505bdc0ec8bf70f8d8d25ea037c1dae8 https://github.com/openSUSE/open-build-service/commit/77bdab9d505bdc0ec8bf7… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/models/bs_request.rb M src/api/app/models/obs_factory/staging_project.rb M src/api/app/presenters/obs_factory/staging_project_presenter.rb Log Message: ----------- Replace BsRequest#obsolete? by an :obsolete scope Commit: 08aaedbada1ae29db5bdc0c0139e30ea9ab2995c https://github.com/openSUSE/open-build-service/commit/08aaedbada1ae29db5bdc… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/models/bs_request.rb M src/api/app/models/obs_factory/staging_project.rb M src/api/app/presenters/obs_factory/staging_project_presenter.rb Log Message: ----------- Merge pull request #5462 from bgeuken/tests_for_request_model Tests for request model Compare: https://github.com/openSUSE/open-build-service/compare/67626c59b3c1...08aae… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 67626c: [backend] bs_worker: aarch64 implementor 0x51 qual...
by Ruediger Oertel 24 Jul '18

24 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 67626c59b3c18f67fd082b26db79a9178e54df4f https://github.com/openSUSE/open-build-service/commit/67626c59b3c18f67fd082… Author: Ruediger Oertel <ro(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/backend/bs_worker Log Message: ----------- [backend] bs_worker: aarch64 implementor 0x51 qualcomm does no 32bit either **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] ff8d6b: Remove reference to label from git message and wik...
by Moisés Déniz Alemán 24 Jul '18

24 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ff8d6b46e8c917fd065630859697a8772a688041 https://github.com/openSUSE/open-build-service/commit/ff8d6b46e8c917fd06563… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M .gitmessage M CONTRIBUTING.md Log Message: ----------- Remove reference to label from git message and wiki Describe labels in the wiki as a deprecated feature. Commit: c4463362608fa069e3ebd49aaa0e8eb6706e4084 https://github.com/openSUSE/open-build-service/commit/c4463362608fa069e3ebd… Author: Moisés Déniz Alemán <mdeniz(a)suse.com> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M .gitmessage M CONTRIBUTING.md Log Message: ----------- Merge pull request #5463 from saraycp/wiki_tag_commits Remove reference to label from git message and wiki Compare: https://github.com/openSUSE/open-build-service/compare/699fce53f36a...c4463… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0