July 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 39bce8: [webui] Trim carriage return characters from attri...
by Ana María Martínez Gómez 24 Jul '18

24 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 39bce8abf4186a5bc79ffa65183c7b48307cfbaf https://github.com/openSUSE/open-build-service/commit/39bce8abf4186a5bc79ff… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-19 (Thu, 19 Jul 2018) Changed paths: M src/api/app/models/attrib_value.rb M src/api/spec/features/webui/attributes_spec.rb Log Message: ----------- [webui] Trim carriage return characters from attribute values Using String.encode - fixes #5311 Commit: 699fce53f36a53cc185e2c6f0f61bd80234979d1 https://github.com/openSUSE/open-build-service/commit/699fce53f36a53cc185e2… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/models/attrib_value.rb M src/api/spec/features/webui/attributes_spec.rb Log Message: ----------- Merge pull request #5400 from coolo/fix_5311 [webui] Trim carriage return characters from attribute values Compare: https://github.com/openSUSE/open-build-service/compare/5c5eb3f9320d...699fc… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 5c8f8e: [backend] always send repochanged events
by Michael Schroeder 24 Jul '18

24 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5c8f8e54e051b83c05571ae0258b9d6e7d76d416 https://github.com/openSUSE/open-build-service/commit/5c8f8e54e051b83c05571… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/backend/bs_sched Log Message: ----------- [backend] always send repochanged events We didn't send them before if we abort the repository check with an error. But this lead to DoD repo changes not being send to the interconnect instances. Commit: ca863d8b9add74ec46ee7fc562b00f2214bfc636 https://github.com/openSUSE/open-build-service/commit/ca863d8b9add74ec46ee7… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/backend/bs_notar M src/backend/bs_publish Log Message: ----------- [backend] implement erasing of deleted containers To do this we need to store the list of container repositories in the publish data. Commit: a2691794c28203b12f5e5c9c94280f93a9452dea https://github.com/openSUSE/open-build-service/commit/a2691794c28203b12f5e5… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/backend/bs_publish Log Message: ----------- [backend] make container_repositories a hash of arrays That's easier to read and also easier to handle. Commit: 5c5eb3f9320d2fd1e7d0b2b83274f8807362d92a https://github.com/openSUSE/open-build-service/commit/5c5eb3f9320d2fd1e7d0b… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/backend/bs_notar M src/backend/bs_publish M src/backend/bs_sched Log Message: ----------- Merge pull request #5444 from mlschroe/master implement erasing of deleted containers Compare: https://github.com/openSUSE/open-build-service/compare/08b0d812a814...5c5eb… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] be7846: Add a configuration for codeclimate
by Henne Vogelsang 24 Jul '18

24 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: be7846b101640628a42cb0e6cfd0b4d385d255e9 https://github.com/openSUSE/open-build-service/commit/be7846b101640628a42cb… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: A .codeclimate.yml Log Message: ----------- Add a configuration for codeclimate Disable warnings about webui2 code and other places Commit: 08b0d812a8141fd8cb37b899357bba80fd0c09e9 https://github.com/openSUSE/open-build-service/commit/08b0d812a8141fd8cb37b… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: A .codeclimate.yml Log Message: ----------- Merge pull request #5460 from coolo/add_codelimate_config Add a configuration for codeclimate Compare: https://github.com/openSUSE/open-build-service/compare/9e2cbcb47086...08b0d… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] b509e0: [ci] Improve project factory
by Björn Geuken 24 Jul '18

24 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b509e03c2eee6b39e0b6622de5201ad74fc305b5 https://github.com/openSUSE/open-build-service/commit/b509e03c2eee6b39e0b66… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/spec/factories/project.rb Log Message: ----------- [ci] Improve project factory * Allow adding a linked project to project factories * Use a valid project config xml file to store in the backend Co-authored-by: David Kang <dkang(a)suse.com> Commit: 15be5d2419387a14af2599d37810afd333291d02 https://github.com/openSUSE/open-build-service/commit/15be5d2419387a14af259… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/models/bs_request_action.rb A src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/does_not_set_the_sourceupdate.yml A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set/1_11_1_4_1.yml A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_cleanup/1_11_1_1_1.yml A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_update/1_11_1_2_1.yml A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_set_to_noupdate/1_11_1_3_1.yml A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new_from_xml/1_11_2_1.yml A src/api/spec/cassettes/RequestController/_global_command_cmd_create_/requesting_creation_of_a_source_project_that_has_a_project_link_that_is_not_owned_by_the_requester/prohibits_creation_of_request.yml M src/api/spec/controllers/request_controller_spec.rb M src/api/spec/factories/attribs.rb M src/api/spec/models/bs_request_spec.rb A src/api/spec/support/shared_contexts/a_bsrequest_that_has_a_project_link.rb Log Message: ----------- [frontend] Extend permission check for requests with projects with link When a source project links to another project and the request is using the sourceupdate option, we have to ensure that the requester has permissions to change the linked project. Kudos goes to @marcus-h (Marcus Hüwe) for finding this ugly bug. Co-authored-by: David Kang <dkang(a)suse.com> Commit: 9aedb33c873f296ab7d3c04640f9e94973beb108 https://github.com/openSUSE/open-build-service/commit/9aedb33c873f296ab7d3c… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/spec/controllers/request_controller_spec.rb Log Message: ----------- [ci] Make it more explicit that we test the request diff action Co-authored-by: David Kang <dkang(a)suse.com> Commit: c43e09d830dc7b7425050ccb0948e84757ab55b5 https://github.com/openSUSE/open-build-service/commit/c43e09d830dc7b7425050… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/spec/controllers/request_controller_spec.rb Log Message: ----------- [ci] Add controller test for creating requests via API Add test case for bsc#1098934. Co-authored-by: David Kang <dkang(a)suse.com> Commit: 26d2bee94898754c97f9e753a618177c680e99eb https://github.com/openSUSE/open-build-service/commit/26d2bee94898754c97f9e… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/spec/cassettes/BsRequest/_forward_to/with_options/creates_a_submit_request_action_with_the_correct_target.yml A src/api/spec/cassettes/BsRequest/_forward_to/with_options/does_not_copy_the_sourceupdate_attribute.yml M src/api/spec/models/bs_request_spec.rb Log Message: ----------- [frontend] Ignore sourceupdate attrbibute for request forwarding Forwarded requests are made from projects that just have been updated. It doesn't make sense to update or clean them up once the forwarded request got updated. Commit: de2ca2880a3daf9dc6ac21329194c3ef2515a817 https://github.com/openSUSE/open-build-service/commit/de2ca2880a3daf9dc6ac2… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/models/bs_request_action_submit.rb Log Message: ----------- [frontend] Recheck permissions in the InitializeDevelPackage attribute codepath This is needed because the target package could have been deleted after the previous check_action_permission! call. Commit: f57b660f49f830006766a8d4abc3b4af6e178063 https://github.com/openSUSE/open-build-service/commit/f57b660f49f830006766a… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/models/bs_request_action_submit.rb Log Message: ----------- Ignore a project link in BsRequestAction.check_action_permission! This makes sure that we check the permissions of the correct package. For instance, assume that the project "Staging" is a link project where the link points to the "Base" project. Also, assume that there exists a "Base/foo" package, but there exists no explicit "Staging/foo" package. Moreover, assume we check the permissions for the following "submit" action: <action type="submit"> <source project="Staging" package="foo"/> <target project="an_arbitrary_project" package="foo"/> </action> In this case, the old code checks if request acceptor can modify the "Base/foo" package (since it follows the project link). This is wrong because the "Staging/foo" package would be turned into a branch during accept. The new code checks the correct package because it does not follow the project link and requires that the source package exists in the source project. Requiring the existence of the source package potentially breaks artificial requests (for instance, a request where the "submit" action from above is preceded by a "submit" action that creates a "Staging/foo" package). Note: so far I was unable to exploit the old code - so this is just to avoid a potential future headache. Fixes: commit 990ef7ccc ("[api][webui] Check access to source package") Commit: 9e2cbcb47086281abc1030d227d9b648ba11168b https://github.com/openSUSE/open-build-service/commit/9e2cbcb47086281abc103… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_submit.rb A src/api/spec/cassettes/BsRequest/_forward_to/with_a_project_as_parameter/does_not_set_the_sourceupdate.yml M src/api/spec/cassettes/BsRequest/_forward_to/with_options/creates_a_submit_request_action_with_the_correct_target.yml A src/api/spec/cassettes/BsRequest/_forward_to/with_options/does_not_copy_the_sourceupdate_attribute.yml A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set/1_11_1_4_1.yml A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_cleanup/1_11_1_1_1.yml A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_not_set_to_update/1_11_1_2_1.yml A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new/when_sourceupdate_is_set_to_noupdate/1_11_1_3_1.yml A src/api/spec/cassettes/BsRequest/creating_a_BsRequest_that_has_a_project_link/via_new_from_xml/1_11_2_1.yml A src/api/spec/cassettes/RequestController/_global_command_cmd_create_/requesting_creation_of_a_source_project_that_has_a_project_link_that_is_not_owned_by_the_requester/prohibits_creation_of_request.yml M src/api/spec/controllers/request_controller_spec.rb M src/api/spec/factories/attribs.rb M src/api/spec/factories/project.rb M src/api/spec/models/bs_request_spec.rb A src/api/spec/support/shared_contexts/a_bsrequest_that_has_a_project_link.rb Log Message: ----------- Merge pull request #5456 from bgeuken/fix_link Fix link Compare: https://github.com/openSUSE/open-build-service/compare/9e02d3551915...9e2cb… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] ba8216: [frontend] Add User#can_modify? method
by Björn Geuken 24 Jul '18

24 Jul '18

Branch: refs/heads/2.9 Home: https://github.com/openSUSE/open-build-service Commit: ba8216e05828f093249e15be422b20e27cb4c0ea https://github.com/openSUSE/open-build-service/commit/ba8216e05828f093249e1… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-04 (Wed, 04 Jul 2018) Changed paths: M src/api/app/models/user.rb Log Message: ----------- [frontend] Add User#can_modify? method We have a couple of code pathes in OBS that operate on both, projects and packages. So we end up many times having to check whether we have to run a permission check on an a project or package. This commit adds a method that calls can_modify_package? or can_modify_project? depending on the given object class. Commit: 6cab8ae038e035c66bc794099a35045fbca30543 https://github.com/openSUSE/open-build-service/commit/6cab8ae038e035c66bc79… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-04 (Wed, 04 Jul 2018) Changed paths: M src/api/spec/factories/project.rb Log Message: ----------- [ci] Improve project factory * Allow adding a linked project to project factories * Use a valid project config xml file to store in the backend Co-authored-by: David Kang <dkang(a)suse.com> Commit: 0db39769ea40e8b7812448f0e2c21acf85a1317e https://github.com/openSUSE/open-build-service/commit/0db39769ea40e8b781244… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-23 (Mon, 23 Jul 2018) Changed paths: M src/api/app/models/bs_request_action.rb A src/api/spec/cassettes/RequestController/_global_command_cmd_create_/requesting_creation_of_a_source_project_that_has_a_project_link_that_is_not_owned_by_the_requester/prohibits_creation_of_request.yml A src/api/spec/cassettes/Requests/decline/does_not_set_the_sourceupdate.yml M src/api/spec/factories/attribs.rb A src/api/spec/support/shared_contexts/a_bsrequest_that_has_a_project_link.rb Log Message: ----------- [frontend] Extend permission check for requests with projects with link When a source project links to another project and the request is using the sourceupdate option, we have to ensure that the requester has permissions to change the linked project. Kudos goes to @marcus-h (Marcus Hüwe) for finding this ugly bug. Co-authored-by: David Kang <dkang(a)suse.com> Commit: ba46422c863ad071aefddd5b44a23f78cce5dc31 https://github.com/openSUSE/open-build-service/commit/ba46422c863ad071aefdd… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-23 (Mon, 23 Jul 2018) Changed paths: A src/api/spec/controllers/request_controller_spec.rb Log Message: ----------- [ci] Add controller test for creating requests via API Add test case for bsc#1098934. Co-authored-by: David Kang <dkang(a)suse.com> Commit: 40d7c60b8c291bee867264732da7ce8e56ea30d9 https://github.com/openSUSE/open-build-service/commit/40d7c60b8c291bee86726… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-23 (Mon, 23 Jul 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [frontend] Ignore sourceupdate attrbibute for request forwarding Forwarded requests are made from projects that just have been updated. It doesn't make sense to update or clean them up once the forwarded request got updated. Commit: 9c5f51af1e3a923dab459f271581cd7d58144d84 https://github.com/openSUSE/open-build-service/commit/9c5f51af1e3a923dab459… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2018-07-23 (Mon, 23 Jul 2018) Changed paths: M src/api/app/models/bs_request_action_submit.rb Log Message: ----------- [frontend] Recheck permissions in the InitializeDevelPackage attribute codepath This is needed because the target package could have been deleted after the previous check_action_permission! call. Commit: 0e9ce6709e5745bb26f824d16c029c52d52e2937 https://github.com/openSUSE/open-build-service/commit/0e9ce6709e5745bb26f82… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: A ReleaseNotes-2.9.4 Log Message: ----------- Add release notes for 2.9.4 Commit: bc051893bae8f8cb331fee5d91f4b16eb99d7bcb https://github.com/openSUSE/open-build-service/commit/bc051893bae8f8cb331fe… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- [frontend] Update sprockets to version 3.7.2 This is needed to address CVE-2018-3760. https://groups.google.com/forum/#!topic/rubyonrails-security/ft_J--l55fM Commit: ba1b692293bdef5afd46b9904052ee5072bc85c5 https://github.com/openSUSE/open-build-service/commit/ba1b692293bdef5afd46b… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: A ReleaseNotes-2.9.4 M src/api/Gemfile.lock M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/user.rb A src/api/spec/cassettes/RequestController/_global_command_cmd_create_/requesting_creation_of_a_source_project_that_has_a_project_link_that_is_not_owned_by_the_requester/prohibits_creation_of_request.yml A src/api/spec/cassettes/Requests/decline/does_not_set_the_sourceupdate.yml A src/api/spec/controllers/request_controller_spec.rb M src/api/spec/factories/attribs.rb M src/api/spec/factories/project.rb A src/api/spec/support/shared_contexts/a_bsrequest_that_has_a_project_link.rb Log Message: ----------- Merge pull request #5457 from bgeuken/fix_link_2_9 Fix link 2 9 Compare: https://github.com/openSUSE/open-build-service/compare/10f6b8fda18d...ba1b6… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] ab6cbe: [webui] Fix wrong openqa_iso_prefix for Leap 15
by Stephan Kulow 24 Jul '18

24 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ab6cbe08e0cfc7ce8fc58f85af083f52b7723238 https://github.com/openSUSE/open-build-service/commit/ab6cbe08e0cfc7ce8fc58… Author: Max Lin <mlin(a)suse.com> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/models/obs_factory/distribution_strategy_opensuse_leap15.rb M src/api/spec/models/obs_factory/distribution_strategy_opensuse_leap15_spec.rb Log Message: ----------- [webui] Fix wrong openqa_iso_prefix for Leap 15 Leap's iso has a prefix openSUSE-Leap:15.1-Staging on openQA, da8aa358 changed it to the wrong path, therefore Leap Staging Dashboard unable to find relevant openQA jobs result. Commit: 9e02d355191584811130f2cea9162fb1efcf1b0e https://github.com/openSUSE/open-build-service/commit/9e02d355191584811130f… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/models/obs_factory/distribution_strategy_opensuse_leap15.rb M src/api/spec/models/obs_factory/distribution_strategy_opensuse_leap15_spec.rb Log Message: ----------- Merge pull request #5459 from nilxam/fix_openqa_iso_prefix [webui] Fix wrong openqa_iso_prefix for Leap 15 Compare: https://github.com/openSUSE/open-build-service/compare/71fc4fbc9e32...9e02d… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] f0c3e3: Style main in bootstrap
by Stephan Kulow 24 Jul '18

24 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f0c3e3eed11e5ffb7261e049d6a70885e4e1b8da https://github.com/openSUSE/open-build-service/commit/f0c3e3eed11e5ffb7261e… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/assets/javascripts/webui2/application.js A src/api/app/assets/javascripts/webui2/plotbusyworkers.js M src/api/app/controllers/webui/main_controller.rb A src/api/app/helpers/webui/status_message_helper.rb A src/api/app/views/layouts/webui2/_logged_in_user_navigation.html.haml M src/api/app/views/layouts/webui2/_personal_navigation.html.haml A src/api/app/views/layouts/webui2/_proxy_auth_navigation.html.haml M src/api/app/views/layouts/webui2/webui.html.haml A src/api/app/views/webui2/status_messages/_card.html.haml A src/api/app/views/webui2/webui/main/_add_status_message_modal.html.haml A src/api/app/views/webui2/webui/main/_admin_proceed-list.html.haml A src/api/app/views/webui2/webui/main/_latest_updates.html.haml A src/api/app/views/webui2/webui/main/_proceed-list.html.haml A src/api/app/views/webui2/webui/main/_sponsors.html.haml A src/api/app/views/webui2/webui/main/_status_messages.html.haml A src/api/app/views/webui2/webui/main/_systemstatus.html.haml A src/api/app/views/webui2/webui/main/_user_proceed-list.html.haml A src/api/app/views/webui2/webui/main/about.html.haml A src/api/app/views/webui2/webui/main/index.html.haml Log Message: ----------- Style main in bootstrap Co-authored-by: Stasiek Michalski <hellcp(a)opensuse.org> Commit: d29cf21f184c9b110807467d8d90ca3eded9dc98 https://github.com/openSUSE/open-build-service/commit/d29cf21f184c9b1108074… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/helpers/webui/main_helper.rb Log Message: ----------- Remove duplicate CSS ids Those ids are not used Commit: 925927e361cfbb03e7a3adfb7263d9c64c236270 https://github.com/openSUSE/open-build-service/commit/925927e361cfbb03e7a3a… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/spec/features/webui/image_templates_spec.rb Log Message: ----------- Make ImageTemplate link clicks spec more specific In webui there are two links with the same locator, in webui2 there is more text (icon) in the link. Commit: a459f4855f203078d16ea5fc37d6ac67df593b29 https://github.com/openSUSE/open-build-service/commit/a459f4855f203078d16ea… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/controllers/webui/webui_controller.rb Log Message: ----------- Fix running the spec with BOOTSTRAP=1 Commit: 71fc4fbc9e3246c30c67d519ba1209573f10a3ce https://github.com/openSUSE/open-build-service/commit/71fc4fbc9e3246c30c67d… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-07-24 (Tue, 24 Jul 2018) Changed paths: M src/api/app/assets/javascripts/webui2/application.js A src/api/app/assets/javascripts/webui2/plotbusyworkers.js M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/webui/main_helper.rb A src/api/app/helpers/webui/status_message_helper.rb A src/api/app/views/layouts/webui2/_logged_in_user_navigation.html.haml M src/api/app/views/layouts/webui2/_personal_navigation.html.haml A src/api/app/views/layouts/webui2/_proxy_auth_navigation.html.haml M src/api/app/views/layouts/webui2/webui.html.haml A src/api/app/views/webui2/status_messages/_card.html.haml A src/api/app/views/webui2/webui/main/_add_status_message_modal.html.haml A src/api/app/views/webui2/webui/main/_admin_proceed-list.html.haml A src/api/app/views/webui2/webui/main/_latest_updates.html.haml A src/api/app/views/webui2/webui/main/_proceed-list.html.haml A src/api/app/views/webui2/webui/main/_sponsors.html.haml A src/api/app/views/webui2/webui/main/_status_messages.html.haml A src/api/app/views/webui2/webui/main/_systemstatus.html.haml A src/api/app/views/webui2/webui/main/_user_proceed-list.html.haml A src/api/app/views/webui2/webui/main/about.html.haml A src/api/app/views/webui2/webui/main/index.html.haml M src/api/spec/features/webui/image_templates_spec.rb Log Message: ----------- Merge pull request #5415 from hennevogel/feature/main_in_bootstrap Style main in bootstrap Compare: https://github.com/openSUSE/open-build-service/compare/2bd0dba1a8f1...71fc4… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 52b180: Move request creation from request controller to m...
by Henne Vogelsang 23 Jul '18

23 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 52b180d9abd592ad375187704ab2002fb09bdb42 https://github.com/openSUSE/open-build-service/commit/52b180d9abd592ad37518… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-22 (Sun, 22 Jul 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/spec/models/bs_request_spec.rb Log Message: ----------- Move request creation from request controller to model This removes quite some duplication in the controller. The conditional setting of optional request action attributes could be removed because the default values of these attributes are null. So setting source_package to params[:devel_package], where params[:devel_package] is nil, won't alter the created object. The explicit setting of request state 'new' got dropped, because there is a callback that sets any newly created request to state new. Commit: a25c7cfb28780845a814e7f606990b6efdf79360 https://github.com/openSUSE/open-build-service/commit/a25c7cfb28780845a814e… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-22 (Sun, 22 Jul 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- Rename variable in request controller: req -> request Commit: 2bd0dba1a8f102bb677f8ffbb20e27199076b677 https://github.com/openSUSE/open-build-service/commit/2bd0dba1a8f102bb677f8… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-23 (Mon, 23 Jul 2018) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/bs_request.rb M src/api/spec/models/bs_request_spec.rb Log Message: ----------- Merge pull request #5423 from bgeuken/update_request_creation_in_webui_controller Update request creation in webui controller Compare: https://github.com/openSUSE/open-build-service/compare/50299519e5b3...2bd0d… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] e3be32: Fix backend/file_spec with global_write_through
by Henne Vogelsang 23 Jul '18

23 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e3be323914c89a21f7de832b90c7efc10ad7e3d4 https://github.com/openSUSE/open-build-service/commit/e3be323914c89a21f7de8… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-07-23 (Mon, 23 Jul 2018) Changed paths: M src/api/spec/models/backend/file_spec.rb Log Message: ----------- Fix backend/file_spec with global_write_through Creating the package and file needs put, so instanciate it in the backend before breaking/stubing put Commit: 50299519e5b340359ab5c582e5bbcf989210d10f https://github.com/openSUSE/open-build-service/commit/50299519e5b340359ab5c… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-07-23 (Mon, 23 Jul 2018) Changed paths: M src/api/spec/models/backend/file_spec.rb Log Message: ----------- Merge pull request #5447 from coolo/fix_backend_file_sec Fix backend/file_spec with global_write_through Compare: https://github.com/openSUSE/open-build-service/compare/522a55f1bc1b...50299… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 3d1360: Use BsRequest instead of Request
by Björn Geuken 23 Jul '18

23 Jul '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3d13608ff1954243263d79f35bdcf7e4d11ec261 https://github.com/openSUSE/open-build-service/commit/3d13608ff1954243263d7… Author: David Kang <dkang(a)suse.com> Date: 2018-07-23 (Mon, 23 Jul 2018) Changed paths: M src/api/app/views/webui/obs_factory/requests/_request.html.erb Log Message: ----------- Use BsRequest instead of Request Recently we integrate `Request` model into `BsRequest`, so now we use `BsRequest` instead of `Request`. Commit: 522a55f1bc1b81fa7ecd2b68ad8b3101a1c58573 https://github.com/openSUSE/open-build-service/commit/522a55f1bc1b81fa7ecd2… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-07-23 (Mon, 23 Jul 2018) Changed paths: M src/api/app/views/webui/obs_factory/requests/_request.html.erb Log Message: ----------- Merge pull request #5448 from DavidKang/bugfix/factory/request Use BsRequest instead of Request Compare: https://github.com/openSUSE/open-build-service/compare/1e6af077b2dc...522a5… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0