June 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 88e748: [frontend] Remove caching in Package.serviceinfo
by Stephan Kulow 29 Jun '18

29 Jun '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 88e748ec95d416eb768f31c7921962d712bc371a https://github.com/openSUSE/open-build-service/commit/88e748ec95d416eb768f3… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-06-29 (Fri, 29 Jun 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/models/package.rb Log Message: ----------- [frontend] Remove caching in Package.serviceinfo The serviceinfo changes in the backend, caching it in the model is as such not wise. The only place it's called outside of service_info is not using the return value - and was removed Commit: a2bc8ddb51c9a08a90c8c455850238a567ed0fdc https://github.com/openSUSE/open-build-service/commit/a2bc8ddb51c9a08a90c8c… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-06-29 (Fri, 29 Jun 2018) Changed paths: A src/api/spec/cassettes/Package/_service_error/returns_nil_without_errors.yml A src/api/spec/cassettes/Package/_service_error/returns_the_errors.yml R src/api/spec/cassettes/Package/_service_error/with_error/1_6_2_1.yml R src/api/spec/cassettes/Package/_service_error/with_error/1_7_2_1.yml R src/api/spec/cassettes/Package/_service_error/without_error/1_6_1_1.yml M src/api/spec/models/package_spec.rb Log Message: ----------- [ci] Fix the service_error test to poll state The old cassette shows the problem: code: 400 message: revision is empty If you commit a _service and try to fetch the service_error right afterwards, you might not have a serviceinfo beside 'running', so we need to wait a little. Unfortunately we can't use cmd=waitservice for this test as it throws an error for invalid services - which is what we want to test Commit: 0aa7fb9ae59b7923e680539bf5888c546f281d89 https://github.com/openSUSE/open-build-service/commit/0aa7fb9ae59b7923e6805… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-06-29 (Fri, 29 Jun 2018) Changed paths: M src/api/app/models/package.rb A src/api/spec/cassettes/Package/_service_error/returns_nil_on_running.yml M src/api/spec/cassettes/Package/_service_error/returns_nil_without_errors.yml M src/api/spec/cassettes/Package/_service_error/returns_the_errors.yml M src/api/spec/models/package_spec.rb Log Message: ----------- [ci] Stub the backend calls for service_error This way we don't need to start a race with the backend to test the model code. Commit: 10a91ac5a49b0125bc747ce9e85e9caf40e3510a https://github.com/openSUSE/open-build-service/commit/10a91ac5a49b0125bc747… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-06-29 (Fri, 29 Jun 2018) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/models/package.rb A src/api/spec/cassettes/Package/_service_error/returns_nil_on_running.yml A src/api/spec/cassettes/Package/_service_error/returns_nil_without_errors.yml A src/api/spec/cassettes/Package/_service_error/returns_the_errors.yml R src/api/spec/cassettes/Package/_service_error/with_error/1_6_2_1.yml R src/api/spec/cassettes/Package/_service_error/with_error/1_7_2_1.yml R src/api/spec/cassettes/Package/_service_error/without_error/1_6_1_1.yml M src/api/spec/models/package_spec.rb Log Message: ----------- Merge pull request #5259 from coolo/fix_serviceinfo Fix service_error test blinking (without cassettes) Compare: https://github.com/openSUSE/open-build-service/compare/4177f497e025...10a91… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 2f4bb7: [backend] simplify last commit
by Michael Schroeder 29 Jun '18

29 Jun '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2f4bb779895fde59b0a39f552a4ed549a3df344b https://github.com/openSUSE/open-build-service/commit/2f4bb779895fde59b0a39… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-06-28 (Thu, 28 Jun 2018) Changed paths: M src/backend/BSSched/Checker.pm Log Message: ----------- [backend] simplify last commit Commit: 627bbb56ef12154a1a2d9a4afeb9bbd740030990 https://github.com/openSUSE/open-build-service/commit/627bbb56ef12154a1a2d9… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-06-28 (Thu, 28 Jun 2018) Changed paths: M src/backend/BSASN1.pm Log Message: ----------- [backend] fix encoding of small negative integers Commit: d79cb899ea3aae5f6de4db595172bbdf7717fac7 https://github.com/openSUSE/open-build-service/commit/d79cb899ea3aae5f6de4d… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-06-28 (Thu, 28 Jun 2018) Changed paths: M src/backend/bs_worker Log Message: ----------- [backend] drop weird "kiwi product with local delivery" build mode Unbreaks non-local kiwi product building as side effect. Commit: 4177f497e025ea08b9d7dab49d45cb7227fd5c29 https://github.com/openSUSE/open-build-service/commit/4177f497e025ea08b9d7d… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-06-29 (Fri, 29 Jun 2018) Changed paths: M src/backend/BSASN1.pm M src/backend/BSSched/Checker.pm M src/backend/bs_worker Log Message: ----------- Merge pull request #5250 from mlschroe/master Drop linklocal delivery support in worker Compare: https://github.com/openSUSE/open-build-service/compare/d117057a14ca...4177f… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 29 Jun '18

29 Jun '18

Branch: refs/heads/depfu/update/srcapi/bunny-2.11.0 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] a93d1f: Update bunny to version 2.11.0
by Ana María Martínez Gómez 29 Jun '18

29 Jun '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a93d1f2cb271ac8cc04020b026360ceef3fe2f7f https://github.com/openSUSE/open-build-service/commit/a93d1f2cb271ac8cc0402… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-06-28 (Thu, 28 Jun 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update bunny to version 2.11.0 Commit: d117057a14cab16d7ee73e27c36bfc535647b174 https://github.com/openSUSE/open-build-service/commit/d117057a14cab16d7ee73… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-06-29 (Fri, 29 Jun 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5185 from openSUSE/depfu/update/srcapi/bunny-2.11.0 Update bunny: 2.10.0 → 2.11.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/b2581f2c83dc...d1170… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/obs-build] 21d9a3: docker: use a correct prefixed label for disturl
by GitHub 29 Jun '18

29 Jun '18

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 21d9a388f7fe0445410a2f45cc99d2859621033d https://github.com/openSUSE/obs-build/commit/21d9a388f7fe0445410a2f45cc99d2… Author: Adrian Schröter <adrian(a)suse.de> Date: 2018-06-29 (Fri, 29 Jun 2018) Changed paths: M build-recipe-docker Log Message: ----------- docker: use a correct prefixed label for disturl **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/obs-build] 690336: docker: use a correct prefixed label for disturl
by GitHub 29 Jun '18

29 Jun '18

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 690336611a3f5ce3ea49153fca930002ddfe5527 https://github.com/openSUSE/obs-build/commit/690336611a3f5ce3ea49153fca9300… Author: Adrian Schröter <adrian(a)suse.de> Date: 2018-06-29 (Fri, 29 Jun 2018) Changed paths: M build-recipe-docker Log Message: ----------- docker: use a correct prefixed label for disturl **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 28 Jun '18

28 Jun '18

Branch: refs/heads/depfu/update/srcapi/airbrake-ruby-2.11.0 Home: https://github.com/openSUSE/open-build-service **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 2d2c2e: Update airbrake-ruby to version 2.11.0
by David Kang 28 Jun '18

28 Jun '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2d2c2e4231154bae851797c0f16eb72e34baa1cb https://github.com/openSUSE/open-build-service/commit/2d2c2e4231154bae85179… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-06-27 (Wed, 27 Jun 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update airbrake-ruby to version 2.11.0 Commit: b2581f2c83dc594964de85594dc12e1cb62795e4 https://github.com/openSUSE/open-build-service/commit/b2581f2c83dc594964de8… Author: David Kang <dkang(a)suse.com> Date: 2018-06-28 (Thu, 28 Jun 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #5238 from openSUSE/depfu/update/srcapi/airbrake-ruby-2.11.0 Update airbrake-ruby: 2.10.0 → 2.11.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/3f771ed4d28a...b2581… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 94828d: [frontend] Update rspec readme
by Björn Geuken 28 Jun '18

28 Jun '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 94828d1e47f2bc14bafcd3bf9e8df8373a4036de https://github.com/openSUSE/open-build-service/commit/94828d1e47f2bc14bafcd… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-06-27 (Wed, 27 Jun 2018) Changed paths: M src/api/spec/README.md Log Message: ----------- [frontend] Update rspec readme to match new setup to fix #5176. [ci skip] Commit: 3f771ed4d28a058c0e9be54b74b6afd2f2115bc2 https://github.com/openSUSE/open-build-service/commit/3f771ed4d28a058c0e9be… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-06-28 (Thu, 28 Jun 2018) Changed paths: M src/api/spec/README.md Log Message: ----------- Merge pull request #5178 from ChrisBr/spec/readme Update rspec readme Compare: https://github.com/openSUSE/open-build-service/compare/84517f8a73ed...3f771… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] b12cc1: [frontend] Add User#can_modify? method
by Björn Geuken 28 Jun '18

28 Jun '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b12cc13cfaa23c0a017b4da1c0d2ca22916425c9 https://github.com/openSUSE/open-build-service/commit/b12cc13cfaa23c0a017b4… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-06-28 (Thu, 28 Jun 2018) Changed paths: M src/api/app/models/user.rb Log Message: ----------- [frontend] Add User#can_modify? method We have a couple of code pathes in OBS that operate on both, projects and packages. So we end up many times having to check whether we have to run a permission check on an a project or package. This commit adds a method that calls can_modify_package? or can_modify_project? depending on the given object class. Commit: 9b5798351278a7a850a14b50b6aa14419e73b35f https://github.com/openSUSE/open-build-service/commit/9b5798351278a7a850a14… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-06-28 (Thu, 28 Jun 2018) Changed paths: M src/api/app/controllers/source_controller.rb M src/api/app/controllers/source_project_config_controller.rb M src/api/app/controllers/source_project_controller.rb M src/api/app/controllers/source_project_meta_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/bs_request_permission_check.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/service.rb M src/api/app/policies/kiwi/image_policy.rb M src/api/app/policies/package_policy.rb M src/api/app/policies/project_policy.rb M src/api/app/views/shared/_involved_users.html.haml M src/api/app/views/webui/package/_files_view.html.erb M src/api/app/views/webui/package/binaries.html.erb M src/api/app/views/webui/package/meta.html.erb M src/api/app/views/webui/package/show.html.erb M src/api/app/views/webui/patchinfo/show.html.haml M src/api/app/views/webui/project/_packages_table.html.erb M src/api/app/views/webui/project/maintained_projects.html.erb M src/api/app/views/webui/project/meta.html.erb M src/api/app/views/webui/project/prjconf.html.erb M src/api/app/views/webui/project/show.html.erb M src/api/app/views/webui/project/status.html.erb M src/api/app/views/webui/project/subprojects.html.haml M src/api/app/views/webui/repositories/_repository_entry.html.haml M src/api/app/views/webui/repositories/index.html.haml M src/api/lib/opensuse/permission.rb Log Message: ----------- [frontend] Replace can_modify_*? methods with User#can_modify? Replaces can_modify_package? and can_modify_project? methods with User#can_modify?. Commit: 97c48e23b02bc05099b6cca7ac4d31dfb89b9a08 https://github.com/openSUSE/open-build-service/commit/97c48e23b02bc05099b6c… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-06-28 (Thu, 28 Jun 2018) Changed paths: M src/api/app/views/shared/_involved_users.html.haml Log Message: ----------- [frontend] Refactor involved_users partial by using can_modify? helper Commit: 84517f8a73ed0648e4403122de268f7d4301dc60 https://github.com/openSUSE/open-build-service/commit/84517f8a73ed0648e4403… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-06-28 (Thu, 28 Jun 2018) Changed paths: M src/api/app/controllers/source_controller.rb M src/api/app/controllers/source_project_config_controller.rb M src/api/app/controllers/source_project_controller.rb M src/api/app/controllers/source_project_meta_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/models/branch_package.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/bs_request_permission_check.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/service.rb M src/api/app/models/user.rb M src/api/app/policies/kiwi/image_policy.rb M src/api/app/policies/package_policy.rb M src/api/app/policies/project_policy.rb M src/api/app/views/shared/_involved_users.html.haml M src/api/app/views/webui/package/_files_view.html.erb M src/api/app/views/webui/package/binaries.html.erb M src/api/app/views/webui/package/meta.html.erb M src/api/app/views/webui/package/show.html.erb M src/api/app/views/webui/patchinfo/show.html.haml M src/api/app/views/webui/project/_packages_table.html.erb M src/api/app/views/webui/project/maintained_projects.html.erb M src/api/app/views/webui/project/meta.html.erb M src/api/app/views/webui/project/prjconf.html.erb M src/api/app/views/webui/project/show.html.erb M src/api/app/views/webui/project/status.html.erb M src/api/app/views/webui/project/subprojects.html.haml M src/api/app/views/webui/repositories/_repository_entry.html.haml M src/api/app/views/webui/repositories/index.html.haml M src/api/lib/opensuse/permission.rb Log Message: ----------- Merge pull request #5247 from bgeuken/add_wrapper_for_can_modify_methods Add wrapper for can modify methods Compare: https://github.com/openSUSE/open-build-service/compare/96850a7fde04...84517… **NOTE:** This service been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0