April 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] dc51b7: [webui] Remove unneeded javascript tab lines
by Christian Bruckmayer 10 Apr '18

10 Apr '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: dc51b7be7f50e0bed46f967593b806c1c979ab30 https://github.com/openSUSE/open-build-service/commit/dc51b7be7f50e0bed46f9… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/views/shared/_buildresult_box.html.haml Log Message: ----------- [webui] Remove unneeded javascript tab lines This is already done in: src/api/app/assets/javascripts/webui/application/groups.js:5 Commit: 2ceff9eedde9d87199c45457a2d3b8887b7fe2a5 https://github.com/openSUSE/open-build-service/commit/2ceff9eedde9d87199c45… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/assets/javascripts/webui/application/groups.js Log Message: ----------- [webui] Fix highlighting of headers in nested tabs They were collapsing. This partially solves: https://github.com/openSUSE/open-build-service/issues/4719 Commit: 698fe010ca7add63189a8599b587a5beff3f400c https://github.com/openSUSE/open-build-service/commit/698fe010ca7add63189a8… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/assets/javascripts/webui/application.js.erb R src/api/app/assets/javascripts/webui/application/groups.js A src/api/app/assets/javascripts/webui/application/tabs.js M src/api/app/views/webui/groups/show.html.haml Log Message: ----------- [webui] Make tabs javascript generic - Rename `content-tab` to make clear what it is about. - Call the javascript file tabs - Put the specific groups code (1 line) into application.js Commit: 8047689a268c187046c981f2ad398335eab7151c https://github.com/openSUSE/open-build-service/commit/8047689a268c187046c98… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/assets/javascripts/webui/application/tabs.js Log Message: ----------- [webui] Add HTML tags structure for tabs To help adding new code and understand current Javascript. Commit: bd7b6a55660c94878d2351a5b93d0d1324f68461 https://github.com/openSUSE/open-build-service/commit/bd7b6a55660c94878d235… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/views/shared/_buildresult_box.html.haml Log Message: ----------- [webui] Adapt request show to use generic tabs js Use the generic javascript and css instead of reimplementing it. Commit: 8bf403a32cc81db59197d6099c3e31a210e6d44a https://github.com/openSUSE/open-build-service/commit/8bf403a32cc81db59197d… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/helpers/webui/webui_helper.rb Log Message: ----------- [webui] Mark selected tab in package#show The `tab` helper spect the controller symbol and not the string which includes the webui. Co-authored-by: Christian Bruckmayer <cbruckmayer(a)suse.com> Commit: a9b316a1c1da9df8063660573c40cfcbe965a9cf https://github.com/openSUSE/open-build-service/commit/a9b316a1c1da9df806366… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/assets/javascripts/webui/application.js.erb R src/api/app/assets/javascripts/webui/application/groups.js A src/api/app/assets/javascripts/webui/application/tabs.js M src/api/app/helpers/webui/webui_helper.rb M src/api/app/views/shared/_buildresult_box.html.haml M src/api/app/views/webui/groups/show.html.haml Log Message: ----------- Merge pull request #4825 from Ana06/javascript [webui] Fix highlighting of headers in nested tabs Compare: https://github.com/openSUSE/open-build-service/compare/a009548a86e8...a9b31…

1 0

[obs-commits] [openSUSE/open-build-service] 462938: [webui] Fix 'undefined method can_modify_project? ...
by Henne Vogelsang 10 Apr '18

10 Apr '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 462938c85b146eb211f7ecfe42e3d0b345a6ea02 https://github.com/openSUSE/open-build-service/commit/462938c85b146eb211f7e… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/jobs/bs_request_action_webui_infos_job.rb M src/api/app/models/bs_request_action/differ/source_package_finder.rb Log Message: ----------- [webui] Fix 'undefined method can_modify_project? for nil:NilClass' in BsRequestActionWebuiInfosJob The issue was in the DelayedJob is no User.current set which causes that BsRequestAction.source_access_check! in SourcePackageFinder to throw a 'undefined method can_modify_project? for nil:NilClass' for packages coming from a remote or linked project as they can not be found with Package#find_by_name_and_project. This Job is only to warm up the caches in the backend by sending the diff requests and immediately discard it. Therefore we can skip the access check anyway as the result won't be displayed somewhere. Fix #4404 Commit: ac2b5ced59b0e9dd011600fd938bfcb29284e90b https://github.com/openSUSE/open-build-service/commit/ac2b5ced59b0e9dd01160… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/jobs/bs_request_action_webui_infos_job.rb A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/for_a_superseded_request/1_1_3_1.yml A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/for_a_superseded_request/1_1_4_1.yml A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/for_a_target_package/creates_the_diff.yml A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/with_non_existing_source_package/1_1_3_1.yml A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/with_non_existing_source_package/1_1_3_2.yml A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/with_non_existing_target_project/1_1_2_1.yml A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/with_non_existing_target_project/1_1_2_2.yml M src/api/spec/jobs/bs_request_action_webui_infos_job.rb Log Message: ----------- [webui] Implement cache for superseded requests as we implemented diffs between superseded requests it is necessary to warm up the cache in the backend for these diffs. See #4741. Commit: 8cfd34996d349d2bda5c4661c865f472191462f5 https://github.com/openSUSE/open-build-service/commit/8cfd34996d349d2bda5c4… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/models/bs_request_action/differ/query_builder_for_superseded.rb M src/api/spec/models/bs_request_action/differ/query_builder_for_superseded_spec.rb Log Message: ----------- [webui][ci] Set revision to 0 when there is no revision in query for superseded requests. Otherwise it would return a DiffError because of not existing revision. Commit: a009548a86e8948204ecd35392fe351af5c4013f https://github.com/openSUSE/open-build-service/commit/a009548a86e8948204ecd… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/jobs/bs_request_action_webui_infos_job.rb M src/api/app/models/bs_request_action/differ/query_builder_for_superseded.rb M src/api/app/models/bs_request_action/differ/source_package_finder.rb A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/for_a_superseded_request/1_1_3_1.yml A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/for_a_superseded_request/1_1_4_1.yml A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/for_a_target_package/creates_the_diff.yml A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/with_non_existing_source_package/1_1_3_1.yml A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/with_non_existing_source_package/1_1_3_2.yml A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/with_non_existing_target_project/1_1_2_1.yml A src/api/spec/cassettes/BsRequestActionWebuiInfosJob/_perform/with_non_existing_target_project/1_1_2_2.yml M src/api/spec/jobs/bs_request_action_webui_infos_job.rb M src/api/spec/models/bs_request_action/differ/query_builder_for_superseded_spec.rb Log Message: ----------- Merge pull request #4763 from ChrisBr/feature/cache-superseded-requests Implemented caching of superseded requests in BsRequestActionWebuiInfosJob Compare: https://github.com/openSUSE/open-build-service/compare/49c98d311b99...a0095…

1 0

[obs-commits] [openSUSE/open-build-service] 36d1fc: [backend] implement 'genmetaalgo' build flag suppo...
by Michael Schroeder 10 Apr '18

10 Apr '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 36d1fc59abd835f9cb9376e958947854cb9529f5 https://github.com/openSUSE/open-build-service/commit/36d1fc59abd835f9cb937… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/backend/BSSched/Checker.pm M src/backend/bs_sched Log Message: ----------- [backend] implement 'genmetaalgo' build flag support This makes it possible to set the meta algorithm for a project via the project config. Commit: 49c98d311b99a50a6a2eb66619df9b7ec4592184 https://github.com/openSUSE/open-build-service/commit/49c98d311b99a50a6a2eb… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/backend/BSBuild.pm Log Message: ----------- [backend] implement new genmeta algorithm This should handle cycles much better than before. Compare: https://github.com/openSUSE/open-build-service/compare/42f406c41919...49c98…

1 0

[obs-commits] [openSUSE/open-build-service] bd29b8: [frontend] Fix encoding of sourcediffs
by Björn Geuken 10 Apr '18

10 Apr '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: bd29b878418909ecbad10e65e40b22672d6a2e72 https://github.com/openSUSE/open-build-service/commit/bd29b878418909ecbad10… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/lib/backend/api/sources/package.rb A src/api/spec/cassettes/BsRequestAction/encoding_of_sourcediffs/1_1_1.yml A src/api/spec/cassettes/BsRequestAction/encoding_of_sourcediffs/1_1_2.yml M src/api/spec/models/bs_request_action_spec.rb M src/api/spec/support/vcr.rb Log Message: ----------- [frontend] Fix encoding of sourcediffs When the frontend requests a sourcediff that is not in xml format the returned string is not encoded. Which means that the content can have differently encoded characters, eg. a tarball that contains diffferently encoded files. When handling such a sourcediff string in OBS this could cause encoding issues. For example sourcediff.present? would raise an ArgumentError: invalid byte sequence in UTF-8. To solve this we replace non-UTF-8 encoded bytes with '?', the default replacement string defined by String#encode. https://ruby-doc.org/core-2.2.0/String.html#method-i-encode A note for the VCR configuration change: Since the backend doesn't return properly encoded data, VCR would fail on this when handling the backend response. To prevent this we have to tell VCR to not encode such requests as described here: http://www.rubydoc.info/github/vcr/vcr/VCR%2FConfiguration%3Apreserve_exact… Commit: 255182c87da67da1a408b93eda7fcdd8590f6b56 https://github.com/openSUSE/open-build-service/commit/255182c87da67da1a408b… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/views/event_mailer/_submit_action.text.erb R src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_Request/using_different_encodings/does_not_throw_an_incompatible_character_encodings_exception.yml M src/api/spec/mailers/event_mailer_spec.rb Log Message: ----------- Revert "[webui] Fix encodings exception in event mailer" This reverts commit f35bee8f94991a165561f8a56e7c92747c1ad10a. This commit was encoding source diff content in the event mailer template. With 5f78f1abe23f91eca8d077fbec19e25125accd92 we now encode the source diff right when we get it from the backend. Which means that we can stop force encoding it in the template. Commit: 779f3b75b43849f4339682ec4232e9e98a94ed94 https://github.com/openSUSE/open-build-service/commit/779f3b75b43849f433968… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/mailers/event_mailer.rb Log Message: ----------- Revert "[webui] Rescue `mail` callbacks in `EventMailer`" This reverts commit 1f259e35d4eb6c866163530de29ae22bb39204b6. This code was added to debug the encoding exceptions we got when sending event mails. Since this got fixed now, we don't need this anymore. Commit: 42f406c41919435a2ba825c589adb60c68c4dd58 https://github.com/openSUSE/open-build-service/commit/42f406c41919435a2ba82… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/app/mailers/event_mailer.rb M src/api/app/views/event_mailer/_submit_action.text.erb M src/api/lib/backend/api/sources/package.rb A src/api/spec/cassettes/BsRequestAction/encoding_of_sourcediffs/1_1_1.yml A src/api/spec/cassettes/BsRequestAction/encoding_of_sourcediffs/1_1_2.yml R src/api/spec/cassettes/EventMailer/_event/for_an_event_of_type_Event_Request/using_different_encodings/does_not_throw_an_incompatible_character_encodings_exception.yml M src/api/spec/mailers/event_mailer_spec.rb M src/api/spec/models/bs_request_action_spec.rb M src/api/spec/support/vcr.rb Log Message: ----------- Merge pull request #4828 from bgeuken/fix_request_encoding Fix request encoding Compare: https://github.com/openSUSE/open-build-service/compare/4414f4c4db8e...42f40…

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 10 Apr '18

10 Apr '18

Branch: refs/heads/depfu/update/srcapi/font-awesome-rails-4.7.0.4 Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service] b745a6: Update font-awesome-rails to version 4.7.0.4
by Eduardo J 10 Apr '18

10 Apr '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b745a611fc47b1326d79e14aa90a8f88db00362f https://github.com/openSUSE/open-build-service/commit/b745a611fc47b1326d79e… Author: depfu[bot] <bot(a)depfu.com> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update font-awesome-rails to version 4.7.0.4 Commit: 4414f4c4db8e574d27f62a8dde655676cdb73895 https://github.com/openSUSE/open-build-service/commit/4414f4c4db8e574d27f62… Author: Eduardo J <enavarro(a)suse.com> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #4827 from openSUSE/depfu/update/srcapi/font-awesome-rails-4.7.0.4 Update font-awesome-rails: 4.7.0.2 → 4.7.0.4 (patch) Compare: https://github.com/openSUSE/open-build-service/compare/f0ea35b6a7be...4414f…

1 0

[obs-commits] [openSUSE/osc] b37452: remove osc_hotshot.py
by Marcus Huewe 10 Apr '18

10 Apr '18

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: b37452157b7c7fb2fc47e18bc1922ef84ebc1111 https://github.com/openSUSE/osc/commit/b37452157b7c7fb2fc47e18bc1922ef84ebc… Author: Tomáš Čech <sleep_walker(a)gnu.org> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: R osc_hotshot.py M setup.py Log Message: ----------- remove osc_hotshot.py osc_hotshot.py is long time untouched and broken thus I assume it is safe to be removed fixes issue #400 Commit: b7e90c3b5726155f891ab2cf8a8edb8ed72a1561 https://github.com/openSUSE/osc/commit/b7e90c3b5726155f891ab2cf8a8edb8ed72a… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: R osc_hotshot.py M setup.py Log Message: ----------- Merge branch 'hostshot' of https://github.com/sleep-walker/osc Remove osc_hotshot.py cruft. Compare: https://github.com/openSUSE/osc/compare/5341f3aae5e1...b7e90c3b5726

1 0

[obs-commits] [openSUSE/open-build-service] f0ea35: [dist] obs-server.spec: just require /usr/bin/crea...
by Ruediger Oertel 10 Apr '18

10 Apr '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f0ea35b6a7be30c08deaccde484409f831919234 https://github.com/openSUSE/open-build-service/commit/f0ea35b6a7be30c08deac… Author: Ruediger Oertel <ro(a)suse.de> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M dist/obs-server.spec Log Message: ----------- [dist] obs-server.spec: just require /usr/bin/createrepo

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 10 Apr '18

10 Apr '18

Branch: refs/heads/depfu/update/srcapi/rubocop-rspec-1.25.0 Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service] e431f1: Update rubocop-rspec to version 1.25.0
by Eduardo J 10 Apr '18

10 Apr '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e431f100d7b9d168b38bae1da58489dc1a3c1c3c https://github.com/openSUSE/open-build-service/commit/e431f100d7b9d168b38ba… Author: depfu[bot] <bot(a)depfu.com> Date: 2018-04-07 (Sat, 07 Apr 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rubocop-rspec to version 1.25.0 Commit: 23ef310d2f79d225203e9512e4472b209cf1fe28 https://github.com/openSUSE/open-build-service/commit/23ef310d2f79d225203e9… Author: Eduardo J <enavarro(a)suse.com> Date: 2018-04-10 (Tue, 10 Apr 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #4819 from openSUSE/depfu/update/srcapi/rubocop-rspec-1.25.0 Update rubocop-rspec: 1.24.0 → 1.25.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/d991cffea273...23ef3…

1 0