November 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 8c4b54: Use contain_exactly to test assignment of staging ...
by Björn Geuken 22 Nov '18

22 Nov '18

Branch: refs/heads/staging-workflow Home: https://github.com/openSUSE/open-build-service Commit: 8c4b549cad0dc6ccd014db4bca613495feb6f182 https://github.com/openSUSE/open-build-service/commit/8c4b549cad0dc6ccd014d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-22 (Thu, 22 Nov 2018) Changed paths: M src/api/spec/controllers/webui/staging/projects_controller_spec.rb Log Message: ----------- Use contain_exactly to test assignment of staging manager groups Commit: d1662873ef03dd5b06702adbb1656d11a3d686ed https://github.com/openSUSE/open-build-service/commit/d1662873ef03dd5b06702… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-22 (Thu, 22 Nov 2018) Changed paths: M src/api/app/controllers/webui/staging/projects_controller.rb M src/api/app/views/webui2/webui/staging/workflows/_create_staging_project.html.haml M src/api/spec/controllers/webui/staging/projects_controller_spec.rb Log Message: ----------- Allow to create staging projects outside the Staging namespace Previously we required the location of the staging projects to be under the 'Staging' namespace of the staging workflow project (eg. my_workflow_project:Staging:A). With this commit it will be possible to create the staging project anywhere as long as the user has permissions to it's location. Commit: fec98fb1cd9f92ccad850a764d325dbdc4d5be65 https://github.com/openSUSE/open-build-service/commit/fec98fb1cd9f92ccad850… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-22 (Thu, 22 Nov 2018) Changed paths: M src/api/app/controllers/webui/staging/projects_controller.rb M src/api/app/views/webui2/webui/staging/workflows/_create_staging_project.html.haml M src/api/spec/controllers/webui/staging/projects_controller_spec.rb Log Message: ----------- Merge pull request #6308 from bgeuken/flexible_staging_project Make the location of the staging project flexible Compare: https://github.com/openSUSE/open-build-service/compare/4ecdd4df0ffd...fec98… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] e4aa4e: Create excluded request API
by Moisés Déniz Alemán 22 Nov '18

22 Nov '18

Branch: refs/heads/staging-workflow Home: https://github.com/openSUSE/open-build-service Commit: e4aa4e91906bc74602149e8d19a406dc7d89b320 https://github.com/openSUSE/open-build-service/commit/e4aa4e91906bc74602149… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-22 (Thu, 22 Nov 2018) Changed paths: A src/api/app/controllers/staging/excluded_requests_controller.rb A src/api/app/policies/staging/request_exclusion_policy.rb M src/api/config/routes.rb Log Message: ----------- Create excluded request API Co-authored-by: Moisés Déniz Alemán <mdeniz(a)suse.com> Commit: f1cfcc9966422c08dfbd1d89485da31a0b5ba80a https://github.com/openSUSE/open-build-service/commit/f1cfcc9966422c08dfbd1… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-22 (Thu, 22 Nov 2018) Changed paths: A src/api/spec/controllers/staging/excluded_requests_controller_spec.rb Log Message: ----------- Write tests for ExcludedRequestController Cover all edge cases. Co-authored-by: David Kang <dkang(a)suse.com> Co-authored-by: Moisés Déniz Alemán <mdeniz(a)suse.com> Commit: 4ecdd4df0ffd6e80406dbdac2c051710a8866c8e https://github.com/openSUSE/open-build-service/commit/4ecdd4df0ffd6e80406db… Author: Moisés Déniz Alemán <mdeniz(a)suse.com> Date: 2018-11-22 (Thu, 22 Nov 2018) Changed paths: A src/api/app/controllers/staging/excluded_requests_controller.rb A src/api/app/policies/staging/request_exclusion_policy.rb M src/api/config/routes.rb A src/api/spec/controllers/staging/excluded_requests_controller_spec.rb Log Message: ----------- Merge pull request #6336 from Ana06/ignored_requests_api Create excluded request API Compare: https://github.com/openSUSE/open-build-service/compare/17d9812d419a...4ecdd… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] d0b971: Fix check methods in StagingProject model
by Stephan Kulow 22 Nov '18

22 Nov '18

Branch: refs/heads/staging-workflow Home: https://github.com/openSUSE/open-build-service Commit: d0b971b8654ba0b1b3410e0cfb9c476dff579143 https://github.com/openSUSE/open-build-service/commit/d0b971b8654ba0b1b3410… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-22 (Thu, 22 Nov 2018) Changed paths: M src/api/app/models/staging/staging_project.rb A src/api/spec/cassettes/Staging_StagingProject/_assign_managers_group/when_the_group_was_already_assigned/1_4_2_1.yml A src/api/spec/cassettes/Staging_StagingProject/_assign_managers_group/when_the_group_wasn_t_assigned_before/1_4_1_1.yml A src/api/spec/cassettes/Staging_StagingProject/_missing_reviews/contains_all_open_reviews_of_staged_requests.yml A src/api/spec/cassettes/Staging_StagingProject/_missing_reviews/when_there_is_an_accepted_review/1_1_2_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_request_got_revoked/1_3_2_1.yml R src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_failed_checks/1_3_5_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_failed_checks_on_build_repo/1_3_7_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_failed_checks_on_build_repo/1_3_7_2.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_failed_checks_on_published_repo/1_3_6_1.yml R src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_missing_checks/1_3_3_1.yml R src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_missing_checks/1_4_3_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_missing_checks_on_build_repo/1_3_4_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_missing_checks_on_published_repo/1_3_3_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_no_staged_requests/1_3_1_1.yml R src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_pending_checks/1_3_4_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_pending_checks/1_3_5_1.yml R src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_pending_checks/1_4_4_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_succeeded_checks/1_3_8_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_we_only_have_outdated_checks/1_3_9_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_we_only_have_outdated_checks/1_3_9_2.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_we_only_have_outdated_checks/1_3_9_3.yml A src/api/spec/cassettes/Staging_StagingProject/_unassign_managers_group/1_5_1.yml A src/api/spec/cassettes/Staging_StagingProject/_untracked_requests/1_2_1.yml M src/api/spec/models/staging/staging_project_spec.rb Log Message: ----------- Fix check methods in StagingProject model and adding specs. Co-authored-by: Christian Bruckmayer <cbruckmayer(a)suse.com> Commit: fdac465fb9dff999c88a7592c709b00f923131f0 https://github.com/openSUSE/open-build-service/commit/fdac465fb9dff999c88a7… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-22 (Thu, 22 Nov 2018) Changed paths: M src/api/app/models/staging/staging_project.rb M src/api/app/views/webui2/webui/staging/projects/show.html.haml M src/api/spec/models/staging/staging_project_spec.rb Log Message: ----------- Rename current_checks to checks There is no more conflict with the relationship Commit: b90137fe6f21c21e09cc681295ce4c5f773e2c0f https://github.com/openSUSE/open-build-service/commit/b90137fe6f21c21e09cc6… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-22 (Thu, 22 Nov 2018) Changed paths: M src/api/app/models/staging/staging_project.rb M src/api/app/views/webui2/webui/staging/workflows/_problems.html.haml Log Message: ----------- Remove failed_status_checks from StagingProject it's just a long variant of checks.failed Commit: 17d9812d419aa32eedd63dfcfee04caa9905a375 https://github.com/openSUSE/open-build-service/commit/17d9812d419aa32eedd63… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-22 (Thu, 22 Nov 2018) Changed paths: M src/api/app/models/staging/staging_project.rb M src/api/app/views/webui2/webui/staging/projects/show.html.haml M src/api/app/views/webui2/webui/staging/workflows/_problems.html.haml A src/api/spec/cassettes/Staging_StagingProject/_assign_managers_group/when_the_group_was_already_assigned/1_4_2_1.yml A src/api/spec/cassettes/Staging_StagingProject/_assign_managers_group/when_the_group_wasn_t_assigned_before/1_4_1_1.yml A src/api/spec/cassettes/Staging_StagingProject/_missing_reviews/contains_all_open_reviews_of_staged_requests.yml A src/api/spec/cassettes/Staging_StagingProject/_missing_reviews/when_there_is_an_accepted_review/1_1_2_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_request_got_revoked/1_3_2_1.yml R src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_failed_checks/1_3_5_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_failed_checks_on_build_repo/1_3_7_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_failed_checks_on_build_repo/1_3_7_2.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_failed_checks_on_published_repo/1_3_6_1.yml R src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_missing_checks/1_3_3_1.yml R src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_missing_checks/1_4_3_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_missing_checks_on_build_repo/1_3_4_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_missing_checks_on_published_repo/1_3_3_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_no_staged_requests/1_3_1_1.yml R src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_pending_checks/1_3_4_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_pending_checks/1_3_5_1.yml R src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_pending_checks/1_4_4_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_succeeded_checks/1_3_8_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_we_only_have_outdated_checks/1_3_9_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_we_only_have_outdated_checks/1_3_9_2.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_we_only_have_outdated_checks/1_3_9_3.yml A src/api/spec/cassettes/Staging_StagingProject/_unassign_managers_group/1_5_1.yml A src/api/spec/cassettes/Staging_StagingProject/_untracked_requests/1_2_1.yml M src/api/spec/models/staging/staging_project_spec.rb Log Message: ----------- Merge pull request #6261 from coolo/add_staging_coverage Add staging coverage Compare: https://github.com/openSUSE/open-build-service/compare/e2ee1e07a1fb...17d98… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 221256: Send requests creation to rabbitmq bus
by Björn Geuken 21 Nov '18

21 Nov '18

Branch: refs/heads/staging-workflow Home: https://github.com/openSUSE/open-build-service Commit: 2212564eae9fc8ad6c7fc97b4da955152962a962 https://github.com/openSUSE/open-build-service/commit/2212564eae9fc8ad6c7fc… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-10-24 (Wed, 24 Oct 2018) Changed paths: M src/api/app/models/event/request_create.rb Log Message: ----------- Send requests creation to rabbitmq bus This allows us to track creation of new requests in grafana. Co-authored-by: Ana María Martínez Gómez <ammartinez(a)suse.de> Co-authored-by: Dany Marcoux <dmarcoux(a)suse.com> Commit: f1cb20801a09c8b8964e5cf33c017dcebfa9eb95 https://github.com/openSUSE/open-build-service/commit/f1cb20801a09c8b8964e5… Author: Ruediger Oertel <ro(a)suse.de> Date: 2018-10-31 (Wed, 31 Oct 2018) Changed paths: M src/backend/BSSSL.pm Log Message: ----------- [backend] BSSSL.pm: replace CTX_use_certificate_file by CTX_use_certificate_chain_file to support chain certificates in the pem certificate file Commit: 250a6ef7aca61b73b7be167aaa3fa300a9ad2159 https://github.com/openSUSE/open-build-service/commit/250a6ef7aca61b73b7be1… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/controllers/application_controller.rb M src/api/app/controllers/attribute_namespace_controller.rb M src/api/app/controllers/build/file_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/search_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/helpers/webui/buildresult_helper.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/mixins/has_attributes.rb M src/api/app/models/bs_request_action_maintenance_incident.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/cloud/azure/configuration.rb M src/api/app/models/cloud/azure/params.rb M src/api/app/models/distribution.rb M src/api/app/models/issue.rb M src/api/app/models/kiwi/repository.rb M src/api/app/models/project/update_from_xml_command.rb M src/api/app/models/user.rb M src/api/app/views/result/packageresult.xml.builder M src/api/config/routes.rb M src/api/db/seeds.rb M src/api/lib/backend/api/sources/package.rb M src/api/lib/backend/api/sources/project.rb M src/api/lib/tasks/sprites.rake M src/api/lib/xpath_engine.rb M src/api/spec/bootstrap/features/webui/packages_spec.rb M src/api/spec/controllers/source_project_config_controller_spec.rb M src/api/spec/controllers/source_project_package_meta_controller_spec.rb M src/api/spec/controllers/status/required_checks_controller_spec.rb M src/api/spec/controllers/webui/configuration_controller_spec.rb M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/repositories_controller_spec.rb M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/factories/download_repository_factory.rb M src/api/spec/factories/kiwi_image.rb M src/api/spec/factories/repository.rb M src/api/spec/features/webui/notifications_spec.rb M src/api/spec/features/webui/packages_spec.rb M src/api/spec/jobs/update_backend_infos_job_spec.rb M src/api/spec/models/bs_request_action_spec.rb M src/api/spec/models/kiwi/image_spec.rb M src/api/spec/models/local_build_statistic/for_package_spec.rb M src/api/spec/models/obs_factory/obs_project_spec.rb M src/api/spec/models/obs_factory/staging_project_spec.rb M src/api/spec/models/project_spec.rb M src/api/spec/support/capybara.rb M src/api/test/functional/attributes_test.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/configurations_controller_test.rb M src/api/test/functional/distributions_controller_test.rb M src/api/test/functional/kgraft_maintenance_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/product_test.rb M src/api/test/functional/release_management_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/search_controller_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/source_services_test.rb M src/api/test/unit/binary_release.rb M src/api/test/unit/project_test.rb Log Message: ----------- Enable Layout/AlignHash rubocop Commit: e423d03ee2e8b386fc5d171b790f815271716555 https://github.com/openSUSE/open-build-service/commit/e423d03ee2e8b386fc5d1… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/.haml-lint.yml Log Message: ----------- Extend ignored_cops of haml_lint Layout/AlignHash needs to be ignored too as the extracted ruby code is not indented as the HAML is Commit: 48d921eeb0d539cef49d1304170960459a210dac https://github.com/openSUSE/open-build-service/commit/48d921eeb0d539cef49d1… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-05 (Mon, 05 Nov 2018) Changed paths: M src/api/.haml-lint.yml M src/api/.rubocop_todo.yml M src/api/app/controllers/application_controller.rb M src/api/app/controllers/attribute_namespace_controller.rb M src/api/app/controllers/build/file_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/search_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/helpers/webui/buildresult_helper.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/mixins/has_attributes.rb M src/api/app/models/bs_request_action_maintenance_incident.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/cloud/azure/configuration.rb M src/api/app/models/cloud/azure/params.rb M src/api/app/models/distribution.rb M src/api/app/models/issue.rb M src/api/app/models/kiwi/repository.rb M src/api/app/models/project/update_from_xml_command.rb M src/api/app/models/user.rb M src/api/app/views/result/packageresult.xml.builder M src/api/config/routes.rb M src/api/db/seeds.rb M src/api/lib/backend/api/sources/package.rb M src/api/lib/backend/api/sources/project.rb M src/api/lib/tasks/sprites.rake M src/api/lib/xpath_engine.rb M src/api/spec/bootstrap/features/webui/packages_spec.rb M src/api/spec/controllers/source_project_config_controller_spec.rb M src/api/spec/controllers/source_project_package_meta_controller_spec.rb M src/api/spec/controllers/status/required_checks_controller_spec.rb M src/api/spec/controllers/webui/configuration_controller_spec.rb M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/repositories_controller_spec.rb M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/factories/download_repository_factory.rb M src/api/spec/factories/kiwi_image.rb M src/api/spec/factories/repository.rb M src/api/spec/features/webui/notifications_spec.rb M src/api/spec/features/webui/packages_spec.rb M src/api/spec/jobs/update_backend_infos_job_spec.rb M src/api/spec/models/bs_request_action_spec.rb M src/api/spec/models/kiwi/image_spec.rb M src/api/spec/models/local_build_statistic/for_package_spec.rb M src/api/spec/models/obs_factory/obs_project_spec.rb M src/api/spec/models/obs_factory/staging_project_spec.rb M src/api/spec/models/project_spec.rb M src/api/spec/support/capybara.rb M src/api/test/functional/attributes_test.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/configurations_controller_test.rb M src/api/test/functional/distributions_controller_test.rb M src/api/test/functional/kgraft_maintenance_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/product_test.rb M src/api/test/functional/release_management_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/search_controller_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/source_services_test.rb M src/api/test/unit/binary_release.rb M src/api/test/unit/project_test.rb Log Message: ----------- Merge pull request #6177 from coolo/enable_hash_alignment Enable Layout/AlignHash rubocop Commit: ab31d0cba4ec7febb8360b6b0da496ac063824a7 https://github.com/openSUSE/open-build-service/commit/ab31d0cba4ec7febb8360… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-11-06 (Tue, 06 Nov 2018) Changed paths: M src/api/app/controllers/cloud/upload_jobs_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/source_project_controller.rb M src/api/app/controllers/source_project_meta_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/download_on_demand_controller.rb M src/api/app/controllers/webui/groups/bs_requests_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/users/bs_requests_controller.rb M src/api/app/helpers/flag_helper.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/helpers/webui/request_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/mixins/parse_package_diff.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request/data_table/params_parser.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_maintenance_incident.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/buildresult.rb M src/api/app/models/channel_binary.rb M src/api/app/models/comment.rb M src/api/app/models/configuration.rb M src/api/app/models/event/base.rb M src/api/app/models/event_subscription.rb M src/api/app/models/full_text_search.rb M src/api/app/models/group.rb M src/api/app/models/issue.rb M src/api/app/models/kiwi/image/xml_parser.rb M src/api/app/models/obs_factory/staging_project.rb M src/api/app/models/package.rb M src/api/app/models/patchinfo.rb M src/api/app/models/project.rb M src/api/app/models/project/key_info.rb M src/api/app/models/project/update_from_xml_command.rb M src/api/app/models/project_status/calculator.rb M src/api/app/models/project_status/pack_info.rb M src/api/app/models/repository.rb M src/api/app/models/role.rb M src/api/app/models/static_permission.rb M src/api/app/models/unregistered_user.rb M src/api/app/models/user.rb M src/api/app/views/webui/feeds/commits.atom.builder M src/api/config/environments/production.rb M src/api/config/routes.rb M src/api/db/attribute_descriptions.rb M src/api/lib/feature_switch/obs_repository.rb M src/api/lib/xpath_engine.rb M src/api/spec/bootstrap/features/webui/maintenance_workflow_spec.rb M src/api/spec/controllers/cloud/upload_jobs_controller_spec.rb M src/api/spec/controllers/webui/cloud/azure/upload_jobs_controller_spec.rb M src/api/spec/controllers/webui/cloud/ec2/upload_jobs_controller_spec.rb M src/api/spec/controllers/webui/download_on_demand_controller_spec.rb M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/controllers/webui/obs_factory/staging_projects_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/packages/build_reason_controller_spec.rb M src/api/spec/controllers/webui/packages/job_history_controller_spec.rb M src/api/spec/controllers/webui/patchinfo_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/controllers/webui/projects/rebuild_times_controller_spec.rb M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/controllers/webui/session_controller_spec.rb M src/api/spec/controllers/webui/user_controller_spec.rb M src/api/spec/decorators/statistics/maintenance_statistic_decorator_spec.rb M src/api/spec/factories/download_repository_factory.rb M src/api/spec/factories/project.rb M src/api/spec/factories/repository.rb M src/api/spec/features/webui/login_spec.rb M src/api/spec/features/webui/maintenance_workflow_spec.rb M src/api/spec/features/webui/users/user_home_page_spec.rb M src/api/spec/helpers/webui/webui_helper_spec.rb M src/api/spec/jobs/bs_request_action_webui_infos_job_spec.rb M src/api/spec/lib/authenticator_spec.rb M src/api/spec/lib/backend/api/cloud_spec.rb M src/api/spec/lib/pretty_nested_errors_spec.rb M src/api/spec/models/bs_request_action/differ/for_source_spec.rb M src/api/spec/models/bs_request_action_spec.rb M src/api/spec/models/bs_request_spec.rb M src/api/spec/models/cloud/backend/upload_job_spec.rb M src/api/spec/models/cloud/upload_job_spec.rb M src/api/spec/models/kiwi/image_spec.rb M src/api/spec/models/obs_factory/staging_project_spec.rb M src/api/spec/models/package_spec.rb M src/api/spec/models/project_spec.rb M src/api/spec/models/unregistered_user_spec.rb M src/api/spec/models/user_ldap_strategy_spec.rb M src/api/spec/models/user_spec.rb M src/api/spec/requests/kerberos_login_spec.rb M src/api/spec/routing/api_matcher_spec.rb M src/api/spec/support/shared_examples/features/bootstrap_user_tab.rb M src/api/spec/support/shared_examples/features/user_tab.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/distributions_controller_test.rb M src/api/test/functional/group_request_test.rb M src/api/test/functional/kgraft_maintenance_test.rb M src/api/test/functional/product_test.rb M src/api/test/functional/public_controller_test.rb M src/api/test/functional/release_management_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/search_controller_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/statistics_controller_test.rb M src/api/test/models/event_test.rb M src/api/test/unit/user_ldap_strategy_test.rb Log Message: ----------- rubocop fix for Layout/AlignHash Layout/AlignHash behaves different in 0.60 than in 0.59 the both PRs (#6144 and #6177) were merged independently Commit: 6092a895bc1e89f76a43c66a726812f6766bdc68 https://github.com/openSUSE/open-build-service/commit/6092a895bc1e89f76a43c… Author: Eduardo J <enavarro(a)suse.com> Date: 2018-11-06 (Tue, 06 Nov 2018) Changed paths: M src/api/app/controllers/cloud/upload_jobs_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/source_project_controller.rb M src/api/app/controllers/source_project_meta_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/download_on_demand_controller.rb M src/api/app/controllers/webui/groups/bs_requests_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/users/bs_requests_controller.rb M src/api/app/helpers/flag_helper.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/helpers/webui/request_helper.rb M src/api/app/helpers/webui/webui_helper.rb M src/api/app/mixins/parse_package_diff.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request/data_table/params_parser.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_maintenance_incident.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/buildresult.rb M src/api/app/models/channel_binary.rb M src/api/app/models/comment.rb M src/api/app/models/configuration.rb M src/api/app/models/event/base.rb M src/api/app/models/event_subscription.rb M src/api/app/models/full_text_search.rb M src/api/app/models/group.rb M src/api/app/models/issue.rb M src/api/app/models/kiwi/image/xml_parser.rb M src/api/app/models/obs_factory/staging_project.rb M src/api/app/models/package.rb M src/api/app/models/patchinfo.rb M src/api/app/models/project.rb M src/api/app/models/project/key_info.rb M src/api/app/models/project/update_from_xml_command.rb M src/api/app/models/project_status/calculator.rb M src/api/app/models/project_status/pack_info.rb M src/api/app/models/repository.rb M src/api/app/models/role.rb M src/api/app/models/static_permission.rb M src/api/app/models/unregistered_user.rb M src/api/app/models/user.rb M src/api/app/views/webui/feeds/commits.atom.builder M src/api/config/environments/production.rb M src/api/config/routes.rb M src/api/db/attribute_descriptions.rb M src/api/lib/feature_switch/obs_repository.rb M src/api/lib/xpath_engine.rb M src/api/spec/bootstrap/features/webui/maintenance_workflow_spec.rb M src/api/spec/controllers/cloud/upload_jobs_controller_spec.rb M src/api/spec/controllers/webui/cloud/azure/upload_jobs_controller_spec.rb M src/api/spec/controllers/webui/cloud/ec2/upload_jobs_controller_spec.rb M src/api/spec/controllers/webui/download_on_demand_controller_spec.rb M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/controllers/webui/obs_factory/staging_projects_controller_spec.rb M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/controllers/webui/packages/build_reason_controller_spec.rb M src/api/spec/controllers/webui/packages/job_history_controller_spec.rb M src/api/spec/controllers/webui/patchinfo_controller_spec.rb M src/api/spec/controllers/webui/project_controller_spec.rb M src/api/spec/controllers/webui/projects/rebuild_times_controller_spec.rb M src/api/spec/controllers/webui/request_controller_spec.rb M src/api/spec/controllers/webui/session_controller_spec.rb M src/api/spec/controllers/webui/user_controller_spec.rb M src/api/spec/decorators/statistics/maintenance_statistic_decorator_spec.rb M src/api/spec/factories/download_repository_factory.rb M src/api/spec/factories/project.rb M src/api/spec/factories/repository.rb M src/api/spec/features/webui/login_spec.rb M src/api/spec/features/webui/maintenance_workflow_spec.rb M src/api/spec/features/webui/users/user_home_page_spec.rb M src/api/spec/helpers/webui/webui_helper_spec.rb M src/api/spec/jobs/bs_request_action_webui_infos_job_spec.rb M src/api/spec/lib/authenticator_spec.rb M src/api/spec/lib/backend/api/cloud_spec.rb M src/api/spec/lib/pretty_nested_errors_spec.rb M src/api/spec/models/bs_request_action/differ/for_source_spec.rb M src/api/spec/models/bs_request_action_spec.rb M src/api/spec/models/bs_request_spec.rb M src/api/spec/models/cloud/backend/upload_job_spec.rb M src/api/spec/models/cloud/upload_job_spec.rb M src/api/spec/models/kiwi/image_spec.rb M src/api/spec/models/obs_factory/staging_project_spec.rb M src/api/spec/models/package_spec.rb M src/api/spec/models/project_spec.rb M src/api/spec/models/unregistered_user_spec.rb M src/api/spec/models/user_ldap_strategy_spec.rb M src/api/spec/models/user_spec.rb M src/api/spec/requests/kerberos_login_spec.rb M src/api/spec/routing/api_matcher_spec.rb M src/api/spec/support/shared_examples/features/bootstrap_user_tab.rb M src/api/spec/support/shared_examples/features/user_tab.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/distributions_controller_test.rb M src/api/test/functional/group_request_test.rb M src/api/test/functional/kgraft_maintenance_test.rb M src/api/test/functional/product_test.rb M src/api/test/functional/public_controller_test.rb M src/api/test/functional/release_management_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/search_controller_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/statistics_controller_test.rb M src/api/test/models/event_test.rb M src/api/test/unit/user_ldap_strategy_test.rb Log Message: ----------- Merge pull request #6184 from vpereira/master rubocop fix for Layout/AlignHash Commit: 4787383743f6097ef34fcf0bbfc4adeebb46aace https://github.com/openSUSE/open-build-service/commit/4787383743f6097ef34fc… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-06 (Tue, 06 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update pry to version 0.12.0 Commit: d941ecaad657be80a3c997bf960b971d4a47c939 https://github.com/openSUSE/open-build-service/commit/d941ecaad657be80a3c99… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-06 (Tue, 06 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6185 from openSUSE/depfu/update/srcapi/pry-0.12.0 [src/api] Update pry: 0.11.3 → 0.12.0 (major) Commit: 31f0a15411961cfb6728364e302c739f5801238e https://github.com/openSUSE/open-build-service/commit/31f0a15411961cfb67283… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-06 (Tue, 06 Nov 2018) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock M src/api/lib/rabbitmq_bus.rb A src/api/spec/lib/rabbitmq_bus_spec.rb A src/api/spec/models/update_notification_events_spec.rb M src/api/spec/rails_helper.rb A src/api/spec/support/rabbitmq.rb Log Message: ----------- Cover sending events to rabbitmq I was mildly annoyed that I couldn't cover the new events to be sent to rabbitmq, so I did a little research on how to test bunny. It's not so easy, but good enough to mock Commit: 409c073fa550e5f4c7d9a1eab225ef7c223ea452 https://github.com/openSUSE/open-build-service/commit/409c073fa550e5f4c7d9a… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-06 (Tue, 06 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update rack to version 2.0.6 Commit: 130a66792b51c169f485467f4e314e1857ace713 https://github.com/openSUSE/open-build-service/commit/130a66792b51c169f4854… Author: Eduardo J <enavarro(a)suse.com> Date: 2018-11-07 (Wed, 07 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6194 from openSUSE/depfu/update/srcapi/rack-2.0.6 🚨 [security] [src/api] Update rack: 2.0.5 → 2.0.6 (patch) Commit: 74bcfa6186672db0a24768157fd458f0dd87faba https://github.com/openSUSE/open-build-service/commit/74bcfa6186672db0a2476… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update concurrent-ruby-ext to version 1.1.3 Commit: c79e780e9e8d9b649e56f2094c735484b1ccc0d4 https://github.com/openSUSE/open-build-service/commit/c79e780e9e8d9b649e56f… Author: Eduardo J <enavarro(a)suse.com> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6203 from openSUSE/depfu/update/srcapi/concurrent-ruby-ext-1.1.3 [src/api] Update concurrent-ruby-ext: 1.0.5 → 1.1.3 (minor) Commit: 0459f1d20c4e96fafaad3e9f19965921f64c8399 https://github.com/openSUSE/open-build-service/commit/0459f1d20c4e96fafaad3… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock M src/api/lib/rabbitmq_bus.rb A src/api/spec/lib/rabbitmq_bus_spec.rb A src/api/spec/models/update_notification_events_spec.rb M src/api/spec/rails_helper.rb A src/api/spec/support/rabbitmq.rb Log Message: ----------- Merge pull request #6174 from coolo/test_bunny Cover sending events to rabbitmq Commit: 0aad483a8f395bf21fcba0fc14e9cc2ba5a6c074 https://github.com/openSUSE/open-build-service/commit/0aad483a8f395bf21fcba… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/backend/BSSrcServer/Multibuild.pm M src/backend/bs_srcserver Log Message: ----------- [backend] update multibuild data in uploadbuild if the flavor is not known yet Commit: b314512aa4d5ac8565e3bc5059dfbd6c1259bce6 https://github.com/openSUSE/open-build-service/commit/b314512aa4d5ac8565e3b… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/backend/BSASN1.pm M src/backend/BSTUF.pm Log Message: ----------- [backend] Refactor BSASN1 code - change order of asn1_unpack return values - also return tag + body in asn1_unpack - add asn1_tagged helper - add asn1_unpack_sequence helper - add asn1_unpack_integer_mpi helper Commit: 90aad5a959574f6c24a9ec482e12b085bc3f25a1 https://github.com/openSUSE/open-build-service/commit/90aad5a959574f6c24a9e… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/backend/BSPublisher/Registry.pm Log Message: ----------- [backend] local registry: lock global :repo file The publisher can have multiple processes publishing to a registry, so better safe than sorry... Commit: 2c800fc931527297551731f0303d37808f41b121 https://github.com/openSUSE/open-build-service/commit/2c800fc93152729755173… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/backend/BSPublisher/Registry.pm M src/backend/BSTUF.pm Log Message: ----------- [backend] add BSTUF::key2keyid helper This calculates a TUF key id from a TUF key Commit: 10d553a497606c1f2676bfa0f49bc585ad9cea1d https://github.com/openSUSE/open-build-service/commit/10d553a497606c1f2676b… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/backend/BSASN1.pm M src/backend/BSTUF.pm A src/backend/BSX509.pm Log Message: ----------- [backend] move X509 stuff from BSASN1.pm to BSX509.pm Commit: 9c344ca82ee1eefad38a340d069bf915faec4f72 https://github.com/openSUSE/open-build-service/commit/9c344ca82ee1eefad38a3… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/backend/bs_notar Log Message: ----------- [backend] also send snapshot data to notary Before this commit we relied on the notary generating a snapshot for us. This is a bit problematic, as we use the same sign keys for multiple notary repositories. Thus is was possible to replace the targets section of a repository with a targets section of a different repository that uses the same sign key. We now calculate and sign the snapshot, thereby binding the targets section data to a specific root. Commit: bd739ae384c40c94c6b01995db57c834f68a7ca9 https://github.com/openSUSE/open-build-service/commit/bd739ae384c40c94c6b01… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/backend/BSASN1.pm Log Message: ----------- [backend] add more ASN1 helpers for packing and unpacking - asn1_enumerated, asn1_string, asn1_bytes, asn1_bits_list - asn1_unpack_integer, asn1_unpack_set, asn1_unpack_bytes, asn1_unpack_octet_string, asn1_unpack_string, asn1_unpack_bits_list, asn1_unpack_boolean, asn1_unpack_tagged Commit: a832804607db631bbe75e63625c72e69284c2f49 https://github.com/openSUSE/open-build-service/commit/a832804607db631bbe75e… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/backend/BSX509.pm Log Message: ----------- [backend] add more certificate pack/unpack helpers - pack_random_serial - pack_distinguished_name, unpack_distinguished_name - pack_cert_extensions, unpack_cert_extensions Commit: 29060c5130be21459585832b6214d0ac95b24495 https://github.com/openSUSE/open-build-service/commit/29060c5130be214595858… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/backend/BSTUF.pm Log Message: ----------- [backend] BSTUF: use new helper functions Commit: 97f918ac27be600b6e239cb832b045bbd6549f1e https://github.com/openSUSE/open-build-service/commit/97f918ac27be600b6e239… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/backend/BSASN1.pm M src/backend/BSTUF.pm M src/backend/BSX509.pm Log Message: ----------- [backend] BSASN1.pm: get rid of asn1_ prefixes It makes no sense to have them if the module is called BSASN1... Commit: 06bfebd6c866b5b683edbffbdb1437bc45cc5466 https://github.com/openSUSE/open-build-service/commit/06bfebd6c866b5b683edb… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/backend/BSPublisher/Registry.pm M src/backend/BSTUF.pm M src/backend/bs_notar M src/backend/bs_repserver Log Message: ----------- [backend] BSTUF: get rid of BSConfiguration dependency This was only used to read BSConfig::sign. With this change we assume the caller has put the sign binary in front of the sign command. Commit: 9c8b75483ad0de2ec3be3c69db7c46d89728326e https://github.com/openSUSE/open-build-service/commit/9c8b75483ad0de2ec3be3… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update font-awesome-sass to version 5.5.0.1 Commit: 0e35a7ce306b8d2f5739a29dfe885b09f25a6501 https://github.com/openSUSE/open-build-service/commit/0e35a7ce306b8d2f5739a… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-08 (Thu, 08 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update tins to version 1.19.0 Commit: a56b984c92922b5026320d1fd0b80fcd4ec01635 https://github.com/openSUSE/open-build-service/commit/a56b984c92922b5026320… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-09 (Fri, 09 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6208 from openSUSE/depfu/update/srcapi/font-awesome-sass-5.5.0.1 [src/api] Update font-awesome-sass: 5.5.0 → 5.5.0.1 (minor) Commit: 1dd0bc1c7545f08d4853aac3deacdfdaae767f32 https://github.com/openSUSE/open-build-service/commit/1dd0bc1c7545f08d4853a… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2018-11-09 (Fri, 09 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6209 from openSUSE/depfu/update/srcapi/tins-1.19.0 [src/api] Update tins: 1.18.0 → 1.19.0 (minor) Commit: b9fcb84362a16bafc2d520bce87bfa7d7fa59c6f https://github.com/openSUSE/open-build-service/commit/b9fcb84362a16bafc2d52… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-09 (Fri, 09 Nov 2018) Changed paths: M src/backend/BSASN1.pm M src/backend/BSPublisher/Registry.pm M src/backend/BSSrcServer/Multibuild.pm M src/backend/BSTUF.pm A src/backend/BSX509.pm M src/backend/bs_notar M src/backend/bs_repserver M src/backend/bs_srcserver Log Message: ----------- Merge pull request #6163 from mlschroe/master [backend] update multibuild data in uploadbuild if the flavor is not … Commit: 1560d9355386c0f53588403a2f345add7b61b04d https://github.com/openSUSE/open-build-service/commit/1560d9355386c0f535884… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2018-11-09 (Fri, 09 Nov 2018) Changed paths: M dist/obsstoragesetup M dist/systemd/obsrepserver.service M dist/systemd/obsservice.service M dist/systemd/obsservicedispatch.service M dist/systemd/obssrcserver.service Log Message: ----------- [dist] fix appliance upstart after switch to systemd * fix ownership for log and run dirs * fixes for startup ordering of daemons Commit: ba657a48f6e59ce48220c27fc5552b1511dddd3f https://github.com/openSUSE/open-build-service/commit/ba657a48f6e59ce48220c… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2018-11-09 (Fri, 09 Nov 2018) Changed paths: M dist/Makefile M dist/obs-server.spec R dist/obsapisetup M dist/setup-appliance.sh A dist/systemd/obsapisetup.service M dist/t/0050-test-appliance.ta Log Message: ----------- [dist] obsapisetup as systemd service unit Commit: 4daf88ed1fdad4e7d46e5babd72060d71973bbd1 https://github.com/openSUSE/open-build-service/commit/4daf88ed1fdad4e7d46e5… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-09 (Fri, 09 Nov 2018) Changed paths: M dist/Makefile M dist/obs-server.spec R dist/obsapisetup M dist/obsstoragesetup M dist/setup-appliance.sh A dist/systemd/obsapisetup.service M dist/systemd/obsrepserver.service M dist/systemd/obsservice.service M dist/systemd/obsservicedispatch.service M dist/systemd/obssrcserver.service M dist/t/0050-test-appliance.ta Log Message: ----------- Merge pull request #6215 from M0ses/fix_service_startup Fix service startup Commit: 13f0be0915f821f7e2608eeb4846943a1c1bdda4 https://github.com/openSUSE/open-build-service/commit/13f0be0915f821f7e2608… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-10 (Sat, 10 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update sass to version 3.7.2 Commit: da43cfdf4602938d5dc42c71d8d4f1fa835f1efe https://github.com/openSUSE/open-build-service/commit/da43cfdf4602938d5dc42… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-10 (Sat, 10 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6216 from openSUSE/depfu/update/srcapi/sass-3.7.2 [src/api] Update sass: 3.6.0 → 3.7.2 (minor) Commit: 8807952eccdecd5391328962411f9c08e4a84ea7 https://github.com/openSUSE/open-build-service/commit/8807952eccdecd5391328… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-10 (Sat, 10 Nov 2018) Changed paths: M src/api/app/helpers/webui/buildresult_helper.rb Log Message: ----------- Prevent scrolling up when pressing 'unresolvable' link We disabled the link by adding '#' as link target. But this was still causing the scrollbar to move to the top when clicking the link. Commit: c7b12243547f882a316774eb065a8b71314d8801 https://github.com/openSUSE/open-build-service/commit/c7b12243547f882a31677… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-10 (Sat, 10 Nov 2018) Changed paths: M src/api/app/assets/javascripts/webui2/buildresult.js Log Message: ----------- Make the build result popovers clickable This solves two issues: * On mobile devices the popovers were not accessible due to the hover * Clicking on a popover makes it stick, which allows users to c&p the popover message. Since these messages can be quite specific, containing package names and versions, this can be very useful. Commit: 080676e40ed8b17c4e2a1f66efbee82ec5205b5e https://github.com/openSUSE/open-build-service/commit/080676e40ed8b17c4e2a1… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-10 (Sat, 10 Nov 2018) Changed paths: M src/api/app/helpers/webui/buildresult_helper.rb Log Message: ----------- Fix flickering popover for build results The build result popover can become very long, eg. when there are many unresolvable package dependencies. When this happens the popover would overlap with the link it belongs to and thus would start to flicker when hovering over it (switching from hovering state and back in a loop). By displaying the popover on the right side of the link we prevent this from happening. Fixes #6200 Commit: a79f272223c095f0a0413456d1475bb9a21c05ce https://github.com/openSUSE/open-build-service/commit/a79f272223c095f0a0413… Author: Alexandru Ungureanu <khakcarot(a)gmail.com> Date: 2018-11-10 (Sat, 10 Nov 2018) Changed paths: M CONTRIBUTING.md Log Message: ----------- Fixed broken anchor in contribution guide Commit: 4854362618c33b92235f6af06988b0df35be6cd3 https://github.com/openSUSE/open-build-service/commit/4854362618c33b92235f6… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-11 (Sun, 11 Nov 2018) Changed paths: M CONTRIBUTING.md Log Message: ----------- Merge pull request #6219 from unguul/patch-1 Fixed broken anchor in contribution guide Commit: 3a274d65054ec1481dd6b814dd9fe3e4f34636db https://github.com/openSUSE/open-build-service/commit/3a274d65054ec1481dd6b… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/assets/javascripts/webui2/buildresult.js M src/api/app/helpers/webui/buildresult_helper.rb Log Message: ----------- Merge pull request #6217 from bgeuken/bootstrap/fix_build_status_link Bootstrap/fix build status link Commit: 40d5abff3ed9b865eb727efeef25a856c1f365df https://github.com/openSUSE/open-build-service/commit/40d5abff3ed9b865eb727… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update bullet to version 5.9.0 Commit: c95113dcb804ab5074b2591bda371bea855421a2 https://github.com/openSUSE/open-build-service/commit/c95113dcb804ab5074b25… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/controllers/request_controller.rb A src/api/app/policies/bs_request_policy.rb Log Message: ----------- Add initial policy for BsRequest To keep up with on-going code improvement, I would like to propose an initial Pundit policy for BsRequest Commit: f792cbbaae410a48802c6a8a63ebd83624006b0f https://github.com/openSUSE/open-build-service/commit/f792cbbaae410a48802c6… Author: Dany Marcoux <dmarcoux(a)posteo.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6221 from openSUSE/depfu/update/srcapi/bullet-5.9.0 [src/api] Update bullet: 5.8.1 → 5.9.0 (minor) Commit: 40c7f423c16544f4b6b61c97ad773ef522024085 https://github.com/openSUSE/open-build-service/commit/40c7f423c16544f4b6b61… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: A src/api/app/models/event/repo_build_finished.rb A src/api/spec/models/event/repo_build_finished_spec.rb M src/backend/BSSched/Checker.pm Log Message: ----------- Add new RepoBuildFinished event to be sent through amqp Commit: bb10b6d6bd35bd68f7fdbbdb36917677e06608da https://github.com/openSUSE/open-build-service/commit/bb10b6d6bd35bd68f7fdb… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/controllers/status/concerns/set_checkable.rb M src/api/app/models/repository_architecture.rb M src/api/app/models/status/report.rb M src/api/config/routes.rb A src/api/db/migrate/20181025152009_add_required_checks_to_repository_architecture.rb M src/api/db/structure.sql M src/api/spec/controllers/status/checks_controller_spec.rb M src/api/spec/controllers/status/reports_controller_spec.rb Log Message: ----------- Allow status checks to be attached to built repositories I left required check controller alone as it needs a little more work as it's currently has required checks for /published in /repositories - which collides with what I want to achieve here Commit: 9bda073b8f6ab1cfee3b98f8e618f31116ad3ea5 https://github.com/openSUSE/open-build-service/commit/9bda073b8f6ab1cfee3b9… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/models/repository_architecture.rb A src/api/lib/backend/api/build/repository.rb A src/api/spec/models/repository_architecture_spec.rb Log Message: ----------- Add a build_id function to RepositoryArchitecture This is a direct mapping to view=status in the backend Commit: 462aa041165fae989fb836a6eb021604e32b018f https://github.com/openSUSE/open-build-service/commit/462aa041165fae989fb83… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/controllers/status/concerns/set_checkable.rb M src/api/spec/controllers/status/checks_controller_spec.rb Log Message: ----------- Status Reports: Fix not found handling Add coverage for checkables not found and fix problems with it. The error message was overwritten and we don't need a default error message as it's impossible to match the :update route without either project or request number Commit: 03f8111cefcf3293eafc247fc704e312538e8b6a https://github.com/openSUSE/open-build-service/commit/03f8111cefcf3293eafc2… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb A src/api/app/models/event/status_check.rb A src/api/app/models/event/status_check_for_published.rb A src/api/app/models/event/status_check_for_request.rb M src/api/app/models/status/report.rb M src/api/spec/controllers/status/checks_controller_spec.rb Log Message: ----------- Provide 2 more events on creating status checks Commit: d530d3db426a864be9eb894941db9e5be55b042f https://github.com/openSUSE/open-build-service/commit/d530d3db426a864be9eb8… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/models/event/status_check.rb M src/api/app/models/event/status_check_for_published.rb M src/api/app/models/event/status_check_for_request.rb Log Message: ----------- Give the status check events a bus id Commit: b8495169dc0db1119dba285b4be959272c8c0faf https://github.com/openSUSE/open-build-service/commit/b8495169dc0db1119dba2… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb M src/api/app/controllers/status/concerns/set_checkable.rb M src/api/app/models/event/status_check_for_published.rb M src/api/app/models/status/report.rb M src/api/spec/controllers/status/checks_controller_spec.rb Log Message: ----------- Harmonize the amqp event payload - it's :repo otherwise repository and architecture are nicer, but we started with the short names, so better stay with it to avoid suprises Commit: cc2e50e999bddde58c9b65e56cc465d48e157fb6 https://github.com/openSUSE/open-build-service/commit/cc2e50e999bddde58c9b6… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb M src/api/app/controllers/status/concerns/set_checkable.rb A src/api/app/models/event/status_check_for_build.rb M src/api/spec/controllers/status/checks_controller_spec.rb Log Message: ----------- Avoid accessing internals of set_checkable Instead of creating the event in an if-else cascade, remember the class to create and save it in constant Commit: d2701c5889dabe01a037eab762845af950f2b133 https://github.com/openSUSE/open-build-service/commit/d2701c5889dabe01a037e… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/models/status/report.rb Log Message: ----------- Remove uncoverable code in status::report model A checkable can only be of a certain type - and we shouldn't have a default Commit: 9cd2ecdf865e85a5abcf9151b6997004bfe8171d https://github.com/openSUSE/open-build-service/commit/9cd2ecdf865e85a5abcf9… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/models/obs_factory/staging_project.rb M src/api/app/models/repository_architecture.rb Log Message: ----------- Staging: Take checks of build repositories into account Commit: ec1f1354abd832da42f7fb9da87359cb9e843cdd https://github.com/openSUSE/open-build-service/commit/ec1f1354abd832da42f7f… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update method_source to version 0.9.2 Commit: f8f25bf6a218366ca55ebeae9756af50af29b22e https://github.com/openSUSE/open-build-service/commit/f8f25bf6a218366ca55eb… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/models/event/base.rb M src/api/app/models/event/branch_command.rb M src/api/app/models/event/build_fail.rb M src/api/app/models/event/build_success.rb M src/api/app/models/event/build_unchanged.rb M src/api/app/models/event/comment_for_package.rb M src/api/app/models/event/comment_for_project.rb M src/api/app/models/event/comment_for_request.rb M src/api/app/models/event/commit.rb M src/api/app/models/event/create_package.rb M src/api/app/models/event/create_project.rb M src/api/app/models/event/delete_package.rb M src/api/app/models/event/delete_project.rb M src/api/app/models/event/packtrack.rb M src/api/app/models/event/repo_build_finished.rb M src/api/app/models/event/repo_publish_state.rb M src/api/app/models/event/repo_published.rb M src/api/app/models/event/request_change.rb M src/api/app/models/event/request_create.rb M src/api/app/models/event/request_delete.rb M src/api/app/models/event/request_statechange.rb M src/api/app/models/event/review_wanted.rb M src/api/app/models/event/service_fail.rb M src/api/app/models/event/service_success.rb M src/api/app/models/event/status_check_for_build.rb M src/api/app/models/event/status_check_for_published.rb M src/api/app/models/event/status_check_for_request.rb M src/api/app/models/event/undelete_package.rb M src/api/app/models/event/undelete_project.rb M src/api/app/models/event/update_package.rb M src/api/app/models/event/update_project.rb M src/api/app/models/event/update_project_config.rb M src/api/app/models/event/upload.rb M src/api/app/models/event/version_change.rb Log Message: ----------- Make message_bus_routing_key a class attribute To avoid every such message_bus_routing_key to appear unconvered (unless sent to a bus) Commit: 7c410f5bf212d51fb6d6e223fc2ecf0950268111 https://github.com/openSUSE/open-build-service/commit/7c410f5bf212d51fb6d6e… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/models/event/base.rb M src/api/app/models/event/branch_command.rb M src/api/app/models/event/build_fail.rb M src/api/app/models/event/build_success.rb M src/api/app/models/event/build_unchanged.rb M src/api/app/models/event/comment_for_package.rb M src/api/app/models/event/comment_for_project.rb M src/api/app/models/event/comment_for_request.rb M src/api/app/models/event/commit.rb M src/api/app/models/event/create_package.rb M src/api/app/models/event/create_project.rb M src/api/app/models/event/delete_package.rb M src/api/app/models/event/delete_project.rb M src/api/app/models/event/packtrack.rb M src/api/app/models/event/repo_build_finished.rb M src/api/app/models/event/repo_publish_state.rb M src/api/app/models/event/repo_published.rb M src/api/app/models/event/request_change.rb M src/api/app/models/event/request_create.rb M src/api/app/models/event/request_delete.rb M src/api/app/models/event/request_statechange.rb M src/api/app/models/event/review_wanted.rb M src/api/app/models/event/service_fail.rb M src/api/app/models/event/service_success.rb M src/api/app/models/event/undelete_package.rb M src/api/app/models/event/undelete_project.rb M src/api/app/models/event/update_package.rb M src/api/app/models/event/update_project.rb M src/api/app/models/event/update_project_config.rb M src/api/app/models/event/upload.rb M src/api/app/models/event/version_change.rb Log Message: ----------- Don't repeat after_create_commit in every event subclass Just send all events to the bus that have a bus ticket/key Commit: d3cbe4f342c6bdffbc1004d8e5a80f58cd40876f https://github.com/openSUSE/open-build-service/commit/d3cbe4f342c6bdffbc100… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: M src/api/app/models/obs_factory/staging_project.rb M src/api/app/models/repository.rb M src/api/app/models/repository_architecture.rb A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/build_repo_has_failed_check/returns_failed.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/build_repo_has_pending_check/returns_testing.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/build_repo_has_succeeded_check/returns_acceptable.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/has_no_checks_at_all/returns_acceptable.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/published_repo_has_failed_check/returns_failed.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/published_repo_has_pending_check/returns_testing.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/published_repo_has_succeeded_check/returns_acceptable.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/required_check_on_build_repo/returns_missing_check.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/required_check_on_published_repo/returns_missing_check.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/required_check_on_standard_repo/returns_missing_check.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_required_checks_on_published_repo/returns_missing_check.yml M src/api/spec/controllers/webui/obs_factory/staging_projects_controller_spec.rb Log Message: ----------- Add test case for staging checks Had to fix some minor issues Commit: 1ffa5db10485ec48b8aaf61b315ce6cb67b9badf https://github.com/openSUSE/open-build-service/commit/1ffa5db10485ec48b8aaf… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-12 (Mon, 12 Nov 2018) Changed paths: A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/published_repo_has_failed_check_but_wrong_buildid/returns_acceptable_without_required_checks.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/published_repo_has_failed_check_but_wrong_buildid/returns_testing_with_required_checks.yml M src/api/spec/controllers/webui/obs_factory/staging_projects_controller_spec.rb Log Message: ----------- Add coverage for mismatched buildid Commit: e670b605a5a4c998738dc5074d3aa1c536bfac7b https://github.com/openSUSE/open-build-service/commit/e670b605a5a4c998738dc… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update nokogumbo to version 2.0.1 Commit: 9e2b772da7e1b40a412975d8b24b17ebaa174c17 https://github.com/openSUSE/open-build-service/commit/9e2b772da7e1b40a41297… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/spec/cassettes/Package/_commit_message/of_a_package_with_more_than_one_changes_file/1_19_4_1.yml M src/api/spec/cassettes/Package/_commit_message/with_a_diff_to_the_target_package_changes_file/1_19_1_1.yml M src/api/spec/cassettes/Package/_commit_message/with_a_diff_to_the_target_package_changes_file/1_19_1_2.yml M src/api/spec/cassettes/Package/_commit_message/with_a_diff_to_the_target_package_changes_file/1_19_1_3.yml M src/api/spec/cassettes/Package/_commit_message/with_a_diff_to_the_target_package_changes_file/1_19_1_4.yml M src/api/spec/cassettes/Package/_commit_message/with_a_diff_to_the_target_package_changes_file/1_19_1_5.yml M src/api/spec/cassettes/Package/_commit_message/with_no_diff_to_the_target_package_changes_file/1_19_2_1.yml M src/api/spec/cassettes/Package/_commit_message/with_no_diff_to_the_target_package_changes_file/1_19_2_2.yml M src/api/spec/cassettes/Package/_commit_message/with_no_diff_to_the_target_package_changes_file/1_19_2_3.yml M src/api/spec/cassettes/Package/_commit_message/with_no_diff_to_the_target_package_changes_file/1_19_2_4.yml M src/api/spec/cassettes/Package/_commit_message/with_no_diff_to_the_target_package_changes_file/1_19_2_5.yml M src/api/spec/cassettes/Webui_PackageController/GET_submit_request_dialog/1_20_1.yml M src/api/spec/cassettes/Webui_PackageController/GET_submit_request_dialog/1_20_2.yml M src/api/spec/cassettes/Webui_PackageController/GET_submit_request_dialog/1_20_3.yml M src/api/spec/cassettes/Webui_PackageController/GET_submit_request_dialog/1_20_4.yml M src/api/spec/cassettes/Webui_PackageController/GET_submit_request_dialog/1_20_5.yml M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/factories/packages.rb A src/api/spec/fixtures/files/factory_package.changes A src/api/spec/fixtures/files/factory_target_package.changes M src/api/spec/models/package_spec.rb Log Message: ----------- Fix package controller spec to fix changes diff Commit: a7591fa4075551e42ba5f4006fbbe8f72b2938e0 https://github.com/openSUSE/open-build-service/commit/a7591fa4075551e42ba5f… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/app/models/obs_factory/staging_project.rb M src/api/app/models/repository.rb M src/api/app/models/repository_architecture.rb A src/api/app/models/status/checkable.rb Log Message: ----------- Use a concern to share code between checkables Commit: d0bf365697194272ce652ff20e6051a1afeb3467 https://github.com/openSUSE/open-build-service/commit/d0bf365697194272ce652… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb M src/api/app/controllers/status/concerns/set_checkable.rb M src/api/app/controllers/status/reports_controller.rb M src/api/spec/controllers/status/checks_controller_spec.rb Log Message: ----------- Simplify set_checkable concern code Commit: db0f97b945ef2530c4d4553ba6a60ad5166435a4 https://github.com/openSUSE/open-build-service/commit/db0f97b945ef2530c4d45… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/spec/controllers/attribute_controller_spec.rb Log Message: ----------- Make attribute controller test more robust Use an explicit reload and eq() instead of be() Fixes #5454 Commit: eee1ec2195e4c38b914a25ace6e3e5cca29cc8d3 https://github.com/openSUSE/open-build-service/commit/eee1ec2195e4c38b914a2… Author: Victor Pereira <vpereira(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/test/functional/request_controller_test.rb Log Message: ----------- Add test cases for the request creation API test if a regular user is able to set an approver if he isnt admin test if admins are able to set any approver Co-authored-by: Marcus Hüwe <suse-tux(a)gmx.de> Commit: 0aeaac8e4990be564c325b076c52af010d94d3cf https://github.com/openSUSE/open-build-service/commit/0aeaac8e4990be564c325… Author: Victor Pereira <vpereirabr(a)gmail.com> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/app/controllers/request_controller.rb A src/api/app/policies/bs_request_policy.rb M src/api/test/functional/request_controller_test.rb Log Message: ----------- Merge pull request #6230 from vpereira/request_create_with_pundit Request create with pundit Commit: 232f769fe26f40485985b660723c3ca7736c1b80 https://github.com/openSUSE/open-build-service/commit/232f769fe26f40485985b… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M dist/t/0050-test-appliance.ta Log Message: ----------- [ci] legacy mode for systemd services in 0050-test-appliance.ta Commit: 61ecdd9220a3c6f1399cb431ca1ea37457898f2a https://github.com/openSUSE/open-build-service/commit/61ecdd9220a3c6f1399cb… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M dist/t/lib/OBS/Test/Utils.pm Log Message: ----------- [ci] improve OBS::Test::Util::get_package_version remove everthing from version string which is not digit or dot Commit: 7046bc3c568c1ec9e1ac738f9d6bf79761019008 https://github.com/openSUSE/open-build-service/commit/7046bc3c568c1ec9e1ac7… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M dist/t/0070-check_recommended_services.ts Log Message: ----------- [ci] fixed version compare in 0070-check_recommended_services.ts changed version compare from ">" to Build::Rpm::verscmp to avoid wrong check calculation. 2.8 < 2.9 = true 2.8 < 2.10 = false (becomes "2.8 < 2.1" mathematical) Commit: abe5eb03b2ae0ca6346ac24c8ba7ec041f303694 https://github.com/openSUSE/open-build-service/commit/abe5eb03b2ae0ca6346ac… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M dist/t/0030-installed-files.t Log Message: ----------- [ci] remove checks for .service files These checks are now longer needed because services get already checked in 0060-check_required_services.ts Commit: 72f228ab54eb1b764fdd5fc9852a58ce1ab2e251 https://github.com/openSUSE/open-build-service/commit/72f228ab54eb1b764fdd5… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M dist/t/osc/0200-check_docker_registry.ts Log Message: ----------- [ci] version dependent registry url in 0200-check_docker_registry * Bail out from 0200-check_docker_registry.ts if OBS version prior 2.8 * Use docker registry shipped with appliance in 2.9 * Use OBS internal registry if OBS >= 2.10 Commit: f0a6be333b5d028eba0ea1a72ad2f67086879a28 https://github.com/openSUSE/open-build-service/commit/f0a6be333b5d028eba0ea… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock M src/api/script/prepare_spec_tests.sh M src/api/spec/README.md M src/api/spec/browser_helper.rb R src/api/spec/support/features/features_rspec_retry.rb Log Message: ----------- Remove rspec-retry, not used since July in circleci The packages in OBS have slightly different tests flickering, but retry almost never works there either Commit: 1b40b0760e9f69727a6ddf6c2f5adbd54e01ac54 https://github.com/openSUSE/open-build-service/commit/1b40b0760e9f69727a6dd… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/spec/controllers/attribute_controller_spec.rb Log Message: ----------- Merge pull request #6222 from coolo/switch_to_dart_sass Make attribute controller test more robust Commit: 22fa39a6f8d6efa24106184d8b0558a2d1a88e90 https://github.com/openSUSE/open-build-service/commit/22fa39a6f8d6efa241061… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M dist/obs-bundled-gems.spec Log Message: ----------- Require system gems in api-deps package Rake and Rack need to get installed on the system and not with the bundled_gems archive because we require them for passenger. This caused that an update of one of these gems in the Gemfile did not trigger an update of the system gem when updating the RPM package which causes a crash of the whole application. Therefore we require them now. There are only 2 gems so it is reasonable to update the version in the spec file manually for now when we update the gem. The RPM package build will fail if we don't do it and prevents us from deploying and breaking our instance. Commit: 446852ab5cf3d33b55ff4c47d6d1253f716386c4 https://github.com/openSUSE/open-build-service/commit/446852ab5cf3d33b55ff4… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/spec/cassettes/Package/_commit_message/of_a_package_with_more_than_one_changes_file/1_19_4_1.yml M src/api/spec/cassettes/Package/_commit_message/with_a_diff_to_the_target_package_changes_file/1_19_1_1.yml M src/api/spec/cassettes/Package/_commit_message/with_a_diff_to_the_target_package_changes_file/1_19_1_2.yml M src/api/spec/cassettes/Package/_commit_message/with_a_diff_to_the_target_package_changes_file/1_19_1_3.yml M src/api/spec/cassettes/Package/_commit_message/with_a_diff_to_the_target_package_changes_file/1_19_1_4.yml M src/api/spec/cassettes/Package/_commit_message/with_a_diff_to_the_target_package_changes_file/1_19_1_5.yml M src/api/spec/cassettes/Package/_commit_message/with_no_diff_to_the_target_package_changes_file/1_19_2_1.yml M src/api/spec/cassettes/Package/_commit_message/with_no_diff_to_the_target_package_changes_file/1_19_2_2.yml M src/api/spec/cassettes/Package/_commit_message/with_no_diff_to_the_target_package_changes_file/1_19_2_3.yml M src/api/spec/cassettes/Package/_commit_message/with_no_diff_to_the_target_package_changes_file/1_19_2_4.yml M src/api/spec/cassettes/Package/_commit_message/with_no_diff_to_the_target_package_changes_file/1_19_2_5.yml M src/api/spec/cassettes/Webui_PackageController/GET_submit_request_dialog/1_20_1.yml M src/api/spec/cassettes/Webui_PackageController/GET_submit_request_dialog/1_20_2.yml M src/api/spec/cassettes/Webui_PackageController/GET_submit_request_dialog/1_20_3.yml M src/api/spec/cassettes/Webui_PackageController/GET_submit_request_dialog/1_20_4.yml M src/api/spec/cassettes/Webui_PackageController/GET_submit_request_dialog/1_20_5.yml M src/api/spec/controllers/webui/package_controller_spec.rb M src/api/spec/factories/packages.rb A src/api/spec/fixtures/files/factory_package.changes A src/api/spec/fixtures/files/factory_target_package.changes M src/api/spec/models/package_spec.rb Log Message: ----------- Merge pull request #6227 from coolo/fix_package_diff Fix package controller spec to fix changes diff Commit: 3e3296693de039f10c3887f66840ec89dbc6d5db https://github.com/openSUSE/open-build-service/commit/3e3296693de039f10c388… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M dist/obs-bundled-gems.spec Log Message: ----------- Merge pull request #6234 from ChrisBr/require_system_gems Require system gems in api-deps package Commit: 0fa9e854fe7a5ae6faae08c96fcf9ab36a81eaf8 https://github.com/openSUSE/open-build-service/commit/0fa9e854fe7a5ae6faae0… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/app/models/binary_release.rb Log Message: ----------- Avoid calling strptime with an empty string But still return `false` if both build times are nil. This was caused by: https://github.com/openSUSE/open-build-service/commit/e9f6f907bc6af777fe244… Although the code was wrong at that point. Fixes https://github.com/openSUSE/open-build-service/issues/6240 Commit: 1b0a3ae854112e42e324e936ef3e3438153c4298 https://github.com/openSUSE/open-build-service/commit/1b0a3ae854112e42e324e… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock M src/api/script/prepare_spec_tests.sh M src/api/spec/README.md M src/api/spec/browser_helper.rb R src/api/spec/support/features/features_rspec_retry.rb Log Message: ----------- Merge pull request #6197 from coolo/remove_retry Remove rspec-retry, not used since July Commit: 80e2fa6868517f491575ee7f768b6920ae7c4cd5 https://github.com/openSUSE/open-build-service/commit/80e2fa6868517f491575e… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/test/functional/published_controller_test.rb Log Message: ----------- Document published controller integration tests Explain what is being tested and if it is a FRONTEND, BACKEND or INTEGRATION test. Co-authored-by: Moisés Déniz Alemán <mdeniz(a)suse.com> Co-authored-by: Adrian Schröter <adrian(a)suse.de> Commit: 59ed7aba64e7c771d89dc6b47e8b16ece83aeb02 https://github.com/openSUSE/open-build-service/commit/59ed7aba64e7c771d89dc… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/app/helpers/maintenance_helper.rb Log Message: ----------- [api] instantiate_container: only skip base links if the master package has a incident suffix Some of our projects have a mixture of incident packages and normal packages. It does not make sense to apply the incident logic to local link packages if the master package is not an incident package. Commit: 5e2630aaa65731013e5bea6e0f507bde0fd83044 https://github.com/openSUSE/open-build-service/commit/5e2630aaa65731013e5be… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update pry to version 0.12.2 Commit: 981a51df9b7c19cd799504968ad8fc266eebe108 https://github.com/openSUSE/open-build-service/commit/981a51df9b7c19cd79950… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6229 from openSUSE/depfu/update/srcapi/nokogumbo-2.0.1 [src/api] Update nokogumbo: 2.0.0 → 2.0.1 (patch) Commit: c2b79fad54fe9ad5c8c4f30a84724a8dba38f03c https://github.com/openSUSE/open-build-service/commit/c2b79fad54fe9ad5c8c4f… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6228 from openSUSE/depfu/update/srcapi/method_source-0.9.2 [src/api] Update method_source: 0.9.1 → 0.9.2 (minor) Commit: 0f98b471656e59f7e5415cb47f9b67852b6d6a5a https://github.com/openSUSE/open-build-service/commit/0f98b471656e59f7e5415… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-13 (Tue, 13 Nov 2018) Changed paths: M src/api/test/functional/published_controller_test.rb Log Message: ----------- Merge pull request #6135 from Ana06/mini-docu Document published controller integration tests Commit: 46c6b8792bde98719ccdad966f7bf1656db0a01c https://github.com/openSUSE/open-build-service/commit/46c6b8792bde98719ccda… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/app/models/binary_release.rb Log Message: ----------- Merge pull request #6242 from Ana06/strptime Avoid calling strptime with an empty string Commit: b6e5d8576e9dc5003b1ef4c0cd19d633ba362ee4 https://github.com/openSUSE/open-build-service/commit/b6e5d8576e9dc5003b1ef… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/app/controllers/status/checks_controller.rb M src/api/app/controllers/status/concerns/set_checkable.rb M src/api/app/controllers/status/reports_controller.rb M src/api/app/models/event/base.rb M src/api/app/models/event/branch_command.rb M src/api/app/models/event/build_fail.rb M src/api/app/models/event/build_success.rb M src/api/app/models/event/build_unchanged.rb M src/api/app/models/event/comment_for_package.rb M src/api/app/models/event/comment_for_project.rb M src/api/app/models/event/comment_for_request.rb M src/api/app/models/event/commit.rb M src/api/app/models/event/create_package.rb M src/api/app/models/event/create_project.rb M src/api/app/models/event/delete_package.rb M src/api/app/models/event/delete_project.rb M src/api/app/models/event/packtrack.rb A src/api/app/models/event/repo_build_finished.rb M src/api/app/models/event/repo_publish_state.rb M src/api/app/models/event/repo_published.rb M src/api/app/models/event/request_change.rb M src/api/app/models/event/request_create.rb M src/api/app/models/event/request_delete.rb M src/api/app/models/event/request_statechange.rb M src/api/app/models/event/review_wanted.rb M src/api/app/models/event/service_fail.rb M src/api/app/models/event/service_success.rb A src/api/app/models/event/status_check.rb A src/api/app/models/event/status_check_for_build.rb A src/api/app/models/event/status_check_for_published.rb A src/api/app/models/event/status_check_for_request.rb M src/api/app/models/event/undelete_package.rb M src/api/app/models/event/undelete_project.rb M src/api/app/models/event/update_package.rb M src/api/app/models/event/update_project.rb M src/api/app/models/event/update_project_config.rb M src/api/app/models/event/upload.rb M src/api/app/models/event/version_change.rb M src/api/app/models/obs_factory/staging_project.rb M src/api/app/models/repository.rb M src/api/app/models/repository_architecture.rb A src/api/app/models/status/checkable.rb M src/api/app/models/status/report.rb M src/api/config/routes.rb A src/api/db/migrate/20181025152009_add_required_checks_to_repository_architecture.rb M src/api/db/structure.sql A src/api/lib/backend/api/build/repository.rb A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/build_repo_has_failed_check/returns_failed.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/build_repo_has_pending_check/returns_testing.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/build_repo_has_succeeded_check/returns_acceptable.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/has_no_checks_at_all/returns_acceptable.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/published_repo_has_failed_check/returns_failed.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/published_repo_has_failed_check_but_wrong_buildid/returns_acceptable_without_required_checks.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/published_repo_has_failed_check_but_wrong_buildid/returns_testing_with_required_checks.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/published_repo_has_pending_check/returns_testing.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/published_repo_has_succeeded_check/returns_acceptable.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/required_check_on_build_repo/returns_missing_check.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/required_check_on_published_repo/returns_missing_check.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_checks/required_check_on_standard_repo/returns_missing_check.yml A src/api/spec/cassettes/Webui_ObsFactory_StagingProjectsController/GET_show/with_a_existent_factory_staging_project/with_required_checks_on_published_repo/returns_missing_check.yml M src/api/spec/controllers/status/checks_controller_spec.rb M src/api/spec/controllers/status/reports_controller_spec.rb M src/api/spec/controllers/webui/obs_factory/staging_projects_controller_spec.rb A src/api/spec/models/event/repo_build_finished_spec.rb A src/api/spec/models/repository_architecture_spec.rb M src/backend/BSSched/Checker.pm Log Message: ----------- Merge pull request #6142 from coolo/add_unpublished_repositories Add status checks for unpublished repositories Commit: e544d15d682f3f1caa6d25485deeef8feae1abd4 https://github.com/openSUSE/open-build-service/commit/e544d15d682f3f1caa6d2… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6248 from openSUSE/depfu/update/srcapi/pry-0.12.2 [src/api] Update pry: 0.12.0 → 0.12.2 (minor) Commit: c3de4b06fd030f48c611029d76e05bf0a403b501 https://github.com/openSUSE/open-build-service/commit/c3de4b06fd030f48c6110… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/lib/rabbitmq_bus.rb Log Message: ----------- Explict reconnect to rabbitmq Technically bunny has code to recover connections, but in the code path called from exchange.publish there is no such exception handling to be found Fixes #6247 Commit: be7b23e059786a6275bc6f3e5813e5952ef617ca https://github.com/openSUSE/open-build-service/commit/be7b23e059786a6275bc6… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/backend/BSASN1.pm Log Message: ----------- [backend] BSASN1: add more unpack helpers - unpack_obj_id - unpack_utctime - unpack_gentime - unpack_tagged_implicit Commit: 9a4bd7a39c7a9cd3fcd924cf738da515a0e648c3 https://github.com/openSUSE/open-build-service/commit/9a4bd7a39c7a9cd3fcd92… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/backend/BSX509.pm Log Message: ----------- [backend] BSX509: add more certificate helpers - pack_authority_key_identifier - unpack_authority_key_identifier - pack_validity - unpack_validity - generate_key_id - oid2str - dn2str Commit: 9f26f315a03d06b7d727e1f0ae017e09d40430c6 https://github.com/openSUSE/open-build-service/commit/9f26f315a03d06b7d727e… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/backend/BSPGP.pm Log Message: ----------- [backend] BSPGP: support pk2userid to get the user id of a pubkey We'll need this to generate a cert from the project pubkey. Commit: 3ef63322236cef8d23378cac9202d807fc3f41da https://github.com/openSUSE/open-build-service/commit/3ef63322236cef8d23378… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/backend/BSPublisher/Registry.pm M src/backend/BSTUF.pm M src/backend/bs_notar M src/backend/bs_repserver Log Message: ----------- [backend] Pass a sign function instead of signargs to BSTUF This is much more versatile than passing the signargs and calling xsystem in BSTUF. Commit: 20ab38dad24d658c3c8fda95867f1f7149cd61b4 https://github.com/openSUSE/open-build-service/commit/20ab38dad24d658c3c8fd… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: A src/backend/BSSrcServer/Signkey.pm M src/backend/BSXML.pm M src/backend/bs_srcserver Log Message: ----------- [backend] split low level signkey handling into BSSrcServer::Signkey Commit: e532cc2323c5c2b5f8dfc627931ddfe2fd9565d8 https://github.com/openSUSE/open-build-service/commit/e532cc2323c5c2b5f8dfc… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/backend/BSTUF.pm Log Message: ----------- [backend] BSTUF: use new BSX509::pack_validity Commit: b9fbfb243306bf914451e11eac119ab00be54006 https://github.com/openSUSE/open-build-service/commit/b9fbfb243306bf914451e… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/backend/BSSrcServer/Signkey.pm M src/backend/BSXML.pm Log Message: ----------- [backend] also report pgp userid in pubkey info Commit: 4b90ef2d660c98d174aa3fa7c607d3c25c3b052d https://github.com/openSUSE/open-build-service/commit/4b90ef2d660c98d174aa3… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/app/models/token.rb Log Message: ----------- Avoid to create tokens with a nonexistent user Make it fail in the application level instead of in the database. Commit: 5b39440a4fccf4e5bfc8afc1bcbe1d5511084ddf https://github.com/openSUSE/open-build-service/commit/5b39440a4fccf4e5bfc8a… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/app/models/download_repository.rb M src/api/spec/models/download_repository_spec.rb Log Message: ----------- Avoid to create download repositories with a nonexistent repository Make it fail in the application level instead of in the database. Commit: ff1f3882141c385b7c9b46d775f6094e0ace4d50 https://github.com/openSUSE/open-build-service/commit/ff1f3882141c385b7c9b4… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/app/models/repository.rb M src/api/spec/models/repository_spec.rb Log Message: ----------- Avoid to create repositories with a nonexistent DbProject Make it fail in the application level instead of in the database. Commit: 55cc7f997a1bd1f236ffafdc82256b7c78c1f1d9 https://github.com/openSUSE/open-build-service/commit/55cc7f997a1bd1f236ffa… Author: Adrian Schröter <adrian(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/test/functional/source_services_test.rb Log Message: ----------- [api] support webhooks from gitlab Commit: b3ba012726200c3b1f8df91043b6849e4525c2f1 https://github.com/openSUSE/open-build-service/commit/b3ba012726200c3b1f8df… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/app/controllers/trigger_controller.rb M src/api/test/functional/source_services_test.rb Log Message: ----------- Merge pull request #6258 from adrianschroeter/gitlab [api] support webhooks from gitlab Commit: 6acb0874c84eaf06fe2d140dd927f0cb960f5651 https://github.com/openSUSE/open-build-service/commit/6acb0874c84eaf06fe2d1… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/app/helpers/maintenance_helper.rb Log Message: ----------- Merge pull request #6246 from adrianschroeter/instantiate [api] instantiate_container: only skip base links if the master packa… Commit: c2b8ee4a967f52d70d31fb5f8fc361d0f6b3d6bb https://github.com/openSUSE/open-build-service/commit/c2b8ee4a967f52d70d31f… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/app/models/download_repository.rb M src/api/app/models/repository.rb M src/api/app/models/token.rb M src/api/spec/models/download_repository_spec.rb M src/api/spec/models/repository_spec.rb Log Message: ----------- Merge pull request #6214 from Ana06/present_associations Avoid to create records referencing nonexistent objects Commit: 19dd9e151fc1968d01a9e37f6b20bd747d968e9b https://github.com/openSUSE/open-build-service/commit/19dd9e151fc1968d01a9e… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/app/models/bs_request.rb M src/api/test/functional/request_controller_test.rb Log Message: ----------- Fix permission check in BsRequest.approval_handling and testcase If I get the RequestControllerTest.test_create_request_approve_and_review testcase right, a "/request/<id>?cmd=approve" http request is only allowed if the currently logged in user has sufficient permissions to accept the request <id>. However, the login_tom # try to approve without being empowered post "/request/#{id}?cmd=approve" assert_response 403 part of the old testcase only succeeds because the submit action's target project "kde4" has the OBS:InitializeDevelPackage attribute set (the 403 is returned because "tom" has no permissions to initialize the source package as a devel package). Hence, we use the "home:fred" project as the submit action's target project. Changing this demonstrates that no "approver" specific permission checks kick in (that is, the 403 assertion will fail because status 200 is returned). Hence, we explicitly check in BsRequest.approval_handling if the currently logged in user has sufficient permissions to accept the request. A side effect of this change is that a user is only allowed to cancel an existing approval of a request (cmd=cancelapproval), if she has sufficient permissions to accept the request. Commit: e050c7417abb06a1a5c2280e4ac2cea394e4c7e7 https://github.com/openSUSE/open-build-service/commit/e050c7417abb06a1a5c22… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2018-11-14 (Wed, 14 Nov 2018) Changed paths: M src/api/app/models/bs_request_permission_check.rb M src/api/test/functional/request_controller_test.rb Log Message: ----------- Fix approver specific code in BsRequestPermissionCheck The old code in BsRequestPermissionCheck.cmd_changestate_permissions always excutes an accept permission check if the request has an approver. Consequently, the fallback rescue code in BsRequest.auto_accept never succeeds. Hence, only perform the permission checks that are required for transitioning into opts[:newstate]. Commit: 0ae4a33d0ad092938514102371afcc0d5d42456d https://github.com/openSUSE/open-build-service/commit/0ae4a33d0ad0929385141… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update codecov to version 0.1.14 Commit: dd8eb72874a48c0d8118a51ffbb390bd84150f73 https://github.com/openSUSE/open-build-service/commit/dd8eb72874a48c0d8118a… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock Log Message: ----------- Replace sass-rails with sassc-rails ruby sass is dead, partly fixing #6263 Commit: 041c28ba12a52e346c59761c68654a90c95b158e https://github.com/openSUSE/open-build-service/commit/041c28ba12a52e346c597… Author: Adrian Schröter <adrian(a)suse.de> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_permission_check.rb M src/api/test/functional/request_controller_test.rb Log Message: ----------- Merge pull request #6268 from marcus-h/request_approver_fixes Request approver fixes Commit: 5079b8deccfdc1e6402408288112c6d368ffcb7f https://github.com/openSUSE/open-build-service/commit/5079b8deccfdc1e640240… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6269 from openSUSE/depfu/update/srcapi/codecov-0.1.14 [src/api] Update codecov: 0.1.13 → 0.1.14 (minor) Commit: 371042055a4598e4dd9b405e0d7a3fe5d0c39ad6 https://github.com/openSUSE/open-build-service/commit/371042055a4598e4dd9b4… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update popper_js to version 1.14.5 Commit: 8fdb244d9c83070fad288d67679326988e8bc5a0 https://github.com/openSUSE/open-build-service/commit/8fdb244d9c83070fad288… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M dist/t/osc/0200-check_docker_registry.ts Log Message: ----------- [ci] fix bail out in 0200-check_docker_registry (2.8) * additional fix for typo in bailout message in 0200-check_docker_registry Commit: 708815fc8f1532d40c47500be06a66544f5de577 https://github.com/openSUSE/open-build-service/commit/708815fc8f1532d40c475… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6270 from openSUSE/depfu/update/srcapi/popper_js-1.14.5 [src/api] Update popper_js: 1.14.3 → 1.14.5 (patch) Commit: 6a2118231f5061ac490890cce826d0fe91c687fe https://github.com/openSUSE/open-build-service/commit/6a2118231f5061ac49089… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M src/api/app/models/event/request_create.rb Log Message: ----------- Merge pull request #6133 from bgeuken/track_request_creation Send requests creation to rabbitmq bus Commit: ac9747aeeba329fa57c187a2bbf662e8304330b9 https://github.com/openSUSE/open-build-service/commit/ac9747aeeba329fa57c18… Author: Adrian Schröter <adrian(a)suse.de> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M dist/obs-server.spec Log Message: ----------- [dist] fix service reload on SLE 12 Use sysv compatible version of all choices in the hope that this stays longer compatible for systemd macro helpers ... (on command of Rudi) Commit: 23d5c3282657ac8f3894c900fe9b16111d4eff5f https://github.com/openSUSE/open-build-service/commit/23d5c3282657ac8f3894c… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M dist/obs-server.spec Log Message: ----------- Merge pull request #6274 from adrianschroeter/systemd_sle12 [dist] fix service reload on SLE 12 Commit: 1817f6eea090416a6d6ebfea193c7636c1e9b053 https://github.com/openSUSE/open-build-service/commit/1817f6eea090416a6d6eb… Author: Adrian Schröter <adrian(a)suse.de> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M dist/t/osc/0200-check_docker_registry.ts Log Message: ----------- Merge pull request #6252 from M0ses/fix_bailout_for_28 [ci] fix bail out in 0200-check_docker_registry (2.8) Commit: 44776ac8ffc09a6f6ad257e3d8271e760a243f5b https://github.com/openSUSE/open-build-service/commit/44776ac8ffc09a6f6ad25… Author: Ruediger Oertel <ro(a)suse.de> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M dist/obs-server.spec Log Message: ----------- [dist] change owner for other logfiles of services converted to systemd Commit: 42e4845ab0b3aa1c8d5dbad18cbce45e056e296b https://github.com/openSUSE/open-build-service/commit/42e4845ab0b3aa1c8d5db… Author: Adrian Schröter <adrian(a)suse.de> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M dist/obs-server.spec Log Message: ----------- Merge pull request #6226 from bugfinder/systemd_fixes [dist] change owner for other logfiles of services converted to systemd Commit: 450d05c77ce291bbac9b4d6538af7d8bb7adeb89 https://github.com/openSUSE/open-build-service/commit/450d05c77ce291bbac9b4… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update tins to version 1.20.2 Commit: 5908a26b1a98f86b34ccf111d65b35089b00c462 https://github.com/openSUSE/open-build-service/commit/5908a26b1a98f86b34ccf… Author: Lukas Krause <lkrause(a)suse.de> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M .gitignore Log Message: ----------- Add byebug history to gitignore The byebug history should not be commited Commit: 89e509e6ee66896414ff3bc500ed3e84d334f596 https://github.com/openSUSE/open-build-service/commit/89e509e6ee66896414ff3… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M dist/obs-bundled-gems.spec Log Message: ----------- Workaround for sass/sassc-ruby#95 The library is only compiled and not moved Commit: 50715e370171623c56a0bf2d514c24ac433e00c7 https://github.com/openSUSE/open-build-service/commit/50715e370171623c56a0b… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update regexp_parser to version 1.3.0 Commit: c7c3f35adc1ce8250036e22db61ec4964c5b60f0 https://github.com/openSUSE/open-build-service/commit/c7c3f35adc1ce8250036e… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update capybara to version 3.11.0 Commit: fdd25f2d9b50a28874871023cbd17939531209a1 https://github.com/openSUSE/open-build-service/commit/fdd25f2d9b50a28874871… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-15 (Thu, 15 Nov 2018) Changed paths: M .gitignore Log Message: ----------- Merge pull request #6278 from krauselukas/gitignore_byebug Add byebug history to gitignore Commit: 25d39608df79626c7421ac55376365608eb98e1e https://github.com/openSUSE/open-build-service/commit/25d39608df79626c7421a… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-16 (Fri, 16 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6279 from openSUSE/depfu/update/srcapi/regexp_parser-1.3.0 [src/api] Update regexp_parser: 1.2.0 → 1.3.0 (minor) Commit: 4510f791f38e35f3e032485b72093effb7192939 https://github.com/openSUSE/open-build-service/commit/4510f791f38e35f3e0324… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-16 (Fri, 16 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6277 from openSUSE/depfu/update/srcapi/tins-1.20.2 [src/api] Update tins: 1.19.0 → 1.20.2 (minor) Commit: c0ba7fde972cfe1a5d503300e4fec71b23c66c3a https://github.com/openSUSE/open-build-service/commit/c0ba7fde972cfe1a5d503… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-16 (Fri, 16 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6280 from openSUSE/depfu/update/srcapi/capybara-3.11.0 [src/api] Update capybara: 3.10.1 → 3.11.0 (minor) Commit: 30fd37ac71061278cf9c43e1413bd8ea10508394 https://github.com/openSUSE/open-build-service/commit/30fd37ac71061278cf9c4… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-17 (Sat, 17 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update capybara to version 3.11.1 Commit: 188141f161be04082fd749972f753d83b9086060 https://github.com/openSUSE/open-build-service/commit/188141f161be04082fd74… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-18 (Sun, 18 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6290 from openSUSE/depfu/update/srcapi/capybara-3.11.1 [src/api] Update capybara: 3.11.0 → 3.11.1 (patch) Commit: 6fbc9039fc2aa9eac648fb8dedc63433ceaab96a https://github.com/openSUSE/open-build-service/commit/6fbc9039fc2aa9eac648f… Author: Stephan Kulow <coolo(a)suse.de> Date: 2018-11-18 (Sun, 18 Nov 2018) Changed paths: M src/api/app/models/obs_factory/staging_project.rb Log Message: ----------- Staging Projects: Prefer testing over final state failed See openSUSE/openSUSE-release-tools#1791 for potential problems Commit: 10c53a23fb95389749ba471fed9a60f0733fabe7 https://github.com/openSUSE/open-build-service/commit/10c53a23fb95389749ba4… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-18 (Sun, 18 Nov 2018) Changed paths: M src/api/app/models/obs_factory/staging_project.rb Log Message: ----------- Merge pull request #6291 from coolo/make_stagings_final Staging Projects: Prefer testing over final state failed Commit: e0dbde455967ac1fc75434741828f83356ef5bf7 https://github.com/openSUSE/open-build-service/commit/e0dbde455967ac1fc7543… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2018-11-18 (Sun, 18 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update uglifier to version 4.1.20 Commit: e396765e6f4b1d97010655d8ee7dd50485631392 https://github.com/openSUSE/open-build-service/commit/e396765e6f4b1d9701065… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-19 (Mon, 19 Nov 2018) Changed paths: M src/backend/bs_srcserver Log Message: ----------- [backend] keyinfo: do not die when checking for a default cert if donotcreatecert is set Commit: d7be0c292ac81d8d94a8de8963d1bf1f8282d023 https://github.com/openSUSE/open-build-service/commit/d7be0c292ac81d8d94a8d… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-11-19 (Mon, 19 Nov 2018) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock A src/api/config/initializers/influxdb_rails.rb M src/api/config/options.yml.example Log Message: ----------- Add influxdb-rails to collect performance metrics of the OBS rails app like * request time * view render time * db query time This information will be collection on metrics.o.o Commit: 416da40b5513f61399eb021fc63dcb4ac5f59513 https://github.com/openSUSE/open-build-service/commit/416da40b5513f61399eb0… Author: Stephan Kulow <stephan(a)kulow.org> Date: 2018-11-19 (Mon, 19 Nov 2018) Changed paths: M dist/obs-bundled-gems.spec M src/api/Gemfile M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6264 from coolo/switch_to_sassc Replace sass-rails with sassc-rails Commit: d2d7b9539d4ef556efb40cc628300597c9f1c87e https://github.com/openSUSE/open-build-service/commit/d2d7b9539d4ef556efb40… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-11-19 (Mon, 19 Nov 2018) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock A src/api/config/initializers/influxdb_rails.rb M src/api/config/options.yml.example Log Message: ----------- Merge pull request #6286 from ChrisBr/influx Add influxdb-rails Commit: 4ac4a30b3fc8a6b5a2848129e410a6a66f218bb7 https://github.com/openSUSE/open-build-service/commit/4ac4a30b3fc8a6b5a2848… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-11-19 (Mon, 19 Nov 2018) Changed paths: M src/api/lib/rabbitmq_bus.rb Log Message: ----------- Merge pull request #6251 from coolo/reconnect_amqp Explict reconnect to rabbitmq Commit: 517421d1762737e1d54bec2195aa79da56bb8831 https://github.com/openSUSE/open-build-service/commit/517421d1762737e1d54be… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-19 (Mon, 19 Nov 2018) Changed paths: M src/backend/bs_srcserver Log Message: ----------- Merge pull request #6297 from mlschroe/master [backend] keyinfo: do not die when checking for a default cert if don… Commit: 13cc549ce3e143b9c5d877417432fdb453c6ac40 https://github.com/openSUSE/open-build-service/commit/13cc549ce3e143b9c5d87… Author: Ruediger Oertel <ro(a)suse.de> Date: 2018-11-19 (Mon, 19 Nov 2018) Changed paths: M src/backend/bs_worker Log Message: ----------- [backend] bs_worker: set proper flags on power9 Commit: a11cadfea85c7dddf2c8e580df9a9b68c0cbb18d https://github.com/openSUSE/open-build-service/commit/a11cadfea85c7dddf2c8e… Author: hellcp <hellcp(a)opensuse.org> Date: 2018-11-20 (Tue, 20 Nov 2018) Changed paths: M src/api/app/assets/javascripts/webui2/cm2/toolbars.js M src/api/app/assets/javascripts/webui2/cm2/use-codemirror.js M src/api/app/assets/stylesheets/webui2/autocomplete.scss M src/api/app/assets/stylesheets/webui2/card-component.scss M src/api/app/assets/stylesheets/webui2/cm2.scss M src/api/app/assets/stylesheets/webui2/cm2/suse.scss R src/api/app/assets/stylesheets/webui2/cm2/toolbars.css M src/api/app/assets/stylesheets/webui2/colors.scss M src/api/app/assets/stylesheets/webui2/links.scss M src/api/app/assets/stylesheets/webui2/modals.scss M src/api/app/assets/stylesheets/webui2/package-attributes.scss M src/api/app/assets/stylesheets/webui2/personal-navigation.scss M src/api/app/assets/stylesheets/webui2/repositories.scss M src/api/app/assets/stylesheets/webui2/sticky-footer.scss M src/api/app/assets/stylesheets/webui2/tabs-component.scss M src/api/app/assets/stylesheets/webui2/texts.scss M src/api/app/views/layouts/webui2/webui.html.haml M src/api/app/views/webui2/shared/_editor.html.haml A src/api/app/views/webui2/shared/_editor_modal.html.haml M src/api/app/views/webui2/shared/_repositories_flag_table_column.html.haml M src/api/app/views/webui2/webui/package/_commit_item.html.haml M src/api/config/initializers/assets.rb M src/api/spec/bootstrap/features/webui/packages_spec.rb M src/api/spec/support/code_mirror.rb Log Message: ----------- Add editor in bootstrap Commit: 4e9595f85a4cdf2280f01ed69239d3cd7b20798b https://github.com/openSUSE/open-build-service/commit/4e9595f85a4cdf2280f01… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2018-11-20 (Tue, 20 Nov 2018) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #6292 from openSUSE/depfu/update/srcapi/uglifier-4.1.20 [src/api] Update uglifier: 4.1.19 → 4.1.20 (patch) Commit: eb587405f2f93bc649ed21ccbbde621bb8a78c61 https://github.com/openSUSE/open-build-service/commit/eb587405f2f93bc649ed2… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-11-20 (Tue, 20 Nov 2018) Changed paths: M src/api/config/options.yml.example Log Message: ----------- Remove protocoll from Influx example config Not needed, this is done by the SSL configuration. Commit: 7feb91d8d3de70cd4e45cd2bb0f9b38b1f603a76 https://github.com/openSUSE/open-build-service/commit/7feb91d8d3de70cd4e45c… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-20 (Tue, 20 Nov 2018) Changed paths: M src/api/config/options.yml.example Log Message: ----------- Merge pull request #6304 from ChrisBr/influx Remove protocoll from Influx example config Commit: ae3ffc6a28b31e839289e0a1bb3f8506ddf9d3be https://github.com/openSUSE/open-build-service/commit/ae3ffc6a28b31e839289e… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-11-20 (Tue, 20 Nov 2018) Changed paths: M src/api/app/assets/javascripts/webui2/cm2/toolbars.js M src/api/app/assets/javascripts/webui2/cm2/use-codemirror.js M src/api/app/assets/stylesheets/webui2/autocomplete.scss M src/api/app/assets/stylesheets/webui2/card-component.scss M src/api/app/assets/stylesheets/webui2/cm2.scss M src/api/app/assets/stylesheets/webui2/cm2/suse.scss R src/api/app/assets/stylesheets/webui2/cm2/toolbars.css M src/api/app/assets/stylesheets/webui2/colors.scss M src/api/app/assets/stylesheets/webui2/links.scss M src/api/app/assets/stylesheets/webui2/modals.scss M src/api/app/assets/stylesheets/webui2/package-attributes.scss M src/api/app/assets/stylesheets/webui2/personal-navigation.scss M src/api/app/assets/stylesheets/webui2/repositories.scss M src/api/app/assets/stylesheets/webui2/sticky-footer.scss M src/api/app/assets/stylesheets/webui2/tabs-component.scss M src/api/app/assets/stylesheets/webui2/texts.scss M src/api/app/views/layouts/webui2/webui.html.haml M src/api/app/views/webui2/shared/_editor.html.haml A src/api/app/views/webui2/shared/_editor_modal.html.haml M src/api/app/views/webui2/shared/_repositories_flag_table_column.html.haml M src/api/app/views/webui2/webui/package/_commit_item.html.haml M src/api/config/initializers/assets.rb M src/api/spec/bootstrap/features/webui/packages_spec.rb M src/api/spec/support/code_mirror.rb Log Message: ----------- Merge pull request #6293 from hellcp/editor Editor based on bootstrap Commit: 91db34a518af141ec38cc732ff60c99fb0082f5e https://github.com/openSUSE/open-build-service/commit/91db34a518af141ec38cc… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-11-20 (Tue, 20 Nov 2018) Changed paths: M src/api/app/assets/stylesheets/webui2/modals.scss Log Message: ----------- Fix long names in modal's heading Fixes #6255 Commit: 23c2cf99a6ea1d3bb5ea8d4054b7891d22b49315 https://github.com/openSUSE/open-build-service/commit/23c2cf99a6ea1d3bb5ea8… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-20 (Tue, 20 Nov 2018) Changed paths: M src/api/app/assets/stylesheets/webui2/modals.scss Log Message: ----------- Merge pull request #6298 from dmarcoux/fix-long-names-in-modal Fix long names in modal's heading Commit: 47b2cf6a6dd07712dc2212873346e47cc89ed83b https://github.com/openSUSE/open-build-service/commit/47b2cf6a6dd07712dc221… Author: Bernhard M. Wiedemann <bwiedemann(a)suse.de> Date: 2018-11-20 (Tue, 20 Nov 2018) Changed paths: M src/api/app/views/shared/_buildresult_box.html.haml M src/api/app/views/webui/kiwi/images/_build_info.html.haml M src/api/app/views/webui2/shared/_buildresult_box.html.haml Log Message: ----------- Allow use of accesskey to trigger reload Because users are often waiting for status to update and do not want to move their mouse to the tiny reload button Uses Alt-Shift-R in Linux Firefox to trigger a reload Commit: aa389f670260e9c32fe8b7e64da415eee55ca7bf https://github.com/openSUSE/open-build-service/commit/aa389f670260e9c32fe8b… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/views/shared/_buildresult_box.html.haml M src/api/app/views/webui/kiwi/images/_build_info.html.haml M src/api/app/views/webui2/shared/_buildresult_box.html.haml Log Message: ----------- Merge pull request #6318 from bmwiedemann/accesskey Allow use of accesskey to trigger reload Commit: 60e3ecee7f4853a634ef57b0637803ae74f11f45 https://github.com/openSUSE/open-build-service/commit/60e3ecee7f4853a634ef5… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/models/kiwi/image/xml_builder.rb Log Message: ----------- Add preference version only if the preference is present Fixes #6256 Commit: ad4153e3274c381878beee682ab4174dda1ca6ee https://github.com/openSUSE/open-build-service/commit/ad4153e3274c381878bee… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/models/kiwi/image/xml_parser.rb Log Message: ----------- Don't crash when the Kiwi image has no name The validation on the Kiwi::Image model will deal accordingly with the name not being present and display an error to the user. Fixes #6306 Commit: eba2d3cf534d85386bf1bd688f059e7fd6ecbb11 https://github.com/openSUSE/open-build-service/commit/eba2d3cf534d85386bf1b… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/models/kiwi/image/xml_builder.rb M src/api/app/models/kiwi/image/xml_parser.rb Log Message: ----------- Merge pull request #6321 from dmarcoux/fix-kiwi-editor-errors Fix kiwi editor errors Commit: 437136d3ad84568a33a1a5bc02570f47a263e145 https://github.com/openSUSE/open-build-service/commit/437136d3ad84568a33a1a… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/backend/bs_worker Log Message: ----------- Merge pull request #6182 from bugfinder/add_power9 [backend] Add power9 detection to bs_worker Commit: 6cccb2f2bb5aeadc8c56ea8792ddc3193e9fe008 https://github.com/openSUSE/open-build-service/commit/6cccb2f2bb5aeadc8c56e… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/backend/BSSSL.pm Log Message: ----------- Merge pull request #6157 from bugfinder/use_chain_in_BSSSL [backend] BSSSL.pm: replace CTX_use_certificate_file by CTX_use_certi… Commit: a4bc081fec668b5706f10d6e7e7e4f69ae0dda44 https://github.com/openSUSE/open-build-service/commit/a4bc081fec668b5706f10… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/backend/bs_repserver Log Message: ----------- [backend] extend_timestamp: do not call BSTUF::rfc3339time Commit: ff0e26f7222c8ff883670231dd6f2469273afbb9 https://github.com/openSUSE/open-build-service/commit/ff0e26f7222c8ff883670… Author: Michael Schroeder <mls(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/backend/bs_repserver Log Message: ----------- Merge pull request #6326 from mlschroe/master [backend] extend_timestamp: do not call BSTUF::rfc3339time Commit: 356b43fe19a6b0ef9b833db7b4d9b05f34184355 https://github.com/openSUSE/open-build-service/commit/356b43fe19a6b0ef9b833… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M .gitignore M dist/obs-bundled-gems.spec M dist/obs-server.spec M dist/t/osc/0200-check_docker_registry.ts M src/api/Gemfile M src/api/Gemfile.lock M src/api/app/assets/javascripts/webui2/cm2/toolbars.js M src/api/app/assets/javascripts/webui2/cm2/use-codemirror.js M src/api/app/assets/stylesheets/webui2/autocomplete.scss M src/api/app/assets/stylesheets/webui2/card-component.scss M src/api/app/assets/stylesheets/webui2/cm2.scss M src/api/app/assets/stylesheets/webui2/cm2/suse.scss R src/api/app/assets/stylesheets/webui2/cm2/toolbars.css M src/api/app/assets/stylesheets/webui2/colors.scss M src/api/app/assets/stylesheets/webui2/links.scss M src/api/app/assets/stylesheets/webui2/modals.scss M src/api/app/assets/stylesheets/webui2/package-attributes.scss M src/api/app/assets/stylesheets/webui2/personal-navigation.scss M src/api/app/assets/stylesheets/webui2/repositories.scss M src/api/app/assets/stylesheets/webui2/sticky-footer.scss M src/api/app/assets/stylesheets/webui2/tabs-component.scss M src/api/app/assets/stylesheets/webui2/texts.scss M src/api/app/controllers/trigger_controller.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_permission_check.rb M src/api/app/models/download_repository.rb M src/api/app/models/event/request_create.rb M src/api/app/models/kiwi/image/xml_builder.rb M src/api/app/models/kiwi/image/xml_parser.rb M src/api/app/models/obs_factory/staging_project.rb M src/api/app/models/repository.rb M src/api/app/models/token.rb M src/api/app/views/layouts/webui2/webui.html.haml M src/api/app/views/shared/_buildresult_box.html.haml M src/api/app/views/webui/kiwi/images/_build_info.html.haml M src/api/app/views/webui2/shared/_buildresult_box.html.haml M src/api/app/views/webui2/shared/_editor.html.haml A src/api/app/views/webui2/shared/_editor_modal.html.haml M src/api/app/views/webui2/shared/_repositories_flag_table_column.html.haml M src/api/app/views/webui2/webui/package/_commit_item.html.haml M src/api/config/initializers/assets.rb A src/api/config/initializers/influxdb_rails.rb M src/api/config/options.yml.example M src/api/lib/rabbitmq_bus.rb M src/api/spec/bootstrap/features/webui/packages_spec.rb M src/api/spec/models/download_repository_spec.rb M src/api/spec/models/repository_spec.rb M src/api/spec/support/code_mirror.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/source_services_test.rb M src/backend/BSASN1.pm M src/backend/BSPGP.pm M src/backend/BSPublisher/Registry.pm M src/backend/BSSSL.pm A src/backend/BSSrcServer/Signkey.pm M src/backend/BSTUF.pm M src/backend/BSX509.pm M src/backend/BSXML.pm M src/backend/bs_notar M src/backend/bs_repserver M src/backend/bs_srcserver M src/backend/bs_worker Log Message: ----------- Merge branch 'master' into staging-workflow-with-master * master: (101 commits) [backend] extend_timestamp: do not call BSTUF::rfc3339time Don't crash when the Kiwi image has no name Add preference version only if the preference is present Allow use of accesskey to trigger reload Fix long names in modal's heading Remove protocoll from Influx example config Add editor in bootstrap [backend] bs_worker: set proper flags on power9 Add influxdb-rails [backend] keyinfo: do not die when checking for a default cert if donotcreatecert is set Update uglifier to version 4.1.20 Staging Projects: Prefer testing over final state failed Update capybara to version 3.11.1 Update capybara to version 3.11.0 Update regexp_parser to version 1.3.0 Workaround for sass/sassc-ruby#95 Add byebug history to gitignore Update tins to version 1.20.2 [dist] change owner for other logfiles of services converted to systemd [dist] fix service reload on SLE 12 ... Commit: 0d2048e605dbd6ba895c9ea6529e63e334650a4b https://github.com/openSUSE/open-build-service/commit/0d2048e605dbd6ba895c9… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/test/functional/request_controller_test.rb Log Message: ----------- Remove duplicated method This method, and the commit it belongs to, appeared twice after merging master into the staging-workflow branch. The first time this commit got added was with the previous master merge (#6250). There was a small difference between both methods. I removed the one that differed from the one we have in master. Commit: e2ee1e07a1fb444b887318d3ef8708ea50c28d8d https://github.com/openSUSE/open-build-service/commit/e2ee1e07a1fb444b88731… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M .gitignore M dist/obs-bundled-gems.spec M dist/obs-server.spec M dist/t/osc/0200-check_docker_registry.ts M src/api/Gemfile M src/api/Gemfile.lock M src/api/app/assets/javascripts/webui2/cm2/toolbars.js M src/api/app/assets/javascripts/webui2/cm2/use-codemirror.js M src/api/app/assets/stylesheets/webui2/autocomplete.scss M src/api/app/assets/stylesheets/webui2/card-component.scss M src/api/app/assets/stylesheets/webui2/cm2.scss M src/api/app/assets/stylesheets/webui2/cm2/suse.scss R src/api/app/assets/stylesheets/webui2/cm2/toolbars.css M src/api/app/assets/stylesheets/webui2/colors.scss M src/api/app/assets/stylesheets/webui2/links.scss M src/api/app/assets/stylesheets/webui2/modals.scss M src/api/app/assets/stylesheets/webui2/package-attributes.scss M src/api/app/assets/stylesheets/webui2/personal-navigation.scss M src/api/app/assets/stylesheets/webui2/repositories.scss M src/api/app/assets/stylesheets/webui2/sticky-footer.scss M src/api/app/assets/stylesheets/webui2/tabs-component.scss M src/api/app/assets/stylesheets/webui2/texts.scss M src/api/app/controllers/trigger_controller.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_permission_check.rb M src/api/app/models/download_repository.rb M src/api/app/models/event/request_create.rb M src/api/app/models/kiwi/image/xml_builder.rb M src/api/app/models/kiwi/image/xml_parser.rb M src/api/app/models/obs_factory/staging_project.rb M src/api/app/models/repository.rb M src/api/app/models/token.rb M src/api/app/views/layouts/webui2/webui.html.haml M src/api/app/views/shared/_buildresult_box.html.haml M src/api/app/views/webui/kiwi/images/_build_info.html.haml M src/api/app/views/webui2/shared/_buildresult_box.html.haml M src/api/app/views/webui2/shared/_editor.html.haml A src/api/app/views/webui2/shared/_editor_modal.html.haml M src/api/app/views/webui2/shared/_repositories_flag_table_column.html.haml M src/api/app/views/webui2/webui/package/_commit_item.html.haml M src/api/config/initializers/assets.rb A src/api/config/initializers/influxdb_rails.rb M src/api/config/options.yml.example M src/api/lib/rabbitmq_bus.rb M src/api/spec/bootstrap/features/webui/packages_spec.rb M src/api/spec/models/download_repository_spec.rb M src/api/spec/models/repository_spec.rb M src/api/spec/support/code_mirror.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/source_services_test.rb M src/backend/BSASN1.pm M src/backend/BSPGP.pm M src/backend/BSPublisher/Registry.pm M src/backend/BSSSL.pm A src/backend/BSSrcServer/Signkey.pm M src/backend/BSTUF.pm M src/backend/BSX509.pm M src/backend/BSXML.pm M src/backend/bs_notar M src/backend/bs_repserver M src/backend/bs_srcserver M src/backend/bs_worker Log Message: ----------- Merge pull request #6329 from bgeuken/staging-workflow-with-master Merge master into staging workflow branch Compare: https://github.com/openSUSE/open-build-service/compare/53eb602d6fd3...e2ee1… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] d0cf40: OpenQA takes the correct qcow2 filename
by David Kang 21 Nov '18

21 Nov '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d0cf40f581cf5159e21aee45ea9ab42bda768f69 https://github.com/openSUSE/open-build-service/commit/d0cf40f581cf5159e21ae… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M dist/schedule-obs.sh Log Message: ----------- OpenQA takes the correct qcow2 filename OpenQA was failing because it was taken the wrong image name. It was taking files ending in "*.packages" instead of "*.qcow2". Now we ensure that it takes only those files ending in ".qcow2" (extracting from href attibute). Co-authored-by: David Kang <dkang(a)suse.com> Commit: 79570c42f7d4b58a7fca0d7ccc4ddf691b2e1b2c https://github.com/openSUSE/open-build-service/commit/79570c42f7d4b58a7fca0… Author: David Kang <dkang(a)suse.com> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M dist/schedule-obs.sh Log Message: ----------- Merge pull request #6335 from saraycp/openqa_qcow2_wrong_filename OpenQA takes the correct qcow2 filename Compare: https://github.com/openSUSE/open-build-service/compare/ff0e26f7222c...79570… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] c345bb: Drop staging identifier
by Björn Geuken 21 Nov '18

21 Nov '18

Branch: refs/heads/staging-workflow Home: https://github.com/openSUSE/open-build-service Commit: c345bb5a27b1093b596fe39da08ae76a46283db1 https://github.com/openSUSE/open-build-service/commit/c345bb5a27b1093b596fe… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/models/staging/staging_project.rb M src/api/app/views/webui2/webui/staging/workflows/_empty_projects_list.html.haml M src/api/app/views/webui2/webui/staging/workflows/_overall_state.html.haml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_failed_checks/1_3_5_1.yml R src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_failed_checks/1_4_5_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_missing_checks/1_3_3_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_pending_checks/1_3_4_1.yml M src/api/spec/models/staging/staging_project_spec.rb Log Message: ----------- Drop staging identifier As result of a discussion related to #6308 we decided to drop the identifier, since there is no fixed naming scheme we could rely on. Commit: 53eb602d6fd336c94ba00ae3022450a080617bda https://github.com/openSUSE/open-build-service/commit/53eb602d6fd336c94ba00… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/models/staging/staging_project.rb M src/api/app/views/webui2/webui/staging/workflows/_empty_projects_list.html.haml M src/api/app/views/webui2/webui/staging/workflows/_overall_state.html.haml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_failed_checks/1_3_5_1.yml R src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_failed_checks/1_4_5_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_missing_checks/1_3_3_1.yml A src/api/spec/cassettes/Staging_StagingProject/_overall_state/when_there_are_pending_checks/1_3_4_1.yml M src/api/spec/models/staging/staging_project_spec.rb Log Message: ----------- Merge pull request #6333 from bgeuken/drop_staging_identifier Drop staging identifier Compare: https://github.com/openSUSE/open-build-service/compare/b6e9035a9880...53eb6… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 2f7be2: Create method for failing status checks
by Lukas Krause 21 Nov '18

21 Nov '18

Branch: refs/heads/staging-workflow Home: https://github.com/openSUSE/open-build-service Commit: 2f7be24f055a3bc6664cf7b4fb666d255e250ada https://github.com/openSUSE/open-build-service/commit/2f7be24f055a3bc6664cf… Author: Lukas Krause <lkrause(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/models/staging/staging_project.rb M src/api/app/models/status/check.rb Log Message: ----------- Create method for failing status checks In order to show the status check problems, they need to be fetched from the status api Co-authored-by: Christian Bruckmayer <cbruckmayer(a)suse.com> Commit: 4bc518cd1a89cdf08c95e824e984c930a830660d https://github.com/openSUSE/open-build-service/commit/4bc518cd1a89cdf08c95e… Author: Lukas Krause <lkrause(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: A src/api/app/views/webui2/webui/staging/workflows/_build_problems.html.haml M src/api/app/views/webui2/webui/staging/workflows/_problems.html.haml R src/api/app/views/webui2/webui/staging/workflows/_problems_item.html.haml A src/api/app/views/webui2/webui/staging/workflows/_status_problems.html.haml Log Message: ----------- List status problems in staging project page Besides the build problems, the status problems must be shown as well Co-authored-by: Ana María Martínez Gómez <ammartinez(a)suse.de> Commit: b6e9035a98808181b7f62c68a00e525a3ab93a4b https://github.com/openSUSE/open-build-service/commit/b6e9035a98808181b7f62… Author: Lukas Krause <lkrause(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/models/staging/staging_project.rb M src/api/app/models/status/check.rb A src/api/app/views/webui2/webui/staging/workflows/_build_problems.html.haml M src/api/app/views/webui2/webui/staging/workflows/_problems.html.haml R src/api/app/views/webui2/webui/staging/workflows/_problems_item.html.haml A src/api/app/views/webui2/webui/staging/workflows/_status_problems.html.haml Log Message: ----------- Merge pull request #6315 from krauselukas/feature/staging/problems_openqa Show status problems in staging project problems column Compare: https://github.com/openSUSE/open-build-service/compare/27928a6a5f95...b6e90… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 147026: Empty project link to staging project instead of p...
by Björn Geuken 21 Nov '18

21 Nov '18

Branch: refs/heads/staging-workflow Home: https://github.com/openSUSE/open-build-service Commit: 147026063e8f031299f9544d1a2be615f2933757 https://github.com/openSUSE/open-build-service/commit/147026063e8f031299f95… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/views/webui2/webui/staging/workflows/_empty_projects_list.html.haml M src/api/app/views/webui2/webui/staging/workflows/_infos.html.haml Log Message: ----------- Empty project link to staging project instead of project Inside Infos box there is a list of Empty Projects. In the old UI they pointed to the project show page. We consider they should point to the staging project instead. Commit: 27928a6a5f95b12f998ee6a485d35a54d4896c4e https://github.com/openSUSE/open-build-service/commit/27928a6a5f95b12f998ee… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/views/webui2/webui/staging/workflows/_empty_projects_list.html.haml M src/api/app/views/webui2/webui/staging/workflows/_infos.html.haml Log Message: ----------- Merge pull request #6332 from saraycp/empty_projects_links Empty project link to staging project instead of project Compare: https://github.com/openSUSE/open-build-service/compare/974e2fce9723...27928… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 7b615c: Put user provided id in apostrophes
by Henne Vogelsang 21 Nov '18

21 Nov '18

Branch: refs/heads/staging-workflow Home: https://github.com/openSUSE/open-build-service Commit: 7b615c1ba71fc8a92984d79f870284cbf2b22449 https://github.com/openSUSE/open-build-service/commit/7b615c1ba71fc8a92984d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-11-20 (Tue, 20 Nov 2018) Changed paths: M src/api/app/controllers/staging/staged_requests_controller.rb Log Message: ----------- Put user provided id in apostrophes It's a tiny change, but it makes it much clearer that OBS wasn't able to fetch the id. Before: <status code="invalid_request"> <summary>Could not assign requests to home:Admin:Staging:A.</summary> </status> After: <status code="invalid_request"> <summary>Could not assign requests '' to home:Admin:Staging:A.</summary> </status> Commit: 974e2fce972369e454b07462ebe2b143dc705c01 https://github.com/openSUSE/open-build-service/commit/974e2fce972369e454b07… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/controllers/staging/staged_requests_controller.rb Log Message: ----------- Merge pull request #6317 from bgeuken/update_error_messages_in_xml_response Put user provided request number in apostrophes Compare: https://github.com/openSUSE/open-build-service/compare/9bdbfea9a640...974e2… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 580157: Make it clearer that managers are a group
by Henne Vogelsang 21 Nov '18

21 Nov '18

Branch: refs/heads/staging-workflow Home: https://github.com/openSUSE/open-build-service Commit: 580157555f74dfc7f06551b9e235ef8dae49d5ef https://github.com/openSUSE/open-build-service/commit/580157555f74dfc7f0655… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/views/webui2/webui/staging/workflows/new.html.haml Log Message: ----------- Make it clearer that managers are a group Also use the right tag for a paragraph Commit: 319744d569d2da9b0fa47c3cb6d6e9931ffedbbc https://github.com/openSUSE/open-build-service/commit/319744d569d2da9b0fa47… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/controllers/webui/staging/workflows_controller.rb M src/api/spec/controllers/webui/staging/workflows_controller_spec.rb Log Message: ----------- Deal with non-existent managers group We need to use `redirect_to` instead of `render` as otherwise, the value of `action_name` is `create` instead of `new`. This would bring a lot of issues in the rendering of the breadcrumbs. Fixes #6313 Commit: 779ebf12b49a7b0b6378bdd281516c637ba1011b https://github.com/openSUSE/open-build-service/commit/779ebf12b49a7b0b6378b… Author: Dany Marcoux <danymarcoux(a)gmail.com> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/views/webui2/webui/staging/workflows/new.html.haml Log Message: ----------- Add note for creation of managers groups Commit: 9bdbfea9a640a9f6236ade7bcba706438e2de425 https://github.com/openSUSE/open-build-service/commit/9bdbfea9a640a9f6236ad… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-11-21 (Wed, 21 Nov 2018) Changed paths: M src/api/app/controllers/webui/staging/workflows_controller.rb M src/api/app/views/webui2/webui/staging/workflows/new.html.haml M src/api/spec/controllers/webui/staging/workflows_controller_spec.rb Log Message: ----------- Merge pull request #6324 from dmarcoux/staging-workflow-managers-group-improvements Staging workflow managers group improvements Compare: https://github.com/openSUSE/open-build-service/compare/44c3b436ab7c...9bdbf… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0