October 2018 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 35e650: Apply same css classes to code tag
by Christian Bruckmayer 02 Oct '18

02 Oct '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 35e650a9f3815ecf290407e6e17ec214c7e7705d https://github.com/openSUSE/open-build-service/commit/35e650a9f3815ecf29040… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/assets/stylesheets/webui2/comments.scss Log Message: ----------- Apply same css classes to code tag In the comments we also create code tags when using ` ticks so we also need to apply the same CSS classes to the code tag. Commit: dede5ebab7ffe044648ca0a583161cad022e5de2 https://github.com/openSUSE/open-build-service/commit/dede5ebab7ffe044648ca… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/webui2/webui/comment/_content.html.haml Log Message: ----------- Hide user icon for XS displays To ident the comments we use bootstraps media object. However, on small screens the indentation does not make sense as the input field gets smaller and smaller. Therefore we just disable the indentation on XS screens. This is done by applying the bootstrap display CSS classes to the user image. Fix #5981. Commit: a0ea4dbbe1b45d4c6736e31f5fbda522a9d49842 https://github.com/openSUSE/open-build-service/commit/a0ea4dbbe1b45d4c6736e… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/webui2/webui/comment/_content.html.haml Log Message: ----------- Swap unless with if statement because it is easier to understand than a negation when just checking smaller / greater than. Commit: 121458faac002e2306dbe148e38254bbaf9eceb5 https://github.com/openSUSE/open-build-service/commit/121458faac002e2306dbe… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/assets/stylesheets/webui2/comments.scss M src/api/app/views/webui2/webui/comment/_content.html.haml Log Message: ----------- Merge pull request #5997 from ChrisBr/bootstrap/comments Fix several bootstrap issues for comments Compare: https://github.com/openSUSE/open-build-service/compare/f33af95fc9d0...12145… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 385361: Hide overflow of long filenames in upload label
by Christian Bruckmayer 02 Oct '18

02 Oct '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3853615c36103ba85cccba4c2066d0375a7353c0 https://github.com/openSUSE/open-build-service/commit/3853615c36103ba85cccb… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/assets/javascripts/webui2/forms.js M src/api/app/assets/stylesheets/webui2/cm2.scss M src/api/app/views/webui2/webui/package/add_file.html.haml Log Message: ----------- Hide overflow of long filenames in upload label When the filename is really long, the input / label broke into next line. For now we just hide the overlfow which is fine for the upload input field. Fix #5979 Commit: dea50675cfbf5187c1c1b295148b1e9537205761 https://github.com/openSUSE/open-build-service/commit/dea50675cfbf5187c1c1b… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/assets/javascripts/webui2/packages.js M src/api/app/views/webui2/webui/package/add_file.html.haml Log Message: ----------- Fix package add file validations The JS validation did not take into account when there was already another input field with a value. Before it just set the required tag on all input fields when the value was empty. This was not correct as it could happen that there is already another input field with a value. In this case we don't need to change the required tag at all and just leave it like it is. Fix #5980. Commit: f33af95fc9d0d8a789dff80e905f5da6c17ef34e https://github.com/openSUSE/open-build-service/commit/f33af95fc9d0d8a789dff… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/assets/javascripts/webui2/forms.js M src/api/app/assets/javascripts/webui2/packages.js M src/api/app/assets/stylesheets/webui2/cm2.scss M src/api/app/views/webui2/webui/package/add_file.html.haml Log Message: ----------- Merge pull request #5991 from ChrisBr/bootstrap/file-upload-bugs Fix several file upload issues Compare: https://github.com/openSUSE/open-build-service/compare/54342dd6840b...f33af… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] c1373f: Remove obsapidelayed SysV init script
by Henne Vogelsang 02 Oct '18

02 Oct '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c1373fc7206e355aea3ecf51b8ee9ab4ff8f9b8b https://github.com/openSUSE/open-build-service/commit/c1373fc7206e355aea3ec… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-09-14 (Fri, 14 Sep 2018) Changed paths: M dist/Makefile M dist/obs-server.spec R dist/obsapidelayed Log Message: ----------- Remove obsapidelayed SysV init script It will be migrated to systemd units. Commit: 9b7b38ce96a35e82876ef235086d4d5f1ef2a83a https://github.com/openSUSE/open-build-service/commit/9b7b38ce96a35e82876ef… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M dist/Makefile M dist/obs-server.spec A dist/systemd/obs-api-support.target A dist/systemd/obs-clockwork.service A dist/systemd/obs-delayedjob-queue-consistency_check.service A dist/systemd/obs-delayedjob-queue-default.service A dist/systemd/obs-delayedjob-queue-issuetracking.service A dist/systemd/obs-delayedjob-queue-mailers.service A dist/systemd/obs-delayedjob-queue-project_log_rotate.service A dist/systemd/obs-delayedjob-queue-quick@.service A dist/systemd/obs-delayedjob-queue-releasetracking.service A dist/systemd/obs-sphinx.service R dist/systemd/obsapidelayed.service Log Message: ----------- Add obs-api-support.target and services Move obsapidelayed to a systemd implementation. SysV init scripts are deprecated. Co-authored-by: Victor Pereira <vpereira(a)suse.com> Commit: a8da1401aef42c3d13c653beab176d2ff6f4ab1c https://github.com/openSUSE/open-build-service/commit/a8da1401aef42c3d13c65… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M dist/setup-appliance.sh Log Message: ----------- Adapt setup-appliance.sh for working with targets Introduce obs-api-support.target as a unit to be checked. Modify the setup-appliance.sh script accordingly to be able to check for both types of systemd units: services and targets. Commit: 0aa0ae819941a8aa32f24ce4eadba0bf583eaed8 https://github.com/openSUSE/open-build-service/commit/0aa0ae819941a8aa32f24… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M dist/t/0060-check_required_services.ts Log Message: ----------- Adapt test for working with targets Introduce obs-api-support.target unit to be checked by the tests. Adapt the test to work with both systemd types of unit: services and targets. Commit: 8e185cffe2c82c3ca1ad1465f713faf9583bf6ec https://github.com/openSUSE/open-build-service/commit/8e185cffe2c82c3ca1ad1… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M dist/README.UPDATERS Log Message: ----------- Update documentation for obs-api-support.target obsapidelayed script got removed in favor of obs-api-support. Commit: 710cd0fe48bb4a63212dee17a3fcb8b2bcdf6cbe https://github.com/openSUSE/open-build-service/commit/710cd0fe48bb4a63212de… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M dist/obs-server.spec Log Message: ----------- Stop API support scripts when upgrading from SysV ... and enable and start API support systemd scripts. This way API support scripts upgrade from SysV to systemd. Commit: 54342dd6840b787a63ec1d69865d865f953cc3f0 https://github.com/openSUSE/open-build-service/commit/54342dd6840b787a63ec1… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M dist/Makefile M dist/README.UPDATERS M dist/obs-server.spec R dist/obsapidelayed M dist/setup-appliance.sh A dist/systemd/obs-api-support.target A dist/systemd/obs-clockwork.service A dist/systemd/obs-delayedjob-queue-consistency_check.service A dist/systemd/obs-delayedjob-queue-default.service A dist/systemd/obs-delayedjob-queue-issuetracking.service A dist/systemd/obs-delayedjob-queue-mailers.service A dist/systemd/obs-delayedjob-queue-project_log_rotate.service A dist/systemd/obs-delayedjob-queue-quick@.service A dist/systemd/obs-delayedjob-queue-releasetracking.service A dist/systemd/obs-sphinx.service R dist/systemd/obsapidelayed.service M dist/t/0060-check_required_services.ts Log Message: ----------- Merge pull request #5660 from eduardoj/systemd Switch obsapidelayed jobs script to systemd Compare: https://github.com/openSUSE/open-build-service/compare/c051c2ea14f4...54342… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 1d0558: Fix the attributes table in mobile size
by Moisés Déniz Alemán 02 Oct '18

02 Oct '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1d055899f1e0edfa57c03d59364aceeed1ec5193 https://github.com/openSUSE/open-build-service/commit/1d055899f1e0edfa57c03… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/assets/javascripts/webui2/attributes.js M src/api/app/views/webui2/webui/attribute/index.html.haml Log Message: ----------- Fix the attributes table in mobile size Before the table was using basic responsive style adding horizontal scrolls and now is using datatables to hide the columns Commit: c051c2ea14f49d34b8f2abb26d0b1ad6bb5177b6 https://github.com/openSUSE/open-build-service/commit/c051c2ea14f49d34b8f2a… Author: Moisés Déniz Alemán <mdeniz(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/assets/javascripts/webui2/attributes.js M src/api/app/views/webui2/webui/attribute/index.html.haml Log Message: ----------- Merge pull request #5993 from mdeniz/bootstrap/fix_attributes_table_on_mobile Fix the attributes table in mobile size Compare: https://github.com/openSUSE/open-build-service/compare/aaa12089afd0...c051c… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] c78c8a: Fix burger menu and show breadcrumbs in mobile
by Henne Vogelsang 02 Oct '18

02 Oct '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c78c8af5ab8183104a47989e13d207863d57c4ab https://github.com/openSUSE/open-build-service/commit/c78c8af5ab8183104a479… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/layouts/webui2/_navigation.html.haml M src/api/app/views/layouts/webui2/_search.html.haml R src/api/app/views/layouts/webui2/_watchlist.html.haml M src/api/app/views/layouts/webui2/webui.html.haml Log Message: ----------- Fix burger menu and show breadcrumbs in mobile Before we had different watchlist views depending on the size of the device, for mobile was broken. Now we only use one single watchlist component. The breadcrumbs was missing in mobile now is shown normally. The personal navigation was shown in the burger menu badly, now is shown in the same way as in big screen devices. Commit: aaa12089afd0e29e75552a49f8aad913fbfbd2d8 https://github.com/openSUSE/open-build-service/commit/aaa12089afd0e29e75552… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/layouts/webui2/_navigation.html.haml M src/api/app/views/layouts/webui2/_search.html.haml R src/api/app/views/layouts/webui2/_watchlist.html.haml M src/api/app/views/layouts/webui2/webui.html.haml Log Message: ----------- Merge pull request #5996 from mdeniz/bootstrap/fix_top_right_links_gaps Fix burger menu and show breadcrumbs in mobile Compare: https://github.com/openSUSE/open-build-service/compare/ea8377f6ae46...aaa12… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] f2df84: Do not show 'View file' link for special files
by Christian Bruckmayer 02 Oct '18

02 Oct '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f2df843cb9ccc8959cde224ccb1701682f3efd5f https://github.com/openSUSE/open-build-service/commit/f2df843cb9ccc8959cde2… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/webui2/webui/package/_revision_diff_detail.html.haml Log Message: ----------- Do not show 'View file' link for special files before we used a unless_link_to helper, this was c&p from the old view. However, the unless_link_to helper returns only the link text in case it evalutes to false. In this case we don't want to show the link at all anymore therefore we removed the unless_to_link helper and check for the condition before we even render the link. #5987. Commit: 4d875b6e4834f1d3d53f650cdc35b05d32d1f328 https://github.com/openSUSE/open-build-service/commit/4d875b6e4834f1d3d53f6… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/webui2/webui/package/_revision_diff_detail.html.haml Log Message: ----------- Use calculate_filename helper in revision diff This helper makes sure to also show renamed files properly. It was dropped while refactoring the view to use bootstrap. It is probably not relevant for the revision diff but for the future request diffs it is crucial. Commit: ea8377f6ae46f4c1e9eb96aae5ef7157ad3ac00d https://github.com/openSUSE/open-build-service/commit/ea8377f6ae46f4c1e9eb9… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/webui2/webui/package/_revision_diff_detail.html.haml Log Message: ----------- Merge pull request #5994 from ChrisBr/rdiff Fix several issues on the revision diff Compare: https://github.com/openSUSE/open-build-service/compare/21586cf69f37...ea837… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/obs-build] 6eb262: Only write statistics in case of a vm build
by GitHub 02 Oct '18

02 Oct '18

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 6eb2628dec56bc886a949862fc684a13ce4bfc3d https://github.com/openSUSE/obs-build/commit/6eb2628dec56bc886a949862fc684a… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M build-recipe Log Message: ----------- Only write statistics in case of a vm build According to the docs, the --statistics option is only used in case of a vm build. Additionally, without this patch we would write to a $TOPDIR/OTHER/_statistics file in the host system (in case of a non-vm build). Fixes: https://github.com/openSUSE/osc/issues/449 ("osc build creates _statistics outside chroot") Commit: 9b2787cf4cd8e48ee557ab3518d800f23daad91a https://github.com/openSUSE/obs-build/commit/9b2787cf4cd8e48ee557ab3518d800… Author: Adrian Schröter <adrian(a)suse.de> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M build-recipe Log Message: ----------- Merge pull request #467 from marcus-h/fix_statistics_dir Save the _statistics file in the $BUILD_ROOT dir Compare: https://github.com/openSUSE/obs-build/compare/ad3eba6e6d02...9b2787cf4cd8 **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/software-o-o] 81e8ea: Translated using Weblate (Russian)
by Alex Minton 02 Oct '18

02 Oct '18

Branch: refs/heads/master Home: https://github.com/openSUSE/software-o-o Commit: 81e8eae672957b06bef188ed84feea76a6fe7792 https://github.com/openSUSE/software-o-o/commit/81e8eae672957b06bef188ed84f… Author: Alex Minton <alex239(a)gmail.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M locale/ru/software.po Log Message: ----------- Translated using Weblate (Russian) Currently translated at 100.0% (209 of 209 strings) Translation: software-o-o/master Translate-URL: https://l10n.opensuse.org/projects/software-o-o/master/ru/ **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 082748: Update show icon on job history table
by Saray Cabrera Padrón 02 Oct '18

02 Oct '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 082748d511b8442948a5807b7776c881fe1d0d39 https://github.com/openSUSE/open-build-service/commit/082748d511b8442948a58… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/webui2/webui/packages/job_history/index.html.haml Log Message: ----------- Update show icon on job history table The icon size recently changed. With that change we don't need to adjust the padding of the second, stacked icon. Commit: eb0d996047fd15a49c78dad2888d85d4a91c515e https://github.com/openSUSE/open-build-service/commit/eb0d996047fd15a49c78d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/helpers/webui/packages/job_history_helper.rb M src/api/app/views/webui2/webui/packages/job_history/index.html.haml Log Message: ----------- Add colors for job history status code Commit: 21586cf69f371c9bb33580fa7864c0d81050e627 https://github.com/openSUSE/open-build-service/commit/21586cf69f371c9bb3358… Author: Saray Cabrera Padrón <scabrerapadron(a)suse.de> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/helpers/webui/packages/job_history_helper.rb M src/api/app/views/webui2/webui/packages/job_history/index.html.haml Log Message: ----------- Merge pull request #5990 from bgeuken/update_job_history_page Update job history page Compare: https://github.com/openSUSE/open-build-service/compare/033439f0bf15...21586… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0

[obs-commits] [openSUSE/open-build-service] 96c213: Add missing variable to `_binaries_action` partial
by David Kang 02 Oct '18

02 Oct '18

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 96c213d3daadf491b2d02defb8f3c51709524906 https://github.com/openSUSE/open-build-service/commit/96c213d3daadf491b2d02… Author: David Kang <dkang(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/webui2/webui/package/binaries.html.haml Log Message: ----------- Add missing variable to `_binaries_action` partial Commit: 033439f0bf15fb53e2be53228079ee3ee200f7fb https://github.com/openSUSE/open-build-service/commit/033439f0bf15fb53e2be5… Author: David Kang <dkang(a)suse.com> Date: 2018-10-02 (Tue, 02 Oct 2018) Changed paths: M src/api/app/views/webui2/webui/package/binaries.html.haml Log Message: ----------- Merge pull request #5986 from DavidKang/fix/binaries Add missing variable to `_binaries_action` partial Compare: https://github.com/openSUSE/open-build-service/compare/f10b2a202079...03343… **NOTE:** This service has been marked for deprecation: https://developer.github.com/changes/2018-04-25-github-services-deprecation/ Functionality will be removed from GitHub.com on January 31st, 2019.

1 0