September 2017 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] dcabad: [backend] getprojpack: always get rid of old multi...
by Michael Schroeder 06 Sep '17

06 Sep '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: dcabad7dc8043dad013565bb690decdf8699209c https://github.com/openSUSE/open-build-service/commit/dcabad7dc8043dad01356… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-09-06 (Wed, 06 Sep 2017) Changed paths: M src/backend/bs_srcserver Log Message: ----------- [backend] getprojpack: always get rid of old multibuild packages We did not do this if a package went from multibuild to non-multibuild leaving spurious packages behind.

1 0

[obs-commits] [openSUSE/open-build-service] 0b137e: [api] avoid an endless loop in special situations
by Henne Vogelsang 06 Sep '17

06 Sep '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0b137ea33a657b07cc7bc8fe06fd52a248275d61 https://github.com/openSUSE/open-build-service/commit/0b137ea33a657b07cc7bc… Author: Adrian Schröter <adrian(a)suse.de> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: M src/api/app/models/project.rb Log Message: ----------- [api] avoid an endless loop in special situations When multiple reuse of repositories in same project in the right order. Current code will find the new created path again and again, so we need a cycle detection here. It would be possible to simplify the code a lot, if we just could update a single entry instead, but we don't guarantee single entry for position atm. Commit: 945a2df00c94a9cc4789101dd2077c2ac064627c https://github.com/openSUSE/open-build-service/commit/945a2df00c94a9cc47891… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-09-06 (Wed, 06 Sep 2017) Changed paths: M src/api/app/models/project.rb Log Message: ----------- Merge pull request #3763 from adrianschroeter/fix_loop [api] avoid an endless loop in special situations Compare: https://github.com/openSUSE/open-build-service/compare/92f913c38fdf...945a2…

1 0

[obs-commits] [openSUSE/open-build-service] a14700: [api][webui] Fix Event creation when comment is to...
by Henne Vogelsang 06 Sep '17

06 Sep '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a14700a84c2c544bd00ae2437d3d04b9a39fdd36 https://github.com/openSUSE/open-build-service/commit/a14700a84c2c544bd00ae… Author: Evan Rolfe <evanrolfe(a)gmail.com> Date: 2017-09-01 (Fri, 01 Sep 2017) Changed paths: M src/api/app/models/event/base.rb M src/api/app/models/event/comment.rb A src/api/spec/models/event/comment_spec.rb Log Message: ----------- [api][webui] Fix Event creation when comment is too long. The max char length of comment.body is 65535 but the max char length of events.payload is also 65535. Since the payload contains the comment body and other data, its possible that the comment body will not fit in the event payload. This commit adds a callback which shortens the comment body if it is necessary to fit it in the payload. Commit: 92f913c38fdfc3e8e6a3f973034089e2f698bd08 https://github.com/openSUSE/open-build-service/commit/92f913c38fdfc3e8e6a3f… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-09-06 (Wed, 06 Sep 2017) Changed paths: M src/api/app/models/event/base.rb M src/api/app/models/event/comment.rb A src/api/spec/models/event/comment_spec.rb Log Message: ----------- Merge pull request #3740 from evanrolfe/fix/event_comment_payload_length [api][webui] Fix Event creation when comment is too long. Compare: https://github.com/openSUSE/open-build-service/compare/8db69e89e0c5...92f91…

1 0

[obs-commits] [openSUSE/open-build-service] e0254a: [api][webui] Fix LDAP login when registration=deny
by Henne Vogelsang 06 Sep '17

06 Sep '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e0254af1ed86feea5577923467805cbfdfaecac7 https://github.com/openSUSE/open-build-service/commit/e0254af1ed86feea55779… Author: Evan Rolfe <evanrolfe(a)gmail.com> Date: 2017-09-06 (Wed, 06 Sep 2017) Changed paths: M src/api/app/models/user.rb M src/api/spec/models/user_spec.rb Log Message: ----------- [api][webui] Fix LDAP login when registration=deny If you have registration set to 'deny' in the config then a user who exists in LDAP but not in the local database will not be able to login because of a check in find_with_credentials_via_ldap. This commit removes that check. Commit: 8db69e89e0c55906bfb0b8b7a6249f7da94249c2 https://github.com/openSUSE/open-build-service/commit/8db69e89e0c55906bfb0b… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-09-06 (Wed, 06 Sep 2017) Changed paths: M src/api/app/models/user.rb M src/api/spec/models/user_spec.rb Log Message: ----------- Merge pull request #3765 from evanrolfe/fix/ldap_login_registration_deny [api][webui] Fix LDAP login when registration=deny Compare: https://github.com/openSUSE/open-build-service/compare/02d9fa77c820...8db69…

1 0

[obs-commits] [openSUSE/open-build-service] 414790: [dist] Fix development environment key length
by Henne Vogelsang 05 Sep '17

05 Sep '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 414790567b42e7def0304e21caf168d02277cb10 https://github.com/openSUSE/open-build-service/commit/414790567b42e7def0304… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: M dist/obs-signd-conf.tar.bz2 Log Message: ----------- [dist] Fix development environment key length Signing stopped because the length of the key was to short. Commit: 02d9fa77c8203c52ff9c40fefb5baa44b82bed63 https://github.com/openSUSE/open-build-service/commit/02d9fa77c8203c52ff9c4… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: M dist/obs-signd-conf.tar.bz2 Log Message: ----------- Merge pull request #3760 from hennevogel/bugfix/devkey-length [dist] Fix development environment key length Compare: https://github.com/openSUSE/open-build-service/compare/61ee1275fdc6...02d9f…

1 0

[obs-commits] [openSUSE/open-build-service] 244e76: [api][webui] Fix LDAP login when registration=deny
by Henne Vogelsang 05 Sep '17

05 Sep '17

Branch: refs/heads/2.8 Home: https://github.com/openSUSE/open-build-service Commit: 244e7690b31e33bfc6bb4b75b1132deb77db5e5a https://github.com/openSUSE/open-build-service/commit/244e7690b31e33bfc6bb4… Author: Evan Rolfe <evanrolfe(a)gmail.com> Date: 2017-09-04 (Mon, 04 Sep 2017) Changed paths: M src/api/app/models/user.rb Log Message: ----------- [api][webui] Fix LDAP login when registration=deny If you have registration set to 'deny' in the config then a user who exists in LDAP but not in the local database will not be able to login because of a check in find_with_credentials_via_ldap. This commit removes that check. Commit: f630ab7f428a29875927d0196f52260c9d43fe43 https://github.com/openSUSE/open-build-service/commit/f630ab7f428a29875927d… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: M src/api/app/models/user.rb Log Message: ----------- Merge pull request #3750 from evanrolfe/fix/ldap_login_registration_deny [api][webui] Fix LDAP login when registration=deny Compare: https://github.com/openSUSE/open-build-service/compare/9e5665563131...f630a…

1 0

[obs-commits] [openSUSE/open-build-service] 71346a: [api][webui] Move BsRequest.collection to own clas...
by Henne Vogelsang 05 Sep '17

05 Sep '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 71346a46e24ed7b0acb219a2ad4cbec207dbb6af https://github.com/openSUSE/open-build-service/commit/71346a46e24ed7b0acb21… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: M src/api/app/controllers/request_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request/data_table/find_for_package_query.rb M src/api/app/models/bs_request/data_table/find_for_project_query.rb A src/api/app/models/bs_request/find_for/base.rb A src/api/app/models/bs_request/find_for/query.rb Log Message: ----------- [api][webui] Move BsRequest.collection to own class Refactoring to split the functionality into single classes. Commit: 33d4b78780a51797a8977b53f0f6bd77e337e809 https://github.com/openSUSE/open-build-service/commit/33d4b78780a51797a8977… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: A src/api/app/models/bs_request/find_for/group.rb M src/api/app/models/bs_request/find_for/query.rb A src/api/app/models/bs_request/find_for/user.rb A src/api/app/models/bs_request/find_for/user_group_mixin.rb Log Message: ----------- [api][webui] Move Group and User query logic to it's own classes Commit: 7ebf983a8a476066c5dc3f8809d68cbc2bdfafb9 https://github.com/openSUSE/open-build-service/commit/7ebf983a8a476066c5dc3… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: A src/api/app/models/bs_request/find_for/project.rb M src/api/app/models/bs_request/find_for/query.rb Log Message: ----------- [api][webui] Move Project query to it's own class Commit: 0461c173724d93a9fdac6799165715ac6ab63f94 https://github.com/openSUSE/open-build-service/commit/0461c173724d93a9fdac6… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: M src/api/app/controllers/request_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request/data_table/find_for_package_query.rb M src/api/app/models/bs_request/data_table/find_for_project_query.rb M src/api/app/models/bs_request/find_for/base.rb M src/api/app/models/bs_request/find_for/query.rb Log Message: ----------- [api][webui] Transform query objects to scopes because other parts of the application don't need to know about the FindFor classes. Commit: 61ee1275fdc69bf14253f41b29bc53849361a124 https://github.com/openSUSE/open-build-service/commit/61ee1275fdc69bf14253f… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: M src/api/app/controllers/request_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request/data_table/find_for_package_query.rb M src/api/app/models/bs_request/data_table/find_for_project_query.rb A src/api/app/models/bs_request/find_for/base.rb A src/api/app/models/bs_request/find_for/group.rb A src/api/app/models/bs_request/find_for/project.rb A src/api/app/models/bs_request/find_for/query.rb A src/api/app/models/bs_request/find_for/user.rb A src/api/app/models/bs_request/find_for/user_group_mixin.rb Log Message: ----------- Merge pull request #3751 from ChrisBr/refactor_bs_request_collection [api][webui] Move BsRequest.collection to own class Compare: https://github.com/openSUSE/open-build-service/compare/4baf9a9bb42a...61ee1…

1 0

[obs-commits] [openSUSE/open-build-service] 337260: [dist] Substitute tabs with spaces
by Henne Vogelsang 05 Sep '17

05 Sep '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3372604579415bafba1bae6a88732b8d00f08d7a https://github.com/openSUSE/open-build-service/commit/3372604579415bafba1ba… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2017-09-04 (Mon, 04 Sep 2017) Changed paths: M dist/obsapidelayed Log Message: ----------- [dist] Substitute tabs with spaces Commit: 701ca068511fa50ae8c6c8ecdba3c9209c1cddb2 https://github.com/openSUSE/open-build-service/commit/701ca068511fa50ae8c6c… Author: Eduardo Navarro <enavarro(a)suse.com> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: M dist/obsapidelayed M src/api/app/jobs/full_text_index_job.rb Log Message: ----------- [dist] Sphinx is started in obsapidelayed script Add starting of sphinx in the start section of obsapidelayed. Remove starting sphinx from the reindex task. Reorder tasks in clean-restart: reindex sphinx after sphinx is started. Commit: 4baf9a9bb42a8defebb6b0ec11a5860f18015459 https://github.com/openSUSE/open-build-service/commit/4baf9a9bb42a8defebb6b… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: M dist/obsapidelayed M src/api/app/jobs/full_text_index_job.rb Log Message: ----------- Merge pull request #3753 from eduardoj/start_sphinx_in_obsapidelayed Start sphinx in obsapidelayed Compare: https://github.com/openSUSE/open-build-service/compare/751f45273826...4baf9…

1 0

[obs-commits] [openSUSE/open-build-service] a0769f: [dist] Restart services in a later RPM scriptlet
by Christian Bruckmayer 05 Sep '17

05 Sep '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: a0769f44c8002d0b5b9c721779893b58dcb92a2f https://github.com/openSUSE/open-build-service/commit/a0769f44c8002d0b5b9c7… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: M dist/obs-server.spec Log Message: ----------- [dist] Restart services in a later RPM scriptlet %post runs before removal of the old package files. Rails does not know about the distinction of old/new files and will just autoload everything. %postun runs after old files are removed. Commit: 751f452738264756e1159515ab8fb44c64d7b9a8 https://github.com/openSUSE/open-build-service/commit/751f452738264756e1159… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: M dist/obs-server.spec Log Message: ----------- Merge pull request #3754 from hennevogel/bugfix/obs-api-service-restart [dist] Restart services in a later RPM scriptlet Compare: https://github.com/openSUSE/open-build-service/compare/3e8ee1855886...751f4…

1 0

[obs-commits] [openSUSE/open-build-service] f5f8a0: [webui] Fix enable revert/save button in KIWI.
by Christian Bruckmayer 05 Sep '17

05 Sep '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f5f8a061db0033e232dfbf0b192f9df3bd32000c https://github.com/openSUSE/open-build-service/commit/f5f8a061db0033e232dfb… Author: David Kang <dkang(a)suse.com> Date: 2017-09-04 (Mon, 04 Sep 2017) Changed paths: M src/api/app/assets/javascripts/webui/application/kiwi_editor.js Log Message: ----------- [webui] Fix enable revert/save button in KIWI. Now, when we change some values in a new dialog these doesn't enable by the default the revert/save button, only if we "save" the dialog. Commit: 3e8ee185588687f7f6a9aa4d9dae5ca79af2a414 https://github.com/openSUSE/open-build-service/commit/3e8ee185588687f7f6a9a… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-09-05 (Tue, 05 Sep 2017) Changed paths: M src/api/app/assets/javascripts/webui/application/kiwi_editor.js Log Message: ----------- Merge pull request #3745 from DavidKang/kiwi [webui] Fix enable revert/save button in KIWI. Compare: https://github.com/openSUSE/open-build-service/compare/829321393fe1...3e8ee…

1 0