August 2017 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] e2ebcc: Fix release note entry 2.8
by Ana María Martínez Gómez 31 Aug '17

31 Aug '17

Branch: refs/heads/2.8 Home: https://github.com/openSUSE/open-build-service Commit: e2ebcc0c89bf946ddf3bd55e482dd8416f495d66 https://github.com/openSUSE/open-build-service/commit/e2ebcc0c89bf946ddf3bd… Author: Manuel Schnitzer <mschnitzer(a)suse.com> Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M ReleaseNotes-2.8 M ReleaseNotes-2.8.3 Log Message: ----------- Fix release note entry 2.8 Commit: 9e5665563131c0c3fdb903b7b049c914a043fcf6 https://github.com/openSUSE/open-build-service/commit/9e5665563131c0c3fdb90… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M ReleaseNotes-2.8 M ReleaseNotes-2.8.3 Log Message: ----------- Merge pull request #3724 from mschnitzer/update_2.8_release_notes Fix release note entry 2.8 Compare: https://github.com/openSUSE/open-build-service/compare/a5dc5a8edc08...9e566…

1 0

[obs-commits] [openSUSE/open-build-service] 817ddd: [ci] Rake task to run git-cop locally
by Ana María Martínez Gómez 31 Aug '17

31 Aug '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 817dddbea9e0f4185a1ab6aece2c7a7ab89370da https://github.com/openSUSE/open-build-service/commit/817dddbea9e0f4185a1ab… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-08-29 (Tue, 29 Aug 2017) Changed paths: M CONTRIBUTING.md A src/api/lib/tasks/git_cop.rake Log Message: ----------- [ci] Rake task to run git-cop locally Create a rake task to run git-cop and document it. Commit: 0dc6173ba017791b63a8924ddb7c53fb15d694db https://github.com/openSUSE/open-build-service/commit/0dc6173ba017791b63a89… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M CONTRIBUTING.md A src/api/lib/tasks/git_cop.rake Log Message: ----------- Merge pull request #3693 from Ana06/git-cop-task [ci] Rake task to run git-cop locally Compare: https://github.com/openSUSE/open-build-service/compare/fb96490dd890...0dc61…

1 0

[obs-commits] [openSUSE/open-build-service] 5eadf5: [webui] Render public/404 error page instead of ra...
by Manuel Schnitzer 31 Aug '17

31 Aug '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5eadf501a6eca75493459ebc944bd5e17091fa06 https://github.com/openSUSE/open-build-service/commit/5eadf501a6eca75493459… Author: Manuel Schnitzer <mschnitzer(a)suse.com> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M src/api/app/controllers/webui/webui_controller.rb Log Message: ----------- [webui] Render public/404 error page instead of raising an exception `ActionController::RoutingError` was never caught anywhere, thus we received entries in errbit. It's better to just render the public 404 page. Commit: fb96490dd89037b40e08deaa8dbcd66085111632 https://github.com/openSUSE/open-build-service/commit/fb96490dd89037b40e08d… Author: Manuel Schnitzer <github(a)mschnitzer.de> Date: 2017-08-31 (Thu, 31 Aug 2017) Changed paths: M src/api/app/controllers/webui/webui_controller.rb Log Message: ----------- Merge pull request #3710 from mschnitzer/fix_routingerror_exception [webui] Render public/404 error page instead of raising an exception Compare: https://github.com/openSUSE/open-build-service/compare/fc15964cfd8f...fb964…

1 0

[obs-commits] [openSUSE/open-build-service] c65a13: [webui] Fix cancel button in new elements
by David Kang 30 Aug '17

30 Aug '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c65a136aacf742a2c4aeaa76b3c7fdeba7f4eb30 https://github.com/openSUSE/open-build-service/commit/c65a136aacf742a2c4aea… Author: David Kang <dkang(a)suse.com> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M src/api/app/assets/javascripts/webui/application/kiwi_editor.js Log Message: ----------- [webui] Fix cancel button in new elements Now when clicking on cancel button in new elements, we delete the new record instead of hiding the dialog. Should resolve #3716. Commit: fc15964cfd8f6a8f4abad0004629192e48a4b418 https://github.com/openSUSE/open-build-service/commit/fc15964cfd8f6a8f4abad… Author: David Kang <dkang(a)suse.com> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M src/api/app/assets/javascripts/webui/application/kiwi_editor.js Log Message: ----------- Merge pull request #3722 from DavidKang/kiwi-cancel-dialog [webui] Fix cancel button in new elements Compare: https://github.com/openSUSE/open-build-service/compare/1a8693822985...fc159…

1 0

[obs-commits] [openSUSE/open-build-service] 1a8693: [backend] do not simply return if nothing to wipe
by Michael Schroeder 30 Aug '17

30 Aug '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 1a8693822985a70ed1375e744c6cfc6a92f6c22f https://github.com/openSUSE/open-build-service/commit/1a8693822985a70ed1375… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M src/backend/BSSched/EventHandler.pm Log Message: ----------- [backend] do not simply return if nothing to wipe Still do the changes marking, so that the scheduler looks at the prps and the dirty flags get cleared.

1 0

[obs-commits] [openSUSE/open-build-service] 3a95bf: [dist] Add Event stats
by Evan Rolfe 30 Aug '17

30 Aug '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3a95bf0d318e61b99b7a750b034844e821001ee5 https://github.com/openSUSE/open-build-service/commit/3a95bf0d318e61b99b7a7… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M src/api/script/delayed_job_stats.rb Log Message: ----------- [dist] Add Event stats Commit: bea5172e73c4b013e4efa47e9abd60d8456a7e4b https://github.com/openSUSE/open-build-service/commit/bea5172e73c4b013e4efa… Author: Evan Rolfe <esrolfe(a)suse.de> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M src/api/script/delayed_job_stats.rb Log Message: ----------- Merge pull request #3718 from hennevogel/feature/more_dj_stats [dist] Add Event stats Compare: https://github.com/openSUSE/open-build-service/compare/c89c2d3a2da9...bea51…

1 0

[obs-commits] [openSUSE/open-build-service] b981b1: [webui] User propper role addition
by Manuel Schnitzer 30 Aug '17

30 Aug '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b981b1a9b36d590479bdcbb33c0ccc58b17f0d85 https://github.com/openSUSE/open-build-service/commit/b981b1a9b36d590479bdc… Author: Manuel Schnitzer <mschnitzer(a)suse.com> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M src/api/app/controllers/webui/user_controller.rb M src/api/app/models/user.rb M src/api/spec/models/user_spec.rb Log Message: ----------- [webui] User propper role addition `update_globalroles` just dropped old roles. To avoid this, a new method has been added called `add_globalrole` which keeps old and adds a new one. Commit: c89c2d3a2da9b88842aadde97caaea35ae1bcf96 https://github.com/openSUSE/open-build-service/commit/c89c2d3a2da9b88842aad… Author: Manuel Schnitzer <github(a)mschnitzer.de> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M src/api/app/controllers/webui/user_controller.rb M src/api/app/models/user.rb M src/api/spec/models/user_spec.rb Log Message: ----------- Merge pull request #3719 from mschnitzer/add_globalrole [webui] User propper role addition Compare: https://github.com/openSUSE/open-build-service/compare/6eec0c2aaa22...c89c2…

1 0

[obs-commits] [openSUSE/open-build-service] b77e31: [api] Prevent dropping of global roles when making...
by Björn Geuken 30 Aug '17

30 Aug '17

Branch: refs/heads/2.8 Home: https://github.com/openSUSE/open-build-service Commit: b77e31b5d9ee8a16d73ba87fd08320caf371d5d5 https://github.com/openSUSE/open-build-service/commit/b77e31b5d9ee8a16d73ba… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M src/api/app/controllers/webui/user_controller.rb Log Message: ----------- [api] Prevent dropping of global roles when making user an admin Commit: a5dc5a8edc081682da456eb87d2d6771ffcd7e12 https://github.com/openSUSE/open-build-service/commit/a5dc5a8edc081682da456… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M src/api/app/controllers/webui/user_controller.rb Log Message: ----------- Merge pull request #3720 from bgeuken/2.8_gloabl_roles [api] Prevent dropping of global roles when making user an admin Compare: https://github.com/openSUSE/open-build-service/compare/56030dfbbce1...a5dc5…

1 0

[obs-commits] [openSUSE/open-build-service] 355684: [webui] Fix make admin link
by Björn Geuken 30 Aug '17

30 Aug '17

Branch: refs/heads/2.8 Home: https://github.com/openSUSE/open-build-service Commit: 35568435ac46bf98815d2ef1f93d1fbcd622472b https://github.com/openSUSE/open-build-service/commit/35568435ac46bf98815d2… Author: Manuel Schnitzer <mschnitzer(a)suse.com> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M ReleaseNotes-2.8 M src/api/app/controllers/webui/user_controller.rb M src/api/spec/controllers/webui/user_controller_spec.rb Log Message: ----------- [webui] Fix make admin link The `make admin` link did not work anymore. This fixes #3705 Commit: 56030dfbbce17d00618a507f065b3c78f3559f9d https://github.com/openSUSE/open-build-service/commit/56030dfbbce17d00618a5… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: M ReleaseNotes-2.8 M src/api/app/controllers/webui/user_controller.rb M src/api/spec/controllers/webui/user_controller_spec.rb Log Message: ----------- Merge pull request #3717 from mschnitzer/fix_makeadmin_link_2.8 Fix makeadmin link for 2.8 Compare: https://github.com/openSUSE/open-build-service/compare/f76945e3d125...56030…

1 0

[obs-commits] [openSUSE/open-build-service] 53466b: [ci] Drop code quality test
by Henne Vogelsang 30 Aug '17

30 Aug '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 53466b44fe66ebbc4bbea1b8da276012f0f0c8ea https://github.com/openSUSE/open-build-service/commit/53466b44fe66ebbc4bbea… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: R src/api/test/unit/code_quality_test.rb Log Message: ----------- [ci] Drop code quality test This test model contains two tests. A static ruby syntax check and a code complexity test. The static code analyzation is covered by rubocop, and our test suite. For measuring code complexity we already use codeclimate in OBS. Beside this both tests don't seem to fullfil any purpose. We know that we have very complex and ugly code in OBS. And whenever we touch it we try to improve things, if time permits. For the cases where time does not permit, we are forced to update the complexity test. In other words we ignore it. And if we actiuvely want to check out OBS code complexity, or even improve it, we are still able to fetch these data from https://codeclimate.com/github/openSUSE/open-build-service Commit: 6eec0c2aaa22e3c7c9361ebd31cd94d1b9a46787 https://github.com/openSUSE/open-build-service/commit/6eec0c2aaa22e3c7c9361… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-08-30 (Wed, 30 Aug 2017) Changed paths: R src/api/test/unit/code_quality_test.rb Log Message: ----------- Merge pull request #3713 from bgeuken/drop_code_quality_tests [ci] Drop code quality test Compare: https://github.com/openSUSE/open-build-service/compare/ca5c169033b1...6eec0…

1 0