June 2017 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] d2120c: [webui] Split reviewable polymorphic association i...
by Christian Bruckmayer 29 Jun '17

29 Jun '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d2120cd2273456adc3e65f2c46af97fc0158f02a https://github.com/openSUSE/open-build-service/commit/d2120cd2273456adc3e65… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/models/bs_request.rb M src/api/app/models/group.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/review.rb M src/api/app/models/user.rb A src/api/db/migrate/20170627111730_split_review_references.rb M src/api/db/structure.sql M src/api/spec/models/review_spec.rb M src/api/spec/models/user_spec.rb M src/api/test/fixtures/reviews.yml Log Message: ----------- [webui] Split reviewable polymorphic association into single ones We need to have seperate associations for project and package because a Project maintainer should see Reviews by_package. This was not easily possible with the polymorphic association as the review only contained the package_id and not the project_id in this case (only with extensive joining this would have been possible). Fixes #3282. Commit: 3963edfb54f401096c12f09c26f04952a723f0a8 https://github.com/openSUSE/open-build-service/commit/3963edfb54f401096c12f… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/models/bs_request.rb M src/api/app/models/group.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/app/models/review.rb M src/api/app/models/user.rb A src/api/db/migrate/20170627111730_split_review_references.rb M src/api/db/structure.sql M src/api/spec/models/review_spec.rb M src/api/spec/models/user_spec.rb M src/api/test/fixtures/reviews.yml Log Message: ----------- Merge pull request #3301 from ChrisBr/fixing_involved_reviews [webui] Split reviewable polymorphic association into single ones Compare: https://github.com/openSUSE/open-build-service/compare/f8d01acc4ff8...3963e…

1 0

[obs-commits] [openSUSE/open-build-service] 7f5205: [ci] Fix typo introduced in #3323
by Christian Bruckmayer 29 Jun '17

29 Jun '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7f5205c88af5534d5bde7bf189f85406aec21cba https://github.com/openSUSE/open-build-service/commit/7f5205c88af5534d5bde7… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/test/models/event_test.rb Log Message: ----------- [ci] Fix typo introduced in #3323 Commit: f8d01acc4ff8226345401651f0768f61f23583ee https://github.com/openSUSE/open-build-service/commit/f8d01acc4ff8226345401… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/test/models/event_test.rb Log Message: ----------- Merge pull request #3325 from hennevogel/master [ci] Fix typo introduced in #3323 Compare: https://github.com/openSUSE/open-build-service/compare/627fafdc1ed3...f8d01…

1 0

[obs-commits] [openSUSE/open-build-service] 627faf: [backend] fix check for empty projpacks query
by Michael Schroeder 29 Jun '17

29 Jun '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 627fafdc1ed30f05678776f084ad480ff207a4da https://github.com/openSUSE/open-build-service/commit/627fafdc1ed30f0567877… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/backend/BSSched/ProjPacks.pm Log Message: ----------- [backend] fix check for empty projpacks query The old check did not work when partitioning was used.

1 0

[obs-commits] [openSUSE/open-build-service] 6ef251: [webui] Flip comment and accept boxes
by Moisés Déniz Alemán 29 Jun '17

29 Jun '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6ef25105b883d7e5c7054845913b6021186b1f11 https://github.com/openSUSE/open-build-service/commit/6ef25105b883d7e5c7054… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/views/webui/comment/_new.html.haml M src/api/app/views/webui/comment/_show.html.haml M src/api/app/views/webui/request/show.html.erb Log Message: ----------- [webui] Flip comment and accept boxes on request#show view because before it was easy to oversee comments. #3184 Commit: c3d3b17be3126a369dc6174cd0eb272af855e27e https://github.com/openSUSE/open-build-service/commit/c3d3b17be3126a369dc61… Author: Moisés Déniz Alemán <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/views/webui/comment/_new.html.haml M src/api/app/views/webui/comment/_show.html.haml M src/api/app/views/webui/request/show.html.erb Log Message: ----------- Merge pull request #3321 from ChrisBr/request_show [webui] Flip comment and accept boxes Compare: https://github.com/openSUSE/open-build-service/compare/4e5ee4ede01d...c3d3b…

1 0

[obs-commits] [openSUSE/obs-build] c4ba67: Oops. fixed syntax error.
by GitHub 29 Jun '17

29 Jun '17

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: c4ba67aeebbc983294b07e49b8e38deb74a787d2 https://github.com/openSUSE/obs-build/commit/c4ba67aeebbc983294b07e49b8e38d… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M Build/Kiwi.pm Log Message: ----------- Oops. fixed syntax error.

1 0

[obs-commits] [openSUSE/open-build-service] 65bb85: [backend] timeout for services
by Frank Schreiner 29 Jun '17

29 Jun '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 65bb8584f9d364fa1ae5b4472983af07e8538012 https://github.com/openSUSE/open-build-service/commit/65bb8584f9d364fa1ae5b… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2017-06-28 (Wed, 28 Jun 2017) Changed paths: M src/backend/BSConfiguration.pm M src/backend/bs_service M src/backend/bs_servicedispatch Log Message: ----------- [backend] timeout for services Without this patch hanging services will run forever and the service dispatcher will perodically retry the service until the maximum of running service is reeached. This patch sets an configurable alarm (default 3600 sec) for services to finish, otherwise the child process gets killed and an error 500 is returned. The same configurable timeout is now used in bs_servicedispatch. SEE ALSO https://github.com/openSUSE/open-build-service/issues/3214 Commit: 4e5ee4ede01d099dec8af3cdd9f85cbf996ed2c7 https://github.com/openSUSE/open-build-service/commit/4e5ee4ede01d099dec8af… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/backend/BSConfiguration.pm M src/backend/bs_service M src/backend/bs_servicedispatch Log Message: ----------- Merge pull request #3226 from M0ses/timeout_for_services [backend] timeout for services Compare: https://github.com/openSUSE/open-build-service/compare/6660282afbad...4e5ee…

1 0

[obs-commits] [openSUSE/open-build-service] 04e26c: [webui][api] RSS Feed for users notifications
by Evan Rolfe 29 Jun '17

29 Jun '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 04e26cb573f5ba18d326a952d221808697b37007 https://github.com/openSUSE/open-build-service/commit/04e26cb573f5ba18d326a… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/models/user.rb A src/api/app/views/webui/feeds/notifications.rss.builder M src/api/config/routes.rb Log Message: ----------- [webui][api] RSS Feed for users notifications Commit: 7bcbfc6b2a1332bff9ecaac9bbbcb475247cda26 https://github.com/openSUSE/open-build-service/commit/7bcbfc6b2a1332bff9eca… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/views/layouts/webui/webui.html.erb M src/api/app/views/webui/user/show.html.haml Log Message: ----------- [webui] Links to the RSS feed for user's notifications Commit: c4d5c1e9f145323cc4813972b7f5b9041333eaa0 https://github.com/openSUSE/open-build-service/commit/c4d5c1e9f145323cc4813… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/jobs/send_event_emails.rb M src/api/app/models/notifications/base.rb M src/api/app/models/notifications/rss_feed_item.rb M src/api/app/views/event_mailer/_actions.text.erb M src/api/app/views/event_mailer/request_create.text.erb M src/api/app/views/event_mailer/request_statechange.text.erb M src/api/app/views/event_mailer/review_wanted.text.erb M src/api/app/views/webui/feeds/notifications.rss.builder M src/api/spec/jobs/send_event_emails_spec.rb Log Message: ----------- [webui][api] Refactor SendEventEmails job Better creation of RSS notifications Fix partial views inclusion not to fail when used outside the EventMailer Remove unneeded ivars in feeds controller Commit: b86aa65d43ebc92bf35ab389171e428b2fd846b5 https://github.com/openSUSE/open-build-service/commit/b86aa65d43ebc92bf35ab… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/test/fixtures/event_mailer/repo_delete_request M src/api/test/fixtures/event_mailer/request_event M src/api/test/fixtures/event_mailer/set_bugowner_event M src/api/test/fixtures/event_mailer/tom_gets_mail_too Log Message: ----------- [ci] Fix fixtures for event mailer after refactoring templates Commit: 0520e670189f2c582a3b87c837b7819137537da9 https://github.com/openSUSE/open-build-service/commit/0520e670189f2c582a3b8… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/models/notifications/rss_feed_item.rb Log Message: ----------- [api][webui] Refactor cleanup of notifications to use offset instead of slice Commit: a03c95399e0c2126d875310b6e90327f6ede5bd5 https://github.com/openSUSE/open-build-service/commit/a03c95399e0c2126d8753… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/jobs/cleanup_notifications.rb M src/api/app/jobs/send_event_emails.rb M src/api/app/models/group.rb A src/api/app/models/notification.rb A src/api/app/models/notification/rss_feed_item.rb R src/api/app/models/notifications/base.rb R src/api/app/models/notifications/rss_feed_item.rb M src/api/app/models/user.rb A src/api/db/migrate/20170619111734_alter_notifications_to_use_polymorphic.rb M src/api/db/structure.sql M src/api/spec/factories/notification.rb M src/api/spec/jobs/send_event_emails_spec.rb M src/api/spec/models/notification_rss_feed_item.rb A src/api/spec/models/notification_spec.rb M src/api/spec/models/user_spec.rb Log Message: ----------- [api][webui] Use a polymorphic relationship in Notifications Commit: 300ff932a2fee7eeb775cfae9cee23c9d11340b4 https://github.com/openSUSE/open-build-service/commit/300ff932a2fee7eeb775c… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/controllers/person_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/models/event_subscription.rb M src/api/app/models/package.rb M src/api/app/models/token.rb A src/api/app/models/token/rss.rb A src/api/app/models/token/service.rb M src/api/app/models/user.rb A src/api/db/migrate/20170621083718_add_st_ito_tokens.rb M src/api/db/structure.sql M src/api/test/functional/source_services_test.rb Log Message: ----------- [api][webui][ci] Token class now have subclasses Commit: 3d50a84e17414a480d62138b01cdfd680a65e443 https://github.com/openSUSE/open-build-service/commit/3d50a84e17414a480d621… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/views/layouts/webui/webui.html.erb M src/api/config/routes.rb Log Message: ----------- [webui] Consume RSS feeds using a token Commit: b6d7f70941aea1f39783ad61c10b5b03731ff06a https://github.com/openSUSE/open-build-service/commit/b6d7f70941aea1f39783a… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: A src/api/app/controllers/webui/users/rss_tokens_controller.rb M src/api/app/views/webui/user/show.html.haml M src/api/app/views/webui/users/subscriptions/index.html.haml M src/api/config/routes.rb Log Message: ----------- [webui] Allow user to generate RSS feed tokens Commit: 40b208043d8387b190a0335fcb5d92da42ff5fbd https://github.com/openSUSE/open-build-service/commit/40b208043d8387b190a03… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/spec/controllers/webui/feeds_controller_spec.rb Log Message: ----------- [ci] Add specs for FeedsController#notifications Commit: 4bb2d59dca4a19b65d26dea1cf04a12be7230694 https://github.com/openSUSE/open-build-service/commit/4bb2d59dca4a19b65d26d… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: A src/api/spec/controllers/webui/users/rss_token_controller_spec.rb Log Message: ----------- [ci] Specs for RssTokenController Commit: bc22d50fcaf73454db730c4e5145f541d2318012 https://github.com/openSUSE/open-build-service/commit/bc22d50fcaf73454db730… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/spec/factories/notification.rb R src/api/spec/models/notification_rss_feed_item.rb A src/api/spec/models/notifications/rss_feed_item.rb Log Message: ----------- [ci] Refactor Notifications::RssFeedItem specs Commit: 0c4bc95a6afde65e6d70ec13a17d86a2e65572c0 https://github.com/openSUSE/open-build-service/commit/0c4bc95a6afde65e6d70e… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: A src/api/spec/models/notification/rss_feed_item_spec.rb R src/api/spec/models/notifications/rss_feed_item.rb Log Message: ----------- [ci] Add specs for RssFeedItem #title and #description Commit: b023cb1b5606609aee4530710e48578838236ca1 https://github.com/openSUSE/open-build-service/commit/b023cb1b5606609aee453… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M ReleaseNotes-2.9 Log Message: ----------- [doc] Add RSS feature to ReleaseNotes Commit: 19880d61d36e544be98584586dec60b81915bfb6 https://github.com/openSUSE/open-build-service/commit/19880d61d36e544be9858… Author: Moises Deniz Aleman <mdeniz(a)suse.com> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/test/fixtures/events.yml Log Message: ----------- [ci] Fix fixtures for events removing some keys from payload Commit: a1e23a6c4d1822646281a42bac9a452493112cbe https://github.com/openSUSE/open-build-service/commit/a1e23a6c4d1822646281a… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/models/notification/rss_feed_item.rb M src/api/app/views/webui/feeds/notifications.rss.builder M src/api/spec/models/notification/rss_feed_item_spec.rb Log Message: ----------- [frontend] EventMailer views now use locals Commit: 03622a07b7a3a74466ced9cef1ddea48e2d059d8 https://github.com/openSUSE/open-build-service/commit/03622a07b7a3a74466ced… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/models/notification/rss_feed_item.rb M src/api/app/views/webui/feeds/notifications.rss.builder M src/api/spec/models/notification/rss_feed_item_spec.rb Log Message: ----------- [webui] Don't render in the description in Notification::RssFeedItem Do it in the notification rss builder instead. Commit: e61f5abb421e083d70445dd6e000df071619781c https://github.com/openSUSE/open-build-service/commit/e61f5abb421e083d70445… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/spec/controllers/webui/feeds_controller_spec.rb Log Message: ----------- [ci] Test rendering of Notification::RssFeedItem Commit: 6660282afbadf649c3982ff9f820cd5149173327 https://github.com/openSUSE/open-build-service/commit/6660282afbadf649c3982… Author: Evan Rolfe <esrolfe(a)suse.de> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M ReleaseNotes-2.9 M src/api/app/controllers/person_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/feeds_controller.rb A src/api/app/controllers/webui/users/rss_tokens_controller.rb M src/api/app/jobs/cleanup_notifications.rb M src/api/app/jobs/send_event_emails.rb M src/api/app/models/event_subscription.rb M src/api/app/models/group.rb A src/api/app/models/notification.rb A src/api/app/models/notification/rss_feed_item.rb R src/api/app/models/notifications/base.rb R src/api/app/models/notifications/rss_feed_item.rb M src/api/app/models/package.rb M src/api/app/models/token.rb A src/api/app/models/token/rss.rb A src/api/app/models/token/service.rb M src/api/app/models/user.rb M src/api/app/views/event_mailer/_actions.text.erb M src/api/app/views/event_mailer/request_create.text.erb M src/api/app/views/event_mailer/request_statechange.text.erb M src/api/app/views/event_mailer/review_wanted.text.erb M src/api/app/views/layouts/webui/webui.html.erb A src/api/app/views/webui/feeds/notifications.rss.builder M src/api/app/views/webui/user/show.html.haml M src/api/app/views/webui/users/subscriptions/index.html.haml M src/api/config/routes.rb A src/api/db/migrate/20170619111734_alter_notifications_to_use_polymorphic.rb A src/api/db/migrate/20170621083718_add_st_ito_tokens.rb M src/api/db/structure.sql M src/api/spec/controllers/webui/feeds_controller_spec.rb A src/api/spec/controllers/webui/users/rss_token_controller_spec.rb M src/api/spec/factories/notification.rb M src/api/spec/jobs/send_event_emails_spec.rb A src/api/spec/models/notification/rss_feed_item_spec.rb R src/api/spec/models/notification_rss_feed_item.rb A src/api/spec/models/notification_spec.rb M src/api/spec/models/user_spec.rb M src/api/test/fixtures/event_mailer/repo_delete_request M src/api/test/fixtures/event_mailer/request_event M src/api/test/fixtures/event_mailer/set_bugowner_event M src/api/test/fixtures/event_mailer/tom_gets_mail_too M src/api/test/fixtures/events.yml M src/api/test/functional/source_services_test.rb Log Message: ----------- Merge pull request #3248 from mdeniz/rss_notifications_ui Rss Notifications Compare: https://github.com/openSUSE/open-build-service/compare/eca42ca9825b...66602…

1 0

[obs-commits] [openSUSE/osc] ffe68f: Check whether project_dir points to a project wc (...
by Marcus Huewe 29 Jun '17

29 Jun '17

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: ffe68fd9f4fb4ff8a35fd03d1b28481225fcab28 https://github.com/openSUSE/osc/commit/ffe68fd9f4fb4ff8a35fd03d1b28481225fc… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M osc/commandline.py Log Message: ----------- Check whether project_dir points to a project wc (in do_importsrcpkg) If we abort early, the user gets a more meaningful error message. Fixes: #301 ("Inconsistent working copy") Commit: c9dfe03a46571a011cc30de8f6a6b3c6bd0f0c68 https://github.com/openSUSE/osc/commit/c9dfe03a46571a011cc30de8f6a6b3c6bd0f… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M osc/core.py Log Message: ----------- Use the correct path in core.createPackageDir The old implementation only worked, if cwd was a project working copy (even in this case, it may did the wrong thing...). Compare: https://github.com/openSUSE/osc/compare/a8612f4ecc71...c9dfe03a4657

1 0

[obs-commits] [openSUSE/open-build-service] 9994df: [frontend] Do not delete Events with unsent mails
by Henne Vogelsang 29 Jun '17

29 Jun '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9994dfc83318d6ccd875fc33c4985a7578cbc43c https://github.com/openSUSE/open-build-service/commit/9994dfc83318d6ccd875f… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/jobs/cleanup_events.rb M src/api/test/models/event_test.rb Log Message: ----------- [frontend] Do not delete Events with unsent mails Commit: eca42ca9825b4db6204d6604915489089836b5d9 https://github.com/openSUSE/open-build-service/commit/eca42ca9825b4db6204d6… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/api/app/jobs/cleanup_events.rb M src/api/test/models/event_test.rb Log Message: ----------- Merge pull request #3323 from mschnitzer/bugfix_cleanup_events_test_fix [frontend] Do not delete Events with unsent mails [tests fixed] Compare: https://github.com/openSUSE/open-build-service/compare/67a4f0ad8d55...eca42…

1 0

[obs-commits] [openSUSE/open-build-service] 67a4f0: [backend] add notifypackagechange command for proj...
by Michael Schroeder 29 Jun '17

29 Jun '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 67a4f0ad8d55c9db8bf8422c4baf7c36e1d2a6ee https://github.com/openSUSE/open-build-service/commit/67a4f0ad8d55c9db8bf84… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-06-29 (Thu, 29 Jun 2017) Changed paths: M src/backend/bs_srcserver Log Message: ----------- [backend] add notifypackagechange command for projects This will do a deepcheck on the project.

1 0