Open Build Service Commits

Download

obs-commits@lists.opensuse.org

April 2017

20 participants
141 discussions

[obs-commits] [openSUSE/open-build-service] 228079: [api] Validate uniqueness of bs request actions
by Björn Geuken 03 Apr '17

03 Apr '17

Branch: refs/heads/avoid_double_release_ Home: https://github.com/openSUSE/open-build-service Commit: 22807938cd5a59659f88750adb80bbfd2fdacfa3 https://github.com/openSUSE/open-build-service/commit/22807938cd5a59659f887… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/app/models/bs_request_action.rb Log Message: ----------- [api] Validate uniqueness of bs request actions Commit: 6f91e03b4965e2609098663620d13e91b4469075 https://github.com/openSUSE/open-build-service/commit/6f91e03b4965e26090986… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/spec/models/bs_request_spec.rb Log Message: ----------- [ci] Fix naming of BsRequest spec Commit: bc8aea786e698f6851063f572a3cf5e7a9abd37d https://github.com/openSUSE/open-build-service/commit/bc8aea786e698f6851063… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/spec/models/bs_request_action_spec.rb Log Message: ----------- [ci] Add uniqueness validation for bs request actions Using the inbuild rspec validation test helper didn't work, because of the association ot BsRequestType named 'type'. ===== 1) BsRequestAction validates uniquness of type among bs requests Failure/Error: type_to_class_name(type_name.to_sym) || super ActiveRecord::SubclassNotFound: The single-table inheritance mechanism failed to locate the subclass: 'an arbitrary value'. This error is raised because the column 'type' is reserved for storing the class in case of inheritance. Please rename this column if you didn't intend it to be used for storing the inheritance class or overwrite BsRequestAction.inheritance_column to use another column for that information. # ./app/models/bs_request_action.rb:87:in `find_sti_class' # ./spec/models/bs_request_action_spec.rb:7:in `block (2 levels) in <top (required)>' # ./spec/support/logging.rb:4:in `block (2 levels) in <top (required)>' # ------------------ # --- Caused by: --- # NameError: # wrong constant name an arbitrary value # ./app/models/bs_request_action.rb:87:in `find_sti_class' Compare: https://github.com/openSUSE/open-build-service/compare/22807938cd5a^...bc8a…

1 0

Jump to page: