April 2017 - Open Build Service Commits

[obs-commits] [openSUSE/obs-build] 0ec4e9: Simplify test setup
by GitHub 04 Apr '17

04 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 0ec4e96d533715ef1e008812a7e0b1746d492396 https://github.com/openSUSE/obs-build/commit/0ec4e96d533715ef1e008812a7e0b1… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M Build.pm M t/conflicts.repo M t/conflicts.t M t/requires.repo M t/requires.t M t/richdeps.repo M t/richdeps.t A t/testlib.pm Log Message: ----------- Simplify test setup

1 0

[obs-commits] [openSUSE/obs-build] db2595: Make choice error deterministic
by GitHub 04 Apr '17

04 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: db2595b9e6e1d49064239815f2e261589221cbbe https://github.com/openSUSE/obs-build/commit/db2595b9e6e1d49064239815f2e261… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M Build.pm Log Message: ----------- Make choice error deterministic Commit: 66d3e516cadefc3a1213c834988a43a33c0a2a39 https://github.com/openSUSE/obs-build/commit/66d3e516cadefc3a1213c834988a43… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: A t/conflicts.repo A t/conflicts.t A t/requires.repo A t/requires.t Log Message: ----------- Add more tests Compare: https://github.com/openSUSE/obs-build/compare/3a0a4e0eaf74...66d3e516cade

1 0

[obs-commits] [openSUSE/open-build-service] 7350d7: [api] Make maintenance statistics route public
by Björn Geuken 04 Apr '17

04 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7350d752cba1ae684396ac2ef08e37e5a7cb3de2 https://github.com/openSUSE/open-build-service/commit/7350d752cba1ae684396a… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M src/api/app/controllers/statistics/maintenance_statistics_controller.rb M src/api/config/routes.rb M src/api/spec/controllers/statistics/maintenance_statistics_controller_spec.rb Log Message: ----------- [api] Make maintenance statistics route public We need to handle connections between OBS instances (interconnects). This is one way to do it. The other one would be to handle authentication between OBS instances. Commit: 78b89937912e37705c309ff4d4e6f21c4b968bea https://github.com/openSUSE/open-build-service/commit/78b89937912e37705c309… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M src/api/app/controllers/statistics/maintenance_statistics_controller.rb M src/api/spec/controllers/statistics/maintenance_statistics_controller_spec.rb Log Message: ----------- [api] Handle maintenance statistics requests for remotes Forward maintenance statistics requests to remote instance and respond with the received xml. If the response is empty, the remote project didn't exist and we respond with a 404. We don't do a redirect here, since we want to be consistent with the other places where we have to handle remote instances. Commit: 0523386ff6cf2e0e2f86619c88c810643e13b0f3 https://github.com/openSUSE/open-build-service/commit/0523386ff6cf2e0e2f866… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M src/api/app/controllers/statistics/maintenance_statistics_controller.rb M src/api/config/routes.rb M src/api/spec/controllers/statistics/maintenance_statistics_controller_spec.rb Log Message: ----------- Merge pull request #2915 from bgeuken/maintenance_stats_ Maintenance stats for remote projects Compare: https://github.com/openSUSE/open-build-service/compare/658f1e9f717f...05233…

1 0

[obs-commits] [openSUSE/open-build-service] aa99ad: [api] Validate uniqueness of bs request actions
by Henne Vogelsang 04 Apr '17

04 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: aa99adb3b9426597d1cb289c89998465a8d27102 https://github.com/openSUSE/open-build-service/commit/aa99adb3b9426597d1cb2… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/app/models/bs_request_action.rb Log Message: ----------- [api] Validate uniqueness of bs request actions Commit: 23d9e23799ada1d24eca252094b6f307d3949932 https://github.com/openSUSE/open-build-service/commit/23d9e23799ada1d24eca2… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/spec/models/bs_request_spec.rb Log Message: ----------- [ci] Fix naming of BsRequest spec Commit: 08aacbc2cfb29a102c6e051921d04e4d27f3eca1 https://github.com/openSUSE/open-build-service/commit/08aacbc2cfb29a102c6e0… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/spec/models/bs_request_action_spec.rb Log Message: ----------- [ci] Add uniqueness validation for bs request actions Using the inbuild rspec validation test helper didn't work, because of the association ot BsRequestType named 'type'. ===== 1) BsRequestAction validates uniquness of type among bs requests Failure/Error: type_to_class_name(type_name.to_sym) || super ActiveRecord::SubclassNotFound: The single-table inheritance mechanism failed to locate the subclass: 'an arbitrary value'. This error is raised because the column 'type' is reserved for storing the class in case of inheritance. Please rename this column if you didn't intend it to be used for storing the inheritance class or overwrite BsRequestAction.inheritance_column to use another column for that information. # ./app/models/bs_request_action.rb:87:in `find_sti_class' # ./spec/models/bs_request_action_spec.rb:7:in `block (2 levels) in <top (required)>' # ./spec/support/logging.rb:4:in `block (2 levels) in <top (required)>' # ------------------ # --- Caused by: --- # NameError: # wrong constant name an arbitrary value # ./app/models/bs_request_action.rb:87:in `find_sti_class' Commit: 658f1e9f717fe55664cbe057d8b381cbc0f2a4b6 https://github.com/openSUSE/open-build-service/commit/658f1e9f717fe55664cbe… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M src/api/app/models/bs_request_action.rb M src/api/spec/models/bs_request_action_spec.rb M src/api/spec/models/bs_request_spec.rb Log Message: ----------- Merge pull request #2916 from bgeuken/avoid_double_release_ Avoid double release Compare: https://github.com/openSUSE/open-build-service/compare/e40b9b1e0815...658f1…

1 0

[obs-commits] [openSUSE/open-build-service] e8878e: [webui] Add peek status bar
by Henne Vogelsang 04 Apr '17

04 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e8878e7f24f2bbb15f7185ece3ee98e241d76276 https://github.com/openSUSE/open-build-service/commit/e8878e7f24f2bbb15f718… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock M src/api/app/assets/javascripts/webui/application.js.erb M src/api/app/assets/stylesheets/webui/application.css.erb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/models/user.rb M src/api/app/views/layouts/webui/webui.html.erb M src/api/config/environments/development.rb A src/api/config/initializers/peek.rb M src/api/config/routes.rb M src/api/db/seeds.rb Log Message: ----------- [webui] Add peek status bar to profile SQL and memcache. https://github.com/peek/peek. Commit: e40b9b1e0815fd664362396887a1d7ebc06b3315 https://github.com/openSUSE/open-build-service/commit/e40b9b1e0815fd6643623… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock M src/api/app/assets/javascripts/webui/application.js.erb M src/api/app/assets/stylesheets/webui/application.css.erb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/models/user.rb M src/api/app/views/layouts/webui/webui.html.erb M src/api/config/environments/development.rb A src/api/config/initializers/peek.rb M src/api/config/routes.rb M src/api/db/seeds.rb Log Message: ----------- Merge pull request #2922 from ChrisBr/peek [Proposal] Add peek status bar Compare: https://github.com/openSUSE/open-build-service/compare/f758f9b3aede...e40b9…

1 0

[obs-commits] [openSUSE/open-build-service] dcd324: [webui] fix wrong repository errors in monitor
by Ana María Martínez Gómez 04 Apr '17

04 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: dcd32442355bdf5bb93093b56eddc543bb961bfa https://github.com/openSUSE/open-build-service/commit/dcd32442355bdf5bb9309… Author: David Kang <dkang(a)suse.com> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/app/helpers/webui/webui_helper.rb Log Message: ----------- [webui] fix wrong repository errors in monitor Commit: f758f9b3aedef59448d7c1f2b25140d99604fa29 https://github.com/openSUSE/open-build-service/commit/f758f9b3aedef59448d7c… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M src/api/app/helpers/webui/webui_helper.rb Log Message: ----------- Merge pull request #2929 from DavidKang/fix-2907 [webui] fix wrong repository errors in monitor Compare: https://github.com/openSUSE/open-build-service/compare/23cf1b303373...f758f…

1 0

[obs-commits] [openSUSE/open-build-service] 658fb7: [api] Remove @auth_method accessor
by Evan Rolfe 04 Apr '17

04 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 658fb7cdea856caa3e3dcf59f6d7eb5efc182f78 https://github.com/openSUSE/open-build-service/commit/658fb7cdea856caa3e3dc… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M src/api/app/controllers/application_controller.rb M src/api/app/controllers/person_controller.rb M src/api/lib/authenticator.rb Log Message: ----------- [api] Remove @auth_method accessor The @auth_method variable is set on each authentification, but only used by the person controller. This commit removes (setting) the variable and instead uses a proxy_mode? helper in the persin controller. Commit: 23cf1b3033730e350feb1dad128b50caaffc2056 https://github.com/openSUSE/open-build-service/commit/23cf1b3033730e350feb1… Author: Evan Rolfe <evanrolfe(a)gmail.com> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M src/api/app/controllers/application_controller.rb M src/api/app/controllers/person_controller.rb M src/api/lib/authenticator.rb Log Message: ----------- Merge pull request #2931 from bgeuken/auth_method [api] Remove unused @auth_method accessor from application controller Compare: https://github.com/openSUSE/open-build-service/compare/d68bff010fbe...23cf1…

1 0

[obs-commits] [openSUSE/open-build-service] 64025f: [api][webui] extract authentication code to Authen...
by Björn Geuken 04 Apr '17

04 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 64025fe35f6e6759aed7b09481b5bda9985de97f https://github.com/openSUSE/open-build-service/commit/64025fe35f6e6759aed7b… Author: Evan Rolfe <evanrolfe(a)gmail.com> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M src/api/app/controllers/application_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/request_controller.rb R src/api/app/mixins/forbids_anonymous_users.rb M src/api/app/models/package.rb A src/api/lib/authenticator.rb Log Message: ----------- [api][webui] extract authentication code to Authenticator class Commit: d68bff010fbe69f89a8e8ddf13b9802d8be31912 https://github.com/openSUSE/open-build-service/commit/d68bff010fbe69f89a8e8… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-04 (Tue, 04 Apr 2017) Changed paths: M src/api/app/controllers/application_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/request_controller.rb R src/api/app/mixins/forbids_anonymous_users.rb M src/api/app/models/package.rb A src/api/lib/authenticator.rb Log Message: ----------- Merge pull request #2930 from evanrolfe/refactor/user_authentication Refactor: encapsulate authentication code into Authenticator class Compare: https://github.com/openSUSE/open-build-service/compare/615f9c5caede...d68bf…

1 0

[obs-commits] [openSUSE/obs-build] 3a0a4e: Parse rich deps from spec files
by GitHub 03 Apr '17

03 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 3a0a4e0eaf74548896921c723ab452e303560e65 https://github.com/openSUSE/obs-build/commit/3a0a4e0eaf74548896921c723ab452… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M Build/Rpm.pm Log Message: ----------- Parse rich deps from spec files

1 0

[obs-commits] [openSUSE/obs-build] 88493a: Add provider filtering with rich conflict dependen...
by GitHub 03 Apr '17

03 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 88493a4e994e1e87b616cd4af6bc8cd78656bf5d https://github.com/openSUSE/obs-build/commit/88493a4e994e1e87b616cd4af6bc8c… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M Build.pm M t/richdeps.repo M t/richdeps.t Log Message: ----------- Add provider filtering with rich conflict dependencies

1 0

[obs-commits] [openSUSE/obs-build] 489c02: Also test parsing of broken rich deps
by GitHub 03 Apr '17

03 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 489c02fb5dc92d60bc2e5ba950ca082ccb67c910 https://github.com/openSUSE/obs-build/commit/489c02fb5dc92d60bc2e5ba950ca08… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M Build/Rpm.pm M t/richdeps.t Log Message: ----------- Also test parsing of broken rich deps

1 0

[obs-commits] [openSUSE/open-build-service] 550ab1: [api] refactor BuildController#file in order to re...
by Henne Vogelsang 03 Apr '17

03 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 550ab1fa3977a20031f5aefa082fbddfec4a7f60 https://github.com/openSUSE/open-build-service/commit/550ab1fa3977a20031f5a… Author: Evan Rolfe <evanrolfe(a)gmail.com> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: A src/api/app/controllers/build/file_controller.rb M src/api/app/controllers/build_controller.rb M src/api/config/routes.rb M src/api/test/unit/code_quality_test.rb Log Message: ----------- [api] refactor BuildController#file in order to reduce its complexity Commit: 615f9c5caedef41aec749632c000a51b0d6454c7 https://github.com/openSUSE/open-build-service/commit/615f9c5caedef41aec749… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: A src/api/app/controllers/build/file_controller.rb M src/api/app/controllers/build_controller.rb M src/api/config/routes.rb M src/api/test/unit/code_quality_test.rb Log Message: ----------- Merge pull request #2924 from evanrolfe/refactor/build_controller_file [api] refactor BuildController#file in order to reduce its complexity Compare: https://github.com/openSUSE/open-build-service/compare/f391758ec58e...615f9…

1 0

[obs-commits] [openSUSE/open-build-service] f39175: [backend] add 'donotcreatecert' option for _keyinf...
by Michael Schroeder 03 Apr '17

03 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f391758ec58e783ea3d39e30ef822456eb08fe71 https://github.com/openSUSE/open-build-service/commit/f391758ec58e783ea3d39… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/backend/bs_srcserver Log Message: ----------- [backend] add 'donotcreatecert' option for _keyinfo The UI doesn't seem to be complete without showing the ssl cert somehow.

1 0

[obs-commits] [openSUSE/obs-build] 50031a: Support rpm style rich deps in the expander
by GitHub 03 Apr '17

03 Apr '17

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 50031a65495b8132d9df1f1e80ba3f3845108205 https://github.com/openSUSE/obs-build/commit/50031a65495b8132d9df1f1e80ba3f… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M Build.pm M Build/Rpm.pm M Makefile A t/richdeps.repo A t/richdeps.t Log Message: ----------- Support rpm style rich deps in the expander

1 0

[obs-commits] [openSUSE/open-build-service]
by bgeuken 03 Apr '17

03 Apr '17

Branch: refs/heads/avoid_double_release_ Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service] 228079: [api] Validate uniqueness of bs request actions
by Björn Geuken 03 Apr '17

03 Apr '17

Branch: refs/heads/avoid_double_release_ Home: https://github.com/openSUSE/open-build-service Commit: 22807938cd5a59659f88750adb80bbfd2fdacfa3 https://github.com/openSUSE/open-build-service/commit/22807938cd5a59659f887… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/app/models/bs_request_action.rb Log Message: ----------- [api] Validate uniqueness of bs request actions Commit: 6f91e03b4965e2609098663620d13e91b4469075 https://github.com/openSUSE/open-build-service/commit/6f91e03b4965e26090986… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/spec/models/bs_request_spec.rb Log Message: ----------- [ci] Fix naming of BsRequest spec Commit: bc8aea786e698f6851063f572a3cf5e7a9abd37d https://github.com/openSUSE/open-build-service/commit/bc8aea786e698f6851063… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-04-03 (Mon, 03 Apr 2017) Changed paths: M src/api/spec/models/bs_request_action_spec.rb Log Message: ----------- [ci] Add uniqueness validation for bs request actions Using the inbuild rspec validation test helper didn't work, because of the association ot BsRequestType named 'type'. ===== 1) BsRequestAction validates uniquness of type among bs requests Failure/Error: type_to_class_name(type_name.to_sym) || super ActiveRecord::SubclassNotFound: The single-table inheritance mechanism failed to locate the subclass: 'an arbitrary value'. This error is raised because the column 'type' is reserved for storing the class in case of inheritance. Please rename this column if you didn't intend it to be used for storing the inheritance class or overwrite BsRequestAction.inheritance_column to use another column for that information. # ./app/models/bs_request_action.rb:87:in `find_sti_class' # ./spec/models/bs_request_action_spec.rb:7:in `block (2 levels) in <top (required)>' # ./spec/support/logging.rb:4:in `block (2 levels) in <top (required)>' # ------------------ # --- Caused by: --- # NameError: # wrong constant name an arbitrary value # ./app/models/bs_request_action.rb:87:in `find_sti_class' Compare: https://github.com/openSUSE/open-build-service/compare/22807938cd5a^...bc8a…

1 0