December 2017 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 6f712a: [ci] wait for publishing in docker upload test
by Frank Schreiner 11 Dec '17

11 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6f712a8c3b12afaac5765f8e3b08a3754eb0f510 https://github.com/openSUSE/open-build-service/commit/6f712a8c3b12afaac5765… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2017-11-29 (Wed, 29 Nov 2017) Changed paths: M dist/t/osc/0200-check_docker_registry.ts Log Message: ----------- [ci] wait for publishing in docker upload test Commit: 21f4ad33aec20a71da9996433b0ad66d2d0d505a https://github.com/openSUSE/open-build-service/commit/21f4ad33aec20a71da999… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2017-12-11 (Mon, 11 Dec 2017) Changed paths: M dist/t/osc/0200-check_docker_registry.ts Log Message: ----------- Merge pull request #4170 from M0ses/fix_docker_test [ci] wait for publishing in docker upload test Compare: https://github.com/openSUSE/open-build-service/compare/11c3444486d9...21f4a…

1 0

[obs-commits] [openSUSE/obs-service-source_validator]
by M0ses 11 Dec '17

11 Dec '17

Branch: refs/tags/0.9 Home: https://github.com/openSUSE/obs-service-source_validator

1 0

[obs-commits] [openSUSE/obs-service-source_validator]
by M0ses 11 Dec '17

11 Dec '17

Branch: refs/tags/0.8 Home: https://github.com/openSUSE/obs-service-source_validator

1 0

[obs-commits] [openSUSE/open-build-service] 886c5a: [api] Move ProjectLogRotate to 1 event per job
by Ana María Martínez Gómez 11 Dec '17

11 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 886c5a4715994bdb6c0bdee05c2f7d05528a5883 https://github.com/openSUSE/open-build-service/commit/886c5a4715994bdb6c0bd… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-08 (Fri, 08 Dec 2017) Changed paths: M src/api/app/jobs/project_log_rotate_job.rb M src/api/app/models/event.rb M src/api/app/models/event/base.rb M src/api/config/clock.rb Log Message: ----------- [api] Move ProjectLogRotate to 1 event per job https://trello.com/c/vOh0oyHu/619-8-p8-move-projectlogrotate-to-1-event-per… Commit: 668724d565e428ea5cf9d50c2049f72334d0fe09 https://github.com/openSUSE/open-build-service/commit/668724d565e428ea5cf9d… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-08 (Fri, 08 Dec 2017) Changed paths: A src/api/lib/tasks/project_log_rotate_manually.rake Log Message: ----------- [ci] Task for manual project log rotate job Commit: fe1198aee7dd3eeaa10c3d4dfefda1bacb7603dd https://github.com/openSUSE/open-build-service/commit/fe1198aee7dd3eeaa10c3… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-08 (Fri, 08 Dec 2017) Changed paths: M .rubocop.yml M .rubocop_todo.yml Log Message: ----------- [ci] Regenerate Rubocop todo file `Rails/SkipsModelValidations` is excluded for all jobs. As now the code to run the job manually is in a rake task, Rubocop complains, so we need to exclude it as well. There is a Rubocop bug, that's why I needed to modify the Rubocop configuration as well. Commit: d43724a17b86d10b5e7ddd54f9d303e37785f06d https://github.com/openSUSE/open-build-service/commit/d43724a17b86d10b5e7dd… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-11 (Mon, 11 Dec 2017) Changed paths: M src/api/spec/jobs/project_log_rotate_job_spec.rb Log Message: ----------- [ci] Fix test for ProjectLogRotateJob Adapt the test for the new code. Commit: ecfb04c86289ce4fbc7486fa5cb192529c04d7d5 https://github.com/openSUSE/open-build-service/commit/ecfb04c86289ce4fbc748… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-11 (Mon, 11 Dec 2017) Changed paths: A src/api/app/jobs/create_project_log_entry_job.rb R src/api/app/jobs/project_log_rotate_job.rb M src/api/app/models/event/base.rb M src/api/spec/jobs/project_log_rotate_job_spec.rb Log Message: ----------- [api] ProjectLogRotateJob -> CreateProjectLogEntry Change the job name, as it doesn't make sense any more. Commit: 676f495e9d9272e02205f10adbb89645be31f6ff https://github.com/openSUSE/open-build-service/commit/676f495e9d9272e02205f… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-11 (Mon, 11 Dec 2017) Changed paths: M src/api/lib/tasks/project_log_rotate_manually.rake M src/api/script/delayed_job_stats.rb Log Message: ----------- [api] Use PROJECT_CLASSES & PACKAGE_CLASSES Use the new `Event` contasts with the events related to `Project` and `Package` in `project_log_rotate_manually.rake` and `delayed_job_stats.rb`. This makes the code more readable und make it easy to understand. Commit: 11c3444486d9d59e8baadd8d1a349a885d3217d8 https://github.com/openSUSE/open-build-service/commit/11c3444486d9d59e8baad… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-11 (Mon, 11 Dec 2017) Changed paths: M .rubocop.yml M .rubocop_todo.yml A src/api/app/jobs/create_project_log_entry_job.rb R src/api/app/jobs/project_log_rotate_job.rb M src/api/app/models/event.rb M src/api/app/models/event/base.rb M src/api/config/clock.rb A src/api/lib/tasks/project_log_rotate_manually.rake M src/api/script/delayed_job_stats.rb M src/api/spec/jobs/project_log_rotate_job_spec.rb Log Message: ----------- Merge pull request #4197 from Ana06/project_log_rotate [api] Move ProjectLogRotate to 1 event per job Compare: https://github.com/openSUSE/open-build-service/compare/124683e80253...11c34…

1 0

[obs-commits] [openSUSE/open-build-service] 3a5d5b: [backend] fix stripping of main tar directory if t...
by Michael Schroeder 11 Dec '17

11 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3a5d5b8f6308d888846a376b828682f474973011 https://github.com/openSUSE/open-build-service/commit/3a5d5b8f6308d888846a3… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-12-11 (Mon, 11 Dec 2017) Changed paths: M src/backend/BSSrcdiff.pm Log Message: ----------- [backend] fix stripping of main tar directory if there is none Otherwise we'll end up with an empty filename that does not get stripped. Commit: 124683e80253643c5cee34ac99c1affe53c13eb3 https://github.com/openSUSE/open-build-service/commit/124683e80253643c5cee3… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-12-11 (Mon, 11 Dec 2017) Changed paths: M src/backend/BSSrcdiff.pm Log Message: ----------- [backend] also diff plain tar files Compare: https://github.com/openSUSE/open-build-service/compare/ccda0573426b...12468…

1 0

[obs-commits] [openSUSE/obs-service-source_validator] 264125: check *_source.changes if they are valid debian so...
by Frank Schreiner 11 Dec '17

11 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-service-source_validator Commit: 264125684290a522738eb5edb4b90e48490bd265 https://github.com/openSUSE/obs-service-source_validator/commit/26412568429… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2017-07-26 (Wed, 26 Jul 2017) Changed paths: M 40-sequence-changes A helpers/DebianSourceChangesValidator.pm A helpers/check_debian_source_changes M source_validator Log Message: ----------- check *_source.changes if they are valid debian source change files Without this commit all *.changes files are checked like changelog files With this commit 40-sequence-changes checks if the file is a valid debian source changes file when the filename matches *_source.changes, by searching for all mandatory keywords in the file. If it is a valid debian source changes file, further changelog checks are ommitted Fixes #42 Commit: f009de22f0533ea8bf2e7c12fd2be8953eabcf74 https://github.com/openSUSE/obs-service-source_validator/commit/f009de22f05… Author: Frank Schreiner <schreiner(a)suse.de> Date: 2017-12-11 (Mon, 11 Dec 2017) Changed paths: M 40-sequence-changes A helpers/DebianSourceChangesValidator.pm A helpers/check_debian_source_changes M source_validator Log Message: ----------- Merge pull request #48 from M0ses/fix_42 check *_source.changes if they are valid debian source change files Compare: https://github.com/openSUSE/obs-service-source_validator/compare/1e990f00f4…

1 0

[obs-commits] [openSUSE/open-build-service] b0d7d2: [api] Fix huge bottleneck in notification emails
by Ana María Martínez Gómez 11 Dec '17

11 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b0d7d263bee0b355ed2127d1660c1af1a9724c6f https://github.com/openSUSE/open-build-service/commit/b0d7d263bee0b355ed212… Author: Stephan Kulow <coolo(a)suse.de> Date: 2017-12-11 (Mon, 11 Dec 2017) Changed paths: M src/api/app/models/event/request.rb Log Message: ----------- [api] Fix huge bottleneck in notification emails The way source_watchers and target_watchers were implemented was pretty suboptimal. It took >20 seconds to dig out 128 users watching openSUSE:Factory by going through the WatchedProject objects connected to these 128 users and listed the users for these, which resulted in 128x128 SELECT user ... - but all we want is the list of 128 User objects (to filter subscriptions for them) So the new query results in one SQL statement taking the database a friction of a second Commit: ccda0573426bf6adb2f57e3b00a0ab1cb566ecb9 https://github.com/openSUSE/open-build-service/commit/ccda0573426bf6adb2f57… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-11 (Mon, 11 Dec 2017) Changed paths: M src/api/app/models/event/request.rb Log Message: ----------- Merge pull request #4200 from coolo/optimize_watcher_query Fix huge bottleneck in notification emails Compare: https://github.com/openSUSE/open-build-service/compare/4e6efd8ae499...ccda0…

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 10 Dec '17

10 Dec '17

Branch: refs/heads/depfu/update/srcapi/uglifier-4.0.1 Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/obs-build] 9cfbfb: createrepomddeps: zypp mode: do not insist on a si...
by GitHub 08 Dec '17

08 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 9cfbfb59fa6a3a03b145cae44076fd2d244a376b https://github.com/openSUSE/obs-build/commit/9cfbfb59fa6a3a03b145cae44076fd… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-12-08 (Fri, 08 Dec 2017) Changed paths: M createrepomddeps Log Message: ----------- createrepomddeps: zypp mode: do not insist on a size if there is none

1 0

[obs-commits] [openSUSE/osc] 43be8f: add meaningful error if no attribute name
by Marcus Huewe 08 Dec '17

08 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 43be8f0e9cddf9e5bc798bdbad3442dcea0b7753 https://github.com/openSUSE/osc/commit/43be8f0e9cddf9e5bc798bdbad3442dcea0b… Author: lethliel <mstrigl(a)suse.com> Date: 2017-12-08 (Fri, 08 Dec 2017) Changed paths: M osc/core.py Log Message: ----------- add meaningful error if no attribute name Commit: d79eb2580bd74df34f55898689a85041d12c63b3 https://github.com/openSUSE/osc/commit/d79eb2580bd74df34f55898689a85041d12c… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2017-12-08 (Fri, 08 Dec 2017) Changed paths: M osc/core.py Log Message: ----------- Merge branch 'error_on_invalid_xml' of https://github.com/lethliel/osc Improve error handling in Serviceinfo.read. Fixes: #360 ("improve error message if service xml is missing name attribute") Compare: https://github.com/openSUSE/osc/compare/b1d6d8347b74...d79eb2580bd7

1 0

[obs-commits] [openSUSE/open-build-service] e2ac73: [api] Split Event::Build
by Henne Vogelsang 07 Dec '17

07 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e2ac73b4b8ba995bd7eed8632690fe8d94277f04 https://github.com/openSUSE/open-build-service/commit/e2ac73b4b8ba995bd7eed… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/models/event/build.rb A src/api/app/models/event/build_fail.rb A src/api/app/models/event/build_success.rb A src/api/app/models/event/build_unchanged.rb Log Message: ----------- [api] Split Event::Build Have every `Event::Build` subclass in a different file, as it is normally done in Rails. Commit: 59c4fcb26cbb16de5708f3668b87ecfd460a7315 https://github.com/openSUSE/open-build-service/commit/59c4fcb26cbb16de5708f… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: A src/api/app/models/event/branch_command.rb M src/api/app/models/event/comment.rb A src/api/app/models/event/comment_for_package.rb A src/api/app/models/event/commit.rb A src/api/app/models/event/create_package.rb A src/api/app/models/event/delete_package.rb M src/api/app/models/event/package.rb A src/api/app/models/event/service_fail.rb A src/api/app/models/event/service_success.rb A src/api/app/models/event/undelete_package.rb A src/api/app/models/event/update_package.rb A src/api/app/models/event/upload.rb A src/api/app/models/event/version_change.rb Log Message: ----------- [api] Split Event::Package Have every `Event::Package` subclass in a different file, as it is normally done in Rails. Commit: 48d46465946e667c6fee031c08b4dcf0b0c2b9b4 https://github.com/openSUSE/open-build-service/commit/48d46465946e667c6fee0… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/models/event/comment.rb A src/api/app/models/event/comment_for_project.rb A src/api/app/models/event/create_project.rb A src/api/app/models/event/delete_project.rb M src/api/app/models/event/project.rb A src/api/app/models/event/undelete_project.rb A src/api/app/models/event/update_project.rb A src/api/app/models/event/update_project_config.rb Log Message: ----------- [api] Split Event::Project Have every `Event::Project` subclass in a different file, as it is normally done in Rails. Commit: d60d6b760b8fed9c767880e30a169cf3b76f12a1 https://github.com/openSUSE/open-build-service/commit/d60d6b760b8fed9c76788… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/models/event/comment.rb A src/api/app/models/event/comment_for_request.rb M src/api/app/models/event/request.rb A src/api/app/models/event/request_change.rb A src/api/app/models/event/request_create.rb A src/api/app/models/event/request_delete.rb A src/api/app/models/event/request_statechange.rb A src/api/app/models/event/review_wanted.rb Log Message: ----------- [api] Split Event::Request Have every `Event::Request` subclass in a different file, as it is normally done in Rails. Commit: cdfe0e101d64f248b0d035503336ff49ada8e51b https://github.com/openSUSE/open-build-service/commit/cdfe0e101d64f248b0d03… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/controllers/request_controller.rb M src/api/app/models/event.rb R src/api/app/models/event/all.rb Log Message: ----------- [api] Remove inclusion for Event subclases Now that all the classes follow Rails name convention, we do not need to include the files one by one. Remove also the `require_dependency 'event/all'` in `request_controller`. Commit: bfdf2c5946889134bf539e45bb19c4137d28e89c https://github.com/openSUSE/open-build-service/commit/bfdf2c5946889134bf539… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/models/event/factory.rb Log Message: ----------- [api] Remove ghost comment This comment was introduced in: https://github.com/openSUSE/open-build-service/commit/6589e1625b7b01ed63e4f… But the code it is commenting was removed in: https://github.com/openSUSE/open-build-service/commit/20740ef3554376745499e… But the comment was not removed. Commit: 79ace9551b4d64881596ffc59fb63d0c9299a56c https://github.com/openSUSE/open-build-service/commit/79ace9551b4d64881596f… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/controllers/source_controller.rb M src/api/app/controllers/webui/user_controller.rb M src/api/app/models/bs_request.rb M src/api/app/models/comment.rb M src/api/app/models/update_notification_events.rb M src/api/config/clock.rb M src/api/test/models/event_test.rb Log Message: ----------- [api] Remove all require event As Event module is now structure in a Rails way the requires are not longer needed. Commit: f26400814482646feff7ce02a8a5f91de3238055 https://github.com/openSUSE/open-build-service/commit/f26400814482646feff7c… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M .rubocop_todo.yml Log Message: ----------- [ci] Regenerate Rubocop todo file When moving the code into different classes the exclusion in the `rubocop_todo.yml` doesn't have effect any more. Also, we had an inclussion of a helper outside a class/module. Rubocop was not complainning before due to a bug, that is already fixed in master and will be in the next release. Regenerating the todo file solve this as well. As we need to solve this in more places, it seems to be fine to exclude it by now. Commit: e41bd74e329aaab02563518cb4b7dc57f1dffa65 https://github.com/openSUSE/open-build-service/commit/e41bd74e329aaab025635… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: R src/api/app/models/event/comment.rb A src/api/app/models/event/comment_event.rb Log Message: ----------- [api] Include CommentEvent in the Event module To allow that the classes which includes it can find it, as now we do things in the Rails way. Commit: c46bb892aa994acb8e5809a454ce08948081d9a2 https://github.com/openSUSE/open-build-service/commit/c46bb892aa994acb8e580… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/models/event/comment_for_package.rb M src/api/app/models/event/comment_for_project.rb M src/api/app/models/event/comment_for_request.rb Log Message: ----------- [api] Do not use shortcut for Comment clases Using `Event::Class` oblies us to include `CommentEvent` with an explicit namespace qualifier (`Event::CommentEvent`), because Ruby will not look inside `Event` for this name. Commit: 678410a14a0f19738928f4288f95460496ee35cb https://github.com/openSUSE/open-build-service/commit/678410a14a0f19738928f… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/models/event/build.rb M src/api/app/models/event/build_fail.rb M src/api/app/models/event/build_success.rb M src/api/app/models/event/build_unchanged.rb M src/api/app/models/event/packtrack.rb M src/api/app/models/event/repo_publish_state.rb M src/api/app/models/event/repo_published.rb M src/api/app/models/event/request.rb M src/api/app/models/event/request_change.rb M src/api/app/models/event/request_create.rb M src/api/app/models/event/request_delete.rb M src/api/app/models/event/request_statechange.rb M src/api/app/models/event/review_wanted.rb Log Message: ----------- [api] Do not use shortcut for classes definitions For consistency with the rest classes of the `Event` module. Commit: ea0a7d664584000eee1cf6532a8ba6f313e84ea9 https://github.com/openSUSE/open-build-service/commit/ea0a7d664584000eee1cf… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/models/event/branch_command.rb M src/api/app/models/event/build_fail.rb M src/api/app/models/event/build_success.rb M src/api/app/models/event/build_unchanged.rb M src/api/app/models/event/comment_for_package.rb M src/api/app/models/event/comment_for_project.rb M src/api/app/models/event/comment_for_request.rb M src/api/app/models/event/commit.rb M src/api/app/models/event/create_package.rb M src/api/app/models/event/create_project.rb M src/api/app/models/event/delete_package.rb M src/api/app/models/event/delete_project.rb M src/api/app/models/event/package.rb M src/api/app/models/event/project.rb M src/api/app/models/event/request_change.rb M src/api/app/models/event/request_create.rb M src/api/app/models/event/request_delete.rb M src/api/app/models/event/request_statechange.rb M src/api/app/models/event/service_fail.rb M src/api/app/models/event/service_success.rb M src/api/app/models/event/undelete_package.rb M src/api/app/models/event/undelete_project.rb M src/api/app/models/event/update_package.rb M src/api/app/models/event/update_project.rb M src/api/app/models/event/update_project_config.rb M src/api/app/models/event/upload.rb M src/api/app/models/event/version_change.rb Log Message: ----------- [api] Add schema information for all new classes And now that we are following Rails way, they are correct! Commit: ee7a10972628377e4827ce0f449cb52a3ec11967 https://github.com/openSUSE/open-build-service/commit/ee7a10972628377e4827c… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/models/event/branch_command.rb M src/api/app/models/event/build.rb M src/api/app/models/event/comment_for_package.rb M src/api/app/models/event/commit.rb M src/api/app/models/event/create_package.rb M src/api/app/models/event/delete_package.rb R src/api/app/models/event/package.rb M src/api/app/models/event/service_fail.rb M src/api/app/models/event/service_success.rb M src/api/app/models/event/undelete_package.rb M src/api/app/models/event/update_package.rb M src/api/app/models/event/upload.rb M src/api/app/models/event/version_change.rb Log Message: ----------- [api] Remove Event::Package `Event::Package` is a class with almost nothing that is used as superclass for: - `Event::BranchCommand` - `Event::Build` - `Event::CommentForPackage` - `Event::Commit` - `Event::CreatePackage` - `Event::DeletePackage` - `Event::ServiceFail` - `Event::ServiceSuccess` - `Event::UndeletePackage` - `Event::UpdatePackage` - `Event::Upload` - `Event::VersionChange` The `Event::Package` causes problem as we also have a `Package` model in the root level. So once one of the two packages models is loaded, Rails doens't look for the second one, which lead to uses of the wrong model. To avoid that Rails uses the `Package` in the root level in `Event::Package` subclasses we can call the Package specifying the module. But for the other case there is nothing we can do. This is all caused because we shouldn't have models with repeated names even if they are in different levels. As the `Event::Package` is useless, we can just remove it and add its data directly to the subclasses. Commit: a571bb9b3dbab4a9890174f6f554202f2f04928b https://github.com/openSUSE/open-build-service/commit/a571bb9b3dbab4a989017… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/models/event/comment_for_project.rb M src/api/app/models/event/create_project.rb M src/api/app/models/event/delete_project.rb R src/api/app/models/event/project.rb M src/api/app/models/event/undelete_project.rb M src/api/app/models/event/update_project.rb M src/api/app/models/event/update_project_config.rb Log Message: ----------- [api] Remove Event::Project `Event::Package` is a class with almost nothing that is used as superclass for: - `Event::CommentForProject` - `Event::CreateProject` - `Event::DeleteProject` - `Event::UndeleteProject` - `Event::UpdateProjectConfig` - `Event::UpdateProject` The `Event::Project` causes problem as we also have a `Project` model in the root level. So once one of the two projects models is loaded, Rails doens't look for the second one, which lead to uses of the wrong model. To avoid that Rails uses the `Project` in the root level in `Event::Project` subclasses we can call the Project specifying the module. But for the other case there is nothing we can do. This is all caused because we shouldn't have models with repeated names even if they are in different levels. As the `Event::Project` is useless, we can just remove it and add its data directly to the subclasses. Commit: 10a9af1725728181f2d2509529b957ff674a84df https://github.com/openSUSE/open-build-service/commit/10a9af1725728181f2d25… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-07 (Thu, 07 Dec 2017) Changed paths: M src/api/app/jobs/project_log_rotate_job.rb M src/api/script/delayed_job_stats.rb Log Message: ----------- [ci] Do not use Event::Project & Package in job I could have assigned the classes array to event_classes, but as the `flat_map(&:descendants)` is no longer needed in ``` event_classes.flat_map(&:descendants).map(&:name) ``` having an array with the name Strings directly seems to be better. Commit: 4e6efd8ae49969a1aa3008a97cd2b5dbecefd171 https://github.com/openSUSE/open-build-service/commit/4e6efd8ae49969a1aa300… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-12-07 (Thu, 07 Dec 2017) Changed paths: M .rubocop_todo.yml M src/api/app/controllers/request_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/webui/user_controller.rb M src/api/app/jobs/project_log_rotate_job.rb M src/api/app/models/bs_request.rb M src/api/app/models/comment.rb M src/api/app/models/event.rb R src/api/app/models/event/all.rb A src/api/app/models/event/branch_command.rb M src/api/app/models/event/build.rb A src/api/app/models/event/build_fail.rb A src/api/app/models/event/build_success.rb A src/api/app/models/event/build_unchanged.rb R src/api/app/models/event/comment.rb A src/api/app/models/event/comment_event.rb A src/api/app/models/event/comment_for_package.rb A src/api/app/models/event/comment_for_project.rb A src/api/app/models/event/comment_for_request.rb A src/api/app/models/event/commit.rb A src/api/app/models/event/create_package.rb A src/api/app/models/event/create_project.rb A src/api/app/models/event/delete_package.rb A src/api/app/models/event/delete_project.rb M src/api/app/models/event/factory.rb R src/api/app/models/event/package.rb M src/api/app/models/event/packtrack.rb R src/api/app/models/event/project.rb M src/api/app/models/event/repo_publish_state.rb M src/api/app/models/event/repo_published.rb M src/api/app/models/event/request.rb A src/api/app/models/event/request_change.rb A src/api/app/models/event/request_create.rb A src/api/app/models/event/request_delete.rb A src/api/app/models/event/request_statechange.rb A src/api/app/models/event/review_wanted.rb A src/api/app/models/event/service_fail.rb A src/api/app/models/event/service_success.rb A src/api/app/models/event/undelete_package.rb A src/api/app/models/event/undelete_project.rb A src/api/app/models/event/update_package.rb A src/api/app/models/event/update_project.rb A src/api/app/models/event/update_project_config.rb A src/api/app/models/event/upload.rb A src/api/app/models/event/version_change.rb M src/api/app/models/update_notification_events.rb M src/api/config/clock.rb M src/api/script/delayed_job_stats.rb M src/api/test/models/event_test.rb Log Message: ----------- Merge pull request #4191 from Ana06/refactor_event Refactor Event module Compare: https://github.com/openSUSE/open-build-service/compare/2e615f4011e6...4e6ef…

1 0

[obs-commits] [openSUSE/open-build-service] 88b8a6: [ci] Fix failure caused by factory bot change
by Björn Geuken 07 Dec '17

07 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 88b8a631d4fce8f3811897f4e2efb75201e60ac4 https://github.com/openSUSE/open-build-service/commit/88b8a631d4fce8f381189… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-12-07 (Thu, 07 Dec 2017) Changed paths: M src/api/spec/factories/kiwi_preference.rb Log Message: ----------- [ci] Fix failure caused by factory bot change PR#4190 was made before that factory got added. So when the PR got merged this new factory started to break the test suite, because it was still using the old name. Commit: 2e615f4011e633234305fc9fb8380042f7d7f5a0 https://github.com/openSUSE/open-build-service/commit/2e615f4011e633234305f… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-12-07 (Thu, 07 Dec 2017) Changed paths: M src/api/spec/factories/kiwi_preference.rb Log Message: ----------- Merge pull request #4195 from bgeuken/factory_girl [ci] Fix failure caused by factory bot change Compare: https://github.com/openSUSE/open-build-service/compare/eddd7b80bd60...2e615…

1 0

[obs-commits] [openSUSE/open-build-service] 8de922: [frontend] Stop conversion to symbols
by Björn Geuken 07 Dec '17

07 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8de9228a33f97cee2bda8afec4f525f63070cb6f https://github.com/openSUSE/open-build-service/commit/8de9228a33f97cee2bda8… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/models/bs_request_action.rb Log Message: ----------- [frontend] Stop conversion to symbols This isn't needed with the recent refactorings made in 38faed0f4e033a. Commit: 24825f40e2aaadeb7a03930b0518649f17dc0c7f https://github.com/openSUSE/open-build-service/commit/24825f40e2aaadeb7a039… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/app/models/bs_request_action.rb Log Message: ----------- [frontend] Make "classification" of variables easier to read ... by using the already classified form of 'bs_request_action_'. So that a reader doesn't have to make this conversion in his mind. Commit: eddd7b80bd6061e8c2aa40ef2f0ff8eba9a04165 https://github.com/openSUSE/open-build-service/commit/eddd7b80bd6061e8c2aa4… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-12-07 (Thu, 07 Dec 2017) Changed paths: M src/api/app/models/bs_request_action.rb Log Message: ----------- Merge pull request #4190 from bgeuken/cleanup Simplify "classification" of variables Compare: https://github.com/openSUSE/open-build-service/compare/1d2361987824...eddd7…

1 0

[obs-commits] [openSUSE/open-build-service] 37bb3d: [ci] Replace FactoryGirl gem with FactoryBot gem
by Björn Geuken 07 Dec '17

07 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 37bb3d7a93c76b9bc50c2b497dd059d986e58913 https://github.com/openSUSE/open-build-service/commit/37bb3d7a93c76b9bc50c2… Author: David Kang <dkang(a)suse.com> Date: 2017-11-03 (Fri, 03 Nov 2017) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock Log Message: ----------- [ci] Replace FactoryGirl gem with FactoryBot gem FactoryGirl gem has been renamed to FactoryBot Commit: 865cf4533851b9a626ecc5af5f6c863d92a2c5c8 https://github.com/openSUSE/open-build-service/commit/865cf4533851b9a626ecc… Author: David Kang <dkang(a)suse.com> Date: 2017-11-03 (Fri, 03 Nov 2017) Changed paths: M src/api/spec/factories/architecture.rb M src/api/spec/factories/attrib_allowed_values.rb M src/api/spec/factories/attrib_default_values.rb M src/api/spec/factories/attrib_namespaces.rb M src/api/spec/factories/attrib_types.rb M src/api/spec/factories/attrib_values.rb M src/api/spec/factories/attribs.rb M src/api/spec/factories/bs_request_actions.rb M src/api/spec/factories/bs_requests.rb M src/api/spec/factories/comments.rb M src/api/spec/factories/configuration.rb M src/api/spec/factories/distribution.rb M src/api/spec/factories/download_repository_factory.rb M src/api/spec/factories/event_subscriptions.rb M src/api/spec/factories/flag.rb M src/api/spec/factories/group_maintainers.rb M src/api/spec/factories/groups.rb M src/api/spec/factories/groups_user.rb M src/api/spec/factories/history_elements.rb M src/api/spec/factories/issue.rb M src/api/spec/factories/issue_tracker.rb M src/api/spec/factories/kiwi_description.rb M src/api/spec/factories/kiwi_image.rb M src/api/spec/factories/kiwi_package.rb M src/api/spec/factories/kiwi_package_group.rb M src/api/spec/factories/kiwi_repository.rb M src/api/spec/factories/maintained_project.rb M src/api/spec/factories/notification.rb M src/api/spec/factories/package_issue.rb M src/api/spec/factories/packages.rb M src/api/spec/factories/path_element.rb M src/api/spec/factories/project.rb M src/api/spec/factories/project_log_entry.rb M src/api/spec/factories/relationship.rb M src/api/spec/factories/release_target.rb M src/api/spec/factories/repository.rb M src/api/spec/factories/repository_architecture.rb M src/api/spec/factories/review.rb M src/api/spec/factories/role.rb M src/api/spec/factories/status_history.rb M src/api/spec/factories/status_message.rb M src/api/spec/factories/users.rb M src/api/spec/factories/watched_projects.rb M src/api/spec/support/factory_girl.rb Log Message: ----------- [ci] Replace FactoryGirl with FactoryBot. Since FactoryGirl has been renamed to FactoryBot we als need to replace `FactoryGirl` with `FactoryBot`. Commit: bf43ecd788c54f1db80abf4922bbfa712ecbb579 https://github.com/openSUSE/open-build-service/commit/bf43ecd788c54f1db80ab… Author: David Kang <dkang(a)suse.com> Date: 2017-11-03 (Fri, 03 Nov 2017) Changed paths: M src/api/config/application.rb M src/api/spec/rails_helper.rb M src/api/spec/support/database_cleaner.rb A src/api/spec/support/factory_bot.rb R src/api/spec/support/factory_girl.rb Log Message: ----------- [ci] Replace `factory_girl` with `factory_bot` Commit: 47801e7674f00d74181a2e636352e91be80d9407 https://github.com/openSUSE/open-build-service/commit/47801e7674f00d74181a2… Author: David Kang <dkang(a)suse.com> Date: 2017-11-03 (Fri, 03 Nov 2017) Changed paths: M src/api/spec/README.md Log Message: ----------- [doc] Update README We replace all the reference from FactoryGirl to FactoryBot Commit: 1d2361987824bb85f2754ff5d47b08423ee8d47e https://github.com/openSUSE/open-build-service/commit/1d2361987824bb85f2754… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-12-07 (Thu, 07 Dec 2017) Changed paths: M src/api/Gemfile M src/api/Gemfile.lock M src/api/config/application.rb M src/api/spec/README.md M src/api/spec/factories/architecture.rb M src/api/spec/factories/attrib_allowed_values.rb M src/api/spec/factories/attrib_default_values.rb M src/api/spec/factories/attrib_namespaces.rb M src/api/spec/factories/attrib_types.rb M src/api/spec/factories/attrib_values.rb M src/api/spec/factories/attribs.rb M src/api/spec/factories/bs_request_actions.rb M src/api/spec/factories/bs_requests.rb M src/api/spec/factories/comments.rb M src/api/spec/factories/configuration.rb M src/api/spec/factories/distribution.rb M src/api/spec/factories/download_repository_factory.rb M src/api/spec/factories/event_subscriptions.rb M src/api/spec/factories/flag.rb M src/api/spec/factories/group_maintainers.rb M src/api/spec/factories/groups.rb M src/api/spec/factories/groups_user.rb M src/api/spec/factories/history_elements.rb M src/api/spec/factories/issue.rb M src/api/spec/factories/issue_tracker.rb M src/api/spec/factories/kiwi_description.rb M src/api/spec/factories/kiwi_image.rb M src/api/spec/factories/kiwi_package.rb M src/api/spec/factories/kiwi_package_group.rb M src/api/spec/factories/kiwi_repository.rb M src/api/spec/factories/maintained_project.rb M src/api/spec/factories/notification.rb M src/api/spec/factories/package_issue.rb M src/api/spec/factories/packages.rb M src/api/spec/factories/path_element.rb M src/api/spec/factories/project.rb M src/api/spec/factories/project_log_entry.rb M src/api/spec/factories/relationship.rb M src/api/spec/factories/release_target.rb M src/api/spec/factories/repository.rb M src/api/spec/factories/repository_architecture.rb M src/api/spec/factories/review.rb M src/api/spec/factories/role.rb M src/api/spec/factories/status_history.rb M src/api/spec/factories/status_message.rb M src/api/spec/factories/users.rb M src/api/spec/factories/watched_projects.rb M src/api/spec/rails_helper.rb M src/api/spec/support/database_cleaner.rb A src/api/spec/support/factory_bot.rb R src/api/spec/support/factory_girl.rb Log Message: ----------- Merge pull request #4092 from DavidKang/factory_bot Replace FactoryGirlRails with FactoryBotRails Compare: https://github.com/openSUSE/open-build-service/compare/d83aadabcdee...1d236…

1 0

[obs-commits] [openSUSE/osc] b1d6d8: Fix "osc buildinfo --prefer-pkgs <dir>..." (finall...
by Marcus Huewe 06 Dec '17

06 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: b1d6d8347b740544d0ab92a94f3f0a096a4abe93 https://github.com/openSUSE/osc/commit/b1d6d8347b740544d0ab92a94f3f0a096a4a… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M osc/commandline.py Log Message: ----------- Fix "osc buildinfo --prefer-pkgs <dir>..." (finally!) This is a follow-up commit for commit ce9a6d0 ("Fixed \"osc buildinfo --prefer-pkgs...\"").

1 0

[obs-commits] [openSUSE/open-build-service] f571d2: [backend] BSRPC: support an authenticator callback
by Michael Schroeder 06 Dec '17

06 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f571d2b76107113e630a43afe546cab3e076bb33 https://github.com/openSUSE/open-build-service/commit/f571d2b76107113e630a4… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/backend/BSRPC.pm Log Message: ----------- [backend] BSRPC: support an authenticator callback Commit: d83aadabcdee3771d434227ff750c366fa7db333 https://github.com/openSUSE/open-build-service/commit/d83aadabcdee3771d4342… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: A src/backend/BSPGP.pm R src/backend/BSPgp.pm M src/backend/bs_notar M src/backend/bs_signer M src/backend/bs_srcserver Log Message: ----------- [backend] Rename BSPgp.pm to BSPGP.pm Better late than never... Compare: https://github.com/openSUSE/open-build-service/compare/50d84df18f5a...d83aa…

1 0

[obs-commits] [openSUSE/open-build-service] 50d84d: [backend] unbreak notary upload
by Michael Schroeder 06 Dec '17

06 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 50d84df18f5a2f4385acd272111452df080d3fc6 https://github.com/openSUSE/open-build-service/commit/50d84df18f5a2f4385acd… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/backend/bs_notar M src/backend/bs_publish Log Message: ----------- [backend] unbreak notary upload

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 06 Dec '17

06 Dec '17

Branch: refs/heads/depfu/update/srcapi/bullet-5.7.0 Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service] 3522d5: Update bullet to version 5.7.0
by Björn Geuken 06 Dec '17

06 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3522d5876a49471eace27c2f838ab6aeddb8fde2 https://github.com/openSUSE/open-build-service/commit/3522d5876a49471eace27… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2017-12-03 (Sun, 03 Dec 2017) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update bullet to version 5.7.0 Commit: 65eab2e79caaa27388e3b35f14972f1a3fd2e7a4 https://github.com/openSUSE/open-build-service/commit/65eab2e79caaa27388e3b… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #4177 from openSUSE/depfu/update/srcapi/bullet-5.7.0 Update bullet: 5.6.1 → 5.7.0 (minor) Compare: https://github.com/openSUSE/open-build-service/compare/ab5a9210f1cd...65eab…

1 0

[obs-commits] [openSUSE/osc] aa01b1: reopen 0.163 development
by lethliel 06 Dec '17

06 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: aa01b1c52abe91d86839990df6dff19b5d37747f https://github.com/openSUSE/osc/commit/aa01b1c52abe91d86839990df6dff19b5d37… Author: lethliel <mstrigl(a)suse.com> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M NEWS M osc/core.py Log Message: ----------- reopen 0.163 development

1 0

[obs-commits] [openSUSE/open-build-service] ab5a92: [dist] fix perl dependency
by Adrian Schröter 06 Dec '17

06 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ab5a9210f1cd2746f7c1d18d36b157da570aacc6 https://github.com/openSUSE/open-build-service/commit/ab5a9210f1cd2746f7c1d… Author: Adrian Schröter <adrian(a)suse.de> Date: 2017-12-06 (Wed, 06 Dec 2017) Changed paths: M dist/obs-server.spec Log Message: ----------- [dist] fix perl dependency perl TimeDate provides multiple modules, but no TimeDate. We need Date::Parse

1 0

[obs-commits] [openSUSE/osc]
by lethliel 05 Dec '17

05 Dec '17

Branch: refs/tags/0.162.1 Home: https://github.com/openSUSE/osc

1 0

[obs-commits] [openSUSE/osc] 067fd4: release 0.162.1
by lethliel 05 Dec '17

05 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 067fd4cd2df8432411e90784c7f3e2982c9453b3 https://github.com/openSUSE/osc/commit/067fd4cd2df8432411e90784c7f3e2982c94… Author: lethliel <mstrigl(a)suse.com> Date: 2017-12-05 (Tue, 05 Dec 2017) Changed paths: M NEWS M osc/core.py Log Message: ----------- release 0.162.1

1 0

[obs-commits] [openSUSE/open-build-service] d22f8b: [backend] fix registry config check
by Michael Schroeder 05 Dec '17

05 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d22f8bec85c649079659b829d5e6a4f1ccf381ee https://github.com/openSUSE/open-build-service/commit/d22f8bec85c649079659b… Author: Michael Schroeder <mls(a)suse.de> Date: 2017-12-05 (Tue, 05 Dec 2017) Changed paths: M src/backend/bs_publish Log Message: ----------- [backend] fix registry config check

1 0

[obs-commits] [openSUSE/open-build-service] 39810f: [webui] Don't raise an exception when 'image' repo...
by Ana María Martínez Gómez 05 Dec '17

05 Dec '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 39810f45a2ed182366079d59eed9eba5c86ee9e9 https://github.com/openSUSE/open-build-service/commit/39810f45a2ed182366079… Author: Manuel Schnitzer <mschnitzer(a)suse.com> Date: 2017-12-05 (Tue, 05 Dec 2017) Changed paths: M src/api/app/controllers/webui/repositories_controller.rb Log Message: ----------- [webui] Don't raise an exception when 'image' repo already exists Our validation in the Repository model prohibits creating new records with the same name for a project. Commit: 080a0d1b62902f27016d705d1bd247deb086ff28 https://github.com/openSUSE/open-build-service/commit/080a0d1b62902f27016d7… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-12-05 (Tue, 05 Dec 2017) Changed paths: M src/api/app/controllers/webui/repositories_controller.rb Log Message: ----------- Merge pull request #4122 from mschnitzer/issue_4048 [webui] Don't raise an exception when 'image' repo already exists Compare: https://github.com/openSUSE/open-build-service/compare/b62ee60b6aa2...080a0…

1 0