November 2017 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] ecd2a5: [webui][api] Add missing table in structure.sql
by David Kang 02 Nov '17

02 Nov '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ecd2a5ed40dc0119bbba0c3528e85765f9216a07 https://github.com/openSUSE/open-build-service/commit/ecd2a5ed40dc0119bbba0… Author: David Kang <dkang(a)suse.com> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M src/api/db/structure.sql Log Message: ----------- [webui][api] Add missing table in structure.sql Commit: 25700f3ba7beaab5abfdbc0f5d1e2f33cdfc3d3c https://github.com/openSUSE/open-build-service/commit/25700f3ba7beaab5abfdb… Author: David Kang <dkang(a)suse.com> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M src/api/db/structure.sql Log Message: ----------- Merge pull request #4103 from DavidKang/add_missing_table [webui][api] Add missing table in structure.sql Compare: https://github.com/openSUSE/open-build-service/compare/59a3142c6fbd...25700…

1 0

[obs-commits] [openSUSE/open-build-service] 629577: [frontend] Fix deletion of groups_users
by David Kang 02 Nov '17

02 Nov '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 629577c2e58f551dae69ef398450acbb9a8e0d79 https://github.com/openSUSE/open-build-service/commit/629577c2e58f551dae69e… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M src/api/app/models/group.rb M src/api/app/models/groups_user.rb A src/api/db/migrate/20171102110929_disallow_null_for_group_id_in_groups_users.rb M src/api/db/structure.sql M src/api/spec/controllers/group_controller_spec.rb Log Message: ----------- [frontend] Fix deletion of groups_users When deleting a group, we also want the related groups_user to be destroyed. That's reflected with a 'dependent: :destroy'. In PR #3393 it was already reported that this was not working and destroying a group that has associated users (and groups_users), would cause a 500. With 18680d611347d312142 the 500 error was solved, but the underlying problem (not properly deleting groups users) persisted. The cause of this issue was that the group model defined the n-to-m relation to groups_users twice. Once via a has_many relation and once via a has_and_belongs_to_many. This doesn't seem to be valid, nor does it make any sense, and it caused rails to create following SQL calls when a_group.destroy was called: SQL (0.6ms) UPDATE `groups_users` SET `groups_users`.`group_id` = NULL WHERE `groups_users`.`group_id` = 1 SQL (0.4ms) DELETE FROM `groups_users` WHERE `groups_users`.`group_id` = 1 As you can see the second SQL query, that would delete the groups user, is ineffective due to the first one. By dropping one of the two n-to-m relations, we prevent Rails from creating bogus SQL queries and thus fix the issue. Commit: 59a3142c6fbd2766ea378238aee3d76d5dc54bae https://github.com/openSUSE/open-build-service/commit/59a3142c6fbd2766ea378… Author: David Kang <dkang(a)suse.com> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M src/api/app/models/group.rb M src/api/app/models/groups_user.rb A src/api/db/migrate/20171102110929_disallow_null_for_group_id_in_groups_users.rb M src/api/db/structure.sql M src/api/spec/controllers/group_controller_spec.rb Log Message: ----------- Merge pull request #4041 from bgeuken/fix_user_group_destroy [frontend] Fix deletion of groups_users Compare: https://github.com/openSUSE/open-build-service/compare/f309ebca1020...59a31…

1 0

[obs-commits] [openSUSE/open-build-service] 2f89be: [ci] Change Rubocop version in Travis
by Eduardo J 02 Nov '17

02 Nov '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2f89bead08e1ac9c02493439d22e6df296b4fb23 https://github.com/openSUSE/open-build-service/commit/2f89bead08e1ac9c02493… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M .travis.yml Log Message: ----------- [ci] Change Rubocop version in Travis We just updated Rubocop, but we forgot to do it in Travis. Pair programmed with @DavidKang. Commit: f309ebca102075f5f828ae688b43ef44a7f44353 https://github.com/openSUSE/open-build-service/commit/f309ebca102075f5f828a… Author: Eduardo J <eduardoj(a)users.noreply.github.com> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M .travis.yml Log Message: ----------- Merge pull request #4101 from Ana06/rubocop-51 [ci] Change Rubocop version in Travis Compare: https://github.com/openSUSE/open-build-service/compare/5af75781c093...f309e…

1 0

[obs-commits] [openSUSE/open-build-service] 3d42c5: [backend] fix logical comparison for sha256 check
by Marco Strigl 02 Nov '17

02 Nov '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 3d42c542eead9b28c8bb67f32aad3819a862f88c https://github.com/openSUSE/open-build-service/commit/3d42c542eead9b28c8bb6… Author: marco <lethliel(a)gmx.de> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M src/backend/bs_srcserver Log Message: ----------- [backend] fix logical comparison for sha256 check and fix wrong spelling of mismatch Commit: 5af75781c093754aa894480fd34fa9150045ff83 https://github.com/openSUSE/open-build-service/commit/5af75781c093754aa8944… Author: Marco Strigl <mstrigl(a)suse.com> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M src/backend/bs_srcserver Log Message: ----------- Merge pull request #4100 from lethliel/fix_sha256_check [backend] fix logical comparison for sha256 check Compare: https://github.com/openSUSE/open-build-service/compare/46e7e1b55362...5af75…

1 0

[obs-commits] [openSUSE/open-build-service] 4d94ab: [doc] Remove duplicated code review how-to
by David Kang 02 Nov '17

02 Nov '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 4d94abe13909bdb5ec9b0c04e82dddce64a99d88 https://github.com/openSUSE/open-build-service/commit/4d94abe13909bdb5ec9b0… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M CONTRIBUTING.md Log Message: ----------- [doc] Remove duplicated code review how-to We had two sections of how we review code. This drops the older version. Though both versions were almost identical. Commit: 46e7e1b553621087e234a136f64796d31c5b996f https://github.com/openSUSE/open-build-service/commit/46e7e1b553621087e234a… Author: David Kang <dkang(a)suse.com> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M CONTRIBUTING.md Log Message: ----------- Merge pull request #4099 from bgeuken/update_contribution_md [doc] Remove duplicated code review how-to Compare: https://github.com/openSUSE/open-build-service/compare/0d43648fffa2...46e7e…

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 02 Nov '17

02 Nov '17

Branch: refs/heads/depfu/update/haml_lint-0.27.0 Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service] 8c5760: Update haml_lint to version 0.27.0
by David Kang 02 Nov '17

02 Nov '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8c57601342d92e9d1b0cb7bf2fbe4b5be0e9627f https://github.com/openSUSE/open-build-service/commit/8c57601342d92e9d1b0cb… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2017-10-30 (Mon, 30 Oct 2017) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update haml_lint to version 0.27.0 Commit: 0d43648fffa214263e31f1e1d9d7d221271ab75c https://github.com/openSUSE/open-build-service/commit/0d43648fffa214263e31f… Author: David Kang <dkang(a)suse.com> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #4084 from openSUSE/depfu/update/haml_lint-0.27.0 Update haml_lint to version 0.27.0 Compare: https://github.com/openSUSE/open-build-service/compare/5435a10cb92d...0d436…

1 0

[obs-commits] [openSUSE/open-build-service]
by Ana06 02 Nov '17

02 Nov '17

Branch: refs/heads/nodoc Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service] f8c312: [api] Do not use :nodoc: for private methods
by Ana María Martínez Gómez 02 Nov '17

02 Nov '17

Branch: refs/heads/nodoc Home: https://github.com/openSUSE/open-build-service Commit: f8c31200cd66984c25755a56388fb2829c938407 https://github.com/openSUSE/open-build-service/commit/f8c31200cd66984c25755… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M src/api/lib/activexml/node.rb Log Message: ----------- [api] Do not use :nodoc: for private methods Private methods are internal by default, so using :nodoc: with private methods shouldn't have any impact. And this is only a comment, so even if it had an impact, it wouldn't affect at all. http://guides.rubyonrails.org/api_documentation_guidelines.html#method-visi… Commit: 8548b239241c0e8f5fffcc982ddb98548cff973e https://github.com/openSUSE/open-build-service/commit/8548b239241c0e8f5fffc… Author: Ana María Martínez Gómez <ammartinez(a)suse.de> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M src/api/lib/activexml/node.rb Log Message: ----------- [api] Make Node#internal_data private Make the method protected instead of adding an scaring comment: _stay away from this_ This was probably made public, as it is needed in `def ==(other)`: ``` _data == other.internal_data ``` Compare: https://github.com/openSUSE/open-build-service/compare/f8c31200cd66^...8548…

1 0

[obs-commits] [openSUSE/open-build-service] 5435a1: [dist] %verifyscript is a rpm section, not a %post...
by Adrian Schröter 02 Nov '17

02 Nov '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 5435a10cb92d74381af3c467595204ca1398c564 https://github.com/openSUSE/open-build-service/commit/5435a10cb92d74381af3c… Author: Adrian Schröter <adrian(a)suse.de> Date: 2017-11-02 (Thu, 02 Nov 2017) Changed paths: M dist/obs-server.spec Log Message: ----------- [dist] %verifyscript is a rpm section, not a %postun scriptlet

1 0