October 2017 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 9bd4a1: [frontend] Move adding maintainer to model
by Björn Geuken 11 Oct '17

11 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 9bd4a130e00e12a133736cfb7780247f2b99acc5 https://github.com/openSUSE/open-build-service/commit/9bd4a130e00e12a133736… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/spec/models/package_spec.rb M src/api/spec/models/project_spec.rb A src/api/spec/support/shared_examples/relationships.rb Log Message: ----------- [frontend] Move adding maintainer to model This commit implements add_maintainer methods for the package and project model and moves the code from the controller to the model. Commit: 9fe3eb37c54cbf846885106a9a9d6f26d4d220a8 https://github.com/openSUSE/open-build-service/commit/9fe3eb37c54cbf8468851… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/spec/models/package_spec.rb M src/api/spec/models/project_spec.rb A src/api/spec/support/shared_examples/relationships.rb Log Message: ----------- Merge pull request #3982 from bgeuken/refactor_request_controller__ [frontend] Move adding maintainer to model Compare: https://github.com/openSUSE/open-build-service/compare/b47f4d28bb17...9fe3e…

1 0

[obs-commits] [openSUSE/open-build-service] 6e818a: [webui] Disable links for remote image templates
by Björn Geuken 11 Oct '17

11 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6e818abc5686949198da48d605642dbf51adc6ab https://github.com/openSUSE/open-build-service/commit/6e818abc5686949198da4… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M src/api/app/views/webui/image_templates/index.html.haml Log Message: ----------- [webui] Disable links for remote image templates We were linking to projects and packages of remote instances. In such a case we don't have a valid url to point at. So users would end up with an error when clicking this link. To fix that we only show a link for local projects and packages on the image template page. Commit: b47f4d28bb173002186b0642c8c133ee41fc4c11 https://github.com/openSUSE/open-build-service/commit/b47f4d28bb173002186b0… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/views/webui/image_templates/index.html.haml Log Message: ----------- Merge pull request #3975 from bgeuken/disable_remote_links [webui] Disable links for remote image templates Compare: https://github.com/openSUSE/open-build-service/compare/ec6d32762f20...b47f4…

1 0

[obs-commits] [openSUSE/open-build-service] 981297: [frontend] DRY code in BsRequest model
by Björn Geuken 11 Oct '17

11 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 98129723c49ae28bae20b6a47db1551d40e16c70 https://github.com/openSUSE/open-build-service/commit/98129723c49ae28bae20b… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [frontend] DRY code in BsRequest model Move duplicated code for checking associated bs_request_actions into private method. Commit: ae97338d47a968d91521b98fd4b0ca77e21c94c5 https://github.com/openSUSE/open-build-service/commit/ae97338d47a968d91521b… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [frontend] Move existing private methods together We already had some private methods that were marked as private individually. This will group them together to have a better overview of them. Commit: 15878f7e5ea828a40ff84e9bc2c600f9f912bbaf https://github.com/openSUSE/open-build-service/commit/15878f7e5ea828a40ff84… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [frontend] Group class and instance methods together Commit: 050a39222ba095c7d462f263882c3727735759d9 https://github.com/openSUSE/open-build-service/commit/050a39222ba095c7d462f… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [frontend] Cleanup usage of constants * Make IntermediateStates a local variable, since it was only used in one method. * Fix naming of ActionNotifyLimit constant and move it up to the other constants. Constants should be written in CAMEL_CASE;-) Commit: ec6d32762f20eaca3c87fef26645f2710b51774b https://github.com/openSUSE/open-build-service/commit/ec6d32762f20eaca3c87f… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- Merge pull request #3980 from bgeuken/refactor_bs_request_model Refactor bs request model Compare: https://github.com/openSUSE/open-build-service/compare/0ab7f3c74218...ec6d3…

1 0

[obs-commits] [openSUSE/open-build-service] 6fc648: Update webmock to version 3.1.0
by Manuel Schnitzer 11 Oct '17

11 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6fc648bd5d8db85c911ebf46cd5371d91c551772 https://github.com/openSUSE/open-build-service/commit/6fc648bd5d8db85c911eb… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2017-10-08 (Sun, 08 Oct 2017) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update webmock to version 3.1.0 Commit: 0ab7f3c742180ac0427117df122edcf7149a208b https://github.com/openSUSE/open-build-service/commit/0ab7f3c742180ac042711… Author: Manuel Schnitzer <github(a)mschnitzer.de> Date: 2017-10-11 (Wed, 11 Oct 2017) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #3962 from openSUSE/depfu/update/webmock-3.1.0 Update webmock to version 3.1.0 Compare: https://github.com/openSUSE/open-build-service/compare/c822971a6211...0ab7f…

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 11 Oct '17

11 Oct '17

Branch: refs/heads/depfu/update/webmock-3.1.0 Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/osc] 0eecda: Add missing comment
by Marcus Huewe 10 Oct '17

10 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 0eecdaf8301760ed4dbfe2d2eb7b608046bee7fc https://github.com/openSUSE/osc/commit/0eecdaf8301760ed4dbfe2d2eb7b608046be… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M osc/core.py Log Message: ----------- Add missing comment Follow-up commit for f6f879d.

1 0

[obs-commits] [openSUSE/osc] c3ba1f: Eventually fix potential shell injections for find
by Marcus Huewe 10 Oct '17

10 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: c3ba1fbf63aa8beb355a100b6d6e8ccfa5b95615 https://github.com/openSUSE/osc/commit/c3ba1fbf63aa8beb355a100b6d6e8ccfa5b9… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M osc/core.py Log Message: ----------- Eventually fix potential shell injections for find It seems that the "find" binary has no way to indicate an end of options for its arguments. Hence, we use os.walk to mimic "find"'s behavior, which is also the cleaner solution. Fixes: #340 ("osc add of directories does not quote the argument") Commit: a5c7611aee8f4c3d87f24c507a28c68bd00cf9dd https://github.com/openSUSE/osc/commit/a5c7611aee8f4c3d87f24c507a28c68bd00c… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M osc/core.py Log Message: ----------- Support unusual filenames in "osc add <directory>" This way, we can also support directories/files that contain a newline "\n" etc. Commit: f6f879dac5e9c474e3f9fb0148586d2d857d0db7 https://github.com/openSUSE/osc/commit/f6f879dac5e9c474e3f9fb0148586d2d857d… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M osc/core.py Log Message: ----------- Fix potential shell injection when running rpm2cpio Actually, there is nothing that can be injected, except the "-h" option. However, in case rpm2cpio evolves, we are on the safe side. Also, document the potential shell injection in the cpio call (the comment was accidentally removed in commit dbdc712) (the current osc code is not affected, because we never pass filenames via *files to core.unpack_srcrpm). Compare: https://github.com/openSUSE/osc/compare/d66ccb2a7dbd...f6f879dac5e9

1 0

[obs-commits] [openSUSE/open-build-service] 7a5d21: [ci] Improve test coverage for EventFindSubscripti...
by Björn Geuken 10 Oct '17

10 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7a5d21f40358021bb79d1fea3ce01358e2775632 https://github.com/openSUSE/open-build-service/commit/7a5d21f40358021bb79d1… Author: Evan Rolfe <esrolfe(a)suse.de> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M src/api/spec/models/event_find_subscriptions_spec.rb Log Message: ----------- [ci] Improve test coverage for EventFindSubscription. I add a test to consider what happens when a user is both a maintainer and a commentor for a comment event. Commit: 4442f80bb664c84af95fe5a41629062bff0593ae https://github.com/openSUSE/open-build-service/commit/4442f80bb664c84af95fe… Author: Evan Rolfe <esrolfe(a)suse.de> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M src/api/app/models/event_find_subscriptions.rb M src/api/spec/models/event_find_subscriptions_spec.rb Log Message: ----------- [api][webui] Refactor EventFindSubscriptions class. I simplify the code in the class and fix the behaviour of it for when a user is part of a group with no email. Commit: ff2a36ba8c4a5a69445ffdb3360fa6366a5631c9 https://github.com/openSUSE/open-build-service/commit/ff2a36ba8c4a5a69445ff… Author: Evan Rolfe <esrolfe(a)suse.de> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M src/api/app/models/event/base.rb R src/api/app/models/event_find_subscriptions.rb A src/api/app/models/event_subscription/find_for_event.rb R src/api/spec/models/event_find_subscriptions_spec.rb A src/api/spec/models/event_subscription/find_for_event_spec.rb M src/api/test/models/event_test.rb Log Message: ----------- [api][webui] Move EventFindSubscriptions into a sub module. Move the class so its kept the other logic classes that relate to EventSubscription. Commit: c822971a62114c6afa2a12e9670a7a8d7097dac6 https://github.com/openSUSE/open-build-service/commit/c822971a62114c6afa2a1… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M src/api/app/models/event/base.rb R src/api/app/models/event_find_subscriptions.rb A src/api/app/models/event_subscription/find_for_event.rb R src/api/spec/models/event_find_subscriptions_spec.rb A src/api/spec/models/event_subscription/find_for_event_spec.rb M src/api/test/models/event_test.rb Log Message: ----------- Merge pull request #3976 from evanrolfe/refactor/event_find_subscriptions2 Refactor/event find subscriptions2 Compare: https://github.com/openSUSE/open-build-service/compare/e9d906416f37...c8229…

1 0

[obs-commits] [openSUSE/open-build-service] 89d7fc: [frontend] Sort local and remote image templates
by Christian Bruckmayer 10 Oct '17

10 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 89d7fc5ce80ab0a63d57dd727f0cd74668338da5 https://github.com/openSUSE/open-build-service/commit/89d7fc5ce80ab0a63d57d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/models/project.rb Log Message: ----------- [frontend] Sort local and remote image templates Sort local and remote image templates by name. Commit: e9d906416f377a6b4674773d58b355cd81bf4870 https://github.com/openSUSE/open-build-service/commit/e9d906416f377a6b46747… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M src/api/app/models/project.rb Log Message: ----------- Merge pull request #3971 from bgeuken/image_sorting [frontend] Sort local and remote image templates Compare: https://github.com/openSUSE/open-build-service/compare/e2869cee005c...e9d90…

1 0

[obs-commits] [openSUSE/open-build-service] e2869c: [backend] sync SLE-15 product schema for productre...
by Adrian Schröter 10 Oct '17

10 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e2869cee005ca3c4239a1757fbba97466587b638 https://github.com/openSUSE/open-build-service/commit/e2869cee005ca3c4239a1… Author: Adrian Schröter <adrian(a)suse.de> Date: 2017-10-10 (Tue, 10 Oct 2017) Changed paths: M src/backend/BSProductXML.pm Log Message: ----------- [backend] sync SLE-15 product schema for productrepositories call

1 0