October 2017 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 22083a: [ci] Solve duplicated shared exampls warning
by David Kang 09 Oct '17

09 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 22083a5736d45da2dc57c94cfaa05d3050f2f777 https://github.com/openSUSE/open-build-service/commit/22083a5736d45da2dc57c… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/spec/models/bs_request_spec.rb M src/api/spec/models/review_spec.rb Log Message: ----------- [ci] Solve duplicated shared exampls warning It would also be an option to merge both examples. But that would mean we have to deal with 2 variables that can change (subject and review / request). This would increase the complexity of the example a lot. For that reason it's better to just fix the name collision. ==== WARNING: Shared example group 'the subject's cache is reset' has been previously defined at: /obs/src/api/spec/models/bs_request_spec.rb:119 ...and you are now defining it at: /obs/src/api/spec/models/review_spec.rb:321 The new definition will overwrite the original one. Commit: 7ebc432b793dfb63a02c455bf068cb4303540a05 https://github.com/openSUSE/open-build-service/commit/7ebc432b793dfb63a02c4… Author: David Kang <dkang(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/spec/models/bs_request_spec.rb M src/api/spec/models/review_spec.rb Log Message: ----------- Merge pull request #3972 from bgeuken/fix_duplicated_rspec_example [ci] Solve duplicated shared exampls warning Compare: https://github.com/openSUSE/open-build-service/compare/71a953b9b5db...7ebc4…

1 0

[obs-commits] [openSUSE/open-build-service] 58d6f8: [webui][ci] Only allow different package groups
by Björn Geuken 09 Oct '17

09 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 58d6f8e1285b19c58e2eea75bcf7b1ae16151ed7 https://github.com/openSUSE/open-build-service/commit/58d6f8e1285b19c58e2ee… Author: David Kang <dkang(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/models/kiwi/image.rb A src/api/spec/cassettes/Webui_Kiwi_ImagesController/GET_import_from_package/with_a_kiwi_file/with_multiple_package_groups/with_the_same_type/1_1_2_4_1_2.yml A src/api/spec/cassettes/Webui_Kiwi_ImagesController/GET_import_from_package/with_a_kiwi_file/with_multiple_package_groups/with_the_same_type/redirect_to_package_view_file_path.yml M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/support/shared_contexts/a_kiwi_image_xml.rb M src/api/spec/support/shared_contexts/an_invalid_kiwi_image_xml.rb Log Message: ----------- [webui][ci] Only allow different package groups We only allow package groups with different types in the same kiwi file. Commit: 71a953b9b5db3d97a433b6282eed180dfafa35f8 https://github.com/openSUSE/open-build-service/commit/71a953b9b5db3d97a433b… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/models/kiwi/image.rb A src/api/spec/cassettes/Webui_Kiwi_ImagesController/GET_import_from_package/with_a_kiwi_file/with_multiple_package_groups/with_the_same_type/1_1_2_4_1_2.yml A src/api/spec/cassettes/Webui_Kiwi_ImagesController/GET_import_from_package/with_a_kiwi_file/with_multiple_package_groups/with_the_same_type/redirect_to_package_view_file_path.yml M src/api/spec/controllers/webui/kiwi/images_controller_spec.rb M src/api/spec/support/shared_contexts/a_kiwi_image_xml.rb M src/api/spec/support/shared_contexts/an_invalid_kiwi_image_xml.rb Log Message: ----------- Merge pull request #3968 from DavidKang/allow-on-package-group [webui][ci] Only allow different package groups Compare: https://github.com/openSUSE/open-build-service/compare/156c972ff09d...71a95…

1 0

[obs-commits] [openSUSE/open-build-service] f38a5b: Revert "[webui] get a defined order of templates"
by Björn Geuken 09 Oct '17

09 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f38a5b08ac0a489c16b2a7cc41740dd7618ceac6 https://github.com/openSUSE/open-build-service/commit/f38a5b08ac0a489c16b2a… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/views/webui/image_templates/index.html.haml Log Message: ----------- Revert "[webui] get a defined order of templates" This reverts commit 44fa6c153295bc0f14e42bea3d1bfae2fb3536ed. Because it doesn't work for remote projects as they don't exists in the database. The order_by_name scope however performs a database query which results in an empty collection. Commit: 156c972ff09d2b4d2f9f53c5af018ea61982607f https://github.com/openSUSE/open-build-service/commit/156c972ff09d2b4d2f9f5… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/views/webui/image_templates/index.html.haml Log Message: ----------- Merge pull request #3965 from ChrisBr/bugfix/template_order_by_name Revert "[webui] get a defined order of templates" Compare: https://github.com/openSUSE/open-build-service/compare/89fe7a96ca83...156c9…

1 0

[obs-commits] [openSUSE/open-build-service] 6efb5c: [ci] Refactor model: AttribValue
by Henne Vogelsang 09 Oct '17

09 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6efb5cbcb3cb205f6febc2b0edc87bfa0348b377 https://github.com/openSUSE/open-build-service/commit/6efb5cbcb3cb205f6febc… Author: Manuel Schnitzer <mschnitzer(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/models/attrib_value.rb M src/api/spec/controllers/webui/attributes_spec.rb A src/api/spec/factories/attrib_default_values.rb M src/api/spec/factories/attrib_types.rb M src/api/spec/factories/attrib_values.rb M src/api/spec/factories/attribs.rb M src/api/spec/features/webui/attributes_spec.rb M src/api/spec/models/attrib_spec.rb A src/api/spec/models/attrib_value_spec.rb Log Message: ----------- [ci] Refactor model: AttribValue Commit: b8f81f8fac57ecf3dcbddc85e785586c852aaca7 https://github.com/openSUSE/open-build-service/commit/b8f81f8fac57ecf3dcbdd… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/spec/factories/attrib_types.rb M src/api/spec/factories/attrib_values.rb M src/api/spec/factories/attribs.rb Log Message: ----------- [ci] Simplify attrib factories Commit: 3fc872f6061dae3152c5ab6b320aa8f072e0d2e5 https://github.com/openSUSE/open-build-service/commit/3fc872f6061dae3152c5a… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/spec/factories/attribs.rb Log Message: ----------- [ci] Remove unused attrib factory Commit: 80041afe4545b244d15b43da15c4e12c2f2bfb6a https://github.com/openSUSE/open-build-service/commit/80041afe4545b244d15b4… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/spec/models/attrib_value_spec.rb Log Message: ----------- [ci] Refactor attrib value spec Commit: 86ea9a827b666e4d8067c53946c430be603d35cc https://github.com/openSUSE/open-build-service/commit/86ea9a827b666e4d8067c… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/models/attrib_value.rb Log Message: ----------- [api][webui] Drop unnecessary nil guard as blank? already checks for nil. Commit: 318b2ab18ad43e06c9b8098ab33c506182c94030 https://github.com/openSUSE/open-build-service/commit/318b2ab18ad43e06c9b80… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/models/attrib_value.rb M src/api/spec/models/attrib_value_spec.rb Log Message: ----------- [api][webui] Set default value in AttribValue when value is blank Commit: aac124a0de79d375b53f815ab16982aa51f01453 https://github.com/openSUSE/open-build-service/commit/aac124a0de79d375b53f8… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/spec/factories/attrib_values.rb M src/api/spec/models/attrib_value_spec.rb Log Message: ----------- [ci] Move reload from AttribValue spec to factory Commit: e7aa75e698182cd966316998170747c59c3f9ebd https://github.com/openSUSE/open-build-service/commit/e7aa75e698182cd966316… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/models/attrib_value.rb M src/api/spec/models/attrib_value_spec.rb Log Message: ----------- [webui] More specs for AttribValue and some small refactoring. Note that it is not possible to let act_as_list set the position as it will assign the position in after_save which would cause an error getting the default value. Commit: 89fe7a96ca83759e7374c260eddace24c8e1dc7c https://github.com/openSUSE/open-build-service/commit/89fe7a96ca83759e7374c… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/models/attrib_value.rb M src/api/spec/controllers/webui/attributes_spec.rb A src/api/spec/factories/attrib_default_values.rb M src/api/spec/factories/attrib_types.rb M src/api/spec/factories/attrib_values.rb M src/api/spec/factories/attribs.rb M src/api/spec/features/webui/attributes_spec.rb M src/api/spec/models/attrib_spec.rb A src/api/spec/models/attrib_value_spec.rb Log Message: ----------- Merge pull request #3950 from ChrisBr/feature/attrib_value_model_specs Specs for AttribValue model Compare: https://github.com/openSUSE/open-build-service/compare/beed676906d7...89fe7…

1 0

[obs-commits] [openSUSE/open-build-service] edc93d: [api] Remove duplicated code from request controll...
by David Kang 09 Oct '17

09 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: edc93d80e3630aaf9d16658365a7bc3a9f65ec2d https://github.com/openSUSE/open-build-service/commit/edc93d80e3630aaf9d166… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [api] Remove duplicated code from request controller There already is a before_action that makes sure a bs_request was found. The code is of the before_action is even identical to the dropped code. Commit: 802f2c903da811d708b1a8fa32cc1324f7f056ba https://github.com/openSUSE/open-build-service/commit/802f2c903da811d708b1a… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/_recent_events_table.html.erb M src/api/app/views/webui/request/show.html.erb M src/api/spec/controllers/webui/request_controller_spec.rb Log Message: ----------- [api] Rename variable: @bsreq -> @bs_request Commit: cac9d208a6096d099cfb417375db06f069cef1cd https://github.com/openSUSE/open-build-service/commit/cac9d208a6096d099cfb4… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [api] Re-use before_action to DRY code With this commit we will use the existing require_request before_action and remove the code that took care of this before from the show action. Commit: 1861973c26b0f9a2c78eb9ba6705c691d06b4ec0 https://github.com/openSUSE/open-build-service/commit/1861973c26b0f9a2c78eb… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/controllers/webui/request_controller.rb Log Message: ----------- [webui] Make before_action private Commit: beed676906d7fabb994f681315400ad0aafd6e5d https://github.com/openSUSE/open-build-service/commit/beed676906d7fabb994f6… Author: David Kang <dkang(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/app/controllers/webui/request_controller.rb M src/api/app/views/webui/request/_recent_events_table.html.erb M src/api/app/views/webui/request/show.html.erb M src/api/spec/controllers/webui/request_controller_spec.rb Log Message: ----------- Merge pull request #3963 from bgeuken/refactor_request_controller Refactor request controller Compare: https://github.com/openSUSE/open-build-service/compare/57e69b01c20c...beed6…

1 0

[obs-commits] [openSUSE/open-build-service] 989854: [webui] Show if request is a new package submissio...
by Christian Bruckmayer 09 Oct '17

09 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 989854f20b36a37b0e24ceb59fed07f573890760 https://github.com/openSUSE/open-build-service/commit/989854f20b36a37b0e24c… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M .rubocop_todo.yml M src/api/app/helpers/webui/request_helper.rb M src/api/app/models/bs_request/data_table/row.rb M src/api/app/views/webui/shared/bs_requests/index.json.erb A src/api/spec/helpers/webui/request_helper_spec.rb Log Message: ----------- [webui] Show if request is a new package submission in the request table on the user and group overview. Commit: 57e69b01c20c7452ce24b2a53dfb0c76c9f8a4dd https://github.com/openSUSE/open-build-service/commit/57e69b01c20c7452ce24b… Author: Christian Bruckmayer <cbruckmayer(a)suse.com> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M .rubocop_todo.yml M src/api/app/helpers/webui/request_helper.rb M src/api/app/models/bs_request/data_table/row.rb M src/api/app/views/webui/shared/bs_requests/index.json.erb A src/api/spec/helpers/webui/request_helper_spec.rb Log Message: ----------- Merge pull request #3960 from ChrisBr/feature/show_new_package [webui] Show if request is a new package submission Compare: https://github.com/openSUSE/open-build-service/compare/562172abfea0...57e69…

1 0

[obs-commits] [openSUSE/open-build-service]
by depfu 09 Oct '17

09 Oct '17

Branch: refs/heads/depfu/update/capybara-2.15.4 Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service] 0fd0af: Update capybara to version 2.15.4
by Manuel Schnitzer 09 Oct '17

09 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 0fd0afff56395554a2702e31685d6225017ac2c0 https://github.com/openSUSE/open-build-service/commit/0fd0afff56395554a2702… Author: depfu[bot] <depfu[bot](a)users.noreply.github.com> Date: 2017-10-07 (Sat, 07 Oct 2017) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Update capybara to version 2.15.4 Commit: 562172abfea024a2f8604bc1969620856afb3c4a https://github.com/openSUSE/open-build-service/commit/562172abfea024a2f8604… Author: Manuel Schnitzer <github(a)mschnitzer.de> Date: 2017-10-09 (Mon, 09 Oct 2017) Changed paths: M src/api/Gemfile.lock Log Message: ----------- Merge pull request #3961 from openSUSE/depfu/update/capybara-2.15.4 Update capybara to version 2.15.4 Compare: https://github.com/openSUSE/open-build-service/compare/50b04194cef9...56217…

1 0

[obs-commits] [openSUSE/obs-build] 26399f: drop %ul_version in leap 15.0
by GitHub 06 Oct '17

06 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 26399f580fe6927ae91689f09364d503ad94c802 https://github.com/openSUSE/obs-build/commit/26399f580fe6927ae91689f09364d5… Author: Adrian Schröter <adrian(a)suse.de> Date: 2017-10-06 (Fri, 06 Oct 2017) Changed paths: M configs/sl15.0.conf Log Message: ----------- drop %ul_version in leap 15.0

1 0

[obs-commits] [openSUSE/obs-build] 97a699: cleanup sl15.0 config
by GitHub 06 Oct '17

06 Oct '17

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: 97a699b55150e3db58408f3c73dddddcc1789339 https://github.com/openSUSE/obs-build/commit/97a699b55150e3db58408f3c73dddd… Author: Adrian Schröter <adrian(a)suse.de> Date: 2017-10-06 (Fri, 06 Oct 2017) Changed paths: M configs/sl15.0.conf Log Message: ----------- cleanup sl15.0 config

1 0