November 2015 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 2884f5: [api][webui] Autocorrect rubocop rule Lint/StringC...
by Björn Geuken 30 Nov '15

30 Nov '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2884f597df5ede0c3a910a4c44a62a9e7d857b74 https://github.com/openSUSE/open-build-service/commit/2884f597df5ede0c3a910… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/controllers/configurations_controller.rb M src/api/app/controllers/search_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/helpers/flag_helper.rb M src/api/app/helpers/model_helper.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/issue_tracker.rb M src/api/db/migrate/20150902130939_remove_index_from_path_element_position.rb M src/api/lib/activexml/transport.rb M src/api/lib/xpath_engine.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/maintenance_test.rb Log Message: ----------- [api][webui] Autocorrect rubocop rule Lint/StringConversionInInterpolation Commit: 7951220ebb177fda1a6979cac583b18c09625748 https://github.com/openSUSE/open-build-service/commit/7951220ebb177fda1a697… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/controllers/application_controller.rb M src/api/app/models/product.rb M src/api/app/models/role.rb M src/api/lib/memory_debugger.rb M src/api/script/reformat_memprof M src/api/test/functional/read_permission_test.rb M src/api/test/functional/search_controller_test.rb Log Message: ----------- [api][webui] Autocorrect rubocop rule Style/EmptyLineBetweenDefs Commit: fd9c938f45c0304e0eed16756a4b2149de6ab258 https://github.com/openSUSE/open-build-service/commit/fd9c938f45c0304e0eed1… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/controllers/build_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/statistics_controller.rb M src/api/app/controllers/tag_controller.rb M src/api/app/controllers/webui/comments_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/helpers/branch_package.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/mixins/has_attributes.rb M src/api/app/models/attrib_type.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request.rb M src/api/app/models/comment_project.rb M src/api/app/models/flag.rb M src/api/app/models/history_element.rb M src/api/app/models/product.rb M src/api/app/models/project.rb M src/api/app/models/relationship.rb M src/api/app/models/tag.rb M src/api/app/models/tagcloud.rb M src/api/app/models/unregistered_user.rb M src/api/config/deploy.rb M src/api/config/routes.rb M src/api/db/migrate/20121124032111_add_aarch64.rb M src/api/db/migrate/20130220160000_make_obs_rejectrequests_configurable.rb M src/api/db/migrate/20130626160000_attribute_issue_marker.rb M src/api/db/migrate/20131005225515_add_ppc64le.rb M src/api/db/migrate/20131006000000_add_m68k.rb M src/api/db/migrate/20131023063641_add_obs_branch_repositories_attribute.rb M src/api/db/migrate/20140123063641_auto_cleanup_attribute.rb M src/api/db/migrate/20140908135426_incident_priority_attribute.rb M src/api/db/migrate/20140916135426_project_maintains.rb M src/api/db/migrate/20140930135426_track_product_media_archs.rb M src/api/db/migrate/20141001135426_group_subscriptions.rb M src/api/db/migrate/20141107135426_embargo_attribute.rb M src/api/db/migrate/20141201135426_make_origin_older_attribute.rb M src/api/db/migrate/20141202135426_add_makeoriginolder_option.rb M src/api/db/migrate/20141208135426_add_channel_target_disable_option.rb M src/api/db/migrate/20150227063641_add_obs_branch_skip_repositories_attribute.rb M src/api/db/migrate/20150623063641_reindex_sphinx_db.rb M src/api/db/migrate/20150630135426_add_origin_for_acceptinfo.rb M src/api/lib/api_exception.rb M src/api/script/import M src/api/script/start_test_backend M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/distributions_controller_test.rb M src/api/test/functional/group_request_test.rb M src/api/test/functional/kgraft_maintenance_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/read_permission_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/search_controller_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/statistics_controller_test.rb M src/api/test/functional/tag_controller_test.rb M src/api/test/functional/webui/attributes_test.rb M src/api/test/functional/webui/configuration_test.rb M src/api/test/functional/webui/login_test.rb M src/api/test/functional/webui/package_branch_test.rb M src/api/test/functional/webui/package_create_test.rb M src/api/test/functional/webui/package_edit_source_test.rb M src/api/test/functional/webui/package_edit_test.rb M src/api/test/functional/webui/project_edit_test.rb M src/api/test/functional/webui/proxy_mode_test.rb M src/api/test/functional/webui/search_controller_test.rb M src/api/test/unit/attrib_test.rb M src/api/test/unit/attribute_test.rb M src/api/test/unit/build_flag_test.rb M src/api/test/unit/channel_test.rb M src/api/test/unit/debug_flag_test.rb M src/api/test/unit/event_mailer_test.rb M src/api/test/unit/flag_test.rb M src/api/test/unit/package_test.rb M src/api/test/unit/project_test.rb M src/api/test/unit/publish_flag_test.rb M src/api/test/unit/tag_test.rb M src/api/test/unit/tagcloud_test.rb Log Message: ----------- [api][webui] Autocorrect rubocop rule Style/EmptyLines Commit: 1b077ce7b8b2b3923984fa7ffce3481751ce7e4c https://github.com/openSUSE/open-build-service/commit/1b077ce7b8b2b3923984f… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/controllers/application_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/status_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/wizard_controller.rb M src/api/app/helpers/flag_helper.rb M src/api/app/jobs/project_status_calculator.rb M src/api/app/mixins/has_relationships.rb M src/api/app/mixins/webui/load_buildresults.rb M src/api/app/models/attrib_value.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request.rb M src/api/app/models/group_maintainer.rb M src/api/app/models/groups_user.rb M src/api/app/models/linked_project.rb M src/api/app/models/owner.rb M src/api/app/models/package.rb M src/api/app/models/product.rb M src/api/app/models/project.rb M src/api/app/models/status_history_rescaler.rb M src/api/app/models/tag.rb M src/api/app/models/tagcloud.rb M src/api/app/models/user.rb M src/api/config/deploy.rb M src/api/config/environments/development.rb M src/api/config/environments/production.rb M src/api/config/environments/test.rb M src/api/config/initializers/hoptoad.rb M src/api/config/routes.rb M src/api/db/migrate/20140908125426_convert_request_history.rb M src/api/lib/tasks/coverage.rake M src/api/lib/tasks/databases.rake M src/api/lib/tasks/history.rake M src/api/script/import M src/api/test/functional/backend_test.rb M src/api/test/functional/webui/driver_update_controller_test.rb M src/api/test/models/event_test.rb M src/api/test/test_consistency_helper.rb M src/api/test/unit/event_mailer_test.rb M src/api/test/unit/ichain_notifier_test.rb M src/api/test/unit/issue_test.rb Log Message: ----------- [api][webui] Autocorrect rubocop rules Style/EmptyLinesAroundAccessModifier, Style/EmptyLinesAroundBlockBody Commit: ebef7295fe621b12dd56b421a2d39f89c15137f5 https://github.com/openSUSE/open-build-service/commit/ebef7295fe621b12dd56b… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/.rubocop_todo.yml M src/api/app/controllers/about_controller.rb M src/api/app/controllers/application_controller.rb M src/api/app/controllers/architectures_controller.rb M src/api/app/controllers/attribute_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/comments_controller.rb M src/api/app/controllers/group_controller.rb M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/mail_handler_controller.rb M src/api/app/controllers/main_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/published_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/search_controller.rb M src/api/app/controllers/service_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/statistics_controller.rb M src/api/app/controllers/status_controller.rb M src/api/app/controllers/tag_controller.rb M src/api/app/controllers/test_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/apidocs_controller.rb M src/api/app/controllers/webui/attribute_controller.rb M src/api/app/controllers/webui/comments_controller.rb M src/api/app/controllers/webui/driver_update_controller.rb M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/user_controller.rb M src/api/app/controllers/wizard_controller.rb M src/api/app/helpers/branch_package.rb M src/api/app/helpers/flag_helper.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/model_helper.rb M src/api/app/helpers/status_helper.rb M src/api/app/helpers/validation_helper.rb M src/api/app/helpers/webui/comment_helper.rb M src/api/app/helpers/webui/main_helper.rb M src/api/app/helpers/webui/monitor_helper.rb M src/api/app/helpers/webui/package_helper.rb M src/api/app/helpers/webui/patchinfo_helper.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/helpers/webui/request_helper.rb M src/api/app/helpers/webui/search_helper.rb M src/api/app/jobs/cleanup_cache_lines.rb M src/api/app/jobs/create_job.rb M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/jobs/project_log_rotate.rb M src/api/app/jobs/project_status_calculator.rb M src/api/app/jobs/send_event_emails.rb M src/api/app/jobs/update_backend_infos.rb M src/api/app/jobs/update_package_meta_job.rb M src/api/app/jobs/update_released_binaries.rb M src/api/app/mailers/event_mailer.rb M src/api/app/middleware/proxy_mode_faker.rb M src/api/app/mixins/build_log_support.rb M src/api/app/mixins/escaper.rb M src/api/app/mixins/has_attributes.rb M src/api/app/mixins/has_ratings.rb M src/api/app/mixins/has_relationships.rb M src/api/app/mixins/parse_package_diff.rb M src/api/app/mixins/request_source_diff.rb M src/api/app/mixins/test_backend_tasks.rb M src/api/app/mixins/webui/has_comments.rb M src/api/app/mixins/webui/has_flags.rb M src/api/app/mixins/webui/load_buildresults.rb M src/api/app/mixins/webui/manage_relationships.rb M src/api/app/models/architecture.rb M src/api/app/models/attrib_namespace.rb M src/api/app/models/attrib_type.rb M src/api/app/models/attrib_value.rb M src/api/app/models/backend_file.rb M src/api/app/models/backend_package.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_add_role.rb M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/bs_request_action_group.rb M src/api/app/models/bs_request_action_maintenance_incident.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_action_set_bugowner.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/bs_request_permission_check.rb M src/api/app/models/build_container.rb M src/api/app/models/buildresult.rb M src/api/app/models/cache_line.rb M src/api/app/models/channel.rb M src/api/app/models/channel_binary.rb M src/api/app/models/channel_binary_list.rb M src/api/app/models/channel_target.rb M src/api/app/models/comment.rb M src/api/app/models/comment_package.rb M src/api/app/models/comment_project.rb M src/api/app/models/comment_request.rb M src/api/app/models/directory.rb M src/api/app/models/distribution.rb M src/api/app/models/download_repository.rb M src/api/app/models/event/base.rb M src/api/app/models/event/build.rb M src/api/app/models/event/comment.rb M src/api/app/models/event/factory.rb M src/api/app/models/event/notify_backends.rb M src/api/app/models/event/package.rb M src/api/app/models/event/project.rb M src/api/app/models/event/request.rb M src/api/app/models/event_find_subscribers.rb M src/api/app/models/flag.rb M src/api/app/models/group.rb M src/api/app/models/history.rb M src/api/app/models/history_element.rb M src/api/app/models/ichain_notifier.rb M src/api/app/models/incident_updateinfo_counter_value.rb M src/api/app/models/issue.rb M src/api/app/models/issue_tracker.rb M src/api/app/models/maintenance_incident.rb M src/api/app/models/message.rb M src/api/app/models/owner.rb M src/api/app/models/package_build_status.rb M src/api/app/models/package_file.rb M src/api/app/models/patchinfo.rb M src/api/app/models/product.rb M src/api/app/models/product_medium.rb M src/api/app/models/product_update_repository.rb M src/api/app/models/project.rb M src/api/app/models/project_config_file.rb M src/api/app/models/project_file.rb M src/api/app/models/rating.rb M src/api/app/models/repository.rb M src/api/app/models/review.rb M src/api/app/models/role.rb M src/api/app/models/static_permission.rb M src/api/app/models/status_history.rb M src/api/app/models/status_history_rescaler.rb M src/api/app/models/status_message.rb M src/api/app/models/tag.rb M src/api/app/models/tagcloud.rb M src/api/app/models/tagging.rb M src/api/app/models/token.rb M src/api/app/models/unregistered_user.rb M src/api/app/models/update_notification_events.rb M src/api/app/models/updateinfo.rb M src/api/app/models/updateinfo_counter.rb M src/api/app/models/user.rb M src/api/app/models/user_ldap_strategy.rb M src/api/app/models/watched_project.rb M src/api/app/models/wizard_form.rb M src/api/app/models/worker_status.rb M src/api/app/policies/attrib_policy.rb M src/api/app/policies/group_policy.rb M src/api/app/policies/package_policy.rb M src/api/app/policies/project_policy.rb M src/api/config/initializers/01_monkeypatches.rb M src/api/config/initializers/nokogiri_builder.rb M src/api/config/initializers/wrap_parameters.rb M src/api/config/routes.rb M src/api/db/migrate/001_initial_database.rb M src/api/db/migrate/20120907114304_import_requests_delayed.rb M src/api/db/migrate/20121014124846_rename_db_projects.rb M src/api/db/migrate/20121112104534_fix_projects_charset.rb M src/api/db/migrate/20121120124300_add_owner_root_project_attrib_type.rb M src/api/db/migrate/20121124032111_add_aarch64.rb M src/api/db/migrate/20130220160000_make_obs_rejectrequests_configurable.rb M src/api/db/migrate/20130301100000_add_release_target_constraints.rb M src/api/db/migrate/20130409123324_move_actions_to_type.rb M src/api/db/migrate/20130610100244_manual_release_trigger.rb M src/api/db/migrate/20130626160000_attribute_issue_marker.rb M src/api/db/migrate/20130702203665_write_configuration.rb M src/api/db/migrate/20130802183717_move_relationships.rb M src/api/db/migrate/20130910162318_create_backend_package.rb M src/api/db/migrate/20131005225515_add_ppc64le.rb M src/api/db/migrate/20131006000000_add_m68k.rb M src/api/db/migrate/20131022114302_check_deleted_repo.rb M src/api/db/migrate/20131023063641_add_obs_branch_repositories_attribute.rb M src/api/db/migrate/20131027122410_add_primary_to_repository_architectures.rb M src/api/db/migrate/20131111090310_remove_bs_prefix_from_user.rb M src/api/db/migrate/20131123113417_get_rid_of_db_prefix.rb M src/api/db/migrate/20131209103450_add_primary_to_groups_users.rb M src/api/db/migrate/20131210182719_change_subscriptions.rb M src/api/db/migrate/20140123063641_auto_cleanup_attribute.rb M src/api/db/migrate/20140516182719_fix_configuration_register_enum.rb M src/api/db/migrate/20140624101042_add_package_tracking.rb M src/api/db/migrate/20140717101042_add_updateinfo_tracking.rb M src/api/db/migrate/20140729101042_updateinfo_tracking_second_attempt.rb M src/api/db/migrate/20140903125426_add_generic_operation_history.rb M src/api/db/migrate/20140908135426_incident_priority_attribute.rb M src/api/db/migrate/20140916135426_project_maintains.rb M src/api/db/migrate/20140930135426_track_product_media_archs.rb M src/api/db/migrate/20141001135426_group_subscriptions.rb M src/api/db/migrate/20141107135426_embargo_attribute.rb M src/api/db/migrate/20141125105426_add_github_issue_parser.rb M src/api/db/migrate/20141201135426_make_origin_older_attribute.rb M src/api/db/migrate/20141202135426_add_makeoriginolder_option.rb M src/api/db/migrate/20141208135426_add_channel_target_disable_option.rb M src/api/db/migrate/20150112135426_adapt_cve_tracker.rb M src/api/db/migrate/20150227063641_add_obs_branch_skip_repositories_attribute.rb M src/api/db/migrate/20150623063641_reindex_sphinx_db.rb M src/api/db/migrate/20150630135426_add_origin_for_acceptinfo.rb M src/api/db/migrate/20150716124906_add_type_to_project.rb M src/api/db/migrate/20150807105426_new_dod_table.rb M src/api/db/migrate/20150903084813_remove_request_from_maintenance_incident.rb M src/api/db/migrate/20150916084813_add_modify_time_to_binary_release.rb M src/api/lib/activexml/node.rb M src/api/lib/activexml/transport.rb M src/api/lib/api_exception.rb M src/api/lib/login_system.rb M src/api/lib/memory_dumper.rb M src/api/lib/obsapi/test_sphinx.rb M src/api/lib/opensuse/backend.rb M src/api/lib/opensuse/permission.rb M src/api/lib/opensuse/validator.rb M src/api/lib/workers/accept_requests.rb M src/api/lib/workers/import_requests.rb M src/api/lib/workers/update_issues.rb M src/api/lib/workers/write_configuration.rb M src/api/lib/xpath_engine.rb M src/api/test/activexml_matcher.rb M src/api/test/functional/about_controller_test.rb M src/api/test/functional/architectures_controller_test.rb M src/api/test/functional/attributes_test.rb M src/api/test/functional/backend_test.rb M src/api/test/functional/binary_release_test.rb M src/api/test/functional/branch_publish_flag_test.rb M src/api/test/functional/build_controller_test.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/comments_controller_test.rb M src/api/test/functional/cross_build_test.rb M src/api/test/functional/group_request_test.rb M src/api/test/functional/group_test.rb M src/api/test/functional/interconnect_test.rb M src/api/test/functional/issue_trackers_controller_test.rb M src/api/test/functional/kgraft_maintenance_test.rb M src/api/test/functional/main_controller_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/message_controller_test.rb M src/api/test/functional/person_controller_test.rb M src/api/test/functional/public_controller_test.rb M src/api/test/functional/published_controller_test.rb M src/api/test/functional/read_permission_test.rb M src/api/test/functional/release_management_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/request_events_test.rb M src/api/test/functional/search_controller_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/statistics_controller_test.rb M src/api/test/functional/status_controller_test.rb M src/api/test/functional/tag_controller_test.rb M src/api/test/functional/webui/add_repo_test.rb M src/api/test/functional/webui/anonymous_test.rb M src/api/test/functional/webui/apidocs_controller_test.rb M src/api/test/functional/webui/apiroutes_test.rb M src/api/test/functional/webui/application_controller_test.rb M src/api/test/functional/webui/attributes_test.rb M src/api/test/functional/webui/commits_feed_test.rb M src/api/test/functional/webui/configuration_test.rb M src/api/test/functional/webui/create_test.rb M src/api/test/functional/webui/driver_update_controller_test.rb M src/api/test/functional/webui/has_flags_test.rb M src/api/test/functional/webui/login_test.rb M src/api/test/functional/webui/main_controller_test.rb M src/api/test/functional/webui/maintenance_workflow_test.rb M src/api/test/functional/webui/messages_test.rb M src/api/test/functional/webui/monitor_controller_test.rb M src/api/test/functional/webui/owner_search_test.rb M src/api/test/functional/webui/package_branch_test.rb M src/api/test/functional/webui/package_controller_test.rb M src/api/test/functional/webui/package_create_test.rb M src/api/test/functional/webui/package_edit_test.rb M src/api/test/functional/webui/patchinfo_controller_test.rb M src/api/test/functional/webui/project_controller_test.rb M src/api/test/functional/webui/project_edit_test.rb M src/api/test/functional/webui/proxy_mode_test.rb M src/api/test/functional/webui/request_controller_test.rb M src/api/test/functional/webui/search_controller_test.rb M src/api/test/functional/webui/spider_test.rb M src/api/test/functional/webui/user_controller_test.rb M src/api/test/functional/webui/watchlists_test.rb M src/api/test/functional/wizard_controller_test.rb M src/api/test/functional/zzz_post_consistency_test.rb M src/api/test/integration/last_events_test.rb M src/api/test/models/backend_info_test.rb M src/api/test/models/event_test.rb M src/api/test/models/status_history_test.rb M src/api/test/policies/attrib_policy_test.rb M src/api/test/test_helper.rb M src/api/test/unit/attrib_test.rb M src/api/test/unit/attribute_test.rb M src/api/test/unit/binary_release.rb M src/api/test/unit/bs_request_test.rb M src/api/test/unit/build_flag_test.rb M src/api/test/unit/channel_test.rb M src/api/test/unit/comment_test.rb M src/api/test/unit/debug_flag_test.rb M src/api/test/unit/event_mailer_test.rb M src/api/test/unit/flag_test.rb M src/api/test/unit/groups_users_test.rb M src/api/test/unit/history_test.rb M src/api/test/unit/issue_test.rb M src/api/test/unit/linked_project_test.rb M src/api/test/unit/package_group_role_relationship_test.rb M src/api/test/unit/package_remove_test.rb M src/api/test/unit/package_test.rb M src/api/test/unit/product_test.rb M src/api/test/unit/project_remove_test.rb M src/api/test/unit/project_test.rb M src/api/test/unit/publish_flag_test.rb M src/api/test/unit/role_test.rb M src/api/test/unit/schema_test.rb M src/api/test/unit/status_helper_test.rb M src/api/test/unit/status_message_test.rb M src/api/test/unit/tag_test.rb M src/api/test/unit/tagcloud_test.rb M src/api/test/unit/user_ldap_strategy_test.rb M src/api/test/unit/user_test.rb M src/api/test/unit/validator_test.rb M src/api/test/unit/watched_project_test.rb M src/api/test/unit/worker_status_test.rb Log Message: ----------- [api][webui] Autocorrect rubocop rules Fixed rules are: Style/EmptyLinesAroundClassBody Style/EmptyLinesAroundMethodBody Style/EmptyLinesAroundModuleBody Commit: 9a113dd481febb4e7fdf945f2787a26f7a1b598a https://github.com/openSUSE/open-build-service/commit/9a113dd481febb4e7fdf9… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/.rubocop_todo.yml M src/api/Gemfile M src/api/app/controllers/application_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/search_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/status_controller.rb M src/api/app/controllers/tag_controller.rb M src/api/app/controllers/webui/driver_update_controller.rb M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/helpers/branch_package.rb M src/api/app/helpers/flag_helper.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/validation_helper.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/mixins/has_relationships.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/group.rb M src/api/app/models/owner.rb M src/api/app/models/package.rb M src/api/app/models/patchinfo.rb M src/api/app/models/project.rb M src/api/app/models/relationship.rb M src/api/app/models/repository.rb M src/api/app/models/tag.rb M src/api/app/models/tagcloud.rb M src/api/app/models/user.rb M src/api/app/models/user_ldap_strategy.rb M src/api/config/application.rb M src/api/config/deploy.rb M src/api/config/environments/production.rb M src/api/config/routes.rb M src/api/db/migrate/20121112104534_fix_projects_charset.rb M src/api/db/migrate/20140908125426_convert_request_history.rb M src/api/lib/activexml/node.rb M src/api/lib/activexml/transport.rb M src/api/lib/opensuse/backend.rb M src/api/lib/opensuse/permission.rb M src/api/lib/opensuse/validator.rb M src/api/lib/tasks/databases.rake M src/api/lib/tasks/extract.rake M src/api/lib/tasks/sprites.rake M src/api/lib/xpath_engine.rb M src/api/script/import M src/api/test/functional/build_controller_test.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/distributions_controller_test.rb M src/api/test/functional/group_test.rb M src/api/test/functional/interconnect_test.rb M src/api/test/functional/issue_controller_test.rb M src/api/test/functional/issue_trackers_controller_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/person_controller_test.rb M src/api/test/functional/product_test.rb M src/api/test/functional/published_controller_test.rb M src/api/test/functional/read_permission_test.rb M src/api/test/functional/release_management_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/search_controller_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/statistics_controller_test.rb M src/api/test/functional/tag_controller_test.rb M src/api/test/functional/webui/attributes_test.rb M src/api/test/functional/webui/commits_feed_test.rb M src/api/test/functional/webui/maintenance_workflow_test.rb M src/api/test/functional/webui/monitor_controller_test.rb M src/api/test/functional/webui/patchinfo_controller_test.rb M src/api/test/functional/webui/request_controller_test.rb M src/api/test/functional/webui/search_controller_test.rb M src/api/test/functional/webui/spider_test.rb M src/api/test/test_helper.rb M src/api/test/unit/attribute_test.rb M src/api/test/unit/bs_request_test.rb M src/api/test/unit/build_flag_test.rb M src/api/test/unit/channel_test.rb M src/api/test/unit/debug_flag_test.rb M src/api/test/unit/flag_test.rb M src/api/test/unit/ichain_notifier_test.rb M src/api/test/unit/issue_test.rb M src/api/test/unit/package_remove_test.rb M src/api/test/unit/package_test.rb M src/api/test/unit/product_test.rb M src/api/test/unit/project_remove_test.rb M src/api/test/unit/project_test.rb M src/api/test/unit/publish_flag_test.rb M src/api/test/unit/status_message_test.rb M src/api/test/unit/tag_test.rb M src/api/test/unit/tagcloud_test.rb M src/api/test/unit/user_ldap_strategy_test.rb M src/api/test/unit/user_test.rb Log Message: ----------- [api][webui] Autocorrect rubocop rule Style/LeadingCommentSpace Commit: 6c73b7ae262746a37b650414834a272c94cb31bb https://github.com/openSUSE/open-build-service/commit/6c73b7ae262746a37b650… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request.rb M src/api/app/models/channel_binary.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/lib/activexml/transport.rb Log Message: ----------- [api][webui] Apply rubocop rule Lint/FormatParameterMismatch app/controllers/webui/package_controller.rb:806:37: W: Lint/FormatParameterMismatch: Number arguments (0) to String#% mismatches expected fields (1). logger.debug("log size is %d" % size) Commit: 660a5d11f1af6fb9ef0d507df069358bf1a91285 https://github.com/openSUSE/open-build-service/commit/660a5d11f1af6fb9ef0d5… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/app/models/bs_request.rb Log Message: ----------- [ci] Silence falsy rubocop report app/models/bs_request.rb:610:13: C: Style/CommentAnnotation: Annotation keywords like review should be all upper case, followed by a colon, and a space, then a note describing the problem. # review got declined or superseded or reopened. ^^^^^^^ Commit: d57f55e88adc3e3d3c27895c878b9417639309ed https://github.com/openSUSE/open-build-service/commit/d57f55e88adc3e3d3c278… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- [ci] Fix Metrics/LineLength error Commit: 89b0f9dc82e0bdd14317fbf5869df4f40532f322 https://github.com/openSUSE/open-build-service/commit/89b0f9dc82e0bdd14317f… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/.rubocop_todo.yml Log Message: ----------- [ci] Update rubocop todo file Note that the Lint/UnneededDisable exclude comes from a mismatch between running 'rubocop --auto-gen-config' and 'rake rubocop'. The latter is used by our test suite and would fail on the Style/CommentAnnotation fixed in 2dd520ba28d359c4563 Commit: 8db216083a5e4ea90774d70f403e888a2c4a92e7 https://github.com/openSUSE/open-build-service/commit/8db216083a5e4ea90774d… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/app/controllers/webui/package_controller.rb Log Message: ----------- [ci] Fix rubocop violation: Style/ElseAlignment Commit: dfd58fd4683b1bd7bf12790c780ea67464fa054c https://github.com/openSUSE/open-build-service/commit/dfd58fd4683b1bd7bf127… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/app/controllers/webui/project_controller.rb M src/api/app/helpers/admin_helper.rb Log Message: ----------- [ci] Fix recently introduced offenses Those recent commits would cause rubocop failures after merging... Commit: d470e9fba3bd9722552a9ecce969488655f34b2b https://github.com/openSUSE/open-build-service/commit/d470e9fba3bd9722552a9… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/.rubocop_todo.yml M src/api/Gemfile M src/api/app/controllers/about_controller.rb M src/api/app/controllers/application_controller.rb M src/api/app/controllers/architectures_controller.rb M src/api/app/controllers/attribute_controller.rb M src/api/app/controllers/build_controller.rb M src/api/app/controllers/comments_controller.rb M src/api/app/controllers/configurations_controller.rb M src/api/app/controllers/group_controller.rb M src/api/app/controllers/issue_trackers_controller.rb M src/api/app/controllers/mail_handler_controller.rb M src/api/app/controllers/main_controller.rb M src/api/app/controllers/message_controller.rb M src/api/app/controllers/person_controller.rb M src/api/app/controllers/public_controller.rb M src/api/app/controllers/published_controller.rb M src/api/app/controllers/request_controller.rb M src/api/app/controllers/search_controller.rb M src/api/app/controllers/service_controller.rb M src/api/app/controllers/source_controller.rb M src/api/app/controllers/statistics_controller.rb M src/api/app/controllers/status_controller.rb M src/api/app/controllers/tag_controller.rb M src/api/app/controllers/test_controller.rb M src/api/app/controllers/trigger_controller.rb M src/api/app/controllers/webui/apidocs_controller.rb M src/api/app/controllers/webui/attribute_controller.rb M src/api/app/controllers/webui/comments_controller.rb M src/api/app/controllers/webui/driver_update_controller.rb M src/api/app/controllers/webui/feeds_controller.rb M src/api/app/controllers/webui/main_controller.rb M src/api/app/controllers/webui/monitor_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/controllers/webui/project_controller.rb M src/api/app/controllers/webui/request_controller.rb M src/api/app/controllers/webui/user_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/app/controllers/wizard_controller.rb M src/api/app/helpers/admin_helper.rb M src/api/app/helpers/branch_package.rb M src/api/app/helpers/flag_helper.rb M src/api/app/helpers/maintenance_helper.rb M src/api/app/helpers/model_helper.rb M src/api/app/helpers/status_helper.rb M src/api/app/helpers/validation_helper.rb M src/api/app/helpers/webui/comment_helper.rb M src/api/app/helpers/webui/main_helper.rb M src/api/app/helpers/webui/monitor_helper.rb M src/api/app/helpers/webui/package_helper.rb M src/api/app/helpers/webui/patchinfo_helper.rb M src/api/app/helpers/webui/project_helper.rb M src/api/app/helpers/webui/request_helper.rb M src/api/app/helpers/webui/search_helper.rb M src/api/app/jobs/cleanup_cache_lines.rb M src/api/app/jobs/create_job.rb M src/api/app/jobs/project_create_auto_cleanup_requests.rb M src/api/app/jobs/project_log_rotate.rb M src/api/app/jobs/project_status_calculator.rb M src/api/app/jobs/send_event_emails.rb M src/api/app/jobs/update_backend_infos.rb M src/api/app/jobs/update_package_meta_job.rb M src/api/app/jobs/update_released_binaries.rb M src/api/app/mailers/event_mailer.rb M src/api/app/middleware/proxy_mode_faker.rb M src/api/app/mixins/build_log_support.rb M src/api/app/mixins/escaper.rb M src/api/app/mixins/has_attributes.rb M src/api/app/mixins/has_ratings.rb M src/api/app/mixins/has_relationships.rb M src/api/app/mixins/parse_package_diff.rb M src/api/app/mixins/request_source_diff.rb M src/api/app/mixins/test_backend_tasks.rb M src/api/app/mixins/webui/has_comments.rb M src/api/app/mixins/webui/has_flags.rb M src/api/app/mixins/webui/load_buildresults.rb M src/api/app/mixins/webui/manage_relationships.rb M src/api/app/models/architecture.rb M src/api/app/models/attrib_namespace.rb M src/api/app/models/attrib_type.rb M src/api/app/models/attrib_value.rb M src/api/app/models/backend_file.rb M src/api/app/models/backend_package.rb M src/api/app/models/binary_release.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action.rb M src/api/app/models/bs_request_action_add_role.rb M src/api/app/models/bs_request_action_delete.rb M src/api/app/models/bs_request_action_group.rb M src/api/app/models/bs_request_action_maintenance_incident.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/app/models/bs_request_action_set_bugowner.rb M src/api/app/models/bs_request_action_submit.rb M src/api/app/models/bs_request_permission_check.rb M src/api/app/models/build_container.rb M src/api/app/models/buildresult.rb M src/api/app/models/cache_line.rb M src/api/app/models/channel.rb M src/api/app/models/channel_binary.rb M src/api/app/models/channel_binary_list.rb M src/api/app/models/channel_target.rb M src/api/app/models/comment.rb M src/api/app/models/comment_package.rb M src/api/app/models/comment_project.rb M src/api/app/models/comment_request.rb M src/api/app/models/directory.rb M src/api/app/models/distribution.rb M src/api/app/models/download_repository.rb M src/api/app/models/event/base.rb M src/api/app/models/event/build.rb M src/api/app/models/event/comment.rb M src/api/app/models/event/factory.rb M src/api/app/models/event/notify_backends.rb M src/api/app/models/event/package.rb M src/api/app/models/event/project.rb M src/api/app/models/event/request.rb M src/api/app/models/event_find_subscribers.rb M src/api/app/models/flag.rb M src/api/app/models/group.rb M src/api/app/models/group_maintainer.rb M src/api/app/models/groups_user.rb M src/api/app/models/history.rb M src/api/app/models/history_element.rb M src/api/app/models/ichain_notifier.rb M src/api/app/models/incident_updateinfo_counter_value.rb M src/api/app/models/issue.rb M src/api/app/models/issue_tracker.rb M src/api/app/models/linked_project.rb M src/api/app/models/maintenance_incident.rb M src/api/app/models/message.rb M src/api/app/models/owner.rb M src/api/app/models/package.rb M src/api/app/models/package_build_status.rb M src/api/app/models/package_file.rb M src/api/app/models/patchinfo.rb M src/api/app/models/product.rb M src/api/app/models/product_medium.rb M src/api/app/models/product_update_repository.rb M src/api/app/models/project.rb M src/api/app/models/project_config_file.rb M src/api/app/models/project_file.rb M src/api/app/models/rating.rb M src/api/app/models/relationship.rb M src/api/app/models/repository.rb M src/api/app/models/review.rb M src/api/app/models/role.rb M src/api/app/models/static_permission.rb M src/api/app/models/status_history.rb M src/api/app/models/status_history_rescaler.rb M src/api/app/models/status_message.rb M src/api/app/models/tag.rb M src/api/app/models/tagcloud.rb M src/api/app/models/tagging.rb M src/api/app/models/token.rb M src/api/app/models/unregistered_user.rb M src/api/app/models/update_notification_events.rb M src/api/app/models/updateinfo.rb M src/api/app/models/updateinfo_counter.rb M src/api/app/models/user.rb M src/api/app/models/user_ldap_strategy.rb M src/api/app/models/watched_project.rb M src/api/app/models/wizard_form.rb M src/api/app/models/worker_status.rb M src/api/app/policies/attrib_policy.rb M src/api/app/policies/group_policy.rb M src/api/app/policies/package_policy.rb M src/api/app/policies/project_policy.rb M src/api/config/application.rb M src/api/config/deploy.rb M src/api/config/environments/development.rb M src/api/config/environments/production.rb M src/api/config/environments/test.rb M src/api/config/initializers/01_monkeypatches.rb M src/api/config/initializers/hoptoad.rb M src/api/config/initializers/nokogiri_builder.rb M src/api/config/initializers/wrap_parameters.rb M src/api/config/routes.rb M src/api/db/migrate/001_initial_database.rb M src/api/db/migrate/20120907114304_import_requests_delayed.rb M src/api/db/migrate/20121014124846_rename_db_projects.rb M src/api/db/migrate/20121112104534_fix_projects_charset.rb M src/api/db/migrate/20121120124300_add_owner_root_project_attrib_type.rb M src/api/db/migrate/20121124032111_add_aarch64.rb M src/api/db/migrate/20130220160000_make_obs_rejectrequests_configurable.rb M src/api/db/migrate/20130301100000_add_release_target_constraints.rb M src/api/db/migrate/20130409123324_move_actions_to_type.rb M src/api/db/migrate/20130610100244_manual_release_trigger.rb M src/api/db/migrate/20130626160000_attribute_issue_marker.rb M src/api/db/migrate/20130702203665_write_configuration.rb M src/api/db/migrate/20130802183717_move_relationships.rb M src/api/db/migrate/20130910162318_create_backend_package.rb M src/api/db/migrate/20131005225515_add_ppc64le.rb M src/api/db/migrate/20131006000000_add_m68k.rb M src/api/db/migrate/20131022114302_check_deleted_repo.rb M src/api/db/migrate/20131023063641_add_obs_branch_repositories_attribute.rb M src/api/db/migrate/20131027122410_add_primary_to_repository_architectures.rb M src/api/db/migrate/20131111090310_remove_bs_prefix_from_user.rb M src/api/db/migrate/20131123113417_get_rid_of_db_prefix.rb M src/api/db/migrate/20131209103450_add_primary_to_groups_users.rb M src/api/db/migrate/20131210182719_change_subscriptions.rb M src/api/db/migrate/20140123063641_auto_cleanup_attribute.rb M src/api/db/migrate/20140516182719_fix_configuration_register_enum.rb M src/api/db/migrate/20140624101042_add_package_tracking.rb M src/api/db/migrate/20140717101042_add_updateinfo_tracking.rb M src/api/db/migrate/20140729101042_updateinfo_tracking_second_attempt.rb M src/api/db/migrate/20140903125426_add_generic_operation_history.rb M src/api/db/migrate/20140908125426_convert_request_history.rb M src/api/db/migrate/20140908135426_incident_priority_attribute.rb M src/api/db/migrate/20140916135426_project_maintains.rb M src/api/db/migrate/20140930135426_track_product_media_archs.rb M src/api/db/migrate/20141001135426_group_subscriptions.rb M src/api/db/migrate/20141107135426_embargo_attribute.rb M src/api/db/migrate/20141125105426_add_github_issue_parser.rb M src/api/db/migrate/20141201135426_make_origin_older_attribute.rb M src/api/db/migrate/20141202135426_add_makeoriginolder_option.rb M src/api/db/migrate/20141208135426_add_channel_target_disable_option.rb M src/api/db/migrate/20150112135426_adapt_cve_tracker.rb M src/api/db/migrate/20150227063641_add_obs_branch_skip_repositories_attribute.rb M src/api/db/migrate/20150623063641_reindex_sphinx_db.rb M src/api/db/migrate/20150630135426_add_origin_for_acceptinfo.rb M src/api/db/migrate/20150716124906_add_type_to_project.rb M src/api/db/migrate/20150807105426_new_dod_table.rb M src/api/db/migrate/20150902130939_remove_index_from_path_element_position.rb M src/api/db/migrate/20150903084813_remove_request_from_maintenance_incident.rb M src/api/db/migrate/20150916084813_add_modify_time_to_binary_release.rb M src/api/lib/activexml/node.rb M src/api/lib/activexml/transport.rb M src/api/lib/api_exception.rb M src/api/lib/login_system.rb M src/api/lib/memory_debugger.rb M src/api/lib/memory_dumper.rb M src/api/lib/obsapi/test_sphinx.rb M src/api/lib/opensuse/backend.rb M src/api/lib/opensuse/permission.rb M src/api/lib/opensuse/validator.rb M src/api/lib/tasks/coverage.rake M src/api/lib/tasks/databases.rake M src/api/lib/tasks/extract.rake M src/api/lib/tasks/history.rake M src/api/lib/tasks/sprites.rake M src/api/lib/workers/accept_requests.rb M src/api/lib/workers/import_requests.rb M src/api/lib/workers/update_issues.rb M src/api/lib/workers/write_configuration.rb M src/api/lib/xpath_engine.rb M src/api/script/import M src/api/script/reformat_memprof M src/api/script/start_test_backend M src/api/test/activexml_matcher.rb M src/api/test/functional/about_controller_test.rb M src/api/test/functional/architectures_controller_test.rb M src/api/test/functional/attributes_test.rb M src/api/test/functional/backend_test.rb M src/api/test/functional/binary_release_test.rb M src/api/test/functional/branch_publish_flag_test.rb M src/api/test/functional/build_controller_test.rb M src/api/test/functional/channel_maintenance_test.rb M src/api/test/functional/comments_controller_test.rb M src/api/test/functional/cross_build_test.rb M src/api/test/functional/distributions_controller_test.rb M src/api/test/functional/group_request_test.rb M src/api/test/functional/group_test.rb M src/api/test/functional/interconnect_test.rb M src/api/test/functional/issue_controller_test.rb M src/api/test/functional/issue_trackers_controller_test.rb M src/api/test/functional/kgraft_maintenance_test.rb M src/api/test/functional/main_controller_test.rb M src/api/test/functional/maintenance_test.rb M src/api/test/functional/message_controller_test.rb M src/api/test/functional/person_controller_test.rb M src/api/test/functional/product_test.rb M src/api/test/functional/public_controller_test.rb M src/api/test/functional/published_controller_test.rb M src/api/test/functional/read_permission_test.rb M src/api/test/functional/release_management_test.rb M src/api/test/functional/request_controller_test.rb M src/api/test/functional/request_events_test.rb M src/api/test/functional/search_controller_test.rb M src/api/test/functional/source_controller_test.rb M src/api/test/functional/statistics_controller_test.rb M src/api/test/functional/status_controller_test.rb M src/api/test/functional/tag_controller_test.rb M src/api/test/functional/webui/add_repo_test.rb M src/api/test/functional/webui/anonymous_test.rb M src/api/test/functional/webui/apidocs_controller_test.rb M src/api/test/functional/webui/apiroutes_test.rb M src/api/test/functional/webui/application_controller_test.rb M src/api/test/functional/webui/attributes_test.rb M src/api/test/functional/webui/commits_feed_test.rb M src/api/test/functional/webui/configuration_test.rb M src/api/test/functional/webui/create_test.rb M src/api/test/functional/webui/driver_update_controller_test.rb M src/api/test/functional/webui/has_flags_test.rb M src/api/test/functional/webui/login_test.rb M src/api/test/functional/webui/main_controller_test.rb M src/api/test/functional/webui/maintenance_workflow_test.rb M src/api/test/functional/webui/messages_test.rb M src/api/test/functional/webui/monitor_controller_test.rb M src/api/test/functional/webui/owner_search_test.rb M src/api/test/functional/webui/package_branch_test.rb M src/api/test/functional/webui/package_controller_test.rb M src/api/test/functional/webui/package_create_test.rb M src/api/test/functional/webui/package_edit_source_test.rb M src/api/test/functional/webui/package_edit_test.rb M src/api/test/functional/webui/patchinfo_controller_test.rb M src/api/test/functional/webui/project_controller_test.rb M src/api/test/functional/webui/project_edit_test.rb M src/api/test/functional/webui/proxy_mode_test.rb M src/api/test/functional/webui/request_controller_test.rb M src/api/test/functional/webui/search_controller_test.rb M src/api/test/functional/webui/spider_test.rb M src/api/test/functional/webui/user_controller_test.rb M src/api/test/functional/webui/watchlists_test.rb M src/api/test/functional/wizard_controller_test.rb M src/api/test/functional/zzz_post_consistency_test.rb M src/api/test/integration/last_events_test.rb M src/api/test/models/backend_info_test.rb M src/api/test/models/event_test.rb M src/api/test/models/status_history_test.rb M src/api/test/policies/attrib_policy_test.rb M src/api/test/test_consistency_helper.rb M src/api/test/test_helper.rb M src/api/test/unit/attrib_test.rb M src/api/test/unit/attribute_test.rb M src/api/test/unit/binary_release.rb M src/api/test/unit/bs_request_test.rb M src/api/test/unit/build_flag_test.rb M src/api/test/unit/channel_test.rb M src/api/test/unit/comment_test.rb M src/api/test/unit/debug_flag_test.rb M src/api/test/unit/event_mailer_test.rb M src/api/test/unit/flag_test.rb M src/api/test/unit/groups_users_test.rb M src/api/test/unit/history_test.rb M src/api/test/unit/ichain_notifier_test.rb M src/api/test/unit/issue_test.rb M src/api/test/unit/linked_project_test.rb M src/api/test/unit/package_group_role_relationship_test.rb M src/api/test/unit/package_remove_test.rb M src/api/test/unit/package_test.rb M src/api/test/unit/product_test.rb M src/api/test/unit/project_remove_test.rb M src/api/test/unit/project_test.rb M src/api/test/unit/publish_flag_test.rb M src/api/test/unit/role_test.rb M src/api/test/unit/schema_test.rb M src/api/test/unit/status_helper_test.rb M src/api/test/unit/status_message_test.rb M src/api/test/unit/tag_test.rb M src/api/test/unit/tagcloud_test.rb M src/api/test/unit/user_ldap_strategy_test.rb M src/api/test/unit/user_test.rb M src/api/test/unit/validator_test.rb M src/api/test/unit/watched_project_test.rb M src/api/test/unit/worker_status_test.rb Log Message: ----------- Merge pull request #1412 from bgeuken/rubocop_fixes Some more rubocop auto correct fixes Compare: https://github.com/openSUSE/open-build-service/compare/c4537ee95bdd...d470e…

1 0

[obs-commits] [openSUSE/open-build-service] ae13ca: [api][webui] avoid wrong usage of User.can_modify_...
by Moisés Déniz Alemán 30 Nov '15

30 Nov '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ae13cabf7b717a7191d67b9714faa27f00c69e9f https://github.com/openSUSE/open-build-service/commit/ae13cabf7b717a7191d67… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-11-02 (Mon, 02 Nov 2015) Changed paths: M src/api/app/models/user.rb Log Message: ----------- [api][webui] avoid wrong usage of User.can_modify_project? can_modify_project? must not be used on non-stored projects. We check only at store time creation permissions, so we would just skip them here. There is a convenience method in Project.check_write_access(!) to call the right check depending on if a project got created already or not. Raise an error, when this is not done right. Fixes obs#1291 Commit: c4537ee95bddb34713af517e415b5ac90278165a https://github.com/openSUSE/open-build-service/commit/c4537ee95bddb34713af5… Author: Moisés Déniz Alemán <mdeniz(a)users.noreply.github.com> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/app/models/user.rb Log Message: ----------- Merge pull request #1328 from adrianschroeter/avoid_illegal_usage_of_can_modify [api][webui] avoid wrong usage of User.can_modify_project? We agree that is a solution for now. Compare: https://github.com/openSUSE/open-build-service/compare/eba5104d0f99...c4537…

1 0

[obs-commits] [openSUSE/open-build-service] 07cb59: [backend] split RPC code into BSSched::RPC.pm
by M0ses 30 Nov '15

30 Nov '15

Branch: refs/heads/prep_sched_split Home: https://github.com/openSUSE/open-build-service Commit: 07cb59a33ca8b3cad2ceae3945f95e03154c8648 https://github.com/openSUSE/open-build-service/commit/07cb59a33ca8b3cad2cea… Author: M0ses <schreiner(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: A src/backend/BSSched/RPC.pm M src/backend/bs_sched Log Message: ----------- [backend] split RPC code into BSSched::RPC.pm

1 0

[obs-commits] [openSUSE/open-build-service] 3a5e05: [backend] more xrpc refactoring
by Michael Schroeder 30 Nov '15

30 Nov '15

Branch: refs/heads/prep_sched_split Home: https://github.com/openSUSE/open-build-service Commit: 3a5e05fa71ba12a349b7c9afdb80e98d8d7c9f82 https://github.com/openSUSE/open-build-service/commit/3a5e05fa71ba12a349b7c… Author: Michael Schroeder <mls(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/backend/bs_sched Log Message: ----------- [backend] more xrpc refactoring - the resume functions now get called with the context - xrpc_setchanged needs to be called with context and handle - get_projpacks and update_project_meta are now called with gctx and not ctx (which makes much more sense). The changed prp is passed with the async parameter.

1 0

[obs-commits] [openSUSE/obs-build] f833c0: Fix the path to the chroot binary inside the busyb...
by GitHub 30 Nov '15

30 Nov '15

Branch: refs/heads/master Home: https://github.com/openSUSE/obs-build Commit: f833c08f572e2f466fd81d59f05da6097a5e2605 https://github.com/openSUSE/obs-build/commit/f833c08f572e2f466fd81d59f05da6… Author: Dan Liew <daniel.liew(a)imperial.ac.uk> Date: 2015-11-29 (Sun, 29 Nov 2015) Changed paths: M build-vm-docker Log Message: ----------- Fix the path to the chroot binary inside the busybox image. The path is ``/bin/chroot`` not ``/usr/sbin/chroot``. The ``/usr/sbin/`` directory exists but it is empty. Tested with ``busybox:1.24`` and ``busybox:latest`` image. Commit: ab1e6fc990def29938a900c4f7dc6badb7fd51cc https://github.com/openSUSE/obs-build/commit/ab1e6fc990def29938a900c4f7dc6b… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M build-vm-docker Log Message: ----------- Merge pull request #223 from delcypher/fix_docker Fix the path to the chroot binary inside the busybox image. The Compare: https://github.com/openSUSE/obs-build/compare/d34dd6a13756...ab1e6fc990de

1 0

[obs-commits] [openSUSE/open-build-service] 60deb3: [vagrant] implemented 2 independent vagrant vms
by Adrian Schröter 30 Nov '15

30 Nov '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 60deb3150bebd0df63310d9068d18fc188a1dc18 https://github.com/openSUSE/open-build-service/commit/60deb3150bebd0df63310… Author: M0ses <fs(a)isarnet.de> Date: 2015-11-25 (Wed, 25 Nov 2015) Changed paths: M README.md M Vagrantfile A bootstrap-appliance-finalize.sh A bootstrap-appliance.sh M bootstrap.sh Log Message: ----------- [vagrant] implemented 2 independent vagrant vms * one for developing the frontend ** fixed output of provisioner script (RAILS_ENV=development was missing) * one for testing deploment and appliance * added code to make Vagrantfile more usable with vagrant-libvirt Commit: ff1038f9ecf46cc8b11325370096459512af5f43 https://github.com/openSUSE/open-build-service/commit/ff1038f9ecf46cc8b1132… Author: M0ses <fs(a)isarnet.de> Date: 2015-11-28 (Sat, 28 Nov 2015) Changed paths: M bootstrap.sh Log Message: ----------- [vagrant] log dir now gets mounted To avoid problems with shared folders in virtualbox we use a tmp dir and mount it with bind because permissions must be changed to vagrant user in libvirt for backend to run. Commit: eba5104d0f99f3534a6df2d310633f73c0cacc21 https://github.com/openSUSE/open-build-service/commit/eba5104d0f99f3534a6df… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M README.md M Vagrantfile A bootstrap-appliance-finalize.sh A bootstrap-appliance.sh M bootstrap.sh Log Message: ----------- Merge pull request #1403 from M0ses/vagrant-new [vagrant] implemented 2 independent vagrant vms Compare: https://github.com/openSUSE/open-build-service/compare/0d915e60172a...eba51…

1 0

[obs-commits] [openSUSE/open-build-service] 975571: [api] double check permissions on locking projects
by Adrian Schröter 30 Nov '15

30 Nov '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 975571c21d29e59fa59c2147124013c008646492 https://github.com/openSUSE/open-build-service/commit/975571c21d29e59fa59c2… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-11-26 (Thu, 26 Nov 2015) Changed paths: M src/api/app/models/bs_request_action_maintenance_release.rb Log Message: ----------- [api] double check permissions on locking projects Commit: ad257b36457c42470a4bb8560da41ebd9bc4424f https://github.com/openSUSE/open-build-service/commit/ad257b36457c42470a4bb… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-11-26 (Thu, 26 Nov 2015) Changed paths: M src/api/app/controllers/webui/project_controller.rb M src/api/app/models/bs_request.rb Log Message: ----------- [webui] add missing login checks Commit: 730148f73490a0f31d978df875017752cdd79911 https://github.com/openSUSE/open-build-service/commit/730148f73490a0f31d978… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/lib/opensuse/permission.rb Log Message: ----------- [api] type check when running old permission check Commit: 0d915e60172a7e77550a5f34a052432727467bcd https://github.com/openSUSE/open-build-service/commit/0d915e60172a7e77550a5… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/app/controllers/webui/project_controller.rb M src/api/app/models/bs_request.rb M src/api/app/models/bs_request_action_maintenance_release.rb M src/api/lib/opensuse/permission.rb Log Message: ----------- Merge pull request #1409 from adrianschroeter/fix_webui_permission_handling Fix permission handling Compare: https://github.com/openSUSE/open-build-service/compare/b840d5c7bf5a...0d915…

1 0

[obs-commits] [openSUSE/open-build-service] c0e03b: [ci] Drop select option of get_by_name / find_by_n...
by Adrian Schröter 30 Nov '15

30 Nov '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: c0e03b703a883622bd479fd72e8912100ad6201b https://github.com/openSUSE/open-build-service/commit/c0e03b703a883622bd479… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-27 (Fri, 27 Nov 2015) Changed paths: M src/api/app/models/project.rb Log Message: ----------- [ci] Drop select option of get_by_name / find_by_name Apparently this isn't used in OBS at all. Kudos to Adrian for pointing that out. Commit: c37e541cf8a29c2d23beab6a42ae8ccf446eb89c https://github.com/openSUSE/open-build-service/commit/c37e541cf8a29c2d23bea… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-27 (Fri, 27 Nov 2015) Changed paths: M src/api/app/models/project.rb Log Message: ----------- [api][webui] Drop raising exceptions in get_by_name / find_by_name Any invalid option parameter will now be silently ignored. No need for failures here... Commit: b840d5c7bf5a1fb3ea56a6d0a47e1fc8c96ae960 https://github.com/openSUSE/open-build-service/commit/b840d5c7bf5a1fb3ea56a… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/app/models/project.rb Log Message: ----------- Merge pull request #1413 from bgeuken/project_find_by_name Project::find by name cleanup Compare: https://github.com/openSUSE/open-build-service/compare/d912837c6d38...b840d…

1 0

[obs-commits] [openSUSE/open-build-service] 2af122: [webui] Stop storing password in a session
by Adrian Schröter 30 Nov '15

30 Nov '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2af1223b2dc8683b6c6f4edc58e09f55154d5699 https://github.com/openSUSE/open-build-service/commit/2af1223b2dc8683b6c6f4… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-25 (Wed, 25 Nov 2015) Changed paths: M src/api/app/controllers/webui/user_controller.rb Log Message: ----------- [webui] Stop storing password in a session We don't used the stored pw anymore. So we can stop storing it. Commit: d912837c6d3878489b35747a4c13cfbfc63d9df4 https://github.com/openSUSE/open-build-service/commit/d912837c6d3878489b357… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M src/api/app/controllers/webui/user_controller.rb Log Message: ----------- Merge pull request #1415 from bgeuken/pwfix [webui] Stop storing password in a session Compare: https://github.com/openSUSE/open-build-service/compare/12e7488c65ec...d9128…

1 0

[obs-commits] [openSUSE/open-build-service] 2f2daf: [docu] Typo fix
by Henne Vogelsang 30 Nov '15

30 Nov '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 2f2daf4ebc27e56606329a31e5ded99e91e85224 https://github.com/openSUSE/open-build-service/commit/2f2daf4ebc27e56606329… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M CONTRIBUTING.md Log Message: ----------- [docu] Typo fix Commit: 4f2356597bda1d72f1a217671e644affa3c9e1ea https://github.com/openSUSE/open-build-service/commit/4f2356597bda1d72f1a21… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M CONTRIBUTING.md Log Message: ----------- [docu] Refer to OBS documentation project in contribution readme Commit: 12e7488c65ec3773da668ff107520ec0fe527ce7 https://github.com/openSUSE/open-build-service/commit/12e7488c65ec3773da668… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-11-30 (Mon, 30 Nov 2015) Changed paths: M CONTRIBUTING.md Log Message: ----------- Merge pull request #1416 from bgeuken/contributing_docu Contributing docu Compare: https://github.com/openSUSE/open-build-service/compare/76fcdec3cfbe...12e74…

1 0