October 2015 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] e6cfa5: [ci][api] request controller test: Ensure that sta...
by Henne Vogelsang 12 Oct '15

12 Oct '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: e6cfa590f424169798fbc10c7c8fa865a677e027 https://github.com/openSUSE/open-build-service/commit/e6cfa590f424169798fbc… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-10-12 (Mon, 12 Oct 2015) Changed paths: M src/api/test/functional/request_controller_test.rb Log Message: ----------- [ci][api] request controller test: Ensure that state of requests got changed via API request Commit: 323c859f57c11f9d16bd3ca9fc736e86498dfd6c https://github.com/openSUSE/open-build-service/commit/323c859f57c11f9d16bd3… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-10-12 (Mon, 12 Oct 2015) Changed paths: M src/api/test/functional/request_controller_test.rb Log Message: ----------- [ci][api] request controller test: Increase test readability Commit: ff6559f3df3fe16e5233087900a5a6cfa1d4c14b https://github.com/openSUSE/open-build-service/commit/ff6559f3df3fe16e52330… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-10-12 (Mon, 12 Oct 2015) Changed paths: M src/api/test/functional/request_controller_test.rb Log Message: ----------- [ci][api] Update test_set_and_get_1 test * Replace assert_xml_tag by Rails's assert_select * Test the responded xml when creating a new request via API * Test that a BsRequest get's created Commit: a0c1528dce9b84232ea9c3142a2cef2cda9f1b5c https://github.com/openSUSE/open-build-service/commit/a0c1528dce9b84232ea9c… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-10-12 (Mon, 12 Oct 2015) Changed paths: M src/api/test/functional/request_controller_test.rb Log Message: ----------- [ci][api] Add test that ensures that requests can't be accepted twice (part of issue#1157) Commit: 47cb9b112d4667fe68592e441b7f32590451a0e5 https://github.com/openSUSE/open-build-service/commit/47cb9b112d4667fe68592… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-10-12 (Mon, 12 Oct 2015) Changed paths: M src/api/test/functional/webui/maintenance_workflow_test.rb Log Message: ----------- [ci][webui] Cleanup maintenance workflow test * Remove patchinfo summary and description validation tests that are already covered by patchinfo controller tests * Remove test for adding issue ids to patchinfo. This is covered by patchinfo controller tests too * Skip setting patchinfo configuration settings that not getting tested, such as: relogin, reboot, zypp_restart_needed, setting a rating Commit: b4650baeb497658f5c98e5a81f3a9940b1d6cb5f https://github.com/openSUSE/open-build-service/commit/b4650baeb497658f5c98e… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-10-12 (Mon, 12 Oct 2015) Changed paths: M src/api/test/functional/request_controller_test.rb M src/api/test/functional/webui/maintenance_workflow_test.rb Log Message: ----------- Merge pull request #1210 from bgeuken/issue_1157 Some test improvements for maintenance workflow and request controller test Compare: https://github.com/openSUSE/open-build-service/compare/57cd63e59fae...b4650…

1 0

[obs-commits] [openSUSE/open-build-service] 815fed: [api][ci] Add tests for updating project watchlist...
by Henne Vogelsang 12 Oct '15

12 Oct '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 815fed707c6b80c297b497f375168fc47ff71748 https://github.com/openSUSE/open-build-service/commit/815fed707c6b80c297b49… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-10-09 (Fri, 09 Oct 2015) Changed paths: M src/api/app/controllers/person_controller.rb M src/api/test/functional/person_controller_test.rb Log Message: ----------- [api][ci] Add tests for updating project watchlist via API Also invalidate cache when updating watchlist. Commit: 8a4c7acbb825146329c701f252859f7e6556324a https://github.com/openSUSE/open-build-service/commit/8a4c7acbb825146329c70… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-10-09 (Fri, 09 Oct 2015) Changed paths: M src/api/test/functional/person_controller_test.rb Log Message: ----------- [ci] person_controller: Add a test for changing watched projects When a user tries to add a not existing project the API should respond with a 404. This commit adds a test for this. Commit: b3ea7652bfb8f0e30068090d507779e379ab509b https://github.com/openSUSE/open-build-service/commit/b3ea7652bfb8f0e300680… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-10-09 (Fri, 09 Oct 2015) Changed paths: M src/api/app/controllers/person_controller.rb M src/api/test/functional/person_controller_test.rb Log Message: ----------- [api] Include user's watchlist when admin requests user data (issue#1204) Other users are not supposed to see a user's projects watchlist. Though if an admin requests user data via the API (/person/$user), he should be able to see it. Otherwise there is a risk that an admin unintenionally deletes this data, eg. when editing user data via osc (see issue#1204). Commit: 57cd63e59fae48e9d8b32ac90e6424efb1256a93 https://github.com/openSUSE/open-build-service/commit/57cd63e59fae48e9d8b32… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-10-12 (Mon, 12 Oct 2015) Changed paths: M src/api/app/controllers/person_controller.rb M src/api/test/functional/person_controller_test.rb Log Message: ----------- Merge pull request #1206 from bgeuken/user_watchlist_tests Add tests for updating project watchlist via API and address issue 1204 Compare: https://github.com/openSUSE/open-build-service/compare/936d0b3e1733...57cd6…

1 0

[obs-commits] [openSUSE/open-build-service] 618777: [ci] Test for /users page (part of issue#1199)
by Henne Vogelsang 12 Oct '15

12 Oct '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 61877780165c2080da39f27a7e1a159617435284 https://github.com/openSUSE/open-build-service/commit/61877780165c2080da39f… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-10-07 (Wed, 07 Oct 2015) Changed paths: M src/api/test/functional/webui/user_controller_test.rb Log Message: ----------- [ci] Test for /users page (part of issue#1199) Commit: 875af984f89f4d1c4eaf66f283767b12a494b42f https://github.com/openSUSE/open-build-service/commit/875af984f89f4d1c4eaf6… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-10-09 (Fri, 09 Oct 2015) Changed paths: M src/api/app/controllers/webui/webui_controller.rb M src/api/test/functional/webui/user_controller_test.rb Log Message: ----------- [webui] Fix NoMethod errors for before filter: require_login, require_admin Commit: eb9ace876c31072cca900c7b408e1de1af99dc3b https://github.com/openSUSE/open-build-service/commit/eb9ace876c31072cca900… Author: Björn Geuken <bgeuken(a)suse.de> Date: 2015-10-09 (Fri, 09 Oct 2015) Changed paths: M src/api/app/controllers/webui/user_controller.rb Log Message: ----------- [webui] Require login when accessing the user index page That data is restricted to admins. Thus a login is required here and we should redirect users to the login page if they aren't. Commit: 936d0b3e1733661e340d57fd9c93023214140cfe https://github.com/openSUSE/open-build-service/commit/936d0b3e1733661e340d5… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-10-12 (Mon, 12 Oct 2015) Changed paths: M src/api/app/controllers/webui/user_controller.rb M src/api/app/controllers/webui/webui_controller.rb M src/api/test/functional/webui/user_controller_test.rb Log Message: ----------- Merge pull request #1208 from bgeuken/test_for_issue_1199 Some smaller things I stumbled over while debugging issue 1199 Compare: https://github.com/openSUSE/open-build-service/compare/6d9e3209c743...936d0…

1 0

[obs-commits] [openSUSE/open-build-service] 6b6567: [backend] Keep enforce_project_keys/forceprojectke...
by Daniel Gollub 09 Oct '15

09 Oct '15

Branch: refs/heads/2.6 Home: https://github.com/openSUSE/open-build-service Commit: 6b6567ed33689fc1a3b4f594791ee16128c88aeb https://github.com/openSUSE/open-build-service/commit/6b6567ed33689fc1a3b4f… Author: Daniel Gollub <dgollub(a)brocade.com> Date: 2015-10-09 (Fri, 09 Oct 2015) Changed paths: M src/backend/bs_srcserver Log Message: ----------- [backend] Keep enforce_project_keys/forceprojectkeys in sync In setups where enforce_project_keys is set in configuration.xml to on. But $BSConfig::forceprojectkeys is undefined sporadic per-project key creations happens, even if a global OBS instance got configured. This is due the fact that $BSConfig::forceprojectkeys get set to 1 once once a src_server API routine got called which calls update_from_configuration(). (Adapted master fix)

1 0

[obs-commits] [openSUSE/open-build-service]
by adrianschroeter 09 Oct '15

09 Oct '15

Branch: refs/tags/2.6.5 Home: https://github.com/openSUSE/open-build-service

1 0

[obs-commits] [openSUSE/open-build-service] d3bd95: [webui] make "on build targets hint" more visible
by Adrian Schröter 09 Oct '15

09 Oct '15

Branch: refs/heads/2.6 Home: https://github.com/openSUSE/open-build-service Commit: d3bd95d3c4504e65e8962d758c2e3517ae7c766b https://github.com/openSUSE/open-build-service/commit/d3bd95d3c4504e65e8962… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-10-09 (Fri, 09 Oct 2015) Changed paths: M src/api/app/controllers/webui/project_controller.rb Log Message: ----------- [webui] make "on build targets hint" more visible Commit: 860e4342223dcb62e66a552892bedcbe594f2662 https://github.com/openSUSE/open-build-service/commit/860e4342223dcb62e66a5… Author: Adrian Schröter <adrian(a)suse.de> Date: 2015-10-09 (Fri, 09 Oct 2015) Changed paths: A ReleaseNotes-2.6.5 Log Message: ----------- [dist] add 2.6.5 ReleaseNotes Compare: https://github.com/openSUSE/open-build-service/compare/fa2195d41368...860e4…

1 0

[obs-commits] [openSUSE/open-build-service] 6d9e32: [dist] rubygem-passenger-apache2 is an apache modu...
by Michael Schroeder 08 Oct '15

08 Oct '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6d9e3209c743e16a250afe305e4fd0b2b24ac10f https://github.com/openSUSE/open-build-service/commit/6d9e3209c743e16a250af… Author: Michael Schroeder <mls(a)suse.de> Date: 2015-10-08 (Thu, 08 Oct 2015) Changed paths: M dist/obs-server.spec Log Message: ----------- [dist] rubygem-passenger-apache2 is an apache module and not a rubygem ...despite the package name. Thus it does not have a rubygem() provides.

1 0

[obs-commits] [openSUSE/open-build-service] 7812a2: [backend] guard against redo_request calls for alr...
by Michael Schroeder 08 Oct '15

08 Oct '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 7812a2a11e1ec50ba64967409a872010abf0a35b https://github.com/openSUSE/open-build-service/commit/7812a2a11e1ec50ba6496… Author: Michael Schroeder <mls(a)suse.de> Date: 2015-10-08 (Thu, 08 Oct 2015) Changed paths: M src/backend/BSWatcher.pm Log Message: ----------- [backend] guard against redo_request calls for already deleted jobs This could happen if the job waited for multiple resources, e.g. file watching and serialization. Also refactors the deljob function.

1 0

[obs-commits] [openSUSE/osc] 4e83af: branch_pkg: fix use of undefined variable
by Marcus Huewe 07 Oct '15

07 Oct '15

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 4e83af82944be0fcbea518934a65f972fa49730a https://github.com/openSUSE/osc/commit/4e83af82944be0fcbea518934a65f972fa49… Author: Andreas Schwab <schwab(a)suse.de> Date: 2015-10-07 (Wed, 07 Oct 2015) Changed paths: M osc/core.py Log Message: ----------- branch_pkg: fix use of undefined variable Commit: 8f8dd9167503a64a7bb09eea479d52d0553e48a4 https://github.com/openSUSE/osc/commit/8f8dd9167503a64a7bb09eea479d52d0553e… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2015-10-07 (Wed, 07 Oct 2015) Changed paths: M osc/core.py Log Message: ----------- Merge branch 'master' of https://github.com/andreas-schwab/osc Compare: https://github.com/openSUSE/osc/compare/400352c61ef9...8f8dd9167503

1 0

[obs-commits] [openSUSE/open-build-service] b6a5d0: [webui] Adapt to the template for models.
by Henne Vogelsang 06 Oct '15

06 Oct '15

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b6a5d0eeb3823fca33c6fe0480a75b2cfbc1a087 https://github.com/openSUSE/open-build-service/commit/b6a5d0eeb3823fca33c6f… Author: Moisés Déniz Alemán <mdeniz(a)suse.de> Date: 2015-10-05 (Mon, 05 Oct 2015) Changed paths: M src/api/app/models/service.rb Log Message: ----------- [webui] Adapt to the template for models. Commit: 069eca3d873feade6fa15e21551e62829ed0804b https://github.com/openSUSE/open-build-service/commit/069eca3d873feade6fa15… Author: Moisés Déniz Alemán <mdeniz(a)suse.de> Date: 2015-10-05 (Mon, 05 Oct 2015) Changed paths: M src/api/app/controllers/webui/driver_update_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/models/service.rb M src/api/test/unit/code_quality_test.rb Log Message: ----------- [webui][api] Get rid of FrontendCompat in Service model Commit: d30385a4045aa9c9b0a60cf1ed918343091104da https://github.com/openSUSE/open-build-service/commit/d30385a4045aa9c9b0a60… Author: Henne Vogelsang <hvogel(a)opensuse.org> Date: 2015-10-06 (Tue, 06 Oct 2015) Changed paths: M src/api/app/controllers/webui/driver_update_controller.rb M src/api/app/controllers/webui/package_controller.rb M src/api/app/models/service.rb M src/api/test/unit/code_quality_test.rb Log Message: ----------- Merge pull request #1203 from mdeniz/refactor_service_model [webui][api] Refactor service model to get rid of FrontendCompat Compare: https://github.com/openSUSE/open-build-service/compare/4bc02b00a4bc...d3038…

1 0