Open Build Service Commits

Download

obs-commits@lists.opensuse.org

January 2015

10 participants
62 discussions

[obs-commits] [openSUSE/osc] 8c8618: - fixed corner case in __del__ method
by Marcus Huewe 03 Jan '15

03 Jan '15

Branch: refs/heads/master Home: https://github.com/openSUSE/osc Commit: 8c8618ac915225712e3ae718080f29912f92a1c9 https://github.com/openSUSE/osc/commit/8c8618ac915225712e3ae718080f29912f92… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2015-01-03 (Sat, 03 Jan 2015) Changed paths: M osc/build.py Log Message: ----------- - fixed corner case in __del__ method For a detailed explanation see https://github.com/openSUSE/osc2/commit/d093c2b43ba13774ade4b1fc81874b119ed…

1 0

[obs-commits] [openSUSE/osc2] d093c2: - test.util.test_io: test corner case in Temporary...
by Marcus Huewe 03 Jan '15

03 Jan '15

Branch: refs/heads/master Home: https://github.com/openSUSE/osc2 Commit: d093c2b43ba13774ade4b1fc81874b119edce767 https://github.com/openSUSE/osc2/commit/d093c2b43ba13774ade4b1fc81874b119ed… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2015-01-03 (Sat, 03 Jan 2015) Changed paths: M test/util/test_io.py Log Message: ----------- - test.util.test_io: test corner case in TemporaryDirectory.__del__ Avoid an unraised exception: Exception AttributeError: "'NoneType' object has no attribute 'path'" in <bound method TemporaryDirectory.__del__ of <osc2.util.io.TemporaryDirectory object at 0x7f8abc8d7910>> ignored This exception was "raised" in the TemporaryDirectory.__del__ method, if the "osc2.util.io" was already "unloaded" (the __del__ method calls the _cleanup method, which tried to call the os.path.isdir function). What happened is the following: If the "osc2.util.io" module is passed to _PyModule_Clear (Objects/moduleobject.c), almost all entries in the module dict are set to None. That is, the entry for the key "os" points to None. Now, suppose that there is still a TemporaryDirectory instance around, whose __del__ method is eventually called. During this call, "os" resolves to None and therefore the subsequent lookup for the name "path" leads to the AttributeError. Instead of raising this exception, it is just printed to stderr, because it occurred in a __del__ method (see slot_tp_del (Objects/typeobject.c) and PyErr_WriteUnraisable (Python/errors.c)). Commit: 9448026bcf2cfbf87659035556e8bcc9f61babcb https://github.com/openSUSE/osc2/commit/9448026bcf2cfbf87659035556e8bcc9f61… Author: Marcus Huewe <suse-tux(a)gmx.de> Date: 2015-01-03 (Sat, 03 Jan 2015) Changed paths: M osc2/util/io.py Log Message: ----------- - util.io.TemporaryDirectory: fixed corner case in __del__ Compare: https://github.com/openSUSE/osc2/compare/c9f8491f6183...9448026bcf2c

1 0