November 2012 - Open Build Service Commits

[obs-commits] [openSUSE/open-build-service] 8b4e5a: [api] add another route to /webui/all_lists
by Stephan Kulow 28 Nov '12

28 Nov '12

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8b4e5a57e875acde054a2fbde7b4b3d1390f6187 https://github.com/openSUSE/open-build-service/commit/8b4e5a57e875acde054a2… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-27 (Tue, 27 Nov 2012) Changed paths: M src/api/app/controllers/webui_controller.rb M src/api/config/routes.rb Log Message: ----------- [api] add another route to /webui/all_lists return all names and titles for including a flag for very important Commit: efedbc793414194d34417163546bf6eac818b476 https://github.com/openSUSE/open-build-service/commit/efedbc793414194d34417… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-27 (Tue, 27 Nov 2012) Changed paths: M src/webui-testsuite/lib/OBSpages/AllProjectsPage.rb R src/webui-testsuite/tests/TC15__AllProjectsList.rb M src/webui/app/assets/javascripts/project.js M src/webui/app/controllers/project_controller.rb M src/webui/app/models/api_details.rb R src/webui/app/views/project/_filter_projects.html.erb R src/webui/app/views/project/_search_packages.html.erb R src/webui/app/views/project/_search_project.html.erb M src/webui/app/views/project/list.html.erb M src/webui/test/functional/project_controller_test.rb Log Message: ----------- [webui] port the "All Projects" route to datatable This makes the whole a lot easier to test and more consistent with the other lists Compare: https://github.com/openSUSE/open-build-service/compare/b932ef98b62c...efedb…

1 0

[obs-commits] [openSUSE/open-build-service] b932ef: [api] make Basedistro very important
by Stephan Kulow 27 Nov '12

27 Nov '12

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: b932ef98b62c09310773cfb916778d8bd185ba4f https://github.com/openSUSE/open-build-service/commit/b932ef98b62c09310773c… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-27 (Tue, 27 Nov 2012) Changed paths: M src/api/lib/tasks/extract.rake M src/api/test/fixtures/attrib_allowed_values.yml M src/api/test/fixtures/attrib_types.yml M src/api/test/fixtures/attribs.yml M src/api/test/fixtures/package_user_role_relationships.yml M src/api/test/fixtures/packages.yml M src/api/test/fixtures/projects.yml M src/api/test/fixtures/roles_static_permissions.yml Log Message: ----------- [api] make Basedistro very important adding a OBS:VeryImportantProject to BaseDistro to get testing for that

1 0

[obs-commits] [openSUSE/open-build-service] 6ae6c6: [webui] port the attribute tests to capybara
by Stephan Kulow 27 Nov '12

27 Nov '12

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 6ae6c60283f1823e0bdf630ff8842dab067321c7 https://github.com/openSUSE/open-build-service/commit/6ae6c60283f1823e0bdf6… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-27 (Tue, 27 Nov 2012) Changed paths: M src/webui-testsuite/lib/OBSpages/BuildServicePage.rb M src/webui-testsuite/lib/OBSpages/PackagePage.rb R src/webui-testsuite/lib/OBSpages/PackagePages/PackageAttributesPage.rb M src/webui-testsuite/lib/OBSpages/ProjectPage.rb R src/webui-testsuite/lib/OBSpages/ProjectPages/ProjectAttributesPage.rb M src/webui-testsuite/lib/common/ClassDeclarations.rb R src/webui-testsuite/tests/TC05__AddProjectAttributes.rb R src/webui-testsuite/tests/TC06__DeleteProjectAttributes.rb R src/webui-testsuite/tests/TC12__AddPackageAttributes.rb R src/webui-testsuite/tests/TC13__DeletePackageAttributes.rb A src/webui/test/functional/attributes_test.rb Log Message: ----------- [webui] port the attribute tests to capybara

1 0

[obs-commits] [openSUSE/open-build-service] 8770f9: [webui] use current capybara rubygem version
by Adrian Schröter 27 Nov '12

27 Nov '12

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 8770f904ec2e0fa2a4014b3be920855587e06381 https://github.com/openSUSE/open-build-service/commit/8770f904ec2e0fa2a4014… Author: Adrian Schröter <adrian(a)suse.de> Date: 2012-11-27 (Tue, 27 Nov 2012) Changed paths: M src/webui/Gemfile.lock Log Message: ----------- [webui] use current capybara rubygem version

1 0

[obs-commits] [openSUSE/open-build-service] f3a898: [webui] add a test that calls every route...
by Stephan Kulow 26 Nov '12

26 Nov '12

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f3a89854d79cc280954d1cec182ce13e7bc34098 https://github.com/openSUSE/open-build-service/commit/f3a89854d79cc280954d1… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-26 (Mon, 26 Nov 2012) Changed paths: M src/webui/app/controllers/apidocs_controller.rb M src/webui/app/controllers/application_controller.rb M src/webui/app/controllers/attribute_controller.rb M src/webui/app/controllers/configuration_controller.rb M src/webui/app/controllers/home_controller.rb M src/webui/app/controllers/main_controller.rb M src/webui/app/controllers/monitor_controller.rb M src/webui/app/controllers/package_controller.rb M src/webui/app/controllers/patchinfo_controller.rb R src/webui/app/controllers/privacy_controller.rb M src/webui/app/controllers/project_controller.rb M src/webui/app/controllers/request_controller.rb M src/webui/app/controllers/user_controller.rb M src/webui/app/helpers/application_helper.rb M src/webui/app/views/main/sitemap.erb M src/webui/app/views/main/sitemap_packages.erb M src/webui/config/routes.rb A src/webui/test/functional/all_routes_test.rb M src/webui/test/functional/spider_test.rb Log Message: ----------- [webui] add a test that calls every route... all routes listed in rake routes are called without parameters to verify that they do not crash. This was a rather stupid idea, but it turned out to catch tons of bugs worth fixing

1 0

[obs-commits] [openSUSE/open-build-service] f492f5: [webui] fix and test package|person#{save|remove}_...
by Stephan Kulow 25 Nov '12

25 Nov '12

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f492f5c502557930fdcdb36436f3567b28b8f00c https://github.com/openSUSE/open-build-service/commit/f492f5c502557930fdcdb… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-25 (Sun, 25 Nov 2012) Changed paths: M src/api/app/controllers/webui_controller.rb M src/webui-testsuite/lib/OBSpages/PackagePage.rb R src/webui-testsuite/lib/OBSpages/PackagePages/PackageAddGroupPage.rb R src/webui-testsuite/lib/OBSpages/PackagePages/PackageAddUserPage.rb R src/webui-testsuite/lib/OBSpages/PackagePages/PackageUsersPage.rb M src/webui-testsuite/lib/OBSpages/ProjectPage.rb R src/webui-testsuite/lib/OBSpages/ProjectPages/ProjectAddGroupPage.rb R src/webui-testsuite/lib/OBSpages/ProjectPages/ProjectUsersPage.rb M src/webui-testsuite/lib/common/ClassDeclarations.rb R src/webui-testsuite/tests/TC16__AddProjectUsers.rb R src/webui-testsuite/tests/TC17__EditProjectUsers.rb R src/webui-testsuite/tests/TC18__AddPackageUsers.rb R src/webui-testsuite/tests/TC19__EditPackageUsers.rb M src/webui/app/assets/javascripts/application.js M src/webui/app/controllers/package_controller.rb M src/webui/app/controllers/project_controller.rb M src/webui/app/models/api_details.rb M src/webui/app/views/layouts/_flash.html.erb M src/webui/app/views/shared/_involved_users.html.erb M src/webui/config/routes.rb A src/webui/test/functional/users_test.rb M src/webui/test/test_helper.rb Log Message: ----------- [webui] fix and test package|person#{save|remove}_{person|group} Instead of fiddling with XML, just use one route in the API for the 8 actions

1 0

[obs-commits] [openSUSE/open-build-service] 629dbf: [activexml] make activexml more robust with capyba...
by Stephan Kulow 25 Nov '12

25 Nov '12

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: 629dbf0636f4a2bb7e194be2dfff4ccced214527 https://github.com/openSUSE/open-build-service/commit/629dbf0636f4a2bb7e194… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-25 (Sun, 25 Nov 2012) Changed paths: M src/activexml/node.rb M src/activexml/transport.rb Log Message: ----------- [activexml] make activexml more robust with capybara The problem is that capybara runs the webui in a thread and selenium in another. This leads to the problem that our libraries are tested for thread safety - which they are not. So the work around is adding a mutex, but this only makes sure http_do calls happen in one thread only. But the real fix is a change in the API as everything accesses the global transport object and sets headers and then assumes the next http_do call will use that headers - which is only true if there is only one thread. But having multiple threads in the test suite sounds like something we want to have Commit: 6edecf459a28c406675bfe68034eef7a226cea62 https://github.com/openSUSE/open-build-service/commit/6edecf459a28c406675bf… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-25 (Sun, 25 Nov 2012) Changed paths: M src/api/app/controllers/webui_controller.rb M src/api/app/models/package.rb M src/api/app/models/project.rb M src/api/config/routes.rb Log Message: ----------- [api] add a webui/change_role route to the API This avoids having to patching XML for a very defined purpose: adding/removing users/groups from projects/packages. to avoid having 8 routes, I added one change_role route Commit: 3c56da8fd6f3d1446746b4378ed8a29b7f59e05d https://github.com/openSUSE/open-build-service/commit/3c56da8fd6f3d1446746b… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-25 (Sun, 25 Nov 2012) Changed paths: M .travis.yml Log Message: ----------- [dist] remove irc notifications this is just spam as it affects all forked repos Compare: https://github.com/openSUSE/open-build-service/compare/ac986ce4da2d...3c56d…

1 0

[obs-commits] [openSUSE/open-build-service] ac986c: [dist] someone changed factory!!!
by Stephan Kulow 25 Nov '12

25 Nov '12

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: ac986ce4da2dfdc46d63d267ad7836395fb2c3b2 https://github.com/openSUSE/open-build-service/commit/ac986ce4da2dfdc46d63d… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-25 (Sun, 25 Nov 2012) Changed paths: M dist/ci/obs_testsuite_travis_before.sh Log Message: ----------- [dist] someone changed factory!!!

1 0

[obs-commits] [openSUSE/open-build-service] d6f9e5: [api] avoid random crashes in test suite
by Stephan Kulow 24 Nov '12

24 Nov '12

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: d6f9e55dcaa954eb7f1a556fb0d69dbdd5cef015 https://github.com/openSUSE/open-build-service/commit/d6f9e55dcaa954eb7f1a5… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-24 (Sat, 24 Nov 2012) Changed paths: M src/api/app/controllers/application_controller.rb M src/api/app/controllers/source_controller.rb Log Message: ----------- [api] avoid random crashes in test suite Tempfile volleys are racy because the file is deleted at the time the Tempfile object is garbage collected - which is basically random Commit: 58cd74809b62fac93ae8461a217c0983dc76800b https://github.com/openSUSE/open-build-service/commit/58cd74809b62fac93ae84… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-24 (Sat, 24 Nov 2012) Changed paths: M .travis.yml Log Message: ----------- [dist] test irc notifications Compare: https://github.com/openSUSE/open-build-service/compare/f647b7e1b029...58cd7…

1 0

[obs-commits] [openSUSE/open-build-service] f647b7: [webui] if the project does not exist, there is no...
by Stephan Kulow 24 Nov '12

24 Nov '12

Branch: refs/heads/master Home: https://github.com/openSUSE/open-build-service Commit: f647b7e1b02987e59709d67dec8419a47cc317e4 https://github.com/openSUSE/open-build-service/commit/f647b7e1b02987e59709d… Author: Stephan Kulow <coolo(a)suse.de> Date: 2012-11-24 (Sat, 24 Nov 2012) Changed paths: M src/webui/app/views/shared/_project_or_package_link.html.erb Log Message: ----------- [webui] if the project does not exist, there is no package either

1 0