[Bug 968405] New: xdm restarts the user session on update
http://bugzilla.suse.com/show_bug.cgi?id=968405 Bug ID: 968405 Summary: xdm restarts the user session on update Classification: openSUSE Product: openSUSE Tumbleweed Version: 2015* Hardware: Other OS: Other Status: NEW Severity: Major Priority: P5 - None Component: X.Org Assignee: xorg-maintainer-bugs@forge.provo.novell.com Reporter: tchvatal@suse.com QA Contact: xorg-maintainer-bugs@forge.provo.novell.com Found By: --- Blocker: --- When system during update is updating xdm it takes down restarts the graphical user session with everything in it. It seems like the try-restart is not nice in this case enough to simply wait for user to exit the session and just kills everything. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c1
Egbert Eich
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c2
Michael Schröder
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c3
--- Comment #3 from Egbert Eich
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c4
Egbert Eich
http://bugzilla.suse.com/show_bug.cgi?id=968405
Egbert Eich
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c16
--- Comment #16 from Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c21
--- Comment #21 from Dr. Werner Fink
You're trying hard, aren't you?
Indeed I do! Beside this, the wiki has to be fixed! -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c27
--- Comment #27 from Michael Schröder
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c29
--- Comment #29 from Michael Schröder
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c30
Olaf Hering
./xen/xen.spec:export DISABLE_RESTART_ON_UPDATE=yes
Nothing in xen-tools can be restarted, as long as there are active domUs and backends. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c34
Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c38
Michael Schröder
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c40
--- Comment #40 from Michael Schröder
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c41
--- Comment #41 from Michael Schröder
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c45
--- Comment #45 from Michael Schröder
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c46
--- Comment #46 from Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c47
--- Comment #47 from Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c48
--- Comment #48 from Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c49
--- Comment #49 from Dominique Leuenberger
Created attachment 667148 [details] Small chnage which adds a rpm macro option as well as makes
the DISABLE_RESTART_ON_UPDATE=1 or DISABLE_STOP_ON_REMOVAL=1 work as well
I like the solution! - Let's make sure that we get this fully documented on what works (seems exporting the variable OR passing -d is fine) and which solution we prefer (presumably -d, but this will only work on openSUSE Tumbleweed and SLE12SP2) -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c50
--- Comment #50 from Dominique Leuenberger
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c51
--- Comment #51 from Egbert Eich
Comment#42 and #43: Your macro change will also only take effect when the corresponding packages are released again, as the macros are already expanded in the binary packages. So I don't see any difference.
Of course. For any package released after the broken macros was released it is too late. The difference is: when you change the semantics, you will have to notify each maintainer of a consumer of the macro of the change and make sure any possible update is properly serialized with the update to systemd-rpm-macros. Of course it would be possible to have both the new (macro option driven) and old deprecated env variable driven semantics around in parallel for a while. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c52
--- Comment #52 from Michael Schröder
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c53
--- Comment #53 from Egbert Eich
%_restart_check_systemctl \ - test "$DISABLE_RESTART_ON_UPDATE" = yes && exit 0 \ + test "$DISABLE_RESTART_ON_UPDATE" != no && exit 0 \
But as /etc/sysconfig/service is not yet sourced at that moment, ANY package not specifying it =no will NOT restart now (their value of DISABLE+RESTART_ON_UPDATE is "", not 'no'
Exactly. I did propose a patch in comment #33 which sources /etc/sysconfig/service but so far this has been ignored completely. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c54
--- Comment #54 from Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c55
--- Comment #55 from Dominique Leuenberger
But as /etc/sysconfig/service is not yet sourced at that moment, ANY package not specifying it =no will NOT restart now (their value of DISABLE+RESTART_ON_UPDATE is "", not 'no'
Exactly. I did propose a patch in comment #33 which sources /etc/sysconfig/service but so far this has been ignored completely.
Maybe I should have given more context... the sourcing of /etc/sysconfig/services would happen right after.. so the approach is equal to what you proposed in comment 33... first check the 'env', then source and recheck the env variable (now coming from the file). The difference being: comment ee checked if DISABLE_RESTART_ON_UPDATE=yes && exit 0 and Werner's new solution doing DISABLE_RESTART_ON_UPDATE != no, which sounds very appealing at first, but fails, as outlined above, as unless specified by the package/user/anything else, the variable is not set at all. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c56
--- Comment #56 from Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c57
--- Comment #57 from Dominique Leuenberger
(In reply to Dominique Leuenberger from comment #50)
In /etc/sysconfig/services there are clear declaration *what+ values are used:
## Path: System/Services ## Type: yesno ## Default: no
... sorry but if a sytem admin edits this without reading I can not help. And it should be clear that this works only for the case
DISABLE_RESTART_ON_UPDATE=1 rpm -Uhv ...
or
DISABLE_RESTART_ON_UPDATE=1 zypper up ...
and what in case of simply: rpm -Uhv <package>? Sorry Werner: your script would not execute a restart of the service in this case, as UPDATE_ON_RESTART!=no is satisfied and the script exits. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c58
--- Comment #58 from Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c59
Egbert Eich
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c60
--- Comment #60 from Egbert Eich
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c61
Egbert Eich
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c62
Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c63
--- Comment #63 from Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c64
Egbert Eich
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c65
Michael Schröder
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c66
--- Comment #66 from Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
Egbert Eich
http://bugzilla.suse.com/show_bug.cgi?id=968405
Egbert Eich
http://bugzilla.suse.com/show_bug.cgi?id=968405
Egbert Eich
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c71
Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c72
Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c73
Dr. Werner Fink
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c75
Michael Schröder
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c78
--- Comment #78 from Andrei Borzenkov
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c79
--- Comment #79 from Egbert Eich
I updated TW to current snapshot and was kicked out of GUI. I'm using XFCE installation pattern with lightdm; I do not see anything related to service restart in lightdm, but I see that xdm was updated (1.1.11-17.1 -> 1.1.11-18.1). Is it (loss of GUI session) expected in this case?
Even if this is fallout of %postuninstall of previous version - I'm using lightdm as display manager, why updating of *xdm* restarts it?
Andrei, Since the faulty code is in the uninstall scriptlet of the *old* package this will happen until a *fixed* package is updated ie gets uninstalled. The uninstall scriptlets of a package(-version) are stored in the rpm database until this package(-version) is removed completely. So even though the issue is fixed, you will suffer from it once more. Only the next time around, when this package is updated *again* you should be fine. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c85
Lars Marowsky-Bree
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c86
Stefan Dirsch
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c87
--- Comment #87 from Lars Marowsky-Bree
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c88
Lars Marowsky-Bree
http://bugzilla.suse.com/show_bug.cgi?id=968405
Swamp Workflow Management
http://bugzilla.suse.com/show_bug.cgi?id=968405
Swamp Workflow Management
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c93
--- Comment #93 from Bernhard Wiedemann
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c94
--- Comment #94 from Bernhard Wiedemann
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c95
--- Comment #95 from Swamp Workflow Management
http://bugzilla.suse.com/show_bug.cgi?id=968405
http://bugzilla.suse.com/show_bug.cgi?id=968405#c96
--- Comment #96 from Swamp Workflow Management
https://bugzilla.suse.com/show_bug.cgi?id=968405
Maintenance Robot
participants (2)
-
bugzilla_noreply@novell.com
-
bugzilla_noreply@suse.com