April 2008 - Zypp Development - openSUSE Mailing Lists

[zypp-devel] new libzypp
by Stephan Kulow 04 Apr '08

04 Apr '08

PackageKit: pk-backend-zypp.cpp: In function 'gboolean backend_get_requires_thread(PkBackendThread*, void*)': pk-backend-zypp.cpp:224: error: 'nosolvable' is not a member of 'zypp::sat::Solvable' pk-backend-zypp.cpp: In function 'gboolean backend_resolve_thread(PkBackendThread*, void*)': pk-backend-zypp.cpp:1171: error: 'nosolvable' is not a member of 'zypp::sat::Solvable' yast2-qt-pkg: qt-pkg/src/YQPkgPatchList.cc:134: error: ‘class zypp::ResStatus’ has no member named ‘isIncomplete’ qt-pkg/src/YQPkgPatchList.cc:175: error: ‘class zypp::ResStatus’ has no member named ‘isNeeded’ qt-pkg/src/YQPkgPatchList.cc:204: error: ‘class zypp::ResStatus’ has no member named ‘isNeeded’ qt-pkg/src/YQPkgPatchList.cc:205: error: ‘class zypp::ResStatus’ has no member named ‘isSatisfied’ Greetings, Stephan -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

3 3

[zypp-devel] api proposal for locks
by Josef Reidinger 04 Apr '08

04 Apr '08

Hi, I'm sending my proposal for locks API in the attachment. See FATE #120118 and [1] (locks). The attachment contains io api for locks file and locks-to-pool bridge. Also some functions telling which Resolvables a lock or several locks cover. question about C++ (function addLocks). I need distinguish between container that contains resolvables and locks. Is this possible in C++? (like Collection<Lock> and Collection<Resolvable> in java?) some ideas how to solve the issue with support of regexes or wildcards in the locks file: - keep support of regexes in the locks file - have function which does something like locks coverage. How would it work? It would get old locks and resolvables which the user wanted to lock (including the changed ones). Then, for each lock it gets all matching available resolvables and checks if the set is a subset of currently locked resolvables. If it is, those resolvables are marked as already locked (written/covered/whatever) and the lock is written back to the locks file unchanged (meaning if it was a regex, it will stay so). Thus the remaining resolvables will be written to the locks file individually (without using any regex). This may not be trivial. - drop regex support and write one lock per resolvable - use two files for user (regex) locks and UI locks (as suggested in [1]) Other issues: - how to clean up or maintain the locks file, it will probably be a mess after some time - the locks file format will be extended to include resolvable kind. The question is whether we want to support also something else (architecture, vendor, ...) - the API supports locks file <-> pool manipulation as well as direct to/from locks manipulation, is it OK? thanks for comments, Pepa [1] http://lists.opensuse.org/yast-devel/2008-03/msg00158.html

6 19

[zypp-devel] implementing PoolQuery iterator using sat-solver's Dataiterator
by Jan Kupec 03 Apr '08

03 Apr '08

I have the following experimental PoolQuery::ResultIterator extern "C" { #include "satsolver/repo.h"; } class PoolQuery { public: typedef ::_Dataiterator RepoDataIterator; class ResultIterator : public boost::iterator_adaptor< ResultIterator // Derived , RepoDataIterator * // Base , const sat::Solvable // Value , boost::forward_traversal_tag // CategoryOrTraversal , const sat::Solvable & // Reference > { public: ResultIterator() : ResultIterator::iterator_adaptor_(0) { _rdit = 0; base_reference() = 0; } ResultIterator(RepoDataIterator * rdit) : ResultIterator::iterator_adaptor_(0) { _rdit = rdit; base_reference() = rdit; } private: friend class boost::iterator_core_access; sat::Solvable dereference() const { return _rdit ? sat::Solvable(_rdit->solvid) : sat::Solvable::noSolvable; } void increment() { if (::dataiterator_step(_rdit)) else { base_reference() = 0; } } template <class OtherDerived, class OtherIterator, class V, class C, class R, class D> bool equal( const boost::iterator_adaptor<OtherDerived, OtherIterator, V, C, R, D> & rhs ) const; { if (!rhs.base() && !base()) return true; if (!rhs.base() || !base()) return false; // quite useless since base() == rhs.base() always except for // end() if (rhs.base()->solvid == base()->solvid) return true; return false; } private: RepoDataIterator * _rdit; }; // PoolQuery methods&members go here.... } I use (maybe wrongly) the RepoDataIterator * as the base. RepoDataIterator is being created in PoolQuery::Impl, the begin() and end() methods look like this: PoolQuery::ResultIterator PoolQuery::Impl::begin() { sat::Pool pool(sat::Pool::instance()); sat::Pool::RepositoryIterator itr = pool.reposBegin(); ::dataiterator_init(&_rdit, itr->get(), 0 /*p*/, 0/*keyname*/, 0 /*matchstring*/, _flags); INT << "next: " << ::dataiterator_step(&_rdit) << endl; return PoolQuery::ResultIterator(&_rdit); } PoolQuery::ResultIterator PoolQuery::Impl::end() { return PoolQuery::ResultIterator(0); } This has (at least :O) two drawbacks: 1) RepoDataIterator * is the same in all instances except for those created with PoolQuery::end() 2) PoolQuery::begin() always resets the dataiterator state for all existing instances This is probably a really bad evil. Can somebody (ma? :O) give me a pointer how to do it better? I would very much love to discover the world by myself, but the time is unfortunately running out :O( Please ignore the fact that this does not iterate across repositories for now; and that it iterates through solvable attributes, not just the solvables. cheers, jano -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

3 2

[zypp-devel] query abstraction level over pool
by Josef Reidinger 03 Apr '08

03 Apr '08

Hi, I have this idea when thinking about locks. problem: ui have direct access to pool (jano say me, that ma and schubi works on it). And with locks is problem, that libzypp don't know what ui wants. ma propose[0] have on solvable some bits for was-locked. Problem with it is, that ui know what they want, but pass to libzypp only result and is hard to recognize what ui want (f.e. ui want locks all package for gcc -> ui locks all gcc solvable X ui wants locks everythink with gcc -> if no gcc patch is avaible then ui locks same solvables and I cannot recognize what they want). sollution (my idea): ui communicate with pool by messages (late query) representing query. So if ui wants locks everything for gcc it fill query with name gcc and call lock with this query as param. If ui wants locks only packages gcc, they fill query with name gcc and kind package. If ui wants locks gcc-4.1.1 they fill query with name and version.etc. This can be also apply to install or uninstall. ui pass filled query what they want. advantage - clear api - only few functions is needed, implementation has been driven by query. uniform calls - you fill same query for locks, search, install, uninstall, whatever you want and only pass ti to right function. libzypp know what ui wants - they fill send what they want not result of it disadvantage - byrocracy? depends on query versatility lock relevant part for locks api is still problems remove lock. ma propose something[0], but I think that it have problem that only guess if lock lock what user want unlock. I think better is save query passed by ui and when they want remove somethink it also pass query. Search thru locks storage and try find what query have non-null intersect of results. If this query is identical (typical if you use one ui) then query is remove. If query have same results but isn't identical then call callback if user really want remove it. If results isn't same show callback but enriched with effected package and let decide on ui (user) if they want remove this lock which also remove more locks. Any other suggestion? thanks for attention and comments Pepa [0] http://lists.opensuse.org/zypp-devel/2008-03/msg00080.html -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

1 0

[zypp-devel] establish states moved from ResStatus to PoolItem
by Stefan Schubert 02 Apr '08

02 Apr '08

Hi, the establish states are no longer available in the ResStatus cause they will be evaluate by the solver while every call of: PoolItem.h /** Whether the items requirements are met. */ bool isSatisfied() const; /** Whether the items requirements are broken. */ bool isBroken() const { return ! isSatisfied(); } Unfortunately I have no write permission to YaST svn, so could you please fix the concerning packages. Thank you. I have already fixed zypper,libzypp-bindings and libzypp-testsuite. Greetings Stefan Index: gtk/src/yzyppwrapper.cc =================================================================== --- gtk/src/yzyppwrapper.cc (Revision 45958) +++ gtk/src/yzyppwrapper.cc (Arbeitskopie) @@ -517,7 +517,7 @@ if (impl->type == Ypp::Package::PATCH_TYPE) { if (impl->zyppSel->hasInstalledObj()) { // broken? show as available - if (impl->zyppSel->installedPoolItem().status().isIncomplete()) + if (impl->zyppSel->installedPoolItem().isBroken()) return false; } } @@ -1568,7 +1568,7 @@ if (!patch) continue; if (!(*it)->hasInstalledObj()) - if (!(*it)->hasCandidateObj() || !(*it)->candidatePoolItem().status().isNeeded()) + if (!(*it)->hasCandidateObj() || !(*it)->candidatePoolItem().isBroken()) continue; category = addCategory (type, patch->category()); break; Index: ncurses-pkg/src/NCPackageSelector.cc =================================================================== --- ncurses-pkg/src/NCPackageSelector.cc (Revision 45958) +++ ncurses-pkg/src/NCPackageSelector.cc (Arbeitskopie) @@ -659,7 +659,7 @@ if ( selectable->hasInstalledObj() ) // patch installed? { // display only if broken - if ( selectable->installedPoolItem().status().isIncomplete() ) + if ( selectable->installedPoolItem().isBroken() ) { displayPatch = true; yuiWarning() << "Installed patch is broken: " << patchPtr->name().c_str() << " - " @@ -670,7 +670,7 @@ { if (selectable->hasCandidateObj() && - selectable->candidatePoolItem().status().isSatisfied() ) + selectable->candidatePoolItem().isSatisfied() ) { //patch not installed, but it is satisfied (updated to the version patch requires) //all that is missing are patch metadata, so let's display the patch @@ -688,7 +688,8 @@ // isSatisfied(): all packages are installed, therefore the isNeeded() flag // isn't set. BUT the patch meta data aren't installed and therefore it makes // sense to install the patch - if ( selectable->candidatePoolItem().status().isNeeded()) + if ( selectable->candidatePoolItem().status().isInstalled() + && selectable->candidatePoolItem().isBroken()) { displayPatch = true; } @@ -1397,7 +1398,7 @@ descr += "<br>"; if ( selectable->hasInstalledObj() - && selectable->installedPoolItem().status().isIncomplete() ) + && selectable->installedPoolItem().isBroken() ) { descr += _( "----- this patch is broken !!! -----" ); descr += "<br>"; Index: pkg-bindings/src/Resolvable_Properties.cc =================================================================== --- pkg-bindings/src/Resolvable_Properties.cc (Revision 45958) +++ pkg-bindings/src/Resolvable_Properties.cc (Arbeitskopie) @@ -293,7 +293,7 @@ info->add(YCPString("interactive"), YCPBoolean(patch_ptr->interactive())); info->add(YCPString("reboot_needed"), YCPBoolean(patch_ptr->reboot_needed())); info->add(YCPString("affects_pkg_manager"), YCPBoolean(patch_ptr->affects_pkg_manager())); - info->add(YCPString("is_needed"), YCPBoolean(it->status().isNeeded())); + info->add(YCPString("is_broken"), YCPBoolean(it->isBroken())); } // dependency info Index: pkg-bindings/src/ProvideProcess.cc =================================================================== --- pkg-bindings/src/ProvideProcess.cc (Revision 45958) +++ pkg-bindings/src/ProvideProcess.cc (Arbeitskopie) @@ -54,7 +54,7 @@ } if (!provider.status().isInstalled() - && (!onlyNeeded || provider.status().isNeeded()) ) // take only needed items (e.G. needed patches) + && (!onlyNeeded || provider.isBroken()) ) // take only needed items (e.G. needed patches) { // deselect the item if it's already selected, // only one item should be selected -- ******************************************************************************* Stefan Schubert SUSE LINUX GmbH - Maxfeldstrasse 5 - D-90409 Nuernberg, Germany e-mail: schubi(a)suse.de ------------------------------------------------------------------------------- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

1 0

[zypp-devel] Re: [zypp-commit] r9328 - in /trunk/libzypp: package/libzypp.changes zypp/sat/Solvable.cc zypp/sat/Solvable.h zypp/sat/WhatProvides.cc zypp/sat/WhatProvides.h zypp/sat/detail/PoolImpl.cc zypp/sat/detail/PoolMember.h
by Michael Matz 02 Apr '08

02 Apr '08

Hi, On Tue, 1 Apr 2008, mlandres(a)svn.opensuse.org wrote: > Author: mlandres > Date: Tue Apr 1 22:03:24 2008 > New Revision: 9328 > > URL: http://svn.opensuse.org/viewcvs/zypp?rev=9328&view=rev > Log: > - Extend sat::WhatProvides to allow to query for possible providers > of a collection of capabilies. E.g. all providers of a packages > requirements. > - Fixed retrieval of translated texts from .solv files, provided the > solv file contains them. > > Modified: > trunk/libzypp/package/libzypp.changes > trunk/libzypp/zypp/sat/Solvable.cc > trunk/libzypp/zypp/sat/Solvable.h > trunk/libzypp/zypp/sat/WhatProvides.cc > trunk/libzypp/zypp/sat/WhatProvides.h > trunk/libzypp/zypp/sat/detail/PoolImpl.cc > trunk/libzypp/zypp/sat/detail/PoolMember.h This doesn't even compile. Yellow card! I've fixed this instead of reverting, because I'm not grumpy today ;) Ciao, Michael. -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

2 1

[zypp-devel] Updating packages
by Stefan Schubert 01 Apr '08

01 Apr '08

-------- Original-Nachricht -------- Betreff: Re: update stack. tasks Datum: Mon, 31 Mar 2008 15:50:47 +0200 Von: Stefan Schubert <schubi(a)suse.de> An: Klaus Kaempf <kkaempf(a)suse.de> CC: Duncan Mac-Vicar P. <dmacvicar(a)suse.de>, Stanislav Visnovsky <visnov(a)suse.cz>, Michael Schroeder <mls(a)suse.de>, Stephan Kulow <coolo(a)suse.de>, Michael Matz <matz(a)suse.de>, Jiri Srain <jsrain(a)suse.cz>, Michal Svec <msvec(a)suse.cz>, Stefan Hundhammer <sh(a)suse.de> Referenzen: <47E98C33.9080705(a)suse.de> <20080326110137.GC10918(a)heron.suse.de> Klaus Kaempf schrieb: >> ---------------------------------- >> > > Let me add > > * Updates > > - Provide a 'compute package updates' function (using sat-solver > 'update_system' mode) in all zypp applications (qt, ncurses, gtk, > zypper). > Replacing the current loop-over-pool-finding-'newer'-packages > functionality. > Libzypp supports this now: /** * Update to the newest package * * Install the newest version of your installed packages as * far as possible. This means a newer package will NOT be * installed if it generates dependency problems. * So the user will not get an error message. * **/ void doUpdate( ); Greetings Stefan -- ******************************************************************************* Stefan Schubert SUSE LINUX GmbH - Maxfeldstrasse 5 - D-90409 Nuernberg, Germany e-mail: schubi(a)suse.de ------------------------------------------------------------------------------- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- ******************************************************************************* Stefan Schubert SUSE LINUX GmbH - Maxfeldstrasse 5 - D-90409 Nuernberg, Germany e-mail: schubi(a)suse.de ------------------------------------------------------------------------------- SUSE LINUX Products GmbH, GF: Markus Rex, HRB 16746 (AG Nürnberg) -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

4 4

[zypp-devel] [review] serialize/recover PoolQuery
by Josef Reidinger 01 Apr '08

01 Apr '08

Hi, I implement serialize/recover for PoolQuery as suggested by ma in "api proposal for locks" thread. Now it is support serializing repo and kind and rest come when is implemented (solvAttr and name). Only dirty part is PoolQueryUtil.h I must create it, because I need include fstream for templated functions. So I add it to separated header which is used only in cc files when want used this templated functions (more comments is at beginning of file). When you want use in your header PoolQuery you don't include fstream. changed files is PoolQuery.h/cc + PoolQueryUtil.h and writed testcases for this. thanks, Pepa -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

1 0

[zypp-devel] [SoC-student] Problem building "zypper" - CMake Error: Zypp_DIR is not set
by Gerard Farràs i Ballabriga 01 Apr '08

01 Apr '08

Hi, I'm trying to build "zypper" but I always get the same error: CMake Error: Zypp_DIR is not set. It must be set to the directory containing ZyppConfig.cmake in order to use Zypp. But... I'm unable to find this file. Any idea ? Thanks, Gerard -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

2 1

[zypp-devel] using base::SafeBool<Foo>::operator bool_type;
by Duncan Mac-Vicar P. 01 Apr '08

01 Apr '08

This statement is present in some sat wrapper classes, and swig is unable to parse it. The idea is to have the biggest amount of bindings completely autogenerated out of the headers, so they fix themselves with API changes, and at least classes using this idiom have to be copied and "cleaned", which of course means syncing them. Is there any similar idiom for this, which is more likely to be parsed by swig? (I remember we used to have the same effect using define), because the current idiom only appears only in: - http://www.artima.com/cppsource/safebool3.html - our source code Duncan -- To unsubscribe, e-mail: zypp-devel+unsubscribe(a)opensuse.org For additional commands, e-mail: zypp-devel+help(a)opensuse.org

2 1