March 2012 - YaST Commits - openSUSE Mailing Lists

[yast-commit] r67599 - /tags/branch-Code-11-SP1-2_17_17_11/
by lslezak＠svn2.opensuse.org 08 Mar '12

08 Mar '12

Author: lslezak Date: Thu Mar 8 13:39:24 2012 New Revision: 67599 URL: http://svn.opensuse.org/viewcvs/yast?rev=67599&view=rev Log: Created tag branch-Code-11-SP1-2_17_17_11 Added: tags/branch-Code-11-SP1-2_17_17_11/ -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r67598 - in /branches/SuSE-Code-11-SP1-Branch/pkg-bindings: VERSION package/yast2-pkg-bindings.changes src/PkgFunctions.h src/Resolvable_Install.cc
by lslezak＠svn2.opensuse.org 08 Mar '12

08 Mar '12

Author: lslezak Date: Thu Mar 8 13:36:38 2012 New Revision: 67598 URL: http://svn.opensuse.org/viewcvs/yast?rev=67598&view=rev Log: - added Pkg::ResolvableUpdate() to avoid downgrading resolvables (bnc#751147) - 2.17.45.6 Modified: branches/SuSE-Code-11-SP1-Branch/pkg-bindings/VERSION branches/SuSE-Code-11-SP1-Branch/pkg-bindings/package/yast2-pkg-bindings.changes branches/SuSE-Code-11-SP1-Branch/pkg-bindings/src/PkgFunctions.h branches/SuSE-Code-11-SP1-Branch/pkg-bindings/src/Resolvable_Install.cc Modified: branches/SuSE-Code-11-SP1-Branch/pkg-bindings/VERSION URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/pkg-b… ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/pkg-bindings/VERSION (original) +++ branches/SuSE-Code-11-SP1-Branch/pkg-bindings/VERSION Thu Mar 8 13:36:38 2012 @@ -1 +1 @@ -2.17.45.5 +2.17.45.6 Modified: branches/SuSE-Code-11-SP1-Branch/pkg-bindings/package/yast2-pkg-bindings.changes URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/pkg-b… ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/pkg-bindings/package/yast2-pkg-bindings.changes (original) +++ branches/SuSE-Code-11-SP1-Branch/pkg-bindings/package/yast2-pkg-bindings.changes Thu Mar 8 13:36:38 2012 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Thu Mar 8 08:16:23 UTC 2012 - lslezak(a)suse.cz + +- added Pkg::ResolvableUpdate() to avoid downgrading resolvables + (bnc#751147) +- 2.17.45.6 + +------------------------------------------------------------------- Thu Jan 26 11:50:25 UTC 2012 - lslezak(a)suse.cz - fixed saving additional repositories added by registration Modified: branches/SuSE-Code-11-SP1-Branch/pkg-bindings/src/PkgFunctions.h URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/pkg-b… ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/pkg-bindings/src/PkgFunctions.h (original) +++ branches/SuSE-Code-11-SP1-Branch/pkg-bindings/src/PkgFunctions.h Thu Mar 8 13:36:38 2012 @@ -235,6 +235,17 @@ // a helper function to add or remove an upgrade repository YCPValue AddRemoveUpgradeRepo(const YCPInteger &repo, bool add); + + // action for a resolvable + enum ResolvableAction + { + Install, + Remove, + Update + }; + + // helper for installing/removing/upgrading a resolvable + bool ResolvableUpdateInstallOrDelete(const YCPString& name_r, const YCPSymbol& kind_r, ResolvableAction action); public: // general @@ -791,6 +802,8 @@ /* TYPEINFO: boolean(string,symbol,integer)*/ YCPValue ResolvableInstallRepo( const YCPString& name_r, const YCPSymbol& kind_r, const YCPInteger& repo_r ); /* TYPEINFO: boolean(string,symbol)*/ + YCPValue ResolvableUpdate( const YCPString& name_r, const YCPSymbol& kind_r ); + /* TYPEINFO: boolean(string,symbol)*/ YCPValue ResolvableRemove( const YCPString& name_r, const YCPSymbol& kind_r ); /* TYPEINFO: boolean(string,symbol,boolean)*/ YCPValue ResolvableNeutral( const YCPString& name_r, const YCPSymbol& kind_r, const YCPBoolean& force_r ); Modified: branches/SuSE-Code-11-SP1-Branch/pkg-bindings/src/Resolvable_Install.cc URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/pkg-b… ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/pkg-bindings/src/Resolvable_Install.cc (original) +++ branches/SuSE-Code-11-SP1-Branch/pkg-bindings/src/Resolvable_Install.cc Thu Mar 8 13:36:38 2012 @@ -236,7 +236,7 @@ return YCPBoolean(ret); } -bool ResolvableInstallOrDelete(const YCPString& name_r, const YCPSymbol& kind_r, bool install) +bool PkgFunctions::ResolvableUpdateInstallOrDelete(const YCPString& name_r, const YCPSymbol& kind_r, ResolvableAction action) { zypp::Resolvable::Kind kind; @@ -275,9 +275,68 @@ if (s) { - y2milestone("%s: %s:%s ", install ? "Installing" : "Removing", req_kind.c_str(), name.c_str()); - return install ? s->setToInstall(zypp::ResStatus::APPL_HIGH): - s->setToDelete(zypp::ResStatus::APPL_HIGH); + if (action == Install) + { + y2milestone("Installing %s %s ", req_kind.c_str(), name.c_str()); + return s->setToInstall(zypp::ResStatus::APPL_HIGH); + } + else if (action == Remove) + { + y2milestone("Removing %s %s ", req_kind.c_str(), name.c_str()); + return s->setToDelete(zypp::ResStatus::APPL_HIGH); + } + else if (action == Update) + { + y2milestone("Updating %s %s ", req_kind.c_str(), name.c_str()); + + // update candidate + zypp::PoolItem update = s->updateCandidateObj(); + + // installed version + zypp::PoolItem installed; + if (zypp::traits::isPseudoInstalled(s->kind())) + { + for_(it, s->availableBegin(), s->availableEnd()) + // this is OK also for patches - isSatisfied() excludes !isRelevant() + if (it->status().isSatisfied() + && (!installed || installed->edition() < (*it)->edition())) + installed = *it; + } + else + { + installed = s->installedObj(); + } + + if (!installed) + { + y2milestone("%s is not installed, nothing to update", name.c_str()); + return false; + } + + if (!update) + { + y2milestone("Update for %s is not available, no change", name.c_str()); + return false; + } + + if (update->edition() > installed->edition()) + { + y2milestone("Updating %s from %s.%s to %s.%s", name.c_str(), installed->edition().asString().c_str(), + installed->arch().asString().c_str(), update->edition().asString().c_str(), update->arch().asString().c_str()); + return update.status().setToBeInstalled(whoWantsIt); + } + else + { + y2milestone("%s %s: installed version (%s) is higher than available update (%s), no change", + req_kind.c_str(), name.c_str(), installed->edition().asString().c_str(), update->edition().asString().c_str()); + return false; + } + } + else + { + y2internal("Unknown resolvable action"); + return false; + } } else { @@ -298,12 +357,27 @@ YCPValue PkgFunctions::ResolvableInstall( const YCPString& name_r, const YCPSymbol& kind_r ) { - // true = install - return YCPBoolean(ResolvableInstallOrDelete(name_r, kind_r, true)); + return YCPBoolean(ResolvableUpdateInstallOrDelete(name_r, kind_r, Install)); } // ------------------------ /** + @builtin ResolvableUpgrade + @short Install all resolvables with selected name and kind + @param name_r name of the resolvable + @param kind_r kind of resolvable, can be `product, `patch, `package, `srcpackage or `pattern + @return boolean true if upgrade candidate was selected, false if the highest version is already installed or if there is no upgrade candidate + * +*/ +YCPValue +PkgFunctions::ResolvableUpdate( const YCPString& name_r, const YCPSymbol& kind_r ) +{ + return YCPBoolean(ResolvableUpdateInstallOrDelete(name_r, kind_r, Update)); +} + + +// ------------------------ +/** @builtin ResolvableRemove @short Removes all resolvables with selected name and kind @param name_r name of the resolvable @@ -314,7 +388,7 @@ PkgFunctions::ResolvableRemove ( const YCPString& name_r, const YCPSymbol& kind_r ) { // false = remove - return YCPBoolean(ResolvableInstallOrDelete(name_r, kind_r, false)); + return YCPBoolean(ResolvableUpdateInstallOrDelete(name_r, kind_r, Remove)); } // ------------------------ -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r67597 - in /branches/SuSE-Code-11-SP1-Branch/wagon: VERSION package/yast2-wagon.changes src/modules/Wagon.ycp
by lslezak＠svn2.opensuse.org 08 Mar '12

08 Mar '12

Author: lslezak Date: Thu Mar 8 13:13:37 2012 New Revision: 67597 URL: http://svn.opensuse.org/viewcvs/yast?rev=67597&view=rev Log: - ensure that the migration products are removed (bnc#750746) - 2.17.17.10 Modified: branches/SuSE-Code-11-SP1-Branch/wagon/VERSION branches/SuSE-Code-11-SP1-Branch/wagon/package/yast2-wagon.changes branches/SuSE-Code-11-SP1-Branch/wagon/src/modules/Wagon.ycp Modified: branches/SuSE-Code-11-SP1-Branch/wagon/VERSION URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/wagon… ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/wagon/VERSION (original) +++ branches/SuSE-Code-11-SP1-Branch/wagon/VERSION Thu Mar 8 13:13:37 2012 @@ -1 +1 @@ -2.17.17.9 +2.17.17.10 Modified: branches/SuSE-Code-11-SP1-Branch/wagon/package/yast2-wagon.changes URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/wagon… ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/wagon/package/yast2-wagon.changes (original) +++ branches/SuSE-Code-11-SP1-Branch/wagon/package/yast2-wagon.changes Thu Mar 8 13:13:37 2012 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Wed Mar 7 08:14:29 UTC 2012 - lslezak(a)suse.cz + +- ensure that the migration products are removed (bnc#750746) +- 2.17.17.10 + +------------------------------------------------------------------- Wed Feb 15 10:33:50 UTC 2012 - lslezak(a)suse.cz - Automatically save solver test case in the migration proposal Modified: branches/SuSE-Code-11-SP1-Branch/wagon/src/modules/Wagon.ycp URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/wagon… ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/wagon/src/modules/Wagon.ycp (original) +++ branches/SuSE-Code-11-SP1-Branch/wagon/src/modules/Wagon.ycp Thu Mar 8 13:13:37 2012 @@ -467,6 +467,14 @@ // be compatible with "zypper dup --from" Pkg::SetSolverFlags($["ignoreAlreadyRecommended" : true]); + // ensure the migration products are removed + foreach(string migration_product, migration_products, + { + y2milestone("Removing migration product: %1", migration_product); + Pkg::ResolvableRemove(migration_product, `product); + } + ); + if (MigrationType() == `full) { // run the solver to evaluate applicable patches -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r67596 - in /trunk/s390/src: dasd/dialogs.ycp dasd/helps.ycp modules/DASDController.ycp modules/ZFCPController.ycp zfcp/dialogs.ycp zfcp/helps.ycp
by aschnell＠svn2.opensuse.org 08 Mar '12

08 Mar '12

Author: aschnell Date: Thu Mar 8 11:56:12 2012 New Revision: 67596 URL: http://svn.opensuse.org/viewcvs/yast?rev=67596&view=rev Log: - consistent use of "Channel ID", "WWPN" and "LUN" (discussed with Ihno) - hide get buttons in zfcp add dialog in config mode Modified: trunk/s390/src/dasd/dialogs.ycp trunk/s390/src/dasd/helps.ycp trunk/s390/src/modules/DASDController.ycp trunk/s390/src/modules/ZFCPController.ycp trunk/s390/src/zfcp/dialogs.ycp trunk/s390/src/zfcp/helps.ycp Modified: trunk/s390/src/dasd/dialogs.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/s390/src/dasd/dialogs.ycp?rev=67… ============================================================================== --- trunk/s390/src/dasd/dialogs.ycp (original) +++ trunk/s390/src/dasd/dialogs.ycp Thu Mar 8 11:56:12 2012 @@ -136,7 +136,7 @@ { header = `header( // table header - `Right(_("Channel")), + `Right(_("Channel ID")), // table header _("Format"), // table header @@ -147,7 +147,7 @@ { header = `header( // table header - `Right(_("Channel")), + `Right(_("Channel ID")), // table header _("Device"), // table header @@ -180,9 +180,9 @@ term content = `VBox( `HBox( // text entry - `InputField(`id(`min_chan), `opt(`hstretch), _("Mi&nimum Channel"), DASDController::filter_min), + `InputField(`id(`min_chan), `opt(`hstretch), _("Mi&nimum Channel ID"), DASDController::filter_min), // text entry - `InputField(`id(`max_chan), `opt(`hstretch), _("Ma&ximum Channel"), DASDController::filter_max), + `InputField(`id(`max_chan), `opt(`hstretch), _("Ma&ximum Channel ID"), DASDController::filter_max), `VBox ( `Label (""), // push button @@ -249,7 +249,7 @@ if (!DASDController::IsValidChannel(filter_min) || !DASDController::IsValidChannel(filter_max)) { // error popup - Popup::Error(_("Invalid filter channels.")); + Popup::Error(_("Invalid filter channel IDs.")); ret = nil; continue; } @@ -477,7 +477,7 @@ `VStretch (), `TextEntry (`id(`channel), `opt (`hstretch), // text entry - _("&Channel Number") + _("&Channel ID") ), `VSpacing (2), // check box @@ -518,7 +518,7 @@ if (!DASDController::IsValidChannel(channel)) { // error popup - Popup::Error(_("Not a valid channel.")); + Popup::Error(_("Not a valid channel ID.")); UI::SetFocus(`channel); ret = nil; continue; Modified: trunk/s390/src/dasd/helps.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/s390/src/dasd/helps.ycp?rev=6759… ============================================================================== --- trunk/s390/src/dasd/helps.ycp (original) +++ trunk/s390/src/dasd/helps.ycp Thu Mar 8 11:56:12 2012 @@ -39,8 +39,8 @@ In this dialog, manage DASD disks on your system.") + /* Disk selection dialog help 2/4 */ -_("To filter the displayed disks, set the Minimum Channel and -the Maximum Channel and click Filter. +_("To filter the displayed disks, set the Minimum Channel ID and +the Maximum Channel ID and click Filter. ") + /* Disk selection dialog help 4/4 */ @@ -55,8 +55,8 @@ In this dialog, manage DASD disks on your system.") + /* Disk selection dialog help 2/4 */ -_("To filter the displayed disks, set the Minimum Channel and -the Maximum Channel and click Filter. +_("To filter the displayed disks, set the Minimum Channel ID and +the Maximum Channel ID and click Filter. ") + /* Disk selection dialog help 3/4 */ @@ -70,7 +70,7 @@ /* Disk add help 1/3 */ "disk_add_config" : _("<big>Add New DASD Disk</big> -To add a disk, enter the Channel Number of the DASD disk as +To add a disk, enter the Channel ID of the DASD disk as identifier.") + /* Disk add help 1/3 */ Modified: trunk/s390/src/modules/DASDController.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/s390/src/modules/DASDController.… ============================================================================== --- trunk/s390/src/modules/DASDController.ycp (original) +++ trunk/s390/src/modules/DASDController.ycp Thu Mar 8 11:56:12 2012 @@ -301,7 +301,7 @@ { ret = maplist (integer index, map<string, any> d, devices, { // summary text, %1 is channel, %2 and %3 are Yes or No - return sformat(_("Channel: %1, Format: %2, DIAG: %3"), d["channel"]:"", + return sformat(_("Channel ID: %1, Format: %2, DIAG: %3"), d["channel"]:"", String::YesNo(d["format"]:false), String::YesNo(d["diag"]:false)); }); } @@ -314,7 +314,7 @@ ret = maplist (integer index, map<string, any> d, active_devices, { // summary text, %1 is channel, %2 is device name, %3 is Yes or No - return sformat(_("Channel: %1, Device: %2, DIAG: %3"), d["channel"]:"", + return sformat(_("Channel ID: %1, Device: %2, DIAG: %3"), d["channel"]:"", d["dev_name"]:"", String::YesNo(d["diag"]:false)); }); } Modified: trunk/s390/src/modules/ZFCPController.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/s390/src/modules/ZFCPController.… ============================================================================== --- trunk/s390/src/modules/ZFCPController.ycp (original) +++ trunk/s390/src/modules/ZFCPController.ycp Thu Mar 8 11:56:12 2012 @@ -313,7 +313,7 @@ { ret = maplist (integer index, map<string,any> d, devices, { // summary text, %1 is channel, %2 is WWPN, %3 is LUN - return sformat(_("Channel: %1, WWPN: %2, ZFCP LUN: %3"), + return sformat(_("Channel ID: %1, WWPN: %2, LUN: %3"), d["detail", "controller_id"]:"", d["detail", "wwpn"]:"", d["detail", "fcp_lun"]:""); }); @@ -322,7 +322,7 @@ { ret = maplist (integer index, map<string,any> d, devices, { // summary text, %1 is channel, %2 is WWPN, %3 is LUN, %4 is device name - return sformat(_("Channel: %1, WWPN: %2, ZFCP LUN: %3, Device: %4"), + return sformat(_("Channel ID: %1, WWPN: %2, LUN: %3, Device: %4"), d["detail", "controller_id"]:"", d["detail", "wwpn"]:"", d["detail", "fcp_lun"]:"", d["dev_name"]:""); }); @@ -468,13 +468,13 @@ case 8: Report::Error (sformat ( // error report, %1 is device identification - _("%1: ZFCP LUN could not be unregistered."), channel)); + _("%1: LUN could not be unregistered."), channel)); break; case 9: Report::Error (sformat ( // error report, %1 is device identification - _("%1: ZFCP WWPN could not be unregistered."), channel)); + _("%1: WWPN could not be unregistered."), channel)); break; default: Modified: trunk/s390/src/zfcp/dialogs.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/s390/src/zfcp/dialogs.ycp?rev=67… ============================================================================== --- trunk/s390/src/zfcp/dialogs.ycp (original) +++ trunk/s390/src/zfcp/dialogs.ycp Thu Mar 8 11:56:12 2012 @@ -110,22 +110,22 @@ { header = `header( // table header - `Right(_("Channel Number")), + `Right(_("Channel ID")), // table header `Right(_("WWPN")), // table header - `Right(_("ZFCP-LUN")) + `Right(_("LUN")) ); } else { header = `header( // table header - `Right(_("Channel Number")), + `Right(_("Channel ID")), // table header `Right(_("WWPN")), // table header - `Right(_("ZFCP-LUN")), + `Right(_("LUN")), // table header _("Device") ); @@ -135,9 +135,9 @@ term content = `VBox( `HBox( // text entry - `InputField(`id(`min_chan), `opt(`hstretch), _("Mi&nimum Channel"), ZFCPController::filter_min), + `InputField(`id(`min_chan), `opt(`hstretch), _("Mi&nimum Channel ID"), ZFCPController::filter_min), // text entry - `InputField(`id(`max_chan), `opt(`hstretch), _("Ma&ximum Channel"), ZFCPController::filter_max), + `InputField(`id(`max_chan), `opt(`hstretch), _("Ma&ximum Channel ID"), ZFCPController::filter_max), `VBox ( `Label (""), // push button @@ -197,7 +197,7 @@ if (!ZFCPController::IsValidChannel(filter_min) || !ZFCPController::IsValidChannel(filter_max)) { // error popup - Popup::Error(_("Invalid filter channels.")); + Popup::Error(_("Invalid filter channel IDs.")); ret = nil; continue; } @@ -239,47 +239,62 @@ /* Minimal text for the help */ string help = ZFCP_HELPS["disk_add"]:""; - /* Dialog caption */ + // dialog caption string caption = _("Add New ZFCP Device"); - string fcp_lun = ZFCPController::previous_settings["fcp_lun"]:""; - if (!isempty(fcp_lun)) - fcp_lun = ZFCPController::GetNextLUN(fcp_lun); + list<string> channels = []; + list<string> wwpns = []; + list<string> luns = []; - list<string> items = []; if (Mode::config ()) { - items = maplist (integer index, map<string, any> d, ZFCPController::devices, { + channels = maplist(integer index, map<string, any> d, ZFCPController::devices, { return d["detail", "controller_id"]:""; }); - items = toset (items); + channels = toset(channels); + + wwpns = maplist(integer index, map<string, any> d, ZFCPController::devices, { + return d["detail", "wwpn"]:""; + }); + wwpns = toset(wwpns); + + luns = maplist(integer index, map<string, any> d, ZFCPController::devices, { + return d["detail", "zfp_lun"]:""; + }); + luns = toset(luns); } else { - items = maplist (map<string, any> c, ZFCPController::GetControllers(), { + channels = maplist (map<string, any> c, ZFCPController::GetControllers(), { return c["sysfs_bus_id"]:""; }); + + wwpns = [ ZFCPController::previous_settings["wwpn"]:"" ]; + + string fcp_lun = ZFCPController::previous_settings["fcp_lun"]:""; + if (!isempty(fcp_lun)) + fcp_lun = ZFCPController::GetNextLUN(fcp_lun); + + luns = [ fcp_lun ]; } - /* Dialog content */ term content = `HBox (`HStretch (), `VBox( `VStretch (), - `ComboBox (`id(`channel), `opt (`editable, `hstretch), - // combo box - _("&Channel Number"), - items), + // combo box + `ComboBox(`id(`channel), `opt (`editable, `hstretch), _("&Channel ID"), channels), `VSpacing (2), - `HBox( - // text entry - `ComboBox(`id(`wwpn), `opt(`hstretch, `editable), _("&WWPN"), - [ ZFCPController::previous_settings["wwpn"]:"" ]), - `PushButton(`id(`get_wwpn), _("Get WWPNs")) + `HBox( + // combo box + `ComboBox(`id(`wwpn), `opt(`hstretch, `editable), _("&WWPN"), wwpns), + // push button + Mode::config() ? `Empty() : `PushButton(`id(`get_wwpn), _("Get WWPNs")) ), `VSpacing (2), - `HBox( - // text entry - `ComboBox(`id(`fcp_lun), `opt(`hstretch, `editable), _("&FCP-LUN"), [ fcp_lun ]), - `PushButton(`id(`get_lun), _("Get LUNs")) + `HBox( + // combobox + `ComboBox(`id(`fcp_lun), `opt(`hstretch, `editable), _("&LUN"), luns), + // push button + Mode::config() ? `Empty() : `PushButton(`id(`get_lun), _("Get LUNs")) ), `VStretch () ), `HStretch ()); @@ -307,7 +322,7 @@ if (!ZFCPController::IsValidChannel(channel)) { // error popup - Popup::Error(_("Not a valid channel.")); + Popup::Error(_("Not a valid channel ID.")); UI::SetFocus(`channel); ret = nil; continue; @@ -315,8 +330,8 @@ channel = ZFCPController::FormatChannel(channel); - list<string> items = ZFCPController::GetWWPNs(channel); - UI::ChangeWidget(`wwpn, `Items, items); + wwpns = ZFCPController::GetWWPNs(channel); + UI::ChangeWidget(`wwpn, `Items, wwpns); ret = nil; } else if (ret == `get_lun) @@ -327,7 +342,7 @@ if (!ZFCPController::IsValidChannel(channel)) { // error popup - Popup::Error(_("Not a valid channel.")); + Popup::Error(_("Not a valid channel ID.")); UI::SetFocus(`channel); ret = nil; continue; @@ -345,8 +360,8 @@ channel = ZFCPController::FormatChannel(channel); wwpn = ZFCPController::FormatWWPN(wwpn); - list<string> items = ZFCPController::GetLUNs(channel, wwpn); - UI::ChangeWidget(`fcp_lun, `Items, items); + luns = ZFCPController::GetLUNs(channel, wwpn); + UI::ChangeWidget(`fcp_lun, `Items, luns); ret = nil; } else if (ret == `abort || ret == `cancel) @@ -367,7 +382,7 @@ if (!ZFCPController::IsValidChannel(channel)) { // error popup - Popup::Error(_("Not a valid channel.")); + Popup::Error(_("Not a valid channel ID.")); UI::SetFocus(`channel); ret = nil; continue; @@ -385,7 +400,7 @@ if (!ZFCPController::IsValidFCPLUN(fcp_lun)) { // error popup - Report::Error(_("The entered FCP-LUN is invalid.")); + Report::Error(_("The entered LUN is invalid.")); UI::SetFocus(`fcp_lun); ret = nil; continue; Modified: trunk/s390/src/zfcp/helps.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/s390/src/zfcp/helps.ycp?rev=6759… ============================================================================== --- trunk/s390/src/zfcp/helps.ycp (original) +++ trunk/s390/src/zfcp/helps.ycp Thu Mar 8 11:56:12 2012 @@ -54,11 +54,11 @@ /* Disk add help 1/2 */ "disk_add" : _("<big>Add New ZFCP Device</big> Enter the identifier of the device to add, the -Channel Number of the ZFCP controller, the worldwide port number -(WWPN) and the FCP-LUN number. +Channel ID of the ZFCP controller, the worldwide port number +(WWPN) and the LUN number. ") + /* Disk add help 2/2, This is HTML, so finally "<devno>" is displayed as "<devno>" */ -_("The Channel Number must be entered with lowercase letters in a sysfs conforming +_("The Channel ID must be entered with lowercase letters in a sysfs conforming format 0.0.<devno>, such as <tt>0.0.5c51</tt>. The WWPN must be entered with lowercase letters as a 16-digit hex value, such as <tt>0x5005076300c40e5a</tt>. -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r67595 - /branches/SuSE-Code-11-SP2-Branch/ncurses-pkg/package/yast2-ncurses-pkg.changes
by gs＠svn2.opensuse.org 08 Mar '12

08 Mar '12

Author: gs Date: Thu Mar 8 11:46:46 2012 New Revision: 67595 URL: http://svn.opensuse.org/viewcvs/yast?rev=67595&view=rev Log: improve license popup Modified: branches/SuSE-Code-11-SP2-Branch/ncurses-pkg/package/yast2-ncurses-pkg.changes Modified: branches/SuSE-Code-11-SP2-Branch/ncurses-pkg/package/yast2-ncurses-pkg.changes URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/ncurs… ============================================================================== --- branches/SuSE-Code-11-SP2-Branch/ncurses-pkg/package/yast2-ncurses-pkg.changes (original) +++ branches/SuSE-Code-11-SP2-Branch/ncurses-pkg/package/yast2-ncurses-pkg.changes Thu Mar 8 11:46:46 2012 @@ -1,4 +1,9 @@ ------------------------------------------------------------------- +Thu Mar 8 11:44:37 CET 2012 - gs(a)suse.de + +- Better apperance of license popup + +------------------------------------------------------------------- Mon Sep 5 15:56:49 CEST 2011 - gs(a)suse.de - Require latest yast2-ncurses version to prevent update/upgrade -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r67594 - /branches/SuSE-Code-11-SP2-Branch/ncurses-pkg/src/NCPkgTable.cc
by gs＠svn2.opensuse.org 08 Mar '12

08 Mar '12

Author: gs Date: Thu Mar 8 11:44:16 2012 New Revision: 67594 URL: http://svn.opensuse.org/viewcvs/yast?rev=67594&view=rev Log: improve license popup Modified: branches/SuSE-Code-11-SP2-Branch/ncurses-pkg/src/NCPkgTable.cc Modified: branches/SuSE-Code-11-SP2-Branch/ncurses-pkg/src/NCPkgTable.cc URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/ncurs… ============================================================================== --- branches/SuSE-Code-11-SP2-Branch/ncurses-pkg/src/NCPkgTable.cc (original) +++ branches/SuSE-Code-11-SP2-Branch/ncurses-pkg/src/NCPkgTable.cc Thu Mar 8 11:44:16 2012 @@ -244,9 +244,8 @@ if (!license_confirmed) { NCPopupInfo * info = new NCPopupInfo( wpos( (lines * 10)/100, (cols * 10) /100), - NCPkgStrings::NotifyLabel(), - string( _("End User License Agreement") + - "" + pkgName + " " + packager->createDescrText( license ) ), + _("End User License Agreement"), + "" + pkgName + " " + packager->createDescrText( license ), NCPkgStrings::AcceptLabel(), NCPkgStrings::CancelLabel() ); -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r67593 - /branches/SuSE-Code-11-SP1-Branch/rdp/yast2-rdp.spec.in
by locilka＠svn2.opensuse.org 08 Mar '12

08 Mar '12

Author: locilka Date: Thu Mar 8 11:35:40 2012 New Revision: 67593 URL: http://svn.opensuse.org/viewcvs/yast?rev=67593&view=rev Log: Another spec file fix Modified: branches/SuSE-Code-11-SP1-Branch/rdp/yast2-rdp.spec.in Modified: branches/SuSE-Code-11-SP1-Branch/rdp/yast2-rdp.spec.in URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/rdp/y… ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/rdp/yast2-rdp.spec.in (original) +++ branches/SuSE-Code-11-SP1-Branch/rdp/yast2-rdp.spec.in Thu Mar 8 11:35:40 2012 @@ -25,7 +25,6 @@ @yncludedir@/rdp/* @clientdir@/rdp.ycp @clientdir@/rdp_*.ycp -@moduledir@/Rdp.* -@moduledir@/Rdp2.* +@moduledir@/RDP.* @desktopdir@/rdp.desktop %doc @docdir@ -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r67592 - /branches/SuSE-Code-11-SP1-Branch/rdp/yast2-rdp.spec.in
by locilka＠svn2.opensuse.org 08 Mar '12

08 Mar '12

Author: locilka Date: Thu Mar 8 11:32:42 2012 New Revision: 67592 URL: http://svn.opensuse.org/viewcvs/yast?rev=67592&view=rev Log: Fixed spec file Modified: branches/SuSE-Code-11-SP1-Branch/rdp/yast2-rdp.spec.in Modified: branches/SuSE-Code-11-SP1-Branch/rdp/yast2-rdp.spec.in URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/rdp/y… ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/rdp/yast2-rdp.spec.in (original) +++ branches/SuSE-Code-11-SP1-Branch/rdp/yast2-rdp.spec.in Thu Mar 8 11:32:42 2012 @@ -2,7 +2,7 @@ @HEADER@ Requires: yast2 -BuildRequires: perl-XML-Writer update-desktop-files yast2 yast2-devtools yast2-testsuite +BuildRequires: perl-XML-Writer update-desktop-files yast2 yast2-devtools yast2-testsuite yast2-network BuildArchitectures: noarch -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r67591 - /branches/SuSE-Code-11-SP2-Branch/ncurses/package/yast2-ncurses.changes
by gs＠svn2.opensuse.org 08 Mar '12

08 Mar '12

Author: gs Date: Thu Mar 8 11:27:06 2012 New Revision: 67591 URL: http://svn.opensuse.org/viewcvs/yast?rev=67591&view=rev Log: bnc #724119, bnc #737752 Modified: branches/SuSE-Code-11-SP2-Branch/ncurses/package/yast2-ncurses.changes Modified: branches/SuSE-Code-11-SP2-Branch/ncurses/package/yast2-ncurses.changes URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/ncurs… ============================================================================== --- branches/SuSE-Code-11-SP2-Branch/ncurses/package/yast2-ncurses.changes (original) +++ branches/SuSE-Code-11-SP2-Branch/ncurses/package/yast2-ncurses.changes Thu Mar 8 11:27:06 2012 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Thu Mar 8 11:18:13 CET 2012 - gs(a)suse.de + +- NCRichText: interpret html tags inside <pre> (bnc #724119), + show license text correctly (bnc #737752) + +------------------------------------------------------------------- Thu Jun 16 12:34:46 CEST 2011 - gs(a)suse.de - Fixed segfault in event handling (bnc #696595) -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r67590 - in /branches/SuSE-Code-11-SP2-Branch/ncurses/src: NCRichText.cc NCRichText.h
by gs＠svn2.opensuse.org 08 Mar '12

08 Mar '12

Author: gs Date: Thu Mar 8 11:26:16 2012 New Revision: 67590 URL: http://svn.opensuse.org/viewcvs/yast?rev=67590&view=rev Log: interpret html tags inside <pre> (bnc #724119), also solves problem with license text (bnc #737752) Modified: branches/SuSE-Code-11-SP2-Branch/ncurses/src/NCRichText.cc branches/SuSE-Code-11-SP2-Branch/ncurses/src/NCRichText.h Modified: branches/SuSE-Code-11-SP2-Branch/ncurses/src/NCRichText.cc URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/ncurs… ============================================================================== --- branches/SuSE-Code-11-SP2-Branch/ncurses/src/NCRichText.cc (original) +++ branches/SuSE-Code-11-SP2-Branch/ncurses/src/NCRichText.cc Thu Mar 8 11:26:16 2012 @@ -160,7 +160,7 @@ , NCPadWidget( parent ) , text( ntext ) , plainText( plainTextMode ) - , textwidth( 0 ) + , textwidth( 0 ) , cl( 0 ) , cc( 0 ) , cindent( 0 ) @@ -322,36 +322,23 @@ } } - -void NCRichText::PadPlainTXT( const wchar_t * osch, const unsigned olen ) +void NCRichText::PadPreTXT( const wchar_t * osch, const unsigned olen ) { wstring wtxt( osch, olen ); + // resolve the entities even in PRE (#71718) wtxt = filterEntities( wtxt ); - + NCstring nctxt( wtxt ); NCtext ftext( nctxt ); - if ( ftext.Columns() > textwidth ) - textwidth = ftext.Columns(); - - AdjustPad( wsze( cl + ftext.Lines(), textwidth ) ); - // insert the text const wchar_t * sch = wtxt.data(); while ( *sch ) { - if ( *sch != L'\r' ) // skip carriage return - { - myPad()->addwstr( sch, 1 ); // add one wide chararacter - cc += wcwidth( *sch ); + myPad()->addwstr( sch, 1 ); // add one wide chararacter - if ( *sch == L'\n' ) - { - PadNL(); // add a new line - } - } ++sch; } } @@ -398,21 +385,92 @@ while ( *wch && WDtoken.find( *wch ) == wstring::npos ); } +static wstring PREtoken( L"<\n\v\r\f" ); // line manipulations + TokenStart '<' + inline void SkipPreTXT( const wchar_t *& wch ) { + do + { + ++wch; + } + while ( *wch && PREtoken.find( *wch ) == wstring::npos ); +} + + +void NCRichText::AdjustPrePad( const wchar_t *osch ) +{ + const wchar_t * wch = osch; wstring wstr( wch, 6 ); + size_t llen = 0; // longest line + size_t tmp_len = 0; // width of current line + + list<NCstring>::const_iterator line; // iterator for list <NCstring> mtext + std::wstring::const_iterator wstr_it; // iterator for wstring + do { - ++wch; + ++wch; wstr.assign( wch, 6 ); } while ( *wch && wstr != L"</pre>" ); -} + wstring wtxt( osch, wch - osch ); + + // resolve the entities to get correct length for calculation of longest line + wtxt = filterEntities( wtxt ); + wstring to_repl = L" "; + size_t pos; + // replace by \n to get appropriate lines in NCtext + for ( ; (pos = wtxt.find( to_repl )) != wstring::npos ; ) + wtxt.replace( pos, to_repl.length(), L"\n" ); + // handle DOS text + for ( ; (pos = wtxt.find( L"\r" )) != wstring::npos ; ) + wtxt.replace( pos, 1, L"" ); + for ( ; (pos = wtxt.find( L"\f" )) != wstring::npos ; ) + wtxt.replace( pos, 1, L"\n" ); + + yuiDebug() << "Input: " << wtxt << " olen: " << wch - osch << endl; + + NCstring nctxt( wtxt ); + NCtext ftext( nctxt ); + + // iterate through NCtext + for ( line = ftext.Text().begin(); line != ftext.Text().end(); ++line ) + { + tmp_len = 0; + + for ( wstr_it = ( *line ).str().begin(); wstr_it != ( *line ).str().end() ; ++wstr_it ) + { + // skip html tags + if ( *wstr_it == '<' ) + { + wstr_it = find(wstr_it, (*line).str().end(), L'>'); + } + else if ( *wstr_it == '\t' ) + { + tmp_len += myPad()->tabsize(); + } + else + { + tmp_len += wcwidth( *wstr_it ); + } + } + + if ( tmp_len > llen ) + llen = tmp_len; + } + + if ( llen > textwidth ) + { + textwidth = llen; + AdjustPad( wsze( cl + ftext.Lines(), llen ) ); // adjust pad to longest line + } + +} void NCRichText::DrawHTMLPad() { @@ -441,6 +499,7 @@ case L'\n': case L'\v': case L'\r': + case L'\f': if ( ! preTag ) { SkipWS( wch ); @@ -448,12 +507,20 @@ } else { - if ( *wch != L'\r' ) // skip carriage return + switch ( *wch ) { - myPad()->addwstr( wch, 1 ); // add the wide chararacter - cc += wcwidth( *wch ); - if ( *wch == '\n' ) - PadNL(); + case L' ': // add white space + case L'\t': + myPad()->addwstr( wch, 1 ); + break; + + case L'\n': + case L'\f': + PadNL(); // add new line + break; + + default: + yuiDebug() << "Ignoring " << *wch << endl; } ++wch; } @@ -461,16 +528,14 @@ break; case L'<': - if ( !preTag ) - { - swch = wch; - SkipToken( wch ); + swch = wch; + SkipToken( wch ); + + if ( PadTOKEN( swch, wch ) ) + break; // strip token + else + wch = swch; // reset and fall through - if ( PadTOKEN( swch, wch ) ) - break; // strip token - else - wch = swch; // reset and fall through - } default: swch = wch; @@ -482,9 +547,7 @@ else { SkipPreTXT( wch ); - PadPlainTXT( swch, wch - swch ); - preTag = false; - PadNL(); // add new line after pre is closed + PadPreTXT( swch, wch - swch ); } break; @@ -493,6 +556,7 @@ PadBOL(); AdjustPad( wsze( cl, textwidth ) ); + yuiDebug() << "Anchors: " << anchors.size() << endl; for ( unsigned i = 0; i < anchors.size(); ++i ) @@ -575,7 +639,8 @@ /** * Get the number of columns needed to print a 'wstring'. Only printable characters - * are taken into account because others would return -1 (e.g. '\n'). + * are taken into account because otherwise 'wcwidth' would return -1 (e.g. for '\n'). + * Tabs are calculated with tabsize(). * Attention: only use textWidth() to calculate space, not for iterating through a text * or to get the length of a text (real text length includes new lines). */ @@ -588,7 +653,13 @@ { // check whether char is printable if ( iswprint( *wstr_it ) ) + { len += wcwidth( *wstr_it ); + } + else if ( *wstr_it == '\t' ) + { + len += myPad()->tabsize(); + } } return len; @@ -819,7 +890,7 @@ else if ( value == L"li" ) token = T_LI; else if ( value == L"ol" ) { token = T_LEVEL; leveltag = 1; } else if ( value == L"qt" ) token = T_IGNORE; - else if ( value == L"tt" ) token = T_TT; + else if ( value == L"tt" ) token = T_IGNORE; else if ( value == L"ul" ) { token = T_LEVEL; leveltag = 0; } break; @@ -959,11 +1030,13 @@ if ( !endtag ) { - preTag = true; // display plain text + preTag = true; // display text preserving newlines and spaces + AdjustPrePad( ech ); } else { preTag = false; + PadNL(); // add new line (text may continue after </pre>) } break; Modified: branches/SuSE-Code-11-SP2-Branch/ncurses/src/NCRichText.h URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP2-Branch/ncurs… ============================================================================== --- branches/SuSE-Code-11-SP2-Branch/ncurses/src/NCRichText.h (original) +++ branches/SuSE-Code-11-SP2-Branch/ncurses/src/NCRichText.h Thu Mar 8 11:26:16 2012 @@ -1,4 +1,3 @@ - /*---------------------------------------------------------------------\ | | | __ __ ____ _____ ____ | @@ -69,8 +68,7 @@ unsigned cindent; bool atbol; - bool preTag; // default is false; set true - // if <pre> tag is found + bool preTag; // <pre> tag unsigned Tattr; @@ -190,7 +188,8 @@ void PadBOL(); void PadWS( const bool tab = false ); void PadTXT( const wchar_t * sch, const unsigned len ); - void PadPlainTXT( const wchar_t * sch, const unsigned len ); + void PadPreTXT( const wchar_t * sch, const unsigned len ); + void AdjustPrePad( const wchar_t * sch ); bool PadTOKEN( const wchar_t * sch, const wchar_t *& ech ); protected: -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0