November 2009 - YaST Commits - openSUSE Mailing Lists

[yast-commit] r59714 - /trunk/network/src/modules/Lan.ycp
by mzugec＠svn.opensuse.org 23 Nov '09

23 Nov '09

Author: mzugec Date: Mon Nov 23 16:19:28 2009 New Revision: 59714 URL: http://svn.opensuse.org/viewcvs/yast?rev=59714&view=rev Log: supplement previous patch: exclude nfsroot devices from bridged slaves (bnc#557688) Modified: trunk/network/src/modules/Lan.ycp Modified: trunk/network/src/modules/Lan.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/network/src/modules/Lan.ycp?rev=… ============================================================================== --- trunk/network/src/modules/Lan.ycp (original) +++ trunk/network/src/modules/Lan.ycp Mon Nov 23 16:19:28 2009 @@ -816,31 +816,6 @@ continue; } if (size(ifcfg)>0){ - if (! (NetworkInterfaces::GetType(ifcfg)=="bond")){ - NetworkInterfaces::Edit(ifcfg); - string new_ifcfg = sformat("br%1", NetworkInterfaces::GetFreeDevice("br")); - y2milestone("old configuration %1, bridge %2", ifcfg, new_ifcfg); - NetworkInterfaces::Name = new_ifcfg; - NetworkInterfaces::Current["BRIDGE"]="yes"; - NetworkInterfaces::Current["BRIDGE_PORTS"]=ifcfg; - NetworkInterfaces::Current["BRIDGE_STP"]="off"; - NetworkInterfaces::Current["BRIDGE_FORWARDDELAY"]="0"; - // hardcode startmode (bnc#450670), it can't be ifplugd! - NetworkInterfaces::Current["STARTMODE"]="auto"; - // remove description - will be replaced by new (real) one - NetworkInterfaces::Current=remove(NetworkInterfaces::Current, "NAME"); - if( NetworkInterfaces::Commit() ){ - NetworkInterfaces::Delete(ifcfg); - NetworkInterfaces::Commit(); - - LanItems::Items[current, "ifcfg"] = new_ifcfg; - LanItems::modified=true; - LanItems::force_restart=true; - y2debug("List %1", NetworkInterfaces::List("")); - // re-read configuration to see new items in UI - LanItems::Read(); - } else y2error("error while proposing bridge device for %1", ifcfg); - } else { NetworkInterfaces::Edit(ifcfg); map<string, any> old_config = NetworkInterfaces::Current; y2debug("Old Config %1\n%2", ifcfg, old_config); -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r59713 - in /trunk/apparmor/src/clients: GenProf.ycp LogProf.ycp
by kmachalkova＠svn.opensuse.org 23 Nov '09

23 Nov '09

Author: kmachalkova Date: Mon Nov 23 16:17:37 2009 New Revision: 59713 URL: http://svn.opensuse.org/viewcvs/yast?rev=59713&view=rev Log: znova a lepe Modified: trunk/apparmor/src/clients/GenProf.ycp trunk/apparmor/src/clients/LogProf.ycp Modified: trunk/apparmor/src/clients/GenProf.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/apparmor/src/clients/GenProf.ycp… ============================================================================== --- trunk/apparmor/src/clients/GenProf.ycp (original) +++ trunk/apparmor/src/clients/GenProf.ycp Mon Nov 23 16:17:37 2009 @@ -345,7 +345,7 @@ boolean written = SCR::Write(.genprof, answers); } else { - string errortext = sformat(_("AppArmor backend terminated unexpectedly: %1", type)) + + string errortext = sformat(_("AppArmor backend terminated unexpectedly: %1"), type) + _("This is worth reporting bug in Novell Bugzilla:\nhttps://bugzilla.novell.com"); Popup::Error(errortext); Modified: trunk/apparmor/src/clients/LogProf.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/apparmor/src/clients/LogProf.ycp… ============================================================================== --- trunk/apparmor/src/clients/LogProf.ycp (original) +++ trunk/apparmor/src/clients/LogProf.ycp Mon Nov 23 16:17:37 2009 @@ -345,7 +345,7 @@ } else { - string errortext = sformat(_("AppArmor backend terminated unexpectedly: %1", type)) + + string errortext = sformat(_("AppArmor backend terminated unexpectedly: %1"), type) + _("This is worth reporting bug in Novell Bugzilla:\nhttps://bugzilla.novell.com"); Popup::Error(errortext); done = true; -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r59712 - /tags/stable-2_19_0/apparmor/
by kmachalkova＠svn.opensuse.org 23 Nov '09

23 Nov '09

Author: kmachalkova Date: Mon Nov 23 16:13:41 2009 New Revision: 59712 URL: http://svn.opensuse.org/viewcvs/yast?rev=59712&view=rev Log: Created tag stable-2_19_0 for apparmor Added: tags/stable-2_19_0/apparmor/ - copied from r59711, trunk/apparmor/ -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r59711 - in /trunk/apparmor: VERSION package/yast2-apparmor.changes
by kmachalkova＠svn.opensuse.org 23 Nov '09

23 Nov '09

Author: kmachalkova Date: Mon Nov 23 16:13:28 2009 New Revision: 59711 URL: http://svn.opensuse.org/viewcvs/yast?rev=59711&view=rev Log: changes Modified: trunk/apparmor/VERSION trunk/apparmor/package/yast2-apparmor.changes Modified: trunk/apparmor/VERSION URL: http://svn.opensuse.org/viewcvs/yast/trunk/apparmor/VERSION?rev=59711&r1=59… ============================================================================== --- trunk/apparmor/VERSION (original) +++ trunk/apparmor/VERSION Mon Nov 23 16:13:28 2009 @@ -1 +1 @@ -2.18.4 +2.19.0 Modified: trunk/apparmor/package/yast2-apparmor.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/apparmor/package/yast2-apparmor.… ============================================================================== --- trunk/apparmor/package/yast2-apparmor.changes (original) +++ trunk/apparmor/package/yast2-apparmor.changes Mon Nov 23 16:13:28 2009 @@ -1,4 +1,12 @@ ------------------------------------------------------------------- +Mon Nov 23 16:09:14 CET 2009 - kmachalkova(a)suse.cz + +- Improved help text (bnc#539352) +- Better error message on unexpected backend termination (bnc#535107) +- Correct saving of event notification levels (bnc#531512) +- 2.19.0 + +------------------------------------------------------------------- Tue Oct 20 19:11:03 CEST 2009 - kmachalkova(a)suse.cz - Have GenericNames from .desktop files correctly translated (removed -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r59710 - in /branches/SuSE-Code-11-SP1-Branch/storage: VERSION package/yast2-storage.changes
by aschnell＠svn.opensuse.org 23 Nov '09

23 Nov '09

Author: aschnell Date: Mon Nov 23 16:09:38 2009 New Revision: 59710 URL: http://svn.opensuse.org/viewcvs/yast?rev=59710&view=rev Log: - bump version Modified: branches/SuSE-Code-11-SP1-Branch/storage/VERSION branches/SuSE-Code-11-SP1-Branch/storage/package/yast2-storage.changes Modified: branches/SuSE-Code-11-SP1-Branch/storage/VERSION URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/stora… ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/storage/VERSION (original) +++ branches/SuSE-Code-11-SP1-Branch/storage/VERSION Mon Nov 23 16:09:38 2009 @@ -1 +1 @@ -2.17.83 +2.17.84 Modified: branches/SuSE-Code-11-SP1-Branch/storage/package/yast2-storage.changes URL: http://svn.opensuse.org/viewcvs/yast/branches/SuSE-Code-11-SP1-Branch/stora… ============================================================================== --- branches/SuSE-Code-11-SP1-Branch/storage/package/yast2-storage.changes (original) +++ branches/SuSE-Code-11-SP1-Branch/storage/package/yast2-storage.changes Mon Nov 23 16:09:38 2009 @@ -1,4 +1,11 @@ ------------------------------------------------------------------- +Mon Nov 23 16:07:30 CET 2009 - aschnell(a)suse.de + +- improved mdadm.conf for IMSM (bnc #554142) +- support udev ids for IMSM (bnc #554143) +- 2.17.84 + +------------------------------------------------------------------- Mon Nov 16 14:11:34 CET 2009 - aschnell(a)suse.de - enabled storage proposal for S390 (bnc #462254) -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r59709 - in /trunk/apparmor/src/clients: GenProf.ycp LogProf.ycp
by kmachalkova＠svn.opensuse.org 23 Nov '09

23 Nov '09

Author: kmachalkova Date: Mon Nov 23 16:09:05 2009 New Revision: 59709 URL: http://svn.opensuse.org/viewcvs/yast?rev=59709&view=rev Log: Better error msgs Modified: trunk/apparmor/src/clients/GenProf.ycp trunk/apparmor/src/clients/LogProf.ycp Modified: trunk/apparmor/src/clients/GenProf.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/apparmor/src/clients/GenProf.ycp… ============================================================================== --- trunk/apparmor/src/clients/GenProf.ycp (original) +++ trunk/apparmor/src/clients/GenProf.ycp Mon Nov 23 16:09:05 2009 @@ -345,8 +345,9 @@ boolean written = SCR::Write(.genprof, answers); } else { + string errortext = sformat(_("AppArmor backend terminated unexpectedly: %1", type)) + + _("This is worth reporting bug in Novell Bugzilla:\nhttps://bugzilla.novell.com"); - string errortext = "Email support(a)novell.com: " + type; Popup::Error(errortext); done = true; Modified: trunk/apparmor/src/clients/LogProf.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/apparmor/src/clients/LogProf.ycp… ============================================================================== --- trunk/apparmor/src/clients/LogProf.ycp (original) +++ trunk/apparmor/src/clients/LogProf.ycp Mon Nov 23 16:09:05 2009 @@ -345,7 +345,8 @@ } else { - string errortext = "Email support(a)novell.com: " + type; + string errortext = sformat(_("AppArmor backend terminated unexpectedly: %1", type)) + + _("This is worth reporting bug in Novell Bugzilla:\nhttps://bugzilla.novell.com"); Popup::Error(errortext); done = true; -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] <web-client> master : Fix testsuite: don't split param, because serialization also doesn't do it (really crapy behavior)
by Josef Reidinger 23 Nov '09

23 Nov '09

ref: refs/heads/master commit a6a799cf6bb0c1f3c60a59cef2a5afa0892b1d1c Author: Josef Reidinger <jreidinger(a)suse.cz> Date: Mon Nov 23 16:02:59 2009 +0100 Fix testsuite: don't split param, because serialization also doesn't do it (really crapy behavior) --- .../network/app/controllers/network_controller.rb | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/network/app/controllers/network_controller.rb b/plugins/network/app/controllers/network_controller.rb index 0400038..d4ff189 100644 --- a/plugins/network/app/controllers/network_controller.rb +++ b/plugins/network/app/controllers/network_controller.rb @@ -83,11 +83,12 @@ class NetworkController < ApplicationController dns = load_proxy "org.opensuse.yast.modules.yapi.network.dns" return false unless dns #compare empty array and nill cause true, so at first test emptyness + #FIXME repair it when spliting of param is ready unless (dns.nameservers.empty? && params["nameservers"].blank?) - dirty = true unless ( dns.nameservers == params["nameservers"].split) + dirty = true unless ( dns.nameservers == params["nameservers"]) end unless (dns.searches.empty? && params["searchdomains"].blank?) - dirty = true if (dns.searches == params["searchdomains"].split) + dirty = true if (dns.searches == params["searchdomains"]) end logger.info "dirty after dns: #{dirty}" # FIXME: params bellow should be arrays -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] <web-client> backgroud_patches_bnc550934 : Fix testsuite: don't split param, because serialization also doesn't do it (really crapy behavior)
by Josef Reidinger 23 Nov '09

23 Nov '09

ref: refs/heads/backgroud_patches_bnc550934 commit a6a799cf6bb0c1f3c60a59cef2a5afa0892b1d1c Author: Josef Reidinger <jreidinger(a)suse.cz> Date: Mon Nov 23 16:02:59 2009 +0100 Fix testsuite: don't split param, because serialization also doesn't do it (really crapy behavior) --- .../network/app/controllers/network_controller.rb | 5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/plugins/network/app/controllers/network_controller.rb b/plugins/network/app/controllers/network_controller.rb index 0400038..d4ff189 100644 --- a/plugins/network/app/controllers/network_controller.rb +++ b/plugins/network/app/controllers/network_controller.rb @@ -83,11 +83,12 @@ class NetworkController < ApplicationController dns = load_proxy "org.opensuse.yast.modules.yapi.network.dns" return false unless dns #compare empty array and nill cause true, so at first test emptyness + #FIXME repair it when spliting of param is ready unless (dns.nameservers.empty? && params["nameservers"].blank?) - dirty = true unless ( dns.nameservers == params["nameservers"].split) + dirty = true unless ( dns.nameservers == params["nameservers"]) end unless (dns.searches.empty? && params["searchdomains"].blank?) - dirty = true if (dns.searches == params["searchdomains"].split) + dirty = true if (dns.searches == params["searchdomains"]) end logger.info "dirty after dns: #{dirty}" # FIXME: params bellow should be arrays -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] <web-client> master : don't write to backend if form is not changed (prevent network restart) (bnc#552548) release 0.0.10
by Josef Reidinger 23 Nov '09

23 Nov '09

ref: refs/heads/master commit 32ae9fbf0d3670c7fa3d8440f4979f1a8d055600 Author: Josef Reidinger <jreidinger(a)suse.cz> Date: Mon Nov 23 15:16:57 2009 +0100 don't write to backend if form is not changed (prevent network restart) (bnc#552548) release 0.0.10 --- .../network/app/controllers/network_controller.rb | 34 ++++++++++++++++--- .../package/yast2-webclient-network.changes | 6 +++ .../network/package/yast2-webclient-network.spec | 2 +- .../test/functional/network_controller_test.rb | 14 ++++++++ 4 files changed, 49 insertions(+), 7 deletions(-) diff --git a/plugins/network/app/controllers/network_controller.rb b/plugins/network/app/controllers/network_controller.rb index 515a326..0400038 100644 --- a/plugins/network/app/controllers/network_controller.rb +++ b/plugins/network/app/controllers/network_controller.rb @@ -73,35 +73,56 @@ class NetworkController < ApplicationController # PUT /users/1 # PUT /users/1.xml def update + dirty = false rt = load_proxy "org.opensuse.yast.modules.yapi.network.routes", "default" return false unless rt + dirty = true unless rt.via == params["default_route"] rt.via = params["default_route"] + logger.info "dirty after default routing: #{dirty}" dns = load_proxy "org.opensuse.yast.modules.yapi.network.dns" return false unless dns + #compare empty array and nill cause true, so at first test emptyness + unless (dns.nameservers.empty? && params["nameservers"].blank?) + dirty = true unless ( dns.nameservers == params["nameservers"].split) + end + unless (dns.searches.empty? && params["searchdomains"].blank?) + dirty = true if (dns.searches == params["searchdomains"].split) + end + logger.info "dirty after dns: #{dirty}" # FIXME: params bellow should be arrays dns.nameservers = params["nameservers"]#.split dns.searches = params["searchdomains"]#.split hn = load_proxy "org.opensuse.yast.modules.yapi.network.hostname" return false unless hn + dirty = true unless (hn.name == params["name"] && hn.domain == params["domain"]) + logger.info "dirty after hostname: #{dirty}" hn.name = params["name"] hn.domain = params["domain"] ifc = load_proxy "org.opensuse.yast.modules.yapi.network.interfaces", params["interface"] return false unless ifc + dirty = true unless (ifc.bootproto == params["conf_mode"]) + logger.info "dirty after interface config: #{dirty}" ifc.bootproto=params["conf_mode"] if ifc.bootproto=="static" + #ip addr is returned in another state then given, but restart of static address is not problem + dirty = true ifc.ipaddr=params["ip"]+"/"+params["netmask"] end - + begin # this is not transaction! # if any *.save failed, the previous will be applied - rt.save - dns.save - hn.save - ifc.save + # FIXME JR: I think that if user choose dhcp not all settings should be written + if dirty + rt.save + dns.save + hn.save + ifc.save + end +#write to avoid confusion, with another string flash[:notice] = _('Network settings have been written.') rescue ActiveResource::ServerError => e response = Hash.from_xml(e.response.body) @@ -111,10 +132,11 @@ class NetworkController < ApplicationController else raise end + #XXX FIXME don't catch universal exception, it is not user friendly and break testing of update rescue Exception => e flash[:error] = e.message logger.warn e - end + end redirect_success end diff --git a/plugins/network/package/yast2-webclient-network.changes b/plugins/network/package/yast2-webclient-network.changes index 42464cc..ac5f10a 100644 --- a/plugins/network/package/yast2-webclient-network.changes +++ b/plugins/network/package/yast2-webclient-network.changes @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Mon Nov 23 14:14:16 UTC 2009 - jreidinger(a)novell.com + +- write to backend only if form is changed (bnc#552548) +- 0.0.10 + +------------------------------------------------------------------- Thu Nov 12 11:25:14 UTC 2009 - jreidinger(a)novell.com - update translation (schubi) diff --git a/plugins/network/package/yast2-webclient-network.spec b/plugins/network/package/yast2-webclient-network.spec index 5f40e91..3a0e737 100644 --- a/plugins/network/package/yast2-webclient-network.spec +++ b/plugins/network/package/yast2-webclient-network.spec @@ -13,7 +13,7 @@ Name: yast2-webclient-network License: GPL v2 only Group: Productivity/Networking/Web/Utilities Autoreqprov: on -Version: 0.0.9 +Version: 0.0.10 Release: 0 Summary: YaST2 - Webclient - network Source: www.tar.bz2 diff --git a/plugins/network/test/functional/network_controller_test.rb b/plugins/network/test/functional/network_controller_test.rb index f71fd2e..c382205 100644 --- a/plugins/network/test/functional/network_controller_test.rb +++ b/plugins/network/test/functional/network_controller_test.rb @@ -1,6 +1,7 @@ require 'test_helper' require 'ostruct' require File.expand_path( File.join("test","validation_assert"), RailsParent.parent ) +require 'mocha' class OpenStruct undef_method :id # so that it looks for our id @@ -10,6 +11,11 @@ class NetworkControllerTest < ActionController::TestCase class Proxy attr_accessor :result, :timeout + + def initialize + @saved = false + end + def permissions return { :read => true, :execute => true } end @@ -81,4 +87,12 @@ class NetworkControllerTest < ActionController::TestCase assert_not_nil assigns(:name) end + def test_dhcp_without_change + @if_proxy.result["eth1"] = OpenStruct.new("bootproto" => "dhcp") + @if_proxy.expects(:save).never #don't call save if dhcp is not saved + post :update, { :interface => "eth1", :conf_mode => "dhcp" } + assert_response :redirect + assert_redirected_to :action => "index" + end + end -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] <web-client> backgroud_patches_bnc550934 : don't write to backend if form is not changed (prevent network restart) (bnc#552548) release 0.0.10
by Josef Reidinger 23 Nov '09

23 Nov '09

ref: refs/heads/backgroud_patches_bnc550934 commit 32ae9fbf0d3670c7fa3d8440f4979f1a8d055600 Author: Josef Reidinger <jreidinger(a)suse.cz> Date: Mon Nov 23 15:16:57 2009 +0100 don't write to backend if form is not changed (prevent network restart) (bnc#552548) release 0.0.10 --- .../network/app/controllers/network_controller.rb | 34 ++++++++++++++++--- .../package/yast2-webclient-network.changes | 6 +++ .../network/package/yast2-webclient-network.spec | 2 +- .../test/functional/network_controller_test.rb | 14 ++++++++ 4 files changed, 49 insertions(+), 7 deletions(-) diff --git a/plugins/network/app/controllers/network_controller.rb b/plugins/network/app/controllers/network_controller.rb index 515a326..0400038 100644 --- a/plugins/network/app/controllers/network_controller.rb +++ b/plugins/network/app/controllers/network_controller.rb @@ -73,35 +73,56 @@ class NetworkController < ApplicationController # PUT /users/1 # PUT /users/1.xml def update + dirty = false rt = load_proxy "org.opensuse.yast.modules.yapi.network.routes", "default" return false unless rt + dirty = true unless rt.via == params["default_route"] rt.via = params["default_route"] + logger.info "dirty after default routing: #{dirty}" dns = load_proxy "org.opensuse.yast.modules.yapi.network.dns" return false unless dns + #compare empty array and nill cause true, so at first test emptyness + unless (dns.nameservers.empty? && params["nameservers"].blank?) + dirty = true unless ( dns.nameservers == params["nameservers"].split) + end + unless (dns.searches.empty? && params["searchdomains"].blank?) + dirty = true if (dns.searches == params["searchdomains"].split) + end + logger.info "dirty after dns: #{dirty}" # FIXME: params bellow should be arrays dns.nameservers = params["nameservers"]#.split dns.searches = params["searchdomains"]#.split hn = load_proxy "org.opensuse.yast.modules.yapi.network.hostname" return false unless hn + dirty = true unless (hn.name == params["name"] && hn.domain == params["domain"]) + logger.info "dirty after hostname: #{dirty}" hn.name = params["name"] hn.domain = params["domain"] ifc = load_proxy "org.opensuse.yast.modules.yapi.network.interfaces", params["interface"] return false unless ifc + dirty = true unless (ifc.bootproto == params["conf_mode"]) + logger.info "dirty after interface config: #{dirty}" ifc.bootproto=params["conf_mode"] if ifc.bootproto=="static" + #ip addr is returned in another state then given, but restart of static address is not problem + dirty = true ifc.ipaddr=params["ip"]+"/"+params["netmask"] end - + begin # this is not transaction! # if any *.save failed, the previous will be applied - rt.save - dns.save - hn.save - ifc.save + # FIXME JR: I think that if user choose dhcp not all settings should be written + if dirty + rt.save + dns.save + hn.save + ifc.save + end +#write to avoid confusion, with another string flash[:notice] = _('Network settings have been written.') rescue ActiveResource::ServerError => e response = Hash.from_xml(e.response.body) @@ -111,10 +132,11 @@ class NetworkController < ApplicationController else raise end + #XXX FIXME don't catch universal exception, it is not user friendly and break testing of update rescue Exception => e flash[:error] = e.message logger.warn e - end + end redirect_success end diff --git a/plugins/network/package/yast2-webclient-network.changes b/plugins/network/package/yast2-webclient-network.changes index 42464cc..ac5f10a 100644 --- a/plugins/network/package/yast2-webclient-network.changes +++ b/plugins/network/package/yast2-webclient-network.changes @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Mon Nov 23 14:14:16 UTC 2009 - jreidinger(a)novell.com + +- write to backend only if form is changed (bnc#552548) +- 0.0.10 + +------------------------------------------------------------------- Thu Nov 12 11:25:14 UTC 2009 - jreidinger(a)novell.com - update translation (schubi) diff --git a/plugins/network/package/yast2-webclient-network.spec b/plugins/network/package/yast2-webclient-network.spec index 5f40e91..3a0e737 100644 --- a/plugins/network/package/yast2-webclient-network.spec +++ b/plugins/network/package/yast2-webclient-network.spec @@ -13,7 +13,7 @@ Name: yast2-webclient-network License: GPL v2 only Group: Productivity/Networking/Web/Utilities Autoreqprov: on -Version: 0.0.9 +Version: 0.0.10 Release: 0 Summary: YaST2 - Webclient - network Source: www.tar.bz2 diff --git a/plugins/network/test/functional/network_controller_test.rb b/plugins/network/test/functional/network_controller_test.rb index f71fd2e..c382205 100644 --- a/plugins/network/test/functional/network_controller_test.rb +++ b/plugins/network/test/functional/network_controller_test.rb @@ -1,6 +1,7 @@ require 'test_helper' require 'ostruct' require File.expand_path( File.join("test","validation_assert"), RailsParent.parent ) +require 'mocha' class OpenStruct undef_method :id # so that it looks for our id @@ -10,6 +11,11 @@ class NetworkControllerTest < ActionController::TestCase class Proxy attr_accessor :result, :timeout + + def initialize + @saved = false + end + def permissions return { :read => true, :execute => true } end @@ -81,4 +87,12 @@ class NetworkControllerTest < ActionController::TestCase assert_not_nil assigns(:name) end + def test_dhcp_without_change + @if_proxy.result["eth1"] = OpenStruct.new("bootproto" => "dhcp") + @if_proxy.expects(:save).never #don't call save if dhcp is not saved + post :update, { :interface => "eth1", :conf_mode => "dhcp" } + assert_response :redirect + assert_redirected_to :action => "index" + end + end -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0