YaST Commits September 2008

yast-commit@lists.opensuse.org

26 participants
1212 discussions

[yast-commit] r50529 - /trunk/autoinstallation/src/modules/AutoinstClone.ycp
by ug＠svn.opensuse.org 01 Sep '08

01 Sep '08

Author: ug Date: Mon Sep 1 16:21:28 2008 New Revision: 50529 URL: http://svn.opensuse.org/viewcvs/yast?rev=50529&view=rev Log: cleanup Modified: trunk/autoinstallation/src/modules/AutoinstClone.ycp Modified: trunk/autoinstallation/src/modules/AutoinstClone.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/autoinstallation/src/modules/Aut… ============================================================================== --- trunk/autoinstallation/src/modules/AutoinstClone.ycp (original) +++ trunk/autoinstallation/src/modules/AutoinstClone.ycp Mon Sep 1 16:21:28 2008 @@ -58,6 +58,9 @@ /** * Set root password */ + + /* useless */ + /* define list root() ``{ list<map> shadow = (list<map>) SCR::Read(.etc.shadow); map rootacct = (map) filter(map acct, shadow, ``(acct["username"]:"" == "root"))[0]:$[]; @@ -69,6 +72,7 @@ users = add(users, rootacct_mod); return users; } + */ /** @@ -78,6 +82,8 @@ * @param list mount points * @return string */ + /* useless */ + /* define string findMountpoint(string device, map p, list<map> mounts) { string mountPoint = ""; @@ -90,17 +96,21 @@ }); return mountPoint; } + */ /** * Convert units to size * @param list region * @return integer size */ + /* useless */ + /* define integer units_to_size (list region) { integer units = (integer) region[1]:0; return (units * bytes_per_unit) - bytes_per_unit + 1; }; + */ /** -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r50528 - /trunk/storage/storage/src/include/ep-hd-lib.ycp
by aschnell＠svn.opensuse.org 01 Sep '08

01 Sep '08

Author: aschnell Date: Mon Sep 1 16:12:38 2008 New Revision: 50528 URL: http://svn.opensuse.org/viewcvs/yast?rev=50528&view=rev Log: - work on messages Modified: trunk/storage/storage/src/include/ep-hd-lib.ycp Modified: trunk/storage/storage/src/include/ep-hd-lib.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/include/ep-h… ============================================================================== --- trunk/storage/storage/src/include/ep-hd-lib.ycp (original) +++ trunk/storage/storage/src/include/ep-hd-lib.ycp Mon Sep 1 16:12:38 2008 @@ -12,6 +12,7 @@ { if (disk_device == nil) { + // error popup Popup::Error(_("No hard disk selected.")); return; } @@ -21,6 +22,7 @@ if (disk["used_by_device"]:"" != "") { + // error popup Popup::Error(_("The disk is in use and cannot be modified.")); return; } @@ -41,6 +43,7 @@ UI::OpenDialog(`opt(`decorated), Greasemonkey::Transform( `VBox( + // dialog heading `Label(sformat(_("Select new partition table type for %1."), disk_device)), `RadioButtonGroup(`id(`labels), tmp), `HBox( @@ -61,6 +64,7 @@ return; } + // popup text, %1 is be replaced by disk name e.g. /dev/sda if (Popup::YesNo(sformat(_("Really create new partition table on %1? This will delete all data on %1 and all RAIDs and Volume Groups using partitions on %1."), disk_device))) { @@ -75,6 +79,7 @@ { if (device == nil) { + // error popup Popup::Error(_("No disk selected.")); return; } @@ -84,6 +89,7 @@ if (disk["type"]:`CT_UNKNOWN == `CT_DMRAID) { + // popup text if (Popup::YesNo(sformat(_("Really delete BIOS RAID %1?"), device))) { if (deleteAllDevPartitions(disk, Stage::initial(), false)) @@ -94,6 +100,7 @@ } else { + // error popup Popup::Error(_("The disk cannot be deleted.")); } } @@ -127,7 +134,7 @@ if (size(ret) == 0) { - // TODO: give detailed reasons esp. for msdos partition table + // error popup string text = sformat(_("It is not possible to create a partition on %1."), disk_device); Popup::Warning(text); } @@ -144,6 +151,7 @@ { if (disk_device == nil) { + // error popup Popup::Error(_("No hard disk selected.")); return; } @@ -153,6 +161,7 @@ if (disk["used_by_device"]:"" != "") { + // error popup Popup::Error(_("The disk is in use and cannot be modified.")); return; } @@ -175,8 +184,6 @@ if (DlgCreatePartition(data)) { - Debug("create partition with data", data); - string device = data["device"]:"error"; symbol mby = data["mountby"]:Storage::GetMountBy(device); @@ -198,6 +205,7 @@ { if (device == nil) { + // error popup Popup::Error(_("No partition selected.")); return; } @@ -207,6 +215,7 @@ if (data["used_by"]:"" != "") { + // error popup, %1 is replace by partition device name e.g. /dev/sdb1 Popup::Error(sformat(_("The partition %1 is in use. It cannot be edited. To edit %1, make sure it is not used."), device)); return; @@ -214,8 +223,6 @@ if (DlgEditPartition(data)) { - Debug("edit partition from data", data); - Storage::ChangeVolumeProperties(data); UpdateNavigationTree(nil); @@ -229,6 +236,7 @@ { if (device == nil) { + // error popup Popup::Error(_("No partition selected.")); return; } @@ -245,6 +253,7 @@ if (data["used_by"]:"" != "") { + // error popup, %1 is replace by partition device name, e.g. /dev/sdb1 Popup::Error(sformat(_("The partition %1 is in use. It cannot be resized. To resize %1, make sure it is not used."), device)); return; @@ -259,6 +268,7 @@ { if (device == nil) { + // error popup Popup::Error(_("No partition selected.")); return; } @@ -281,7 +291,7 @@ if (!disk["dasdfmt"]:false) { - // popup text %1 is replaced by a dasd name e.g. /dev/dasda + // popup text, %1 is replaced by a dasd name e.g. /dev/dasda boolean doit = Popup::YesNo(sformat( _("Running dasdfmt deletes all data on the disk. Really execute dasdfmt on disk %1? @@ -294,6 +304,7 @@ } else { + // popup text Popup::Message(_("The disk is no longer marked for dasdfmt. Partitions currently present on this disk are again -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r50527 - in /trunk/pkg-bindings/src: Makefile.am ServiceManager.cc
by lslezak＠svn.opensuse.org 01 Sep '08

01 Sep '08

Author: lslezak Date: Mon Sep 1 15:24:42 2008 New Revision: 50527 URL: http://svn.opensuse.org/viewcvs/yast?rev=50527&view=rev Log: - fixed ServiceManager reset and alias change - build the new files Modified: trunk/pkg-bindings/src/Makefile.am trunk/pkg-bindings/src/ServiceManager.cc Modified: trunk/pkg-bindings/src/Makefile.am URL: http://svn.opensuse.org/viewcvs/yast/trunk/pkg-bindings/src/Makefile.am?rev… ============================================================================== --- trunk/pkg-bindings/src/Makefile.am (original) +++ trunk/pkg-bindings/src/Makefile.am Mon Sep 1 15:24:42 2008 @@ -51,6 +51,8 @@ Callbacks.cc Callbacks_Register.cc \ Y2PkgFunction.cc Y2PkgFunction.h \ YRepo.h YRepo.cc \ + PkgService.cc PkgService.h \ + ServiceManager.cc ServiceManager.h \ HelpTexts.h i18n.h log.h Modified: trunk/pkg-bindings/src/ServiceManager.cc URL: http://svn.opensuse.org/viewcvs/yast/trunk/pkg-bindings/src/ServiceManager.… ============================================================================== --- trunk/pkg-bindings/src/ServiceManager.cc (original) +++ trunk/pkg-bindings/src/ServiceManager.cc Mon Sep 1 15:24:42 2008 @@ -228,7 +228,9 @@ void ServiceManager::Reset() { y2milestone("Resetting known services..."); + // reset the internal structures _known_services.clear(); + _services_loaded = false; } @@ -263,32 +265,40 @@ return zypp::ServiceInfo::noService; } -// FIXME allow to change the alias bool ServiceManager::SetService(const std::string old_alias, const zypp::ServiceInfo &srv) { try { - std::string alias(srv.alias()); - - PkgServices::const_iterator serv_it = _known_services.find(alias); + PkgServices::const_iterator serv_it = _known_services.find(old_alias); if (serv_it != _known_services.end()) { if (serv_it->second.isDeleted()) { - y2warning("Service %s has been removed", alias.c_str()); + y2warning("Service %s has been removed", old_alias.c_str()); return false; } else { - PkgService s(srv, old_alias); - _known_services[alias] = s; + // if the alias has been already changed then keep the original alias + if (old_alias == serv_it->second.alias() ) + { + PkgService s(srv, old_alias); + _known_services[srv.alias()] = s; + } + else + { + // keep the old alias + PkgService s(srv, serv_it->second.origAlias()); + _known_services[srv.alias()] = s; + } + return true; } } else { - y2error("Service %s does not exist", alias.c_str()); + y2error("Service %s does not exist", old_alias.c_str()); return false; } } -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r50526 - /tags/stable-2_17_24/storage/
by aschnell＠svn.opensuse.org 01 Sep '08

01 Sep '08

Author: aschnell Date: Mon Sep 1 15:16:37 2008 New Revision: 50526 URL: http://svn.opensuse.org/viewcvs/yast?rev=50526&view=rev Log: Created tag stable-2_17_24 for storage Added: tags/stable-2_17_24/storage/ - copied from r50525, trunk/storage/ -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r50525 - /tags/stable-2_17_24/
by aschnell＠svn.opensuse.org 01 Sep '08

01 Sep '08

Author: aschnell Date: Mon Sep 1 15:16:36 2008 New Revision: 50525 URL: http://svn.opensuse.org/viewcvs/yast?rev=50525&view=rev Log: Created tag stable-2_17_24 Added: tags/stable-2_17_24/ -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r50524 - in /trunk/storage: VERSION package/yast2-storage.changes storage/src/modules/Partitions.ycp
by aschnell＠svn.opensuse.org 01 Sep '08

01 Sep '08

Author: aschnell Date: Mon Sep 1 15:04:26 2008 New Revision: 50524 URL: http://svn.opensuse.org/viewcvs/yast?rev=50524&view=rev Log: - support EFI boot on non-ia64 systems (fate #303995) Modified: trunk/storage/VERSION trunk/storage/package/yast2-storage.changes trunk/storage/storage/src/modules/Partitions.ycp Modified: trunk/storage/VERSION URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/VERSION?rev=50524&r1=505… ============================================================================== --- trunk/storage/VERSION (original) +++ trunk/storage/VERSION Mon Sep 1 15:04:26 2008 @@ -1 +1 @@ -2.17.23 +2.17.24 Modified: trunk/storage/package/yast2-storage.changes URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/package/yast2-storage.ch… ============================================================================== --- trunk/storage/package/yast2-storage.changes (original) +++ trunk/storage/package/yast2-storage.changes Mon Sep 1 15:04:26 2008 @@ -1,4 +1,10 @@ ------------------------------------------------------------------- +Mon Sep 01 15:02:31 CEST 2008 - aschnell(a)suse.de + +- support EFI boot on non-ia64 systems (fate #303995) +- version 2.17.24 + +------------------------------------------------------------------- Wed Aug 27 17:34:10 CEST 2008 - aschnell(a)suse.de - fixed documentation in StorageInterface.h Modified: trunk/storage/storage/src/modules/Partitions.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/modules/Part… ============================================================================== --- trunk/storage/storage/src/modules/Partitions.ycp (original) +++ trunk/storage/storage/src/modules/Partitions.ycp Mon Sep 1 15:04:26 2008 @@ -101,7 +101,30 @@ global boolean EfiBoot() { - return Arch::ia64(); + boolean ret = false; + + if (Arch::ia64()) + { + ret = true; + } + else + { + if (Stage::initial()) + { + string tmp = (string) SCR::Read(.etc.install_inf.EFI); + if (tmp != nil && tmp == "1") + ret = true; + } + else + { + string tmp = (string) SCR::Read(.etc.bootloader.LOADER_TYPE); + if (tmp != nil && tmp == "elilo") + ret = true; + } + } + + y2milestone("EfiBoot ret:%1", ret); + return ret; } -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r50523 - /trunk/storage/storage/src/include/ep-settings.ycp
by aschnell＠svn.opensuse.org 01 Sep '08

01 Sep '08

Author: aschnell Date: Mon Sep 1 14:52:35 2008 New Revision: 50523 URL: http://svn.opensuse.org/viewcvs/yast?rev=50523&view=rev Log: - work on helptexts Modified: trunk/storage/storage/src/include/ep-settings.ycp Modified: trunk/storage/storage/src/include/ep-settings.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/include/ep-s… ============================================================================== --- trunk/storage/storage/src/include/ep-settings.ycp (original) +++ trunk/storage/storage/src/include/ep-settings.ycp Mon Sep 1 14:52:35 2008 @@ -48,7 +48,7 @@ `item(`id(`path), _("Device Path")) ], `id(Storage::GetDefaultMountBy()))), `Left(`ComboBoxSelected(`id(`default_fs), - _("Default Filesystem"), + _("Default File System"), [ `item(`id(`ext2), "Ext2"), `item(`id(`ext3), "Ext3"), `item(`id(`reiserfs), "Reiser") ], @@ -72,7 +72,28 @@ `VStretch() ))); - Wizard::RestoreHelp("TODO"); + + // helptext + string helptext = _("This view shows general storage +settings:"); + + // helptext + helptext = helptext + _("Default Mount by gives the mount by +method for newly created file systems."); + + // helptext + helptext = helptext + _("Default File System gives the file +system type for newly created file file systems."); + + // helptext + helptext = helptext + _("Show Storage Devices by controls +the name displayed for hard disks in the navigation tree."); + + // helptext + helptext = helptext + _("Visible Information On Storage +Devices allows to hide information in the tables and overview."); + + Wizard::RestoreHelp(helptext); } -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r50522 - /trunk/storage/storage/src/modules/StorageFields.ycp
by aschnell＠svn.opensuse.org 01 Sep '08

01 Sep '08

Author: aschnell Date: Mon Sep 1 14:28:31 2008 New Revision: 50522 URL: http://svn.opensuse.org/viewcvs/yast?rev=50522&view=rev Log: - work on helptexts Modified: trunk/storage/storage/src/modules/StorageFields.ycp Modified: trunk/storage/storage/src/modules/StorageFields.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/modules/Stor… ============================================================================== --- trunk/storage/storage/src/modules/StorageFields.ycp (original) +++ trunk/storage/storage/src/modules/StorageFields.ycp Mon Sep 1 14:28:31 2008 @@ -305,7 +305,7 @@ break; case `model: - // helptext for table column and overview entry + // helptext for table column and overview entry ret = ret + _("Model shows the device model."); break; @@ -370,7 +370,8 @@ case `type: // helptext for table column and overview entry - // TODO + ret = ret + _("Type gives a general overview about the +device type."); break; case `udev_id: @@ -380,7 +381,7 @@ break; case `udev_path: - // helptext for table column and overview entry + // helptext for table column and overview entry ret = ret + _("Device Path shows the persistent device path. This field can be empty."); break; -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r50521 - in /trunk/nis-client/src: Nis.ycp ui.ycp
by jsuchome＠svn.opensuse.org 01 Sep '08

01 Sep '08

Author: jsuchome Date: Mon Sep 1 14:14:17 2008 New Revision: 50521 URL: http://svn.opensuse.org/viewcvs/yast?rev=50521&view=rev Log: laoyout fixes, code cleanup Modified: trunk/nis-client/src/Nis.ycp trunk/nis-client/src/ui.ycp Modified: trunk/nis-client/src/Nis.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/nis-client/src/Nis.ycp?rev=50521… ============================================================================== --- trunk/nis-client/src/Nis.ycp (original) +++ trunk/nis-client/src/Nis.ycp Mon Sep 1 14:14:17 2008 @@ -130,6 +130,9 @@ y2milestone("getNetconfigValues called"); policy = (string)SCR::Read(.sysconfig.network.config.NETCONFIG_NIS_POLICY); + y2milestone("policy : %1", policy); + if (policy == nil) policy = ""; + map<string, map<string, string> > staticVals = $[]; list<string> keylist = SCR::Dir (.sysconfig.network.config); Modified: trunk/nis-client/src/ui.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/nis-client/src/ui.ycp?rev=50521&… ============================================================================== --- trunk/nis-client/src/ui.ycp (original) +++ trunk/nis-client/src/ui.ycp Mon Sep 1 14:14:17 2008 @@ -279,16 +279,16 @@ `item(`id(`auto), "auto"), `item(`id(`custom), "custom") ]), - `InputField (`id(`custompolicy), `opt (`hstrech), + `InputField (`id(`custompolicy), `opt (`hstretch), // text entry label _("C&ustom Policy"), "") ), `VSpacing (0.2), // text entry label - `InputField (`id (`domain), `opt (`hstrech), _("N&IS Domain"), + `InputField (`id (`domain), `opt (`hstretch), _("N&IS Domain"), domain), `VSpacing (0.2), - `InputField (`id (`servers), `opt (`hstrech), + `InputField (`id (`servers), `opt (`hstretch), // text entry label _("&Addresses of NIS servers"), servers), `HBox ( @@ -320,16 +320,16 @@ con = `HBox (`HSpacing (0.5), `VCenter ( `VBox ( `VSpacing (0.4), - `RadioButtonGroup ( - `id (`rd), - `Left ( - `HVSquash ( - `VBox ( - // radio button label - `Left (`RadioButton (`id (`nisno), `opt (`notify), _("Do &not use NIS"), !yp_client)), - // radio button label - `Left (`RadioButton (`id (`nisyes), `opt (`notify), _("&Use NIS"), yp_client)) - )))), + `RadioButtonGroup (`id (`rd), `Left ( `HVSquash (`VBox ( + `Left (`RadioButton (`id (`nisno), `opt (`notify), + // radio button label + _("Do &not use NIS"), !yp_client) + ), + `Left (`RadioButton (`id (`nisyes), `opt (`notify), + // radio button label + _("&Use NIS"), yp_client) + ) + )))), `VSpacing (1.2), nis_frame, `VSpacing (0.4), @@ -356,30 +356,28 @@ UI::ChangeWidget (`id (`autofs), `Enabled, Nis::_autofs_allowed); - if(Nis::policy == "") + if (Nis::policy == "") { - UI::ChangeWidget (`id (`policy), `Value, `id(`nomodify)); - UI::ChangeWidget (`id (`custompolicy), `Enabled, false); + UI::ChangeWidget (`id (`policy), `Value, `id(`nomodify)); + UI::ChangeWidget (`id (`custompolicy), `Enabled, false); } else if(Nis::policy == "auto" || Nis::policy == "STATIC *") { - UI::ChangeWidget (`id (`policy), `Value, `id(`auto)); - UI::ChangeWidget (`id (`custompolicy), `Enabled, false); + UI::ChangeWidget (`id (`policy), `Value, `id(`auto)); + UI::ChangeWidget (`id (`custompolicy), `Enabled, false); } else { - UI::ChangeWidget (`id (`policy), `Value, `id(`custom)); - UI::ChangeWidget (`id (`custompolicy), `Enabled, true); - UI::ChangeWidget (`id (`custompolicy), `Value, Nis::policy); + UI::ChangeWidget (`id (`policy), `Value, `id(`custom)); + UI::ChangeWidget (`id (`custompolicy), `Enabled, true); + UI::ChangeWidget (`id (`custompolicy), `Value, Nis::policy); } - map event = $[]; symbol result = nil; repeat { - y2milestone("LOOP: %1", result); - - yp_client = ((symbol) UI::QueryWidget (`id (`rd), `CurrentButton) != `nisno); + y2milestone("LOOP: %1", result); + yp_client = (UI::QueryWidget (`id (`rd), `CurrentButton) != `nisno); UI::ChangeWidget (`id (`expert), `Enabled, yp_client); UI::ChangeWidget (`id (`policy), `Enabled, yp_client); //UI::ChangeWidget (`id (`custompolicy), `Enabled, yp_client); @@ -558,7 +556,7 @@ // check box label `Left (`CheckBox (`id (`broken_server), _("Br&oken server"), broken_server)), `VSpacing (0.2), - `InputField (`id (`options), `opt (`hstrech), + `InputField (`id (`options), `opt (`hstretch), // text entry label (do not translate 'ypbind') _("Other &ypbind options"), options), `VSpacing (0.2) -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

[yast-commit] r50520 - /trunk/storage/storage/src/modules/StorageFields.ycp
by aschnell＠svn.opensuse.org 01 Sep '08

01 Sep '08

Author: aschnell Date: Mon Sep 1 14:08:16 2008 New Revision: 50520 URL: http://svn.opensuse.org/viewcvs/yast?rev=50520&view=rev Log: - work on helptexts Modified: trunk/storage/storage/src/modules/StorageFields.ycp Modified: trunk/storage/storage/src/modules/StorageFields.ycp URL: http://svn.opensuse.org/viewcvs/yast/trunk/storage/storage/src/modules/Stor… ============================================================================== --- trunk/storage/storage/src/modules/StorageFields.ycp (original) +++ trunk/storage/storage/src/modules/StorageFields.ycp Mon Sep 1 14:08:16 2008 @@ -241,7 +241,8 @@ case `encrypted: // helptext for table column and overview entry - // TODO + ret = ret + _("Encrypted shows whether the file system +is encrypted."); break; case `end_cyl: @@ -270,7 +271,8 @@ case `file_path: // helptext for table column and overview entry - // TODO + ret = ret + _("File Path shows the path of the file for +an encrypted loop device."); break; case `format: @@ -282,12 +284,12 @@ case `fs_id: // helptext for table column and overview entry - // TODO + ret = ret + _("FS Id shows the file system id."); break; case `fs_type: // helptext for table column and overview entry - // TODO + ret = ret + _("FS Type shows the file system type."); break; case `label: @@ -298,7 +300,8 @@ case `lvm_metadata: // helptext for table column and overview entry - // TODO + ret = ret + _("Metadata shows the LVM metadata type for +volume groups."); break; case `model: @@ -648,7 +651,7 @@ if (style == `table) return value; else - return sformat(_("Metadata Type: %1"), value); + return sformat(_("Metadata: %1"), value); } case `pe_size: -- To unsubscribe, e-mail: yast-commit+unsubscribe(a)opensuse.org For additional commands, e-mail: yast-commit+help(a)opensuse.org

1 0

Jump to page:

2023

2022

2021

2020

2019

2018

2017

2016

2015

2014

2013

2012

2011

2010

2009

2008

2007

YaST Commits September 2008