[Bug 924314] New: malformed string in ssh options during installation
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 Bug ID: 924314 Summary: malformed string in ssh options during installation Classification: openSUSE Product: openSUSE Factory Version: 201503* Hardware: Other OS: openSUSE 13.2 Status: NEW Severity: Major Priority: P5 - None Component: Translations Assignee: ke@suse.com Reporter: trcs@gmx.com QA Contact: ke@suse.com CC: guillaume.gardet@opensuse.org, jreidinger@suse.com, sbphr@volted.net, trcs@gmx.com Depends on: 903881 Found By: --- Blocker: --- Created attachment 628657 --> http://bugzilla.opensuse.org/attachment.cgi?id=628657&action=edit File generated by "save_y2logs /tmp/y2logs.tgz" after installation. +++ This bug was initially created as a clone of Bug #903881 +++ When you reach the "Installation Settings" screen it appears the same message, it only changes the fast_gettext version (0.9.2 in this case). Steps to Reproduce: 1. Launch installation with Spanish selected as default language. 2. Continue until you reach the aforementioned screen. Actual Results: Error pop-up displaying the following message: Error Internal error. Please report a bug report with logs. Details: malformed format string - %" Caller: /usr/lib64/ruby/gems/2.1.0/gems/fast_gettext-0.9.2/lib/fast_gettext/vendor/string.rb:70:in `%' If you press the OK button then it appears a new pop-up: Error Internal error. Please report a bug report with logs. Details: undefined method `[]' for false:FalseClass Caller: /usr/share/YaST2/lib/installation/proposal_runner.rb:378:in `block in make_proposal' And there is a third pop-up when you push the OK button: Calling the YaST module `inst_proposal has failed. More information can be found near the end of the '/var/log/YaST2/y2log' file. This is worth reporting a bug at http://bugzilla.novell.com/. Please, attach also all YaST logs stored in the '/var/log/YaST2/' directory. See http://en.opensuse.org/Bugs/YaST for more information about YaST logs. You can continue the installation if you press the Next button, but you can't make any changes in this step. Expected Results: There's should work fine and let you make whatever change you want to before starting the installation. Build Date & Hardware: The bug is present in at least the following two snapshots: openSUSE-Tumbleweed-DVD-x86_64-Snapshot20150312-Media.iso openSUSE-Tumbleweed-DVD-x86_64-Snapshot20150319-Media.iso Additional Information: Any other useful information: Logs attached as suggested. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|ke@suse.com |carlos.e.r@opensuse.org --- Comment #1 from Karl Eichwalder <ke@suse.com> --- Index: network.es.po =================================================================== --- network.es.po (revision 91457) +++ network.es.po (working copy) @@ -193,11 +193,11 @@ #: src/clients/firewall_stage1_proposal.rb:287 msgid "SSH service will be enabled (<a href=\"%s\">disable</a>)" -msgstr "El servicio SSH será habilitado (<a href=\"%1\">deshabilitar</a>)" +msgstr "El servicio SSH será habilitado (<a href=\"%s\">deshabilitar</a>)" #: src/clients/firewall_stage1_proposal.rb:291 msgid "SSH service will be disabled (<a href=\"%s\">enable</a>)" -msgstr "El servicio SSH será deshabilitado (<a href=\"%1\">habilitar</a>)" +msgstr "El servicio SSH será deshabilitado (<a href=\"%s\">habilitar</a>)" #. TRANSLATORS: check-box label #: src/clients/firewall_stage1_proposal.rb:307 @@ -212,11 +212,11 @@ #. Show VNC port only if installing over VNC #: src/clients/firewall_stage1_proposal.rb:339 msgid "VNC ports will be open (<a href=\"%s\">close</a>)" -msgstr "Los puertos VNC estarán abiertos (<a href=\"%1\">cerrar</a>)" +msgstr "Los puertos VNC estarán abiertos (<a href=\"%s\">cerrar</a>)" #: src/clients/firewall_stage1_proposal.rb:341 msgid "VNC ports will be blocked (<a href=\"%s\">open</a>)" -msgstr "Los puertos VNC estarán cerrados (<a href=\"%1\">abrir</a>)" +msgstr "Los puertos VNC estarán cerrados (<a href=\"%s\">abrir</a>)" It looks as if we'd need a patch along these lines (%s instead of %1 at some points); I can apply it if wanted. Carlos, can you take a look please (or reassign it): #. Returns the SSH-port part of the firewall proposal description #. Returns nil if this part should be skipped @@ -223,11 +223,11 @@ #. @return [String] proposal html text #: src/clients/firewall_stage1_proposal.rb:352 msgid "SSH port will be open (<a href=\"%s\">block</a>)" -msgstr "El puerto SSH estará abierto (<a href=\"%1\">cerrar</a>)" +msgstr "El puerto SSH estará abierto (<a href=\"%s\">cerrar</a>)" #: src/clients/firewall_stage1_proposal.rb:354 msgid "SSH port will be blocked (<a href=\"%s\">open</a>)" -msgstr "El puerto SSH estará cerrado (<a href=\"%1\">abrir</a>)" +msgstr "El puerto SSH estará cerrado (<a href=\"%s\">abrir</a>)" #. Commandline help title #. configuration of hosts @@ -4785,7 +4785,7 @@ #: src/modules/LanItems.rb:1378 msgid "enslaved in %s" -msgstr "esclavizado en %1" +msgstr "esclavizado en %s" #: src/modules/LanItems.rb:1379 msgid "Bonding master" -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 --- Comment #2 from jc sl <trcs@gmx.com> --- Hi. I have submitted the proposed changes to Vertaal. Greetings. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 --- Comment #3 from Carlos Robinson <carlos.e.r@opensuse.org> --- Good catch. I see in 13.1 strings that both the (English) msgid and (translated) msgstr used "%1", so I suppose that it was correct at the time. On 13.2 this changed, and apparently neither the translator nor the automatic checks noticed it. Perhaps the checks could be improved for this case :-? I have applied the changes on 13.2 directly. I see jc sl did it for trunk only. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 --- Comment #5 from jc sl <trcs@gmx.com> --- (In reply to Carlos Robinson from comment #4)
I change the status to "in_progress". I hope that's the addequate state till it is verified that the applied changes work.
Hi. The problem is still present in openSUSE-Tumbleweed-DVD-x86_64-Snapshot20150410-Media. It would be nice to know if the changes are already applied or pending because this is the second or third snapshot since the fix was submitted. Greetings -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|carlos.e.r@opensuse.org |ke@suse.com --- Comment #6 from Karl Eichwalder <ke@suse.com> --- I guess thus far nobody submitted a yast2-trans-es package update. Maybe, I can work on it next week. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 --- Comment #7 from jc sl <trcs@gmx.com> --- (In reply to Karl Eichwalder from comment #6)
I guess thus far nobody submitted a yast2-trans-es package update. Maybe, I can work on it next week.
Hi. Is the process the usual in the OBS (branch package at YaST:Head → fix → submit) or YaST is somehow special? I think I could do that this week if necessary. I thought that the translations were regularly and automatically updated from the SVN. How does this work? Greetings. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 --- Comment #9 from jc sl <trcs@gmx.com> --- (In reply to Karl Eichwalder from comment #8)
I would be great if you could work on this.
Yes, translations are in our SVN. There you first create the .tar.bz2 files with the sources; then submit them to the OBS.
Thus I do this with some scripts in the 50-tools directory. I guess these days one would have to turn this into an OBS source service; then a package update could be done from external.
I don't know what I'm doing wrong but I'm not able to submit the package: https://build.opensuse.org/package/show/home:jcsl:test/yast2-trans All I get is "Unable to submit". If someone can submit the fix, please do so. No hurries. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(trcs@gmx.com) --- Comment #10 from Karl Eichwalder <ke@suse.com> --- You please must remove yast2-trans-es-boo_924314-fix.patch and update the .changes file (I guess you now updated the .tar.bz2 file). -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 --- Comment #11 from jc sl <trcs@gmx.com> --- (In reply to Karl Eichwalder from comment #10)
You please must remove yast2-trans-es-boo_924314-fix.patch and update the .changes file (I guess you now updated the .tar.bz2 file).
Hi. I have tried creating the .tar.bz2 with the fixed file; using only the patch; using a clean Firefox profile, Konqueror, Midori and even another computer and in all cases I only get "Unable to submit". I made a mistake when I forgot to restore the original file after adding the patch, but once fixed it makes no difference. I think that turning this into an OBS source service would be perfect to save time and avoid problems like this one. Greetings. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 --- Comment #12 from Josef Reidinger <jreidinger@suse.com> --- Hi, problem with submit request is that we want to prevent confusion for users as sources are based on version system, so expected work-flow is to pack version in version control system by authorized person and commit it directly. For yast modules it is done by jenkins which pick latest version and pack it. For yast-trans situation is slightly different as it is not covered by jenkins. so if @ke want to add more person that have permission to change yast2-trans, I can add it to BS repo. I am not sure if we can allow submit request only for one package. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 --- Comment #13 from jc sl <trcs@gmx.com> --- (In reply to Josef Reidinger from comment #12)
Hi, problem with submit request is that we want to prevent confusion for users as sources are based on version system, so expected work-flow is to pack version in version control system by authorized person and commit it directly. For yast modules it is done by jenkins which pick latest version and pack it. For yast-trans situation is slightly different as it is not covered by jenkins. so if @ke want to add more person that have permission to change yast2-trans, I can add it to BS repo. I am not sure if we can allow submit request only for one package.
Hi. I didn't want to deal with packaging, but this bug breaks the installation in the overview step. There has been published several new snapshots after I opened this bug report, and the bug was present some snapshots before. So it has been broken for about one or two months and I tried to fix it myself. I'm not really interested in packaging. Thanks to Karl Eichwalder now I understand the delay since the changes are made in the SVN to the moment they're applied. And it's perfectly understanable being it a manual process. But 4 months (according to the package) is a bit too much and it would be better is the process was automated. Greetings. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 --- Comment #18 from jc sl <trcs@gmx.com> --- (In reply to Karl Eichwalder from comment #17)
Ok, done:
I was waiting for a properly working snapshot to mark the bug as fixed, but on the images released after the comment 17 was posted the bug is still present. The only difference in the error message is a number in: /usr/share/YaST2/lib/installation/proposal_runner.rb:378:in `block in make_proposal' It is 431 now. I don't know if this means a new translation bug different of the ones fixed or not. The last snapshot I've tested is openSUSE-Tumbleweed-DVD-x86_64-Snapshot20150425-Media.iso -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 Karl Eichwalder <ke@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags| |needinfo?(trcs@gmx.com) --- Comment #19 from Karl Eichwalder <ke@suse.com> --- yes, these are still wrong in SVN (trunk): #. anything but enabling the firewall closes this dialog #. (VNC and SSH checkboxes do nothing) #: src/clients/firewall_stage1_proposal.rb:278 msgid "Firewall will be enabled (<a href=\"%s\">disable</a>)" msgstr "El cortafuegos será habilitado (<a href=\"%1\">deshabilitar</a>)" #: src/clients/firewall_stage1_proposal.rb:282 msgid "Firewall will be disabled (<a href=\"%s\">enable</a>)" msgstr "El cortafuegos será deshabilitado (<a href=\"%1\">habilitar</a>)" Unfortunately, msgfmt (coming with gettext) does not seem to validate ruby snippets... -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 --- Comment #20 from jc sl <trcs@gmx.com> --- (In reply to Karl Eichwalder from comment #19)
yes, these are still wrong in SVN (trunk):
#. anything but enabling the firewall closes this dialog #. (VNC and SSH checkboxes do nothing) #: src/clients/firewall_stage1_proposal.rb:278 msgid "Firewall will be enabled (<a href=\"%s\">disable</a>)" msgstr "El cortafuegos será habilitado (<a href=\"%1\">deshabilitar</a>)"
#: src/clients/firewall_stage1_proposal.rb:282 msgid "Firewall will be disabled (<a href=\"%s\">enable</a>)" msgstr "El cortafuegos será deshabilitado (<a href=\"%1\">habilitar</a>)"
I've submitted the fix to Vertaal. This time I've reviewed the whole file, but human inspection is error prone...
Unfortunately, msgfmt (coming with gettext) does not seem to validate ruby snippets...
¿Isn't there any alternative? -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.opensuse.org/show_bug.cgi?id=924314 jc sl <trcs@gmx.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #21 from jc sl <trcs@gmx.com> --- The problem is still present in openSUSE-Tumbleweed-DVD-x86_64-Snapshot20150503-Media.iso. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠novell.com