November 2022 - YaST Commits - openSUSE Mailing Lists

[yast/yast-installation] 719ec9: Fix hash vs keyword arguments in RSpec expectation...
by Martin Vidner 24 Nov '22

24 Nov '22

Branch: refs/heads/master Home: https://github.com/yast/yast-installation Commit: 719ec92236aa9de7c0b03b4d6ecdeb21cbed3a04 https://github.com/yast/yast-installation/commit/719ec92236aa9de7c0b03b4d6e… Author: Martin Vidner <mvidner(a)suse.cz> Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M test/lib/clients/inst_download_release_notes_test.rb M test/system_role_test.rb Log Message: ----------- Fix hash vs keyword arguments in RSpec expectations (bsc#1204871) New rspec-mocks distinguish between hash and keyword arguments passed to `with`. The tested code does use hashes but we've used keywords in tests because it's shorter to write. Fixed. rspec-mocks 3.11.2 / 2022-10-25: > Bug Fixes: Support keyword argument semantics when constraining argument > expectations using with on Ruby 3.0+ with instance_double > https://github.com/rspec/rspec-mocks/pull/1473 Commit: 2fe904ced9cfd98b1c6f89c11d2c5f43fb25666c https://github.com/yast/yast-installation/commit/2fe904ced9cfd98b1c6f89c11d… Author: Martin Vidner <mvidner(a)suse.cz> Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M package/yast2-installation.changes M package/yast2-installation.spec Log Message: ----------- version + changelog Commit: 67e74d406030d955ebb9ddaaa1574185c19a1e5e https://github.com/yast/yast-installation/commit/67e74d406030d955ebb9ddaaa1… Author: Martin Vidner <mvidner(a)suse.cz> Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M package/yast2-installation.changes M package/yast2-installation.spec M test/lib/clients/inst_download_release_notes_test.rb M test/system_role_test.rb Log Message: ----------- Merge pull request #1068 from yast/rspec-kw-hash Fix hash vs keyword arguments in RSpec expectations (bsc#1204871) Compare: https://github.com/yast/yast-installation/compare/9a2495e021ed...67e74d4060…

1 0

[yast/yast-installation]
by Martin Vidner 24 Nov '22

24 Nov '22

Branch: refs/heads/rspec-kw-hash Home: https://github.com/yast/yast-installation

1 0

[yast/yast-installation] 719ec9: Fix hash vs keyword arguments in RSpec expectation...
by Martin Vidner 24 Nov '22

24 Nov '22

Branch: refs/heads/rspec-kw-hash Home: https://github.com/yast/yast-installation Commit: 719ec92236aa9de7c0b03b4d6ecdeb21cbed3a04 https://github.com/yast/yast-installation/commit/719ec92236aa9de7c0b03b4d6e… Author: Martin Vidner <mvidner(a)suse.cz> Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M test/lib/clients/inst_download_release_notes_test.rb M test/system_role_test.rb Log Message: ----------- Fix hash vs keyword arguments in RSpec expectations (bsc#1204871) New rspec-mocks distinguish between hash and keyword arguments passed to `with`. The tested code does use hashes but we've used keywords in tests because it's shorter to write. Fixed. rspec-mocks 3.11.2 / 2022-10-25: > Bug Fixes: Support keyword argument semantics when constraining argument > expectations using with on Ruby 3.0+ with instance_double > https://github.com/rspec/rspec-mocks/pull/1473 Commit: 2fe904ced9cfd98b1c6f89c11d2c5f43fb25666c https://github.com/yast/yast-installation/commit/2fe904ced9cfd98b1c6f89c11d… Author: Martin Vidner <mvidner(a)suse.cz> Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M package/yast2-installation.changes M package/yast2-installation.spec Log Message: ----------- version + changelog Compare: https://github.com/yast/yast-installation/compare/17d3d9aae1ed...2fe904ced9…

1 0

[yast/yast-network]
by Martin Vidner 24 Nov '22

24 Nov '22

Branch: refs/heads/rspec-kw-hash Home: https://github.com/yast/yast-network

1 0

[yast/yast-network] dd7320: Fix hash vs keyword arguments in RSpec expectation...
by Martin Vidner 24 Nov '22

24 Nov '22

Branch: refs/heads/master Home: https://github.com/yast/yast-network Commit: dd7320fbe6f965df81891f90da50c130308fb77c https://github.com/yast/yast-network/commit/dd7320fbe6f965df81891f90da50c13… Author: Martin Vidner <mvidner(a)suse.cz> Date: 2022-11-22 (Tue, 22 Nov 2022) Changed paths: M test/y2network/driver_test.rb M test/y2network/network_manager/config_writer_test.rb M test/y2network/udev_rule_test.rb Log Message: ----------- Fix hash vs keyword arguments in RSpec expectations (bsc#1204871) New rspec-mocks distinguish between hash and keyword arguments passed to `with`. The tested code does use hashes but we've used keywords in tests because it's shorter to write. Fixed. rspec-mocks 3.11.2 / 2022-10-25: > Bug Fixes: Support keyword argument semantics when constraining argument > expectations using with on Ruby 3.0+ with instance_double > rspec/rspec-mocks#1473 Why this took longer to fix? Misleading RSpec messages: Even with current rspec-mocks 3.12.0 the error message can be confusing, differing only in the object_id of the Path: Yast::SCR received :Write with unexpected arguments expected: (#<Yast::Path:0x00007f92c30a6f88 @components=["modules", "options", "virtio_net"]>, {"debug"=>"16"}) got: (#<Yast::Path:0x00007f92c30a4d00 @components=["modules", "options", "virtio_net"]>, {"debug"=>"16"}) That's because https://github.com/rspec/rspec-mocks/commit/e931e818b577172b89fb4583fc336fb… only adds the distinguishing "(keyword arguments)" or "(options hash)" when the _inspect representations_ of the arguments are the same. To avoid this bug we could override #inspect to omit the #object_id whenever we override #==. Commit: f89bf2ca2b3bee486c4a92e61c50c9f912cbc6e8 https://github.com/yast/yast-network/commit/f89bf2ca2b3bee486c4a92e61c50c9f… Author: Martin Vidner <mvidner(a)suse.cz> Date: 2022-11-22 (Tue, 22 Nov 2022) Changed paths: M package/yast2-network.changes M package/yast2-network.spec Log Message: ----------- version + changelog Commit: 1c37acda0904e89ec9999299f9a18e3840dc5f8e https://github.com/yast/yast-network/commit/1c37acda0904e89ec9999299f9a18e3… Author: Martin Vidner <mvidner(a)suse.cz> Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M package/yast2-network.changes M package/yast2-network.spec M test/y2network/driver_test.rb M test/y2network/network_manager/config_writer_test.rb M test/y2network/udev_rule_test.rb Log Message: ----------- Merge pull request #1314 from yast/rspec-kw-hash Fix hash vs keyword arguments in RSpec expectations (bsc#1204871) Compare: https://github.com/yast/yast-network/compare/485c46fd9672...1c37acda0904

1 0

[yast/yast-country] 177c31: Version bump and change log
by Stefan Hundhammer 24 Nov '22

24 Nov '22

Branch: refs/heads/huha-fix-lang-cache Home: https://github.com/yast/yast-country Commit: 177c31541ee3ee4c6e7b8f3595fea188198fd7bb https://github.com/yast/yast-country/commit/177c31541ee3ee4c6e7b8f3595fea18… Author: Stefan Hundhammer <shundhammer(a)suse.de> Date: 2022-11-24 (Thu, 24 Nov 2022) Changed paths: M package/yast2-country.changes M package/yast2-country.spec Log Message: ----------- Version bump and change log

1 0

[yast/yast-country] c160b1: Version bump and change log
by Stefan Hundhammer 23 Nov '22

23 Nov '22

Branch: refs/heads/huha-fix-lang-cache Home: https://github.com/yast/yast-country Commit: c160b1d40b10b52bf2f251c4b593f3379ae6966e https://github.com/yast/yast-country/commit/c160b1d40b10b52bf2f251c4b593f33… Author: Stefan Hundhammer <shundhammer(a)suse.de> Date: 2022-11-23 (Wed, 23 Nov 2022) Changed paths: M package/yast2-country.changes M package/yast2-country.spec Log Message: ----------- Version bump and change log

1 0

[yast/yast-country] 6b7da5: Update translated lang names if needed
by Stefan Hundhammer 23 Nov '22

23 Nov '22

Branch: refs/heads/huha-fix-lang-cache Home: https://github.com/yast/yast-country Commit: 6b7da5829f23931af4739e8490e79d951d5ccad8 https://github.com/yast/yast-country/commit/6b7da5829f23931af4739e8490e79d9… Author: Stefan Hundhammer <shundhammer(a)suse.de> Date: 2022-11-23 (Wed, 23 Nov 2022) Changed paths: M language/src/modules/Language.rb Log Message: ----------- Update translated lang names if needed

1 0

[yast/yast-country] 565825: Removed cruft
by Stefan Hundhammer 23 Nov '22

23 Nov '22

Branch: refs/heads/huha-fix-lang-cache Home: https://github.com/yast/yast-country Commit: 565825e44a5dbb9369cd5a1a7940e19e38eb67c5 https://github.com/yast/yast-country/commit/565825e44a5dbb9369cd5a1a7940e19… Author: Stefan Hundhammer <shundhammer(a)suse.de> Date: 2022-11-23 (Wed, 23 Nov 2022) Changed paths: M language/src/modules/Language.rb Log Message: ----------- Removed cruft Commit: 785d63e09692be15051223b2a04f308f9dae3fea https://github.com/yast/yast-country/commit/785d63e09692be15051223b2a04f308… Author: Stefan Hundhammer <shundhammer(a)suse.de> Date: 2022-11-23 (Wed, 23 Nov 2022) Changed paths: M language/src/modules/Language.rb Log Message: ----------- Updated translated lang names if needed Compare: https://github.com/yast/yast-country/compare/565825e44a5d%5E...785d63e09692

1 0

[yast/yast-autoinstallation] 2e5d8a: Fix hash vs keyword arguments in RSpec expectation...
by Martin Vidner 22 Nov '22

22 Nov '22

Branch: refs/heads/rspec-kw-hash Home: https://github.com/yast/yast-autoinstallation Commit: 2e5d8aaf5d6732fda921f4e23732ffa628c53e42 https://github.com/yast/yast-autoinstallation/commit/2e5d8aaf5d6732fda921f4… Author: Martin Vidner <mvidner(a)suse.cz> Date: 2022-11-22 (Tue, 22 Nov 2022) Changed paths: M test/AutoInstallRules_test.rb M test/lib/clients/ayast_setup_test.rb Log Message: ----------- Fix hash vs keyword arguments in RSpec expectations (bsc#1204871) New rspec-mocks distinguish between hash and keyword arguments passed to `with`. The tested code does use hashes but we've used keywords in tests because it's shorter to write. Fixed. rspec-mocks 3.11.2 / 2022-10-25: > Bug Fixes: Support keyword argument semantics when constraining argument > expectations using with on Ruby 3.0+ with instance_double > https://github.com/rspec/rspec-mocks/pull/1473 Commit: a57dd88152e80a544b6038ee548d4eb49b95181c https://github.com/yast/yast-autoinstallation/commit/a57dd88152e80a544b6038… Author: Martin Vidner <mvidner(a)suse.cz> Date: 2022-11-22 (Tue, 22 Nov 2022) Changed paths: M package/autoyast2.changes M package/autoyast2.spec Log Message: ----------- version + changelog Compare: https://github.com/yast/yast-autoinstallation/compare/2e5d8aaf5d67%5E...a57…

1 0