[Bug 1225709] New: tik mounts the wrong path onto usb sticks installations
https://bugzilla.suse.com/show_bug.cgi?id=1225709 Bug ID: 1225709 Summary: tik mounts the wrong path onto usb sticks installations Classification: openSUSE Product: openSUSE Aeon Version: Current Hardware: x86-64 OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: Installation Assignee: rbrown@suse.com Reporter: hotel-brot.0z@icloud.com QA Contact: qa-bugs@suse.de Target Milestone: --- Found By: --- Blocker: --- User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:126.0) Gecko/20100101 Firefox/126.0 Build Identifier: tik tries to mount ‘/usr/bin/mount -o compress=zstd:1 /dev/disk/by-id/usb-Kingston_DataTraveler_3.0_60A44C3FAD9EE791C9291FA8-0’ but the correct path to mount would be ‘/dev/disk/by-id/usb-Kingston_DataTraveler_3.0_60A44C3FAD9EE791C9291FA8-0\:0’ it seems as if tik just stops indicating the path at \ Reproducible: Always Steps to Reproduce: try to install aeon onto a usb stick Actual Results: mount: /var/lib/tik/mig/mnt: special device /dev/disk/by-id/usb-Kingston_DataTraveler_3.0_60A44C3FAD9EE791C9291FA8-0 does not exist. dmesg(1) may have more information after failed mount system call. [/usr/lib/tik/modules/pre/20-mig][20240531-08:43:17][LOG] [pkexec][32] /usr/bin/mount -o compress=zstd:1 /dev/disk/by-id/usb-Kingston_DataTraveler_3.0_60A44C3FAD9EE791C9291FA8-0 /var/lib/tik/mig/mnt [/usr/lib/tik/modules/pre/20-mig][20240531-08:43:17][ERROR] Command <tt>/usr/bin/mount -o compress=zstd:1 /dev/disk/by-id/usb-Kingston_DataTraveler_3.0_60A44C3FAD9EE791C9291FA8-0 /var/lib/tik/mig/mnt</tt> FAILED [/usr/lib/tik/modules/pre/20-mig][20240531-08:43:20][LOG] [zenity][0][] --error --text Command <tt>/usr/bin/mount -o compress=zstd:1 /dev/disk/by-id/usb-Kingston_DataTraveler_3.0_60A44C3FAD9EE791C9291FA8-0 /var/lib/tik/mig/mnt</tt> FAILED [/usr/lib/tik/modules/pre/20-mig][20240531-08:43:20][LOG] [STOP][1] /usr/bin/tik Expected Results: Successful mounting -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225709 https://bugzilla.suse.com/show_bug.cgi?id=1225709#c1 Richard Brown <rbrown@suse.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - None |P4 - Low Status|NEW |CONFIRMED --- Comment #1 from Richard Brown <rbrown@suse.com> --- This is because we use : as a delimiter where analysing the disk metadata..so the :0 is interpetted as the next field, not as part of the device Either we'll need to rework that functionality, or just filter out all usb- devices so the problem doesn't occur Given the UEFI ESP standard we use is for permenant installations, some UEFI firmwares may not appreciate an Aeon OS disk being removed, so maybe we shouldn't support removable devices Leaving these thoughts here for discussion, not expecting to move on this bug quickly -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225709 https://bugzilla.suse.com/show_bug.cgi?id=1225709#c2 --- Comment #2 from Müller <hotel-brot.0z@icloud.com> --- I understand your thought but maybe people have a windows pc without 2 ssd where they just slap an external ssd in the back that always stays on, then it would also be permanent -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225709 https://bugzilla.suse.com/show_bug.cgi?id=1225709#c4 --- Comment #4 from Müller <hotel-brot.0z@icloud.com> --- a possible solution would be to execute another check in the tik-functions at line 171 which triggers the fallback to unix path (which doesn't contain a :) if the by-id path contains :0 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225709 https://bugzilla.suse.com/show_bug.cgi?id=1225709#c6 --- Comment #6 from Müller <hotel-brot.0z@icloud.com> --- # Fallback to unix device in case by-id does not exist or contains :0 if [[ ! -e "${TIK_INSTALL_DEVICE}" || "${TIK_INSTALL_DEVICE}" == *":0"* ]]; then TIK_INSTALL_DEVICE="/dev/${result}" fi if the code is correct this change is also a solution https://github.com/sysrich/tik/blob/main/usr/lib/tik/lib/tik-functions#L171 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225709 https://bugzilla.suse.com/show_bug.cgi?id=1225709#c7 --- Comment #7 from Müller <hotel-brot.0z@icloud.com> --- if richard confirms that it would work and this solution would be acceptable i could make a PR -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225709 https://bugzilla.suse.com/show_bug.cgi?id=1225709#c8 --- Comment #8 from Müller <hotel-brot.0z@icloud.com> --- i have made a PR so that it is easier to judge what my train of thought is https://github.com/sysrich/tik/pull/24 -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225709 https://bugzilla.suse.com/show_bug.cgi?id=1225709#c9 --- Comment #9 from Müller <hotel-brot.0z@icloud.com> --- oh i don't think that works because the : is not in the variable, right..? sad -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225709 https://bugzilla.suse.com/show_bug.cgi?id=1225709#c10 --- Comment #10 from Müller <hotel-brot.0z@icloud.com> --- i tested it and it gave a pretty interesting result, it more or less worked. it doesn't take the by-id path anymore but a completely wrong other path [/usr/lib/tik/modules/pre/20-mig][20240531-11:24:18][LOG] [STOP] /usr/lib/tik/modules/pre//usr/lib/tik/modules/pre/20-mig [tik][20240531-11:24:18][ERROR] Given device <tt>/dev/usb-Kingston_DataTraveler_3.0_60A44C3FAD9EE791C9291FA8-0:0</tt> does not exist. [tik][20240531-11:25:24][LOG] [zenity][0][] --error --text Given device <tt>/dev/usb-Kingston_DataTraveler_3.0_60A44C3FAD9EE791C9291FA8-0:0</tt> does not exist. [tik][20240531-11:25:24][LOG] [STOP][1] /usr/bin/tik btw: normal disk installations were not destroyed by my code -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225709 https://bugzilla.suse.com/show_bug.cgi?id=1225709#c11 --- Comment #11 from Müller <hotel-brot.0z@icloud.com> --- okayy so the trigger for the fallback works but the fallback doesn't work -- You are receiving this mail because: You are on the CC list for the bug.
https://bugzilla.suse.com/show_bug.cgi?id=1225709 https://bugzilla.suse.com/show_bug.cgi?id=1225709#c12 Martin Abele <happymab.dev@outlook.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|CONFIRMED |RESOLVED --- Comment #12 from Martin Abele <happymab.dev@outlook.com> --- Should be fixed with https://github.com/sysrich/tik/pull/28 -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply＠suse.com