[Bug 1065569] New: yast2-apparmor with incomplete German translation
http://bugzilla.suse.com/show_bug.cgi?id=1065569 Bug ID: 1065569 Summary: yast2-apparmor with incomplete German translation Classification: openSUSE Product: openSUSE Tumbleweed Version: Current Hardware: Other OS: Other Status: NEW Severity: Normal Priority: P5 - None Component: YaST2 Assignee: yast2-maintainers@suse.de Reporter: fkrueger@mailbox.org QA Contact: jsrain@suse.com Found By: --- Blocker: --- Created attachment 746263 --> http://bugzilla.suse.com/attachment.cgi?id=746263&action=edit yast2-apparmor_example_mixed languages Yast2-apparmor-4.0.0-1.2 (TW 20171027) has incomplete German translations with yast2-trans-de installed (see attachment). -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c1
--- Comment #1 from Arvin Schnell
http://bugzilla.suse.com/show_bug.cgi?id=1065569
Arvin Schnell
http://bugzilla.suse.com/show_bug.cgi?id=1065569
Arvin Schnell
http://bugzilla.suse.com/show_bug.cgi?id=1065569
Lukas Ocilka
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c2
Goldwyn Rodrigues
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c3
--- Comment #3 from Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c4
Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=1065569
Goldwyn Rodrigues
http://bugzilla.suse.com/show_bug.cgi?id=1065569
Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c7
--- Comment #7 from Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c8
--- Comment #8 from Goldwyn Rodrigues
Here you can see that your package uses two textdomains:
~/yast-checkout/apparmor> grep -r textdomain src src/include/apparmor/apparmor_ycp_utils.rb: textdomain "yast2-apparmor" src/include/apparmor/config_complain.rb: textdomain "yast2-apparmor" src/include/apparmor/helps.rb: textdomain "yast2-apparmor" src/include/apparmor/aa-config.rb: textdomain "yast2-apparmor" src/include/apparmor/apparmor_profile_check.rb: textdomain "yast2-apparmor" src/include/apparmor/profile_dialogs.rb: textdomain "yast2-apparmor" src/include/apparmor/capabilities.rb: textdomain "yast2-apparmor" src/modules/AppArmorDialogs.rb: textdomain "yast2-apparmor" src/lib/apparmor/genprof.rb: textdomain 'apparmor' src/lib/apparmor/settings.rb: textdomain 'apparmor' src/clients/apparmor.rb: textdomain "yast2-apparmor"
This is not good without knowing what you are doing.
Sorry, I did not know what the keyword is for. Now that I understood it, I will change all of them to consistent "apparmor" to be uniform with the the rest of the yast clients. I assume changing textdomain "yast2-apparmor" to textdomain "apparmor" should be enough. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c9
--- Comment #9 from Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c10
Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c11
--- Comment #11 from Goldwyn Rodrigues
yast-apparmor textdomain fix: https://github.com/yast/yast-apparmor/pull/21
Thanks Stanislav. I had it ready but could not push it because of holidays last week. https://github.com/goldwynr/yast-apparmor/tree/fixes -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c12
Stanislav Brabec
- Update yast-translations package accordingly. Done: https://github.com/yast/yast-translations/commit/cb7e955416ee00f1e6fa56c786f... Package should appear soon.
- Migrate all existing translations to the new translation domain. Done: https://github.com/yast/yast-translations/commit/eede2748a591413f90c1611846b... However there is no common strings between the former yast2-apparmor before split and new apparmor before merge, so all new strings are fuzzy matches only.
- Update configuration of https://l10n.opensuse.org/projects/yast-apparmor/master/ to point to the new translation domain. Done.
- Remove special handling for textdomain starting by "yast2-" from update-tool.sh and weblate-functions.inc from yast-translations/tools. Done: https://github.com/yast/yast-translations/commit/8c559c1c0c8cddcc1d5da1f411f...
- And add the new contents of the yast-apparmor component to the "SUSE Linux Enterprise 15" component list. It will be processed by contracted translators. Done.
-- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c13
--- Comment #13 from Frank Kruger
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c14
Frank Kruger
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c15
Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c17
Stanislav Brabec
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c18
--- Comment #18 from Frank Kruger
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c21
Ladislav Slezák
What I do not know is, how the translations package build in OBS is triggered. Do you know, Ladislav?
As Stanislav commented, for the translation packages we need a bit different approach to avoid flooding OBS with submit requests... For now the packages must be submitted manually. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c22
--- Comment #22 from Frank Kruger
Created attachment 753343 [details] Still mixed languages
Using yast2-trans-de-84.87.20171214.b62b0550c-294.1.noarch from https://download.opensuse.org/repositories/YaST:/Head/openSUSE_Tumbleweed/ almost solves the issue. There is one page still not translated (see attachment).
The issue is solved for Leap 15.0 with yast2-trans-84.87.20180301.762401304, but not for TW which still has version 20180208. Anyway, please feel free to close this bug. -- You are receiving this mail because: You are on the CC list for the bug.
http://bugzilla.suse.com/show_bug.cgi?id=1065569
http://bugzilla.suse.com/show_bug.cgi?id=1065569#c23
Frank Kruger
(In reply to Frank Kruger from comment #18)
Created attachment 753343 [details] Still mixed languages
Using yast2-trans-de-84.87.20171214.b62b0550c-294.1.noarch from https://download.opensuse.org/repositories/YaST:/Head/openSUSE_Tumbleweed/ almost solves the issue. There is one page still not translated (see attachment).
The issue is solved for Leap 15.0 with yast2-trans-84.87.20180301.762401304, but not for TW which still has version 20180208. Anyway, please feel free to close this bug.
With the update to TW20180407 and yast2-trans-de-84.87.20180406.01ef53789 the issue is solved. Closing as fixed. -- You are receiving this mail because: You are on the CC list for the bug.
participants (1)
-
bugzilla_noreply@novell.com