June 2022 - wicked Commits - openSUSE Mailing Lists

[openSUSE/wicked]
by Marius Tomaschewski 24 Jun '22

24 Jun '22

Branch: refs/heads/testing Home: https://github.com/openSUSE/wicked

1 0

[openSUSE/wicked] a9f5ab: xpath-fmt: Fix segfault when formating an empty node
by Marius Tomaschewski 24 Jun '22

24 Jun '22

Branch: refs/heads/master Home: https://github.com/openSUSE/wicked Commit: a9f5ab6ceee79548574572031ed7a36b5880b636 https://github.com/openSUSE/wicked/commit/a9f5ab6ceee79548574572031ed7a36b5… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-06-24 (Fri, 24 Jun 2022) Changed paths: M src/xpath-fmt.c Log Message: ----------- xpath-fmt: Fix segfault when formating an empty node If we try to format an empty node with xpath, we got a segfault in the corresponding printf call, e.g. ``` echo "<foo><bar></bar><foo>" | \ wicked xpath --reference '/foo' '%{bar}' ``` Commit: 2fd8a3f32d260128a25c05ba9001395fbaf8a41d https://github.com/openSUSE/wicked/commit/2fd8a3f32d260128a25c05ba9001395fb… Author: Marius Tomaschewski <mt(a)suse.com> Date: 2022-06-24 (Fri, 24 Jun 2022) Changed paths: M src/xpath-fmt.c Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/919 xpath-fmt: Fix segfault when formating an empty node Compare: https://github.com/openSUSE/wicked/compare/10aaf5c2dc2f...2fd8a3f32d26

1 0

[openSUSE/wicked] b48600: dhcp4: cleanup useless classid availability check
by cfconrad 16 Jun '22

16 Jun '22

Branch: refs/heads/master Home: https://github.com/openSUSE/wicked Commit: b4860037800c0202112648d657ed224e25664124 https://github.com/openSUSE/wicked/commit/b4860037800c0202112648d657ed224e2… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-16 (Thu, 16 Jun 2022) Changed paths: M src/dhcp4/protocol.c Log Message: ----------- dhcp4: cleanup useless classid availability check Commit: b5574ad2a638315bb0c82fb0c00d27b0ccdf3fca https://github.com/openSUSE/wicked/commit/b5574ad2a638315bb0c82fb0c00d27b0c… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-16 (Thu, 16 Jun 2022) Changed paths: M src/leasefile.c Log Message: ----------- leasefile: don't call fclose twice on rename error Commit: b72512fd3e81965dc5bfd8e1c05c9e06c51e4698 https://github.com/openSUSE/wicked/commit/b72512fd3e81965dc5bfd8e1c05c9e06c… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-16 (Thu, 16 Jun 2022) Changed paths: M src/pppd.c Log Message: ----------- pppd: don't fclose twice on rename error Commit: 10aaf5c2dc2fcf1e5e02e90098b1a3feec59a392 https://github.com/openSUSE/wicked/commit/10aaf5c2dc2fcf1e5e02e90098b1a3fee… Author: cfconrad <40127946+cfconrad(a)users.noreply.github.com> Date: 2022-06-16 (Thu, 16 Jun 2022) Changed paths: M src/dhcp4/protocol.c M src/leasefile.c M src/pppd.c Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/918 cleanup: don't fclose twice on rename error Compare: https://github.com/openSUSE/wicked/compare/c02538e53398...10aaf5c2dc2f

1 0

[openSUSE/wicked] 252889: testing/wunit: Add prefix to TESTCASE() generated ...
by Marius Tomaschewski 15 Jun '22

15 Jun '22

Branch: refs/heads/master Home: https://github.com/openSUSE/wicked Commit: 2528892ac1986870ad891f32350c6532ca773cb5 https://github.com/openSUSE/wicked/commit/2528892ac1986870ad891f32350c6532c… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-06-08 (Wed, 08 Jun 2022) Changed paths: M testing/wunit.h Log Message: ----------- testing/wunit: Add prefix to TESTCASE() generated functions Commit: 272a88b5392fc75a9d0fb1671d38a12d447fed2d https://github.com/openSUSE/wicked/commit/272a88b5392fc75a9d0fb1671d38a12d4… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-06-09 (Thu, 09 Jun 2022) Changed paths: M include/wicked/util.h M src/util.c Log Message: ----------- util: Add bitmask utility functions Commit: f3ce38bb201022e055149c08733903ee1018125f https://github.com/openSUSE/wicked/commit/f3ce38bb201022e055149c08733903ee1… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-06-09 (Thu, 09 Jun 2022) Changed paths: M testing/Makefile.am A testing/bitmask-test.c Log Message: ----------- testing: Add tests for bitmask utility functions Commit: 89f58074d16d659d7ac5666a86b26d01d25a4b63 https://github.com/openSUSE/wicked/commit/89f58074d16d659d7ac5666a86b26d01d… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-06-09 (Thu, 09 Jun 2022) Changed paths: M testing/Makefile.am M testing/bitmap-test.c Log Message: ----------- testing: Transform bitmap-test.c to unittest Commit: c02538e5339877659844321ec05c9ffab8444392 https://github.com/openSUSE/wicked/commit/c02538e5339877659844321ec05c9ffab… Author: Marius Tomaschewski <mt(a)suse.com> Date: 2022-06-15 (Wed, 15 Jun 2022) Changed paths: M include/wicked/util.h M src/util.c M testing/Makefile.am M testing/bitmap-test.c A testing/bitmask-test.c M testing/wunit.h Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/917 util: Add bitmask utility functions Compare: https://github.com/openSUSE/wicked/compare/cff372a7b770...c02538e53398

1 0

[openSUSE/wicked] 36febb: refcount: add reference couting utilility macros
by cfconrad 02 Jun '22

02 Jun '22

Branch: refs/heads/master Home: https://github.com/openSUSE/wicked Commit: 36febb320f6c3ec054571c0f292b72cb772b6d0c https://github.com/openSUSE/wicked/commit/36febb320f6c3ec054571c0f292b72cb7… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M include/Makefile.am A include/wicked/refcount.h M src/Makefile.am A src/refcount.c Log Message: ----------- refcount: add reference couting utilility macros Co-authored-by: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Commit: 61e2168d9dbf452a244d15502cd3c9c0a08e7869 https://github.com/openSUSE/wicked/commit/61e2168d9dbf452a244d15502cd3c9c0a… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M client/suse/compat-suse.c M include/wicked/route.h M src/route.c Log Message: ----------- route: adjust routes and rules to refcount macros Added also rule array and route tables copy utils. Commit: 6dd62ea9b27d0381cea7f9daa2711e1458907383 https://github.com/openSUSE/wicked/commit/6dd62ea9b27d0381cea7f9daa2711e145… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M autoip4/fsm.c M client/dracut/cmdline.c M client/redhat/compat-redhat.c M client/suse/compat-suse.c M include/wicked/address.h M src/address.c M src/auto6.c M src/dbus-objects/misc.c M src/dhcp4/protocol.c M src/dhcp6/protocol.c M src/iflist.c M src/leasefile.c Log Message: ----------- address: adjust address to use new refcount macros Renamed address_new to address_create like in route, added also an ni_address_list_copy utility function. Commit: 5291d16c0cae287ce1e20fa59efd7e5dd1c8f914 https://github.com/openSUSE/wicked/commit/5291d16c0cae287ce1e20fa59efd7e5dd… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M include/wicked/addrconf.h M include/wicked/nis.h M include/wicked/resolver.h M src/dhcp.c M src/dhcp.h M src/netinfo.c M src/nis.c M src/resolver.c M src/state.c Log Message: ----------- lease: add clone utils and reference counting Commit: cff372a7b770e571da8af7e811103b483777c05b https://github.com/openSUSE/wicked/commit/cff372a7b770e571da8af7e811103b483… Author: cfconrad <40127946+cfconrad(a)users.noreply.github.com> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M autoip4/fsm.c M client/dracut/cmdline.c M client/redhat/compat-redhat.c M client/suse/compat-suse.c M include/Makefile.am M include/wicked/addrconf.h M include/wicked/address.h M include/wicked/nis.h A include/wicked/refcount.h M include/wicked/resolver.h M include/wicked/route.h M src/Makefile.am M src/address.c M src/auto6.c M src/dbus-objects/misc.c M src/dhcp.c M src/dhcp.h M src/dhcp4/protocol.c M src/dhcp6/protocol.c M src/iflist.c M src/leasefile.c M src/netinfo.c M src/nis.c A src/refcount.c M src/resolver.c M src/route.c M src/state.c Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/916 lease: add clone utils and reference counting Compare: https://github.com/openSUSE/wicked/compare/cd308dc6a8cb...cff372a7b770

1 0

[openSUSE/wicked] 36febb: refcount: add reference couting utilility macros
by Marius Tomaschewski 02 Jun '22

02 Jun '22

Branch: refs/heads/testing Home: https://github.com/openSUSE/wicked Commit: 36febb320f6c3ec054571c0f292b72cb772b6d0c https://github.com/openSUSE/wicked/commit/36febb320f6c3ec054571c0f292b72cb7… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M include/Makefile.am A include/wicked/refcount.h M src/Makefile.am A src/refcount.c Log Message: ----------- refcount: add reference couting utilility macros Co-authored-by: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Commit: 61e2168d9dbf452a244d15502cd3c9c0a08e7869 https://github.com/openSUSE/wicked/commit/61e2168d9dbf452a244d15502cd3c9c0a… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M client/suse/compat-suse.c M include/wicked/route.h M src/route.c Log Message: ----------- route: adjust routes and rules to refcount macros Added also rule array and route tables copy utils. Commit: 6dd62ea9b27d0381cea7f9daa2711e1458907383 https://github.com/openSUSE/wicked/commit/6dd62ea9b27d0381cea7f9daa2711e145… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M autoip4/fsm.c M client/dracut/cmdline.c M client/redhat/compat-redhat.c M client/suse/compat-suse.c M include/wicked/address.h M src/address.c M src/auto6.c M src/dbus-objects/misc.c M src/dhcp4/protocol.c M src/dhcp6/protocol.c M src/iflist.c M src/leasefile.c Log Message: ----------- address: adjust address to use new refcount macros Renamed address_new to address_create like in route, added also an ni_address_list_copy utility function. Commit: 5291d16c0cae287ce1e20fa59efd7e5dd1c8f914 https://github.com/openSUSE/wicked/commit/5291d16c0cae287ce1e20fa59efd7e5dd… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M include/wicked/addrconf.h M include/wicked/nis.h M include/wicked/resolver.h M src/dhcp.c M src/dhcp.h M src/netinfo.c M src/nis.c M src/resolver.c M src/state.c Log Message: ----------- lease: add clone utils and reference counting Commit: 81f68a369377c74e7d47e6b561072ce3ff66637b https://github.com/openSUSE/wicked/commit/81f68a369377c74e7d47e6b561072ce3f… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M autoip4/fsm.c M client/dracut/cmdline.c M client/redhat/compat-redhat.c M client/suse/compat-suse.c M include/Makefile.am M include/wicked/addrconf.h M include/wicked/address.h M include/wicked/nis.h A include/wicked/refcount.h M include/wicked/resolver.h M include/wicked/route.h M src/Makefile.am M src/address.c M src/auto6.c M src/dbus-objects/misc.c M src/dhcp.c M src/dhcp.h M src/dhcp4/protocol.c M src/dhcp6/protocol.c M src/iflist.c M src/leasefile.c M src/netinfo.c M src/nis.c A src/refcount.c M src/resolver.c M src/route.c M src/state.c Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/916 lease: add clone utils and reference counting Compare: https://github.com/openSUSE/wicked/compare/0011fba29afb...81f68a369377

1 0

[openSUSE/wicked] 375d3f: Update include/wicked/refcount.h
by Marius Tomaschewski 02 Jun '22

02 Jun '22

Branch: refs/heads/testing Home: https://github.com/openSUSE/wicked Commit: 375d3f92c918b05d9193ba5d19ed57ce71e32895 https://github.com/openSUSE/wicked/commit/375d3f92c918b05d9193ba5d19ed57ce7… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M include/wicked/refcount.h Log Message: ----------- Update include/wicked/refcount.h Co-authored-by: cfconrad <40127946+cfconrad(a)users.noreply.github.com> Commit: 0011fba29afbeef08bca4dfbe023a4f9ea1197b0 https://github.com/openSUSE/wicked/commit/0011fba29afbeef08bca4dfbe023a4f9e… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-02 (Thu, 02 Jun 2022) Changed paths: M autoip4/fsm.c M client/dracut/cmdline.c M client/redhat/compat-redhat.c M client/suse/compat-suse.c M include/Makefile.am M include/wicked/addrconf.h M include/wicked/address.h M include/wicked/nis.h A include/wicked/refcount.h M include/wicked/resolver.h M include/wicked/route.h M src/Makefile.am M src/address.c M src/auto6.c M src/dbus-objects/misc.c M src/dhcp.c M src/dhcp.h M src/dhcp4/protocol.c M src/dhcp6/protocol.c M src/iflist.c M src/leasefile.c M src/netinfo.c M src/nis.c A src/refcount.c M src/resolver.c M src/route.c M src/state.c Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/916 lease: add clone utils and reference counting Compare: https://github.com/openSUSE/wicked/compare/eb298a9bec68...0011fba29afb

1 0

[openSUSE/wicked] 55c773: Remove systemd-udev-settle
by Marius Tomaschewski 01 Jun '22

01 Jun '22

Branch: refs/heads/testing Home: https://github.com/openSUSE/wicked Commit: 55c773b20ea615a7ed96935fef735028eaa6e605 https://github.com/openSUSE/wicked/commit/55c773b20ea615a7ed96935fef735028e… Author: madanyang <madanyang(a)users.noreply.github.com> Date: 2021-03-15 (Mon, 15 Mar 2021) Changed paths: M etc/systemd/wickedd.service.in Log Message: ----------- Remove systemd-udev-settle According to udevadm systemd-udev-settle.service is deprecated. Hence removed from Wants and and After Commit: 7562a598b29026f27637244411595c6968daede6 https://github.com/openSUSE/wicked/commit/7562a598b29026f27637244411595c696… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-05-04 (Wed, 04 May 2022) Changed paths: M src/ifevent.c Log Message: ----------- ifevent: always close old rtnl event sock on restart The used `ni_socket_release()`, while restart on rtnetlink event errors, didn't closed and deactivated/removed the obsolete socket from poll processing immediately. This caused further restarts and finally an assertion due to incorrect reference count (bsc#1192508). Commit: b3a07a520c58b2db34dccb398ef9d770b6f41409 https://github.com/openSUSE/wicked/commit/b3a07a520c58b2db34dccb398ef9d770b… Author: Marius Tomaschewski <mt(a)suse.com> Date: 2022-05-11 (Wed, 11 May 2022) Changed paths: M etc/systemd/wickedd.service.in Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/864 service: remove systemd-udev-settle dependency from wickedd.service Commit: 8339f6f897a61558cd43c241a1c451a0e1445894 https://github.com/openSUSE/wicked/commit/8339f6f897a61558cd43c241a1c451a0e… Author: Marius Tomaschewski <mt(a)suse.com> Date: 2022-05-11 (Wed, 11 May 2022) Changed paths: M src/ifevent.c Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/912 ifevent: always close old rtnl event sock on restart (bsc#1192508) The used ni_socket_release(), while restart on rtnetlink event errors, didn't closed and deactivated/removed the obsolete socket from poll processing immediately. This caused further restarts and finally an assertion due to incorrect reference count. Commit: df563d56454f9c5629d7fd5a252a38ba55a7f605 https://github.com/openSUSE/wicked/commit/df563d56454f9c5629d7fd5a252a38ba5… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M include/wicked/dbus.h M src/dbus-xml.c Log Message: ----------- dbus-xml: expose get_argument_type, add _name utility Commit: d982c97923764852cfde4aa6aaf8b34291b17bf2 https://github.com/openSUSE/wicked/commit/d982c97923764852cfde4aa6aaf8b3429… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M dhcp4/dbus-api.c M dhcp6/dbus-api.c M schema/addrconf.xml M src/dbus-objects/addrconf.c M src/dhcp4/device.c M src/dhcp4/dhcp4.h M src/dhcp6/device.c M src/dhcp6/dhcp6.h Log Message: ----------- dbus: add options dict argument to dhcp dropLease() Commit: ecaccd4abfc441acb1c68a585833982d70ab412a https://github.com/openSUSE/wicked/commit/ecaccd4abfc441acb1c68a585833982d7… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-05-13 (Fri, 13 May 2022) Changed paths: M include/wicked/fsm.h M src/fsm.c Log Message: ----------- fsm: pass transition arguments to method arguments Commit: d4182568210daa4f94d3bff1838c32e67f49e364 https://github.com/openSUSE/wicked/commit/d4182568210daa4f94d3bff1838c32e67… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-05-17 (Tue, 17 May 2022) Changed paths: M src/dbus-object.c Log Message: ----------- dbus: Fix common dbus string_array handling We missed the cleanup of the old value. This lead into orphan entries in our local datastructure. It was detected when debugging BSS info on wireless. If I kept the same SSID/BSSID, but changed pairwise or key management settings, the old values where still displayed. Because the dbus object just get updated. Commit: bf4d9197dbd32ed0bd14a89912673d1010f071ec https://github.com/openSUSE/wicked/commit/bf4d9197dbd32ed0bd14a89912673d101… Author: Marius Tomaschewski <mt(a)suse.com> Date: 2022-05-18 (Wed, 18 May 2022) Changed paths: M src/dbus-object.c Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/913 dbus: Fix common dbus string_array handling Commit: 44cf8531fdae2494f820cfe54b716910459dacdd https://github.com/openSUSE/wicked/commit/44cf8531fdae2494f820cfe54b7169104… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M client/ifdown.c M client/ifreload.c M client/ifup.c M client/suse/scripts/ifup.in M man/ifup.8.in M man/wicked.8.in Log Message: ----------- client: add --[no-]release option to ifdown/ifreload Commit: f3c1888233dfb06c56b9471edc1bb537c161ef56 https://github.com/openSUSE/wicked/commit/f3c1888233dfb06c56b9471edc1bb537c… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-05-20 (Fri, 20 May 2022) Changed paths: M include/Makefile.am A include/wicked/refcount.h M src/Makefile.am A src/refcount.c Log Message: ----------- refcount: add reference couting utilility macros Commit: be181b1db799665761bfbc45f769994a0f7d3dfa https://github.com/openSUSE/wicked/commit/be181b1db799665761bfbc45f769994a0… Author: cfconrad <40127946+cfconrad(a)users.noreply.github.com> Date: 2022-05-23 (Mon, 23 May 2022) Changed paths: M client/ifdown.c M client/ifreload.c M client/ifup.c M client/suse/scripts/ifup.in M dhcp4/dbus-api.c M dhcp6/dbus-api.c M include/wicked/dbus.h M include/wicked/fsm.h M man/ifup.8.in M man/wicked.8.in M schema/addrconf.xml M src/dbus-objects/addrconf.c M src/dbus-xml.c M src/dhcp4/device.c M src/dhcp4/dhcp4.h M src/dhcp6/device.c M src/dhcp6/dhcp6.h M src/fsm.c Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/915 client: add --[no-]release option to ifdown/ifreload (jsc#SLE-10249) Commit: 58364c8d20047e7150f97b04e803e12a70340241 https://github.com/openSUSE/wicked/commit/58364c8d20047e7150f97b04e803e12a7… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M src/dbus-connection.c Log Message: ----------- dbus-connection: Add missing ni_socket_release() calls When ever we do not care of a ni_socket_t object, we need to call the ni_socket_release(), otherwise the reference will kept forever. Commit: e342acd09997bca1f7abbde96d9612afdffd45ea https://github.com/openSUSE/wicked/commit/e342acd09997bca1f7abbde96d9612afd… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M client/suse/compat-suse.c M include/wicked/route.h M src/route.c Log Message: ----------- route: adjust routes and rules to refcount macros Added also rule array and route tables copy utils. Commit: ecf6cbb045ff15db6d2609f3cb27bb34e4df42d6 https://github.com/openSUSE/wicked/commit/ecf6cbb045ff15db6d2609f3cb27bb34e… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M autoip4/fsm.c M client/dracut/cmdline.c M client/redhat/compat-redhat.c M client/suse/compat-suse.c M include/wicked/address.h M src/address.c M src/auto6.c M src/dbus-objects/misc.c M src/dhcp4/protocol.c M src/dhcp6/protocol.c M src/iflist.c M src/leasefile.c Log Message: ----------- address: adjust address to use new refcount macros Renamed address_new to address_create like in route, added also an ni_address_list_copy utility function. Commit: 6e82e77b225ff30271a7fa9c689a988aac0f9e49 https://github.com/openSUSE/wicked/commit/6e82e77b225ff30271a7fa9c689a988aa… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M include/wicked/addrconf.h M include/wicked/nis.h M include/wicked/resolver.h M src/dhcp.c M src/dhcp.h M src/netinfo.c M src/nis.c M src/resolver.c M src/state.c Log Message: ----------- lease: add clone utils and reference counting Commit: 9e7b5059e1f729447eeb3366d13bd7f0e36083b5 https://github.com/openSUSE/wicked/commit/9e7b5059e1f729447eeb3366d13bd7f0e… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M src/socket.c Log Message: ----------- socket: Fix concurrent manipulation of static socket array In ni_socket_array_wait() we should not manipulating the same array what we use for iteration. The static socket array __ni_sockets should not be used for iteration, as we might manipulate the array via ni_socket_close() from other modules. Commit: df32481abd443b58caddaf3969e9cfab40caeeef https://github.com/openSUSE/wicked/commit/df32481abd443b58caddaf3969e9cfab4… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M src/socket.c Log Message: ----------- socket: Do not call close() callback twice The close() callback was called unconditional, thus it got called even if the file descriptor is already unset. Commit: afc02733993e959f4769888cf56bee9de1668c2e https://github.com/openSUSE/wicked/commit/afc02733993e959f4769888cf56bee9de… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M src/socket.c Log Message: ----------- socket: Assert early when releasing a active socket If a `ni_socket_release()` is called with a refcount equal to `1`, we hit a assert in a recursive call of ni_socket_release(). Simply check that no one call `ni_socket_release()` on the last reference, while the socket is still active! Commit: dde20d8eef14371b93392db90202644b3d1bd824 https://github.com/openSUSE/wicked/commit/dde20d8eef14371b93392db90202644b3… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M .gitignore M testing/Makefile.am A testing/socket-mock-test.c A testing/wunit.h Log Message: ----------- Add unit-test for src/socket.c Cover upcoming regressions and check for issues in corner cases which failed in old implementation. Commit: cd308dc6a8cb4d22f40498529e74484ddec7c0ce https://github.com/openSUSE/wicked/commit/cd308dc6a8cb4d22f40498529e74484dd… Author: Marius Tomaschewski <mt(a)suse.com> Date: 2022-06-01 (Wed, 01 Jun 2022) Changed paths: M .gitignore M src/dbus-connection.c M src/socket.c M testing/Makefile.am A testing/socket-mock-test.c A testing/wunit.h Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/914 socket.c improvements and unit tests Commit: eb298a9bec683b6d2fb16ce09b947472936e9e22 https://github.com/openSUSE/wicked/commit/eb298a9bec683b6d2fb16ce09b9474729… Author: Marius Tomaschewski <mt(a)suse.de> Date: 2022-06-01 (Wed, 01 Jun 2022) Changed paths: M autoip4/fsm.c M client/dracut/cmdline.c M client/redhat/compat-redhat.c M client/suse/compat-suse.c M include/Makefile.am M include/wicked/addrconf.h M include/wicked/address.h M include/wicked/nis.h A include/wicked/refcount.h M include/wicked/resolver.h M include/wicked/route.h M src/Makefile.am M src/address.c M src/auto6.c M src/dbus-objects/misc.c M src/dhcp.c M src/dhcp.h M src/dhcp4/protocol.c M src/dhcp6/protocol.c M src/iflist.c M src/leasefile.c M src/netinfo.c M src/nis.c A src/refcount.c M src/resolver.c M src/route.c M src/state.c Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/916 lease: add clone utils and reference counting Compare: https://github.com/openSUSE/wicked/compare/885ace85a2e7...eb298a9bec68

1 0

[openSUSE/wicked] 58364c: dbus-connection: Add missing ni_socket_release() c...
by Marius Tomaschewski 01 Jun '22

01 Jun '22

Branch: refs/heads/master Home: https://github.com/openSUSE/wicked Commit: 58364c8d20047e7150f97b04e803e12a70340241 https://github.com/openSUSE/wicked/commit/58364c8d20047e7150f97b04e803e12a7… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M src/dbus-connection.c Log Message: ----------- dbus-connection: Add missing ni_socket_release() calls When ever we do not care of a ni_socket_t object, we need to call the ni_socket_release(), otherwise the reference will kept forever. Commit: 9e7b5059e1f729447eeb3366d13bd7f0e36083b5 https://github.com/openSUSE/wicked/commit/9e7b5059e1f729447eeb3366d13bd7f0e… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M src/socket.c Log Message: ----------- socket: Fix concurrent manipulation of static socket array In ni_socket_array_wait() we should not manipulating the same array what we use for iteration. The static socket array __ni_sockets should not be used for iteration, as we might manipulate the array via ni_socket_close() from other modules. Commit: df32481abd443b58caddaf3969e9cfab40caeeef https://github.com/openSUSE/wicked/commit/df32481abd443b58caddaf3969e9cfab4… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M src/socket.c Log Message: ----------- socket: Do not call close() callback twice The close() callback was called unconditional, thus it got called even if the file descriptor is already unset. Commit: afc02733993e959f4769888cf56bee9de1668c2e https://github.com/openSUSE/wicked/commit/afc02733993e959f4769888cf56bee9de… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M src/socket.c Log Message: ----------- socket: Assert early when releasing a active socket If a `ni_socket_release()` is called with a refcount equal to `1`, we hit a assert in a recursive call of ni_socket_release(). Simply check that no one call `ni_socket_release()` on the last reference, while the socket is still active! Commit: dde20d8eef14371b93392db90202644b3d1bd824 https://github.com/openSUSE/wicked/commit/dde20d8eef14371b93392db90202644b3… Author: Clemens Famulla-Conrad <cfamullaconrad(a)suse.de> Date: 2022-05-30 (Mon, 30 May 2022) Changed paths: M .gitignore M testing/Makefile.am A testing/socket-mock-test.c A testing/wunit.h Log Message: ----------- Add unit-test for src/socket.c Cover upcoming regressions and check for issues in corner cases which failed in old implementation. Commit: cd308dc6a8cb4d22f40498529e74484ddec7c0ce https://github.com/openSUSE/wicked/commit/cd308dc6a8cb4d22f40498529e74484dd… Author: Marius Tomaschewski <mt(a)suse.com> Date: 2022-06-01 (Wed, 01 Jun 2022) Changed paths: M .gitignore M src/dbus-connection.c M src/socket.c M testing/Makefile.am A testing/socket-mock-test.c A testing/wunit.h Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/914 socket.c improvements and unit tests Compare: https://github.com/openSUSE/wicked/compare/be181b1db799...cd308dc6a8cb

1 0