Branch: refs/heads/master Home: https://github.com/openSUSE/wicked Commit: 58364c8d20047e7150f97b04e803e12a70340241 https://github.com/openSUSE/wicked/commit/58364c8d20047e7150f97b04e803e12a70... Author: Clemens Famulla-Conrad cfamullaconrad@suse.de Date: 2022-05-30 (Mon, 30 May 2022)

Changed paths: M src/dbus-connection.c

Log Message: ----------- dbus-connection: Add missing ni_socket_release() calls

When ever we do not care of a ni_socket_t object, we need to call the ni_socket_release(), otherwise the reference will kept forever.

Commit: 9e7b5059e1f729447eeb3366d13bd7f0e36083b5 https://github.com/openSUSE/wicked/commit/9e7b5059e1f729447eeb3366d13bd7f0e3... Author: Clemens Famulla-Conrad cfamullaconrad@suse.de Date: 2022-05-30 (Mon, 30 May 2022)

Changed paths: M src/socket.c

Log Message: ----------- socket: Fix concurrent manipulation of static socket array

In ni_socket_array_wait() we should not manipulating the same array what we use for iteration. The static socket array __ni_sockets should not be used for iteration, as we might manipulate the array via ni_socket_close() from other modules.

Commit: df32481abd443b58caddaf3969e9cfab40caeeef https://github.com/openSUSE/wicked/commit/df32481abd443b58caddaf3969e9cfab40... Author: Clemens Famulla-Conrad cfamullaconrad@suse.de Date: 2022-05-30 (Mon, 30 May 2022)

Changed paths: M src/socket.c

Log Message: ----------- socket: Do not call close() callback twice

The close() callback was called unconditional, thus it got called even if the file descriptor is already unset.

Commit: afc02733993e959f4769888cf56bee9de1668c2e https://github.com/openSUSE/wicked/commit/afc02733993e959f4769888cf56bee9de1... Author: Clemens Famulla-Conrad cfamullaconrad@suse.de Date: 2022-05-30 (Mon, 30 May 2022)

Changed paths: M src/socket.c

Log Message: ----------- socket: Assert early when releasing a active socket

If a `ni_socket_release()` is called with a refcount equal to `1`, we hit a assert in a recursive call of ni_socket_release().

Simply check that no one call `ni_socket_release()` on the last reference, while the socket is still active!

Commit: dde20d8eef14371b93392db90202644b3d1bd824 https://github.com/openSUSE/wicked/commit/dde20d8eef14371b93392db90202644b3d... Author: Clemens Famulla-Conrad cfamullaconrad@suse.de Date: 2022-05-30 (Mon, 30 May 2022)

Changed paths: M .gitignore M testing/Makefile.am A testing/socket-mock-test.c A testing/wunit.h

Log Message: ----------- Add unit-test for src/socket.c

Cover upcoming regressions and check for issues in corner cases which failed in old implementation.

Commit: cd308dc6a8cb4d22f40498529e74484ddec7c0ce https://github.com/openSUSE/wicked/commit/cd308dc6a8cb4d22f40498529e74484dde... Author: Marius Tomaschewski mt@suse.com Date: 2022-06-01 (Wed, 01 Jun 2022)

Changed paths: M .gitignore M src/dbus-connection.c M src/socket.c M testing/Makefile.am A testing/socket-mock-test.c A testing/wunit.h

Log Message: ----------- Merge pull request https://github.com/openSUSE/wicked/pull/914

socket.c improvements and unit tests

Compare: https://github.com/openSUSE/wicked/compare/be181b1db799...cd308dc6a8cb