Bueller? Bueller? (I'd really like some feedback before I push this out as an online update) Will On Thursday 29 July 2010 14:15:16 Will Stephenson wrote:
Nailed https://bugs.kde.org/show_bug.cgi?id=245606: when a file is dropped on the desktop, its mimetype is evaluated to see what widgets or wallpaper plugins can be activated to handle it. When it is a wallpaper, the plugin expects two arguments: the URL to display (of the file) and the rendering mode to use. The rendering mode passed is an empty string, which according to the API means use the default mode. However in the implementation of the Image wallpaper plugin[1], which has two modes, Single Image and Slideshow, all the logic is based on a positive test for Single Image - any other value (eg an empty string) falls back to SlideShow.
I have added a test patch to the openSUSE kdebase4-workspace KDE:Distro:Stable packages that treats an empty string rendering mode in the Image wallpaper as Single Image, but I am going to pursue a proper fix in the Wallpaper base class on plasma-devel@ before closing the bug.
Please test the fix.
Dotan, the bug manifests whenever dropping an image onto the desktop and the current wallpaper mode is not Image or Slideshow.
Will
[1] http://websvn.kde.org/branches/KDE/4.4/kdebase/workspace/plasma/generic/wal l papers/image/image.cpp?view=markup
-- Will Stephenson, KDE Developer, openSUSE Boosters Team SUSE LINUX Products GmbH - Nürnberg - AG Nürnberg - HRB 16746 - GF: Markus Rex
-- Will Stephenson, KDE Developer, openSUSE Boosters Team SUSE LINUX Products GmbH - Nürnberg - AG Nürnberg - HRB 16746 - GF: Markus Rex -- To unsubscribe, e-mail: opensuse+unsubscribe@opensuse.org For additional commands, e-mail: opensuse+help@opensuse.org